Repository navigation
[backport core/1.54] test: cover mouse-driven autogrow reference alignment - #18369
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
🎭 Playwright: ✅ 1949 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-24T01:17:03.037Z",
"gitSha": "1dbbff7d00e1a2a2d64ebb66916ee980592bf91d",
"branch": "backport-18101-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2025.5510000000072,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.717,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.041,
"heapDeltaBytes": 614208,
"heapUsedBytes": 70391216,
"domNodes": -279,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.481999999999999,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2018.7459999999646,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.213999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.96500000000003,
"heapDeltaBytes": -11976232,
"heapUsedBytes": 58400892,
"domNodes": -277,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 7.65,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1723.117000000002,
"styleRecalcs": 73,
"styleRecalcDurationMs": 18.726,
"layouts": 14,
"layoutDurationMs": 2.731,
"taskDurationMs": 718.02,
"heapDeltaBytes": -3823636,
"heapUsedBytes": 67115828,
"domNodes": -277,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 111.95700000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1719.206999999983,
"styleRecalcs": 74,
"styleRecalcDurationMs": 17.223000000000003,
"layouts": 14,
"layoutDurationMs": 2.363,
"taskDurationMs": 616.193,
"heapDeltaBytes": 9336592,
"heapUsedBytes": 80223708,
"domNodes": -277,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 94.319,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.542999999987,
"styleRecalcs": 31,
"styleRecalcDurationMs": 11.328,
"layouts": 6,
"layoutDurationMs": 1.035,
"taskDurationMs": 288.023,
"heapDeltaBytes": 4633008,
"heapUsedBytes": 75522600,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.530999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1658.331999999973,
"styleRecalcs": 31,
"styleRecalcDurationMs": 11.861999999999998,
"layouts": 6,
"layoutDurationMs": 0.893,
"taskDurationMs": 289.95400000000006,
"heapDeltaBytes": 4371128,
"heapUsedBytes": 74932868,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.018999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 515.2820000000133,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.544,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 323.78499999999997,
"heapDeltaBytes": -7827672,
"heapUsedBytes": 63139028,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 106.53399999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 522.3979999999528,
"styleRecalcs": 13,
"styleRecalcDurationMs": 5.824,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 323.954,
"heapDeltaBytes": -7897004,
"heapUsedBytes": 62917680,
"domNodes": 22,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 106.99,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2022.104000000013,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.490999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.04799999999994,
"heapDeltaBytes": -16264016,
"heapUsedBytes": 87079396,
"domNodes": -263,
"jsHeapTotalBytes": -1114112,
"scriptDurationMs": 26.868999999999996,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2011.5979999999354,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.192999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.45900000000006,
"heapDeltaBytes": 5084504,
"heapUsedBytes": 81688272,
"domNodes": -282,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 25.602,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2082.841999999971,
"styleRecalcs": 66,
"styleRecalcDurationMs": 6.5749999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1188.4589999999998,
"heapDeltaBytes": 18992636,
"heapUsedBytes": 85213528,
"domNodes": 8,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 583.976,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2103.0739999999923,
"styleRecalcs": 65,
"styleRecalcDurationMs": 6.541999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1155.979,
"heapDeltaBytes": 17010712,
"heapUsedBytes": 83624284,
"domNodes": 6,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 555.017,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3080.5970000000116,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.750000000000002,
"layouts": 60,
"layoutDurationMs": 8.536999999999999,
"taskDurationMs": 1251.6349999999998,
"heapDeltaBytes": -2775532,
"heapUsedBytes": 75440480,
"domNodes": -268,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 517.004,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3184.4209999999293,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.959,
"layouts": 60,
"layoutDurationMs": 9.718000000000002,
"taskDurationMs": 1303.124,
"heapDeltaBytes": -7196472,
"heapUsedBytes": 71856988,
"domNodes": -291,
"jsHeapTotalBytes": 3305472,
"scriptDurationMs": 533.029,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2134.014000000036,
"styleRecalcs": 42,
"styleRecalcDurationMs": 3.8549999999999973,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1311.985,
"heapDeltaBytes": 14392920,
"heapUsedBytes": 84683880,
"domNodes": 4,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 634.833,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2085.382999999979,
"styleRecalcs": 42,
"styleRecalcDurationMs": 3.735000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1301.462,
"heapDeltaBytes": 13666048,
"heapUsedBytes": 81832696,
"domNodes": 4,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 615.7210000000001,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2036.1610000000496,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.67,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 512.9299999999998,
"heapDeltaBytes": 5911404,
"heapUsedBytes": 83367128,
"domNodes": -274,
"jsHeapTotalBytes": -2461696,
"scriptDurationMs": 26.570000000000004,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2023.5870000000205,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.841999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.4799999999999,
"heapDeltaBytes": -11012144,
"heapUsedBytes": 66152456,
"domNodes": -285,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 31.322999999999997,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 511.39599999999064,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.943,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 298.908,
"heapDeltaBytes": 13669232,
"heapUsedBytes": 86418872,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 96.064,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 512.9000000000588,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.875999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 301.527,
"heapDeltaBytes": 14705216,
"heapUsedBytes": 87962096,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 97.95,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.8300000000036,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.801,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.05600000000004,
"heapDeltaBytes": -13384732,
"heapUsedBytes": 59778660,
"domNodes": -298,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.501999999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2038.962999999967,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.5009999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.773,
"heapDeltaBytes": -10682580,
"heapUsedBytes": 61295760,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.587000000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.0389999999793,
"styleRecalcs": 77,
"styleRecalcDurationMs": 16.58,
"layouts": 18,
"layoutDurationMs": 2.656,
"taskDurationMs": 589.3230000000001,
"heapDeltaBytes": -9290744,
"heapUsedBytes": 63154276,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 65.137,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.5789999999997,
"styleRecalcs": 77,
"styleRecalcDurationMs": 18.676000000000002,
"layouts": 18,
"layoutDurationMs": 3.377,
"taskDurationMs": 604.3689999999999,
"heapDeltaBytes": 10038164,
"heapUsedBytes": 82277380,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 70.63,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 916.0980000000336,
"styleRecalcs": 21,
"styleRecalcDurationMs": 23.390000000000008,
"layouts": 17,
"layoutDurationMs": 10.217,
"taskDurationMs": 700.7520000000001,
"heapDeltaBytes": 21893048,
"heapUsedBytes": 106009500,
"domNodes": 13751,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 20.677999999999994,
"eventListeners": 2385,
"totalBlockingTimeMs": 112,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8127.837999999997,
"styleRecalcs": 248,
"styleRecalcDurationMs": 21.868000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4203.147000000001,
"heapDeltaBytes": 13167600,
"heapUsedBytes": 89657968,
"domNodes": -270,
"jsHeapTotalBytes": 647168,
"scriptDurationMs": 1851.207,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8214.604000000008,
"styleRecalcs": 250,
"styleRecalcDurationMs": 24.133000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4200.044999999999,
"heapDeltaBytes": 9174540,
"heapUsedBytes": 85230052,
"domNodes": -265,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 1835.0620000000001,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12058.013999999957,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11022.173,
"heapDeltaBytes": -30209852,
"heapUsedBytes": 178113856,
"domNodes": -8068,
"jsHeapTotalBytes": -14614528,
"scriptDurationMs": 177.751,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 11227.522000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10589.865,
"heapDeltaBytes": -58418724,
"heapUsedBytes": 177600884,
"domNodes": -8068,
"jsHeapTotalBytes": -20361216,
"scriptDurationMs": 162.44400000000002,
"eventListeners": -14937,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14776.605000000018,
"styleRecalcs": 70,
"styleRecalcDurationMs": 12.534999999999991,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14078.161999999998,
"heapDeltaBytes": -28655388,
"heapUsedBytes": 189103232,
"domNodes": -8072,
"jsHeapTotalBytes": -15798272,
"scriptDurationMs": 712.515,
"eventListeners": -14931,
"totalBlockingTimeMs": 48,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14101.767999999993,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.86000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13504.550000000001,
"heapDeltaBytes": -55918408,
"heapUsedBytes": 161266544,
"domNodes": -8068,
"jsHeapTotalBytes": -16248832,
"scriptDurationMs": 742.9879999999999,
"eventListeners": -14933,
"totalBlockingTimeMs": 94,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4065.969999999993,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.10499999999997,
"layouts": 20,
"layoutDurationMs": 19.368999999999996,
"taskDurationMs": 3899.896000000001,
"heapDeltaBytes": -39535124,
"heapUsedBytes": 177841048,
"domNodes": -8068,
"jsHeapTotalBytes": 11014144,
"scriptDurationMs": 67.723,
"eventListeners": -14933,
"totalBlockingTimeMs": 91,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 3974.154999999996,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.45800000000004,
"layouts": 20,
"layoutDurationMs": 19.234,
"taskDurationMs": 3856.294999999999,
"heapDeltaBytes": -37894688,
"heapUsedBytes": 179781664,
"domNodes": -8098,
"jsHeapTotalBytes": 13635584,
"scriptDurationMs": 63.527,
"eventListeners": -14981,
"totalBlockingTimeMs": 82,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6080.825000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5514.165999999999,
"heapDeltaBytes": -476768,
"heapUsedBytes": 176985652,
"domNodes": 0,
"jsHeapTotalBytes": -29622272,
"scriptDurationMs": 121.86099999999999,
"eventListeners": -6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5492.15700000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5272.01,
"heapDeltaBytes": 21881424,
"heapUsedBytes": 184670252,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 71.50200000000001,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 79.68699999992168,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.606,
"layouts": 4,
"layoutDurationMs": 1.198,
"taskDurationMs": 53.87500000000001,
"heapDeltaBytes": 3253724,
"heapUsedBytes": 72304440,
"domNodes": 131,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.228999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 83.93000000000939,
"styleRecalcs": 6,
"styleRecalcDurationMs": 10.222,
"layouts": 2,
"layoutDurationMs": 1.198,
"taskDurationMs": 54.34799999999999,
"heapDeltaBytes": 2991596,
"heapUsedBytes": 67411332,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.495000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #18369 +/- ##
=============================================
+ Coverage 83.55% 83.72% +0.17%
=============================================
Files 2094 2103 +9
Lines 123520 124583 +1063
Branches 33296 33869 +573
=============================================
+ Hits 103202 104313 +1111
+ Misses 20139 20091 -48
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…Image node bypassing upload (#18464) Automated backport of #18180 to `core/1.54`. The bot's auto-backport (`comfy-pr-bot`) failed on this branch with merge conflicts in: - `src/extensions/core/load3d/Load3DConfiguration.test.ts` - `src/extensions/core/load3d/Load3DConfiguration.ts` - `src/utils/createAnnotatedPath.test.ts` ## Root cause of the conflict Not a stacking conflict against any of the PRs the bot listed as still-open on `core/1.54` (#18417, #18410, #18407, #18369, #18354, #18334, #17872) — none of them touch these files. The real cause is that `core/1.54` never received an **already-merged, unrelated** PR: #17537 ("Load3D preview capture stale after agent-driven model_file change"), which is not on the bot's open-PR list and is not itself labeled for backport. That PR: - added a `DEFAULT_GIZMO`/`GizmoConfig` block to `Load3DConfiguration.ts` right next to the `parseAnnotatedFilename` helper that #18180 deletes (textual adjacency, not a real dependency — I did not port the gizmo code, since it's out of scope here and `core/1.54` has no other reference to it), and added `ComfyApi`/`ComfyApp` test imports unused on this branch (dropped), - moved the `ResultItem` type from `@/schemas/apiSchema` to `@/platform/remote/comfyui/execution/types` on `main`, which `core/1.54` hasn't picked up (kept the branch's existing `@/schemas/apiSchema` import), and - added an `app.getRandParam()` call inside `nodeOutputStore.ts` (already present on `core/1.54` from an earlier point, unrelated to #18180) whose test mock in `nodeOutputStore.test.ts` was missing `getRandParam`, only surfaced now because #18180's new test is the first to exercise `getNodeImageUrls()` on this file — added the missing mock entry. Resolved by taking #18180's actual change (removing the local `parseAnnotatedFilename` in favor of the shared `parseAnnotatedPath` util) while leaving everything from #17537 out, since it isn't part of this branch. ## Verification - `pnpm exec vitest run` on the touched spec files (`Load3DConfiguration.test.ts`, `createAnnotatedPath.test.ts`, `nodeOutputStore.test.ts`, `imageUtil.test.ts`) — all pass (113/113) - `pnpm typecheck` — clean - `pnpm exec eslint` on changed files — no errors (2 pre-existing `apiSchema` deprecation warnings, unrelated to this change) - `pnpm exec oxfmt --check` on changed files — clean - The new Playwright e2e (`assetPanelDragOntoLoadImageWidget.spec.ts`) was not run locally (no backend available), consistent with the original PR's own review notes. <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-org.slack.com/archives/C0BGH348Z0C/p1789875316334739)_ --- _Generated by [Claude Code](https://claude.ai/code/session_01Ws2BqUcMwaeUuPpKdYNxPV)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: bymyself <cbyrne@comfy.org>
## Summary - Mouse-driven reference-image alignment coverage only; no product fix claimed. - Five source links and the empty trailing slot are asserted. - Unrelated runtime changes removed from this PR. <details><summary>Full context for agent readers</summary> The [original report](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789782395656129) described port/label drift while stress-testing the in-app agent. This test uses mouse connections, not agent synchronization. It must not be used to close that incident. [The agent slot-identity fix](#18279) remains separate. The earlier test failure was a fixed-coordinate drag losing its target during canvas auto-pan. Keeping the viewport stable makes this mouse scenario pass without a product-code change. This is coverage of working behavior, not a reproduced product regression or a TDD bug-fix claim. The takeover rebuilds the test on current main rather than carrying parent-branch widget-rebinding and formatting changes. Primary commit authorship is preserved; the co-author trailer is removed as requested. The retained test now checks the exact five source identities, ordered image_1 through image_6 slots, row labels, and link-endpoint alignment. It captures the full workflow and an enlarged node. Local Chromium QA passed, including three consecutive runs without retries. Browser TypeScript, scoped lint and format passed. Fresh hosted CI and actual bot review remain required before merge; the previous CodeRabbit success status represented a skipped review. Cross-model review: Gemini Skeptic and Evidence-Seeded lenses completed. Refreshed slot indexes inside each alignment retry. Rejected tolerance widening without evidence of rounding failures, and rejected an asynchronous-autogrow claim after inspecting the synchronous connection callback and the drag helper's existing frame wait. The architecture-lens alternate provider was not verified as a different model and is not counted as cross-model evidence. Glossary: autogrow means creating the next empty input automatically; QA means exercising the rendered application; CI means hosted automated checks; TDD means a test demonstrated failing before its corresponding production fix. </details> --------- Co-authored-by: christian-byrne <cbyrne@comfy.org>
1ec0978 to
af1f145
Compare
…window (#18673) Automated backport of #18599 to `core/1.54`. The backport bot's automated cherry-pick attempt failed with a merge conflict in `src/scripts/api.fetchApi.test.ts` (several other open PRs — #18660, #18369, #18334, #17872 — are stacked against `core/1.54` touching the same file), so this was done manually. ## What conflicted and how it was resolved - **`src/scripts/api.fetchApi.test.ts`**: only the import/mock-setup header conflicted. `core/1.54`'s auth mocking is older than `main`'s: this branch's `authStore` still talks to Firebase directly through `vuefire` + `firebase/auth` (no `firebaseIdentity` port exists here yet), so the new `describe('post-401 retry timeout budget')` test's `beforeEach` was adapted to mock `vuefire`/`firebase/auth` directly (matching the pattern already used in this branch's `authStore.test.ts`) instead of spying on `firebaseIdentity.onUserChanged`/`onTokenChanged`. The new `trackUnifiedAuthRetry`/`mockDistribution`/`mockFeatureFlags` mocks were kept, simplified to this branch's non-`fromPartial` mocking style. - **`src/platform/auth/unified/remintRetry.test.ts`**: auto-merged, but the new test referenced `useWorkspaceAuthStore()` directly; this branch's file mocks that whole module via a hoisted `mockRemint` instead, so the test was updated to use `mockRemint.mockResolvedValue(...)` like every other test in the file. - **`src/scripts/api.ts`**: auto-merged, but the new timeout-retry code called `addBreadcrumb(...)` directly; this branch imports Sentry as `import * as Sentry from '@sentry/vue'` (not a named `addBreadcrumb` import), so the call was changed to `Sentry.addBreadcrumb(...)` to match this branch's existing convention (used a few lines above in the same file). - **`src/platform/auth/unified/remintRetry.ts`**: auto-merged cleanly, no changes needed. ## Verification - `pnpm typecheck` — clean - `pnpm lint` (eslint on the touched files; `src/scripts/api.ts` is repo-ignored from eslint on this branch) — clean, no new oxlint/eslint issues - `src/scripts/api.fetchApi.test.ts` — 18/18 passing - `src/platform/auth/unified/remintRetry.test.ts` — 23/23 passing - Pre-commit hooks (oxfmt, oxlint --fix, eslint --fix, typecheck) ran clean on commit 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_0137jzrG6RSp5e6YgGp8kxdY --- _Generated by [Claude Code](https://claude.ai/code/session_0137jzrG6RSp5e6YgGp8kxdY)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: dante01yoon <bunggl@naver.com>
Backport of #18101 to
core/1.54Automatically created by backport workflow.