Repository navigation
fix: materialize insert_workflow links with numeric ids - #18458
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2117 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (9 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 1a6456b4a6ae3372779407f1e963e0092389c97d
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle: 9.97 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.87 kB (baseline 3.87 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.44 MB (baseline 1.44 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 28 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.92 MB (baseline 3.92 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 577 kB (baseline 577 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.8 MB (baseline 17.8 MB) • ⚪ 0 BBundles that do not match a named category Status: 302 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T02:05:37.770Z",
"gitSha": "4d49b2906df4831c65adf6c475dee14a7389faa9",
"branch": "repro/insert-workflow-links-not-materialized",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.7920000000145,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.745,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.2230000000001,
"heapDeltaBytes": 11184492,
"heapUsedBytes": 78640468,
"domNodes": -259,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 12.703,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2012.8889999999728,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.832999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.34299999999996,
"heapDeltaBytes": -3767128,
"heapUsedBytes": 58728616,
"domNodes": -260,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.490000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1749.351000000047,
"styleRecalcs": 44,
"styleRecalcDurationMs": 15.967000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 876.53,
"heapDeltaBytes": -5062576,
"heapUsedBytes": 62564080,
"domNodes": -261,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 174.49499999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1750.4669999999578,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.301,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 853.293,
"heapDeltaBytes": -5112564,
"heapUsedBytes": 62593228,
"domNodes": -262,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 165.328,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1733.699999999999,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.362000000000002,
"layouts": 6,
"layoutDurationMs": 1.203,
"taskDurationMs": 390.08,
"heapDeltaBytes": 2783884,
"heapUsedBytes": 70044912,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 14.976999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1683.1249999999045,
"styleRecalcs": 29,
"styleRecalcDurationMs": 13.968,
"layouts": 6,
"layoutDurationMs": 1.0530000000000002,
"taskDurationMs": 357.148,
"heapDeltaBytes": 3121184,
"heapUsedBytes": 70619728,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 12.427000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 730.9599999999818,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.379999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.17199999999997,
"heapDeltaBytes": 19200456,
"heapUsedBytes": 86483032,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 178.316,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 714.917000000014,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.080000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.716,
"heapDeltaBytes": 19167200,
"heapUsedBytes": 86332932,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 173.019,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1214.3499999999676,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 907.76,
"heapDeltaBytes": 38826844,
"heapUsedBytes": 106531828,
"domNodes": 0,
"jsHeapTotalBytes": 17723392,
"scriptDurationMs": 76.596,
"eventListeners": 0,
"totalBlockingTimeMs": 602,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1194.8340000000144,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 886.17,
"heapDeltaBytes": 35550128,
"heapUsedBytes": 105147864,
"domNodes": 0,
"jsHeapTotalBytes": 18771968,
"scriptDurationMs": 70.487,
"eventListeners": 0,
"totalBlockingTimeMs": 589,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 876.9060000000195,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.3169999999993,
"heapDeltaBytes": 16178012,
"heapUsedBytes": 91663872,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 176.386,
"eventListeners": 0,
"totalBlockingTimeMs": 234,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.8150000000633,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.51900000000046,
"heapDeltaBytes": 14304760,
"heapUsedBytes": 90539736,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 166.54199999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 231,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11904.341999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10918.887,
"heapDeltaBytes": 1945632,
"heapUsedBytes": 84616640,
"domNodes": -20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 8991.748000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1781,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10605.472999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9600.208999999999,
"heapDeltaBytes": 3516100,
"heapUsedBytes": 85098204,
"domNodes": -16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8127.694,
"eventListeners": 0,
"totalBlockingTimeMs": 1288,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 49.99999999999818
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11896.35800000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10976.505,
"heapDeltaBytes": 10590264,
"heapUsedBytes": 87729492,
"domNodes": -14,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 9139.326000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1924,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11921.04100000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10981.180999999999,
"heapDeltaBytes": 7027724,
"heapUsedBytes": 83496036,
"domNodes": -267,
"jsHeapTotalBytes": 11788288,
"scriptDurationMs": 9180.999,
"eventListeners": -174,
"totalBlockingTimeMs": 1961,
"frameDurationMs": 19.996666666666595,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2043.5150000000135,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.099999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.4499999999999,
"heapDeltaBytes": -2860272,
"heapUsedBytes": 83544572,
"domNodes": -242,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 40.669999999999995,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2040.450000000078,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.498,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 665.6439999999999,
"heapDeltaBytes": -2839820,
"heapUsedBytes": 83930944,
"domNodes": -244,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 40.51199999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2583.3039999999983,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.406000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1800.6119999999999,
"heapDeltaBytes": -2709948,
"heapUsedBytes": 85042904,
"domNodes": -242,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 912.4920000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2559.4630000000507,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.183999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1780.0280000000002,
"heapDeltaBytes": 20550092,
"heapUsedBytes": 84670600,
"domNodes": -245,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 923.936,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3638.701000000026,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.443000000000001,
"layouts": 60,
"layoutDurationMs": 14.162999999999998,
"taskDurationMs": 1793.6900000000003,
"heapDeltaBytes": 10263868,
"heapUsedBytes": 75234592,
"domNodes": -246,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 814.742,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3652.2370000000137,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.323000000000004,
"layouts": 60,
"layoutDurationMs": 14.094,
"taskDurationMs": 1783.7620000000002,
"heapDeltaBytes": 10143904,
"heapUsedBytes": 75185392,
"domNodes": -252,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 825.522,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3178.2230000000027,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.678,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2083.453,
"heapDeltaBytes": -1913372,
"heapUsedBytes": 65633012,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 1059.601,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3213.023000000021,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.619000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2040.9350000000002,
"heapDeltaBytes": 796980,
"heapUsedBytes": 66557804,
"domNodes": 6,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 1046.193,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.5579999999945,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.099999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 593.1759999999999,
"heapDeltaBytes": -4522096,
"heapUsedBytes": 84167212,
"domNodes": -246,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 32.516000000000005,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2009.730999999988,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.036999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.857,
"heapDeltaBytes": 20231956,
"heapUsedBytes": 84671800,
"domNodes": -251,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.74000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 597.6689999999962,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.268999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.731,
"heapDeltaBytes": 14092140,
"heapUsedBytes": 82973456,
"domNodes": 21,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 146.488,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 601.4769999999316,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.776000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.69500000000005,
"heapDeltaBytes": 13449312,
"heapUsedBytes": 83381660,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 147.464,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.4400000000219,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.574,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.91700000000003,
"heapDeltaBytes": 10171044,
"heapUsedBytes": 79981140,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.558999999999997,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.9320000000062,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.344,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.44899999999996,
"heapDeltaBytes": -14507096,
"heapUsedBytes": 54970624,
"domNodes": -276,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.246,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1739.657999999963,
"styleRecalcs": 45,
"styleRecalcDurationMs": 17.786,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 792.8420000000001,
"heapDeltaBytes": 3213984,
"heapUsedBytes": 73064632,
"domNodes": -275,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 113.929,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.4519999999284,
"styleRecalcs": 45,
"styleRecalcDurationMs": 16.676999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 787.846,
"heapDeltaBytes": 517280,
"heapUsedBytes": 70343016,
"domNodes": -279,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 114.55,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.8130000000083,
"styleRecalcs": 17,
"styleRecalcDurationMs": 28.760999999999996,
"layouts": 5,
"layoutDurationMs": 13.442000000000002,
"taskDurationMs": 961.9219999999997,
"heapDeltaBytes": -6267296,
"heapUsedBytes": 81456196,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 31.341,
"eventListeners": 2383,
"totalBlockingTimeMs": 141,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9095.219000000043,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.102,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6374.734,
"heapDeltaBytes": -8299360,
"heapUsedBytes": 77888752,
"domNodes": -244,
"jsHeapTotalBytes": -827392,
"scriptDurationMs": 3030.59,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.659999999999975,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8670.72900000005,
"styleRecalcs": 251,
"styleRecalcDurationMs": 41.173,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6118.532,
"heapDeltaBytes": -1691904,
"heapUsedBytes": 84509432,
"domNodes": -240,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 2903.793,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17804.03899999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17382.083000000002,
"heapDeltaBytes": -42184528,
"heapUsedBytes": 183463696,
"domNodes": -8061,
"jsHeapTotalBytes": -14426112,
"scriptDurationMs": 288.432,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13121.174999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12648.96,
"heapDeltaBytes": -60461936,
"heapUsedBytes": 173785932,
"domNodes": -8061,
"jsHeapTotalBytes": -5517312,
"scriptDurationMs": 225.906,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21064.475000000017,
"styleRecalcs": 158,
"styleRecalcDurationMs": 18.44900000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20883.156999999996,
"heapDeltaBytes": -35928024,
"heapUsedBytes": 191915444,
"domNodes": -8061,
"jsHeapTotalBytes": -18358272,
"scriptDurationMs": 932.3639999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 96,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21828.215,
"styleRecalcs": 157,
"styleRecalcDurationMs": 21.739000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21633.544,
"heapDeltaBytes": -59708912,
"heapUsedBytes": 180848356,
"domNodes": -8062,
"jsHeapTotalBytes": -21127168,
"scriptDurationMs": 989.0799999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 93,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "vue-node-resize-workload",
"durationMs": 6225.221000000033,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.733,
"layouts": 20,
"layoutDurationMs": 24.39200000000001,
"taskDurationMs": 6168.619000000001,
"heapDeltaBytes": -54868936,
"heapUsedBytes": 166672312,
"domNodes": -8061,
"jsHeapTotalBytes": 8056832,
"scriptDurationMs": 136.65,
"eventListeners": -14928,
"totalBlockingTimeMs": 397,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6354.767999999922,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.19199999999998,
"layouts": 20,
"layoutDurationMs": 26.055999999999997,
"taskDurationMs": 6317.625000000001,
"heapDeltaBytes": -64422500,
"heapUsedBytes": 170262796,
"domNodes": -8061,
"jsHeapTotalBytes": 18337792,
"scriptDurationMs": 116.134,
"eventListeners": -14928,
"totalBlockingTimeMs": 406,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8882.861000000048,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8660.64,
"heapDeltaBytes": 22666924,
"heapUsedBytes": 197685240,
"domNodes": 0,
"jsHeapTotalBytes": -28573696,
"scriptDurationMs": 136.06999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8831.468000000086,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8723.156,
"heapDeltaBytes": 13689684,
"heapUsedBytes": 190847144,
"domNodes": 0,
"jsHeapTotalBytes": -10485760,
"scriptDurationMs": 162.59900000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 489.2120000000659,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.189,
"layouts": 6,
"layoutDurationMs": 3.1860000000000004,
"taskDurationMs": 159.601,
"heapDeltaBytes": 5376320,
"heapUsedBytes": 67478156,
"domNodes": 147,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 21.134999999999998,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 117.8300000000263,
"styleRecalcs": 7,
"styleRecalcDurationMs": 12.946,
"layouts": 2,
"layoutDurationMs": 1.049,
"taskDurationMs": 73.50599999999999,
"heapDeltaBytes": 3039096,
"heapUsedBytes": 68463520,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.245999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌐 Website E2ETip All tests passed.
|
A CRDT insert_workflow op that adds several nodes and the links between them in one batch (no subgraph, no reconnect of an existing slot) reads back with every node materialized correctly but every link silently missing. Root cause: comfy-multi-player's insert_workflow applier mints a fresh, non-numeric doc id for every inserted node AND link (remap.ts's derivedId, e.g. insert:<opId>:root:link:201), so a batch can never collide with an existing id. ecsFollowerAdapter.ts's readSemanticLink narrows a link's doc id through Number(tuple[0]) and requires Number.isInteger on the result; a derived string id always fails that check. On the full-reconcile path (the first frame a session binds, or any frame after a rejected batch) the unreadable link is filtered out with no error reported, while nodes in the same batch commit fine since readSemanticNode has no such constraint. On the incremental path it is worse: the same failed Number() conversion also breaks removeLinks's non-negative-integer check in graphMutations.ts's prepare(), rejecting the whole batch including the node adds sharing it. This is a different code path from #18375's LinkMap revision-cache race: that fix only matters when a connect displaces an existing occupant on an already-live slot, which never happens for a batch of brand-new nodes and brand-new links. RED only; no fix included. Claude-Session: https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY
7d82da6 to
8b70538
Compare
This comment has been minimized.
This comment has been minimized.
ecsFollowerAdapter.ts's readSemanticLink narrowed a link's doc id through Number(tuple[0]) and required Number.isInteger, so a link minted by insert_workflow (whose ids are derived strings like insert:<opId>:root:link:201, per comfy-multi-player's remap.ts) was always treated as unreadable: silently dropped on the full-reconcile path, and enough to reject the whole batch via the same Number() conversion feeding removeLinks on the incremental path. LiteGraph's own link ids are plain numbers, so a derived string id is now hashed into a large integer (resolveLinkId), well outside the range any real persisted link id can reach, instead of being rejected. The same resolver is used for the removeLinks id conversion so a link's identity stays consistent across connect and remove. Extends the regression test with incremental-path and remove/replay coverage alongside the existing full-reconcile case. Claude-Session: https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY
dante01yoon
left a comment
There was a problem hiding this comment.
The diagnosis here is genuinely good and I could follow it end to end: remap.ts's derivedId mints a non-numeric doc id for links as well as nodes, readSemanticLink's Number.isInteger check rejects it, and the two paths then fail differently — silently filtered on full reconcile, whole-batch rejection on the incremental path, because the same failed conversion feeds removeLinks. I verified that story against remap.ts and the adapter, and it holds. Separating this from #18375 is also correct: there is no existing occupant at either target slot in this batch, so commit() never takes its detachLinkSlots branch.
I'm requesting changes on the chosen identity scheme, not on the analysis. @christian-byrne already flagged the 32-bit collision at line 241; I'm confirming it as blocking and adding a reproduction against this branch, because the failure it produces is the same silent-link-drop this PR exists to fix.
Reproduced: a colliding pair silently drops a link, and the batch still reports success
Two independent insert_workflow ops, each inserting its own brand-new node pair and its own brand-new link, with distinct 32-char op ids whose derived link ids collide under FNV-1a:
insert:d7b0c03fe2abc909a5c84a6e02d80cdd:root:link:201 -> fnv1a 3181811759
insert:589889ae708156b3e33fdf39e3cfb931:root:link:201 -> fnv1a 3181811759
both -> resolveLinkId 13181811759
Run through AgentCrdtProjection on this head, exactly as the PR's own tests bind it:
committed = true | live nodes = 4 | serialized links =
[[13181811759, "insert:589889…:root:node:103", 0, "insert:589889…:root:node:104", 0, "IMAGE"]]
All four nodes materialize; one of the two links is gone, op A's wire replaced by op B's, committed === true, nothing reported. Nodes correct, link missing, no error — the exact symptom in the PR description. I also confirmed @christian-byrne's example independently: insert:op-27669:root:link:27669 and insert:op-58546:root:link:58546 both hash to 3886304658.
I found that colliding 32-char pair in ~30k random samples, so the practical rate scales as the usual birthday bound over 2³² (≈0.01% at 1k live derived links, ≈1% at 10k). Low per graph, but it fails silently and in the same way as the bug being fixed, which is what makes it worth blocking on rather than shipping and watching.
Why the existing tests pass anyway
All three scenarios exercise one derived id at a time, so they establish that a single id resolves consistently across connect / removeLinks / removeMissing — which it does; I checked all three call sites and they agree. None of them establishes uniqueness across ids, which is the property that actually fails. The op-id pair above makes that regression cheap to write.
What I verified, and what still works
fnv1areturns a 32-bit unsigned int (hash >>> 0), soDERIVED_LINK_ID_BASE + fnv1a(...)stays a safe integer — no string-concat or precision hazard. Confirmed againstsrc/platform/workflow/persistence/base/hashUtil.ts.- The resolver is applied consistently at all three sites that need it:
readSemanticLink(line 253), theremovedLinkIdsconversion (line 539), andremoveMissing, which takes its ids fromreadSemanticLinkoutput. There is no remaining rawNumber()on a link doc id in this file. That part of the fix is complete. graphMutations.tsreally does need no change — the non-negative-integer guards at lines 779-780 accept the resolved id, andtoLinkIdis an unbounded branded number.- The PR's three tests pass locally:
npx vitest run src/workbench/extensions/agent/crdt/agentInsertWorkflowLinks.regression.test.ts→ 3 passed.
Validation
Ran the new test file locally (3/3 pass) and the collision probe above against 59e42b8. CI at this head: 57 pass, 0 fail, 31 pending (Playwright shards and cursor-review), 30 skipped. I did not run the full unit suite or the Playwright shards locally.
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: changes requested
The derived-link ID mapping is lossy, so this fix can silently replace or remove an unrelated link. I also found boundary-validation, fixture-typing, and test-maintenance issues in the new code.
Pre-merge blockers:
- P1: Distinct derived IDs can resolve to the same live
LinkId, and the chosen numeric range is not reserved. This confirms the existing review finding below.
Existing findings confirmed or contested
- Confirmed christian-byrne's collision finding. I independently evaluated the exact IDs in that comment. Both hash to
3886304658and resolve to13886304658. The workflow schema and LiteGraph allocator do not cap persisted numeric IDs below10_000_000_000, so derived-to-derived and derived-to-numeric aliasing are both possible. The mapping needs collision-free session identity, with tests for both cases. - Confirmed dante01yoon's end-to-end collision reproduction. It demonstrates the same aliasing through
AgentCrdtProjection: four nodes materialize, one of two links remains, and the batch reports success. My independent collision searches and constant-hash mutation produced the same failure class. - Confirmed dante01yoon's reload and persistence finding.
graph.serialize()persists the synthetic numeric ID, while the workflow schema and LiteGraph allocator impose no upper bound. A reopened workflow can therefore contain a persisted ID in the supposed reserved range. - Confirmed dante01yoon's identity-ownership concern. The CRDT document owns a string identity, but this adapter invents a second numeric identity. Preserving the string, minting a numeric ID upstream, or maintaining a checked session bijection are design alternatives; the current stateless hash is not a valid identity function.
Checked and cleared
- Fallow reports cyclomatic 12 / CRAP 43.1 for
readSemanticLink, but its diff-scoped result marks that metricintroduced:false. The complex reader predates this PR, and this patch removes one decision from it, so I did not treat that metric as a new finding.
Coverage
- Depth: standard.
- Lanes: correctness, maintainability, idiomaticity, tests, and documentation.
- The tests lane applied unit-test, mock-boundary, setup-consolidation, and proof lenses. Playwright guidance was not applicable because no
browser_tests/file changed. - Both changed files were read in full. Identity consumers, schemas, allocation, and package operation types were traced at their relevant boundaries.
- Local checks at
59e42b8fedf2ec003a0e3aee3d16acf719800a2e: targeted Vitest 3/3 passed; ESLint passed; oxfmt passed; full typecheck passed; diff-scoped Fallow exited 0. - CI still had running checks when I reviewed this SHA.
|
Thanks Christian, dante01yoon, and DrJKL — all three reviews are correct. The FNV-1a hash approach in Team decision (from the linked Slack thread): rather than patching around the collision risk in this frontend adapter, we're fixing it at the source. A genuine collision-free numeric link id will be minted server-side in Once that upstream fix merges, this PR will be updated to consume the real numeric id directly — likely simplifying or removing The smaller test-quality nits from DrJKL's review — setup duplication (will use This PR isn't going anywhere in the meantime; it stays open and will be updated once the upstream fix is ready. Leaving all existing review threads open until then. Generated by Claude Code |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 8 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 2 |
| 🟡 Medium | 4 |
| 🟢 Low | 1 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18458 +/- ##
==========================================
- Coverage 83.40% 83.38% -0.02%
==========================================
Files 2987 2987
Lines 147801 147824 +23
Branches 40064 38188 -1876
==========================================
- Hits 123267 123266 -1
- Misses 23253 23277 +24
Partials 1281 1281
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 🚀 New features to boost your workflow:
|
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: blocked by the merge conflict with main.
I re-reviewed the implementation after pushing c386f72. The code findings are addressed: tuple IDs must now be non-negative safe numbers and match their canonical map keys; malformed replacements retire the prior live link; and the regression suite now checks exact persisted/live IDs, incumbent collision topology, standalone disconnect/reinsertion, malformed numeric values, cleanup, and reinsertion naming.
Remaining findings:
- P1: The PR description still says the frontend hashes derived string IDs into a reserved numeric range. The current implementation instead pins comfy-multi-player PR #245 at 08be0d1 and validates the genuine numeric IDs minted upstream. The root-cause and fix sections need to describe the implementation that will merge.
- P2: The description says the regression file covers three scenarios including undo/redo. It now covers initial and incremental projection, collision preservation, malformed IDs, map-key/tuple divergence, reload, standalone disconnect, and reinsertion; it does not exercise product undo/redo.
- P2: The description does not disclose that the dependency is temporarily pinned to unreleased comfy-multi-player PR #245 or state the condition for replacing the codeload SHA with a released package.
GitHub currently reports mergeable_state: dirty, and the required checks for c386f72 are pending, so I cannot approve this revision yet.
Resolves the comfy-multi-player pin conflict: keeps the catalog: entry pinned to the git-tarball commit 08be0d1 (one commit past the v0.3.3 release, containing the upstream "mint genuine numeric link ids for insert_workflow" fix), which is a strict superset of main's plain 0.3.3 version bump. pnpm-lock.yaml regenerated via `pnpm install --frozen-lockfile` and confirmed up to date, no other drift. Claude-Session: https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY
|
|
…ric ids (#18548) ## Summary Release-native backport of [the merged main fix](#18458): `insert_workflow` nodes no longer materialize without their links. <details> <summary>Full context for agent readers</summary> ## Changes - Pins `@comfyorg/comfy-multi-player` to published npm version `0.3.4`, which mints numeric link IDs for `insert_workflow`. - Adds a version 1.54-native integration regression proving a three-node inserted workflow stores canonical numeric IDs and projects both links. - Removes the obsolete codeload build allowance; no GitHub tarball remains in the effective dependency path. ## Review focus This intentionally omits the main-branch-only `AgentCrdtProjection` and `parseLinkId` changes that made [the generated core backport](#18539) fail to compile. The version 1.54 adapter already accepts the upstream numeric IDs. The original branch-native targeted integration suite, ESLint, formatting, typecheck, and pre-push Knip passed before the npm-source correction. Hosted checks are requalifying the corrected exact head. Backport of [the merged main fix](#18458). Supersedes [the generated core backport](#18539). </details>
…eric ids (#18549) ## Summary Release-native backport of [the merged main fix](#18458): `insert_workflow` nodes no longer materialize without their links. <details> <summary>Full context for agent readers</summary> ## Changes - Pins `@comfyorg/comfy-multi-player` to published npm version `0.3.4`, which mints numeric link IDs for `insert_workflow`. - Adds a version 1.54-native integration regression proving a three-node inserted workflow stores canonical numeric IDs and projects both links. - Preserves the live `cloud/1.54` package version (`1.54.14`) and removes the obsolete codeload build allowance. ## Review focus This intentionally omits the main-branch-only `AgentCrdtProjection` and `parseLinkId` changes that made [the generated cloud backport](#18540) fail to compile. The version 1.54 adapter already accepts the upstream numeric IDs. The original branch-native targeted integration suite, ESLint, formatting, typecheck, and pre-push Knip passed before the npm-source/version correction. Hosted checks are requalifying the corrected exact head. Backport of [the merged main fix](#18458). Supersedes [the generated cloud backport](#18540). </details>
## Summary Use published `@comfyorg/comfy-multi-player@0.3.5`; replace [the blocked predecessor](#18544), whose commit trailer cannot pass policy without rewriting history. <details> <summary>Full context for agent readers</summary> - Replaces the temporary codeload tarball pin from [the numeric-link fix](#18458) with exact npm version `0.3.5`. - Removes the tarball-specific `allowBuilds` entry. - Keeps only the active `0.3.5` release-age exclusion, addressing [DrJKL's review](#18544 (comment)). - Starts from current `main` and contains one clean commit with no rejected co-author trailer. - Was originally opened against `0.3.4`, then bumped to `0.3.5` once [comfy-multi-player#248](Comfy-Org/comfy-multi-player#248) published it — 0.3.5 fixes a `structuredClone`/`TS2304` typing gap in comfy-multi-player's own build ([comfy-multi-player#247](Comfy-Org/comfy-multi-player#247)) that 0.3.4 did not fix. - Also bumps the frontend's own `yjs` catalog pin to `^13.6.32`: comfy-multi-player@0.3.5's own `yjs ^13.6.27` dependency resolved to `13.6.32`, which coexisted with the frontend's previously-pinned `13.6.31` as two separate package instances and broke `vue-tsc` (`TS2345`, incompatible `Doc`/`AbstractType`/`Item` types) in `schemaGuard.ts` and `useAgentCrdtFollower.integration.test.ts`. Deduping to one `yjs` instance fixes it. npm reports the lockfile integrity for `0.3.5` as `sha512-stsag63SdKI/EFzdbEFPO3IhGzftyDcuJnT0WyPLMc08nEWkwg0M8kmVHAc4akRsIeWoj7mXSLzbHxpcbCm3lg==`. </details> --------- Co-authored-by: Claude <noreply@anthropic.com>
<!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449?thread_ts=1790058330.774449&cid=C0BGH348Z0C)_ Fixes a bug where an agent's `insert_workflow` batch (e.g. the in-app agent loading a template like "Z Image Turbo") materialized nodes with correct positions and types, and links between them materialized correctly (#18458 / PM-1562), but every inserted node's **widgets rendered as empty/blank bodies** even though the widget values, `MarkdownNote` text, `SaveImage` `filename_prefix`, etc. were present in the CRDT document and in the widget store. Two independent, compounding bugs, both specific to how `insert_workflow` differs from `add_node`: **Bug 1 — widgets undiscoverable (blank node body, zero widget rows).** `comfy-multi-player`'s `insert_workflow` applier remaps every inserted node's id to a derived string carrying colons for reasons that have nothing to do with subgraph scoping (`remap.ts`'s `derivedId`, e.g. `insert:<opId>:root:node:<originalId>`). `add_node` never does this — it keeps the id comfy-cli minted. Widget registration (`attachNodeToStores`/`BaseWidget.setNodeId` in `nodeShellLifecycle.ts`/`BaseWidget.ts`) always keys on that full id. The node-render path reads widget ids back through `stripGraphPrefix` (`src/stores/widgetValueStore.ts`) — used by `LGraphNode.vue`, `processedWidgetRenderModel.ts`, `WidgetItem.vue`, and `WidgetTextPreview.vue`. It used to strip *everything up to the last colon* unconditionally, which is correct for a genuine subgraph-scoped id (`<uuid>:<localId>`) but wrong for `insert_workflow`'s derived id: it collapsed `insert:<opId>:root:node:9` down to bare `9`, a key nothing was ever registered under (and, if a second `insert_workflow` op happened to reuse the same original id, a key two unrelated nodes would collapse onto). The lookup came back empty, so the node rendered with **zero widget rows**. Fixed `stripGraphPrefix` to only strip a prefix that is actually a subgraph UUID (repeating for nested subgraphs), leaving any other colon-bearing id untouched. **Bug 2 — widget discoverable but stuck at its constructor default.** Once bug 1 is fixed, `agentNodeMaterializer.ts`'s `materialize()` still didn't restore the real value. The op layer stores an ordinary node's `widgets_values` **by name** (`readSemanticNode`), but `LGraphNode.configure()`'s named-value restore is gated behind the experimental `Comfy.Workflow.NamedValuesRestore` setting (off by default) or a `fallbackNames` list that is never populated for real catalog nodes. Without either, `configure()` falls back to *positional* restore against `widgets_values` — for a named payload that's a plain object, not an array, so nothing restores and the widget keeps whatever value its constructor set. This file already has a `withNamedValuesRestore()` helper that flips `LiteGraph.namedValuesRestore` on for the duration of a call — it was used only when configuring a subgraph *definition*, never for the node's own `configure()` call in `materialize()`. `add_node`-created nodes mostly dodge this because the agent's add-node tool typically follow-ups with discrete `set_widget` ops (a direct, always-correct value write), whereas `insert_workflow` bakes every widget value into the node's initial creation payload, hitting this path on every single widget of every inserted node. **Fix:** wrap `materialize()`'s `node.configure(...)` call in `withNamedValuesRestore()` too, so a named payload actually lands. **Tests:** - `agentInsertWorkflowWidgets.regression.test.ts` (new): drives the real pipeline (comfy-multi-player's `insert_workflow` applier → `EcsFollowerAdapter`/`AgentCrdtProjection` → `graphMutations` → `agentNodeMaterializer`), then reads widget ids back exactly the way `LGraphNode.vue` does (`stripGraphPrefix` + `getNodeWidgetIds`), asserting the widget is both discoverable and correctly-valued. Also covers two `insert_workflow` ops that reuse the same original node id, proving they no longer collide. - `widgetValueStore.test.ts`: focused unit coverage for `stripGraphPrefix` — bare id passthrough, single/nested subgraph-uuid stripping, the derived-id passthrough case, the same-trailing-segment non-collision case, and the empty-id case. **Verified:** `pnpm typecheck`, `pnpm lint` (eslint + oxlint), `pnpm format:check` (via the repo's pre-commit hook) and the full `src/workbench/extensions/agent/crdt` + `src/stores` Vitest suites (2148 passed, 16 pre-existing expected-fails unrelated to this change, 1 skipped) all pass, plus the render-adjacent `LGraphNode.widgetOrder.test.ts`, `WidgetItem.test.ts`, and `WidgetTextPreview.test.ts`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY --- _Generated by [Claude Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
<!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449?thread_ts=1790058330.774449&cid=C0BGH348Z0C)_ Fixes a bug where an agent's `insert_workflow` batch (e.g. the in-app agent loading a template like "Z Image Turbo") materialized nodes with correct positions and types, and links between them materialized correctly (#18458 / PM-1562), but every inserted node's **widgets rendered as empty/blank bodies** even though the widget values, `MarkdownNote` text, `SaveImage` `filename_prefix`, etc. were present in the CRDT document and in the widget store. Two independent, compounding bugs, both specific to how `insert_workflow` differs from `add_node`: **Bug 1 — widgets undiscoverable (blank node body, zero widget rows).** `comfy-multi-player`'s `insert_workflow` applier remaps every inserted node's id to a derived string carrying colons for reasons that have nothing to do with subgraph scoping (`remap.ts`'s `derivedId`, e.g. `insert:<opId>:root:node:<originalId>`). `add_node` never does this — it keeps the id comfy-cli minted. Widget registration (`attachNodeToStores`/`BaseWidget.setNodeId` in `nodeShellLifecycle.ts`/`BaseWidget.ts`) always keys on that full id. The node-render path reads widget ids back through `stripGraphPrefix` (`src/stores/widgetValueStore.ts`) — used by `LGraphNode.vue`, `processedWidgetRenderModel.ts`, `WidgetItem.vue`, and `WidgetTextPreview.vue`. It used to strip *everything up to the last colon* unconditionally, which is correct for a genuine subgraph-scoped id (`<uuid>:<localId>`) but wrong for `insert_workflow`'s derived id: it collapsed `insert:<opId>:root:node:9` down to bare `9`, a key nothing was ever registered under (and, if a second `insert_workflow` op happened to reuse the same original id, a key two unrelated nodes would collapse onto). The lookup came back empty, so the node rendered with **zero widget rows**. Fixed `stripGraphPrefix` to only strip a prefix that is actually a subgraph UUID (repeating for nested subgraphs), leaving any other colon-bearing id untouched. **Bug 2 — widget discoverable but stuck at its constructor default.** Once bug 1 is fixed, `agentNodeMaterializer.ts`'s `materialize()` still didn't restore the real value. The op layer stores an ordinary node's `widgets_values` **by name** (`readSemanticNode`), but `LGraphNode.configure()`'s named-value restore is gated behind the experimental `Comfy.Workflow.NamedValuesRestore` setting (off by default) or a `fallbackNames` list that is never populated for real catalog nodes. Without either, `configure()` falls back to *positional* restore against `widgets_values` — for a named payload that's a plain object, not an array, so nothing restores and the widget keeps whatever value its constructor set. This file already has a `withNamedValuesRestore()` helper that flips `LiteGraph.namedValuesRestore` on for the duration of a call — it was used only when configuring a subgraph *definition*, never for the node's own `configure()` call in `materialize()`. `add_node`-created nodes mostly dodge this because the agent's add-node tool typically follow-ups with discrete `set_widget` ops (a direct, always-correct value write), whereas `insert_workflow` bakes every widget value into the node's initial creation payload, hitting this path on every single widget of every inserted node. **Fix:** wrap `materialize()`'s `node.configure(...)` call in `withNamedValuesRestore()` too, so a named payload actually lands. **Tests:** - `agentInsertWorkflowWidgets.regression.test.ts` (new): drives the real pipeline (comfy-multi-player's `insert_workflow` applier → `EcsFollowerAdapter`/`AgentCrdtProjection` → `graphMutations` → `agentNodeMaterializer`), then reads widget ids back exactly the way `LGraphNode.vue` does (`stripGraphPrefix` + `getNodeWidgetIds`), asserting the widget is both discoverable and correctly-valued. Also covers two `insert_workflow` ops that reuse the same original node id, proving they no longer collide. - `widgetValueStore.test.ts`: focused unit coverage for `stripGraphPrefix` — bare id passthrough, single/nested subgraph-uuid stripping, the derived-id passthrough case, the same-trailing-segment non-collision case, and the empty-id case. **Verified:** `pnpm typecheck`, `pnpm lint` (eslint + oxlint), `pnpm format:check` (via the repo's pre-commit hook) and the full `src/workbench/extensions/agent/crdt` + `src/stores` Vitest suites (2148 passed, 16 pre-existing expected-fails unrelated to this change, 1 skipped) all pass, plus the render-adjacent `LGraphNode.widgetOrder.test.ts`, `WidgetItem.test.ts`, and `WidgetTextPreview.test.ts`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY --- _Generated by [Claude Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_
<!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449?thread_ts=1790058330.774449&cid=C0BGH348Z0C)_ Fixes a bug where an agent's `insert_workflow` batch (e.g. the in-app agent loading a template like "Z Image Turbo") materialized nodes with correct positions and types, and links between them materialized correctly (#18458 / PM-1562), but every inserted node's **widgets rendered as empty/blank bodies** even though the widget values, `MarkdownNote` text, `SaveImage` `filename_prefix`, etc. were present in the CRDT document and in the widget store. Two independent, compounding bugs, both specific to how `insert_workflow` differs from `add_node`: **Bug 1 — widgets undiscoverable (blank node body, zero widget rows).** `comfy-multi-player`'s `insert_workflow` applier remaps every inserted node's id to a derived string carrying colons for reasons that have nothing to do with subgraph scoping (`remap.ts`'s `derivedId`, e.g. `insert:<opId>:root:node:<originalId>`). `add_node` never does this — it keeps the id comfy-cli minted. Widget registration (`attachNodeToStores`/`BaseWidget.setNodeId` in `nodeShellLifecycle.ts`/`BaseWidget.ts`) always keys on that full id. The node-render path reads widget ids back through `stripGraphPrefix` (`src/stores/widgetValueStore.ts`) — used by `LGraphNode.vue`, `processedWidgetRenderModel.ts`, `WidgetItem.vue`, and `WidgetTextPreview.vue`. It used to strip *everything up to the last colon* unconditionally, which is correct for a genuine subgraph-scoped id (`<uuid>:<localId>`) but wrong for `insert_workflow`'s derived id: it collapsed `insert:<opId>:root:node:9` down to bare `9`, a key nothing was ever registered under (and, if a second `insert_workflow` op happened to reuse the same original id, a key two unrelated nodes would collapse onto). The lookup came back empty, so the node rendered with **zero widget rows**. Fixed `stripGraphPrefix` to only strip a prefix that is actually a subgraph UUID (repeating for nested subgraphs), leaving any other colon-bearing id untouched. **Bug 2 — widget discoverable but stuck at its constructor default.** Once bug 1 is fixed, `agentNodeMaterializer.ts`'s `materialize()` still didn't restore the real value. The op layer stores an ordinary node's `widgets_values` **by name** (`readSemanticNode`), but `LGraphNode.configure()`'s named-value restore is gated behind the experimental `Comfy.Workflow.NamedValuesRestore` setting (off by default) or a `fallbackNames` list that is never populated for real catalog nodes. Without either, `configure()` falls back to *positional* restore against `widgets_values` — for a named payload that's a plain object, not an array, so nothing restores and the widget keeps whatever value its constructor set. This file already has a `withNamedValuesRestore()` helper that flips `LiteGraph.namedValuesRestore` on for the duration of a call — it was used only when configuring a subgraph *definition*, never for the node's own `configure()` call in `materialize()`. `add_node`-created nodes mostly dodge this because the agent's add-node tool typically follow-ups with discrete `set_widget` ops (a direct, always-correct value write), whereas `insert_workflow` bakes every widget value into the node's initial creation payload, hitting this path on every single widget of every inserted node. **Fix:** wrap `materialize()`'s `node.configure(...)` call in `withNamedValuesRestore()` too, so a named payload actually lands. **Tests:** - `agentInsertWorkflowWidgets.regression.test.ts` (new): drives the real pipeline (comfy-multi-player's `insert_workflow` applier → `EcsFollowerAdapter`/`AgentCrdtProjection` → `graphMutations` → `agentNodeMaterializer`), then reads widget ids back exactly the way `LGraphNode.vue` does (`stripGraphPrefix` + `getNodeWidgetIds`), asserting the widget is both discoverable and correctly-valued. Also covers two `insert_workflow` ops that reuse the same original node id, proving they no longer collide. - `widgetValueStore.test.ts`: focused unit coverage for `stripGraphPrefix` — bare id passthrough, single/nested subgraph-uuid stripping, the derived-id passthrough case, the same-trailing-segment non-collision case, and the empty-id case. **Verified:** `pnpm typecheck`, `pnpm lint` (eslint + oxlint), `pnpm format:check` (via the repo's pre-commit hook) and the full `src/workbench/extensions/agent/crdt` + `src/stores` Vitest suites (2148 passed, 16 pre-existing expected-fails unrelated to this change, 1 skipped) all pass, plus the render-adjacent `LGraphNode.widgetOrder.test.ts`, `WidgetItem.test.ts`, and `WidgetTextPreview.test.ts`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY --- _Generated by [Claude Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_
…s, subgraphs, templates) Extends the PM-1562/#18458 (link materialization) and PM-1580/#18598/#18604 (widget rendering) regression coverage with broader integration tests for insert_workflow across widget types, link topologies, subgraph promotion, and representative workflow-template shapes. - agentInsertWorkflow.widgetTypes.test.ts (13 cases): combo/number/text/ toggle/multiline widgets on inserted nodes, partial widgets_values, cross-graph and same-graph id collisions. - agentInsertWorkflow.linkTopology.test.ts (8 cases): fan-out, fan-in, parallel chains, links crossing into/out of a subgraph boundary, a fully interior subgraph link, batch id-collision, incremental inserts. - agentInsertWorkflow.subgraphs.test.ts (7 cases): a promoted widget surviving a later set_widget, multiple widget types promoted together, subgraph-instance id collisions, several instances of one definition in one op, coexistence with a pre-existing instance, multiple definitions in one op. Documents a real gap (not fixed here): a subgraph instance nested as an interior node of another subgraph does not yet materialize through this pipeline. - agentInsertWorkflow.templates.test.ts (7 cases): representative txt2img, img2img, ControlNet, LoRA, video and compound pipelines, plus the same template inserted twice without cross-wiring.
…ric ids (#18559) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449?thread_ts=1790058330.774449&cid=C0BGH348Z0C)_ ## Summary Manual backport of the merged main fix (#18458): `insert_workflow` nodes no longer materialize without their links, on `core/1.54`. <details> <summary>Full context for agent readers</summary> ## Changes - Pins `@comfyorg/comfy-multi-player` to published npm version `0.3.4` (was `0.3.2`), which mints numeric link IDs for `insert_workflow` (Comfy-Org/comfy-multi-player#245). - Removes the now-obsolete `allowBuilds` codeload tarball entry from `pnpm-workspace.yaml` and adds `0.3.4` to `minimumReleaseAgeExclude`. - Adds a `core/1.54`-native regression test to the existing `ecsFollowerAdapter.integration.test.ts` proving a three-node inserted workflow batch stores canonical numeric link IDs and both links project onto the canvas. - Regenerated `pnpm-lock.yaml` via `pnpm install` (integrity hash for `0.3.4` matches the one already reviewed in #18549/#18552). ## Review focus This intentionally omits the main-branch-only `ecsFollowerAdapter.ts`/`resolveLinkId`/`resolveLinkMapKey`/`parseLinkId` hardening from #18458. That hardening depends on `parseLinkId`, which was introduced by the unrelated #18361 and is not present on `core/1.54`. It is not required to fix this bug: `core/1.54`'s `readSemanticLink` already accepts a genuine numeric link ID via its existing `Number(tuple[0])` / `Number.isInteger` check, so once `comfy-multi-player` mints real numeric IDs (0.3.4), the bug is fixed by the dependency bump alone. This mirrors the approach #18549 already took for `cloud/1.54` (see that PR's own "Review focus" section), which hit and resolved the identical conflict. Backport of #18458. Companion PRs doing the same dependency-pin cleanup: #18549 (`cloud/1.54`, already covers that branch) and #18552 (`main`). Verified locally: targeted regression test passes (16/16 in `ecsFollowerAdapter.integration.test.ts`), `pnpm typecheck` clean, `pnpm exec eslint`/`pnpm oxlint` on changed files clean. </details> Claude-Session: https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY --- _Generated by [Claude Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_ --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
|
|
|
|
<!-- ccr-slack-attribution -->
Requested by Jo Zhang · Slack thread
Fixes a bug where an agent's
insert_workflowbatch — several brand-new nodes plus the links between them, applied as one CRDT op, not a subgraph paste — materialized the nodes correctly (including widget values) but dropped every link between them, with no error surfaced.Root cause:
comfy-multi-player'sinsert_workflowapplier used to mint a fresh, non-numeric doc id for every node and link it inserts (remap.ts'sderivedId, e.g.insert:<opId>:root:link:201).ecsFollowerAdapter.ts'sreadSemanticLinknarrowed a link's doc id withNumber(tuple[0])and requiredNumber.isIntegeron the result — a derived string id always failed that check, so the link was treated as unreadable:readSemanticNodehas no such numeric constraint).Number()conversion also fedremoveLinks's id check, rejecting the whole batch — including the node adds sharing it.Fix: rather than working around the non-numeric derived id in the frontend,
comfy-multi-playeris pinned to PR #245 ("fix: mint genuine numeric link ids for insert_workflow (ADR-033)"), now merged tomainat commitb475423, which mints a real numeric link id for every link aninsert_workflowbatch inserts, upstream.ecsFollowerAdapter.ts'sreadSemanticLinknow just validates that identity:resolveLinkIdaccepts only a real non-negative safe-integer link id, andresolveLinkMapKey(viaparseLinkId) cross-checks that id against the link's own doc map key, retiring any live link whose map key and tuple id diverge instead of materializing something inconsistent.graphMutations.tsneeded no change — its non-negative-integer guards already accept the validated id.Dependency pin:
@comfyorg/comfy-multi-playeris temporarily pinned, via apnpm-workspace.yamlcatalog entry, to a codeload tarball of commitb475423on comfy-multi-player'smainbranch (where PR #245 has now merged), rather than a published npm version — because that fix hasn't been published to npm yet. This anchors the pin to a permanentmaincommit instead of the now-merged (and possibly soon-deleted) feature branch, so it won't break if that branch is removed. Once comfy-multi-player publishes a release containing #245, this pin should be replaced with the released npm version string.Not the same bug as #18375: that fix addresses a
LinkMaprevision-cache race that only matters when aconnectdisplaces an existing occupant on an already-live slot (e.g. an autogrow hand-wire). This batch has no existing occupant and no live node for either target before the op arrives, so that code path never triggers here.Tests:
agentInsertWorkflowLinks.regression.test.tscovers:🤖 Generated with Claude Code
https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY