Repository navigation
test: cover asset panel drag onto existing Load Image node bypassing upload - #18180
Conversation
…upload Dragging an item from the Asset Library panel onto an existing Load Image node's widget updates the widget's filename correctly but the preview shows a broken image, because useNodeDragAndDrop.ts's onResultItemDrop path treats the drag payload's original job location (filename/subfolder/type from MediaAssetCard.vue's dragStart) as already uploaded and calls onUploadComplete directly, skipping the real /upload/image POST that a raw file drop or paste performs. When that location was the ephemeral temp folder from a since-finished job, nothing backs the resulting widget value and the live preview 404s. Adds a failing (test.fail) Playwright e2e repro asserting: the widget value updates to the annotated temp-folder filename, no request ever hits /upload/image, and the node's image-load-error state becomes visible. Repro only, no fix.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2074 passed, 0 failed · 2 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since eca31830869f2222152350b45a210f1bde14082e
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.96 MB gzip 🔴 +6 BDetailsSummary
Category Glance App Entry Points — 3.87 kB (baseline 3.87 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.46 MB (baseline 1.46 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 123 kB (baseline 123 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.88 MB (baseline 3.88 MB) • 🔴 +686 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 577 kB (baseline 577 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 19 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.8 MB (baseline 17.8 MB) • 🟢 -495 BBundles that do not match a named category
Status: 73 added / 73 removed / 229 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-22T00:06:59.701Z",
"gitSha": "06f0bf51b5d9476a0748b13f92985d65337a1a87",
"branch": "test/asset-panel-drag-onto-load-image-widget",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1991.2319999999681,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.8790000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.74799999999993,
"heapDeltaBytes": 12868456,
"heapUsedBytes": 74991604,
"domNodes": -261,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.292,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2006.4180000000533,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.145000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.38300000000004,
"heapDeltaBytes": -1535132,
"heapUsedBytes": 59841180,
"domNodes": -263,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 11.738000000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1978.679999999997,
"styleRecalcs": 73,
"styleRecalcDurationMs": 22.633,
"layouts": 14,
"layoutDurationMs": 3.5860000000000007,
"taskDurationMs": 954.0730000000001,
"heapDeltaBytes": -1310596,
"heapUsedBytes": 60839592,
"domNodes": -261,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 165.443,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1708.8549999999714,
"styleRecalcs": 74,
"styleRecalcDurationMs": 25.983,
"layouts": 14,
"layoutDurationMs": 4.588,
"taskDurationMs": 772.542,
"heapDeltaBytes": 18931048,
"heapUsedBytes": 80980408,
"domNodes": -261,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 136.70399999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.2799999999784,
"styleRecalcs": 30,
"styleRecalcDurationMs": 12.983000000000002,
"layouts": 6,
"layoutDurationMs": 0.9800000000000002,
"taskDurationMs": 293.801,
"heapDeltaBytes": 2388664,
"heapUsedBytes": 64687432,
"domNodes": 75,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 12.611,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.9919999999665,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.282,
"layouts": 6,
"layoutDurationMs": 1.0770000000000002,
"taskDurationMs": 309.978,
"heapDeltaBytes": 2207052,
"heapUsedBytes": 64451636,
"domNodes": 75,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 13.161000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 532.6729999999884,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.359,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.36,
"heapDeltaBytes": 17959240,
"heapUsedBytes": 79920460,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 134.02999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 557.0480000000089,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.408000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.432,
"heapDeltaBytes": 17863624,
"heapUsedBytes": 80151356,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 137.919,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 993.2269999999903,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.0510000000002,
"heapDeltaBytes": 35295312,
"heapUsedBytes": 103045760,
"domNodes": 0,
"jsHeapTotalBytes": 19296256,
"scriptDurationMs": 48.565,
"eventListeners": 0,
"totalBlockingTimeMs": 388,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1059.8240000000487,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 727.694,
"heapDeltaBytes": 38237420,
"heapUsedBytes": 107073268,
"domNodes": 0,
"jsHeapTotalBytes": 18771968,
"scriptDurationMs": 55.41299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 444,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 766.4829999999938,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.36499999999995,
"heapDeltaBytes": 13605204,
"heapUsedBytes": 89978532,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 111.57800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 155,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 796.7479999999796,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.68899999999996,
"heapDeltaBytes": 15345928,
"heapUsedBytes": 90780496,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 130.04299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 169,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7260.198000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6411.462,
"heapDeltaBytes": 12335112,
"heapUsedBytes": 93975892,
"domNodes": -16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 5092.959,
"eventListeners": 0,
"totalBlockingTimeMs": 35,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7040.846999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6176.9800000000005,
"heapDeltaBytes": -262656,
"heapUsedBytes": 81520828,
"domNodes": -16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 4864.398,
"eventListeners": 0,
"totalBlockingTimeMs": 48,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7403.790000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6594.623,
"heapDeltaBytes": 2025384,
"heapUsedBytes": 83268380,
"domNodes": -14,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 5281.47,
"eventListeners": 0,
"totalBlockingTimeMs": 61,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7904.711999999904,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7099.659,
"heapDeltaBytes": 32694648,
"heapUsedBytes": 96508960,
"domNodes": -273,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 5613.802000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 63,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2025.0709999999685,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.045000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.79300000000006,
"heapDeltaBytes": -1292172,
"heapUsedBytes": 80183216,
"domNodes": -243,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 31.466999999999995,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2022.6379999999153,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.728999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 558.1080000000001,
"heapDeltaBytes": 1991428,
"heapUsedBytes": 83349428,
"domNodes": -244,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 34.541999999999994,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2091.9700000000034,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.509,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1247.913,
"heapDeltaBytes": 14849588,
"heapUsedBytes": 79464688,
"domNodes": 8,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 644.849,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2234.5249999999623,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.793000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1461.515,
"heapDeltaBytes": -11893892,
"heapUsedBytes": 68976900,
"domNodes": -223,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 706.8019999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3173.5649999999964,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.180999999999997,
"layouts": 60,
"layoutDurationMs": 12.251000000000001,
"taskDurationMs": 1365.1530000000002,
"heapDeltaBytes": 9456548,
"heapUsedBytes": 73896944,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 631.17,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3290.0569999999334,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.941999999999998,
"layouts": 60,
"layoutDurationMs": 13.595,
"taskDurationMs": 1497.8999999999999,
"heapDeltaBytes": 8119552,
"heapUsedBytes": 74020780,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 669.735,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2297.232000000008,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.791,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1562.9689999999998,
"heapDeltaBytes": -16995220,
"heapUsedBytes": 69064932,
"domNodes": -226,
"jsHeapTotalBytes": 1339392,
"scriptDurationMs": 776.894,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2502.582000000075,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.680000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1687.6109999999999,
"heapDeltaBytes": 22037732,
"heapUsedBytes": 90037536,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 822.817,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2016.5989999999852,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.416,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.9819999999999,
"heapDeltaBytes": -7330552,
"heapUsedBytes": 81365012,
"domNodes": -251,
"jsHeapTotalBytes": 1077248,
"scriptDurationMs": 32.32300000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2017.5289999999677,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.394999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 570.2589999999999,
"heapDeltaBytes": -5010080,
"heapUsedBytes": 84166176,
"domNodes": -245,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 36.54399999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 525.0149999999962,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.455,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 321.922,
"heapDeltaBytes": 13559608,
"heapUsedBytes": 76371384,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 116.29599999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 512.738000000013,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.33,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 308.493,
"heapDeltaBytes": 13990376,
"heapUsedBytes": 76498220,
"domNodes": 14,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 113.314,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2010.3179999999838,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.247000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 360.22700000000003,
"heapDeltaBytes": 3107572,
"heapUsedBytes": 65811248,
"domNodes": -276,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.877999999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1991.0960000000841,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.292000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.336,
"heapDeltaBytes": 15959616,
"heapUsedBytes": 79517944,
"domNodes": -276,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.444000000000003,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.9680000000076,
"styleRecalcs": 77,
"styleRecalcDurationMs": 22.990999999999996,
"layouts": 18,
"layoutDurationMs": 4.781000000000001,
"taskDurationMs": 622.4150000000001,
"heapDeltaBytes": 17473276,
"heapUsedBytes": 81019208,
"domNodes": -276,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 85.033,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.378000000076,
"styleRecalcs": 78,
"styleRecalcDurationMs": 27.234,
"layouts": 18,
"layoutDurationMs": 5.71,
"taskDurationMs": 700.662,
"heapDeltaBytes": -579092,
"heapUsedBytes": 62249588,
"domNodes": -277,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 98.69500000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 884.1160000000627,
"styleRecalcs": 17,
"styleRecalcDurationMs": 21.931000000000004,
"layouts": 5,
"layoutDurationMs": 9.431,
"taskDurationMs": 707.0560000000002,
"heapDeltaBytes": -6459976,
"heapUsedBytes": 86608204,
"domNodes": 13667,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 22.046999999999997,
"eventListeners": 2383,
"totalBlockingTimeMs": 90,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8249.730999999996,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.777,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4591.856,
"heapDeltaBytes": -13212312,
"heapUsedBytes": 68173720,
"domNodes": -244,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 2182.9460000000004,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8249.186000000009,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.973000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4854.084999999999,
"heapDeltaBytes": -14571068,
"heapUsedBytes": 67069852,
"domNodes": -251,
"jsHeapTotalBytes": 5009408,
"scriptDurationMs": 2221.0190000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 14297.140000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14072.239,
"heapDeltaBytes": -24107220,
"heapUsedBytes": 186922108,
"domNodes": -8061,
"jsHeapTotalBytes": -6856704,
"scriptDurationMs": 207.82399999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15155.873999999927,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15108.582999999999,
"heapDeltaBytes": -61713680,
"heapUsedBytes": 177572748,
"domNodes": -8061,
"jsHeapTotalBytes": -20942848,
"scriptDurationMs": 232.17699999999996,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16875.951000000045,
"styleRecalcs": 119,
"styleRecalcDurationMs": 14.383000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16709.344,
"heapDeltaBytes": -32285520,
"heapUsedBytes": 177948704,
"domNodes": -8061,
"jsHeapTotalBytes": -14721024,
"scriptDurationMs": 704.033,
"eventListeners": -14928,
"totalBlockingTimeMs": 15,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18378.608999999982,
"styleRecalcs": 126,
"styleRecalcDurationMs": 19.47499999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18325.384,
"heapDeltaBytes": -61035340,
"heapUsedBytes": 178243812,
"domNodes": -8061,
"jsHeapTotalBytes": -18321408,
"scriptDurationMs": 799.5,
"eventListeners": -14928,
"totalBlockingTimeMs": 37,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5192.210999999929,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.37300000000001,
"layouts": 20,
"layoutDurationMs": 21.236000000000004,
"taskDurationMs": 5163.706,
"heapDeltaBytes": -33130124,
"heapUsedBytes": 184965492,
"domNodes": -8062,
"jsHeapTotalBytes": 15527936,
"scriptDurationMs": 85.199,
"eventListeners": -14928,
"totalBlockingTimeMs": 234,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5555.545000000052,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.91400000000003,
"layouts": 20,
"layoutDurationMs": 25.72200000000001,
"taskDurationMs": 5538.45,
"heapDeltaBytes": -49754616,
"heapUsedBytes": 169894192,
"domNodes": -8061,
"jsHeapTotalBytes": 11423744,
"scriptDurationMs": 93.145,
"eventListeners": -14928,
"totalBlockingTimeMs": 402,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7214.275000000043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7176.772999999999,
"heapDeltaBytes": 383600,
"heapUsedBytes": 193293232,
"domNodes": 0,
"jsHeapTotalBytes": -8650752,
"scriptDurationMs": 102.877,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7688.6109999999235,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7662.911999999998,
"heapDeltaBytes": 11105832,
"heapUsedBytes": 168398828,
"domNodes": -1,
"jsHeapTotalBytes": -7077888,
"scriptDurationMs": 118.28800000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 87.3109999999997,
"styleRecalcs": 6,
"styleRecalcDurationMs": 12.295999999999998,
"layouts": 4,
"layoutDurationMs": 1.6589999999999998,
"taskDurationMs": 68.756,
"heapDeltaBytes": 3324376,
"heapUsedBytes": 65090040,
"domNodes": 134,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.14,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 438.97199999992154,
"styleRecalcs": 15,
"styleRecalcDurationMs": 22.203000000000003,
"layouts": 4,
"layoutDurationMs": 1.948,
"taskDurationMs": 108.09300000000002,
"heapDeltaBytes": 4882928,
"heapUsedBytes": 66479268,
"domNodes": 123,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.036,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🎨 Storybook: ✅ Built — View Storybook |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18180 +/- ##
==========================================
+ Coverage 82.81% 84.23% +1.41%
==========================================
Files 2948 2278 -670
Lines 145159 129281 -15878
Branches 39267 33558 -5709
==========================================
- Hits 120209 108895 -11314
+ Misses 23684 20090 -3594
+ Partials 1266 296 -970
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 883 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
|
Fixed the CI failure — it was passing Root cause: the mock asset's Fix (79fd02c): swapped in UUID-shaped ids, matching the pattern already used by Verified via lint/format/ 🤖 Generated with Claude Code |
The repro spec's mock asset used non-UUID strings for id/job_id (stale-temp-preview-001, job-stale-temp-001). The generation API's zAsset schema (packages/ingest-types/src/zod.gen.ts) requires both as UUIDs, so useAssetsQuery's assetResponseSchema.safeParse() silently rejected the whole mocked /api/assets response and the assets panel never rendered a card. That's why CI's test.fail() run "passed" for the wrong reason: it timed out in AssetsSidebarTab.waitForAssets() during setup, never reaching the drag/drop or the widget/upload/ preview-error assertions the test is meant to guard. Swapping in UUID-shaped ids (matching the pattern already used by AGENT_VIDEO_ASSET in assetFixtures.ts) lets the mock asset pass schema validation and render, so the test can reach its real assertions.
79fd02c to
6f386ad
Compare
|
Root cause: not the UUID fix itself, and not infra — it's a second, previously-unexercised bug in the test file. Before the UUID fix, the mocked asset failed schema validation and the test died early in
🤖 Generated with Claude Code |
card.dragTo(loadImageNode) dragged onto the Vue-rendered node's own DOM element, which has no drop handler and let the drag hang until the video job's inflated 180s test timeout (opaque "Test timeout of 180000ms exceeded", no assertion ever ran). assets.spec.ts's identical "Dragging outputs from assets skips upload" scenario drags onto comfyPage.canvas at the node's center via canvasOps.getNodeCenterByTitle, matching where useNodeDragAndDrop.ts's drop handler actually lives. Switching to that convention lets the drop resolve so the test reaches its real assertions.
62e8f9b to
b13d1c0
Compare
… repro The Load Image Vue node's own DOM overlays the canvas at its center (pointer-events-auto), so Playwright's actionability check on the canvas drop target never resolves and the test hangs to the full 180s CI timeout instead of reaching test.fail()'s assertions. force: true bypasses that check, matching the same pattern already used for slot-drag overlap in linkInteraction.spec.ts.
christian-byrne
left a comment
There was a problem hiding this comment.
The hosted expected failure still does not demonstrate the reported preview bug. Please correct the drag precondition and assert the healthy outcome before treating this as a regression test. I read the original Slack replies, attached screenshot/report and this head's hosted report; I did not run a new local browser test.
Christian's review on this head's CI run found the test failing at the widget-filename assertion itself (received the workflow's default example.png, not the dragged temp filename), never reaching the preview assertions - the expected failure was passing for the wrong reason and didn't reproduce the report. Move the drag's resulting widget value to a plain assertion above test.fail() so a broken drop now fails loudly as a setup problem instead of being swallowed as an expected failure. The single test.fail()-guarded assertion now checks the healthy outcome instead of the broken one: the preview loads and no image-load error shows. Mock /view to keep failing only for the literal stale temp reference (matching the report) while succeeding for any other resolution, since the RCA leaves the fix's shape (re-upload vs. reading the asset's own persisted location) open. Drop the hard zero-uploads assertion for the same reason.
christian-byrne
left a comment
There was a problem hiding this comment.
You need to add a commit that fixes the issue.
Addresses review feedback: #18180 (comment)
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: ready to approve
I found no blocking defect. The available-temp path is now fixed and the unavailable-source case remains an explicit expected failure. I left five non-blocking inline findings.
Finding without an inline anchor
- P2: The PR description is stale. It still calls this a test-only change with no production fix, says the drag generally ends in an image error, and says annotated-path parsing cannot fix the reproduction. This head adds
parseAnnotatedPath, uses it innodeOutputStore, and requires a healthy preview for the available-temp case. Please update the description to separate the fixed available-file case from the still-failing unavailable-file recovery case.
Existing findings checked
- Christian Byrne's drag-precondition finding is addressed. The widget-value poll now runs before
test.fail, and the test distinguishes available and unavailable temp sources. - Christian Byrne's inverted-expectation finding is addressed. Both cases assert the desired visible preview and hidden error; only the unavailable-source case is marked as an expected failure.
Checked and cleared
- I kept the unavailable-source test title in desired-behavior form. Other expected-failure tests in this repository follow that convention, and
test.failrecords the current status. - Fallow's store-contract warning is clear because the store shape did not change; the intended edge-case behavior did.
- Fallow's
createAnnotatedPathcontract warning is clear because the existing function and overloads did not change; this diff adds a separate export.
Coverage
Standard-depth correctness, maintainability, idiomaticity, tests, and documentation lanes reviewed all five changed files. The Playwright lane inventoried 745 helper/assertion methods across 105 fixture files and applied checks A through H plus every repository rulebook item. Focused Vitest passed 62 tests in two files. App and browser typechecks, changed-file ESLint, and changed-file formatting passed. Fallow reported no changed-file complexity or duplication issue. I did not run the Cloud Playwright case locally because it needs the Cloud/backend test environment; its CI check was still pending at review time. No CI check had failed for the reviewed SHA.
|
CI found a real regression from this commit's Root cause: A minimal fix likely needs Generated by Claude Code |
This comment has been minimized.
This comment has been minimized.
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: ready to approve
I found no blocking defect. The follow-up fixes the linked-core-media compatibility regression and addresses all five prior inline findings. I left two non-blocking inline findings about preserving the folder-root type and testing Load3D at its consumer boundary.
Finding without an inline anchor
- P2: The PR title and description are now materially stale. They still present this as a test-only reproduction with no production fix, say annotated-path parsing cannot fix the available-file case, and claim the E2E asserts that no
/upload/imagerequest occurs. This head includes the production parser/store/Load3D fix, and the current spec contains no upload-request assertion. Please update the title and description to match the actual scope and distinguish the fixed available-file case from the deferred unavailable-source recovery case.
Prior findings checked
- The duplicate-parser finding is addressed:
parseAnnotatedPathis now the authoritative parser used by the store, image utility, and Load3D. - The animated-classification gap is addressed with an annotated PNG regression asserting
isAnimated. - The browser fixture, named
test.stepphases, and redundant-comment findings are addressed. - Christian Byrne's linked-core-media regression report is addressed. The stored preview retains the annotated filename while keeping the explicit
inputtype, and the full E2E suite is green on this SHA.
Checked and cleared
- I did not request another
LoadImageOutputunit test becausewidgetValuePersistence.spec.tsalready exercises that class and asserts its preview URL retains the annotated filename. - I kept the unavailable-source expected-failure title because the recovery behavior is explicitly deferred and desired-behavior titles are the repository convention.
- Fallow's four public-contract decisions are clear: store and image-parser output shapes, Load3D's default API, and the existing
createAnnotatedPathoverloads remain compatible. Its remaining dependency/complexity output is baseline noise.
Coverage
Standard-depth correctness, maintainability, idiomaticity, tests, and documentation lanes reviewed all nine changed files. Focused Vitest passed 114 tests across four files. Full app and browser typechecks, changed-file ESLint, changed-file formatting, and Fallow passed locally. All current GitHub checks are completed successfully or intentionally skipped, including Cloud and sharded Playwright, the ecosystem matrix, lint/format, unit tests, and Fallow.
| subfolder?: string | ||
| } | ||
|
|
||
| export function parseAnnotatedPath( |
There was a problem hiding this comment.
P2: fallbackRoot and the returned rootFolder are unrestricted strings even though this parser recognizes only the ResultItemType domain (input | output | temp). That lets Load3D’s broad setting type weaken the shared source of truth. Please type both as ResultItemType and narrow Load3D’s loadFolder/setting boundary to that union instead of widening the parser.
There was a problem hiding this comment.
Tracked as FE-2776. The PR merged with this thread unresolved, so the finding is carried in Linear rather than lost here. Filed automatically; close the ticket if the finding is no longer true at main.
| }) | ||
|
|
||
| describe('parseAnnotatedFilename', () => { | ||
| describe('parseAnnotatedPath', () => { |
There was a problem hiding this comment.
P2: These tests now call parseAnnotatedPath directly, so they only retest the utility grammar inside the Load3D suite; they would pass if Load3DConfiguration stopped delegating to the parser. Please move the grammar matrix to createAnnotatedPath.test.ts and replace it here with one consumer-level case that passes an annotated model value through Load3DConfiguration and asserts the parsed path/root reach URL generation or model loading.
There was a problem hiding this comment.
Tracked as FE-2777. The PR merged with this thread unresolved, so the finding is carried in Linear rather than lost here. Filed automatically; close the ticket if the finding is no longer true at main.
Minimal fix for the two open P2 nits + a title/description refreshStatus check first: head is still 1.
|
|
|
|
|
…upload (#18180) <!-- ccr-slack-attribution --> _Requested by **Jo Zhang** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789875316334739)_ Dragging an item out of the Asset Library panel onto an **existing** Load Image node's widget (not empty canvas) updates the widget's filename correctly, but the node's preview shows a broken image / "Image does not exist" instead of the picture. This adds a failing (`test.fail`) e2e repro. No fix included, per the reporting thread's request. `MediaAssetCard.vue`'s `dragStart()` reads the asset's *original* output location straight off its metadata (`filename`/`subfolder`/`type` — e.g. `ComfyUI_temp_<random>_00001_.png [temp]`, the same shape `folder_paths.py`'s own temp-file naming produces) and publishes it as `application/x-comfy-asset-info`. `useNodeDragAndDrop.ts`'s drop handler sees that MIME type and treats it as an already-uploaded `ResultItem`, calling `onResultItemDrop` -> `onUploadComplete` directly (`useNodeImageUpload.ts`). That path never POSTs to `/upload/image` the way a real OS file drag or paste does, so nothing copies (or even checks for) the file at the location the card's metadata names. When that location was the ephemeral `temp` folder from a since-finished job, the widget value becomes a real-looking annotated path that nothing backs, and the live preview's `/view` request 404s. This is a **different mechanism** from two other bugs in this area: - The agent-CRDT stale-preview family: writes bypass `widget.callback`/`onWidgetChanged`, leaving a valid-but-stale image on screen until refresh. Here the callback/`onWidgetChanged` chain runs exactly as designed — the value it commits was just never a real, current upload. - The open "resolve annotated widget values to their own directory" fix (#15065): that fixes `nodeOutputStore.createOutputs` mis-parsing an annotated `[output]`/`[temp]` value into the wrong `/view` query params. That PR's own description scopes out "the drag-drop preview-restore... half" of this bug family as a separate, unaddressed issue — this PR is that other half. Even with #15065's URL-parsing fix applied, this repro still 404s, because the dragged asset's file was never re-uploaded/verified to exist at all; only its *reported* location is now correctly formatted. - **What**: `browser_tests/tests/sidebar/assetPanelDragOntoLoadImageWidget.spec.ts` — mocks a job-grouped, `temp`-tagged Cloud asset (mirroring a stale intermediate output from a finished job), loads `widgets/load_image_widget`, drags the asset card onto the existing Load Image node, then asserts: the widget value becomes the annotated temp-folder filename, no request ever hits `/upload/image`, and the node's image-load-error state (`TestIds.errors.imageLoadError`) becomes visible. - Test only, no production code changed. - The e2e was not run locally (no ComfyUI/Cloud backend available in this environment); lint, format, and both typecheck scopes (`browser_tests` and the whole app) pass. CI should confirm this fails for the intended reason (broken-image/404, not a setup error) before anyone builds a fix on top of it. - Repro-only per request — no production fix included. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01Ws2BqUcMwaeUuPpKdYNxPV --- _Generated by [Claude Code](https://claude.ai/code/session_01Ws2BqUcMwaeUuPpKdYNxPV)_ --------- Co-authored-by: bymyself <cbyrne@comfy.org> (cherry picked from commit d3b73c8)
…upload (#18180) <!-- ccr-slack-attribution --> _Requested by **Jo Zhang** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789875316334739)_ Dragging an item out of the Asset Library panel onto an **existing** Load Image node's widget (not empty canvas) updates the widget's filename correctly, but the node's preview shows a broken image / "Image does not exist" instead of the picture. This adds a failing (`test.fail`) e2e repro. No fix included, per the reporting thread's request. `MediaAssetCard.vue`'s `dragStart()` reads the asset's *original* output location straight off its metadata (`filename`/`subfolder`/`type` — e.g. `ComfyUI_temp_<random>_00001_.png [temp]`, the same shape `folder_paths.py`'s own temp-file naming produces) and publishes it as `application/x-comfy-asset-info`. `useNodeDragAndDrop.ts`'s drop handler sees that MIME type and treats it as an already-uploaded `ResultItem`, calling `onResultItemDrop` -> `onUploadComplete` directly (`useNodeImageUpload.ts`). That path never POSTs to `/upload/image` the way a real OS file drag or paste does, so nothing copies (or even checks for) the file at the location the card's metadata names. When that location was the ephemeral `temp` folder from a since-finished job, the widget value becomes a real-looking annotated path that nothing backs, and the live preview's `/view` request 404s. This is a **different mechanism** from two other bugs in this area: - The agent-CRDT stale-preview family: writes bypass `widget.callback`/`onWidgetChanged`, leaving a valid-but-stale image on screen until refresh. Here the callback/`onWidgetChanged` chain runs exactly as designed — the value it commits was just never a real, current upload. - The open "resolve annotated widget values to their own directory" fix (#15065): that fixes `nodeOutputStore.createOutputs` mis-parsing an annotated `[output]`/`[temp]` value into the wrong `/view` query params. That PR's own description scopes out "the drag-drop preview-restore... half" of this bug family as a separate, unaddressed issue — this PR is that other half. Even with #15065's URL-parsing fix applied, this repro still 404s, because the dragged asset's file was never re-uploaded/verified to exist at all; only its *reported* location is now correctly formatted. - **What**: `browser_tests/tests/sidebar/assetPanelDragOntoLoadImageWidget.spec.ts` — mocks a job-grouped, `temp`-tagged Cloud asset (mirroring a stale intermediate output from a finished job), loads `widgets/load_image_widget`, drags the asset card onto the existing Load Image node, then asserts: the widget value becomes the annotated temp-folder filename, no request ever hits `/upload/image`, and the node's image-load-error state (`TestIds.errors.imageLoadError`) becomes visible. - Test only, no production code changed. - The e2e was not run locally (no ComfyUI/Cloud backend available in this environment); lint, format, and both typecheck scopes (`browser_tests` and the whole app) pass. CI should confirm this fails for the intended reason (broken-image/404, not a setup error) before anyone builds a fix on top of it. - Repro-only per request — no production fix included. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01Ws2BqUcMwaeUuPpKdYNxPV --- _Generated by [Claude Code](https://claude.ai/code/session_01Ws2BqUcMwaeUuPpKdYNxPV)_ --------- Co-authored-by: bymyself <cbyrne@comfy.org> (cherry picked from commit d3b73c8)
… Image node bypassing upload (#18465) Automated backport of #18180 to `cloud/1.54`. The bot's auto-backport (`comfy-pr-bot`) failed on this branch with merge conflicts in: - `src/extensions/core/load3d/Load3DConfiguration.test.ts` - `src/extensions/core/load3d/Load3DConfiguration.ts` - `src/utils/createAnnotatedPath.test.ts` ## Root cause of the conflict Not a stacking conflict against any of the PRs the bot listed as still-open on `cloud/1.54` (#18418, #18411, #18370, #18367, #18355, #18351) — none of them touch these files. The real cause is identical to the `core/1.54` backport: `cloud/1.54` never received an **already-merged, unrelated** PR, #17537 ("Load3D preview capture stale after agent-driven model_file change"), which is not on the bot's open-PR list and is not itself labeled for backport. That PR: - added a `DEFAULT_GIZMO`/`GizmoConfig` block to `Load3DConfiguration.ts` right next to the `parseAnnotatedFilename` helper that #18180 deletes (textual adjacency, not a real dependency — the gizmo code was left out, since it's out of scope here and `cloud/1.54` has no other reference to it), and added `ComfyApi`/`ComfyApp` test imports unused on this branch (dropped), - moved the `ResultItem` type from `@/schemas/apiSchema` to `@/platform/remote/comfyui/execution/types` on `main`, which `cloud/1.54` hasn't picked up (kept the branch's existing `@/schemas/apiSchema` import), and - added an `app.getRandParam()` call inside `nodeOutputStore.ts` (already present on `cloud/1.54` from an earlier point, unrelated to #18180) whose test mock in `nodeOutputStore.test.ts` was missing `getRandParam`, only surfaced now because #18180's new test is the first to exercise `getNodeImageUrls()` on this file — added the missing mock entry. Resolved by taking #18180's actual change (removing the local `parseAnnotatedFilename` in favor of the shared `parseAnnotatedPath` util) while leaving everything from #17537 out, since it isn't part of this branch. ## Verification - `pnpm exec vitest run` on the touched spec files (`Load3DConfiguration.test.ts`, `createAnnotatedPath.test.ts`, `nodeOutputStore.test.ts`, `imageUtil.test.ts`) — all pass (113/113) - `pnpm typecheck` — clean - `pnpm exec eslint` on changed files — no errors (2 pre-existing `apiSchema` deprecation warnings, unrelated to this change) - `pnpm exec oxfmt --check` on changed files — clean - The new Playwright e2e (`assetPanelDragOntoLoadImageWidget.spec.ts`) was not run locally (no backend available), consistent with the original PR's own review notes. <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-org.slack.com/archives/C0BGH348Z0C/p1789875316334739)_ --- _Generated by [Claude Code](https://claude.ai/code/session_01Ws2BqUcMwaeUuPpKdYNxPV)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: bymyself <cbyrne@comfy.org>
The core/1.54 branch's app mock predates the getRandParam() addition to src/scripts/app.ts (already backported here), so it was never updated to stub it. The new "previews an annotated widget value from its own directory" test (backport of #18180) is the first test in this file to exercise buildImageUrls(), which calls app.getRandParam(), surfacing the stale mock as a TypeError. Matches the mock already present on main and on backport-18180-to-cloud-1.54. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ws2BqUcMwaeUuPpKdYNxPV
…upload (#18180) <!-- ccr-slack-attribution --> _Requested by **Jo Zhang** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789875316334739)_ Dragging an item out of the Asset Library panel onto an **existing** Load Image node's widget (not empty canvas) updates the widget's filename correctly, but the node's preview shows a broken image / "Image does not exist" instead of the picture. This adds a failing (`test.fail`) e2e repro. No fix included, per the reporting thread's request. `MediaAssetCard.vue`'s `dragStart()` reads the asset's *original* output location straight off its metadata (`filename`/`subfolder`/`type` — e.g. `ComfyUI_temp_<random>_00001_.png [temp]`, the same shape `folder_paths.py`'s own temp-file naming produces) and publishes it as `application/x-comfy-asset-info`. `useNodeDragAndDrop.ts`'s drop handler sees that MIME type and treats it as an already-uploaded `ResultItem`, calling `onResultItemDrop` -> `onUploadComplete` directly (`useNodeImageUpload.ts`). That path never POSTs to `/upload/image` the way a real OS file drag or paste does, so nothing copies (or even checks for) the file at the location the card's metadata names. When that location was the ephemeral `temp` folder from a since-finished job, the widget value becomes a real-looking annotated path that nothing backs, and the live preview's `/view` request 404s. This is a **different mechanism** from two other bugs in this area: - The agent-CRDT stale-preview family: writes bypass `widget.callback`/`onWidgetChanged`, leaving a valid-but-stale image on screen until refresh. Here the callback/`onWidgetChanged` chain runs exactly as designed — the value it commits was just never a real, current upload. - The open "resolve annotated widget values to their own directory" fix (#15065): that fixes `nodeOutputStore.createOutputs` mis-parsing an annotated `[output]`/`[temp]` value into the wrong `/view` query params. That PR's own description scopes out "the drag-drop preview-restore... half" of this bug family as a separate, unaddressed issue — this PR is that other half. Even with #15065's URL-parsing fix applied, this repro still 404s, because the dragged asset's file was never re-uploaded/verified to exist at all; only its *reported* location is now correctly formatted. - **What**: `browser_tests/tests/sidebar/assetPanelDragOntoLoadImageWidget.spec.ts` — mocks a job-grouped, `temp`-tagged Cloud asset (mirroring a stale intermediate output from a finished job), loads `widgets/load_image_widget`, drags the asset card onto the existing Load Image node, then asserts: the widget value becomes the annotated temp-folder filename, no request ever hits `/upload/image`, and the node's image-load-error state (`TestIds.errors.imageLoadError`) becomes visible. - Test only, no production code changed. - The e2e was not run locally (no ComfyUI/Cloud backend available in this environment); lint, format, and both typecheck scopes (`browser_tests` and the whole app) pass. CI should confirm this fails for the intended reason (broken-image/404, not a setup error) before anyone builds a fix on top of it. - Repro-only per request — no production fix included. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01Ws2BqUcMwaeUuPpKdYNxPV --- _Generated by [Claude Code](https://claude.ai/code/session_01Ws2BqUcMwaeUuPpKdYNxPV)_ --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: bymyself <cbyrne@comfy.org> (cherry picked from commit d3b73c8)
…upload (#18180) <!-- ccr-slack-attribution --> _Requested by **Jo Zhang** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789875316334739)_ Dragging an item out of the Asset Library panel onto an **existing** Load Image node's widget (not empty canvas) updates the widget's filename correctly, but the node's preview shows a broken image / "Image does not exist" instead of the picture. This adds a failing (`test.fail`) e2e repro. No fix included, per the reporting thread's request. `MediaAssetCard.vue`'s `dragStart()` reads the asset's *original* output location straight off its metadata (`filename`/`subfolder`/`type` — e.g. `ComfyUI_temp_<random>_00001_.png [temp]`, the same shape `folder_paths.py`'s own temp-file naming produces) and publishes it as `application/x-comfy-asset-info`. `useNodeDragAndDrop.ts`'s drop handler sees that MIME type and treats it as an already-uploaded `ResultItem`, calling `onResultItemDrop` -> `onUploadComplete` directly (`useNodeImageUpload.ts`). That path never POSTs to `/upload/image` the way a real OS file drag or paste does, so nothing copies (or even checks for) the file at the location the card's metadata names. When that location was the ephemeral `temp` folder from a since-finished job, the widget value becomes a real-looking annotated path that nothing backs, and the live preview's `/view` request 404s. This is a **different mechanism** from two other bugs in this area: - The agent-CRDT stale-preview family: writes bypass `widget.callback`/`onWidgetChanged`, leaving a valid-but-stale image on screen until refresh. Here the callback/`onWidgetChanged` chain runs exactly as designed — the value it commits was just never a real, current upload. - The open "resolve annotated widget values to their own directory" fix (#15065): that fixes `nodeOutputStore.createOutputs` mis-parsing an annotated `[output]`/`[temp]` value into the wrong `/view` query params. That PR's own description scopes out "the drag-drop preview-restore... half" of this bug family as a separate, unaddressed issue — this PR is that other half. Even with #15065's URL-parsing fix applied, this repro still 404s, because the dragged asset's file was never re-uploaded/verified to exist at all; only its *reported* location is now correctly formatted. - **What**: `browser_tests/tests/sidebar/assetPanelDragOntoLoadImageWidget.spec.ts` — mocks a job-grouped, `temp`-tagged Cloud asset (mirroring a stale intermediate output from a finished job), loads `widgets/load_image_widget`, drags the asset card onto the existing Load Image node, then asserts: the widget value becomes the annotated temp-folder filename, no request ever hits `/upload/image`, and the node's image-load-error state (`TestIds.errors.imageLoadError`) becomes visible. - Test only, no production code changed. - The e2e was not run locally (no ComfyUI/Cloud backend available in this environment); lint, format, and both typecheck scopes (`browser_tests` and the whole app) pass. CI should confirm this fails for the intended reason (broken-image/404, not a setup error) before anyone builds a fix on top of it. - Repro-only per request — no production fix included. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01Ws2BqUcMwaeUuPpKdYNxPV --- _Generated by [Claude Code](https://claude.ai/code/session_01Ws2BqUcMwaeUuPpKdYNxPV)_ --------- Co-authored-by: bymyself <cbyrne@comfy.org> (cherry picked from commit d3b73c8)
…Image node bypassing upload (#18464) Automated backport of #18180 to `core/1.54`. The bot's auto-backport (`comfy-pr-bot`) failed on this branch with merge conflicts in: - `src/extensions/core/load3d/Load3DConfiguration.test.ts` - `src/extensions/core/load3d/Load3DConfiguration.ts` - `src/utils/createAnnotatedPath.test.ts` ## Root cause of the conflict Not a stacking conflict against any of the PRs the bot listed as still-open on `core/1.54` (#18417, #18410, #18407, #18369, #18354, #18334, #17872) — none of them touch these files. The real cause is that `core/1.54` never received an **already-merged, unrelated** PR: #17537 ("Load3D preview capture stale after agent-driven model_file change"), which is not on the bot's open-PR list and is not itself labeled for backport. That PR: - added a `DEFAULT_GIZMO`/`GizmoConfig` block to `Load3DConfiguration.ts` right next to the `parseAnnotatedFilename` helper that #18180 deletes (textual adjacency, not a real dependency — I did not port the gizmo code, since it's out of scope here and `core/1.54` has no other reference to it), and added `ComfyApi`/`ComfyApp` test imports unused on this branch (dropped), - moved the `ResultItem` type from `@/schemas/apiSchema` to `@/platform/remote/comfyui/execution/types` on `main`, which `core/1.54` hasn't picked up (kept the branch's existing `@/schemas/apiSchema` import), and - added an `app.getRandParam()` call inside `nodeOutputStore.ts` (already present on `core/1.54` from an earlier point, unrelated to #18180) whose test mock in `nodeOutputStore.test.ts` was missing `getRandParam`, only surfaced now because #18180's new test is the first to exercise `getNodeImageUrls()` on this file — added the missing mock entry. Resolved by taking #18180's actual change (removing the local `parseAnnotatedFilename` in favor of the shared `parseAnnotatedPath` util) while leaving everything from #17537 out, since it isn't part of this branch. ## Verification - `pnpm exec vitest run` on the touched spec files (`Load3DConfiguration.test.ts`, `createAnnotatedPath.test.ts`, `nodeOutputStore.test.ts`, `imageUtil.test.ts`) — all pass (113/113) - `pnpm typecheck` — clean - `pnpm exec eslint` on changed files — no errors (2 pre-existing `apiSchema` deprecation warnings, unrelated to this change) - `pnpm exec oxfmt --check` on changed files — clean - The new Playwright e2e (`assetPanelDragOntoLoadImageWidget.spec.ts`) was not run locally (no backend available), consistent with the original PR's own review notes. <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-org.slack.com/archives/C0BGH348Z0C/p1789875316334739)_ --- _Generated by [Claude Code](https://claude.ai/code/session_01Ws2BqUcMwaeUuPpKdYNxPV)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: bymyself <cbyrne@comfy.org>
Requested by Jo Zhang · Slack thread
Summary
Dragging an item out of the Asset Library panel onto an existing Load Image node's widget (not empty canvas) updates the widget's filename correctly, but the node's preview shows a broken image / "Image does not exist" instead of the picture. This adds a failing (
test.fail) e2e repro. No fix included, per the reporting thread's request.Root cause
MediaAssetCard.vue'sdragStart()reads the asset's original output location straight off its metadata (filename/subfolder/type— e.g.ComfyUI_temp_<random>_00001_.png [temp], the same shapefolder_paths.py's own temp-file naming produces) and publishes it asapplication/x-comfy-asset-info.useNodeDragAndDrop.ts's drop handler sees that MIME type and treats it as an already-uploadedResultItem, callingonResultItemDrop->onUploadCompletedirectly (useNodeImageUpload.ts). That path never POSTs to/upload/imagethe way a real OS file drag or paste does, so nothing copies (or even checks for) the file at the location the card's metadata names. When that location was the ephemeraltempfolder from a since-finished job, the widget value becomes a real-looking annotated path that nothing backs, and the live preview's/viewrequest 404s.This is a different mechanism from two other bugs in this area:
widget.callback/onWidgetChanged, leaving a valid-but-stale image on screen until refresh. Here the callback/onWidgetChangedchain runs exactly as designed — the value it commits was just never a real, current upload.nodeOutputStore.createOutputsmis-parsing an annotated[output]/[temp]value into the wrong/viewquery params. That PR's own description scopes out "the drag-drop preview-restore... half" of this bug family as a separate, unaddressed issue — this PR is that other half. Even with fix(assets): resolve annotated widget values to their own directory #15065's URL-parsing fix applied, this repro still 404s, because the dragged asset's file was never re-uploaded/verified to exist at all; only its reported location is now correctly formatted.Changes
browser_tests/tests/sidebar/assetPanelDragOntoLoadImageWidget.spec.ts— mocks a job-grouped,temp-tagged Cloud asset (mirroring a stale intermediate output from a finished job), loadswidgets/load_image_widget, drags the asset card onto the existing Load Image node, then asserts: the widget value becomes the annotated temp-folder filename, no request ever hits/upload/image, and the node's image-load-error state (TestIds.errors.imageLoadError) becomes visible.Review Focus
browser_testsand the whole app) pass. CI should confirm this fails for the intended reason (broken-image/404, not a setup error) before anyone builds a fix on top of it.🤖 Generated with Claude Code
https://claude.ai/code/session_01Ws2BqUcMwaeUuPpKdYNxPV
Generated by Claude Code