Repository navigation
Give unified-remint retry fetch its own timeout window - #18599
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2127 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 2f0b5857fce36f4b56694a110e085ec654341c51
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.99 MB gzip 🔴 +407 BDetailsSummary
Category Glance App Entry Points — 3.83 kB (baseline 3.83 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.44 MB (baseline 1.44 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.96 MB (baseline 3.96 MB) • 🔴 +1.39 kBStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 578 kB (baseline 578 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 19 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.9 MB (baseline 17.9 MB) • ⚪ 0 BBundles that do not match a named category
Status: 74 added / 74 removed / 227 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-24T00:48:42.593Z",
"gitSha": "b7dc01b819743c6d54d2be24bd258556a91c8129",
"branch": "fix/unified-remint-retry-timeout-budget",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2020.241999999996,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.736999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.78799999999995,
"heapDeltaBytes": 3972400,
"heapUsedBytes": 71677980,
"domNodes": -260,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.290000000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2012.886999999978,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.193,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.25500000000005,
"heapDeltaBytes": 5989424,
"heapUsedBytes": 73775820,
"domNodes": -261,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.781,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1760.549000000026,
"styleRecalcs": 46,
"styleRecalcDurationMs": 17.259,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 714.902,
"heapDeltaBytes": -7778176,
"heapUsedBytes": 58857636,
"domNodes": -257,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 165.213,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1770.340000000033,
"styleRecalcs": 44,
"styleRecalcDurationMs": 14.753,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 778.9809999999999,
"heapDeltaBytes": 10528828,
"heapUsedBytes": 77894408,
"domNodes": -262,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 159.47400000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.430999999995,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.203999999999999,
"layouts": 6,
"layoutDurationMs": 0.8870000000000001,
"taskDurationMs": 331.75200000000007,
"heapDeltaBytes": 2728496,
"heapUsedBytes": 70314988,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.607000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.5869999999659,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.399,
"layouts": 6,
"layoutDurationMs": 0.9440000000000001,
"taskDurationMs": 323.666,
"heapDeltaBytes": 2119544,
"heapUsedBytes": 64630092,
"domNodes": 78,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 10.452,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 631.3949999999977,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.955,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.496,
"heapDeltaBytes": 18249924,
"heapUsedBytes": 85961400,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 171.11900000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 694.543000000067,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.786999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.665,
"heapDeltaBytes": 18679128,
"heapUsedBytes": 86095572,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 171.097,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1215.106999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 909.3440000000002,
"heapDeltaBytes": -16344188,
"heapUsedBytes": 73002548,
"domNodes": -294,
"jsHeapTotalBytes": 20054016,
"scriptDurationMs": 72.04100000000001,
"eventListeners": -217,
"totalBlockingTimeMs": 564,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1225.4479999999148,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 885.7719999999999,
"heapDeltaBytes": 13281576,
"heapUsedBytes": 103536452,
"domNodes": -295,
"jsHeapTotalBytes": 22433792,
"scriptDurationMs": 69.96400000000001,
"eventListeners": -195,
"totalBlockingTimeMs": 608,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.4710000000414,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.3959999999999,
"heapDeltaBytes": 13927048,
"heapUsedBytes": 90883220,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 161.42599999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 228,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 842.7439999999251,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.86600000000067,
"heapDeltaBytes": 14393024,
"heapUsedBytes": 90395800,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 162.56300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 230,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9678.901000000053,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8818.229000000001,
"heapDeltaBytes": -14053248,
"heapUsedBytes": 68686444,
"domNodes": -18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7462.295,
"eventListeners": 0,
"totalBlockingTimeMs": 1173,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8905.930000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8287.698,
"heapDeltaBytes": -4664104,
"heapUsedBytes": 72625976,
"domNodes": -268,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7055.93,
"eventListeners": -174,
"totalBlockingTimeMs": 889,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11066.310000000045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10060.461,
"heapDeltaBytes": -7526884,
"heapUsedBytes": 74814176,
"domNodes": -10,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 8389.696,
"eventListeners": 0,
"totalBlockingTimeMs": 1511,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9919.785000000047,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8997.019,
"heapDeltaBytes": 11161500,
"heapUsedBytes": 92992032,
"domNodes": -16,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 7392.935,
"eventListeners": 0,
"totalBlockingTimeMs": 934,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2032.3339999999916,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.649000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 571.265,
"heapDeltaBytes": -3502444,
"heapUsedBytes": 83292100,
"domNodes": -242,
"jsHeapTotalBytes": -2330624,
"scriptDurationMs": 32.370999999999995,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2047.384999999963,
"styleRecalcs": 7,
"styleRecalcDurationMs": 9.691999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.508,
"heapDeltaBytes": -6270088,
"heapUsedBytes": 80695332,
"domNodes": -250,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 31.997999999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2342.691000000002,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.092999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1608.0089999999998,
"heapDeltaBytes": 14923888,
"heapUsedBytes": 79598544,
"domNodes": -250,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 838.842,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2741.6200000000117,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.272000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1695.88,
"heapDeltaBytes": 20234716,
"heapUsedBytes": 84331100,
"domNodes": -245,
"jsHeapTotalBytes": 2322432,
"scriptDurationMs": 883.376,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3585.630999999978,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.632000000000003,
"layouts": 60,
"layoutDurationMs": 12.536000000000001,
"taskDurationMs": 1651.112,
"heapDeltaBytes": 8459836,
"heapUsedBytes": 74210848,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 796.14,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3606.5830000000005,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.692,
"layouts": 60,
"layoutDurationMs": 12.730000000000002,
"taskDurationMs": 1687.9520000000002,
"heapDeltaBytes": -15413832,
"heapUsedBytes": 73747528,
"domNodes": -261,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 779.1999999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3096.5590000000134,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.678999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1931.597,
"heapDeltaBytes": 25551264,
"heapUsedBytes": 91639580,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1007.8620000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3150.845000000004,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.368000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1898.52,
"heapDeltaBytes": 23294524,
"heapUsedBytes": 91397232,
"domNodes": 6,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 975.7620000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2030.777999999998,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.671,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.1890000000002,
"heapDeltaBytes": -4845992,
"heapUsedBytes": 84089124,
"domNodes": -244,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 39.443000000000005,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2030.0260000000208,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.551999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 542.9620000000001,
"heapDeltaBytes": -4971888,
"heapUsedBytes": 83825848,
"domNodes": -246,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 35.676,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 626.8000000000029,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.13,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.371,
"heapDeltaBytes": 13769656,
"heapUsedBytes": 76885956,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 144.79899999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 602.897999999982,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.957000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.05100000000004,
"heapDeltaBytes": 13627800,
"heapUsedBytes": 83592232,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 144.589,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.8830000000025,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.413,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.626,
"heapDeltaBytes": -15439440,
"heapUsedBytes": 54544080,
"domNodes": -276,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.487000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.7799999999115,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.845999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.3109999999999,
"heapDeltaBytes": 8589028,
"heapUsedBytes": 78111048,
"domNodes": -273,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.863000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.4790000000112,
"styleRecalcs": 47,
"styleRecalcDurationMs": 15.175,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 713.5160000000001,
"heapDeltaBytes": 2886764,
"heapUsedBytes": 72858140,
"domNodes": -272,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 103.65299999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.6270000000632,
"styleRecalcs": 45,
"styleRecalcDurationMs": 13.940999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 745.9070000000002,
"heapDeltaBytes": 2122888,
"heapUsedBytes": 71986312,
"domNodes": -278,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 105.88499999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.108000000022,
"styleRecalcs": 17,
"styleRecalcDurationMs": 27.729999999999997,
"layouts": 5,
"layoutDurationMs": 12.615000000000002,
"taskDurationMs": 881.448,
"heapDeltaBytes": -6246440,
"heapUsedBytes": 81746892,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 28.838999999999995,
"eventListeners": 2383,
"totalBlockingTimeMs": 133,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8543.962000000021,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.617,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5808.3640000000005,
"heapDeltaBytes": -18850384,
"heapUsedBytes": 68054904,
"domNodes": -250,
"jsHeapTotalBytes": 5271552,
"scriptDurationMs": 2830.225,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8625.186999999984,
"styleRecalcs": 252,
"styleRecalcDurationMs": 38.641999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5761.964,
"heapDeltaBytes": -2055944,
"heapUsedBytes": 85197680,
"domNodes": -236,
"jsHeapTotalBytes": -827392,
"scriptDurationMs": 2755.1229999999996,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 16879.059999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16419.529000000002,
"heapDeltaBytes": -70058260,
"heapUsedBytes": 171127252,
"domNodes": -8061,
"jsHeapTotalBytes": -17764352,
"scriptDurationMs": 257.053,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16617.50499999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15930.430999999999,
"heapDeltaBytes": -53544764,
"heapUsedBytes": 187497328,
"domNodes": -8061,
"jsHeapTotalBytes": -12455936,
"scriptDurationMs": 242.70399999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20084.415999999976,
"styleRecalcs": 168,
"styleRecalcDurationMs": 16.93799999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19730.975000000002,
"heapDeltaBytes": -23065084,
"heapUsedBytes": 191257724,
"domNodes": -8061,
"jsHeapTotalBytes": -11354112,
"scriptDurationMs": 857.7360000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 77,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15591.850000000022,
"styleRecalcs": 79,
"styleRecalcDurationMs": 11.869000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14964.582000000002,
"heapDeltaBytes": -54463288,
"heapUsedBytes": 186580128,
"domNodes": -8061,
"jsHeapTotalBytes": -18620416,
"scriptDurationMs": 810.295,
"eventListeners": -14928,
"totalBlockingTimeMs": 28,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5980.721000000017,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.546,
"layouts": 20,
"layoutDurationMs": 22.212999999999997,
"taskDurationMs": 5867.183000000001,
"heapDeltaBytes": -57055040,
"heapUsedBytes": 183145108,
"domNodes": -8061,
"jsHeapTotalBytes": 11378688,
"scriptDurationMs": 108.746,
"eventListeners": -14928,
"totalBlockingTimeMs": 352,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6015.806999999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.39999999999998,
"layouts": 20,
"layoutDurationMs": 23.169999999999995,
"taskDurationMs": 5927.429999999999,
"heapDeltaBytes": -42268088,
"heapUsedBytes": 172532012,
"domNodes": -8061,
"jsHeapTotalBytes": 13561856,
"scriptDurationMs": 105.833,
"eventListeners": -14928,
"totalBlockingTimeMs": 398,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8197.358000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7817.902,
"heapDeltaBytes": 10401308,
"heapUsedBytes": 184142088,
"domNodes": 0,
"jsHeapTotalBytes": -14680064,
"scriptDurationMs": 118.60100000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8085.524999999961,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7717.165999999999,
"heapDeltaBytes": 25951624,
"heapUsedBytes": 189660128,
"domNodes": 0,
"jsHeapTotalBytes": -13631488,
"scriptDurationMs": 131.45599999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 487.03999999997905,
"styleRecalcs": 19,
"styleRecalcDurationMs": 25.126999999999995,
"layouts": 4,
"layoutDurationMs": 2.018,
"taskDurationMs": 139.244,
"heapDeltaBytes": 5326172,
"heapUsedBytes": 70790376,
"domNodes": 153,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 16.738999999999997,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 465.70699999995213,
"styleRecalcs": 22,
"styleRecalcDurationMs": 25.386,
"layouts": 5,
"layoutDurationMs": 2.177,
"taskDurationMs": 123.48899999999999,
"heapDeltaBytes": 5010636,
"heapUsedBytes": 70689492,
"domNodes": 150,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.934999999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #18599 +/- ##
==========================================
+ Coverage 83.67% 84.67% +0.99%
==========================================
Files 3019 2294 -725
Lines 148932 131397 -17535
Branches 38457 35552 -2905
==========================================
- Hits 124624 111256 -13368
+ Misses 23005 19841 -3164
+ Partials 1303 300 -1003
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 756 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
The retry needs a fresh per-attempt timeout, but the original timer must not keep reporting a timeout after the first fetch has already returned. Please fix the overlapping timer/telemetry lifecycle and extend the regression test to assert no timeout diagnostic is emitted when the retry succeeds.
fetchWithUnifiedRemint's post-401 retry reused the caller's original AbortSignal, so a slow re-mint round trip (its own independently bounded token exchange) could leave the retry only a few seconds of the original 60s deadline instead of a fresh one, causing spurious TimeoutErrors under load. fetchApi now passes a freshRetrySignal callback that mints a new AbortController + timeout, matching the same duration and TimeoutError semantics, only if a retry actually happens. The two other fetchWithUnifiedRemint callers (globalSettingsApi, authStore) pass no signal at all and are unaffected since the parameter is optional and defaults to the original reuse behavior.
58fbb7c to
d5e6840
Compare
The original per-request timer stayed armed through the re-mint + retry window and was only cleared in the final `.finally()`. If it fired while the retry was still in flight, it emitted a false `app:fetch_timeout` breadcrumb/telemetry event for a request that had already returned (with a 401). Clear it inside `freshRetrySignal`, right before arming the retry's own timer, so only the retry's fresh timer can fire during the retry window. Extends the "post-401 retry timeout budget" regression test to assert `trackFetchTimeout`/`addBreadcrumb` are not called when the retry succeeds.
d5e6840 to
65d5f9e
Compare
Amp-Thread-ID: https://ampcode.com/threads/T-01a0d03d-977a-71a4-9096-906ddd71e867 Co-authored-by: Amp <amp@ampcode.com>
dante01yoon
left a comment
There was a problem hiding this comment.
The follow-up still clears the original timeout too late: freshRetrySignal runs only after token re-mint completes. A delayed initial 401 can therefore let the original timer emit false timeout diagnostics during re-mint, before this callback gets a chance to clear it. The focused regression below fails on this head and passes when the initial timer is cleared before re-mint.
| // retry) -- end its timeout lifecycle now so it cannot fire the | ||
| // timeout telemetry/abort for a request that already resolved. | ||
| // Only the fresh timer armed below guards the retry window. | ||
| if (timeoutId !== undefined) clearTimeout(timeoutId) |
There was a problem hiding this comment.
issue: freshRetrySignal() is invoked only after await tryRemintToken(...) completes, so clearing the original timer here can already be too late. For example: initial fetch returns 401 at t=40s, re-mint takes 30s, and retry takes 30s. The original timer fires at t=60s during re-mint and emits trackFetchTimeout/the breadcrumb; this line does not run until t=70s, then the request still succeeds at t=100s. I reproduced this against the current head by using that timeline in the regression test: it fails with one false timeout event. Please end the initial fetch timeout when the 401 is received (before re-mint), and create the fresh retry signal immediately before the retry fetch.
dante01yoon
left a comment
There was a problem hiding this comment.
Verified on the current head: the initial fetch timeout is cleared before token re-mint begins, while the retry timeout is armed immediately before the retry fetch. The delayed-401 regression now covers the previously missed overlap and passes without timeout telemetry or breadcrumbs.
|
|
<!-- ccr-slack-attribution --> _Requested via [Slack thread](https://comfy-organization.slack.com/archives/C09KFK2ABB8/p1790161872557349)_ Fixes the pattern behind Sentry `CLOUD-FRONTEND-STAGING-4MF`/`4MG`: the unified-remint retry fetch could spuriously time out under staging load because it inherited whatever was left of the original request's 60s deadline instead of getting a full one. - **What**: `fetchApi()` (`src/scripts/api.ts`) armed a single 60s `AbortSignal` and passed it straight through to `fetchWithUnifiedRemint()`. On a 401, that function re-mints the unified Cloud JWT (`tryRemintToken` → `workspaceAuthStore.remintUnifiedOnce()` → `unifiedUser()` → `unifiedSessionClient.remint()` → `exchangeToken()`, each step with its own independent ~15s ceiling) before retrying the original request — but the retry reused the *same* original signal, so its effective budget was `60s minus whatever the re-mint round trip already spent`, not a fresh 60s. Under load, a slower-than-usual re-mint could leave the retry only a few seconds before it was aborted with `TimeoutError: Fetch timeout`, even though every individual step was within its own budget. `fetchWithUnifiedRemint()` (`src/platform/auth/unified/remintRetry.ts`) now takes an optional 4th parameter, `freshRetrySignal?: () => AbortSignal | undefined`, called only if a retry actually happens; its return value replaces the original `init.signal` on the retry `fetch`. `fetchApi()` passes a callback that mints a new `AbortController` + `setTimeout` (same duration, same `DOMException('Fetch timeout', 'TimeoutError')` construction as the existing timeout, so Sentry grouping stays consistent) combined with the caller's own `signal` via `AbortSignal.any`, and cleans up the new timer in the existing `.finally()`. `fetchWithUnifiedRemint()` has two other call sites (`globalSettingsApi.ts`, `authStore.ts`) that pass no signal at all today; the new parameter is optional and defaults to `undefined`, which keeps their behavior byte-for-byte unchanged (they can't produce this `TimeoutError` in the first place — only a benign `TypeError: Failed to fetch`). - **Breaking**: none - **Dependencies**: none - `remintRetry.ts`: build the retry `fetch`'s `init` from `freshRetrySignal()` when supplied, instead of always spreading the original `init` (which carried the shrunk signal). - `api.ts`: `freshRetrySignal` is only constructed when `timeout` is non-null (i.e. `timeoutMs` wasn't explicitly disabled), and only actually invoked by `fetchWithUnifiedRemint` if a 401 retry happens — a request that never gets a 401 pays no extra cost. - `src/scripts/api.ts`, `fetchApi()`: the new `freshRetrySignal` closure and its timer's cleanup in `.finally()` (no leaked timers on either the happy path or an error path). - `src/platform/auth/unified/remintRetry.ts`, `fetchWithUnifiedRemint()`: the retry `init` construction now branches on whether `freshRetrySignal` was supplied. - Confirmed the two other callers (`globalSettingsApi.ts`, `authStore.ts`) are unaffected — they don't pass a signal today, and the new parameter is optional and off by default. - `src/platform/auth/unified/remintRetry.test.ts`: new cases assert the retry `fetch` receives the object returned by `freshRetrySignal()` (not the original `init.signal`) when supplied, and that the callback is never called when no retry happens. - `src/scripts/api.fetchApi.test.ts`: new regression test with fake timers simulates a 401 → 55s re-mint → 30s retry sequence. Verified (via `git stash` of only the source changes, keeping the new tests) that both new tests fail against the pre-fix code — the retry test rejects with the abort from the stale signal at t=60s — and pass once the fix is restored. Fixes the pattern behind Sentry `CLOUD-FRONTEND-STAGING-4MF`/`CLOUD-FRONTEND-STAGING-4MG`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_0137jzrG6RSp5e6YgGp8kxdY --- _Generated by [Claude Code](https://claude.ai/code/session_0137jzrG6RSp5e6YgGp8kxdY)_ --------- Co-authored-by: dante01yoon <bunggl@naver.com> (cherry picked from commit e346ef9)
…window (#18673) Automated backport of #18599 to `core/1.54`. The backport bot's automated cherry-pick attempt failed with a merge conflict in `src/scripts/api.fetchApi.test.ts` (several other open PRs — #18660, #18369, #18334, #17872 — are stacked against `core/1.54` touching the same file), so this was done manually. ## What conflicted and how it was resolved - **`src/scripts/api.fetchApi.test.ts`**: only the import/mock-setup header conflicted. `core/1.54`'s auth mocking is older than `main`'s: this branch's `authStore` still talks to Firebase directly through `vuefire` + `firebase/auth` (no `firebaseIdentity` port exists here yet), so the new `describe('post-401 retry timeout budget')` test's `beforeEach` was adapted to mock `vuefire`/`firebase/auth` directly (matching the pattern already used in this branch's `authStore.test.ts`) instead of spying on `firebaseIdentity.onUserChanged`/`onTokenChanged`. The new `trackUnifiedAuthRetry`/`mockDistribution`/`mockFeatureFlags` mocks were kept, simplified to this branch's non-`fromPartial` mocking style. - **`src/platform/auth/unified/remintRetry.test.ts`**: auto-merged, but the new test referenced `useWorkspaceAuthStore()` directly; this branch's file mocks that whole module via a hoisted `mockRemint` instead, so the test was updated to use `mockRemint.mockResolvedValue(...)` like every other test in the file. - **`src/scripts/api.ts`**: auto-merged, but the new timeout-retry code called `addBreadcrumb(...)` directly; this branch imports Sentry as `import * as Sentry from '@sentry/vue'` (not a named `addBreadcrumb` import), so the call was changed to `Sentry.addBreadcrumb(...)` to match this branch's existing convention (used a few lines above in the same file). - **`src/platform/auth/unified/remintRetry.ts`**: auto-merged cleanly, no changes needed. ## Verification - `pnpm typecheck` — clean - `pnpm lint` (eslint on the touched files; `src/scripts/api.ts` is repo-ignored from eslint on this branch) — clean, no new oxlint/eslint issues - `src/scripts/api.fetchApi.test.ts` — 18/18 passing - `src/platform/auth/unified/remintRetry.test.ts` — 23/23 passing - Pre-commit hooks (oxfmt, oxlint --fix, eslint --fix, typecheck) ran clean on commit 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_0137jzrG6RSp5e6YgGp8kxdY --- _Generated by [Claude Code](https://claude.ai/code/session_0137jzrG6RSp5e6YgGp8kxdY)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: dante01yoon <bunggl@naver.com>
… window (#18674) <!-- ccr-slack-attribution --> Automated backport of #18599 to `cloud/1.54`, after the backport bot's automated cherry-pick attempt failed on a merge conflict. ## Summary Cherry-picks e346ef9 (#18599) onto `cloud/1.54`. That PR gives the unified-remint post-401 retry fetch a fresh timeout window instead of letting it inherit whatever was left of the original request's 60s deadline (Sentry `CLOUD-FRONTEND-STAGING-4MF`/`4MG`). ## Conflict and resolution - `src/scripts/api.ts` and `src/platform/auth/unified/remintRetry.ts` cherry-picked cleanly with no conflicts. - `src/scripts/api.fetchApi.test.ts` conflicted because three other open PRs (#18644, #18479, #18370) are stacked on `cloud/1.54` touching the same file, and because `cloud/1.54`'s mocking setup for this file predates several refactors that already landed on `main` (`fromPartial`/`vi.mock(import(...))` typed mocks, and a `firebaseIdentity` auth wrapper that doesn't exist on `cloud/1.54`). Resolved by keeping `cloud/1.54`'s existing plain `vi.mock('module', factory)` style and layering in only the additions the new `post-401 retry timeout budget` test needs (the `trackUnifiedAuthRetry` mock, the `mockDistribution`/`isCloud` toggle, a `useFeatureFlags` mock, and `vuefire`/`firebase/auth` stubs matching the convention already used in `authStore.test.ts`), instead of pulling over `main`'s newer typed-mock plumbing verbatim. - Also fixed two latent issues surfaced while getting the cherry-picked tests to actually pass on this branch (not part of the original PR's intent, but required for the cherry-pick to work): - `src/platform/auth/unified/remintRetry.test.ts`'s new test referenced `useWorkspaceAuthStore()` directly (that's `main`'s current test style), but `cloud/1.54`'s version of this file mocks the store via a `mockRemint` const instead and never imports `useWorkspaceAuthStore` — fixed to use `mockRemint.mockResolvedValue(...)`. - `src/scripts/api.ts`'s new retry-timeout breadcrumb called a bare `addBreadcrumb(...)`, but this file imports Sentry as `import * as Sentry from '@sentry/vue'` — fixed to `Sentry.addBreadcrumb(...)`. ## Verification - `pnpm vitest run src/scripts/api.fetchApi.test.ts src/platform/auth/unified/remintRetry.test.ts` — 41/41 tests pass. - `pnpm exec eslint` on the four touched files — clean (pre-existing, unrelated `api.ts` lint findings elsewhere in the file are untouched by this diff). - `pnpm run typecheck` (`vue-tsc --noEmit`) — clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_0137jzrG6RSp5e6YgGp8kxdY --- _Generated by [Claude Code](https://claude.ai/code/session_0137jzrG6RSp5e6YgGp8kxdY)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: dante01yoon <bunggl@naver.com>
<!-- ccr-slack-attribution --> _Requested via [Slack thread](https://comfy-organization.slack.com/archives/C09KFK2ABB8/p1790161872557349)_ ## Summary Fixes the pattern behind Sentry `CLOUD-FRONTEND-STAGING-4MF`/`4MG`: the unified-remint retry fetch could spuriously time out under staging load because it inherited whatever was left of the original request's 60s deadline instead of getting a full one. ## Changes - **What**: `fetchApi()` (`src/scripts/api.ts`) armed a single 60s `AbortSignal` and passed it straight through to `fetchWithUnifiedRemint()`. On a 401, that function re-mints the unified Cloud JWT (`tryRemintToken` → `workspaceAuthStore.remintUnifiedOnce()` → `unifiedUser()` → `unifiedSessionClient.remint()` → `exchangeToken()`, each step with its own independent ~15s ceiling) before retrying the original request — but the retry reused the *same* original signal, so its effective budget was `60s minus whatever the re-mint round trip already spent`, not a fresh 60s. Under load, a slower-than-usual re-mint could leave the retry only a few seconds before it was aborted with `TimeoutError: Fetch timeout`, even though every individual step was within its own budget. `fetchWithUnifiedRemint()` (`src/platform/auth/unified/remintRetry.ts`) now takes an optional 4th parameter, `freshRetrySignal?: () => AbortSignal | undefined`, called only if a retry actually happens; its return value replaces the original `init.signal` on the retry `fetch`. `fetchApi()` passes a callback that mints a new `AbortController` + `setTimeout` (same duration, same `DOMException('Fetch timeout', 'TimeoutError')` construction as the existing timeout, so Sentry grouping stays consistent) combined with the caller's own `signal` via `AbortSignal.any`, and cleans up the new timer in the existing `.finally()`. `fetchWithUnifiedRemint()` has two other call sites (`globalSettingsApi.ts`, `authStore.ts`) that pass no signal at all today; the new parameter is optional and defaults to `undefined`, which keeps their behavior byte-for-byte unchanged (they can't produce this `TimeoutError` in the first place — only a benign `TypeError: Failed to fetch`). - **Breaking**: none - **Dependencies**: none ## How - `remintRetry.ts`: build the retry `fetch`'s `init` from `freshRetrySignal()` when supplied, instead of always spreading the original `init` (which carried the shrunk signal). - `api.ts`: `freshRetrySignal` is only constructed when `timeout` is non-null (i.e. `timeoutMs` wasn't explicitly disabled), and only actually invoked by `fetchWithUnifiedRemint` if a 401 retry happens — a request that never gets a 401 pays no extra cost. ## Review Focus - `src/scripts/api.ts`, `fetchApi()`: the new `freshRetrySignal` closure and its timer's cleanup in `.finally()` (no leaked timers on either the happy path or an error path). - `src/platform/auth/unified/remintRetry.ts`, `fetchWithUnifiedRemint()`: the retry `init` construction now branches on whether `freshRetrySignal` was supplied. - Confirmed the two other callers (`globalSettingsApi.ts`, `authStore.ts`) are unaffected — they don't pass a signal today, and the new parameter is optional and off by default. ## Tests - `src/platform/auth/unified/remintRetry.test.ts`: new cases assert the retry `fetch` receives the object returned by `freshRetrySignal()` (not the original `init.signal`) when supplied, and that the callback is never called when no retry happens. - `src/scripts/api.fetchApi.test.ts`: new regression test with fake timers simulates a 401 → 55s re-mint → 30s retry sequence. Verified (via `git stash` of only the source changes, keeping the new tests) that both new tests fail against the pre-fix code — the retry test rejects with the abort from the stale signal at t=60s — and pass once the fix is restored. Fixes the pattern behind Sentry `CLOUD-FRONTEND-STAGING-4MF`/`CLOUD-FRONTEND-STAGING-4MG`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_0137jzrG6RSp5e6YgGp8kxdY --- _Generated by [Claude Code](https://claude.ai/code/session_0137jzrG6RSp5e6YgGp8kxdY)_ --------- Co-authored-by: dante01yoon <bunggl@naver.com> (cherry picked from commit e346ef9) (cherry picked from commit 4c0e45e)
## Summary Consolidates the verified fixes that landed on `cloud/1.54` but were absent from `cloud/1.55`: - #17486 keeps promoted dynamic-combo child links when loading workflows. - #18599 gives unified-remint retries a fresh timeout window. - #18093 allows nodes to shrink after content growth and tab switches. - #18155 resolves stale Agent bindings when workflows share a name. - #18693 keeps the Agent target aligned with the visible workflow until send or node reference. - #18619 waits for open dialogs before showing Agent consent. - #18061 deselects a node when its composer reference is removed. - #18392 marks video reply assets correctly. - #18664 records Agent panel visibility and page-hide teardown correctly. - #18911 restores Agent onboarding focus, navigation, and replay behavior. - #18911 remains deliberately excluded: its activation-telemetry substrate is cloud/1.54-only, and the original backport records that scope. This is the consolidated `cloud/1.55` carrier from the 1.54→1.55 release audit. The already-open saved-workflow backport remains in #19732 and is intentionally not duplicated here. ## Validation - Release-branch conflicts were resolved against the current cloud/1.55 Agent targeting, consent, and onboarding implementations. - CI is the authoritative full suite. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com> Co-authored-by: Maanil Verma <vermaMaanil97@gmail.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: dante01yoon <bunggl@naver.com> Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com> Co-authored-by: Hunter <huntcsg@users.noreply.github.com> Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com>
<!-- ccr-slack-attribution --> _Requested via [Slack thread](https://comfy-organization.slack.com/archives/C09KFK2ABB8/p1790161872557349)_ ## Summary Fixes the pattern behind Sentry `CLOUD-FRONTEND-STAGING-4MF`/`4MG`: the unified-remint retry fetch could spuriously time out under staging load because it inherited whatever was left of the original request's 60s deadline instead of getting a full one. ## Changes - **What**: `fetchApi()` (`src/scripts/api.ts`) armed a single 60s `AbortSignal` and passed it straight through to `fetchWithUnifiedRemint()`. On a 401, that function re-mints the unified Cloud JWT (`tryRemintToken` → `workspaceAuthStore.remintUnifiedOnce()` → `unifiedUser()` → `unifiedSessionClient.remint()` → `exchangeToken()`, each step with its own independent ~15s ceiling) before retrying the original request — but the retry reused the *same* original signal, so its effective budget was `60s minus whatever the re-mint round trip already spent`, not a fresh 60s. Under load, a slower-than-usual re-mint could leave the retry only a few seconds before it was aborted with `TimeoutError: Fetch timeout`, even though every individual step was within its own budget. `fetchWithUnifiedRemint()` (`src/platform/auth/unified/remintRetry.ts`) now takes an optional 4th parameter, `freshRetrySignal?: () => AbortSignal | undefined`, called only if a retry actually happens; its return value replaces the original `init.signal` on the retry `fetch`. `fetchApi()` passes a callback that mints a new `AbortController` + `setTimeout` (same duration, same `DOMException('Fetch timeout', 'TimeoutError')` construction as the existing timeout, so Sentry grouping stays consistent) combined with the caller's own `signal` via `AbortSignal.any`, and cleans up the new timer in the existing `.finally()`. `fetchWithUnifiedRemint()` has two other call sites (`globalSettingsApi.ts`, `authStore.ts`) that pass no signal at all today; the new parameter is optional and defaults to `undefined`, which keeps their behavior byte-for-byte unchanged (they can't produce this `TimeoutError` in the first place — only a benign `TypeError: Failed to fetch`). - **Breaking**: none - **Dependencies**: none ## How - `remintRetry.ts`: build the retry `fetch`'s `init` from `freshRetrySignal()` when supplied, instead of always spreading the original `init` (which carried the shrunk signal). - `api.ts`: `freshRetrySignal` is only constructed when `timeout` is non-null (i.e. `timeoutMs` wasn't explicitly disabled), and only actually invoked by `fetchWithUnifiedRemint` if a 401 retry happens — a request that never gets a 401 pays no extra cost. ## Review Focus - `src/scripts/api.ts`, `fetchApi()`: the new `freshRetrySignal` closure and its timer's cleanup in `.finally()` (no leaked timers on either the happy path or an error path). - `src/platform/auth/unified/remintRetry.ts`, `fetchWithUnifiedRemint()`: the retry `init` construction now branches on whether `freshRetrySignal` was supplied. - Confirmed the two other callers (`globalSettingsApi.ts`, `authStore.ts`) are unaffected — they don't pass a signal today, and the new parameter is optional and off by default. ## Tests - `src/platform/auth/unified/remintRetry.test.ts`: new cases assert the retry `fetch` receives the object returned by `freshRetrySignal()` (not the original `init.signal`) when supplied, and that the callback is never called when no retry happens. - `src/scripts/api.fetchApi.test.ts`: new regression test with fake timers simulates a 401 → 55s re-mint → 30s retry sequence. Verified (via `git stash` of only the source changes, keeping the new tests) that both new tests fail against the pre-fix code — the retry test rejects with the abort from the stale signal at t=60s — and pass once the fix is restored. Fixes the pattern behind Sentry `CLOUD-FRONTEND-STAGING-4MF`/`CLOUD-FRONTEND-STAGING-4MG`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_0137jzrG6RSp5e6YgGp8kxdY --- _Generated by [Claude Code](https://claude.ai/code/session_0137jzrG6RSp5e6YgGp8kxdY)_ --------- Co-authored-by: dante01yoon <bunggl@naver.com> Co-authored-by: Amp <amp@ampcode.com> (cherry picked from commit e346ef9)
## Summary Carries the fixes that landed on `core/1.54` but were absent from `core/1.55`: - #17486 keeps promoted dynamic-combo child links when loading workflows. - #18599 gives unified-remint retries a fresh timeout window. - #18093 allows nodes to shrink after content growth and tab switches. - #18155 resolves stale Agent bindings when workflows share a name. - #18693 keeps the Agent target aligned with the visible workflow until send or node reference. - #18619 waits for open dialogs before showing Agent consent. - #18061 deselects a node when its composer reference is removed. - #18392 marks video reply assets correctly. This is the consolidated `core/1.55` carrier from the 1.54→1.55 release audit. ## Validation - Cherry-picks applied cleanly except for release-branch adaptations in Agent consent and workflow targeting. - Local typecheck is running; CI is the authoritative full suite. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: Maanil Verma <vermaMaanil97@gmail.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: dante01yoon <bunggl@naver.com> Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com> Co-authored-by: GitHub Action <action@github.com>
Requested via Slack thread
Summary
Fixes the pattern behind Sentry
CLOUD-FRONTEND-STAGING-4MF/4MG: the unified-remint retry fetch could spuriously time out under staging load because it inherited whatever was left of the original request's 60s deadline instead of getting a full one.Changes
What:
fetchApi()(src/scripts/api.ts) armed a single 60sAbortSignaland passed it straight through tofetchWithUnifiedRemint(). On a 401, that function re-mints the unified Cloud JWT (tryRemintToken→workspaceAuthStore.remintUnifiedOnce()→unifiedUser()→unifiedSessionClient.remint()→exchangeToken(), each step with its own independent ~15s ceiling) before retrying the original request — but the retry reused the same original signal, so its effective budget was60s minus whatever the re-mint round trip already spent, not a fresh 60s. Under load, a slower-than-usual re-mint could leave the retry only a few seconds before it was aborted withTimeoutError: Fetch timeout, even though every individual step was within its own budget.fetchWithUnifiedRemint()(src/platform/auth/unified/remintRetry.ts) now takes an optional 4th parameter,freshRetrySignal?: () => AbortSignal | undefined, called only if a retry actually happens; its return value replaces the originalinit.signalon the retryfetch.fetchApi()passes a callback that mints a newAbortController+setTimeout(same duration, sameDOMException('Fetch timeout', 'TimeoutError')construction as the existing timeout, so Sentry grouping stays consistent) combined with the caller's ownsignalviaAbortSignal.any, and cleans up the new timer in the existing.finally().fetchWithUnifiedRemint()has two other call sites (globalSettingsApi.ts,authStore.ts) that pass no signal at all today; the new parameter is optional and defaults toundefined, which keeps their behavior byte-for-byte unchanged (they can't produce thisTimeoutErrorin the first place — only a benignTypeError: Failed to fetch).Breaking: none
Dependencies: none
How
remintRetry.ts: build the retryfetch'sinitfromfreshRetrySignal()when supplied, instead of always spreading the originalinit(which carried the shrunk signal).api.ts:freshRetrySignalis only constructed whentimeoutis non-null (i.e.timeoutMswasn't explicitly disabled), and only actually invoked byfetchWithUnifiedRemintif a 401 retry happens — a request that never gets a 401 pays no extra cost.Review Focus
src/scripts/api.ts,fetchApi(): the newfreshRetrySignalclosure and its timer's cleanup in.finally()(no leaked timers on either the happy path or an error path).src/platform/auth/unified/remintRetry.ts,fetchWithUnifiedRemint(): the retryinitconstruction now branches on whetherfreshRetrySignalwas supplied.globalSettingsApi.ts,authStore.ts) are unaffected — they don't pass a signal today, and the new parameter is optional and off by default.Tests
src/platform/auth/unified/remintRetry.test.ts: new cases assert the retryfetchreceives the object returned byfreshRetrySignal()(not the originalinit.signal) when supplied, and that the callback is never called when no retry happens.src/scripts/api.fetchApi.test.ts: new regression test with fake timers simulates a 401 → 55s re-mint → 30s retry sequence. Verified (viagit stashof only the source changes, keeping the new tests) that both new tests fail against the pre-fix code — the retry test rejects with the abort from the stale signal at t=60s — and pass once the fix is restored.Fixes the pattern behind Sentry
CLOUD-FRONTEND-STAGING-4MF/CLOUD-FRONTEND-STAGING-4MG.🤖 Generated with Claude Code
https://claude.ai/code/session_0137jzrG6RSp5e6YgGp8kxdY
Generated by Claude Code