Repository navigation
fix: insert_workflow nodes still render no widgets when execId derivation fails (PM-1580 follow-up) - #18604
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2123 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since a937e31eaa1ab4dd195919f23fc610a8cec5d098
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.98 MB gzip 🔴 +286 kBDetailsSummary
Category Glance App Entry Points — 3.87 kB (baseline 3.73 kB) • 🔴 +138 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.44 MB (baseline 1.43 MB) • 🔴 +17.5 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 124 kB) • 🔴 +8.02 kBTop-level views, pages, and routed surfaces
Status: 17 added / 16 removed / 1 unchanged Panels & Settings — 639 kB (baseline 621 kB) • 🔴 +17.6 kBConfiguration panels, inspectors, and settings screens
Status: 28 added / 27 removed User & Accounts — 37.9 kB (baseline 27.8 kB) • 🔴 +10.1 kBAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 2 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🔴 +740 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 124 kB (baseline 117 kB) • 🔴 +6.54 kBReusable component library chunks
Status: 16 added / 15 removed Data & Services — 3.95 MB (baseline 3.6 MB) • 🔴 +347 kBStores, services, APIs, and repositories
Status: 16 added / 16 removed Utilities & Hooks — 577 kB (baseline 559 kB) • 🔴 +18.8 kBHelpers, composables, and utility bundles
Status: 31 added / 29 removed / 7 unchanged Vendor & Third-Party — 17.4 MB (baseline 18.1 MB) • 🟢 -692 kBExternal libraries and shared vendor chunks
Status: 12 added / 12 removed / 6 unchanged Other — 17.8 MB (baseline 16.4 MB) • 🔴 +1.43 MBBundles that do not match a named category
Status: 179 added / 173 removed / 123 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T12:31:49.750Z",
"gitSha": "c871536bd960b2f9789323596ac21ebce5b02407",
"branch": "claude/fix-insert-workflow-execid-and-quarantine",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.1159999999827,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.376000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.735,
"heapDeltaBytes": -30420,
"heapUsedBytes": 67512652,
"domNodes": -266,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.879000000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2015.2259999999842,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.349,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.82699999999994,
"heapDeltaBytes": 7859476,
"heapUsedBytes": 75478524,
"domNodes": -261,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 11.065000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1773.6050000000319,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.773000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 799.2399999999999,
"heapDeltaBytes": 6798088,
"heapUsedBytes": 74330164,
"domNodes": -260,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 163.976,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1772.2459999999955,
"styleRecalcs": 44,
"styleRecalcDurationMs": 16.766,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 856.0600000000001,
"heapDeltaBytes": 11675276,
"heapUsedBytes": 79158436,
"domNodes": -261,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 166.472,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.9129999999955,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.990000000000002,
"layouts": 6,
"layoutDurationMs": 1.2300000000000002,
"taskDurationMs": 348.407,
"heapDeltaBytes": 2858700,
"heapUsedBytes": 70423972,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.229000000000005,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.826000000031,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.299999999999999,
"layouts": 6,
"layoutDurationMs": 1.09,
"taskDurationMs": 373.18399999999997,
"heapDeltaBytes": 2197020,
"heapUsedBytes": 64777024,
"domNodes": 77,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 13.296000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 657.7819999999974,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.712000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.531,
"heapDeltaBytes": 18809272,
"heapUsedBytes": 86464008,
"domNodes": 18,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 168.081,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 702.3420000000442,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.595999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.99999999999994,
"heapDeltaBytes": 18314288,
"heapUsedBytes": 80775608,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 173.57,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1220.9219999999732,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 876.641,
"heapDeltaBytes": 10324016,
"heapUsedBytes": 100433560,
"domNodes": -297,
"jsHeapTotalBytes": 24006656,
"scriptDurationMs": 67.00799999999998,
"eventListeners": -195,
"totalBlockingTimeMs": 586,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1208.5959999999432,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 882.0939999999999,
"heapDeltaBytes": 35210600,
"heapUsedBytes": 104991528,
"domNodes": 0,
"jsHeapTotalBytes": 18509824,
"scriptDurationMs": 76.10300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 566,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.3730000000187,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.9609999999995,
"heapDeltaBytes": 14377516,
"heapUsedBytes": 90749696,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 169.32899999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 233,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 860.1770000000215,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.0870000000003,
"heapDeltaBytes": 14852568,
"heapUsedBytes": 90128904,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 171.97299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 240,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11144.780999999966,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10060.95,
"heapDeltaBytes": -7104860,
"heapUsedBytes": 74761288,
"domNodes": -16,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 8601.243,
"eventListeners": 0,
"totalBlockingTimeMs": 1885,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9804.266999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8820.136,
"heapDeltaBytes": 12401008,
"heapUsedBytes": 93922604,
"domNodes": -12,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7466.284,
"eventListeners": 0,
"totalBlockingTimeMs": 992,
"frameDurationMs": 18.889999999999965,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9970.288999999979,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9062.178999999998,
"heapDeltaBytes": -13681340,
"heapUsedBytes": 68602800,
"domNodes": -20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 7752.22,
"eventListeners": 0,
"totalBlockingTimeMs": 1044,
"frameDurationMs": 20,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10466.821000000095,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9616.318,
"heapDeltaBytes": -397688,
"heapUsedBytes": 81746780,
"domNodes": -16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 7871.503000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1227,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2037.2089999999616,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.838999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.5169999999999,
"heapDeltaBytes": -3253848,
"heapUsedBytes": 83584136,
"domNodes": -242,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 33.61500000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2056.560999999988,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.868999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 649.626,
"heapDeltaBytes": -3124680,
"heapUsedBytes": 83037808,
"domNodes": -242,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 43.376999999999995,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2305.199000000016,
"styleRecalcs": 65,
"styleRecalcDurationMs": 8.828,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1613.149,
"heapDeltaBytes": 18666908,
"heapUsedBytes": 83354176,
"domNodes": 6,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 852.933,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2405.15199999993,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.415000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1697.8570000000002,
"heapDeltaBytes": 19453740,
"heapUsedBytes": 83839152,
"domNodes": -249,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 868.148,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3641.7129999999815,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.541000000000002,
"layouts": 60,
"layoutDurationMs": 14.084,
"taskDurationMs": 1788.379,
"heapDeltaBytes": 8216136,
"heapUsedBytes": 74257460,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 839.577,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3546.2870000000066,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.544999999999998,
"layouts": 60,
"layoutDurationMs": 13.892000000000001,
"taskDurationMs": 1634.5810000000004,
"heapDeltaBytes": 8693048,
"heapUsedBytes": 74655180,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 830.24,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3163.9169999999694,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.126999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1999.1910000000003,
"heapDeltaBytes": -2469604,
"heapUsedBytes": 88507248,
"domNodes": -257,
"jsHeapTotalBytes": 2543616,
"scriptDurationMs": 1017.7689999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3201.1960000000954,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.353000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2033.9020000000003,
"heapDeltaBytes": 793212,
"heapUsedBytes": 66941568,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 1033.609,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2005.1950000000147,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.5470000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.4920000000001,
"heapDeltaBytes": 20233920,
"heapUsedBytes": 84652408,
"domNodes": -252,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.49000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2037.5040000000126,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.939000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 647.5059999999999,
"heapDeltaBytes": -5825388,
"heapUsedBytes": 82976412,
"domNodes": -252,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 37.269,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 609.4099999999685,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.369999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.566,
"heapDeltaBytes": 14052044,
"heapUsedBytes": 84052108,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 152.199,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.0720000000119,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.268,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.20000000000005,
"heapDeltaBytes": 14050332,
"heapUsedBytes": 83740636,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 150.483,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.632000000001,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.079999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.55800000000005,
"heapDeltaBytes": -14478100,
"heapUsedBytes": 55249500,
"domNodes": -278,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.418999999999997,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.7969999999923,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.655,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.3209999999999,
"heapDeltaBytes": 11166500,
"heapUsedBytes": 80998400,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.017999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1740.680999999995,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.285999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 756.904,
"heapDeltaBytes": -9519732,
"heapUsedBytes": 60585748,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 110.375,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1701.1100000000852,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.584999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 785.849,
"heapDeltaBytes": 8817696,
"heapUsedBytes": 78563668,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 111.48600000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.0109999999786,
"styleRecalcs": 17,
"styleRecalcDurationMs": 31.714,
"layouts": 5,
"layoutDurationMs": 13.388999999999998,
"taskDurationMs": 960.628,
"heapDeltaBytes": -6254984,
"heapUsedBytes": 81984392,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 33.620999999999995,
"eventListeners": 2383,
"totalBlockingTimeMs": 151,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8320.783000000007,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.94799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5839.417,
"heapDeltaBytes": -6543996,
"heapUsedBytes": 80423472,
"domNodes": -242,
"jsHeapTotalBytes": -40960,
"scriptDurationMs": 2798.684,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8843.338000000018,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.851,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6179.99,
"heapDeltaBytes": -5761188,
"heapUsedBytes": 80373864,
"domNodes": -241,
"jsHeapTotalBytes": 483328,
"scriptDurationMs": 2881.135,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17180.498,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16783.143,
"heapDeltaBytes": -47221440,
"heapUsedBytes": 178364020,
"domNodes": -8061,
"jsHeapTotalBytes": -15998976,
"scriptDurationMs": 270.41800000000006,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17748.166999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17345.341999999997,
"heapDeltaBytes": -41734316,
"heapUsedBytes": 183966092,
"domNodes": -8061,
"jsHeapTotalBytes": -15736832,
"scriptDurationMs": 272.188,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15892.504999999972,
"styleRecalcs": 84,
"styleRecalcDurationMs": 12.674000000000019,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15526.529999999997,
"heapDeltaBytes": -52897972,
"heapUsedBytes": 167435620,
"domNodes": -8061,
"jsHeapTotalBytes": -18939904,
"scriptDurationMs": 882.2289999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 66,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21206.267000000025,
"styleRecalcs": 166,
"styleRecalcDurationMs": 18.14000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20898.609,
"heapDeltaBytes": -48966224,
"heapUsedBytes": 192119832,
"domNodes": -8061,
"jsHeapTotalBytes": -20979712,
"scriptDurationMs": 917.0140000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 74,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6200.86399999991,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.652,
"layouts": 20,
"layoutDurationMs": 23.899000000000004,
"taskDurationMs": 6127.142,
"heapDeltaBytes": -59867656,
"heapUsedBytes": 181300924,
"domNodes": -8061,
"jsHeapTotalBytes": 12120064,
"scriptDurationMs": 106.63099999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 408,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6329.221999999959,
"styleRecalcs": 20,
"styleRecalcDurationMs": 96.23400000000001,
"layouts": 20,
"layoutDurationMs": 29.987,
"taskDurationMs": 6259.219000000001,
"heapDeltaBytes": -74549936,
"heapUsedBytes": 166646484,
"domNodes": -8061,
"jsHeapTotalBytes": 585728,
"scriptDurationMs": 103.303,
"eventListeners": -14928,
"totalBlockingTimeMs": 682,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8533.736999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8371.054,
"heapDeltaBytes": -7039160,
"heapUsedBytes": 180594864,
"domNodes": 0,
"jsHeapTotalBytes": -4456448,
"scriptDurationMs": 138.34599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9129.657999999949,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8800.738000000001,
"heapDeltaBytes": -2488636,
"heapUsedBytes": 170037388,
"domNodes": 0,
"jsHeapTotalBytes": -14155776,
"scriptDurationMs": 136.49,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 122.91400000003705,
"styleRecalcs": 10,
"styleRecalcDurationMs": 17.840000000000003,
"layouts": 3,
"layoutDurationMs": 0.842,
"taskDurationMs": 94.746,
"heapDeltaBytes": 3226068,
"heapUsedBytes": 67899924,
"domNodes": 114,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.908,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 110.96299999996972,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.088999999999999,
"layouts": 2,
"layoutDurationMs": 1.137,
"taskDurationMs": 77.69899999999998,
"heapDeltaBytes": 3015540,
"heapUsedBytes": 68902748,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.605999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
…tion fails (PM-1580 follow-up) #18598 fixed stripGraphPrefix's widget-id lookup for comfy-multi-player's insert_workflow remapped ids (insert:<opId>:<scope>:node:<originalId>), but computeProcessedWidgets derives its own nodeExecId separately, via executionIdFromState/createNodeExecutionId. Both reject any node id containing a colon, including the derived id itself, so nodeExecId comes back null for these nodes and computeProcessedWidgets early-returns [] -- the same "zero widget rows" symptom the store-lookup fix addressed, from a different call site the existing regression test never exercised (it only replayed the raw store lookup, not computeProcessedWidgets). Adds createLeafNodeExecutionId, which keeps a root-level node's raw id whole instead of rejecting a colon inside it, and uses it at the two fallback call sites (executionIdFromState, computeProcessedWidgets) that only need a single, ancestor-free segment. Also scopes agentNodeMaterializer's withNamedValuesRestore (added in #18598 to fix ordinary nodes' named widget restore) away from SubgraphNode instances: SubgraphNode.configure() skips _applyPromotedWidgetValues -- the only place a proxyWidgetErrorQuarantine override wins over a stale value -- whenever widgets_values_named is set and namedValuesRestore is on, so forcing the flag for every configure() call would silently drop a quarantined promoted-input value on agent-materialized subgraph instances. Also fixes the insert_workflow regression test's collision case, which put the two colliding-id nodes in separate LGraphs and so never exercised a same-graph collision. Fixes PM-1580.
8dc432d to
035d905
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
exact-head evidence at 035d9056b015244aab37b5e2219f56989bff927a: the fallback now preserves a colon-bearing ID only for a root-owned leaf while retaining strict segment encoding for subgraph-owned nodes. The regression also moves the duplicate-original-ID case into one graph, so it actually exercises the per-node map collision the fix must prevent. I found no unresolved review threads; hosted test, perf-tests, and cloud Playwright remain in progress, so this is evidence only rather than a merge disposition.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18604 +/- ##
==========================================
+ Coverage 83.58% 84.55% +0.97%
==========================================
Files 2999 2293 -706
Lines 148402 131078 -17324
Branches 40216 33472 -6744
==========================================
- Hits 124038 110837 -13201
+ Misses 23070 19940 -3130
+ Partials 1294 301 -993
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 713 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…s, subgraphs, templates) Extends the PM-1562/#18458 (link materialization) and PM-1580/#18598/#18604 (widget rendering) regression coverage with broader integration tests for insert_workflow across widget types, link topologies, subgraph promotion, and representative workflow-template shapes. - agentInsertWorkflow.widgetTypes.test.ts (13 cases): combo/number/text/ toggle/multiline widgets on inserted nodes, partial widgets_values, cross-graph and same-graph id collisions. - agentInsertWorkflow.linkTopology.test.ts (8 cases): fan-out, fan-in, parallel chains, links crossing into/out of a subgraph boundary, a fully interior subgraph link, batch id-collision, incremental inserts. - agentInsertWorkflow.subgraphs.test.ts (7 cases): a promoted widget surviving a later set_widget, multiple widget types promoted together, subgraph-instance id collisions, several instances of one definition in one op, coexistence with a pre-existing instance, multiple definitions in one op. Documents a real gap (not fixed here): a subgraph instance nested as an interior node of another subgraph does not yet materialize through this pipeline. - agentInsertWorkflow.templates.test.ts (7 cases): representative txt2img, img2img, ControlNet, LoRA, video and compound pipelines, plus the same template inserted twice without cross-wiring.
|
|
Root cause of the missing auto-backport: I added Opened #18608 by hand with the same cherry-pick for Created by Claude Tag |
…ets when execId derivation fails (PM-1580 follow-up) (#18608) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449?thread_ts=1790058330.774449&cid=C0BGH348Z0C)_ Backport of #18604 to `cloud/1.54`. Opened manually: the `PR Backport` workflow (`pr-backport.yaml`) only runs when the PR carries the `needs-backport` label — `core/1.54` + `cloud/1.54` alone (added manually before merge) don't trigger it, so it never ran at merge time. After adding `needs-backport`, the workflow did run and this target (`cloud/1.54`) cherry-picked `035d9056b0` cleanly, but the run's overall job still failed because the `core/1.54` target hit a real conflict (that target is missing #18598 entirely, since its own backport #18600 is still open/unmerged against `core/1.54`) — and the workflow's "Cleanup stranded backport branches" step then deleted the `cloud/1.54` branch it had just successfully pushed, because it runs on `failure()` for the *job*, not per-target. So this clean backport never got a PR from the bot despite succeeding. Re-cherry-picked `035d9056b0` onto `cloud/1.54` (which already has #18598 via #18601) by hand — clean apply, no conflicts. `core/1.54` is intentionally not backported here: it needs #18600 (the #18598 backport) merged first. --- 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY --- _Generated by [Claude Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
…w node ids in locator/callback path (#18616) (#18618) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449)_ Backport of #18616 to `cloud/1.54`. Manual cherry-pick, same approach as #18608: `cloud/1.54` now has #18604's execution-id fix (via #18608), and #18616 is the follow-up that fixes the *sibling* locator-id path (`createNodeLocatorId`/`locatorIdFromState`/`getNodeByLocatorId`), used to resolve the live `LGraphNode` for widget callback dispatch and navigation, for the same colon-bearing `insert_workflow` node ids. ## Before Moving a widget on an `insert_workflow`-materialized node (comfy-multi-player, PM-1580) updates the widget's stored value, but the underlying node's `widget.callback` — which drives dependent UI, control-after-generate, dynamic input wiring, etc. — never fires, because `createNodeLocatorId` rejected the colon-bearing id and `getHostNode` resolved no live `LGraphNode`. The same path also silently broke "Enter Subgraph" navigation and promoted-widget preview locator ids for these nodes. ## After `createLeafNodeLocatorId` (mirroring `createLeafNodeExecutionId` from #18604) keeps a root-level colon-bearing id whole instead of rejecting it, while a genuinely subgraph-nested id still goes through the strict, delimiter-aware path unchanged. `locatorIdFromState`, `getNodeByLocatorId`, and the promoted-widget preview locator (`widgetNodeLocatorId`) now agree on this leaf-tolerant encoding/decoding, so `getHostNode` resolves the real `LGraphNode` and `live.widget.callback` fires normally. ## Cherry-pick details - Source commit: 5d85b04 (single self-contained commit from #18616, `claude/fix-node-locator-id-colon-rejection`) - `git cherry-pick -m 1` applied cleanly onto `cloud/1.54` (post-#18608) — no conflicts, since `nodeIdentification.ts`, `graphTraversalUtil.ts`, and `processedWidgetRenderModel.ts` already had #18604/#18608's sibling execution-id fix in place. - Committer identity normalized to `claude[bot]` (author was already `claude[bot]`; no AI co-author trailer was present in the original commit body, so none needed stripping). ## Testing - `pnpm vitest run` on `nodeIdentification.test.ts`, `graphTraversalUtil.test.ts`, and `useProcessedWidgets.test.ts` (which exercises `processedWidgetRenderModel.ts`'s `getHostNode`) against `cloud/1.54`'s actual code — 186 tests passed. - `vue-tsc --noEmit` — clean. - `eslint` and `oxfmt --check` on all 6 touched files — clean. Ref: #18616 (source PR, still open on `main` at cherry-pick time but CI-green and single-commit) 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY --- _Generated by [Claude Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
…low nodes Widgets on nodes inside a subgraph inserted via insert_workflow did not render in Vue mode once the subgraph was entered (litegraph rendering and execution were unaffected, since both read node.widgets directly). Root cause: comfy-multi-player's insert_workflow remaps every node id it inserts, including a subgraph DEFINITION's interior nodes, to a derived string carrying colons unrelated to subgraph scoping (e.g. insert:<opId>:root/definition:<defId>:node:<originalId>, remap.ts's derivedId). PR #18604/#18616 (PM-1580) already made createLeafNodeExecutionId/createLeafNodeLocatorId tolerate such a colon-bearing id for a ROOT-owned node, but both explicitly fell back to the strict, delimiter-aware path once the node was subgraph-owned, returning null. computeProcessedWidgets treats a null execution id as "nothing to render" and bails with an empty widget list. Fix: extend the leaf-tolerant handling to a subgraph-owned node too. - nodeIdentification.ts: createLeafNodeLocatorId now encodes a colon-bearing local id as `${subgraphUuid}:${nodeId}` instead of rejecting it; the new parseLeafNodeLocatorId decodes it back by splitting on the first colon only (mirroring stripGraphPrefix's existing technique for widget ids). - graphTraversalUtil.ts: getNodeByLocatorId uses the new leaf-tolerant parser; executionIdFromState's fallback and createExecutionIdFromPath's leaf segment are likewise leaf-tolerant regardless of subgraph ownership; getExecutionIdByNode's root branch uses createLeafNodeExecutionId for symmetry. Verified against real nightly CRDT captures of the "Text to Image (Z-Image-Turbo)" template (Jo Zhang) showing the exact insert:<opId>:root/definition:... id shape at the moment the bug reproduced. Adds insertWorkflowSubgraphInteriorWidgets.regression.test.ts: drives the real insert_workflow pipeline to materialize a subgraph-interior node and asserts computeProcessedWidgets renders it in Vue mode, covering combo, int, float, text and toggle widgets on a synthetic node plus the real CLIPTextEncode/EmptySD3LatentImage/KSampler widget shapes from the Z-Image-Turbo capture.
…s, subgraphs, templates) (Comfy-Org#18607) ## Before/After **Before:** `insert_workflow` regression coverage was two narrow pins — one for the PM-1562 link-materialization bug (`agentInsertWorkflowLinks.regression.test.ts`) and one for the PM-1580 widget-rendering bug (`agentInsertWorkflowWidgets.regression.test.ts`), plus a single subgraph-blueprint-paste test. Real-world `insert_workflow` usage (agent-driven template inserts, pastes, multi-node/subgraph batches) had no broader integration coverage: no check that every widget *type* renders correctly, no coverage of link topologies beyond the exact shapes those two bugs hit, and no coverage of subgraph promotion beyond one happy path. **After:** 35 new integration test cases across 4 files, all driving the real pipeline (comfy-multi-player's `insert_workflow` applier → `AgentCrdtProjection`/`EcsFollowerAdapter` → `graphMutations` → `agentNodeMaterializer`), same technique as the existing regression files (either literal `WorkflowJSON` ops, or a real litegraph graph built with `createTestSubgraph`/`createTestSubgraphNode` and round-tripped through `serialize()`): - **`agentInsertWorkflow.widgetTypes.test.ts`** (13 cases): combo, number, text, toggle and multiline widgets on inserted nodes; a combo value outside its declared options; a multi-widget node rendering in declared order; a node whose `widgets_values` is shorter than its widget list; two same-original-id nodes inserted into **different** graphs; three same-original-id nodes inserted into the **same** graph (extends the existing 2-way collision test). - **`agentInsertWorkflow.linkTopology.test.ts`** (8 cases): one output fanning out to two inputs; three independent chains in one batch; a link crossing **into** a freshly-inserted subgraph's promoted input; a link crossing **out of** one; a fully **interior** subgraph link; two batch-inserted ops that collide on node ids without cross-wiring their links; a two-source fan-in; an incrementally-inserted link on an already-open graph. - **`agentInsertWorkflow.subgraphs.test.ts`** (7 cases): a promoted widget materialized via `insert_workflow` surviving a later `set_widget` op; two different widget types (combo + number) promoted together on one host; two subgraph instances colliding on their original host id in the same graph; several instances of the *same* definition inserted in one op; a new subgraph insert coexisting with a pre-existing, unrelated instance; two distinct subgraph definitions carried by one op. - **`agentInsertWorkflow.templates.test.ts`** (7 cases): representative checkpoint txt2img, img2img, ControlNet, LoRA, video and compound (ControlNet+LoRA) pipelines, plus the same template inserted twice with no cross-wiring. This repo vendors no local fixture set for the GCS-hosted templates catalogue, so these are literal graphs built to the same node/widget shapes as the well-known public templates rather than pulled fixtures. **Real gap found, not fixed here:** while writing the subgraph tests I found that an interior node which is itself a subgraph instance (a subgraph nested inside another subgraph, as opposed to two sibling definitions in one op) does not currently materialize correctly through `insert_workflow` — its `type` still names the un-remapped blueprint definition id, which nothing registers on the live side, so it falls back to a plain, widget-less node. That's called out in a comment at the top of `agentInsertWorkflow.subgraphs.test.ts` rather than asserted around or silently skipped. Worth its own follow-up ticket. ## How - All four files reuse the same harness pattern as the existing regression files (`bindProjection`/`insertOp` helpers, `LiteGraph.registerNodeType` fixture classes, `useWidgetValueStore`/`stripGraphPrefix` for reading rendered widgets the way `LGraphNode.vue` does). - `pnpm vitest run` on the four new files: **35/35 passing**. - `pnpm vitest run src/workbench/extensions/agent/crdt/`: all 64 files in the directory pass (925 passed, 15 pre-existing expected-fails), confirming no regression. - `pnpm typecheck:app`: clean. - `pnpm exec oxlint --type-aware` / `eslint` on the new files: clean. - Branched from current `main` (`a937e31e`, includes Comfy-Org#18598's widget-rendering fix). Comfy-Org#18604 (the PM-1580 follow-up for colon-bearing root-level ids) is still open as of this PR and not included; nothing in this suite specifically re-pins that narrow fallback path, since its own regression test already lives in Comfy-Org#18604. <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · Slack thread (channel C0BGH348Z0C, thread 1790058330.774449)_ 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY --- _Generated by [Claude Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_ --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
…callback path (Comfy-Org#18616) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449)_ ## What Follow-up to Comfy-Org#18604, which fixed the *execution-id* path (`createNodeExecutionId`/`executionIdFromState`) for comfy-multi-player's `insert_workflow` remapped node ids (`insert:<opId>:root:node:<originalId>`, PM-1580), but left the *locator-id* path — `createNodeLocatorId`/`locatorIdFromState`/`getNodeByLocatorId`, used to resolve the live `LGraphNode` for callback dispatch and navigation — rejecting the same colon-bearing ids. - `createNodeLocatorId` rejects any colon in a root-level local id, so `locatorIdFromState` returned `null` for these nodes. - `getHostNode` (`processedWidgetRenderModel.ts`) calls `locatorIdFromState`, so it resolved no live `LGraphNode` for an inserted node. - `resolveLiveWidgetContext` then got `hostNode = null` and returned `{}` (no `live` context). - In `createWidgetUpdateHandler`, `widgetValueStore.setValue(id, newValue)` still ran (the stored value updated correctly), but `live.widget.callback?.(...)` was skipped since `live` was undefined. Net effect: widget callbacks silently never fired for agent-inserted nodes, even though the stored value looked correct. - Separately, `getNodeByLocatorId`'s parse side (`parseNodeLocatorId`) had the same colon rejection, so even a correctly leaf-encoded locator id couldn't be resolved back to a node. **Before:** moving a widget on an `insert_workflow`-materialized node updates the widget's stored value, but the underlying node's `widget.callback` (which drives dependent UI, control-after-generate, dynamic input wiring, etc.) never fires. The same `locatorIdFromState`/`createNodeLocatorId` path also silently breaks "Enter Subgraph" navigation and promoted-widget preview locator ids for these nodes. **After:** `createLeafNodeLocatorId` (mirroring the sibling `createLeafNodeExecutionId` from Comfy-Org#18604) keeps a root-level colon-bearing id whole instead of rejecting it, while a genuinely subgraph-nested id still goes through the strict, delimiter-aware path unchanged. `locatorIdFromState`, `getNodeByLocatorId`, and the promoted-widget preview locator (`widgetNodeLocatorId`) now agree on this leaf-tolerant encoding/decoding, so `getHostNode` resolves the real `LGraphNode` and `live.widget.callback` fires normally. ## Scope confirmation - `LGraphNode.vue`'s `nodeLocatorId` (drives "Enter Subgraph" and the `lgraphNode` resolution used by promoted previews / GLSL preview) calls `locatorIdFromState` directly, so it is covered by this fix with no separate test needed — same function, same code path. - `widgetNodeLocatorId()`'s promoted-widget preview locator called `createNodeLocatorId` directly (not through `locatorIdFromState`), so it would **not** have been fixed by patching `locatorIdFromState` alone; it's explicitly switched to `createLeafNodeLocatorId` in this PR. No dedicated test was added for this call site specifically (it has no colon-bearing-id test coverage before or after), since the underlying encode/decode logic is exercised directly in `nodeIdentification.test.ts`/`graphTraversalUtil.test.ts`. ## Test plan - `createLeafNodeLocatorId` unit tests in `nodeIdentification.test.ts` — ordinary colon-free id, colon-bearing root id (PM-1580), still-strict rejection for a genuinely subgraph-nested colon-bearing id, empty id. - `locatorIdFromState` regression tests in `graphTraversalUtil.test.ts` — root id, subgraph id, colon-bearing root id, and a no-regression case for a real subgraph-owned colon-bearing id. - Widget-callback regression test in `useProcessedWidgets.test.ts` asserting the live `widget.callback` **actually fires** (not just that the stored value updates) for a colon-bearing node id. - Confirmed every new assertion fails against the pre-fix code and passes with the fix (`git stash`/`git stash pop` red→green check). - `pnpm vitest run` on all touched/related suites: `nodeIdentification`, `graphTraversalUtil`, all of `vueNodes`, all of `workbench/extensions/agent/crdt` — 161 files, 2218 passed. - `vue-tsc --noEmit` clean. - `eslint` and `oxfmt --check` clean on touched files; pre-commit hooks (oxfmt/oxlint/eslint/typecheck) passed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY --- _Generated by [Claude Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
…ets when execId derivation fails (PM-1580 follow-up) (#18608) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449?thread_ts=1790058330.774449&cid=C0BGH348Z0C)_ Backport of #18604 to `cloud/1.54`. Opened manually: the `PR Backport` workflow (`pr-backport.yaml`) only runs when the PR carries the `needs-backport` label — `core/1.54` + `cloud/1.54` alone (added manually before merge) don't trigger it, so it never ran at merge time. After adding `needs-backport`, the workflow did run and this target (`cloud/1.54`) cherry-picked `035d9056b0` cleanly, but the run's overall job still failed because the `core/1.54` target hit a real conflict (that target is missing #18598 entirely, since its own backport #18600 is still open/unmerged against `core/1.54`) — and the workflow's "Cleanup stranded backport branches" step then deleted the `cloud/1.54` branch it had just successfully pushed, because it runs on `failure()` for the *job*, not per-target. So this clean backport never got a PR from the bot despite succeeding. Re-cherry-picked `035d9056b0` onto `cloud/1.54` (which already has #18598 via #18601) by hand — clean apply, no conflicts. `core/1.54` is intentionally not backported here: it needs #18600 (the #18598 backport) merged first. --- 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY --- _Generated by [Claude Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_ (cherry picked from commit a55ce3d)
…w node ids in locator/callback path (#18616) (#18618) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449)_ Backport of #18616 to `cloud/1.54`. Manual cherry-pick, same approach as #18608: `cloud/1.54` now has #18604's execution-id fix (via #18608), and #18616 is the follow-up that fixes the *sibling* locator-id path (`createNodeLocatorId`/`locatorIdFromState`/`getNodeByLocatorId`), used to resolve the live `LGraphNode` for widget callback dispatch and navigation, for the same colon-bearing `insert_workflow` node ids. ## Before Moving a widget on an `insert_workflow`-materialized node (comfy-multi-player, PM-1580) updates the widget's stored value, but the underlying node's `widget.callback` — which drives dependent UI, control-after-generate, dynamic input wiring, etc. — never fires, because `createNodeLocatorId` rejected the colon-bearing id and `getHostNode` resolved no live `LGraphNode`. The same path also silently broke "Enter Subgraph" navigation and promoted-widget preview locator ids for these nodes. ## After `createLeafNodeLocatorId` (mirroring `createLeafNodeExecutionId` from #18604) keeps a root-level colon-bearing id whole instead of rejecting it, while a genuinely subgraph-nested id still goes through the strict, delimiter-aware path unchanged. `locatorIdFromState`, `getNodeByLocatorId`, and the promoted-widget preview locator (`widgetNodeLocatorId`) now agree on this leaf-tolerant encoding/decoding, so `getHostNode` resolves the real `LGraphNode` and `live.widget.callback` fires normally. ## Cherry-pick details - Source commit: 5d85b04 (single self-contained commit from #18616, `claude/fix-node-locator-id-colon-rejection`) - `git cherry-pick -m 1` applied cleanly onto `cloud/1.54` (post-#18608) — no conflicts, since `nodeIdentification.ts`, `graphTraversalUtil.ts`, and `processedWidgetRenderModel.ts` already had #18604/#18608's sibling execution-id fix in place. - Committer identity normalized to `claude[bot]` (author was already `claude[bot]`; no AI co-author trailer was present in the original commit body, so none needed stripping). ## Testing - `pnpm vitest run` on `nodeIdentification.test.ts`, `graphTraversalUtil.test.ts`, and `useProcessedWidgets.test.ts` (which exercises `processedWidgetRenderModel.ts`'s `getHostNode`) against `cloud/1.54`'s actual code — 186 tests passed. - `vue-tsc --noEmit` — clean. - `eslint` and `oxfmt --check` on all 6 touched files — clean. Ref: #18616 (source PR, still open on `main` at cherry-pick time but CI-green and single-commit) 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY --- _Generated by [Claude Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_ (cherry picked from commit 0ec045e)
## Summary Ports to `core/1.54` every merged `main` Agent fix that `cloud/1.54` carries and core does not (the Agent UI catch-up from #18622, the cloud-only CRDT and workflow fixes, and the round-2 fixes), so both release lines are symmetric ahead of the local-agent rollout. ## Changes - **What**: `cherry-pick -x`, in three groups: - Agent UI, as in #18622: #17339, #17908, #17420, #18348, #18043, #17621 (without its two `src/lib/litegraph/` files; a 5 px HUD offset in `SideToolbar.vue` compensates), #17471, #17690. - Cloud-only fixes: #18063, #18073, #18064, #18033, #18289, #18604, #18616, #18376. - Round 2: #17568, #17628, #16491, #18453, #17767, #18431 (from #18571), #18603. - **Already on `core/1.54`**: #17439 (#18161), #17912 (#18186), #18391 (#18595). - **Excluded**: #17730 (core lacks its three files), #18421 (dead code on core builds), #16917 (conflicts with later core changes), #18066 (Christian's request), #18375 and #18251 (need their litegraph hunks). ## Review Focus - On this line the Agent panel registers only in cloud builds (`src/extensions/core/index.ts:41-44`); the shared chrome from #17621 and #17471 and the host telemetry from #18376 and #18603 ship in every build. - `HostTelemetrySink.ts` and its test equal `main`'s files (#18376, then #18603 on top). - #18064: `agentConversationHostDoc.test.ts` keeps this line's file; #18063's new test uses `main`'s version (multi-player 0.3.x stamps). - Supersedes #18571 and the closed #18637. Linear: [PM-1657](https://linear.app/comfyorg/issue/PM-1657), [PM-1656](https://linear.app/comfyorg/issue/PM-1656) ## Screenshots (if applicable) Visual changes are the ones reviewed on `main` and carried to cloud in #18622. --------- Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: ryan-di <ryan.weihao.di@gmail.com> Co-authored-by: jaeone lee <89377375+jaeone94@users.noreply.github.com> Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Comfy Org PR Bot <snomiao+comfy-pr@gmail.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Hunter <huntcsg@users.noreply.github.com> Co-authored-by: Maanil Verma <vermaMaanil97@gmail.com>
|
|
|
|
|
|
Summary
Follow-up to #18598, which fixed
stripGraphPrefix's widget-id lookup for comfy-multi-player'sinsert_workflowremapped ids (insert:<opId>:<scope>:node:<originalId>) but left two more places rejecting the same colon-bearing ids:computeProcessedWidgetsstill returns[]for these nodes. It derives its ownnodeExecIdviaexecutionIdFromState/createNodeExecutionId, both of which reject any colon in a node id — including the derived id itself — sonodeExecIdcomes backnulland the function early-returns[]regardless of how correct the widget-id lookup is. This is the actual rendering path (useProcessedWidgets→LGraphNode.vue), so the "zero widget rows" symptom fix: render widgets on insert_workflow-materialized nodes #18598 aimed to fix was not actually fixed. fix: render widgets on insert_workflow-materialized nodes #18598's regression test only replayed the raw store lookup (stripGraphPrefix+getNodeWidgetIds), nevercomputeProcessedWidgets, so it went green either way.Fix: added
createLeafNodeExecutionId, which keeps a root-level node's raw id whole instead of rejecting a colon inside it (there's no ancestor segment to disambiguate it from), and used it at the two fallback call sites inexecutionIdFromStateandcomputeProcessedWidgets.agentNodeMaterializer's newwithNamedValuesRestorewrap around everynode.configure()call drops quarantined promoted-widget values on subgraph instances.SubgraphNode.configure()skips_applyPromotedWidgetValues— the only place aproxyWidgetErrorQuarantineoverride wins over a stale value — wheneverwidgets_values_namedis set andnamedValuesRestoreis on. fix: render widgets on insert_workflow-materialized nodes #18598 started forcing that flag for every materialized node'sconfigure()call (previously only subgraph definitions used it), so an agent-materialized subgraph instance carrying a quarantined value now silently loses it to the stale value instead.Fix: scoped the forced flag away from
SubgraphNodeinstances, which don't need it (their promoted values restore through_applyPromotedWidgetValues, not the named-values path).The new "collision" regression test never exercised a same-graph collision. It put the two colliding-id nodes in separate
LGraphs, so even astripGraphPrefixthat collapsed both to their trailing segment (the pre-fix: render widgets on insert_workflow-materialized nodes #18598 bug) would still pass, since the per-graph maps are keyed by graph id first. Changed it to insert both nodes into the same graph.Found while verifying an automated review panel's findings on #18598 after it was merged via the merge queue; all three were confirmed against the current code with reproducing tests before this fix, and each new assertion fails without the fix.
Test plan
createLeafNodeExecutionId/executionIdFromStateregression tests insrc/types/nodeIdentification.test.tsandsrc/utils/graphTraversalUtil.test.tsagentInsertWorkflowWidgets.regression.test.tsmain(pre-fix) and passes with the fixpnpm vitest runon all touched/related test files (340 passed)vue-tsc --noEmitclean🤖 Generated with Claude Code
https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY
Generated by Claude Code