Repository navigation
test(agent): alternating-write (A -> B -> A) case for promoted subgraph widgets - #18629
Conversation
…raph widgets insert_workflow.subgraphs.test.ts covers a promoted widget surviving one subsequent set_widget, but no case exercises a repeated toggle on the same node through comfy-multi-player's insert_workflow remap/promotion path. Adds one case that inserts a subgraph host with a promoted number widget, then writes 5 -> 42 -> 5 via set_widget, asserting the live widget and the widget value store round-trip correctly at each step. Uses the same real-graph-blueprint + FollowerDoc/AgentCrdtProjection harness as the rest of the file, and the same alternating-state structure as agentInsertWorkflowLinks.regression.test.ts's link remove-then-reinsert case.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2118 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d2568038e4b73a5c2ccfc7ef549e434eeb048831
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.98 MB gzip 🟢 -146 BDetailsSummary
Category Glance App Entry Points — 3.87 kB (baseline 3.87 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.44 MB (baseline 1.44 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.95 MB (baseline 3.95 MB) • 🟢 -786 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 577 kB (baseline 577 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 19 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.8 MB (baseline 17.8 MB) • ⚪ 0 BBundles that do not match a named category
Status: 74 added / 74 removed / 228 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T20:17:50.747Z",
"gitSha": "21e21fa649923aeeba80f3e6d75f5967a82f7d39",
"branch": "claude/insert-workflow-alternating-widget-test",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1992.243999999971,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.155000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.685,
"heapDeltaBytes": 9692124,
"heapUsedBytes": 77251624,
"domNodes": -259,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 8.453000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2019.2759999999907,
"styleRecalcs": 13,
"styleRecalcDurationMs": 11.180999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.02000000000004,
"heapDeltaBytes": -7914072,
"heapUsedBytes": 59988228,
"domNodes": -257,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.045000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1731.4650000000142,
"styleRecalcs": 47,
"styleRecalcDurationMs": 14.678000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 675.2539999999999,
"heapDeltaBytes": 10565964,
"heapUsedBytes": 78028708,
"domNodes": -260,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 125.32099999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1720.9310000000642,
"styleRecalcs": 48,
"styleRecalcDurationMs": 15.717999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 689.442,
"heapDeltaBytes": 8092464,
"heapUsedBytes": 75912144,
"domNodes": -256,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 124.90599999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1691.8269999999893,
"styleRecalcs": 28,
"styleRecalcDurationMs": 13.986,
"layouts": 6,
"layoutDurationMs": 1.06,
"taskDurationMs": 279.35200000000003,
"heapDeltaBytes": 2227920,
"heapUsedBytes": 64573728,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.389000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1688.7719999999717,
"styleRecalcs": 30,
"styleRecalcDurationMs": 13.267,
"layouts": 6,
"layoutDurationMs": 0.9840000000000001,
"taskDurationMs": 284.532,
"heapDeltaBytes": 3108020,
"heapUsedBytes": 70569352,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.515,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 550.4159999999843,
"styleRecalcs": 14,
"styleRecalcDurationMs": 9.034,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.99899999999997,
"heapDeltaBytes": 18289164,
"heapUsedBytes": 86291360,
"domNodes": 23,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 142.007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 574.7669999999516,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.88,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 389.514,
"heapDeltaBytes": 18511020,
"heapUsedBytes": 80952356,
"domNodes": 21,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 136.6,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1064.86799999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 727.05,
"heapDeltaBytes": -17607268,
"heapUsedBytes": 72865880,
"domNodes": -295,
"jsHeapTotalBytes": 22151168,
"scriptDurationMs": 55.85799999999999,
"eventListeners": -217,
"totalBlockingTimeMs": 410,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1005.6660000000193,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 646.238,
"heapDeltaBytes": 38834420,
"heapUsedBytes": 105668556,
"domNodes": 0,
"jsHeapTotalBytes": 19034112,
"scriptDurationMs": 51.836000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 398,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 766.4299999999571,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 379.877,
"heapDeltaBytes": 14797832,
"heapUsedBytes": 90173928,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 121.67499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 161,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 797.4219999999832,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.32999999999976,
"heapDeltaBytes": 14797404,
"heapUsedBytes": 90106164,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 132.436,
"eventListeners": 0,
"totalBlockingTimeMs": 160,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7805.712999999969,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6957.112999999999,
"heapDeltaBytes": -10941328,
"heapUsedBytes": 70947496,
"domNodes": -16,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 5514.181,
"eventListeners": 0,
"totalBlockingTimeMs": 46,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7350.888999999938,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6467.943,
"heapDeltaBytes": -9444968,
"heapUsedBytes": 72568976,
"domNodes": -16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 5096.0599999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 32,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.19999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7634.31300000002,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.11399999999999952,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6798.776,
"heapDeltaBytes": -169724,
"heapUsedBytes": 81871976,
"domNodes": -16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 5419.892,
"eventListeners": 0,
"totalBlockingTimeMs": 122,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7522.032999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6649.86,
"heapDeltaBytes": -11947708,
"heapUsedBytes": 69955868,
"domNodes": -18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 5286.642,
"eventListeners": 0,
"totalBlockingTimeMs": 28,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2017.417000000023,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.8199999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.271,
"heapDeltaBytes": -3306444,
"heapUsedBytes": 83839788,
"domNodes": -241,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 33.07199999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2006.1490000000504,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.588999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.4969999999998,
"heapDeltaBytes": 20577720,
"heapUsedBytes": 84313736,
"domNodes": -238,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.07399999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2183.072999999979,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.325999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1388.5030000000002,
"heapDeltaBytes": -11489376,
"heapUsedBytes": 76565488,
"domNodes": -218,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 705.2760000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2235.0629999999683,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.032000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1463.635,
"heapDeltaBytes": 9680388,
"heapUsedBytes": 97952956,
"domNodes": -254,
"jsHeapTotalBytes": 2351104,
"scriptDurationMs": 698.6410000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3289.024999999981,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.501000000000001,
"layouts": 60,
"layoutDurationMs": 14.064999999999998,
"taskDurationMs": 1465.9070000000002,
"heapDeltaBytes": 8418796,
"heapUsedBytes": 74122204,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 666.241,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3277.105000000006,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.267999999999999,
"layouts": 60,
"layoutDurationMs": 14.290000000000001,
"taskDurationMs": 1471.291,
"heapDeltaBytes": 8122076,
"heapUsedBytes": 73887748,
"domNodes": 12,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 664.954,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2482.714000000044,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.953,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1714.959,
"heapDeltaBytes": -1241752,
"heapUsedBytes": 83648152,
"domNodes": -249,
"jsHeapTotalBytes": 147456,
"scriptDurationMs": 863.026,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2459.3079999999645,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.782000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1655.7430000000002,
"heapDeltaBytes": 21274660,
"heapUsedBytes": 87447224,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 823.3009999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2025.2169999999978,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.167,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.396,
"heapDeltaBytes": -6283260,
"heapUsedBytes": 82892132,
"domNodes": -238,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 37.112,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2033.478999999943,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.974000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 522.4,
"heapDeltaBytes": -9683044,
"heapUsedBytes": 78506904,
"domNodes": -250,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 35.944,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 542.9740000000152,
"styleRecalcs": 49,
"styleRecalcDurationMs": 11.755999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 347.147,
"heapDeltaBytes": 13734832,
"heapUsedBytes": 83437052,
"domNodes": 24,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 124.34599999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 511.34799999999814,
"styleRecalcs": 49,
"styleRecalcDurationMs": 11.773,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 343.75,
"heapDeltaBytes": 14055988,
"heapUsedBytes": 83989140,
"domNodes": 24,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 123.68400000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1992.845999999986,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.563000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.74399999999997,
"heapDeltaBytes": -5374912,
"heapUsedBytes": 64627736,
"domNodes": -276,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 7.3359999999999985,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1988.281000000029,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.629,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.44200000000006,
"heapDeltaBytes": 11393200,
"heapUsedBytes": 81551732,
"domNodes": -273,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.433000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.5539999999728,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.76,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 632.6070000000001,
"heapDeltaBytes": -8543668,
"heapUsedBytes": 61661960,
"domNodes": -273,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 88.34599999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.9900000000325,
"styleRecalcs": 47,
"styleRecalcDurationMs": 15.630999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 670.099,
"heapDeltaBytes": -9726324,
"heapUsedBytes": 60284944,
"domNodes": -275,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 95.381,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1002.7479999999969,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.34,
"layouts": 5,
"layoutDurationMs": 9.323999999999998,
"taskDurationMs": 751.1250000000002,
"heapDeltaBytes": -6202316,
"heapUsedBytes": 81735124,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 24.136,
"eventListeners": 2383,
"totalBlockingTimeMs": 93,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8207.514000000003,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.376000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4793.249,
"heapDeltaBytes": -10773368,
"heapUsedBytes": 76098848,
"domNodes": -242,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 2281.8129999999996,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8197.290000000066,
"styleRecalcs": 250,
"styleRecalcDurationMs": 42.032,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4944.112999999999,
"heapDeltaBytes": -5826836,
"heapUsedBytes": 81265760,
"domNodes": -215,
"jsHeapTotalBytes": 2088960,
"scriptDurationMs": 2323.333,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15195.438999999966,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15117.94,
"heapDeltaBytes": -56716672,
"heapUsedBytes": 190062220,
"domNodes": -8062,
"jsHeapTotalBytes": -14094336,
"scriptDurationMs": 231.69899999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15225.476999999955,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15068.032000000003,
"heapDeltaBytes": -50766228,
"heapUsedBytes": 169443584,
"domNodes": -8062,
"jsHeapTotalBytes": -17444864,
"scriptDurationMs": 238.41700000000003,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18100.144,
"styleRecalcs": 122,
"styleRecalcDurationMs": 16.30300000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17961.292999999998,
"heapDeltaBytes": -60746592,
"heapUsedBytes": 178060088,
"domNodes": -8062,
"jsHeapTotalBytes": -20668416,
"scriptDurationMs": 738.3919999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 35,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17805.530999999974,
"styleRecalcs": 124,
"styleRecalcDurationMs": 15.865000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17637.754999999997,
"heapDeltaBytes": -42069920,
"heapUsedBytes": 192313336,
"domNodes": -8062,
"jsHeapTotalBytes": -18276352,
"scriptDurationMs": 774.0610000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 8,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5560.595999999919,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.54899999999999,
"layouts": 20,
"layoutDurationMs": 24.371000000000002,
"taskDurationMs": 5530.303,
"heapDeltaBytes": -62382276,
"heapUsedBytes": 176235596,
"domNodes": -8062,
"jsHeapTotalBytes": 17604608,
"scriptDurationMs": 96.88799999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 304,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5614.832999999976,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.41900000000001,
"layouts": 20,
"layoutDurationMs": 30.194,
"taskDurationMs": 5578.868999999999,
"heapDeltaBytes": -62465404,
"heapUsedBytes": 176845448,
"domNodes": -8062,
"jsHeapTotalBytes": 7241728,
"scriptDurationMs": 100.14899999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 256,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7454.504000000043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7428.445999999999,
"heapDeltaBytes": -32566824,
"heapUsedBytes": 169554268,
"domNodes": 0,
"jsHeapTotalBytes": -30146560,
"scriptDurationMs": 135.56100000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7615.447999999901,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7583.892000000003,
"heapDeltaBytes": 17265508,
"heapUsedBytes": 182314892,
"domNodes": 0,
"jsHeapTotalBytes": -18612224,
"scriptDurationMs": 135.295,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 455.6989999999814,
"styleRecalcs": 19,
"styleRecalcDurationMs": 24.652000000000005,
"layouts": 5,
"layoutDurationMs": 1.986,
"taskDurationMs": 126.184,
"heapDeltaBytes": 5291668,
"heapUsedBytes": 70636508,
"domNodes": 154,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.623,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 89.57599999996546,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.213,
"layouts": 4,
"layoutDurationMs": 1.6030000000000002,
"taskDurationMs": 62.40899999999999,
"heapDeltaBytes": 3043984,
"heapUsedBytes": 68949752,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.294999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999727
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 3 finding(s).
| Severity | Count |
|---|---|
| 🟢 Low | 1 |
| ⚪ Nit | 2 |
Panel: 8/8 reviewers contributed findings.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18629 +/- ##
==========================================
+ Coverage 83.65% 84.58% +0.93%
==========================================
Files 3018 2294 -724
Lines 148838 131229 -17609
Branches 40331 35408 -4923
==========================================
- Hits 124508 111003 -13505
+ Misses 23029 19925 -3104
+ Partials 1301 301 -1000
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
|
|
|
|
|
Summary
Adds one test case to
agentInsertWorkflow.subgraphs.test.ts: a promoted subgraph widget toggled A -> B -> A via repeatedset_widgetwrites throughinsert_workflow's remap/promotion path.Changes
set_widget, but none exercise a repeated toggle (A -> B -> A) on the same promoted widget throughcomfy-multi-player's remap path — the exact path touched by the nested-subgraph widget-remap fix in comfy-multi-player Update litegraph (Fix drag + alt copy node) #253 / 0.3.6. This adds that case as a baseline regression guard.round-trips a promoted widget through alternating set_widget writes (A -> B -> A)inserts a subgraph host with a promotedNUMBERwidget (value5), writes42over it, then writes5back, asserting the live widget value and the widget-value-store entry at each step.@comfyorg/comfy-multi-player@0.3.5, and expected to keep passing after the 0.3.6 bump.Review Focus
agentInsertWorkflowLinks.regression.test.ts'sremoves then reinserts a numeric-id linkcase (same insert_workflow harness, same alternating-state style).Testing
npx vitest run src/workbench/extensions/agent/crdt/agentInsertWorkflow.subgraphs.test.ts— 8 passed (7 existing + 1 new)npx vitest run src/workbench/extensions/agent/crdt/— 926 passed, 15 expected-fail (pre-existing, unrelated), no regressionsnpx eslintandnpx oxfmt --checkclean on the changed file🤖 Generated with Claude Code
https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY
Generated by Claude Code