Repository navigation
[Backport core/1.54] test: cover asset panel drag onto existing Load Image node bypassing upload - #18464
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1938 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-22T23:27:00.793Z",
"gitSha": "0e326ca7eb1a9afdbd0fe5af9542c3497b649f89",
"branch": "backport-18180-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2063.4840000000167,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.639000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 643.154,
"heapDeltaBytes": -4283080,
"heapUsedBytes": 65842780,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.922999999999998,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2054.4150000000627,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.057000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 626.9,
"heapDeltaBytes": -10129408,
"heapUsedBytes": 60031064,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 13.007000000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1908.596999999986,
"styleRecalcs": 77,
"styleRecalcDurationMs": 33.54,
"layouts": 14,
"layoutDurationMs": 4.539,
"taskDurationMs": 960.83,
"heapDeltaBytes": 7192240,
"heapUsedBytes": 77721264,
"domNodes": -280,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 172.777,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1834.7109999999702,
"styleRecalcs": 75,
"styleRecalcDurationMs": 30.186,
"layouts": 14,
"layoutDurationMs": 4.3309999999999995,
"taskDurationMs": 908.4160000000002,
"heapDeltaBytes": 11554952,
"heapUsedBytes": 82030384,
"domNodes": -279,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 164.915,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1731.854999999996,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.315999999999995,
"layouts": 6,
"layoutDurationMs": 1.303,
"taskDurationMs": 403.48400000000004,
"heapDeltaBytes": 3533344,
"heapUsedBytes": 68377524,
"domNodes": 76,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 15.340000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1663.7440000000652,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.117,
"layouts": 6,
"layoutDurationMs": 1.0890000000000002,
"taskDurationMs": 365.586,
"heapDeltaBytes": 4680784,
"heapUsedBytes": 75464448,
"domNodes": 75,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.445,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 680.7570000000283,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.932,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.91700000000003,
"heapDeltaBytes": -7840052,
"heapUsedBytes": 63028836,
"domNodes": 22,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 165.928,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 724.5039999999108,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.846,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.70500000000004,
"heapDeltaBytes": 18421852,
"heapUsedBytes": 88553284,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 190.46099999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2034.9479999999858,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.256999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 671.916,
"heapDeltaBytes": 3115264,
"heapUsedBytes": 78600256,
"domNodes": -283,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 38.403999999999996,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2054.5150000000376,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.476,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 680.432,
"heapDeltaBytes": 5311768,
"heapUsedBytes": 81506728,
"domNodes": -277,
"jsHeapTotalBytes": -630784,
"scriptDurationMs": 45.89600000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2552.509999999984,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.646000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1807.584,
"heapDeltaBytes": -1758460,
"heapUsedBytes": 75640628,
"domNodes": -280,
"jsHeapTotalBytes": 118784,
"scriptDurationMs": 851.183,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2307.4910000000273,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.035,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1691.7069999999999,
"heapDeltaBytes": 23471448,
"heapUsedBytes": 89299392,
"domNodes": -275,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 837.997,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3798.456999999985,
"styleRecalcs": 63,
"styleRecalcDurationMs": 15.596000000000002,
"layouts": 60,
"layoutDurationMs": 12.674999999999999,
"taskDurationMs": 1878.4910000000002,
"heapDeltaBytes": -3675364,
"heapUsedBytes": 75004424,
"domNodes": -279,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 807.118,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3591.489999999908,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.009999999999998,
"layouts": 60,
"layoutDurationMs": 12.189000000000002,
"taskDurationMs": 1723.4369999999997,
"heapDeltaBytes": 9937776,
"heapUsedBytes": 76862320,
"domNodes": -280,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 783.115,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3112.9440000000272,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.412,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2005.629,
"heapDeltaBytes": 25912160,
"heapUsedBytes": 93822968,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1000.278,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3122.596999999928,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.753,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1942.289,
"heapDeltaBytes": 22422100,
"heapUsedBytes": 89981908,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 952.515,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2063.5690000000295,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.063000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 688.2210000000001,
"heapDeltaBytes": 8436964,
"heapUsedBytes": 86276840,
"domNodes": -275,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 35.362,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2065.876000000003,
"styleRecalcs": 5,
"styleRecalcDurationMs": 7.554999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 664.6529999999999,
"heapDeltaBytes": 5705516,
"heapUsedBytes": 82940232,
"domNodes": -284,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 34.25399999999999,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 627.9930000000036,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.448,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.435,
"heapDeltaBytes": 15061476,
"heapUsedBytes": 88211616,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 151.797,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 605.1449999999932,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.910000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.396,
"heapDeltaBytes": 13705412,
"heapUsedBytes": 79487548,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 142.22000000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2017.9330000000277,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.575000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 509.255,
"heapDeltaBytes": 466060,
"heapUsedBytes": 73414844,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 9.065,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2015.5640000000403,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.884999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 515.19,
"heapDeltaBytes": -14788832,
"heapUsedBytes": 57924308,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.171000000000003,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1757.0910000000026,
"styleRecalcs": 77,
"styleRecalcDurationMs": 31.306,
"layouts": 18,
"layoutDurationMs": 5.444,
"taskDurationMs": 898.768,
"heapDeltaBytes": -7576248,
"heapUsedBytes": 64400788,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 122.24100000000001,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1755.6640000000243,
"styleRecalcs": 79,
"styleRecalcDurationMs": 32.247,
"layouts": 18,
"layoutDurationMs": 5.594,
"taskDurationMs": 849.8539999999999,
"heapDeltaBytes": -15136048,
"heapUsedBytes": 57836496,
"domNodes": -294,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 116.01499999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.8460000000305,
"styleRecalcs": 18,
"styleRecalcDurationMs": 32.910999999999994,
"layouts": 14,
"layoutDurationMs": 15.775999999999998,
"taskDurationMs": 1041.2050000000002,
"heapDeltaBytes": -5317660,
"heapUsedBytes": 83452480,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 35.75099999999999,
"eventListeners": 2387,
"totalBlockingTimeMs": 149,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9297.435000000007,
"styleRecalcs": 247,
"styleRecalcDurationMs": 37.766,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6225.068,
"heapDeltaBytes": 9612548,
"heapUsedBytes": 85813324,
"domNodes": -270,
"jsHeapTotalBytes": -700416,
"scriptDurationMs": 2796.0769999999998,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8534.45499999998,
"styleRecalcs": 246,
"styleRecalcDurationMs": 35.104,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5944.986999999999,
"heapDeltaBytes": -13385876,
"heapUsedBytes": 89629872,
"domNodes": -270,
"jsHeapTotalBytes": -630784,
"scriptDurationMs": 2763.6150000000002,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17944.389000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17238.464,
"heapDeltaBytes": -40384104,
"heapUsedBytes": 196393996,
"domNodes": -8068,
"jsHeapTotalBytes": -11907072,
"scriptDurationMs": 296.27000000000004,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17877.429000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17198.298000000003,
"heapDeltaBytes": -32718220,
"heapUsedBytes": 184704480,
"domNodes": -8068,
"jsHeapTotalBytes": -11808768,
"scriptDurationMs": 315.98,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21632.00999999998,
"styleRecalcs": 168,
"styleRecalcDurationMs": 19.52999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21276.859,
"heapDeltaBytes": -33739000,
"heapUsedBytes": 183329188,
"domNodes": -8068,
"jsHeapTotalBytes": -11354112,
"scriptDurationMs": 920.1920000000001,
"eventListeners": -14925,
"totalBlockingTimeMs": 87,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22176.634000000035,
"styleRecalcs": 165,
"styleRecalcDurationMs": 22.58899999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21912.799,
"heapDeltaBytes": -45315584,
"heapUsedBytes": 182776988,
"domNodes": -8068,
"jsHeapTotalBytes": -18309120,
"scriptDurationMs": 967.9350000000001,
"eventListeners": -14925,
"totalBlockingTimeMs": 119,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "vue-node-resize-workload",
"durationMs": 6497.575000000041,
"styleRecalcs": 20,
"styleRecalcDurationMs": 91.46399999999998,
"layouts": 20,
"layoutDurationMs": 25.27900000000001,
"taskDurationMs": 6367.341999999999,
"heapDeltaBytes": -34789488,
"heapUsedBytes": 180549396,
"domNodes": -8068,
"jsHeapTotalBytes": 6524928,
"scriptDurationMs": 116.247,
"eventListeners": -14927,
"totalBlockingTimeMs": 450,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6548.406,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.67399999999996,
"layouts": 20,
"layoutDurationMs": 25.604000000000003,
"taskDurationMs": 6455.13,
"heapDeltaBytes": -42667316,
"heapUsedBytes": 184189516,
"domNodes": -8097,
"jsHeapTotalBytes": 10899456,
"scriptDurationMs": 125.25199999999998,
"eventListeners": -14929,
"totalBlockingTimeMs": 428,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9131.721999999969,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8846.132000000001,
"heapDeltaBytes": 13721864,
"heapUsedBytes": 193800084,
"domNodes": 0,
"jsHeapTotalBytes": -7077888,
"scriptDurationMs": 177.38200000000003,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9136.45400000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8755.402,
"heapDeltaBytes": 9252780,
"heapUsedBytes": 178710424,
"domNodes": 0,
"jsHeapTotalBytes": -9699328,
"scriptDurationMs": 155.79999999999993,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 111.30800000000818,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.224,
"layouts": 2,
"layoutDurationMs": 0.72,
"taskDurationMs": 79.89500000000001,
"heapDeltaBytes": 3120720,
"heapUsedBytes": 72172748,
"domNodes": 112,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.8359999999999985,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 96.94400000000769,
"styleRecalcs": 6,
"styleRecalcDurationMs": 11.428,
"layouts": 2,
"layoutDurationMs": 0.98,
"taskDurationMs": 63.153,
"heapDeltaBytes": 2993404,
"heapUsedBytes": 72066356,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.526000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
da8116e to
c604adc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #18464 +/- ##
=============================================
+ Coverage 83.55% 83.56% +0.01%
=============================================
Files 2094 2094
Lines 123648 123655 +7
Branches 31499 33351 +1852
=============================================
+ Hits 103315 103337 +22
+ Misses 20154 20139 -15
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
d4fafd0 to
da8116e
Compare
…upload (#18180) <!-- ccr-slack-attribution --> _Requested by **Jo Zhang** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789875316334739)_ Dragging an item out of the Asset Library panel onto an **existing** Load Image node's widget (not empty canvas) updates the widget's filename correctly, but the node's preview shows a broken image / "Image does not exist" instead of the picture. This adds a failing (`test.fail`) e2e repro. No fix included, per the reporting thread's request. `MediaAssetCard.vue`'s `dragStart()` reads the asset's *original* output location straight off its metadata (`filename`/`subfolder`/`type` — e.g. `ComfyUI_temp_<random>_00001_.png [temp]`, the same shape `folder_paths.py`'s own temp-file naming produces) and publishes it as `application/x-comfy-asset-info`. `useNodeDragAndDrop.ts`'s drop handler sees that MIME type and treats it as an already-uploaded `ResultItem`, calling `onResultItemDrop` -> `onUploadComplete` directly (`useNodeImageUpload.ts`). That path never POSTs to `/upload/image` the way a real OS file drag or paste does, so nothing copies (or even checks for) the file at the location the card's metadata names. When that location was the ephemeral `temp` folder from a since-finished job, the widget value becomes a real-looking annotated path that nothing backs, and the live preview's `/view` request 404s. This is a **different mechanism** from two other bugs in this area: - The agent-CRDT stale-preview family: writes bypass `widget.callback`/`onWidgetChanged`, leaving a valid-but-stale image on screen until refresh. Here the callback/`onWidgetChanged` chain runs exactly as designed — the value it commits was just never a real, current upload. - The open "resolve annotated widget values to their own directory" fix (#15065): that fixes `nodeOutputStore.createOutputs` mis-parsing an annotated `[output]`/`[temp]` value into the wrong `/view` query params. That PR's own description scopes out "the drag-drop preview-restore... half" of this bug family as a separate, unaddressed issue — this PR is that other half. Even with #15065's URL-parsing fix applied, this repro still 404s, because the dragged asset's file was never re-uploaded/verified to exist at all; only its *reported* location is now correctly formatted. - **What**: `browser_tests/tests/sidebar/assetPanelDragOntoLoadImageWidget.spec.ts` — mocks a job-grouped, `temp`-tagged Cloud asset (mirroring a stale intermediate output from a finished job), loads `widgets/load_image_widget`, drags the asset card onto the existing Load Image node, then asserts: the widget value becomes the annotated temp-folder filename, no request ever hits `/upload/image`, and the node's image-load-error state (`TestIds.errors.imageLoadError`) becomes visible. - Test only, no production code changed. - The e2e was not run locally (no ComfyUI/Cloud backend available in this environment); lint, format, and both typecheck scopes (`browser_tests` and the whole app) pass. CI should confirm this fails for the intended reason (broken-image/404, not a setup error) before anyone builds a fix on top of it. - Repro-only per request — no production fix included. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01Ws2BqUcMwaeUuPpKdYNxPV --- _Generated by [Claude Code](https://claude.ai/code/session_01Ws2BqUcMwaeUuPpKdYNxPV)_ --------- Co-authored-by: bymyself <cbyrne@comfy.org> (cherry picked from commit d3b73c8)
da8116e to
37e9802
Compare
Automated backport of #18180 to
core/1.54.The bot's auto-backport (
comfy-pr-bot) failed on this branch with merge conflicts in:src/extensions/core/load3d/Load3DConfiguration.test.tssrc/extensions/core/load3d/Load3DConfiguration.tssrc/utils/createAnnotatedPath.test.tsRoot cause of the conflict
Not a stacking conflict against any of the PRs the bot listed as still-open on
core/1.54(#18417, #18410, #18407, #18369, #18354, #18334, #17872) — none of them touch these files. The real cause is thatcore/1.54never received an already-merged, unrelated PR: #17537 ("Load3D preview capture stale after agent-driven model_file change"), which is not on the bot's open-PR list and is not itself labeled for backport. That PR:DEFAULT_GIZMO/GizmoConfigblock toLoad3DConfiguration.tsright next to theparseAnnotatedFilenamehelper that test: cover asset panel drag onto existing Load Image node bypassing upload #18180 deletes (textual adjacency, not a real dependency — I did not port the gizmo code, since it's out of scope here andcore/1.54has no other reference to it), and addedComfyApi/ComfyApptest imports unused on this branch (dropped),ResultItemtype from@/schemas/apiSchemato@/platform/remote/comfyui/execution/typesonmain, whichcore/1.54hasn't picked up (kept the branch's existing@/schemas/apiSchemaimport), andapp.getRandParam()call insidenodeOutputStore.ts(already present oncore/1.54from an earlier point, unrelated to test: cover asset panel drag onto existing Load Image node bypassing upload #18180) whose test mock innodeOutputStore.test.tswas missinggetRandParam, only surfaced now because test: cover asset panel drag onto existing Load Image node bypassing upload #18180's new test is the first to exercisegetNodeImageUrls()on this file — added the missing mock entry.Resolved by taking #18180's actual change (removing the local
parseAnnotatedFilenamein favor of the sharedparseAnnotatedPathutil) while leaving everything from #17537 out, since it isn't part of this branch.Verification
pnpm exec vitest runon the touched spec files (Load3DConfiguration.test.ts,createAnnotatedPath.test.ts,nodeOutputStore.test.ts,imageUtil.test.ts) — all pass (113/113)pnpm typecheck— cleanpnpm exec eslinton changed files — no errors (2 pre-existingapiSchemadeprecation warnings, unrelated to this change)pnpm exec oxfmt --checkon changed files — cleanassetPanelDragOntoLoadImageWidget.spec.ts) was not run locally (no backend available), consistent with the original PR's own review notes.Requested by Christian Byrne · Slack thread
Generated by Claude Code