Repository navigation
fix(agent): signal the onboarding overlay only while a coach card is on screen - #18439
Conversation
…on screen The coach registered its overlay source as active, which is true from mount, while the card itself renders only once its target has mounted. A target that never mounts left the What's New popup withheld for the whole session with nothing on screen to dismiss. The source now follows the same condition the template renders on.
🎭 Playwright: ✅ 2094 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 70af4257999db66710efb835205caf08a026dd45
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.96 MB gzip 🔴 +270 kBDetailsSummary
Category Glance App Entry Points — 3.87 kB (baseline 3.73 kB) • 🔴 +138 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.44 MB (baseline 1.43 MB) • 🔴 +13.6 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 124 kB) • 🔴 +8.02 kBTop-level views, pages, and routed surfaces
Status: 17 added / 16 removed / 1 unchanged Panels & Settings — 639 kB (baseline 621 kB) • 🔴 +17.6 kBConfiguration panels, inspectors, and settings screens
Status: 28 added / 27 removed User & Accounts — 37.9 kB (baseline 27.8 kB) • 🔴 +10.1 kBAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 2 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🔴 +740 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 123 kB (baseline 117 kB) • 🔴 +6.31 kBReusable component library chunks
Status: 16 added / 15 removed Data & Services — 3.92 MB (baseline 3.6 MB) • 🔴 +314 kBStores, services, APIs, and repositories
Status: 16 added / 16 removed Utilities & Hooks — 577 kB (baseline 559 kB) • 🔴 +18.7 kBHelpers, composables, and utility bundles
Status: 31 added / 29 removed / 7 unchanged Vendor & Third-Party — 17.4 MB (baseline 18.1 MB) • 🟢 -692 kBExternal libraries and shared vendor chunks
Status: 11 added / 11 removed / 7 unchanged Other — 17.8 MB (baseline 16.4 MB) • 🔴 +1.42 MBBundles that do not match a named category
Status: 179 added / 173 removed / 123 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-22T14:50:31.452Z",
"gitSha": "7080e12afa94b5e82849fc13a84450247887fe30",
"branch": "maanil/pm-1461-coach-overlay-needs-target",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2040.5269999999973,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.799000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 564.3900000000001,
"heapDeltaBytes": 15052348,
"heapUsedBytes": 76276404,
"domNodes": -261,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 12.229000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2006.6140000000132,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.76,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.735,
"heapDeltaBytes": -4260516,
"heapUsedBytes": 58188796,
"domNodes": -261,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.271,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1848.5109999999736,
"styleRecalcs": 45,
"styleRecalcDurationMs": 17.535999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 993.8560000000001,
"heapDeltaBytes": 9578172,
"heapUsedBytes": 77134384,
"domNodes": -261,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 189.925,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1778.6730000000261,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.849999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 866.9000000000001,
"heapDeltaBytes": -4097700,
"heapUsedBytes": 63445756,
"domNodes": -261,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 170.88600000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1731.9929999999886,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.619999999999997,
"layouts": 6,
"layoutDurationMs": 1.461,
"taskDurationMs": 494.97099999999995,
"heapDeltaBytes": 3190168,
"heapUsedBytes": 70651572,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 18.692,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.0730000000367,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.505999999999998,
"layouts": 6,
"layoutDurationMs": 1.1329999999999998,
"taskDurationMs": 358.403,
"heapDeltaBytes": 2338432,
"heapUsedBytes": 64335512,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.898000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 780.9320000000071,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.316999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.2570000000001,
"heapDeltaBytes": 18956300,
"heapUsedBytes": 86459616,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 193.45600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 693.9569999999549,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.069,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.8450000000001,
"heapDeltaBytes": 18930444,
"heapUsedBytes": 86394100,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 172.36599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1303.1250000000227,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1031.938,
"heapDeltaBytes": 35703664,
"heapUsedBytes": 101446108,
"domNodes": -265,
"jsHeapTotalBytes": 19558400,
"scriptDurationMs": 72.505,
"eventListeners": 0,
"totalBlockingTimeMs": 685,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1252.8959999999643,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 948.202,
"heapDeltaBytes": -16769208,
"heapUsedBytes": 73471768,
"domNodes": -295,
"jsHeapTotalBytes": 21364736,
"scriptDurationMs": 70.38199999999999,
"eventListeners": -217,
"totalBlockingTimeMs": 579,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 874.385000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.3439999999997,
"heapDeltaBytes": 14807252,
"heapUsedBytes": 90170040,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 183.05699999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 247,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 863.6400000000322,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.2259999999997,
"heapDeltaBytes": 14661064,
"heapUsedBytes": 90714188,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 168.63100000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 231,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11782.918999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10762.649,
"heapDeltaBytes": -12921048,
"heapUsedBytes": 68685320,
"domNodes": -10,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8852.272,
"eventListeners": 0,
"totalBlockingTimeMs": 1887,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11365.184999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10444.761,
"heapDeltaBytes": 1141016,
"heapUsedBytes": 83298572,
"domNodes": -18,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 8479.005000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1696,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11079.203000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10039.378,
"heapDeltaBytes": -9507012,
"heapUsedBytes": 72404452,
"domNodes": -16,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 8485.937,
"eventListeners": 0,
"totalBlockingTimeMs": 1632,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11942.994999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11074.848,
"heapDeltaBytes": 9926016,
"heapUsedBytes": 86480792,
"domNodes": -10,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 9154.329,
"eventListeners": 0,
"totalBlockingTimeMs": 2188,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2043.0409999999597,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.430999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 527.5119999999998,
"heapDeltaBytes": -3677920,
"heapUsedBytes": 83500524,
"domNodes": -246,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 36.66,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2027.4949999999308,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.576,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 605.9780000000001,
"heapDeltaBytes": 1886492,
"heapUsedBytes": 83113636,
"domNodes": -242,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 37.772,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3092.8759999999897,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.421,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1926.949,
"heapDeltaBytes": 761248,
"heapUsedBytes": 88764932,
"domNodes": -248,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 971.7470000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2373.0030000000397,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.485000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1739.732,
"heapDeltaBytes": -6435304,
"heapUsedBytes": 81580064,
"domNodes": -219,
"jsHeapTotalBytes": 2351104,
"scriptDurationMs": 881.347,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4051.9560000000183,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.578,
"layouts": 60,
"layoutDurationMs": 16.007,
"taskDurationMs": 1982.7850000000003,
"heapDeltaBytes": 9723656,
"heapUsedBytes": 74941096,
"domNodes": -254,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 932.7520000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3674.0029999999706,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.866999999999997,
"layouts": 60,
"layoutDurationMs": 13.827000000000002,
"taskDurationMs": 1773.5880000000002,
"heapDeltaBytes": 8193740,
"heapUsedBytes": 74553744,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 827.836,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3216.282999999976,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.533999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2119.5139999999997,
"heapDeltaBytes": 540828,
"heapUsedBytes": 66656932,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 1101.6460000000002,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3128.242,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.9049999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1949.612,
"heapDeltaBytes": 23280104,
"heapUsedBytes": 89523724,
"domNodes": 8,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1001.4070000000002,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2066.797000000065,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.934999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 707.1840000000002,
"heapDeltaBytes": -7368548,
"heapUsedBytes": 81837472,
"domNodes": -251,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 43.157000000000004,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2028.5499999999956,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.777,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 562.203,
"heapDeltaBytes": -4421884,
"heapUsedBytes": 84252532,
"domNodes": -248,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 33.39600000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 702.0649999999478,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.675999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.604,
"heapDeltaBytes": 14051456,
"heapUsedBytes": 83870240,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 159.682,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.9990000000244,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.361999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.837,
"heapDeltaBytes": 13713944,
"heapUsedBytes": 83560244,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 149.416,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2014.9809999999775,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.914,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.744,
"heapDeltaBytes": -12917308,
"heapUsedBytes": 56817856,
"domNodes": -276,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.706,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.403000000054,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.3500000000001,
"heapDeltaBytes": -4556440,
"heapUsedBytes": 65237556,
"domNodes": -277,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.030000000000003,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1740.7089999999812,
"styleRecalcs": 46,
"styleRecalcDurationMs": 19.029999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 912.9,
"heapDeltaBytes": 4990540,
"heapUsedBytes": 73767436,
"domNodes": -277,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 131.637,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1722.0350000000053,
"styleRecalcs": 47,
"styleRecalcDurationMs": 17.699999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 811.0580000000001,
"heapDeltaBytes": 6713504,
"heapUsedBytes": 75582852,
"domNodes": -274,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 114.293,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1416.8419999999742,
"styleRecalcs": 16,
"styleRecalcDurationMs": 33.984,
"layouts": 5,
"layoutDurationMs": 14.467,
"taskDurationMs": 1078.0879999999997,
"heapDeltaBytes": -6382824,
"heapUsedBytes": 86289752,
"domNodes": 13667,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 39.17700000000001,
"eventListeners": 2383,
"totalBlockingTimeMs": 165,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10034.897999999997,
"styleRecalcs": 250,
"styleRecalcDurationMs": 43.05500000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6682.389000000001,
"heapDeltaBytes": -5496692,
"heapUsedBytes": 81057924,
"domNodes": -239,
"jsHeapTotalBytes": 221184,
"scriptDurationMs": 3236.681,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8425.56400000001,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.089,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6070.8369999999995,
"heapDeltaBytes": -9713504,
"heapUsedBytes": 76878992,
"domNodes": -216,
"jsHeapTotalBytes": 1269760,
"scriptDurationMs": 2944.54,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15216.680999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14916.958,
"heapDeltaBytes": -72580540,
"heapUsedBytes": 168306244,
"domNodes": -8061,
"jsHeapTotalBytes": -11034624,
"scriptDurationMs": 302.04900000000004,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17363.57399999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16893.329999999998,
"heapDeltaBytes": -57687352,
"heapUsedBytes": 183609512,
"domNodes": -8061,
"jsHeapTotalBytes": -16977920,
"scriptDurationMs": 260.937,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 17405.31199999998,
"styleRecalcs": 124,
"styleRecalcDurationMs": 17.54699999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17224.324,
"heapDeltaBytes": -70343192,
"heapUsedBytes": 170735820,
"domNodes": -8061,
"jsHeapTotalBytes": -16842752,
"scriptDurationMs": 954.378,
"eventListeners": -14928,
"totalBlockingTimeMs": 27,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21541.09099999994,
"styleRecalcs": 164,
"styleRecalcDurationMs": 18.813000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21222.078,
"heapDeltaBytes": -50470244,
"heapUsedBytes": 169602696,
"domNodes": -8061,
"jsHeapTotalBytes": -19791872,
"scriptDurationMs": 1046.74,
"eventListeners": -14928,
"totalBlockingTimeMs": 183,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6765.97199999992,
"styleRecalcs": 20,
"styleRecalcDurationMs": 85.64699999999998,
"layouts": 20,
"layoutDurationMs": 28.766,
"taskDurationMs": 6726.361000000001,
"heapDeltaBytes": -58470836,
"heapUsedBytes": 160352504,
"domNodes": -8061,
"jsHeapTotalBytes": 3661824,
"scriptDurationMs": 132.285,
"eventListeners": -14928,
"totalBlockingTimeMs": 430,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6451.851000000033,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.78,
"layouts": 20,
"layoutDurationMs": 27.060000000000002,
"taskDurationMs": 6413.789,
"heapDeltaBytes": -71018740,
"heapUsedBytes": 170061520,
"domNodes": -8061,
"jsHeapTotalBytes": 11595776,
"scriptDurationMs": 121.002,
"eventListeners": -14928,
"totalBlockingTimeMs": 386,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9164.077999999903,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9037.695,
"heapDeltaBytes": 2135484,
"heapUsedBytes": 180362412,
"domNodes": 0,
"jsHeapTotalBytes": -4456448,
"scriptDurationMs": 164.39799999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9050.45800000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8770.635000000002,
"heapDeltaBytes": -19959408,
"heapUsedBytes": 166871576,
"domNodes": 0,
"jsHeapTotalBytes": -27787264,
"scriptDurationMs": 167.27800000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 131.61300000001575,
"styleRecalcs": 7,
"styleRecalcDurationMs": 21.014000000000003,
"layouts": 3,
"layoutDurationMs": 1.0819999999999999,
"taskDurationMs": 104.665,
"heapDeltaBytes": 3303544,
"heapUsedBytes": 67887736,
"domNodes": 110,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.034999999999998,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 113.68900000002213,
"styleRecalcs": 9,
"styleRecalcDurationMs": 17.913999999999998,
"layouts": 3,
"layoutDurationMs": 1.257,
"taskDurationMs": 79.25400000000002,
"heapDeltaBytes": 3043240,
"heapUsedBytes": 68578824,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.919,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe onboarding coach now uses one visibility condition for overlay-store signaling and coach rendering. Tests verify inactive state without a target and active state after a late target appears. ChangesOnboarding overlay visibility
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The onboarding coach now signals the overlay only when its target is visible, preventing a missing coach target from blocking the What's New popup. No concrete merge-blocking risk remains. Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The title uses the bug-fix signal “fix”. The PR changes frontend files under
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18439 +/- ##
==========================================
+ Coverage 83.35% 84.33% +0.98%
==========================================
Files 2990 2288 -702
Lines 147204 129995 -17209
Branches 38043 33223 -4820
==========================================
- Hits 122708 109637 -13071
+ Misses 23214 20063 -3151
+ Partials 1282 295 -987
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 709 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
|
…on screen (#18439) ## Summary The Agent coach told the What's New popup to stay away from the moment it mounted, even when its own card was not on screen yet. If a coach step's target never mounts, that held the popup back for the whole session with nothing visible to dismiss. The signal now follows the card itself. Follow-up to #18287. ## Changes - `OnboardingCoach.vue` registers its overlay source as `active && target !== null`, the same condition the template renders on, through one `visible` computed used by both. - `OnboardingCoach.test.ts` pins that the overlay stays clear while the target is absent and turns on once a late target mounts. ## Review Focus The popup hides a tick later than before: after the target resolves rather than at mount. `WhatsNewPopup.vue` gates on a reactive `v-if` and showing it writes no seen flag, so nothing is burned in that window. ## QA - [x] Unit: 71 passing across `OnboardingCoach`, `releaseStore` and `onboardingOverlayStore` - [x] Revert-red: the tightened target-absent test fails on the previous source and passes on this one - [x] Manual: open the Agent panel with the chat history view showing (no `#agent-composer` on screen), confirm the What's New popup is not withheld
…on screen (#18439) ## Summary The Agent coach told the What's New popup to stay away from the moment it mounted, even when its own card was not on screen yet. If a coach step's target never mounts, that held the popup back for the whole session with nothing visible to dismiss. The signal now follows the card itself. Follow-up to #18287. ## Changes - `OnboardingCoach.vue` registers its overlay source as `active && target !== null`, the same condition the template renders on, through one `visible` computed used by both. - `OnboardingCoach.test.ts` pins that the overlay stays clear while the target is absent and turns on once a late target mounts. ## Review Focus The popup hides a tick later than before: after the target resolves rather than at mount. `WhatsNewPopup.vue` gates on a reactive `v-if` and showing it writes no seen flag, so nothing is burned in that window. ## QA - [x] Unit: 71 passing across `OnboardingCoach`, `releaseStore` and `onboardingOverlayStore` - [x] Revert-red: the tightened target-absent test fails on the previous source and passes on this one - [x] Manual: open the Agent panel with the chat history view showing (no `#agent-composer` on screen), confirm the What's New popup is not withheld
|
@MaanilVerma Successfully backported to #18564 |
|
@MaanilVerma Successfully backported to #18565 |
Summary
The Agent coach told the What's New popup to stay away from the moment it mounted, even when its own card was not on screen yet. If a coach step's target never mounts, that held the popup back for the whole session with nothing visible to dismiss. The signal now follows the card itself.
Follow-up to #18287.
Changes
OnboardingCoach.vueregisters its overlay source asactive && target !== null, the same condition the template renders on, through onevisiblecomputed used by both.OnboardingCoach.test.tspins that the overlay stays clear while the target is absent and turns on once a late target mounts.Review Focus
The popup hides a tick later than before: after the target resolves rather than at mount.
WhatsNewPopup.vuegates on a reactivev-ifand showing it writes no seen flag, so nothing is burned in that window.QA
OnboardingCoach,releaseStoreandonboardingOverlayStore#agent-composeron screen), confirm the What's New popup is not withheld