Repository navigation
[backport core/1.54] Give unified-remint retry fetch its own timeout window - #18673
Conversation
<!-- ccr-slack-attribution --> _Requested via [Slack thread](https://comfy-organization.slack.com/archives/C09KFK2ABB8/p1790161872557349)_ Fixes the pattern behind Sentry `CLOUD-FRONTEND-STAGING-4MF`/`4MG`: the unified-remint retry fetch could spuriously time out under staging load because it inherited whatever was left of the original request's 60s deadline instead of getting a full one. - **What**: `fetchApi()` (`src/scripts/api.ts`) armed a single 60s `AbortSignal` and passed it straight through to `fetchWithUnifiedRemint()`. On a 401, that function re-mints the unified Cloud JWT (`tryRemintToken` → `workspaceAuthStore.remintUnifiedOnce()` → `unifiedUser()` → `unifiedSessionClient.remint()` → `exchangeToken()`, each step with its own independent ~15s ceiling) before retrying the original request — but the retry reused the *same* original signal, so its effective budget was `60s minus whatever the re-mint round trip already spent`, not a fresh 60s. Under load, a slower-than-usual re-mint could leave the retry only a few seconds before it was aborted with `TimeoutError: Fetch timeout`, even though every individual step was within its own budget. `fetchWithUnifiedRemint()` (`src/platform/auth/unified/remintRetry.ts`) now takes an optional 4th parameter, `freshRetrySignal?: () => AbortSignal | undefined`, called only if a retry actually happens; its return value replaces the original `init.signal` on the retry `fetch`. `fetchApi()` passes a callback that mints a new `AbortController` + `setTimeout` (same duration, same `DOMException('Fetch timeout', 'TimeoutError')` construction as the existing timeout, so Sentry grouping stays consistent) combined with the caller's own `signal` via `AbortSignal.any`, and cleans up the new timer in the existing `.finally()`. `fetchWithUnifiedRemint()` has two other call sites (`globalSettingsApi.ts`, `authStore.ts`) that pass no signal at all today; the new parameter is optional and defaults to `undefined`, which keeps their behavior byte-for-byte unchanged (they can't produce this `TimeoutError` in the first place — only a benign `TypeError: Failed to fetch`). - **Breaking**: none - **Dependencies**: none - `remintRetry.ts`: build the retry `fetch`'s `init` from `freshRetrySignal()` when supplied, instead of always spreading the original `init` (which carried the shrunk signal). - `api.ts`: `freshRetrySignal` is only constructed when `timeout` is non-null (i.e. `timeoutMs` wasn't explicitly disabled), and only actually invoked by `fetchWithUnifiedRemint` if a 401 retry happens — a request that never gets a 401 pays no extra cost. - `src/scripts/api.ts`, `fetchApi()`: the new `freshRetrySignal` closure and its timer's cleanup in `.finally()` (no leaked timers on either the happy path or an error path). - `src/platform/auth/unified/remintRetry.ts`, `fetchWithUnifiedRemint()`: the retry `init` construction now branches on whether `freshRetrySignal` was supplied. - Confirmed the two other callers (`globalSettingsApi.ts`, `authStore.ts`) are unaffected — they don't pass a signal today, and the new parameter is optional and off by default. - `src/platform/auth/unified/remintRetry.test.ts`: new cases assert the retry `fetch` receives the object returned by `freshRetrySignal()` (not the original `init.signal`) when supplied, and that the callback is never called when no retry happens. - `src/scripts/api.fetchApi.test.ts`: new regression test with fake timers simulates a 401 → 55s re-mint → 30s retry sequence. Verified (via `git stash` of only the source changes, keeping the new tests) that both new tests fail against the pre-fix code — the retry test rejects with the abort from the stale signal at t=60s — and pass once the fix is restored. Co-authored-by: dante01yoon <bunggl@naver.com> (cherry picked from commit e346ef9)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1946 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-24T02:07:05.471Z",
"gitSha": "d46bb97d1d166af555a38241d5909e51cab99b31",
"branch": "backport-18599-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2100.9450000000243,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.229000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 540.686,
"heapDeltaBytes": -13310336,
"heapUsedBytes": 56185436,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.523,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2054.1729999999916,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.337,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.355,
"heapDeltaBytes": -12403000,
"heapUsedBytes": 57951300,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 14.546000000000003,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1961.0450000000128,
"styleRecalcs": 78,
"styleRecalcDurationMs": 35.044,
"layouts": 14,
"layoutDurationMs": 4.476,
"taskDurationMs": 896.471,
"heapDeltaBytes": 10986400,
"heapUsedBytes": 81234188,
"domNodes": -284,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 185.729,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1840.1450000000068,
"styleRecalcs": 76,
"styleRecalcDurationMs": 28.261999999999997,
"layouts": 14,
"layoutDurationMs": 4.224,
"taskDurationMs": 855.7769999999999,
"heapDeltaBytes": 1067932,
"heapUsedBytes": 72308972,
"domNodes": -283,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 162.78799999999998,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1730.2690000000212,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.733999999999998,
"layouts": 6,
"layoutDurationMs": 0.9730000000000001,
"taskDurationMs": 355.412,
"heapDeltaBytes": 4657240,
"heapUsedBytes": 75817908,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.004,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.325000000008,
"styleRecalcs": 33,
"styleRecalcDurationMs": 16.53,
"layouts": 6,
"layoutDurationMs": 1.0919999999999999,
"taskDurationMs": 354.037,
"heapDeltaBytes": 4584296,
"heapUsedBytes": 75905412,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.595,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 651.1750000000234,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.151000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.81499999999994,
"heapDeltaBytes": 18681848,
"heapUsedBytes": 88477580,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 161.961,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 662.0149999999967,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.735,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.7410000000001,
"heapDeltaBytes": -8199388,
"heapUsedBytes": 62971656,
"domNodes": 18,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 177.79500000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2047.442999999987,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.766,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 604.803,
"heapDeltaBytes": 10852244,
"heapUsedBytes": 86682668,
"domNodes": -269,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 32.66999999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2045.7689999999502,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.142,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.6640000000001,
"heapDeltaBytes": 11193368,
"heapUsedBytes": 86884456,
"domNodes": -269,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 37.766000000000005,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2369.583999999975,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.787000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1718.918,
"heapDeltaBytes": 21725016,
"heapUsedBytes": 88544960,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 867.457,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2230.809000000022,
"styleRecalcs": 64,
"styleRecalcDurationMs": 8.741999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1629.3270000000002,
"heapDeltaBytes": 21359328,
"heapUsedBytes": 87640168,
"domNodes": -277,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 823.615,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3628.6029999999982,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.404000000000003,
"layouts": 60,
"layoutDurationMs": 11.897000000000002,
"taskDurationMs": 1724.186,
"heapDeltaBytes": 8193020,
"heapUsedBytes": 76157100,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 780.0129999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3525.6630000000087,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.33,
"layouts": 60,
"layoutDurationMs": 11.508999999999999,
"taskDurationMs": 1705.286,
"heapDeltaBytes": -3043612,
"heapUsedBytes": 75680712,
"domNodes": -285,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 762.609,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3161.617000000035,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.760000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2006.78,
"heapDeltaBytes": 22571340,
"heapUsedBytes": 90448980,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1009.0569999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3076.2520000000677,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.771000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1899.864,
"heapDeltaBytes": 20499280,
"heapUsedBytes": 88526120,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 960.3640000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2057.6730000000225,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.156999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 616.205,
"heapDeltaBytes": 7206192,
"heapUsedBytes": 85380684,
"domNodes": -275,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 33.157999999999994,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2038.2629999999153,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.5760000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 573.834,
"heapDeltaBytes": 10296744,
"heapUsedBytes": 87712868,
"domNodes": -271,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 31.71399999999999,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 589.7110000000225,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.298000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.60799999999995,
"heapDeltaBytes": 15068132,
"heapUsedBytes": 88343136,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 140.704,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 628.8349999999809,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.896,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.78800000000007,
"heapDeltaBytes": 14568428,
"heapUsedBytes": 87064376,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 149.112,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2016.55599999998,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.46,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.806,
"heapDeltaBytes": -13604472,
"heapUsedBytes": 59294660,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.198999999999998,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2022.8420000000256,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.501,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.371,
"heapDeltaBytes": -8728448,
"heapUsedBytes": 63789436,
"domNodes": -297,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.1160000000000005,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.8830000000007,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.994999999999997,
"layouts": 18,
"layoutDurationMs": 4.457,
"taskDurationMs": 827.4189999999999,
"heapDeltaBytes": -15492596,
"heapUsedBytes": 57558188,
"domNodes": -297,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 113.24199999999999,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.2009999999937,
"styleRecalcs": 78,
"styleRecalcDurationMs": 27.877999999999997,
"layouts": 18,
"layoutDurationMs": 5.111999999999999,
"taskDurationMs": 823.3580000000001,
"heapDeltaBytes": 166532,
"heapUsedBytes": 73462772,
"domNodes": -297,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 112.198,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1433.9930000000436,
"styleRecalcs": 18,
"styleRecalcDurationMs": 32.231,
"layouts": 14,
"layoutDurationMs": 16.235000000000003,
"taskDurationMs": 1009.4060000000003,
"heapDeltaBytes": -7144784,
"heapUsedBytes": 82844948,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 33.459999999999994,
"eventListeners": 2385,
"totalBlockingTimeMs": 142,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8724.683999999968,
"styleRecalcs": 245,
"styleRecalcDurationMs": 34.737,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5993.406999999999,
"heapDeltaBytes": 15042408,
"heapUsedBytes": 80709376,
"domNodes": -272,
"jsHeapTotalBytes": 1765376,
"scriptDurationMs": 2740.138,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8441.160999999965,
"styleRecalcs": 247,
"styleRecalcDurationMs": 33.309,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5888.272,
"heapDeltaBytes": 15677668,
"heapUsedBytes": 91983048,
"domNodes": -271,
"jsHeapTotalBytes": 385024,
"scriptDurationMs": 2789.663,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17096.134000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16593.751,
"heapDeltaBytes": -51060640,
"heapUsedBytes": 176773336,
"domNodes": -8068,
"jsHeapTotalBytes": -21192704,
"scriptDurationMs": 307.01099999999997,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16698.603000000046,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15998.768,
"heapDeltaBytes": -30118496,
"heapUsedBytes": 182050612,
"domNodes": -8068,
"jsHeapTotalBytes": -11436032,
"scriptDurationMs": 257.521,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21074.015000000032,
"styleRecalcs": 176,
"styleRecalcDurationMs": 17.446000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20741.624,
"heapDeltaBytes": -30378532,
"heapUsedBytes": 192761248,
"domNodes": -8068,
"jsHeapTotalBytes": -15282176,
"scriptDurationMs": 953.807,
"eventListeners": -14929,
"totalBlockingTimeMs": 69,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20812.37999999996,
"styleRecalcs": 175,
"styleRecalcDurationMs": 16.63300000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20441.103,
"heapDeltaBytes": -24353160,
"heapUsedBytes": 192799660,
"domNodes": -8068,
"jsHeapTotalBytes": -11075584,
"scriptDurationMs": 923.125,
"eventListeners": -14925,
"totalBlockingTimeMs": 63,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6094.874000000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.978,
"layouts": 20,
"layoutDurationMs": 22.689999999999987,
"taskDurationMs": 5977.242,
"heapDeltaBytes": -57019624,
"heapUsedBytes": 165113896,
"domNodes": -8068,
"jsHeapTotalBytes": 7524352,
"scriptDurationMs": 108.441,
"eventListeners": -14929,
"totalBlockingTimeMs": 442,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6066.030000000069,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.428,
"layouts": 20,
"layoutDurationMs": 31.642000000000017,
"taskDurationMs": 5932.018,
"heapDeltaBytes": -40468720,
"heapUsedBytes": 177405208,
"domNodes": -8068,
"jsHeapTotalBytes": 12046336,
"scriptDurationMs": 108.05600000000001,
"eventListeners": -14927,
"totalBlockingTimeMs": 352,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8710.835999999972,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8451.339,
"heapDeltaBytes": 5545440,
"heapUsedBytes": 178729880,
"domNodes": 0,
"jsHeapTotalBytes": -11272192,
"scriptDurationMs": 134.40300000000005,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8471.651000000065,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8204.361,
"heapDeltaBytes": 21490828,
"heapUsedBytes": 182075780,
"domNodes": 0,
"jsHeapTotalBytes": -8388608,
"scriptDurationMs": 126.65000000000003,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 473.4269999999583,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.001,
"layouts": 4,
"layoutDurationMs": 1.818,
"taskDurationMs": 119.315,
"heapDeltaBytes": 5079004,
"heapUsedBytes": 74319408,
"domNodes": 149,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 13.665999999999999,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 99.16499999997086,
"styleRecalcs": 8,
"styleRecalcDurationMs": 12.550000000000002,
"layouts": 2,
"layoutDurationMs": 1.071,
"taskDurationMs": 67.03500000000001,
"heapDeltaBytes": 3003020,
"heapUsedBytes": 71559628,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.968,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
|
The Generated by Claude Code |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.54 #18673 +/- ##
==========================================
Coverage 83.73% 83.73%
==========================================
Files 2103 2103
Lines 124583 124612 +29
Branches 31535 31569 +34
==========================================
+ Hits 104314 104344 +30
+ Misses 20090 20089 -1
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Automated backport of #18599 to
core/1.54. The backport bot's automated cherry-pick attempt failed with a merge conflict insrc/scripts/api.fetchApi.test.ts(several other open PRs — #18660, #18369, #18334, #17872 — are stacked againstcore/1.54touching the same file), so this was done manually.What conflicted and how it was resolved
src/scripts/api.fetchApi.test.ts: only the import/mock-setup header conflicted.core/1.54's auth mocking is older thanmain's: this branch'sauthStorestill talks to Firebase directly throughvuefire+firebase/auth(nofirebaseIdentityport exists here yet), so the newdescribe('post-401 retry timeout budget')test'sbeforeEachwas adapted to mockvuefire/firebase/authdirectly (matching the pattern already used in this branch'sauthStore.test.ts) instead of spying onfirebaseIdentity.onUserChanged/onTokenChanged. The newtrackUnifiedAuthRetry/mockDistribution/mockFeatureFlagsmocks were kept, simplified to this branch's non-fromPartialmocking style.src/platform/auth/unified/remintRetry.test.ts: auto-merged, but the new test referenceduseWorkspaceAuthStore()directly; this branch's file mocks that whole module via a hoistedmockRemintinstead, so the test was updated to usemockRemint.mockResolvedValue(...)like every other test in the file.src/scripts/api.ts: auto-merged, but the new timeout-retry code calledaddBreadcrumb(...)directly; this branch imports Sentry asimport * as Sentry from '@sentry/vue'(not a namedaddBreadcrumbimport), so the call was changed toSentry.addBreadcrumb(...)to match this branch's existing convention (used a few lines above in the same file).src/platform/auth/unified/remintRetry.ts: auto-merged cleanly, no changes needed.Verification
pnpm typecheck— cleanpnpm lint(eslint on the touched files;src/scripts/api.tsis repo-ignored from eslint on this branch) — clean, no new oxlint/eslint issuessrc/scripts/api.fetchApi.test.ts— 18/18 passingsrc/platform/auth/unified/remintRetry.test.ts— 23/23 passing🤖 Generated with Claude Code
https://claude.ai/code/session_0137jzrG6RSp5e6YgGp8kxdY
Generated by Claude Code