Repository navigation
test(agent): cover spare autogrow input across a tab switch - #18246
Conversation
…itch #18127 fixed reconciliation dropping the spare, unconnected slot at the tail of an agent-wired autogrow group (PM-1155: the wire looks like it landed on the wrong widget because the slot the user expected to be free is gone) and shipped with unit cover only. Two cases on the seed and tab switch agentAutogrowTabSwitchReconcile.spec.ts already drives: the graph keeps a free `model.images.image_2` after the switch, and the node still draws it. The second is annotated `test.fail()`. Measured at 35524d5 with the fix in place, the DOM either side of the switch is `[2-in-0 "image_1", 2-in-1 "image_2"]` before and `[2-in-0 "image_1"]` after, while `node.inputs` holds the spare throughout - so the fix restored the model and the rendered node still shows the user nowhere to drop a second image.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe PR centralizes autogrow tab-switch regression setup in shared fixtures. It adds marker reconciliation checks, follower resubscription handling, Vue-node boot configuration, and fixture-provided panel and node-state helpers. ChangesAgent autogrow reconciliation
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Other 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 2094 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since f34a7bf24a988127b06efd08a0a92861d9f18b6c
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.96 MB gzip 🔴 +268 kBDetailsSummary
Category Glance App Entry Points — 3.87 kB (baseline 3.73 kB) • 🔴 +138 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.44 MB (baseline 1.43 MB) • 🔴 +13.6 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 124 kB) • 🔴 +8.02 kBTop-level views, pages, and routed surfaces
Status: 17 added / 16 removed / 1 unchanged Panels & Settings — 639 kB (baseline 621 kB) • 🔴 +17.6 kBConfiguration panels, inspectors, and settings screens
Status: 28 added / 27 removed User & Accounts — 37.9 kB (baseline 27.8 kB) • 🔴 +10.1 kBAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 2 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🔴 +740 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 123 kB (baseline 117 kB) • 🔴 +6.31 kBReusable component library chunks
Status: 16 added / 15 removed Data & Services — 3.91 MB (baseline 3.6 MB) • 🔴 +309 kBStores, services, APIs, and repositories
Status: 16 added / 16 removed Utilities & Hooks — 577 kB (baseline 559 kB) • 🔴 +18.7 kBHelpers, composables, and utility bundles
Status: 31 added / 29 removed / 7 unchanged Vendor & Third-Party — 17.4 MB (baseline 18.1 MB) • 🟢 -692 kBExternal libraries and shared vendor chunks
Status: 11 added / 11 removed / 7 unchanged Other — 17.8 MB (baseline 16.4 MB) • 🔴 +1.42 MBBundles that do not match a named category
Status: 179 added / 173 removed / 123 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-22T10:01:24.329Z",
"gitSha": "324d8887c4643c64b95f209380ca9dfd9550d336",
"branch": "qabrowser/autogrow-spare-input-e2e",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1990.1250000000346,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.783,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.376,
"heapDeltaBytes": 4316004,
"heapUsedBytes": 71819104,
"domNodes": -258,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.247000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 1991.1120000000437,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.613,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.678,
"heapDeltaBytes": -7678504,
"heapUsedBytes": 59783484,
"domNodes": -260,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.058,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1757.8269999999634,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.054000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 805.1890000000001,
"heapDeltaBytes": -6449544,
"heapUsedBytes": 61199136,
"domNodes": -262,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 163.446,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1775.9869999999864,
"styleRecalcs": 47,
"styleRecalcDurationMs": 15.338000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 806.37,
"heapDeltaBytes": 5733328,
"heapUsedBytes": 68313140,
"domNodes": -261,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 165.482,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.8779999999938,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.874000000000002,
"layouts": 6,
"layoutDurationMs": 1.029,
"taskDurationMs": 322.894,
"heapDeltaBytes": 2812728,
"heapUsedBytes": 70340252,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.758999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1684.4790000000103,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.169999999999998,
"layouts": 6,
"layoutDurationMs": 1.0750000000000002,
"taskDurationMs": 330.554,
"heapDeltaBytes": 3042632,
"heapUsedBytes": 70612284,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.634000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 657.6259999999934,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.871999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.64599999999996,
"heapDeltaBytes": 18149504,
"heapUsedBytes": 80432336,
"domNodes": 20,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 172.51899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 634.5000000000027,
"styleRecalcs": 14,
"styleRecalcDurationMs": 9.853000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.1740000000001,
"heapDeltaBytes": 18839172,
"heapUsedBytes": 86322540,
"domNodes": 24,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 168.122,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1170.3299999999786,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 816.344,
"heapDeltaBytes": 12256676,
"heapUsedBytes": 82957800,
"domNodes": 0,
"jsHeapTotalBytes": 19558400,
"scriptDurationMs": 66.32300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 545,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1210.0380000000541,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 903.4219999999999,
"heapDeltaBytes": -17038620,
"heapUsedBytes": 72936612,
"domNodes": -296,
"jsHeapTotalBytes": 21102592,
"scriptDurationMs": 73.592,
"eventListeners": -217,
"totalBlockingTimeMs": 554,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 864.1230000000064,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.8269999999999,
"heapDeltaBytes": 14955832,
"heapUsedBytes": 89861032,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 180.066,
"eventListeners": 0,
"totalBlockingTimeMs": 237,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 827.9860000000099,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.3759999999997,
"heapDeltaBytes": 14419896,
"heapUsedBytes": 89723504,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 157.60600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 219,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10590.847000000053,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9662.153,
"heapDeltaBytes": 13825508,
"heapUsedBytes": 95680336,
"domNodes": -12,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 8281.332,
"eventListeners": 0,
"totalBlockingTimeMs": 1318,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10007.379000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9168.606,
"heapDeltaBytes": -588508,
"heapUsedBytes": 81220764,
"domNodes": -14,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7555.7789999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 891,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10322.134000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9457.757999999998,
"heapDeltaBytes": -12557344,
"heapUsedBytes": 69657016,
"domNodes": -12,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 7834.551,
"eventListeners": 0,
"totalBlockingTimeMs": 984,
"frameDurationMs": 18.89333333333337,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10020.496999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9147.048,
"heapDeltaBytes": 4457188,
"heapUsedBytes": 86535872,
"domNodes": -14,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 7535.5650000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 924,
"frameDurationMs": 20.553333333333285,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2020.4309999999737,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.242,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.704,
"heapDeltaBytes": -3342776,
"heapUsedBytes": 83623948,
"domNodes": -243,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 32.495999999999995,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2035.888,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.2509999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.8729999999999,
"heapDeltaBytes": -3739796,
"heapUsedBytes": 83642260,
"domNodes": -244,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 36.159,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2288.9390000000276,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.080000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1677.6530000000002,
"heapDeltaBytes": -3105076,
"heapUsedBytes": 85061164,
"domNodes": -248,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 892.3140000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2326.40600000002,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.751999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1694.0680000000002,
"heapDeltaBytes": -7552932,
"heapUsedBytes": 80446360,
"domNodes": -245,
"jsHeapTotalBytes": 1826816,
"scriptDurationMs": 863.014,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3612.819000000002,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.716999999999999,
"layouts": 60,
"layoutDurationMs": 13.220000000000002,
"taskDurationMs": 1695.2749999999999,
"heapDeltaBytes": 8099548,
"heapUsedBytes": 73961988,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 803.21,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3588.0839999999807,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.592999999999998,
"layouts": 60,
"layoutDurationMs": 13.106,
"taskDurationMs": 1749.9419999999998,
"heapDeltaBytes": -19345776,
"heapUsedBytes": 70336112,
"domNodes": -227,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 798.871,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3189.8160000000075,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.711000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2016.8149999999998,
"heapDeltaBytes": 1117204,
"heapUsedBytes": 92366000,
"domNodes": -256,
"jsHeapTotalBytes": 970752,
"scriptDurationMs": 1025.678,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3195.3340000000026,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.302,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2024.4140000000002,
"heapDeltaBytes": -2212160,
"heapUsedBytes": 88844752,
"domNodes": -255,
"jsHeapTotalBytes": 446464,
"scriptDurationMs": 1042.5819999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2016.089000000079,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.711000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.45200000000006,
"heapDeltaBytes": -5219224,
"heapUsedBytes": 83974620,
"domNodes": -246,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 33.084,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2014.6009999999706,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.535000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.8990000000001,
"heapDeltaBytes": 20237124,
"heapUsedBytes": 84539260,
"domNodes": -246,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.032,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 577.6319999999942,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.590999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.779,
"heapDeltaBytes": 14030308,
"heapUsedBytes": 82983788,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 149.106,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 564.0720000000101,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.082999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.009,
"heapDeltaBytes": 13725884,
"heapUsedBytes": 83480248,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 149.797,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2016.7109999999866,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.844,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.515,
"heapDeltaBytes": 15834628,
"heapUsedBytes": 78778468,
"domNodes": -276,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.77,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.8210000000827,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.252,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.241,
"heapDeltaBytes": 4219668,
"heapUsedBytes": 68198692,
"domNodes": -274,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.639,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1718.8409999999976,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.090000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 729.66,
"heapDeltaBytes": 2478888,
"heapUsedBytes": 72368424,
"domNodes": -276,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 105.662,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1722.8569999999763,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.889,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 736.5070000000001,
"heapDeltaBytes": 4193804,
"heapUsedBytes": 74068652,
"domNodes": -276,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 106.945,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.8840000000191,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.865000000000002,
"layouts": 5,
"layoutDurationMs": 13.247000000000002,
"taskDurationMs": 884.679,
"heapDeltaBytes": -6206292,
"heapUsedBytes": 82135596,
"domNodes": 13667,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 30.431,
"eventListeners": 2383,
"totalBlockingTimeMs": 143,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8398.120000000006,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.889,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5948.797,
"heapDeltaBytes": -4206516,
"heapUsedBytes": 82924160,
"domNodes": -243,
"jsHeapTotalBytes": -827392,
"scriptDurationMs": 2899.5519999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8373.926999999981,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.68099999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5747.38,
"heapDeltaBytes": -19609992,
"heapUsedBytes": 67749916,
"domNodes": -222,
"jsHeapTotalBytes": 4747264,
"scriptDurationMs": 2797.143,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17132.013000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16620.227,
"heapDeltaBytes": -52984332,
"heapUsedBytes": 185329104,
"domNodes": -8061,
"jsHeapTotalBytes": -12255232,
"scriptDurationMs": 260.07800000000003,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16791.22899999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16353.725,
"heapDeltaBytes": -47253420,
"heapUsedBytes": 191145796,
"domNodes": -8061,
"jsHeapTotalBytes": -15138816,
"scriptDurationMs": 258.292,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21113.591000000044,
"styleRecalcs": 164,
"styleRecalcDurationMs": 18.06800000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20874.113,
"heapDeltaBytes": -71143568,
"heapUsedBytes": 169954964,
"domNodes": -8061,
"jsHeapTotalBytes": -19599360,
"scriptDurationMs": 911.621,
"eventListeners": -14928,
"totalBlockingTimeMs": 117,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20399.257000000034,
"styleRecalcs": 161,
"styleRecalcDurationMs": 16.25899999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20036.176,
"heapDeltaBytes": -42462136,
"heapUsedBytes": 191766752,
"domNodes": -8061,
"jsHeapTotalBytes": -11091968,
"scriptDurationMs": 858.414,
"eventListeners": -14928,
"totalBlockingTimeMs": 15,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4691.26099999994,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.185,
"layouts": 20,
"layoutDurationMs": 22.908000000000012,
"taskDurationMs": 4577.282,
"heapDeltaBytes": -44072388,
"heapUsedBytes": 191341096,
"domNodes": -8061,
"jsHeapTotalBytes": 11149312,
"scriptDurationMs": 86.70200000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 84,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 4817.08100000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.46699999999998,
"layouts": 20,
"layoutDurationMs": 23.04200000000001,
"taskDurationMs": 4694.268999999999,
"heapDeltaBytes": -40080152,
"heapUsedBytes": 187745464,
"domNodes": -8062,
"jsHeapTotalBytes": 18411520,
"scriptDurationMs": 91.135,
"eventListeners": -14928,
"totalBlockingTimeMs": 157,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8505.817999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8272.983,
"heapDeltaBytes": -7818400,
"heapUsedBytes": 176270128,
"domNodes": 0,
"jsHeapTotalBytes": -19660800,
"scriptDurationMs": 124.36100000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8483.918000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8309.997,
"heapDeltaBytes": 22117712,
"heapUsedBytes": 183153792,
"domNodes": 0,
"jsHeapTotalBytes": -11272192,
"scriptDurationMs": 132.277,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 466.6980000000649,
"styleRecalcs": 21,
"styleRecalcDurationMs": 29.508999999999997,
"layouts": 3,
"layoutDurationMs": 1.5859999999999999,
"taskDurationMs": 124.664,
"heapDeltaBytes": 5091116,
"heapUsedBytes": 67220448,
"domNodes": 149,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.915000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 103.5349999999653,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.295,
"layouts": 3,
"layoutDurationMs": 1.436,
"taskDurationMs": 76.83600000000001,
"heapDeltaBytes": 3036756,
"heapUsedBytes": 68354284,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.397000000000002,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18246 +/- ##
==========================================
+ Coverage 83.34% 84.34% +0.99%
==========================================
Files 2985 2283 -702
Lines 147092 129883 -17209
Branches 39921 33210 -6711
==========================================
- Hits 122596 109550 -13046
+ Misses 23214 20038 -3176
+ Partials 1282 295 -987
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
DrJKL
left a comment
There was a problem hiding this comment.
Pre-merge blockers:
- [P1] The passing regression case does not wait for the second CRDT subscription and catch-up before checking a state that was already true before the tab switch.
- [P1] The expected-failure marker covers the entire setup, so unrelated setup or lifecycle failures can satisfy the known Vue-rendering failure.
Findings without an anchorable line
- [P3] The PR description calls this "black-box browser" coverage, but the passing case reads
window.app.graph,node.inputs, andgetInputLink()as its oracle. "Browser integration coverage" would describe it accurately; the second case is the user-visible DOM check.
Unverified claims
- [P2] The current CI report proves the first case passes at
3fd1398, but the reverse-patched failing run is not retained or linked. Please attach the command output or artifact showing that the first case fails with only #18127's production change reverted. - [P3] CI proves the expected-failure case reached its final assertion at line 397. I could not locate the exact before/after row arrays or evidence that
node.inputsheld the spare "throughout." Please link that output, or narrow the description to the sampled facts the test retains.
Checked and cleared
- The seed does not execute an agent connect operation, but this is intentional: it represents a graph the agent already left wired so the test isolates tab-return reconciliation.
- The material build provenance is available in exact-head CI: the cloud dist artifact, cloud Playwright report, and pinned test container are all present.
- Fallow reported no issue in the changed file. Browser typecheck, formatting, and type-aware Oxlint pass. Playwright discovers both cloud cases, and exact-head cloud CI passes.
Coverage
Standard review. Lanes: correctness, maintainability, idiomaticity, tests, and documentation. The Playwright lane inventoried helpers first, traced 33 browser interactions, and applied checks A through H plus all 23 repository rulebook items. Fallow ran against the changed file. No lane or changed path was skipped.
| page | ||
| }) => { | ||
| test.setTimeout(60_000) | ||
| test.fail() |
There was a problem hiding this comment.
[P1] Move test.fail() below wireAutogrowNodeAndSwitchTabs(), immediately before the final row assertion. Playwright treats every failure after this marker as expected; a focused test with an arrange failure after test.fail() exited 0. This CI run happened to reach line 397, but a later route, socket, panel, precondition, tab-switch, or screenshot failure would still leave the suite green without exercising the known Vue defect.
There was a problem hiding this comment.
Addressed in 124c32e: test.fail() now scopes only the known final DOM assertion.
There was a problem hiding this comment.
Tracked as FE-2750. The PR merged with this thread unresolved, so the finding is carried in Linear rather than lost here. Filed automatically; close the ticket if the finding is no longer true at main.
| // Everything up to and including the tab switch, shared by both cases | ||
| // below: they differ only in where they look for the free slot | ||
| // afterwards - the graph, or the node the user is actually looking at. | ||
| async function wireAutogrowNodeAndSwitchTabs(page: Page) { |
There was a problem hiding this comment.
[P2] This adds a second owner for the sibling spec's full scenario: 242 unique lines are shared, including six exact blocks of 14 to 83 lines. It also reimplements existing owners such as AgentFollowerHostSocket and AgentPanel. The repository's Playwright rule 19 requires free-standing setup and locator wiring to live in fixtures/helpers. Please put the shared seed and lifecycle in one fixture/helper and leave each spec with its distinct oracle; otherwise route, protocol, and readiness fixes must be kept in sync across both 400-line files.
There was a problem hiding this comment.
Addressed in e2847c0: both specs use one fixture, which reuses AgentFollowerHostSocket and AgentPanel; each spec retains only its oracle.
There was a problem hiding this comment.
Tracked as FE-2752. The PR merged with this thread unresolved, so the finding is carried in Linear rather than lost here. Filed automatically; close the ticket if the finding is no longer true at main.
| topbar.workflowTabs.locator('.p-togglebutton') | ||
| ).toHaveCount(2) | ||
| await topbar.getTab(0).click() | ||
| await expect(topbar.getTab(0)).toHaveClass(/p-togglebutton-checked/) |
There was a problem hiding this comment.
[P1] The checked tab class does not prove the second doc_subscribe and catch-up have applied. The graph already has the expected two-slot array before this switch, so the final expect.poll can pass immediately and only later receive the replay that drops the spare on pre-fix code. Count a new subscription and wait behind the queued catch-up before returning from this step. AgentConversationHarness.switchAwayAndBack() already does both with subscribeCount() and waitForPendingFrames().
There was a problem hiding this comment.
Addressed in 36afe23: the fixture observes the new subscription, sends a host marker behind catch-up, waits for that marker to apply, then asserts the slots.
There was a problem hiding this comment.
Tracked as FE-2754. The PR merged with this thread unresolved, so the finding is carried in Linear rather than lost here. Filed automatically; close the ticket if the finding is no longer true at main.
|
|
||
| test.describe( | ||
| 'Agent CRDT autogrow node keeps a free slot across a tab switch', | ||
| { tag: ['@cloud', '@agent'] }, |
There was a problem hiding this comment.
[P3] This is a Vue-node test but lacks the required @vue-nodes tag and manually sets Comfy.VueNodes.Enabled below. The browser-test guide says every Vue-node test must use the tag and must not set the renderer directly. Since this raw agent fixture does not currently consume that tag, please make the fixture honor it and remove the one-off setting rather than leaving this test outside the suite's renderer contract.
There was a problem hiding this comment.
Addressed in 04b9619: both specs carry @vue-nodes, the agent fixture honors the tag, and the one-off renderer setting is gone.
There was a problem hiding this comment.
Tracked as FE-2756. The PR merged with this thread unresolved, so the finding is carried in Linear rather than lost here. Filed automatically; close the ticket if the finding is no longer true at main.
| await page.route('**/api/agent/run-mode', (route) => | ||
| route.fulfill(jsonRoute({ mode: 'ask_approval', credit_limit: null })) | ||
| ) | ||
| // The CRDT follower only binds a workflow once a real turn's ack |
There was a problem hiding this comment.
[P3] bindWorkflow() is not only reached from a turn acknowledgement. AgentPanelRoot.vue also calls it when an active-tab workflow is switched, opened, or fails to open. Please narrow this to the fact needed by this setup: selecting the switcher target does not itself bind the workflow, so this mocked acknowledgement supplies the workflow ID.
There was a problem hiding this comment.
Addressed in 62c995f: the comment now states only why this setup includes workflow_id in the mocked acknowledgement.
There was a problem hiding this comment.
Tracked as FE-2758. The PR merged with this thread unresolved, so the finding is carried in Linear rather than lost here. Filed automatically; close the ticket if the finding is no longer true at main.
Resolve the sibling-spec overlap in favor of the shared fixture and adopt main's new agent turn and workflow persistence helpers.
## Summary Keep the spare image input visible after returning to an Agent workflow tab. <details><summary>Full context for agent readers</summary> ## Changes - Preserve input/output array identity in `updateNodeSlots`, matching the existing `updateNode` action. Replacing these arrays left live node additions disconnected from the rendered store. - Add a real-store regression covering remote slot replacement followed by live input/output additions and reactive consumers. - Reuse [the autogrow browser evidence](#18246), require the visible slot instead of an expected failure, and wait for accepted turn state before sending completion. ## Review Focus The production change is two in-place array updates. Verify live node/store ownership remains shared after remote reconciliation. No transport, document authority or persistence changes. Incident: [spare input missing after tab return](https://linear.app/comfyorg/issue/PM-1155). This fixes that rendering case; initial wrong-wire/Undo investigation and both release qualifications remain open under the existing completion lane. The evidence-only branch is untouched. ## Testing - [Test-first hosted regression](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35564805909/job/106224444136): the new store case is the sole failure, before production changes. - After repair: 108 focused store/follower/materializer tests pass; one pre-existing expected failure remains. - Both Cloud browser cases pass with one worker and zero retries. Before the production fix, graph retention passes and visible-slot retention fails. - Commit hooks pass affected formatting, lint and application types. Hosted repaired-head checks are still required; local results are not hosted green. ## Screenshots Inspected node capture after tab return: both `image_1` and `image_2` labels/ports are visible. The input area is unobstructed. Trace/video and captures are retained in the completion lane's evidence directory. This establishes the narrow rendering result, not real-service or original wiring/Undo acceptance. Glossary: autogrow adds a spare input after a connection; array identity means node and store retain the same collection object. </details>
|
Updated the title and description at exact head Full context for agent readersThe description now matches the live four-file diff: one shared autogrow fixture, the follower socket visibility correction, Vue-node fixture wiring, and the existing tab-switch spec. It also records that the production rendering fix removed the old Because the earlier reverse-patch run was not retained, the description no longer claims reproducible red-on-base evidence. It reports only the exact-head green remote CI that is available. Local browser work and local checks remain explicitly deferred under the owner Resource Guardian restriction. |
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: ready to approve.
I verified the metadata-only follow-up at the unchanged reviewed head. Both remaining findings are addressed: the description now matches the four-file diff and current non-test.fail() behavior, distinguishes the graph integration oracle from the user-visible browser oracle, and withdraws the unretained reverse-patch claim rather than presenting it as reproducible evidence. The title no longer calls the coverage black-box.
All earlier code findings remain resolved, including the private parser export and catch-up readiness boundary. I found no new findings. The prior CodeRabbit HumanOpsHost warning remains invalid because 'autogrow-e2e' is the fourth socketSid argument, not the optional fifth host-mode argument.
The exact head has no failing or pending check runs. Cloud Playwright, lint/format, browser typecheck, Knip, unit tests, Fallow, performance, and ecosystem matrix all pass. My previous dedicated-worktree checks on this same SHA also passed. Maintainability remains clear: Fallow reports no changed-file findings, and this round changes no code.
|
Conflict with Full context for agent readersMerged current |
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: ready to approve.
I reviewed the merge-resolution head d45684e523. The effective PR diff remains limited to the same four reviewed browser-test files. The conflicted shared fixture is unchanged from the previously reviewed PR parent, and it still incorporates main's overlapping mockWorkflowPersistence extraction, so no relevant base-branch behavior was dropped. All eight prior findings remain addressed; none regressed.
Nit (P3): the description still calls CI at pre-merge SHA 1f5a37b "Exact-head remote CI." The current exact head is d45684e523 and its CI is green, so updating that SHA would keep the evidence statement current. This does not block approval.
Checks passed in a dedicated worktree: frozen install; full app and browser typechecks; changed-file ESLint; type-aware Oxlint (six unrelated existing warnings); full format check; Knip; all five AgentFollowerHostSocket tests; and Playwright discovery of the three cloud autogrow cases. The exact head has 101 completed check runs: 83 successful, 18 intentionally skipped, none pending or failing. Fallow passes. Maintainability remains clear: the shared lifecycle stays consolidated and the merge adds no new PR-only surface.
|
Conflict repaired at exact head Full context for agent readersMerged current Local lint, formatting, typecheck, tests, builds, and browser work were intentionally deferred under the active Resource Guardian restriction. Automatic hosted CI on the exact head is the verification path and is not local browser acceptance. |
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: ready to approve.
I reviewed the current merge-resolution head 8f378e671d. The effective PR diff remains limited to the same four browser-test files. The sole conflict in agentPanelFixture.ts is resolved correctly: both the explicit vueNodes option introduced on main and this PR's @vue-nodes tag contract enable Comfy.VueNodes.Enabled, while the caller's other settings remain present. All eight earlier code and evidence findings remain addressed, and the merge introduces no regression.
Nit (P3): the prior metadata nit was updated to the previous head, but the description now calls CI at d45684e "Exact-head remote CI" while the current exact head is 8f378e671d. Update the SHA after this run finishes if you want the evidence statement to remain exact. This does not block approval.
Checks passed in a dedicated worktree: frozen install; full app and browser typechecks; changed-file ESLint; type-aware Oxlint (six unrelated existing warnings); full format check; Knip; all five AgentFollowerHostSocket tests; and Playwright discovery of the three cloud autogrow cases. Exact-head hosted CI was still running at review time (34 latest checks in progress); an earlier cancelled attempt left aggregate red checks, but the replacement jobs were active and there was no confirmed code failure. Fallow's replacement run was not complete. Maintainability remains clear: the shared lifecycle stays consolidated and the merge adds no new PR-only surface.
|
|
|
|
|
|
Summary
Adds browser integration coverage for the tab-return reconciliation behavior fixed by #18127. The coverage verifies that an agent-wired autogrow node retains a free
model.images.image_2after switching away from and back to its workflow.The original visible-node gap tracked by PM-1155 is no longer an expected failure here: the production rendering fix has since landed on
main, so the current case asserts the visible spare input directly.Changes
browser_tests/fixtures/agentAutogrowSpareInputFixture.ts.parseClientDocFrameprivate toAgentFollowerHostSocketwhile reusing that fixture's supported host behavior.agentPanelFixture.tshonor the existing@vue-nodesrenderer contract.agentAutogrowTabSwitchReconcile.spec.tsto wait for the second subscription and an ordered post-catch-up marker before asserting both graph state and the user-visible spare input row.No production code changes.
Review Focus
The graph assertion is an integration oracle: it inspects
window.app.graph,node.inputs, andgetInputLink()after the second CRDT subscription and queued catch-up complete. It is not described as black-box coverage. The visible-row assertion is the user-facing browser oracle.Exact-head remote CI at
8f378e671d45a7f1855e3c8779f39802eaf5cb3ais green, including the cloud Playwright project, browser typecheck, lint/format, Knip, unit tests, and ecosystem matrix. The earlier reverse-patch run was not retained, so this description does not claim a reproducible red-on-base artifact; it records only the available exact-head green evidence and the behavior exercised by the current test.Local browser work, builds, lint, formatting, typechecking, tests, and preflight scripts were deferred under the owner Resource Guardian restriction. Remote CI is verification evidence, not local browser acceptance.