Repository navigation
fix: guard keybindHandler Escape check against non-Element event targets - #18620
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2122 passed, 0 failed · 1 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 70830f4a5522da3e1727f15205cffdf183adc74f
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle: 9.98 MB gzip 🔴 +286 kBDetailsSummary
Category Glance App Entry Points — 3.87 kB (baseline 3.73 kB) • 🔴 +138 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.44 MB (baseline 1.43 MB) • 🔴 +17.5 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 124 kB) • 🔴 +8.02 kBTop-level views, pages, and routed surfaces
Status: 17 added / 16 removed / 1 unchanged Panels & Settings — 639 kB (baseline 621 kB) • 🔴 +17.6 kBConfiguration panels, inspectors, and settings screens
Status: 28 added / 27 removed User & Accounts — 37.9 kB (baseline 27.8 kB) • 🔴 +10.1 kBAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 2 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🔴 +740 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 124 kB (baseline 117 kB) • 🔴 +6.54 kBReusable component library chunks
Status: 16 added / 15 removed Data & Services — 3.95 MB (baseline 3.6 MB) • 🔴 +347 kBStores, services, APIs, and repositories
Status: 16 added / 16 removed Utilities & Hooks — 577 kB (baseline 559 kB) • 🔴 +18.8 kBHelpers, composables, and utility bundles
Status: 31 added / 29 removed / 7 unchanged Vendor & Third-Party — 17.4 MB (baseline 18.1 MB) • 🟢 -692 kBExternal libraries and shared vendor chunks
Status: 12 added / 12 removed / 6 unchanged Other — 17.8 MB (baseline 16.4 MB) • 🔴 +1.43 MBBundles that do not match a named category
Status: 179 added / 173 removed / 123 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T18:24:08.324Z",
"gitSha": "4dc2511d6f91495befe9d4825db435165364aa0a",
"branch": "fix/keybind-handler-non-element-target",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1991.644000000008,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.384999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 366.62899999999996,
"heapDeltaBytes": 10100304,
"heapUsedBytes": 77550620,
"domNodes": -258,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.556,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1992.2929999999042,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.389000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.3570000000001,
"heapDeltaBytes": -6767992,
"heapUsedBytes": 60788912,
"domNodes": -258,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.5539999999999985,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.3640000000073,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.539,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 641.7090000000001,
"heapDeltaBytes": -5837804,
"heapUsedBytes": 62030844,
"domNodes": -258,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 118.72099999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1693.7639999999874,
"styleRecalcs": 47,
"styleRecalcDurationMs": 13.263,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 650.462,
"heapDeltaBytes": 9704184,
"heapUsedBytes": 77513608,
"domNodes": -259,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 119.75699999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1691.3000000000125,
"styleRecalcs": 30,
"styleRecalcDurationMs": 12.17,
"layouts": 6,
"layoutDurationMs": 1.0510000000000002,
"taskDurationMs": 266.96500000000003,
"heapDeltaBytes": 3097472,
"heapUsedBytes": 70849332,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.072999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1691.8269999999893,
"styleRecalcs": 30,
"styleRecalcDurationMs": 13.5,
"layouts": 6,
"layoutDurationMs": 1.0440000000000003,
"taskDurationMs": 291.054,
"heapDeltaBytes": 3212716,
"heapUsedBytes": 70841128,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.380999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 542.3589999999763,
"styleRecalcs": 14,
"styleRecalcDurationMs": 7.813000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 361.854,
"heapDeltaBytes": 19015072,
"heapUsedBytes": 86562068,
"domNodes": 23,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 129.466,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 527.7630000000499,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.353,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 375.642,
"heapDeltaBytes": 19005524,
"heapUsedBytes": 86586004,
"domNodes": 21,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 134.405,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1037.3220000000174,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 694.6289999999999,
"heapDeltaBytes": -16680356,
"heapUsedBytes": 73710660,
"domNodes": -293,
"jsHeapTotalBytes": 20054016,
"scriptDurationMs": 49.589999999999996,
"eventListeners": -217,
"totalBlockingTimeMs": 389,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1022.9549999999108,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 697.2270000000001,
"heapDeltaBytes": -17471192,
"heapUsedBytes": 73071148,
"domNodes": -292,
"jsHeapTotalBytes": 21102592,
"scriptDurationMs": 47.562000000000005,
"eventListeners": -217,
"totalBlockingTimeMs": 393,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 766.760999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.8670000000002,
"heapDeltaBytes": 14744884,
"heapUsedBytes": 90157228,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 114.43900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 157,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 766.4749999999003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.69099999999986,
"heapDeltaBytes": 14800812,
"heapUsedBytes": 90082108,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 116.231,
"eventListeners": 0,
"totalBlockingTimeMs": 157,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6855.983999999979,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6088.204999999999,
"heapDeltaBytes": -8409336,
"heapUsedBytes": 73285632,
"domNodes": -14,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 5033.275,
"eventListeners": 0,
"totalBlockingTimeMs": 59,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7274.513999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6484.402,
"heapDeltaBytes": -12198148,
"heapUsedBytes": 69809216,
"domNodes": -16,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 5155.726,
"eventListeners": 0,
"totalBlockingTimeMs": 37,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.20000000000073
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7136.471000000029,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.2029999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6382.511,
"heapDeltaBytes": 21150776,
"heapUsedBytes": 99090044,
"domNodes": -260,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 5270.977,
"eventListeners": -174,
"totalBlockingTimeMs": 85,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7113.382999999999,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.144,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6312.0509999999995,
"heapDeltaBytes": 4243672,
"heapUsedBytes": 82104216,
"domNodes": -259,
"jsHeapTotalBytes": 9953280,
"scriptDurationMs": 5245.356,
"eventListeners": -174,
"totalBlockingTimeMs": 62,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2024.2809999999736,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.924,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.72,
"heapDeltaBytes": 1773952,
"heapUsedBytes": 82457844,
"domNodes": -236,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 29.54699999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2024.9789999999166,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.371,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.31800000000004,
"heapDeltaBytes": -8167448,
"heapUsedBytes": 78927052,
"domNodes": -241,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 30.006999999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2166.2189999999555,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.678999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1337.736,
"heapDeltaBytes": -474692,
"heapUsedBytes": 80745788,
"domNodes": -212,
"jsHeapTotalBytes": 1527808,
"scriptDurationMs": 650.697,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2156.793999999991,
"styleRecalcs": 70,
"styleRecalcDurationMs": 13.392999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1334.339,
"heapDeltaBytes": -7863428,
"heapUsedBytes": 80050832,
"domNodes": -242,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 662.879,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3153.6239999999793,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.813999999999998,
"layouts": 60,
"layoutDurationMs": 12.848000000000003,
"taskDurationMs": 1385.9669999999999,
"heapDeltaBytes": 9130440,
"heapUsedBytes": 74509080,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 631.6489999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3217.8270000000566,
"styleRecalcs": 64,
"styleRecalcDurationMs": 12.326,
"layouts": 60,
"layoutDurationMs": 12.706,
"taskDurationMs": 1419.1670000000001,
"heapDeltaBytes": 11283064,
"heapUsedBytes": 77773020,
"domNodes": 10,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 656.774,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2341.511999999966,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.907,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1467.808,
"heapDeltaBytes": 21559284,
"heapUsedBytes": 87556920,
"domNodes": 8,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 827.1990000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2455.8289999999943,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.481000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1616.6879999999999,
"heapDeltaBytes": 9550896,
"heapUsedBytes": 75103600,
"domNodes": -241,
"jsHeapTotalBytes": 2584576,
"scriptDurationMs": 823.0430000000001,
"eventListeners": 28,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2006.4789999999562,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.0419999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.17500000000007,
"heapDeltaBytes": 20245812,
"heapUsedBytes": 84342320,
"domNodes": -251,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 29.761000000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2034.104999999954,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.852999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.66900000000004,
"heapDeltaBytes": -7029872,
"heapUsedBytes": 81898084,
"domNodes": -244,
"jsHeapTotalBytes": 1863680,
"scriptDurationMs": 30.900999999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 497.773000000052,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.263,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 327.087,
"heapDeltaBytes": 14091552,
"heapUsedBytes": 83890712,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 117.676,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 515.8519999999953,
"styleRecalcs": 49,
"styleRecalcDurationMs": 9.872,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 320.872,
"heapDeltaBytes": 13760868,
"heapUsedBytes": 76898688,
"domNodes": 23,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 117.209,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2002.8030000000285,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.810999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 371.8879999999999,
"heapDeltaBytes": 11060916,
"heapUsedBytes": 80887548,
"domNodes": -273,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.158000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1991.6680000000042,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.383,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.66900000000004,
"heapDeltaBytes": -1581164,
"heapUsedBytes": 68322604,
"domNodes": -273,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.033000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.9640000000177,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.118,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 576.9689999999999,
"heapDeltaBytes": 6573372,
"heapUsedBytes": 76422880,
"domNodes": -274,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 77.734,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.1180000001032,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.799000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 625.017,
"heapDeltaBytes": 6527608,
"heapUsedBytes": 76531852,
"domNodes": -273,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 87.63600000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 867.3880000000054,
"styleRecalcs": 18,
"styleRecalcDurationMs": 21.410999999999994,
"layouts": 5,
"layoutDurationMs": 9.142999999999999,
"taskDurationMs": 691.1039999999999,
"heapDeltaBytes": -6290352,
"heapUsedBytes": 81151072,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 21.251999999999992,
"eventListeners": 2383,
"totalBlockingTimeMs": 94,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8208.790000000023,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.434,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4531.026,
"heapDeltaBytes": -10891008,
"heapUsedBytes": 76097040,
"domNodes": -238,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 2148.758,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8305.635000000053,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.852999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4746.531,
"heapDeltaBytes": -6946348,
"heapUsedBytes": 80132704,
"domNodes": -239,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 2229.0950000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14004.826000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13688.048999999999,
"heapDeltaBytes": -28990296,
"heapUsedBytes": 171822596,
"domNodes": -8062,
"jsHeapTotalBytes": -12582912,
"scriptDurationMs": 195.98299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14167.282999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13939.507000000001,
"heapDeltaBytes": -27515108,
"heapUsedBytes": 183282948,
"domNodes": -8062,
"jsHeapTotalBytes": -14004224,
"scriptDurationMs": 206.61400000000003,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16765.093000000037,
"styleRecalcs": 119,
"styleRecalcDurationMs": 14.040999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16556.166999999998,
"heapDeltaBytes": 17642920,
"heapUsedBytes": 191253152,
"domNodes": -8062,
"jsHeapTotalBytes": -21041152,
"scriptDurationMs": 691.4090000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 18,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16931.018999999993,
"styleRecalcs": 118,
"styleRecalcDurationMs": 14.526999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16717.280000000002,
"heapDeltaBytes": -54537964,
"heapUsedBytes": 168483032,
"domNodes": -8062,
"jsHeapTotalBytes": -19316736,
"scriptDurationMs": 705.152,
"eventListeners": -14932,
"totalBlockingTimeMs": 8,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5188.253999999972,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.68199999999999,
"layouts": 20,
"layoutDurationMs": 22.550999999999988,
"taskDurationMs": 5124.402000000001,
"heapDeltaBytes": -58751596,
"heapUsedBytes": 182483948,
"domNodes": -8062,
"jsHeapTotalBytes": 12976128,
"scriptDurationMs": 87.38,
"eventListeners": -14927,
"totalBlockingTimeMs": 263,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5235.719000000017,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.501,
"layouts": 20,
"layoutDurationMs": 21.585999999999995,
"taskDurationMs": 5203.169,
"heapDeltaBytes": -57509292,
"heapUsedBytes": 185036640,
"domNodes": -8062,
"jsHeapTotalBytes": 16941056,
"scriptDurationMs": 86.56599999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 218,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7002.942999999959,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6825.566,
"heapDeltaBytes": 3402368,
"heapUsedBytes": 197748252,
"domNodes": -1,
"jsHeapTotalBytes": -27787264,
"scriptDurationMs": 98.57300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7144.9230000000625,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6964.960000000001,
"heapDeltaBytes": 7529952,
"heapUsedBytes": 193982688,
"domNodes": 0,
"jsHeapTotalBytes": -9699328,
"scriptDurationMs": 97.23300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 87.31999999997697,
"styleRecalcs": 8,
"styleRecalcDurationMs": 12.732000000000003,
"layouts": 2,
"layoutDurationMs": 1.168,
"taskDurationMs": 65.543,
"heapDeltaBytes": 3108464,
"heapUsedBytes": 68614588,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.814000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 440.6740000000582,
"styleRecalcs": 20,
"styleRecalcDurationMs": 19.952,
"layouts": 4,
"layoutDurationMs": 1.7429999999999997,
"taskDurationMs": 99.56099999999999,
"heapDeltaBytes": 5027632,
"heapUsedBytes": 70518376,
"domNodes": 149,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.585999999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
event.composedPath()[0] is typed as HTMLElement but is not guaranteed to actually be one. When no element has focus, some browsers (Safari) fire the keydown with document as the target instead of document.body, and Document has no closest() method, throwing `TypeError: target.closest is not a function` from keybindHandler. Guard the role="menu"/menubar Escape check with `target instanceof Element` before calling closest() so a non-Element target falls through to the normal Escape handling instead of throwing.
b5a44a3 to
8c71085
Compare
|
The commit carried an AI co-author trailer, which this repo's |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18620 +/- ##
==========================================
+ Coverage 83.63% 84.57% +0.93%
==========================================
Files 3018 2294 -724
Lines 148739 131131 -17608
Branches 40301 35379 -4922
==========================================
- Hits 124396 110898 -13498
+ Misses 23042 19932 -3110
+ Partials 1301 301 -1000
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 733 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
|
## Summary Backports #18620 to `core/1.54`. Guards the Escape menu check when `composedPath()[0]` is a non-Element event target and preserves the release line’s existing `role="menu"` behavior. Includes the source regression test. Source commit: `8c71085132e81c116ac7f945d19af9d0756f0c36` ## Testing - `NODE_OPTIONS=--no-experimental-webstorage pnpm test:unit src/platform/keybindings/keybindingService.escape.test.ts` (14 passed) Co-authored-by: Claude <noreply@anthropic.com>
## Summary Backports #18620 to `core/1.55`. The cherry-pick is clean and includes the source regression test. Source commit: `8c71085132e81c116ac7f945d19af9d0756f0c36` ## Testing - `NODE_OPTIONS=--no-experimental-webstorage pnpm test:unit src/platform/keybindings/keybindingService.escape.test.ts` (15 passed) Co-authored-by: Claude <noreply@anthropic.com>
## Summary Backports #18620 to `cloud/1.55`. The cherry-pick is clean and includes the source regression test. Source commit: `8c71085132e81c116ac7f945d19af9d0756f0c36` ## Testing - `NODE_OPTIONS=--no-experimental-webstorage pnpm test:unit src/platform/keybindings/keybindingService.escape.test.ts` (15 passed) Co-authored-by: Claude <noreply@anthropic.com>
## Summary Backports #18620 to `cloud/1.54`. Guards the Escape menu check when `composedPath()[0]` is a non-Element event target and preserves the release line’s existing `role="menu"` behavior. Includes the source regression test. Source commit: `8c71085132e81c116ac7f945d19af9d0756f0c36` ## Testing - `NODE_OPTIONS=--no-experimental-webstorage pnpm test:unit src/platform/keybindings/keybindingService.escape.test.ts` (14 passed) Co-authored-by: Claude <noreply@anthropic.com>
Requested by Sentry · Slack thread
Summary
Fixes
TypeError: target.closest is not a functioninkeybindHandler, reported by Sentry as CLOUD-FRONTEND-STAGING-4MJ.Changes
keybindHandlerinsrc/platform/keybindings/keybindingService.tsreadsconst target = event.composedPath()[0] as HTMLElementand then callstarget.closest('[role="menu"], [role="menubar"]')to let an open menu own the Escape key. That cast is a lie at runtime:composedPath()[0]is only guaranteed to be anEventTarget. When nothing in the document currently has focus, some browsers (Safari is the documented case) target the keydown atdocumentitself instead of falling back todocument.body, andDocumenthas noclosest()method, so the call throws. This guards the check withtarget instanceof Elementso a non-Element target simply falls through to the normal Escape handling (closing dialogs/modals, running the defaultComfy.Graph.ExitSubgraphkeybinding, etc.) instead of throwing and aborting the whole handler.Review Focus
src/platform/keybindings/keybindingService.ts: the addedtarget instanceof Elementguard on the menu/menubar Escape check. The rest of the function (target.tagName,target.contentEditable,target.classList) is already safe for a non-Element target because those are read inside&&chains that short-circuit onundefined !== 'TEXTAREA'-style comparisons before reaching a method call.src/platform/keybindings/keybindingService.escape.test.ts: new regression test that fires Escape withdocumentas thecomposedPath()[0]target (simulating the no-focus/Safari case) and assertskeybindHandlerdoesn't throw and still runs the default Escape keybinding.Validation
keybindingService.escape.test.ts,keybindingService.canvas.test.ts, andkeybindingService.dialog.test.tssuites: 39 passed.oxlintandeslinton the changed files: clean.vue-tsc --noEmit(full app typecheck): clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01V1jT82HP6itcqu4kZD8hz7