Repository navigation
test(agent): pin the nested-subgraph-instance insert_workflow gap (PR #18607 follow-up) - #18624
Conversation
…18607 follow-up) A subgraph definition whose OWN interior node is itself a subgraph instance of another definition (a subgraph nested inside another subgraph, as opposed to two sibling definitions inserted together) does not materialize through insert_workflow -- the interior node's `type` still names the un-remapped blueprint definition id, which nothing on the live side registers, so it falls back to a plain, widget-less node. Documented as a known gap in #18607 without a repro or a fix. Root-caused to @comfyorg/comfy-multi-player's remapInsertedWorkflowIds(): litegraph's own serializer never nests a definition inside another definition's own `definitions.subgraphs` (LGraph.asSerialisable's findUsedSubgraphIds always flattens every used subgraph, however deep, into ONE top-level list), but the remapper only resolved an interior node's `type` against a scope keyed for that JSON-nesting shape, leaving a FLAT SIBLING reference (what litegraph actually emits) un-remapped. The fix belongs upstream: Comfy-Org/comfy-multi-player#253. This adds the repro as an `it.fails` regression test (agentInsertWorkflow.subgraphs.test.ts), following the same RED-until-dependency-bump convention already used by agentSubgraphInsertWorkflow.regression.test.ts. Full agentInsertWorkflow*.test.ts suite (35 pre-existing cases) and the rest of src/workbench/extensions/agent/crdt/ (925 tests) still pass with no regressions. The underlying defect is in the CRDT insert_workflow data-model pipeline, not the renderer: Vue Nodes (useProcessedWidgets/getNodeByLocatorId) and the legacy canvas both read widgets off the same live LGraphNode, so no renderer-specific change is needed once the interior node materializes correctly.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2125 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 2f0b5857fce36f4b56694a110e085ec654341c51
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.99 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.83 kB (baseline 3.83 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.44 MB (baseline 1.44 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 28 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.96 MB (baseline 3.96 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 578 kB (baseline 578 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.9 MB (baseline 17.9 MB) • ⚪ 0 BBundles that do not match a named category Status: 301 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-24T00:50:57.842Z",
"gitSha": "e0f1e25161a757cf36e325065273c42ccace3d0b",
"branch": "claude/fix-nested-subgraph-widgets-88308",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.2779999999852,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.0200000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.914,
"heapDeltaBytes": -8427072,
"heapUsedBytes": 59231472,
"domNodes": -262,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.814000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2009.4349999999395,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.704000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.437,
"heapDeltaBytes": 7475484,
"heapUsedBytes": 74804120,
"domNodes": -258,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.261999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1726.430999999991,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.914,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 662.2600000000001,
"heapDeltaBytes": -6482908,
"heapUsedBytes": 61403444,
"domNodes": -260,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 116.46500000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1710.356000000047,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.259,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 620.178,
"heapDeltaBytes": -5277216,
"heapUsedBytes": 62306468,
"domNodes": -258,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 110.07900000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.8429999999407,
"styleRecalcs": 30,
"styleRecalcDurationMs": 13.244,
"layouts": 6,
"layoutDurationMs": 1.2170000000000003,
"taskDurationMs": 279.61199999999997,
"heapDeltaBytes": 2194956,
"heapUsedBytes": 64710364,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.649000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.0279999999657,
"styleRecalcs": 31,
"styleRecalcDurationMs": 11.759,
"layouts": 6,
"layoutDurationMs": 0.929,
"taskDurationMs": 272.32500000000005,
"heapDeltaBytes": 2826104,
"heapUsedBytes": 70413964,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.133999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 544.7060000000192,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.989000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 358.15000000000003,
"heapDeltaBytes": 18464352,
"heapUsedBytes": 80406896,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 129.077,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 575.172000000066,
"styleRecalcs": 14,
"styleRecalcDurationMs": 6.796999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.81299999999993,
"heapDeltaBytes": 19008396,
"heapUsedBytes": 86323796,
"domNodes": 23,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 129.188,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1103.4819999999854,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 714.715,
"heapDeltaBytes": -14947112,
"heapUsedBytes": 72897528,
"domNodes": -296,
"jsHeapTotalBytes": 19005440,
"scriptDurationMs": 48.30000000000001,
"eventListeners": -217,
"totalBlockingTimeMs": 437,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1093.6609999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 759.4510000000001,
"heapDeltaBytes": -17713676,
"heapUsedBytes": 73033160,
"domNodes": -295,
"jsHeapTotalBytes": 21364736,
"scriptDurationMs": 58.991000000000014,
"eventListeners": -217,
"totalBlockingTimeMs": 446,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 716.1370000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 321.39000000000004,
"heapDeltaBytes": 14535372,
"heapUsedBytes": 89547456,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 101.62800000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 118,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 747.1389999999474,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 341.42200000000014,
"heapDeltaBytes": 14259392,
"heapUsedBytes": 90683700,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 111.302,
"eventListeners": 0,
"totalBlockingTimeMs": 128,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7438.935000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6525.83,
"heapDeltaBytes": -9646276,
"heapUsedBytes": 72672684,
"domNodes": -20,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 5097.885,
"eventListeners": 0,
"totalBlockingTimeMs": 67,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6580.292999999983,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.0920000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5933.441,
"heapDeltaBytes": -577252,
"heapUsedBytes": 81564316,
"domNodes": -18,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 4784.634,
"eventListeners": 0,
"totalBlockingTimeMs": 44,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7602.3870000000215,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.4869999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6814.387,
"heapDeltaBytes": -6879264,
"heapUsedBytes": 69815352,
"domNodes": -268,
"jsHeapTotalBytes": 11788288,
"scriptDurationMs": 5374.318,
"eventListeners": -174,
"totalBlockingTimeMs": 174,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6657.782999999995,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.8659999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6015.194,
"heapDeltaBytes": -4715868,
"heapUsedBytes": 72950392,
"domNodes": -262,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 4647.014999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 30,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "large-graph-idle",
"durationMs": 2029.8179999999775,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.159000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.411,
"heapDeltaBytes": -3755964,
"heapUsedBytes": 83526792,
"domNodes": -234,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 32.535999999999994,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2024.2030000000568,
"styleRecalcs": 9,
"styleRecalcDurationMs": 11.477,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.387,
"heapDeltaBytes": -3459716,
"heapUsedBytes": 83934808,
"domNodes": -237,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 30.035,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2131.9199999999796,
"styleRecalcs": 70,
"styleRecalcDurationMs": 12.548,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1330.688,
"heapDeltaBytes": -7375492,
"heapUsedBytes": 80620448,
"domNodes": -237,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 654.6039999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2117.323000000056,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.346000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1248.643,
"heapDeltaBytes": 15692320,
"heapUsedBytes": 80296132,
"domNodes": 12,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 615.204,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3246.424999999988,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.255000000000003,
"layouts": 60,
"layoutDurationMs": 14.135,
"taskDurationMs": 1294.6399999999999,
"heapDeltaBytes": 8516448,
"heapUsedBytes": 74170912,
"domNodes": 10,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 619.2639999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3392.881999999986,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.209999999999997,
"layouts": 60,
"layoutDurationMs": 14.605,
"taskDurationMs": 1490.45,
"heapDeltaBytes": 2605156,
"heapUsedBytes": 85640516,
"domNodes": -261,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 628.719,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2251.848999999993,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.068999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1515.4869999999999,
"heapDeltaBytes": -9848552,
"heapUsedBytes": 74516480,
"domNodes": -219,
"jsHeapTotalBytes": 1789952,
"scriptDurationMs": 724.202,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2433.8220000000774,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.030000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1594.291,
"heapDeltaBytes": -17782500,
"heapUsedBytes": 73882020,
"domNodes": -219,
"jsHeapTotalBytes": 1564672,
"scriptDurationMs": 787.7860000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 1997.6930000000266,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.441000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.107,
"heapDeltaBytes": 20201372,
"heapUsedBytes": 84583312,
"domNodes": -240,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.378000000000004,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2029.6710000000076,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.495,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.3039999999999,
"heapDeltaBytes": -8531760,
"heapUsedBytes": 80418644,
"domNodes": -248,
"jsHeapTotalBytes": 1077248,
"scriptDurationMs": 30.24299999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 546.6979999999921,
"styleRecalcs": 49,
"styleRecalcDurationMs": 8.963000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 328.46799999999996,
"heapDeltaBytes": 14009772,
"heapUsedBytes": 83844104,
"domNodes": 23,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 114.01599999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 512.6089999999976,
"styleRecalcs": 49,
"styleRecalcDurationMs": 9.678,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 327.618,
"heapDeltaBytes": 13937800,
"heapUsedBytes": 83640600,
"domNodes": 23,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 114.40899999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1992.5770000000398,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.284000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 324.695,
"heapDeltaBytes": -1012712,
"heapUsedBytes": 62131012,
"domNodes": -276,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.678000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2007.2270000000572,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.431,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.36199999999997,
"heapDeltaBytes": -2370884,
"heapUsedBytes": 67858528,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.118999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.1220000000167,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.668,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 631.3770000000001,
"heapDeltaBytes": 1125964,
"heapUsedBytes": 64322904,
"domNodes": -276,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 80.539,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.5609999999979,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.787999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 599.028,
"heapDeltaBytes": -5243268,
"heapUsedBytes": 57840892,
"domNodes": -273,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 77.981,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 899.4860000000244,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.569,
"layouts": 5,
"layoutDurationMs": 8.715,
"taskDurationMs": 697.938,
"heapDeltaBytes": -6250896,
"heapUsedBytes": 83873844,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 21.936000000000003,
"eventListeners": 2383,
"totalBlockingTimeMs": 115,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8219.971999999983,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.84700000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4815.530000000001,
"heapDeltaBytes": 11413736,
"heapUsedBytes": 98757940,
"domNodes": -216,
"jsHeapTotalBytes": 2613248,
"scriptDurationMs": 2255.036,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8189.5569999999225,
"styleRecalcs": 251,
"styleRecalcDurationMs": 33.993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4605.912,
"heapDeltaBytes": -11094536,
"heapUsedBytes": 75874312,
"domNodes": -238,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 2106.067,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12881.06300000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12281.436000000003,
"heapDeltaBytes": -45015180,
"heapUsedBytes": 195996984,
"domNodes": -8062,
"jsHeapTotalBytes": -20647936,
"scriptDurationMs": 200.33200000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.22666666666664,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 13389.846999999918,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12722.955999999998,
"heapDeltaBytes": -49715772,
"heapUsedBytes": 175599600,
"domNodes": -8062,
"jsHeapTotalBytes": -20717568,
"scriptDurationMs": 231.85900000000004,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15467.655999999919,
"styleRecalcs": 83,
"styleRecalcDurationMs": 14.880000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15070.955000000002,
"heapDeltaBytes": -44634300,
"heapUsedBytes": 192468632,
"domNodes": -8062,
"jsHeapTotalBytes": -15384576,
"scriptDurationMs": 764.0579999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 21,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 16122.446999999966,
"styleRecalcs": 93,
"styleRecalcDurationMs": 15.194999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15729.200000000003,
"heapDeltaBytes": -41573612,
"heapUsedBytes": 179020584,
"domNodes": -8062,
"jsHeapTotalBytes": -20512768,
"scriptDurationMs": 824.9580000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 54,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 4592.264999999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.027,
"layouts": 20,
"layoutDurationMs": 23.649000000000004,
"taskDurationMs": 4474.7469999999985,
"heapDeltaBytes": -36896140,
"heapUsedBytes": 177694140,
"domNodes": -8062,
"jsHeapTotalBytes": 11026432,
"scriptDurationMs": 81.625,
"eventListeners": -14927,
"totalBlockingTimeMs": 60,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4829.558999999904,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.196000000000005,
"layouts": 20,
"layoutDurationMs": 23.102999999999998,
"taskDurationMs": 4772.1849999999995,
"heapDeltaBytes": -31149456,
"heapUsedBytes": 187592732,
"domNodes": -8062,
"jsHeapTotalBytes": 12836864,
"scriptDurationMs": 85.53300000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 109,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6356.118000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6129.254999999999,
"heapDeltaBytes": 21757600,
"heapUsedBytes": 196036072,
"domNodes": 0,
"jsHeapTotalBytes": -32243712,
"scriptDurationMs": 98.41200000000005,
"eventListeners": -2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6833.313999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6486.703,
"heapDeltaBytes": 11724460,
"heapUsedBytes": 181606212,
"domNodes": 0,
"jsHeapTotalBytes": -22806528,
"scriptDurationMs": 104.84599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.22666666666664,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 433.03400000002057,
"styleRecalcs": 16,
"styleRecalcDurationMs": 21.443,
"layouts": 4,
"layoutDurationMs": 2.078,
"taskDurationMs": 109.396,
"heapDeltaBytes": 4878568,
"heapUsedBytes": 70424172,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.144000000000002,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 440.41600000002745,
"styleRecalcs": 14,
"styleRecalcDurationMs": 16.598,
"layouts": 3,
"layoutDurationMs": 0.8420000000000001,
"taskDurationMs": 97.98099999999998,
"heapDeltaBytes": 4922220,
"heapUsedBytes": 70553296,
"domNodes": 123,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.427,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18624 +/- ##
==========================================
+ Coverage 83.66% 84.66% +0.99%
==========================================
Files 3019 2294 -725
Lines 148883 131375 -17508
Branches 38451 35559 -2892
==========================================
- Hits 124565 111228 -13337
+ Misses 23015 19847 -3168
+ Partials 1303 300 -1003
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
the exact-head diff at ec00ce0ad4a88812ae61837990887945e43f372e is limited to the nested-subgraph regression fixture. The fixture builds the serializer’s flat two-definition shape, asserts the insert_workflow operation applies, then checks that the interior SubgraphNode retains its widget name and value. it.fails keeps the current @comfyorg/comfy-multi-player@0.3.5 gap explicit and will fail once the upstream repair makes the assertion unexpectedly pass, forcing the planned pin-and-flip follow-up. There are no unresolved review threads, and all current hosted checks are terminal without an adverse conclusion. Assigning DrJKL for independent disposition.
<!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449)_ ## Before/After **Before:** `cloud/1.54`'s pnpm catalog pinned `@comfyorg/comfy-multi-player` at `0.3.5`, which has the nested-subgraph-instance `insert_workflow` bug (an interior node that is itself a subgraph instance materializes widget-less). **After:** bumps the catalog pin (`pnpm-workspace.yaml` + `pnpm-lock.yaml`, `minimumReleaseAgeExclude` entry) to `0.3.6`, which carries the fix from `comfy-multi-player#253`. ## Note on scope Pin bump only, opened directly against `cloud/1.54` (not stacked on the `main` PR) per request. This branch does not yet have the nested-subgraph regression test that PR #18624 is adding to `main` (that PR is itself still open/unmerged), so there is nothing to flip here. ## Testing - `pnpm install --frozen-lockfile` resolves clean against `0.3.6` (verified installed `node_modules/@comfyorg/comfy-multi-player/package.json` reports `0.3.6`). - `pnpm exec vitest run src/workbench/extensions/agent/crdt/`: 773 passed, 3 expected-fail (baseline on this branch, no regressions from the bump alone). - Confirmed `0.3.6` is actually live on the public npm registry (dist-tags.latest = 0.3.6) before opening this PR. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY --- _Generated by [Claude Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
<!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449)_ ## Before/After **Before:** `core/1.54` pinned `@comfyorg/comfy-multi-player` directly (not via the pnpm catalog). It started this PR at `0.3.4` (this branch never picked up the `0.3.5` catalog backport that `main`/`cloud/1.54` got); while this PR was open, `core/1.54`'s tip independently moved to `0.3.5` (via #18617). Either way, the nested-subgraph-instance `insert_workflow` bug (an interior node that is itself a subgraph instance materializes widget-less) was present. **After:** rebased onto `core/1.54`'s current tip and bumped `package.json`'s direct dependency to `0.3.6`, plus the `minimumReleaseAgeExclude` entry in `pnpm-workspace.yaml`/`pnpm-lock.yaml`. `0.3.6` carries the fix from `comfy-multi-player#253`. ## Note on scope Pin bump only, opened directly against `core/1.54` (not stacked). This branch does not have the nested-subgraph regression test that PR #18624 is adding to `main` (that PR is itself still open/unmerged), so there is nothing to flip here. ## Testing - `pnpm install --frozen-lockfile` resolves clean against `0.3.6` (verified installed `node_modules/@comfyorg/comfy-multi-player/package.json` reports `0.3.6`). - `pnpm exec vitest run src/workbench/extensions/agent/crdt/`: 715 passed, 3 expected-fail (baseline on this branch's current tip, no regressions from the bump alone). - Confirmed `0.3.6` is actually live on the public npm registry (dist-tags.latest = 0.3.6) before opening this PR. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Merge queue dequeue (CI_FAILURE) — investigated and fixedThis was a real failure, not a batching artifact from another PR in the same queue batch. Root cause: while this PR was queued, #18626 (bumping Fix pushed (
Re-enabled auto-merge so it re-enters the merge queue once branch CI on the new commit is green. Created by Claude Tag |
comfy-multi-player was bumped to 0.3.6 (#18626) while this PR was queued, which carries the upstream fix (comfy-multi-player#253) for the nested-subgraph-instance insert_workflow gap this test pins. The merge queue caught it: with the pin bumped, the `it.fails` assertion unexpectedly passed, which Vitest treats as a failure ("Expect test to fail"), failing "CI: Tests Unit" on the gh-readonly-queue merge commit. Flip `it.fails` to a plain `it` and update the header comment now that the gap is fixed and pinned, per the PR's own documented follow-up.
62e6db5 to
551c1c3
Compare
<!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449)_ ## Before/After **Before:** the pnpm catalog pinned `@comfyorg/comfy-multi-player` at `0.3.5`, which has the nested-subgraph-instance `insert_workflow` bug (an interior node that is itself a subgraph instance materializes widget-less because `remapInsertedWorkflowIds()` didn't resolve the flat-sibling `type` reference litegraph's serializer actually emits). **After:** bumps the catalog pin (`pnpm-workspace.yaml` + `pnpm-lock.yaml`, `minimumReleaseAgeExclude` entry) to `0.3.6`, which carries the fix from `comfy-multi-player#253`. ## Note on scope This PR is the pin bump only. PR Comfy-Org#18624 (which added a `it.fails` regression test for this exact bug, keyed to flip once this dependency lands) is **still open/unmerged** on `main` as of this PR — its `mergeable_state` is `blocked`. Since the test doesn't exist on `main` yet, there's nothing to flip here; once Comfy-Org#18624 merges, a follow-up should flip its `it.fails` to a plain `it` (it will pass — see verification below). ## Testing - `pnpm install --frozen-lockfile` resolves clean against `0.3.6` (verified installed `node_modules/@comfyorg/comfy-multi-player/package.json` reports `0.3.6`). - `pnpm exec vitest run src/workbench/extensions/agent/crdt/`: 925 passed, 15 expected-fail (0.3.5 baseline, no regressions from the bump alone). - Confirmed `0.3.6` is actually live on the public npm registry (dist-tags.latest = 0.3.6, integrity matches the release workflow's packed tarball) before opening this PR. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY --- _Generated by [Claude Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
christian-byrne
left a comment
There was a problem hiding this comment.
current-head evidence at 551c1c376a287afdea9fdf418873a1b7fa2793b2: the queue repair is internally consistent with the now-pinned @comfyorg/comfy-multi-player@0.3.6. The only diff replaces the stale expected-failure marker with a normal regression assertion and updates the file-level provenance; the test still exercises a nested subgraph instance, widget names, widget value, projection delivery, and absence of materialization errors. No unresolved review threads are present. Hosted checks are non-adverse; one independent cursor edge-case job remains in progress. Leaving this as COMMENT because the authenticated actor is the requested owner of this bot-authored PR, and assigning remains with DrJKL for independent approval/disposition.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @DrJKL.
Found 3 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 1 |
| 🟢 Low | 1 |
| ⚪ Nit | 1 |
Panel: 7/8 reviewers contributed findings.
Reviewers that did not contribute: claude-opus-5-thinking-max:adversarial (error)
Address Cursor review feedback on PR #18624: the nested-subgraph regression test destructured the first root instance and the first interior SubgraphNode without checking cardinality, so an extra instance or a duplicate nested node could go unnoticed. Assert findSubgraphInstances(graph) has length 1 and that definition A contains exactly one interior SubgraphNode, matching the sibling multi-definition test's convention.
DrJKL
left a comment
There was a problem hiding this comment.
Reviewed the complete current discussion and re-reviewed head f4c7622f6617e53ec79a975ee77b7ce0f80ddfb3 after fixes.
The actionable Cursor cardinality finding is fixed: the test now requires exactly one root instance and one nested instance. The two contested Cursor findings do not reproduce. LGraph assigns distinct root UUIDs and the live node receives a scoped remapped ID, so the blueprint widget value cannot satisfy the live assertion. A direct 0.3.5/0.3.6 comparison also showed that 0.3.6 remaps both inner-first and outer-first definition orders, while 0.3.5 fails both.
The follow-up removes redundant implementation-history comments, replaces the added non-null assertion with explicit narrowing, and updates the PR description for the current 0.3.6 passing-test state. CodeRabbit's skipped review, the CI/Codecov reports, the merge-queue diagnosis, and both prior review summaries contain no remaining action.
Verification on this head:
- Focused Vitest: 8/8 passed.
- Pre-commit formatter, oxlint, ESLint, app typecheck, and Knip passed.
- Standard correctness, maintainability, tests, idiomaticity, and documentation re-review found no remaining issue.
|
|
…18607 follow-up) (#18624) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449)_ ## Summary Add a regression test for an `insert_workflow` containing a subgraph instance nested inside another subgraph definition. The test passes a real LiteGraph serialization through the CRDT pipeline and verifies that the nested instance materializes without errors, with its promoted widget name and value intact. The defect was in `@comfyorg/comfy-multi-player`'s `remapInsertedWorkflowIds()`. LiteGraph serializes all used subgraph definitions into one top-level list, but the old remapper did not resolve an interior node's flat sibling definition ID. [comfy-multi-player#253](Comfy-Org/comfy-multi-player#253) fixed the remapping and shipped in version 0.3.6, which this repository now pins. Both legacy and Vue nodes use the same materialized `SubgraphNode`, so no renderer-specific change is needed. ## Testing - `pnpm vitest run src/workbench/extensions/agent/crdt/agentInsertWorkflow.subgraphs.test.ts`: 8 passed ## Backport Backport this regression test to `core/1.54` and `cloud/1.54`. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Amp <amp@ampcode.com>
…18607 follow-up) (#18624) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449)_ ## Summary Add a regression test for an `insert_workflow` containing a subgraph instance nested inside another subgraph definition. The test passes a real LiteGraph serialization through the CRDT pipeline and verifies that the nested instance materializes without errors, with its promoted widget name and value intact. The defect was in `@comfyorg/comfy-multi-player`'s `remapInsertedWorkflowIds()`. LiteGraph serializes all used subgraph definitions into one top-level list, but the old remapper did not resolve an interior node's flat sibling definition ID. [comfy-multi-player#253](Comfy-Org/comfy-multi-player#253) fixed the remapping and shipped in version 0.3.6, which this repository now pins. Both legacy and Vue nodes use the same materialized `SubgraphNode`, so no renderer-specific change is needed. ## Testing - `pnpm vitest run src/workbench/extensions/agent/crdt/agentInsertWorkflow.subgraphs.test.ts`: 8 passed ## Backport Backport this regression test to `core/1.54` and `cloud/1.54`. ---------
…18607 follow-up) (#18624) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449)_ ## Summary Add a regression test for an `insert_workflow` containing a subgraph instance nested inside another subgraph definition. The test passes a real LiteGraph serialization through the CRDT pipeline and verifies that the nested instance materializes without errors, with its promoted widget name and value intact. The defect was in `@comfyorg/comfy-multi-player`'s `remapInsertedWorkflowIds()`. LiteGraph serializes all used subgraph definitions into one top-level list, but the old remapper did not resolve an interior node's flat sibling definition ID. [comfy-multi-player#253](Comfy-Org/comfy-multi-player#253) fixed the remapping and shipped in version 0.3.6, which this repository now pins. Both legacy and Vue nodes use the same materialized `SubgraphNode`, so no renderer-specific change is needed. ## Testing - `pnpm vitest run src/workbench/extensions/agent/crdt/agentInsertWorkflow.subgraphs.test.ts`: 8 passed ## Backport Backport this regression test to `core/1.54` and `cloud/1.54`. ---------
Requested by Christian Byrne · Slack thread
Summary
Add a regression test for an
insert_workflowcontaining a subgraph instance nested inside another subgraph definition. The test passes a real LiteGraph serialization through the CRDT pipeline and verifies that the nested instance materializes without errors, with its promoted widget name and value intact.The defect was in
@comfyorg/comfy-multi-player'sremapInsertedWorkflowIds(). LiteGraph serializes all used subgraph definitions into one top-level list, but the old remapper did not resolve an interior node's flat sibling definition ID. comfy-multi-player#253 fixed the remapping and shipped in version 0.3.6, which this repository now pins.Both legacy and Vue nodes use the same materialized
SubgraphNode, so no renderer-specific change is needed.Testing
pnpm vitest run src/workbench/extensions/agent/crdt/agentInsertWorkflow.subgraphs.test.ts: 8 passedBackport
Backport this regression test to
core/1.54andcloud/1.54.