Repository navigation
test(agent-crdt): pin insert_workflow dropping promoted host widgets - #18270
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2073 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e9a76712291ccfdce6b0912f3d513f597c00edd8
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle: 9.95 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.81 kB (baseline 3.81 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.46 MB (baseline 1.46 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 638 kB (baseline 638 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 28 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.87 MB (baseline 3.87 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 566 kB (baseline 566 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.8 MB (baseline 17.8 MB) • ⚪ 0 BBundles that do not match a named category Status: 301 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-21T11:14:28.768Z",
"gitSha": "ce4c1046cd29b8ebad057aebe2c75cd4bfa307da",
"branch": "test/insert-workflow-promoted-widget-e2e-repro",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1992.7089999999907,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.172,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 371.98300000000006,
"heapDeltaBytes": 14683692,
"heapUsedBytes": 76633988,
"domNodes": -262,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.556,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1992.748000000006,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.2490000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 377.69700000000006,
"heapDeltaBytes": 11285888,
"heapUsedBytes": 73315064,
"domNodes": -260,
"jsHeapTotalBytes": 3661824,
"scriptDurationMs": 7.413000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1677.9099999999971,
"styleRecalcs": 74,
"styleRecalcDurationMs": 17.541999999999998,
"layouts": 14,
"layoutDurationMs": 2.874,
"taskDurationMs": 614.816,
"heapDeltaBytes": 18435992,
"heapUsedBytes": 80446452,
"domNodes": -261,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 104.524,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1693.5929999999644,
"styleRecalcs": 73,
"styleRecalcDurationMs": 17.685,
"layouts": 14,
"layoutDurationMs": 2.712,
"taskDurationMs": 615.318,
"heapDeltaBytes": 1267468,
"heapUsedBytes": 63340320,
"domNodes": -262,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 103.718,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.9880000000003,
"styleRecalcs": 30,
"styleRecalcDurationMs": 11.26,
"layouts": 6,
"layoutDurationMs": 0.9659999999999999,
"taskDurationMs": 263.948,
"heapDeltaBytes": 2144568,
"heapUsedBytes": 64260528,
"domNodes": 76,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9.350000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.4390000000649,
"styleRecalcs": 31,
"styleRecalcDurationMs": 11.663,
"layouts": 6,
"layoutDurationMs": 0.948,
"taskDurationMs": 265.385,
"heapDeltaBytes": 2181916,
"heapUsedBytes": 64291532,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.629999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 513.9670000000365,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.675,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 322.129,
"heapDeltaBytes": 17884440,
"heapUsedBytes": 80027176,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 112.625,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 527.3009999999658,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.729000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 334.581,
"heapDeltaBytes": 17938720,
"heapUsedBytes": 80055556,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 120.817,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1086.4540000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 740.915,
"heapDeltaBytes": -13720780,
"heapUsedBytes": 72430380,
"domNodes": -294,
"jsHeapTotalBytes": 19529728,
"scriptDurationMs": 47.694,
"eventListeners": -217,
"totalBlockingTimeMs": 432,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1052.2730000000138,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 716.6719999999999,
"heapDeltaBytes": -13559136,
"heapUsedBytes": 72300956,
"domNodes": -297,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 41.92299999999999,
"eventListeners": -217,
"totalBlockingTimeMs": 421,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 716.2309999999934,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.9069999999999,
"heapDeltaBytes": 13887664,
"heapUsedBytes": 90723752,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 107.27999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 119,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 714.7119999999632,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 323.16900000000004,
"heapDeltaBytes": 14401112,
"heapUsedBytes": 90533648,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 103.99599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 115,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6948.014000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6053.851,
"heapDeltaBytes": 2719720,
"heapUsedBytes": 84727024,
"domNodes": -14,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 4786.429,
"eventListeners": 0,
"totalBlockingTimeMs": 76,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6425.791000000004,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.6449999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5694.356,
"heapDeltaBytes": 12302448,
"heapUsedBytes": 89380524,
"domNodes": -268,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 4438.264999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 26,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6900.4180000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6159.857,
"heapDeltaBytes": -5264004,
"heapUsedBytes": 68425172,
"domNodes": -8,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 4835.687,
"eventListeners": 0,
"totalBlockingTimeMs": 81,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6400.768000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5673.929,
"heapDeltaBytes": -1285408,
"heapUsedBytes": 80480608,
"domNodes": -16,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 4415.3949999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 44,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2028.6909999999807,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.733,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.21000000000015,
"heapDeltaBytes": 1145968,
"heapUsedBytes": 82975112,
"domNodes": -244,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 28.668999999999993,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2018.3330000000979,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.6879999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.27799999999996,
"heapDeltaBytes": 20215344,
"heapUsedBytes": 83926732,
"domNodes": -243,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 29.901999999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2119.7579999999903,
"styleRecalcs": 66,
"styleRecalcDurationMs": 8.436,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1202.574,
"heapDeltaBytes": 15243836,
"heapUsedBytes": 79447048,
"domNodes": 8,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 608.644,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2117.522000000008,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.305,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1247.986,
"heapDeltaBytes": -1307756,
"heapUsedBytes": 80826292,
"domNodes": -242,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 620.0009999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3132.6259999999593,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.915999999999999,
"layouts": 60,
"layoutDurationMs": 12.179,
"taskDurationMs": 1278.384,
"heapDeltaBytes": 8242240,
"heapUsedBytes": 74368520,
"domNodes": 6,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 565.245,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3112.7789999999322,
"styleRecalcs": 64,
"styleRecalcDurationMs": 11.102,
"layouts": 60,
"layoutDurationMs": 11.248000000000001,
"taskDurationMs": 1189.4680000000003,
"heapDeltaBytes": -9945644,
"heapUsedBytes": 73534904,
"domNodes": -251,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 552.149,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2154.762000000005,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.663000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1352.4060000000002,
"heapDeltaBytes": 17551080,
"heapUsedBytes": 82795520,
"domNodes": 8,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 663.839,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2263.5309999999436,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.323999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1397.9760000000003,
"heapDeltaBytes": 17736956,
"heapUsedBytes": 83713292,
"domNodes": -248,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 677.7479999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2036.196000000018,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.875999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.7110000000001,
"heapDeltaBytes": -7134024,
"heapUsedBytes": 81812728,
"domNodes": -243,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 30.651999999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2031.296999999995,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.847999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.65500000000003,
"heapDeltaBytes": -7056204,
"heapUsedBytes": 81734932,
"domNodes": -245,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 25.948,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 476.9489999999905,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.403999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 298.423,
"heapDeltaBytes": 14526800,
"heapUsedBytes": 78249376,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 100.97900000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 508.743000000095,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.055000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 292.59499999999997,
"heapDeltaBytes": 13188016,
"heapUsedBytes": 76835932,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 99.35999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1992.6209999999855,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.4639999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 376.19199999999995,
"heapDeltaBytes": 1190564,
"heapUsedBytes": 64658208,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.649000000000002,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2006.167000000005,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.959999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 379.50600000000003,
"heapDeltaBytes": -4877456,
"heapUsedBytes": 64729348,
"domNodes": -274,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 6.750999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1696.1190000000101,
"styleRecalcs": 78,
"styleRecalcDurationMs": 19.962,
"layouts": 18,
"layoutDurationMs": 3.7909999999999995,
"taskDurationMs": 603.257,
"heapDeltaBytes": -1681372,
"heapUsedBytes": 61803752,
"domNodes": -276,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 71.67499999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1676.3990000000604,
"styleRecalcs": 78,
"styleRecalcDurationMs": 18.144000000000002,
"layouts": 18,
"layoutDurationMs": 3.5309999999999993,
"taskDurationMs": 586.41,
"heapDeltaBytes": -2223288,
"heapUsedBytes": 60502516,
"domNodes": -273,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 72.621,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 882.8409999999849,
"styleRecalcs": 19,
"styleRecalcDurationMs": 21.375999999999998,
"layouts": 5,
"layoutDurationMs": 8.588999999999999,
"taskDurationMs": 668.903,
"heapDeltaBytes": -6480516,
"heapUsedBytes": 86376812,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 22.522000000000002,
"eventListeners": 2383,
"totalBlockingTimeMs": 106,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8168.6119999999955,
"styleRecalcs": 249,
"styleRecalcDurationMs": 32.63000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3956.008,
"heapDeltaBytes": -1965652,
"heapUsedBytes": 79608456,
"domNodes": -247,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 1992.791,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8104.011000000014,
"styleRecalcs": 250,
"styleRecalcDurationMs": 27.848,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3763.2299999999996,
"heapDeltaBytes": -13328920,
"heapUsedBytes": 66770640,
"domNodes": -246,
"jsHeapTotalBytes": 3661824,
"scriptDurationMs": 1894.9080000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12593.029999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11823.307,
"heapDeltaBytes": -44184900,
"heapUsedBytes": 195072224,
"domNodes": -8061,
"jsHeapTotalBytes": -16261120,
"scriptDurationMs": 185.807,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 8654.049999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7720.536000000001,
"heapDeltaBytes": -42374440,
"heapUsedBytes": 186522640,
"domNodes": -8062,
"jsHeapTotalBytes": -6012928,
"scriptDurationMs": 128.963,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14998.985000000004,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.485999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14403.348999999998,
"heapDeltaBytes": -51197236,
"heapUsedBytes": 178445972,
"domNodes": -8061,
"jsHeapTotalBytes": -12304384,
"scriptDurationMs": 713.444,
"eventListeners": -14928,
"totalBlockingTimeMs": 25,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 14406.716000000073,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.421999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13771.372,
"heapDeltaBytes": -62951292,
"heapUsedBytes": 173728340,
"domNodes": -8061,
"jsHeapTotalBytes": -11599872,
"scriptDurationMs": 651.725,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.22666666666664,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4324.968000000013,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.76600000000001,
"layouts": 20,
"layoutDurationMs": 21.030999999999995,
"taskDurationMs": 4206.01,
"heapDeltaBytes": -36741192,
"heapUsedBytes": 194106196,
"domNodes": -8062,
"jsHeapTotalBytes": 15671296,
"scriptDurationMs": 77.32799999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 20,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 4106.51299999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 70.737,
"layouts": 20,
"layoutDurationMs": 30.74700000000001,
"taskDurationMs": 3950.9559999999997,
"heapDeltaBytes": -41104596,
"heapUsedBytes": 175585092,
"domNodes": -8061,
"jsHeapTotalBytes": 12804096,
"scriptDurationMs": 88.34199999999997,
"eventListeners": -14928,
"totalBlockingTimeMs": 98,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6322.931999999981,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5929.676,
"heapDeltaBytes": 17046584,
"heapUsedBytes": 195629632,
"domNodes": 0,
"jsHeapTotalBytes": -11796480,
"scriptDurationMs": 93.27099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5581.534000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5313.058,
"heapDeltaBytes": 8679956,
"heapUsedBytes": 175910748,
"domNodes": 0,
"jsHeapTotalBytes": -17825792,
"scriptDurationMs": 72.39100000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 449.0610000000288,
"styleRecalcs": 22,
"styleRecalcDurationMs": 21.489,
"layouts": 4,
"layoutDurationMs": 1.8149999999999997,
"taskDurationMs": 109.21300000000001,
"heapDeltaBytes": 5240908,
"heapUsedBytes": 67070300,
"domNodes": 153,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.344,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 429.7759999999471,
"styleRecalcs": 14,
"styleRecalcDurationMs": 15.847,
"layouts": 3,
"layoutDurationMs": 0.8350000000000001,
"taskDurationMs": 89.056,
"heapDeltaBytes": 4905252,
"heapUsedBytes": 66704264,
"domNodes": 121,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.333,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌐 Website E2ETip All tests passed.
|
Pasting a subgraph blueprint arrives as an `insert_workflow` op. The currently published `@comfyorg/comfy-multi-player@0.3.0` mints fresh ids for a definition's interior nodes and links but never rewrites the definition's own top-level `inputs[].linkIds` (its promoted-widget declarations), and drops a definition-interior link whose origin is the subgraph IO node as dangling. `promotedWidgetNames()` resolves those `linkIds` against the definition's remapped `links`, so every declared input reads back as unpromoted. The host still carries its blueprint `widgets_values`, so `readSemanticNode` sees N opaque values against 0 promoted names, reports `error_reconciling_agent_subgraph_host_widgets`, and drops the values rather than risk landing them on the wrong widget. This repo's reader is correct; the test is red purely because of the published package. It goes green once the dependency is bumped past the release carrying the upstream fix.
00b68a5 to
d33625b
Compare
|
The Generated by Claude Code |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18270 +/- ##
=========================================
Coverage 83.00% 83.01%
=========================================
Files 2955 2959 +4
Lines 145855 145950 +95
Branches 39495 37646 -1849
=========================================
+ Hits 121070 121159 +89
- Misses 23513 23519 +6
Partials 1272 1272
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
0.3.0 dropped promoted host widgets when insert_workflow pasted a subgraph blueprint, which agentSubgraphInsertWorkflow.regression.test.ts pinned as a known-red test. 0.3.2 carries the upstream fix, and the regression test now passes. Also adds 0.3.2 to minimumReleaseAgeExclude alongside the existing comfy-multi-player entries, since the release is newer than the release-age gate.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Pushed The regression test now passes for real, against the unmodified published package: Red on The PR body has been updated to drop the "expected to stay red" note. Release trail: v0.3.2 tag · auto-tag run · publish run Created by Claude Tag |
|
|
|
|
- Removes the `cloud/1.54` multiplayer skew. - Moves directly from 0.2.1 to 0.3.2. - Focused tests and typecheck pass. <details><summary>Full context for agent readers</summary> Backports the multiplayer 0.3.0 adoption from #18163 and the 0.3.2 promoted-widget fix from #18270 directly to `cloud/1.54`, avoiding an obsolete intermediate carrier. ### Changes - **What**: Pins `@comfyorg/comfy-multi-player` 0.3.2, carries the current operation-envelope fixture repair, and adds the real-package `insert_workflow` promoted-widget regression. - **Dependencies**: `@comfyorg/comfy-multi-player` 0.2.1 → 0.3.2. ### Review focus Confirm the release branch should move directly to 0.3.2 and retain both source PRs' regression coverage. ### Verification - Frozen install and supply-chain policy check passed. - Focused Vitest: 3 passed. - `pnpm typecheck` passed. - Oxfmt and type-aware Oxlint passed on changed files. Backport of #18163 and #18270. </details>
- Removes the `core/1.54` multiplayer skew. - Moves directly from 0.2.1 to 0.3.2. - Focused tests and typecheck pass. <details><summary>Full context for agent readers</summary> Backports the multiplayer 0.3.0 adoption from #18163 and the 0.3.2 promoted-widget fix from #18270 directly to `core/1.54`, avoiding an obsolete intermediate carrier. ### Changes - **What**: Pins `@comfyorg/comfy-multi-player` 0.3.2 and adds the real-package `insert_workflow` promoted-widget regression. The deleted cloud-only tab-switch fixture is not revived on this branch. - **Dependencies**: `@comfyorg/comfy-multi-player` 0.2.1 → 0.3.2. ### Review focus Confirm the release branch should move directly to 0.3.2 and that omitting the absent cloud-only fixture is correct. ### Verification - Frozen install and supply-chain policy check passed. - Focused Vitest: 1 passed. - `pnpm typecheck` passed. - Oxfmt and type-aware Oxlint passed on changed files. Backport of #18163 and #18270. </details>
|
|
|
|
Requested by Christian Byrne · Slack thread
Summary
Before: pasting a subgraph blueprint that has promoted widgets silently breaks widget promotion. The host node lands with no promoted widgets and its blueprint values are dropped. Nothing surfaces to the user; the only trace is background telemetry (
error_reconciling_agent_subgraph_host_widgets).After: this PR adds an end-to-end test that proves the bug, and bumps
@comfyorg/comfy-multi-playerfrom0.3.0to0.3.2, which carries the upstream fix from Comfy-Org/comfy-multi-player#230. The test now passes against the real, unmodified package.Changes
src/workbench/extensions/agent/crdt/agentSubgraphInsertWorkflow.regression.test.ts. It mints a realY.Docwith the real, pinned@comfyorg/comfy-multi-player(no mocking of the package), applies a realinsert_workflowop carrying a subgraph definition whose declaredvalueinput is wired to an interior node's widget-bearing input, feeds the resulting update throughFollowerDoc→EcsFollowerAdapter.applyFrame→reconcileAgentAdapters, and asserts that no drift telemetry is reported and the host'swidgets_valuesare re-keyed onto the promoted widget. It mirrors the existingagentSubgraphFollower.test.tsfixtures (createTestSubgraph,enableSubgraphNodeCreation,createGraphMutations,inertPlacementPort) rather than inventing new harness code.@comfyorg/comfy-multi-player0.3.0→0.3.2inpackage.json, withpnpm-lock.yamlupdated to match.pnpm-workspace.yamlgains0.3.2on the existingminimumReleaseAgeExcludeentry for this package, because the release is newer than the release-age gate.Mechanism
remapInsertedWorkflowIds/remapGraph(src/remap.tsin the package) mint fresh ids for everything an insertion carries, including each definition's interiornodes,linksandnodes[].inputs[].link. In0.3.0they never rewrote a definition's own top-levelinputs[].linkIds, the promoted-widget declarations naming which interior links feed each declared input, and they dropped a definition-interior link whose origin is the subgraph IO node (-10) as dangling.promotedWidgetNames()insrc/workbench/extensions/agent/crdt/agentSubgraphHostSlots.tswalks thoselinkIds, missed every lookup against the correctly remappedlinks, and reported zero promoted widgets. The pasted host still carried its opaquewidgets_values, soreadSemanticNode(ecsFollowerAdapter.ts:138) saw N opaque values against 0 promoted names and, exactly as designed, dropped the values rather than risk landing them on the wrong widget.How tested
pnpm vitest run src/workbench/extensions/agent/crdt/agentSubgraphInsertWorkflow.regression.test.tspasses on0.3.2(1 file, 1 test). On0.3.0the same test failed on the promotion drift, with the drift report itself:So the test is red on the broken version and green on the fixed one, against the real published package either way, with no hand-patching of
dist/.vue-tsc --noEmitpasses (exit 0), andoxlint --type-awareandoxfmt --checkare clean on the changed files.Review focus
The dependency bump is the substantive change; the test is the proof. Worth a look at the
minimumReleaseAgeExcludeentry inpnpm-workspace.yaml:0.3.2was published minutes before this bump, so it is added to the existing transitional exclusion list for this package rather than waiting out the gate.🤖 Generated with Claude Code
https://claude.ai/code/session_01EbqU9KR86taXjLJi3LjVGF
Generated by Claude Code