Repository navigation
[backport core/1.54] test(agent): pin the turn a transient socket reconnect abandons (PM-1199) (#18113) - #18531
claude[bot] wants to merge 2 commits into
Conversation
…199) (#18113) *PR Created by the Glary-Bot Agent* --- Failing regression coverage for PM-1199 / PM-1200. Test-only — no product code is touched, and the fix is deliberately out of scope. A user ran the agent in auto mode for a long stretch. The action stream stopped updating, the busy indicator was replaced by a "worked for 3m" summary as if the turn had finished, and the next message came back `Message failed to send: a turn is already in progress for this thread`. **No refresh and no tab close anywhere in the journey** — that is what makes this distinct from PM-1154 and PM-1043. The agent chat stream rides the shared ComfyUI websocket, so any transient close dispatches `reconnecting`. `useAgentSession.onStatus(false)` answers it with `abortActiveTurn()`, which settles the assistant message locally; `onStatus(true)` only sets a flag. Nothing re-attaches, and `agentConversationStore.ingest` then discards every later frame for that turn — `transport` is null and `dropBackgroundTurns()` emptied the map it would otherwise fall back to. The server never saw the socket go away, so its assistant row is still `streaming` and it keeps answering posts with 409 `TURN_IN_PROGRESS`. The user's own CRDT debug attachment carries a single `reconnected` event at 11:15:37 UTC with no reload, `Active agent request/turn id: none`, and a most-recent turn id of `local-error-…`. Full RCA on [PM-1199](https://linear.app/comfyorg/issue/PM-1199/fix-agent-stream-drops-mid-turn-with-no-refresh-leaving-no-working#comment-5804f260). Both frames come from the new fixture driving a real socket close — the second reproduces the reported strings verbatim. `browser_tests/tests/agent/agentTurnSurvivesSocketDrop.spec.ts` — five cases, three `test.fail()`: | Case | Pins | Today | |---|---|---| | keeps rendering the turn after the socket reconnects | post-reconnect deltas are dropped | `test.fail()` | | keeps the turn marked as running | `streaming` flips false, so ActivityTrace becomes the "Worked for …" summary and Stop reverts to Send | `test.fail()` | | does not reject the next message | the nudge comes back 409 `TURN_IN_PROGRESS` | `test.fail()` | | summarises a turn that ends normally | keeps the `workSummary` locator honest so the negatives above cannot pass vacuously | green | | keeps the turn running while audio decoding runs alongside it | Web Audio beside a live turn is harmless | green | `useAgentSession.test.ts` `(g3)`/`(g4)` — the same defect at the lowest level that proves it, as `it.fails`. Their double answers `getMessages` with a `streaming` transcript carrying the full reply, so a repair that re-hydrates on reconnect satisfies them just as well as one that re-attaches the local transport, and both wait 2s so a debounced recovery still trips them. Note `(g)` directly above them asserts today's behaviour as correct, with the comment *"Reconnection recovery is the CRDT follower's job now."* That is the decision that caused this: recovery was delegated for the **document** — `useAgentCrdtFollower` does resubscribe on `reconnected`, and the user's log shows it recovering in 458ms — and nobody was left owning the **conversation**. Whoever fixes this will need to invert `(g)`. - Browser spec: **5 passed** (3 expected-fail), 10 consecutive clean runs. - Unit: **74 passed / 2 expected fail**. - With the markers stripped, each case fails on its documented assertion — `POST_RECONNECT_TEXT` not visible / `Stop` not found / the 409 alert resolving to 1 / `'partial'` vs `'partial and the rest'`. - `vue-tsc` (both tsconfigs), `oxfmt`, `oxlint --type-aware`, `eslint`, `knip` clean. - Shared-fixture regression: `agentInlinePrompt` and `agentInlineReferences` still pass. `agentChatRefreshPersistence` fails identically on a pristine `main` in this sandbox — pre-existing, not from this branch. - **The suites are green by design and go non-zero the moment the product is fixed**, via the repo's existing mechanism (`groupNode.spec.ts`, `VirtualGrid.test.ts`). Playwright raises `Expected to fail, but passed.` and Vitest `Expect test to fail`. - `ws.ts` gains `nextWebSocket()` so a test can await the socket opened *after* a reconnect. `getWebSocket()` is unchanged for its ~25 existing consumers; replacing the single `resolve` slot with a `Set` also fixes a latent bug where a second concurrent waiter was stranded. - In the 409 case the nudge is driven **above** `test.fail()` on purpose: body-level `test.fail()` only sets the expected status when it executes, so once the client re-attaches and Send disappears, that click reports red by name rather than being absorbed. - `startTurn()` gates on the user bubble, not the Stop button. Stop renders from `isSending` before the POST leaves, and frames pushed in that window are dropped with no retry — that race made an earlier revision of this suite fail ~half the time. - The audio control does not call `useWaveAudioPlayer`, so it does not clear the whole audio path. What shows the playback was incidental is that the three socket specs reproduce every symptom with no audio at all. - `transcript()` and the cancel route in the fixture are deliberately unexercised; they keep the fake a faithful server so a re-hydrate repair does not look broken. Re-hydrate on `reconnected` instead of staying inert, **and** treat any `status === 'streaming'` assistant row as pending in `normalizeAgentTranscript` — today only a row carrying a `run_approval` ask re-attaches, which is why a refresh does not recover either. That pair also closes PM-1043 and PM-1154. The backend gap is separate: agent events have no `Last-Event-ID`/replay, so frames sent during the reconnect window are lost outright. Tracked in Linear as PM-1199 (parent) and PM-1200.   --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎭 Playwright: ✅ 21 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T04:36:30.220Z",
"gitSha": "2ff0fea8c25e6e37237223a34fdedfdc321fc94e",
"branch": "backport-18113-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2034.6549999999866,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.737,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.1460000000001,
"heapDeltaBytes": 8824972,
"heapUsedBytes": 78578428,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.198999999999996,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2036.4769999999908,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.177000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 534.6949999999999,
"heapDeltaBytes": 11534128,
"heapUsedBytes": 82089524,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.079999999999998,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1833.5440000000176,
"styleRecalcs": 74,
"styleRecalcDurationMs": 28.502000000000002,
"layouts": 14,
"layoutDurationMs": 4.173,
"taskDurationMs": 899.0919999999999,
"heapDeltaBytes": 13209152,
"heapUsedBytes": 83632596,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 163.101,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1848.4750000000076,
"styleRecalcs": 75,
"styleRecalcDurationMs": 30.346999999999998,
"layouts": 14,
"layoutDurationMs": 4.425999999999999,
"taskDurationMs": 924.3399999999999,
"heapDeltaBytes": -2554676,
"heapUsedBytes": 67925964,
"domNodes": -278,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 168.882,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1733.6159999999836,
"styleRecalcs": 30,
"styleRecalcDurationMs": 20.094,
"layouts": 6,
"layoutDurationMs": 2.655,
"taskDurationMs": 406.929,
"heapDeltaBytes": 4680940,
"heapUsedBytes": 75206512,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.159999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1666.6909999999007,
"styleRecalcs": 29,
"styleRecalcDurationMs": 14.782,
"layouts": 6,
"layoutDurationMs": 0.9940000000000001,
"taskDurationMs": 344.8519999999999,
"heapDeltaBytes": 4377280,
"heapUsedBytes": 75038472,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.605000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 733.126000000027,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.955000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.96099999999996,
"heapDeltaBytes": -7609380,
"heapUsedBytes": 63121356,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 168.618,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 720.3740000001062,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.742999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.75199999999995,
"heapDeltaBytes": 18701524,
"heapUsedBytes": 87727028,
"domNodes": 18,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 169.98499999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2043.0499999999938,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.5829999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 631.3359999999999,
"heapDeltaBytes": -15984092,
"heapUsedBytes": 87420176,
"domNodes": -270,
"jsHeapTotalBytes": -1380352,
"scriptDurationMs": 34.371,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2063.5300000000143,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.608999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 713.335,
"heapDeltaBytes": 4204220,
"heapUsedBytes": 80083840,
"domNodes": -283,
"jsHeapTotalBytes": -892928,
"scriptDurationMs": 39.489,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2286.2820000000283,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.796,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1672.1489999999997,
"heapDeltaBytes": 19065864,
"heapUsedBytes": 85351212,
"domNodes": -273,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 829.582,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2403.5840000000235,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.385000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1771.909,
"heapDeltaBytes": 4536396,
"heapUsedBytes": 81658652,
"domNodes": -280,
"jsHeapTotalBytes": -667648,
"scriptDurationMs": 900.7239999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3673.2959999999366,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.559000000000005,
"layouts": 60,
"layoutDurationMs": 13.015000000000002,
"taskDurationMs": 1777.4159999999997,
"heapDeltaBytes": 14876024,
"heapUsedBytes": 93584924,
"domNodes": 6,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 798.626,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3572.43399999993,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.061000000000002,
"layouts": 60,
"layoutDurationMs": 12.139,
"taskDurationMs": 1745.04,
"heapDeltaBytes": -10979080,
"heapUsedBytes": 67829912,
"domNodes": -286,
"jsHeapTotalBytes": 4349952,
"scriptDurationMs": 789.4570000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3134.209999999939,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.132,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2003.8580000000002,
"heapDeltaBytes": -6868724,
"heapUsedBytes": 73478792,
"domNodes": 6,
"jsHeapTotalBytes": 4874240,
"scriptDurationMs": 1016.6429999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 30,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3116.8969999999945,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.804000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1951.3210000000001,
"heapDeltaBytes": 19851748,
"heapUsedBytes": 88137480,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 965.7020000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2027.3639999999205,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.195,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 595.4459999999999,
"heapDeltaBytes": 10264356,
"heapUsedBytes": 88000004,
"domNodes": -269,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 32.54,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2006.9489999999632,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.6370000000001,
"heapDeltaBytes": 21809304,
"heapUsedBytes": 87802260,
"domNodes": -279,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.748,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 657.2419999999966,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.761000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.052,
"heapDeltaBytes": 15092036,
"heapUsedBytes": 87841740,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 159.74099999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 591.3140000000112,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.215000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.25200000000007,
"heapDeltaBytes": 14303096,
"heapUsedBytes": 86367864,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 142.32500000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2056.400999999994,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.944999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.4479999999999,
"heapDeltaBytes": -14649436,
"heapUsedBytes": 57887636,
"domNodes": -293,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.288999999999998,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2014.8080000000164,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.803,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.91,
"heapDeltaBytes": -13362652,
"heapUsedBytes": 59734328,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.485999999999997,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1732.404000000031,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.774999999999995,
"layouts": 18,
"layoutDurationMs": 4.888,
"taskDurationMs": 865.3570000000001,
"heapDeltaBytes": -5926768,
"heapUsedBytes": 67153084,
"domNodes": -295,
"jsHeapTotalBytes": 7331840,
"scriptDurationMs": 115.486,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.1179999999895,
"styleRecalcs": 77,
"styleRecalcDurationMs": 29.336000000000002,
"layouts": 18,
"layoutDurationMs": 5.378,
"taskDurationMs": 882.3620000000001,
"heapDeltaBytes": -9349548,
"heapUsedBytes": 62690856,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 121.97500000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1386.4350000000059,
"styleRecalcs": 18,
"styleRecalcDurationMs": 32.92099999999999,
"layouts": 14,
"layoutDurationMs": 17.779999999999998,
"taskDurationMs": 974.145,
"heapDeltaBytes": 21963572,
"heapUsedBytes": 105313272,
"domNodes": 13751,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 32.321,
"eventListeners": 2385,
"totalBlockingTimeMs": 148,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8821.604999999978,
"styleRecalcs": 248,
"styleRecalcDurationMs": 37.95700000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6077.257,
"heapDeltaBytes": 5105920,
"heapUsedBytes": 81430772,
"domNodes": -250,
"jsHeapTotalBytes": 380928,
"scriptDurationMs": 2764.7920000000004,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8391.390000000001,
"styleRecalcs": 247,
"styleRecalcDurationMs": 34.21399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5833.611,
"heapDeltaBytes": 13474644,
"heapUsedBytes": 89155596,
"domNodes": -272,
"jsHeapTotalBytes": 380928,
"scriptDurationMs": 2721.273,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18387.959999999908,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17661.897,
"heapDeltaBytes": -42167712,
"heapUsedBytes": 176588988,
"domNodes": -8068,
"jsHeapTotalBytes": -10870784,
"scriptDurationMs": 340.48,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.33666666666662,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17325.418000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16757.482,
"heapDeltaBytes": -56619880,
"heapUsedBytes": 181452024,
"domNodes": -8068,
"jsHeapTotalBytes": -21168128,
"scriptDurationMs": 287.835,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21444.035000000098,
"styleRecalcs": 166,
"styleRecalcDurationMs": 19.498000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21123.958000000002,
"heapDeltaBytes": -39603476,
"heapUsedBytes": 178753628,
"domNodes": -8068,
"jsHeapTotalBytes": -11546624,
"scriptDurationMs": 926.895,
"eventListeners": -14927,
"totalBlockingTimeMs": 48,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21280.15800000003,
"styleRecalcs": 172,
"styleRecalcDurationMs": 17.871000000000027,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20874.214000000004,
"heapDeltaBytes": -53218176,
"heapUsedBytes": 178552764,
"domNodes": -8068,
"jsHeapTotalBytes": -23642112,
"scriptDurationMs": 924.0079999999999,
"eventListeners": -14925,
"totalBlockingTimeMs": 34,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6361.958000000072,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.75999999999999,
"layouts": 20,
"layoutDurationMs": 23.150999999999993,
"taskDurationMs": 6207.969,
"heapDeltaBytes": -34610600,
"heapUsedBytes": 183095624,
"domNodes": -8068,
"jsHeapTotalBytes": 13864960,
"scriptDurationMs": 115.02400000000002,
"eventListeners": -14929,
"totalBlockingTimeMs": 455,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6077.01899999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.80799999999999,
"layouts": 20,
"layoutDurationMs": 23.062999999999985,
"taskDurationMs": 5929.063,
"heapDeltaBytes": -54873404,
"heapUsedBytes": 177682792,
"domNodes": -8068,
"jsHeapTotalBytes": 12337152,
"scriptDurationMs": 115.61200000000002,
"eventListeners": -14927,
"totalBlockingTimeMs": 345,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9090.330999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8695.913999999999,
"heapDeltaBytes": 13299888,
"heapUsedBytes": 179221288,
"domNodes": 0,
"jsHeapTotalBytes": -20709376,
"scriptDurationMs": 174.69599999999997,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8472.552000000065,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8267.967999999997,
"heapDeltaBytes": 14712864,
"heapUsedBytes": 178394576,
"domNodes": 0,
"jsHeapTotalBytes": -16515072,
"scriptDurationMs": 140.385,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 109.84900000005382,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.854,
"layouts": 2,
"layoutDurationMs": 1.392,
"taskDurationMs": 77.90799999999999,
"heapDeltaBytes": 3019276,
"heapUsedBytes": 71969276,
"domNodes": 131,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.805999999999998,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 117.16200000000754,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.577000000000002,
"layouts": 2,
"layoutDurationMs": 1.142,
"taskDurationMs": 73.549,
"heapDeltaBytes": 2992740,
"heapUsedBytes": 70891528,
"domNodes": 128,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.512,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #18531 +/- ##
=============================================
- Coverage 83.58% 83.58% -0.01%
=============================================
Files 2096 2096
Lines 123796 123796
Branches 31538 31538
=============================================
- Hits 103481 103477 -4
- Misses 20136 20140 +4
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…ore/1.54 The wholesale main-version swap in the previous commit assumed a WorkSummary.vue / ActivityTrace.vue split (distinct "Working..." vs "Worked for ..." UI states, driven by the `agent.working`/`agent.worked` i18n keys) that does not exist on core/1.54: this branch's tool-call UI is still ToolCallGroup.vue, which renders a single "Ran N tool call(s)" label throughout a turn (see src/workbench/extensions/agent/components/ agent/message/ToolCallGroup.vue). The `agent.working` i18n string exists in the locale file but nothing on this branch reads it, so the fixture's `workingRow` locator never resolves and every test using AgentTurnLockHarness.startTurn() timed out in CI (playwright-tests (cloud), 5/5 specs in agentTurnSurvivesSocketDrop.spec.ts failing identically on every retry). Reverting these two files to the pre-existing core/1.54 content (the `activityRow` locator matching the real "Ran 1 tool call" button) restores parity with the actual UI. That content already carries equivalent coverage for PM-1199 from the earlier #18186 sweep, so no further backport of these files is needed until the WorkSummary/ ActivityTrace refactor itself lands on this branch. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WgCgZKjk1bLPcyYppEr9DZ
|
Closing: no release change remains.
Full context for agent readersThe current branch correctly reverts the incompatible Hosted failure evidence: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35817582292/job/107044916130 Since #18113 is test-only, closing this now-empty duplicate omits no product fix and avoids adding a net-zero commit pair to the release branch. |
Manual backport of #18113 to
core/1.54. The automated backport failed with conflicts in:browser_tests/fixtures/agentTurnLockFixture.tsbrowser_tests/tests/agent/agentTurnSurvivesSocketDrop.spec.tssrc/workbench/extensions/agent/composables/agent/useAgentSession.test.tsWhy this conflicted (not a stacking conflict)
The bot's failure comment suggested this might be a stacking conflict against other open PRs targeting
core/1.54(#18471, #18417, #18410, #18407, #18369, #18334, #17872). I checked: none of those PRs touch any of the three conflicting files, so that wasn't it.The actual cause: #18113's content was already carried onto
core/1.54once before, as one of seventeen sources bundled into #18186 ("Agent catalogue sweep 2"), merged 2026-09-20. That sweep appears to have grabbed an intermediate/pre-final revision of #18113's branch rather than its final squashed state, socore/1.54already had a draft version of the same test suite (using anactivityRowlocator) that predates the PR's actual final polish (which renamed things toworkSummary/workingRowand added stronger assertions).Conflict resolution
browser_tests/fixtures/agentTurnLockFixture.tsandbrowser_tests/tests/agent/agentTurnSurvivesSocketDrop.spec.ts: took the incoming (final test(agent): pin the turn a transient socket reconnect abandons (PM-1199) #18113 / currentmain) version wholesale — it's a strict improvement over the draft already on the branch (clearer locators anchored on theagent.worked/agent.workingi18n keys, which already exist oncore/1.54; more thorough assertions in the "keeps the turn marked as running" case). Confirmed nothing else oncore/1.54references the oldactivityRowsymbol.src/workbench/extensions/agent/composables/agent/useAgentSession.test.ts: kept the branch's existing content as-is. The PM-1199-specific tests ((g3)/(g4)) are byte-identical between the two sides already. The apparent diff was entirely: (a) stylistic drift from later main-only refactorscore/1.54hasn't absorbed (setActivePiniapattern,vi.mock(import(...))syntax) that are out of scope here, and (b) the PM-1429/PM-1430 "unbound tab" tests that only exist oncore/1.54(backported later via [backport core/1.54] fix: flag a freshly created, unsaved tab as unbound for the agent (PM-1430) #18381) and aren't in test(agent): pin the turn a transient socket reconnect abandons (PM-1199) #18113's original diff — dropping them would have been a regression.Verification
pnpm exec vitest run src/workbench/extensions/agent/composables/agent/useAgentSession.test.ts— 76 passed, 2 expected fail (the(g3)/(g4)it.failspins), matching the original PR's reported behavior.pnpm exec oxfmt --checkandpnpm exec oxlinton the three touched files — clean.pnpm run typecheck(vue-tsc, both tsconfigs) — clean.agentTurnSurvivesSocketDrop.spec.ts) needs the full e2e harness/dev server, which wasn't available in this sandbox; verified by inspection and lint/format only.Requested by Christian Byrne in Slack
🤖 Generated with Claude Code
https://claude.ai/code/session_01WgCgZKjk1bLPcyYppEr9DZ
Generated by Claude Code