Repository navigation
fix: guard reportError against re-entrant reports from Sentry normalization - #18041
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2070 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.96 MB gzip 🔴 +147 BDetailsSummary
Category Glance App Entry Points — 3.85 kB (baseline 3.85 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.46 MB (baseline 1.46 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 638 kB (baseline 638 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 123 kB (baseline 123 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.87 MB (baseline 3.87 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 575 kB (baseline 575 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 19 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.8 MB (baseline 17.8 MB) • 🔴 +404 BBundles that do not match a named category
Status: 75 added / 75 removed / 226 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-21T12:28:38.999Z",
"gitSha": "8cb5c2f6e9e38dc4e642415e1cd65c685a7f2b3d",
"branch": "fix/report-error-reentrancy",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.2480000000137,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.896999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.374,
"heapDeltaBytes": 12740436,
"heapUsedBytes": 74870924,
"domNodes": -262,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.082999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1992.4190000000408,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.554999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.59599999999995,
"heapDeltaBytes": -4653396,
"heapUsedBytes": 57319452,
"domNodes": -262,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 7.451000000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1775.622999999996,
"styleRecalcs": 74,
"styleRecalcDurationMs": 25.424,
"layouts": 14,
"layoutDurationMs": 3.8800000000000003,
"taskDurationMs": 777.274,
"heapDeltaBytes": 8182572,
"heapUsedBytes": 70233824,
"domNodes": -262,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 154.005,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1739.445000000046,
"styleRecalcs": 72,
"styleRecalcDurationMs": 22.067999999999998,
"layouts": 14,
"layoutDurationMs": 3.9730000000000008,
"taskDurationMs": 761.2520000000001,
"heapDeltaBytes": 2520016,
"heapUsedBytes": 63461444,
"domNodes": -261,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 150.68400000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.4539999999843,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.348,
"layouts": 6,
"layoutDurationMs": 1.09,
"taskDurationMs": 302.339,
"heapDeltaBytes": 2367244,
"heapUsedBytes": 64679128,
"domNodes": 76,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 9.467,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.1609999999282,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.665000000000001,
"layouts": 6,
"layoutDurationMs": 1.031,
"taskDurationMs": 300.95300000000003,
"heapDeltaBytes": 2151468,
"heapUsedBytes": 64282540,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.581,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 577.2519999999872,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.756999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.06800000000004,
"heapDeltaBytes": 18141892,
"heapUsedBytes": 80315236,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 158.968,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 575.4749999999831,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.481999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.97299999999996,
"heapDeltaBytes": 18156540,
"heapUsedBytes": 80361300,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 157.548,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1213.639999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 882.458,
"heapDeltaBytes": -12645852,
"heapUsedBytes": 73564156,
"domNodes": -299,
"jsHeapTotalBytes": 20578304,
"scriptDurationMs": 67.94999999999999,
"eventListeners": -217,
"totalBlockingTimeMs": 548,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1149.7349999999642,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 838.0600000000002,
"heapDeltaBytes": -13693356,
"heapUsedBytes": 72242112,
"domNodes": -294,
"jsHeapTotalBytes": 18219008,
"scriptDurationMs": 66.11299999999999,
"eventListeners": -217,
"totalBlockingTimeMs": 509,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 815.511000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.82899999999967,
"heapDeltaBytes": 14416876,
"heapUsedBytes": 89655884,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 151.05799999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 204,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 814.6160000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.3159999999996,
"heapDeltaBytes": 14464228,
"heapUsedBytes": 89852532,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 151.18599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 207,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9226.54399999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8252.093,
"heapDeltaBytes": 1045192,
"heapUsedBytes": 82814400,
"domNodes": -16,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7058.555,
"eventListeners": 0,
"totalBlockingTimeMs": 840,
"frameDurationMs": 18.329999999999988,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8885.716000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8099.444,
"heapDeltaBytes": 5200828,
"heapUsedBytes": 81977664,
"domNodes": -274,
"jsHeapTotalBytes": 1826816,
"scriptDurationMs": 6610.195,
"eventListeners": -174,
"totalBlockingTimeMs": 391,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9518.394999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8719.091,
"heapDeltaBytes": 2686724,
"heapUsedBytes": 84652092,
"domNodes": -12,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 7184.908,
"eventListeners": 0,
"totalBlockingTimeMs": 669,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9915.316999999959,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9131.582999999999,
"heapDeltaBytes": 336328,
"heapUsedBytes": 82472728,
"domNodes": -14,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 7640.2970000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 862,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2033.4059999999567,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.261000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.1560000000001,
"heapDeltaBytes": 2196400,
"heapUsedBytes": 83444100,
"domNodes": -246,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 25.53399999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2041.6989999999942,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.621000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.048,
"heapDeltaBytes": 2833720,
"heapUsedBytes": 83686496,
"domNodes": -248,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 29.364999999999995,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2250.6369999999833,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.173,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1542.3300000000002,
"heapDeltaBytes": -3507140,
"heapUsedBytes": 83688704,
"domNodes": -253,
"jsHeapTotalBytes": 1564672,
"scriptDurationMs": 816.203,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2234.792000000084,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.945999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1561.2120000000002,
"heapDeltaBytes": 16277916,
"heapUsedBytes": 80166776,
"domNodes": -245,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 837.839,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3404.5900000000415,
"styleRecalcs": 64,
"styleRecalcDurationMs": 16.522000000000002,
"layouts": 60,
"layoutDurationMs": 11.754000000000001,
"taskDurationMs": 1637.8819999999998,
"heapDeltaBytes": -12088900,
"heapUsedBytes": 69621144,
"domNodes": -226,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 753.4680000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3356.5659999999298,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.098000000000003,
"layouts": 60,
"layoutDurationMs": 11.875,
"taskDurationMs": 1572.2910000000002,
"heapDeltaBytes": 9126344,
"heapUsedBytes": 74093300,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 746.929,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2719.927000000041,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.778000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1751.0049999999997,
"heapDeltaBytes": -7529372,
"heapUsedBytes": 83016288,
"domNodes": -256,
"jsHeapTotalBytes": 184320,
"scriptDurationMs": 893.898,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2670.513000000028,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.632,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1716.7939999999999,
"heapDeltaBytes": -6264724,
"heapUsedBytes": 77204124,
"domNodes": -228,
"jsHeapTotalBytes": 2314240,
"scriptDurationMs": 961.3910000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2003.2850000000053,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.5029999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.221,
"heapDeltaBytes": 20107048,
"heapUsedBytes": 84417444,
"domNodes": -254,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 26.227,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2031.6080000000056,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.660000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 569.1210000000001,
"heapDeltaBytes": -6468956,
"heapUsedBytes": 81733572,
"domNodes": -252,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 29.904,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 563.2190000000037,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.616,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.62100000000004,
"heapDeltaBytes": 14284648,
"heapUsedBytes": 77620984,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 138.816,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 551.8749999999955,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.543000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 371.33000000000004,
"heapDeltaBytes": 13222880,
"heapUsedBytes": 76783908,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 133.84300000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.8930000000005,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.037999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.768,
"heapDeltaBytes": 367956,
"heapUsedBytes": 63910036,
"domNodes": -277,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.363,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2000.7190000000037,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.180000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.492,
"heapDeltaBytes": 283396,
"heapUsedBytes": 63778684,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.475999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.1699999999719,
"styleRecalcs": 77,
"styleRecalcDurationMs": 23.784000000000002,
"layouts": 18,
"layoutDurationMs": 4.271999999999999,
"taskDurationMs": 707.094,
"heapDeltaBytes": 1286104,
"heapUsedBytes": 64820788,
"domNodes": -277,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 100.278,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.609999999955,
"styleRecalcs": 78,
"styleRecalcDurationMs": 23.75,
"layouts": 18,
"layoutDurationMs": 4.351,
"taskDurationMs": 708.207,
"heapDeltaBytes": 15189584,
"heapUsedBytes": 78752904,
"domNodes": -274,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 97.653,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1150.9990000000698,
"styleRecalcs": 16,
"styleRecalcDurationMs": 26.673000000000002,
"layouts": 5,
"layoutDurationMs": 11.832,
"taskDurationMs": 810.527,
"heapDeltaBytes": 20086560,
"heapUsedBytes": 102505376,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 27.180999999999997,
"eventListeners": 2383,
"totalBlockingTimeMs": 130,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8197.991000000002,
"styleRecalcs": 248,
"styleRecalcDurationMs": 32.973,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5371.943,
"heapDeltaBytes": -5018980,
"heapUsedBytes": 76258328,
"domNodes": -248,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 2653.1169999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8297.403000000031,
"styleRecalcs": 248,
"styleRecalcDurationMs": 32.965,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5346.177,
"heapDeltaBytes": -5448764,
"heapUsedBytes": 75965412,
"domNodes": -248,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 2645.6150000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15005.538999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14539.887999999997,
"heapDeltaBytes": -36382648,
"heapUsedBytes": 184138568,
"domNodes": -8061,
"jsHeapTotalBytes": -12517376,
"scriptDurationMs": 204.226,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 16006.285000000047,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15042.568,
"heapDeltaBytes": -32890192,
"heapUsedBytes": 184007316,
"domNodes": -8061,
"jsHeapTotalBytes": -10526720,
"scriptDurationMs": 227.31699999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18977.439000000006,
"styleRecalcs": 173,
"styleRecalcDurationMs": 15.898000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18567.927,
"heapDeltaBytes": -40700576,
"heapUsedBytes": 168811184,
"domNodes": -8061,
"jsHeapTotalBytes": -9433088,
"scriptDurationMs": 852.637,
"eventListeners": -14928,
"totalBlockingTimeMs": 30,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20546.065,
"styleRecalcs": 168,
"styleRecalcDurationMs": 17.555999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20134.995,
"heapDeltaBytes": -28636460,
"heapUsedBytes": 191709296,
"domNodes": -8061,
"jsHeapTotalBytes": -13373440,
"scriptDurationMs": 936.1800000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 42,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5542.732999999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.12599999999996,
"layouts": 20,
"layoutDurationMs": 20.946999999999992,
"taskDurationMs": 5419.8949999999995,
"heapDeltaBytes": -34592724,
"heapUsedBytes": 183431528,
"domNodes": -8061,
"jsHeapTotalBytes": 19329024,
"scriptDurationMs": 92.48,
"eventListeners": -14928,
"totalBlockingTimeMs": 289,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5918.007999999986,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.93299999999998,
"layouts": 20,
"layoutDurationMs": 23.462999999999997,
"taskDurationMs": 5820.329,
"heapDeltaBytes": -42299112,
"heapUsedBytes": 181922044,
"domNodes": -8061,
"jsHeapTotalBytes": 12644352,
"scriptDurationMs": 109.521,
"eventListeners": -14928,
"totalBlockingTimeMs": 440,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7475.460999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7201.041000000002,
"heapDeltaBytes": 5046228,
"heapUsedBytes": 181949384,
"domNodes": 0,
"jsHeapTotalBytes": -11272192,
"scriptDurationMs": 103.40700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8181.252000000086,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7878.311999999999,
"heapDeltaBytes": -2460040,
"heapUsedBytes": 188505308,
"domNodes": 0,
"jsHeapTotalBytes": -22020096,
"scriptDurationMs": 151.54600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 471.8160000001035,
"styleRecalcs": 18,
"styleRecalcDurationMs": 25.905000000000005,
"layouts": 5,
"layoutDurationMs": 2.2259999999999995,
"taskDurationMs": 128.035,
"heapDeltaBytes": 5300292,
"heapUsedBytes": 67044600,
"domNodes": 149,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 15.532999999999998,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 112.09600000006503,
"styleRecalcs": 9,
"styleRecalcDurationMs": 16.913999999999998,
"layouts": 3,
"layoutDurationMs": 1.5040000000000002,
"taskDurationMs": 79.86500000000002,
"heapDeltaBytes": 3038972,
"heapUsedBytes": 64830424,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.158999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 82fdd3f29820070cf337ea5d8e4a53619c08d18d
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18041 +/- ##
==========================================
+ Coverage 83.00% 84.21% +1.20%
==========================================
Files 2956 2263 -693
Lines 145790 129057 -16733
Branches 37585 33447 -4138
==========================================
- Hits 121015 108680 -12335
+ Misses 23505 20081 -3424
+ Partials 1270 296 -974
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 742 files with indirect coverage changes 🚀 New features to boost your workflow:
|
a30963a to
dd66f44
Compare
…trancy # Conflicts: # src/platform/telemetry/reportError.ts
|
Refreshed with a real-Sentry regression; local checks pass. Dante: please review the current head, especially nested-report suppression and guard reset. Hosted checks and independent approval remain pending. Full context for agent readersCarried this branch under Christian's completion authorization, preserving its existing fix and adding one integration test. No force push. The diff against the incorporated main contains only the reporter and two test files. The new test uses the real Sentry client with an in-memory transport, so no telemetry leaves the test. A payload's Verification: telemetry suite 471 tests across 36 files; full lint, typecheck and knip passed. Commit and push hooks ran without bypass. The inherited main update emitted two unused translation-key warnings, not errors. No original production workflow/browser acceptance was performed in this pass. This fixes amplification during error reporting, not the underlying graph-serialization mismatch. Both Glossary: Sentry normalization converts report context into serializable data; an in-memory transport captures events without sending them to a service. Knip checks for unused code. |
dante01yoon
left a comment
There was a problem hiding this comment.
Thanks for this — I dug into the premise rather than taking the description at face value, and it holds up completely. Approving.
Premise verification (this is a fix:, so it was the main question)
I did not just read the narrative; I reproduced the chain from source and then confirmed it against production telemetry.
From source, on main:
LGraph.toJSON()->this.serialize()(src/lib/litegraph/src/LGraph.ts:2883)serialize()->asSerialisable()->serialiseStoredNodes()(LGraph.ts:2907;Subgraphhas its own atLGraph.ts:3684)serialiseStoredNodes()callsreportError('Graph serialization state mismatch', ...)on a stored/live mismatch (LGraph.ts:436)
From production RUM (@error.type:graph_serialization_state_mismatch, last 25d): ~10.1k events, and the per-session distribution is exactly the amplification you describe — a single session with 4554 events, another with 2466, another with 1504. A captured handling_stack shows the loop verbatim:
reportError -> dispatch -> captureException -> BrowserClient._process
-> SyncPromise.then -> prepareEvent -> normalizeEvent -> normalize
-> visit -> visit -> visit -> Subgraph.toJSON -> Subgraph.serialize
-> Subgraph.asSerialisable -> serialiseStoredNodes -> reportError -> dispatch
That trace also settles the thing I most wanted to check before believing a module-scoped boolean could work at all: Sentry runs this on SyncPromise, so normalizeEvent/visit/toJSON execute synchronously inside captureException, still inside dispatch()'s try. If normalization were a real microtask the flag would already be back to false by the time toJSON ran and the guard would be a no-op. It isn't. The guard is correctly placed.
Guard correctness
- Reset on both paths:
finally { dispatching = false }wraps both sinks, and each sink already has its own innertry/catch, so neither a throwing sink nor a returning one can strand the flag. - Can it swallow a legitimate unrelated report? I don't think so in practice. The window is strictly synchronous and single-threaded, so nothing can interleave into it — anything raised inside it is, by construction, raised by serialization of the payload currently being delivered. Sequential reports are unaffected, and your test asserts that explicitly.
- No
beforeSendhook callsreportError, so that re-entry route can't be caught by the guard either (checkedrumBeforeSend/initDatadogRum.ts). - The RUM console-echo claim checks out.
isConsoleEchoOfReportedError(datadogRumBeforeSend.ts:66) matches onREPORTED_ERROR_PREFIX, and the suppressed line still begins with that prefix, so the nested lines are dropped byrumBeforeSendand genuinely don't re-burn RUM budget. Worth stating since the whole point is volume reduction. - Desktop sink:
dispatchToDesktopsits outside the guarded block, but it only forwards{message, stack}plus primitive tags — it never serializescontext— so it can't re-enter. Fine as is.
Answering your Review Focus question
console-only fallback vs. queueing the nested report for delivery after the outer dispatch
Console-only is the right call, and I'd keep it. Queueing would re-deliver a report about the object currently being normalized, which re-enters normalization on drain — you'd have rebuilt the loop with a delay. It would also mean the pending buffer (cap 25) gets filled by suppressed duplicates and starts evicting real pre-sink reports.
Tests
Both new tests are discriminating — I checked they fail for the reason they claim, not incidentally:
reportError.test.ts: without the guard the nested call reachescaptureExceptiona second time, sotoHaveBeenCalledOnce()fails. It also asserts the nested error still hits the console and that the next independent report is delivered, which is what pins the reset.reportError.sentry.test.tsis the strong one: realinit(), realnormalizeDepth: 8, real normalizer driving the re-entry throughtoJSON. Without the guardbeforeSendsees a third event and thetoEqual([...])fails. This is the test that actually proves the mechanism rather than the mock's shape — nice.
CI is green at 06653e4 (86 passing, 0 failing), and the vitest test job did run, so the Sentry-backed test is genuinely exercised.
No scope creep — the +51/-35 is almost entirely re-indentation from wrapping the existing sink calls.
Two non-blocking notes inline.
|
|
…s from Sentry normalization (#18528) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C09KFK2ABB8/p1788424987450979)_ Backport of #18041 to `core/1.54`. **Before:** on `core/1.54`, a report raised while `reportError` is already dispatching (for example Sentry's normalizer calling `Subgraph.toJSON()`) re-enters the reporter and fans out into an error storm. **After:** the nested report is logged to the console only and the original report completes; one mismatch produces one event. Manual backport: the automated cherry-pick conflicted in `src/platform/telemetry/reportError.ts` because this branch's reporter predates the current one; the guard was ported onto the branch's existing dispatch path. Only surrounding context differed: `core/1.54` lacks main's `RESERVED_TAG_KEYS` constant and the expanded `reportError` doc comment, so the `dispatching` flag, `logReport` helper and the new tests applied unchanged around the branch's Sentry/Datadog dispatch. --- _Generated by [Claude Code](https://claude.ai/code/session_01TsajsCwfDusee9F9rPWNb7)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
…ts from Sentry normalization (#18530) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C09KFK2ABB8/p1788424987450979)_ Backport of #18041 to `cloud/1.54`. **Before:** on `cloud/1.54`, a report raised while `reportError` is already dispatching (for example Sentry's normalizer calling `Subgraph.toJSON()`) re-enters the reporter and fans out into an error storm. **After:** the nested report is logged to the console only and the original report completes; one mismatch produces one event. Manual backport: the automated cherry-pick conflicted in `src/platform/telemetry/reportError.ts` because this branch's reporter predates the current one; the guard was ported onto the branch's existing dispatch path. Only surrounding context differed: `cloud/1.54` lacks main's `RESERVED_TAG_KEYS` constant and the expanded `reportError` doc comment, so the `dispatching` flag, `logReport` helper and the new tests applied unchanged around the branch's Sentry/Datadog dispatch. --- _Generated by [Claude Code](https://claude.ai/code/session_01TsajsCwfDusee9F9rPWNb7)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
|
|
Requested via Slack thread
ELI5
Our error reporter is like a smoke alarm that, while ringing, could accidentally set off another smoke alarm, which set off another, and so on. This PR makes the alarm ignore any new smoke it detects while it is already ringing, so one faulty graph produces one report instead of thousands.
Motivation
In production, a single subgraph with a stored-node/live-node mismatch produced thousands of
graph_serialization_state_mismatchevents per session. In a Datadog RUM sample of the error, 272 of 300 events carried Sentryvisit(normalizer) frames in their stack, which is how the loop was identified. Each one of those events also hit Datadog RUM, so a single bad workflow could burn through error budget and drown out real signals on both sinks. The reporter is the shared choke point for every observability sink, so it has to be the one place that refuses to re-enter itself.Summary
reportError()now tracks whether it is currently delivering to a sink (dispatching). A report raised while delivery is in flight skips both Sentry and Datadog and only writes to the console, marked(suppressed: raised while reporting), so the nested failure is still visible in devtools but cannot fan out.try/finallyaround both sink calls, so a throwing sink cannot leave the guard stuck and the very next independent report is delivered normally.src/platform/telemetry/reportError.tsand its test change.Before / after
Before: reporting an error could recurse whenever a live graph reached Sentry's payload normalizer. The normalizer (
normalizeDepth: 8insrc/main.ts) walks the event payload and callstoJSON()on the objects it finds. A graph can get there two ways: through the report's owncontext, or through breadcrumb data, since console and DOM breadcrumbs capture references to their arguments andnormalizeEventmaps overevent.breadcrumbs[].data. In the observed production RUM traces it was the breadcrumb path: the outer report (agent_crdt_unrepresentable_subgraph_node_create) carried an all-stringcontext, and the captured stack wasnormalizeEvent -> Array.map -> normalize -> visit -> Subgraph.toJSON.LGraph.toJSON()(inherited bySubgraph) isreturn this.serialize(), andserialize()runsserialiseStoredNodes, which on a mismatch callsreportError('Graph serialization state mismatch', ...). That inner call went straight back intocaptureException, which normalized again, and so on:Because the graph rides in on the breadcrumb trail, any subsequent
captureException, from any call site with a completely cleancontext, can re-enter. Sanitizingcontextat individual call sites would never have fixed it, which is why the guard sits at the sharedreportErrorchoke point rather than at callers. Whoever picks up the underlyinggraph_serialization_state_mismatchinvestigation should look at breadcrumb retention rather than hunt for a call site that passes a graph incontext.After: the inner
reportErrorseesdispatching === true, writes one console line with the(suppressed: raised while reporting)marker, and returns. The outer report reaches Sentry and Datadog exactly once. After the outer dispatch finishes, the guard is cleared and later reports are delivered as before.Red / green
test:) adds the regression test alone. It fails onmainwithcaptureExceptioncalled twice.fix:) adds the guard. The same test passes with no changes to the test.The test mocks
captureExceptionto synchronously callreportErroragain (simulating the normalizer re-entering throughtoJSON), asserts each sink is hit exactly once, asserts the nested error still reaches the console, and then asserts a subsequent independent report is delivered (the guard resets).Provenance
pnpm vitest run src/platform/telemetry: 35 files, 461 passed, 0 failed (the new test fails onmainwith "expected to be called once, but got 2 times" and passes with the fix).pnpm typecheck: clean.pnpm lint: 0 errors (173 pre-existingimport-x/no-named-as-default-memberwarnings, untouched by this PR).pnpm format: no changes.pnpm knip: clean.Reviewer context
graph_serialization_state_mismatchinserialiseStoredNodesis being investigated separately; this PR only stops it from amplifying.contextcallers attach to reports.Review Focus
REPORTED_ERROR_PREFIX, sodatadogRumBeforeSendcontinues to drop the RUM console echo of it, as it does for every other reported error.Test plan
test:commit, green on thefix:commitgraph_serialization_state_mismatchand confirm Sentry and Datadog receive one event, with the suppressed nested report visible in the browser console🤖 Generated with Claude Code
https://claude.ai/code/session_01TsajsCwfDusee9F9rPWNb7
Generated by Claude Code