Repository navigation
fix: resolve real LGraphNode for insert_workflow node ids in locator/callback path - #18616
Conversation
…callback path Follow-up to #18604, which fixed the *execution-id* path (createNodeExecutionId/executionIdFromState) for comfy-multi-player's insert_workflow remapped node ids (insert:<opId>:root:node:<originalId>, PM-1580), but left the *locator-id* path unfixed: - createNodeLocatorId/locatorIdFromState rejected any colon in a root-level local id, so getHostNode (processedWidgetRenderModel.ts) resolved no live LGraphNode for these nodes. resolveLiveWidgetContext then returned no `live` context, so createWidgetUpdateHandler still updated the stored widget value but silently skipped widget.callback. - getNodeByLocatorId's parse side had the same rejection, so even a correctly-encoded leaf locator id could not be resolved back to a node. Added createLeafNodeLocatorId, mirroring createLeafNodeExecutionId: for a root-level id (no real subgraph nesting) it keeps a colon-bearing id whole instead of rejecting it, while a genuinely subgraph-nested id still goes through the strict, delimiter-aware path unchanged. Wired it into locatorIdFromState and widgetNodeLocatorId (the promoted-widget preview locator), and gave getNodeByLocatorId a matching leaf-tolerant fallback so the encode and decode sides agree. Test plan: - createLeafNodeLocatorId unit tests in nodeIdentification.test.ts (ordinary id, colon-bearing root id, still-strict subgraph-nested id, empty id) - locatorIdFromState regression tests in graphTraversalUtil.test.ts (root id, subgraph id, colon-bearing root id, no regression for a real subgraph-owned colon-bearing id) - Widget-callback regression test in useProcessedWidgets.test.ts asserting the live widget.callback actually fires (not just that the stored value updates) for a colon-bearing node id - Confirmed every new assertion fails on the pre-fix code and passes with the fix (git stash red/green check) - `pnpm vitest run` on all touched/related suites: nodeIdentification, graphTraversalUtil, all of vueNodes, all of workbench/extensions/agent/crdt (161 files, 2218 passed) - `vue-tsc --noEmit` clean - `eslint` and `oxfmt --check` clean on touched files
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2122 passed, 0 failed · 1 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 78a0e401ab8ed5e9659ec8fbac0fb2fb62d3d374
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.98 MB gzip 🔴 +286 kBDetailsSummary
Category Glance App Entry Points — 3.87 kB (baseline 3.73 kB) • 🔴 +138 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.44 MB (baseline 1.43 MB) • 🔴 +17.6 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 124 kB) • 🔴 +8.02 kBTop-level views, pages, and routed surfaces
Status: 17 added / 16 removed / 1 unchanged Panels & Settings — 639 kB (baseline 621 kB) • 🔴 +17.6 kBConfiguration panels, inspectors, and settings screens
Status: 28 added / 27 removed User & Accounts — 37.9 kB (baseline 27.8 kB) • 🔴 +10.1 kBAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 2 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🔴 +740 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 124 kB (baseline 117 kB) • 🔴 +6.54 kBReusable component library chunks
Status: 16 added / 15 removed Data & Services — 3.95 MB (baseline 3.6 MB) • 🔴 +349 kBStores, services, APIs, and repositories
Status: 16 added / 16 removed Utilities & Hooks — 577 kB (baseline 559 kB) • 🔴 +18.8 kBHelpers, composables, and utility bundles
Status: 31 added / 29 removed / 7 unchanged Vendor & Third-Party — 17.4 MB (baseline 18.1 MB) • 🟢 -692 kBExternal libraries and shared vendor chunks
Status: 12 added / 12 removed / 6 unchanged Other — 17.8 MB (baseline 16.4 MB) • 🔴 +1.43 MBBundles that do not match a named category
Status: 179 added / 173 removed / 123 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T17:01:31.431Z",
"gitSha": "d1de5fb93ab09960276e6261a1001122a1e34de5",
"branch": "claude/fix-node-locator-id-colon-rejection",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2033.028999999999,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.417,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.933,
"heapDeltaBytes": 10769756,
"heapUsedBytes": 77922148,
"domNodes": -262,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 14.075999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2006.5250000000106,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.767,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.642,
"heapDeltaBytes": -1089336,
"heapUsedBytes": 61471204,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 14.624000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1823.9660000000413,
"styleRecalcs": 46,
"styleRecalcDurationMs": 18.985000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 941.1919999999999,
"heapDeltaBytes": 10316112,
"heapUsedBytes": 77906156,
"domNodes": -259,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 179.286,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1768.8590000000204,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.803999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 915.8589999999999,
"heapDeltaBytes": -7317216,
"heapUsedBytes": 60140664,
"domNodes": -261,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 176.475,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.0079999999698,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.659999999999997,
"layouts": 6,
"layoutDurationMs": 1.09,
"taskDurationMs": 419.273,
"heapDeltaBytes": 3130164,
"heapUsedBytes": 70630564,
"domNodes": 76,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 17.522999999999996,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1678.7910000000466,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.186999999999998,
"layouts": 6,
"layoutDurationMs": 1.202,
"taskDurationMs": 407.142,
"heapDeltaBytes": 3108844,
"heapUsedBytes": 70483056,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 16.111,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 728.6250000000223,
"styleRecalcs": 13,
"styleRecalcDurationMs": 10.3,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.67,
"heapDeltaBytes": 18870660,
"heapUsedBytes": 86594872,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 185.91299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 719.1090000000031,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.921999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.13300000000004,
"heapDeltaBytes": 18980304,
"heapUsedBytes": 86509632,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 178.461,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1319.68999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1035.3220000000001,
"heapDeltaBytes": 12179516,
"heapUsedBytes": 83068932,
"domNodes": 0,
"jsHeapTotalBytes": 19034112,
"scriptDurationMs": 75.685,
"eventListeners": 0,
"totalBlockingTimeMs": 696,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1264.4520000000057,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 937.166,
"heapDeltaBytes": 38165544,
"heapUsedBytes": 103975084,
"domNodes": -263,
"jsHeapTotalBytes": 19820544,
"scriptDurationMs": 72.97999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 656,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 861.2140000000181,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.83899999999926,
"heapDeltaBytes": 14436772,
"heapUsedBytes": 90263476,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 174.84199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 236,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 870.0309999999263,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.1440000000003,
"heapDeltaBytes": 14963424,
"heapUsedBytes": 91813756,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 176.04999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 244,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11718.97899999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10627.327000000001,
"heapDeltaBytes": 4617144,
"heapUsedBytes": 86869280,
"domNodes": -18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 8920.323,
"eventListeners": 0,
"totalBlockingTimeMs": 1834,
"frameDurationMs": 20,
"p95FrameDurationMs": 49.89999999999782
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10866.129999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9854.221,
"heapDeltaBytes": -8954080,
"heapUsedBytes": 72916800,
"domNodes": -14,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 8283.729999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 1474,
"frameDurationMs": 18.883333333333333,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11587.298999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10633.397,
"heapDeltaBytes": -1022816,
"heapUsedBytes": 81056460,
"domNodes": -12,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 8718.767,
"eventListeners": 0,
"totalBlockingTimeMs": 1632,
"frameDurationMs": 18.889999999999905,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 12597.139999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11700.267,
"heapDeltaBytes": 4254092,
"heapUsedBytes": 86472552,
"domNodes": -14,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 9754.207,
"eventListeners": 0,
"totalBlockingTimeMs": 2533,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 49.89999999999782
},
{
"name": "large-graph-idle",
"durationMs": 2001.7479999999637,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.060000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 698.9110000000001,
"heapDeltaBytes": 20570224,
"heapUsedBytes": 84444604,
"domNodes": -245,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 39.05200000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2040.100999999936,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.954000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 734.8690000000001,
"heapDeltaBytes": -3315572,
"heapUsedBytes": 83400752,
"domNodes": -243,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 41.619,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2919.69499999999,
"styleRecalcs": 67,
"styleRecalcDurationMs": 16.035999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1916.1750000000002,
"heapDeltaBytes": 6243356,
"heapUsedBytes": 86744880,
"domNodes": -251,
"jsHeapTotalBytes": 2314240,
"scriptDurationMs": 950.694,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2941.1479999999983,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.527000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1869.9339999999997,
"heapDeltaBytes": 23767560,
"heapUsedBytes": 88181148,
"domNodes": 6,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 944.0459999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3950.968000000046,
"styleRecalcs": 61,
"styleRecalcDurationMs": 12.086000000000004,
"layouts": 60,
"layoutDurationMs": 14.567,
"taskDurationMs": 1909.775,
"heapDeltaBytes": 8512456,
"heapUsedBytes": 74401544,
"domNodes": -258,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 872.4080000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3944.2370000000437,
"styleRecalcs": 64,
"styleRecalcDurationMs": 16.034,
"layouts": 60,
"layoutDurationMs": 15.163,
"taskDurationMs": 1994.2330000000002,
"heapDeltaBytes": -15553308,
"heapUsedBytes": 73499916,
"domNodes": -258,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 898.988,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3166.181999999992,
"styleRecalcs": 42,
"styleRecalcDurationMs": 7.165000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2133.827,
"heapDeltaBytes": 478972,
"heapUsedBytes": 66635712,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 1072.349,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3191.780000000108,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.586999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2137.124,
"heapDeltaBytes": 30046596,
"heapUsedBytes": 96203588,
"domNodes": 2,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 1092.099,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2006.7119999999932,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.869999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 698.501,
"heapDeltaBytes": 20203456,
"heapUsedBytes": 84529168,
"domNodes": -245,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 40.45399999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2012.9610000000184,
"styleRecalcs": 6,
"styleRecalcDurationMs": 8.080000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.5239999999999,
"heapDeltaBytes": 20204784,
"heapUsedBytes": 84198984,
"domNodes": -246,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 38.97200000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.3400000000174,
"styleRecalcs": 48,
"styleRecalcDurationMs": 13.027000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.01800000000003,
"heapDeltaBytes": 13708904,
"heapUsedBytes": 83664152,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 159.92700000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 629.8100000000204,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.058,
"heapDeltaBytes": 14005640,
"heapUsedBytes": 83656160,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 154.71699999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.8309999999633,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.508,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.068,
"heapDeltaBytes": -3419416,
"heapUsedBytes": 66514664,
"domNodes": -274,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 12.599999999999996,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2023.388999999952,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.466,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 586.384,
"heapDeltaBytes": 9769924,
"heapUsedBytes": 79619796,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 12.956999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1722.325000000012,
"styleRecalcs": 46,
"styleRecalcDurationMs": 17.194000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 843.0009999999999,
"heapDeltaBytes": -5678920,
"heapUsedBytes": 64217448,
"domNodes": -276,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 123.42999999999998,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.693000000002,
"styleRecalcs": 44,
"styleRecalcDurationMs": 17.651000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 862.692,
"heapDeltaBytes": 8599604,
"heapUsedBytes": 78185136,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 125.87299999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1451.9299999999475,
"styleRecalcs": 16,
"styleRecalcDurationMs": 32.553,
"layouts": 5,
"layoutDurationMs": 13.894999999999998,
"taskDurationMs": 1086.4530000000002,
"heapDeltaBytes": 19352648,
"heapUsedBytes": 107000152,
"domNodes": 13667,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 38.271000000000015,
"eventListeners": 2383,
"totalBlockingTimeMs": 161,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9987.05799999999,
"styleRecalcs": 249,
"styleRecalcDurationMs": 40.812,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6651.116,
"heapDeltaBytes": -2487268,
"heapUsedBytes": 84260044,
"domNodes": -245,
"jsHeapTotalBytes": -40960,
"scriptDurationMs": 3089.155,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9206.216999999924,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.163000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6427.204,
"heapDeltaBytes": -1532880,
"heapUsedBytes": 84855472,
"domNodes": -240,
"jsHeapTotalBytes": 221184,
"scriptDurationMs": 3000.118,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18033.082999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17608.123,
"heapDeltaBytes": -43863556,
"heapUsedBytes": 181885428,
"domNodes": -8061,
"jsHeapTotalBytes": -16855040,
"scriptDurationMs": 300.18699999999995,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17624.86799999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17294.418,
"heapDeltaBytes": -41689252,
"heapUsedBytes": 179455364,
"domNodes": -8061,
"jsHeapTotalBytes": -15405056,
"scriptDurationMs": 298.668,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22446.38800000007,
"styleRecalcs": 163,
"styleRecalcDurationMs": 24.980999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22275.909,
"heapDeltaBytes": -54298688,
"heapUsedBytes": 180956284,
"domNodes": -8065,
"jsHeapTotalBytes": -14692352,
"scriptDurationMs": 1022.8269999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 101,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22561.37000000001,
"styleRecalcs": 164,
"styleRecalcDurationMs": 25.37400000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22463.616,
"heapDeltaBytes": -70966876,
"heapUsedBytes": 169127344,
"domNodes": -8061,
"jsHeapTotalBytes": -19816448,
"scriptDurationMs": 1066.5910000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 150,
"frameDurationMs": 17.77666666666652,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-node-resize-workload",
"durationMs": 6674.169000000006,
"styleRecalcs": 20,
"styleRecalcDurationMs": 88.046,
"layouts": 20,
"layoutDurationMs": 29.240000000000016,
"taskDurationMs": 6646.1179999999995,
"heapDeltaBytes": -41105704,
"heapUsedBytes": 177518664,
"domNodes": -8061,
"jsHeapTotalBytes": 8118272,
"scriptDurationMs": 137.685,
"eventListeners": -14924,
"totalBlockingTimeMs": 430,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6518.654999999967,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.268,
"layouts": 20,
"layoutDurationMs": 26.22200000000001,
"taskDurationMs": 6475.106999999999,
"heapDeltaBytes": -65647920,
"heapUsedBytes": 169871824,
"domNodes": -8061,
"jsHeapTotalBytes": 10997760,
"scriptDurationMs": 144.655,
"eventListeners": -14928,
"totalBlockingTimeMs": 483,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8983.036999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8901.368000000002,
"heapDeltaBytes": 10333596,
"heapUsedBytes": 184691328,
"domNodes": 0,
"jsHeapTotalBytes": -10485760,
"scriptDurationMs": 150.416,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9003.235000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8814.377999999999,
"heapDeltaBytes": -17332584,
"heapUsedBytes": 183113260,
"domNodes": 0,
"jsHeapTotalBytes": -26738688,
"scriptDurationMs": 176.69000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 454.54800000004525,
"styleRecalcs": 15,
"styleRecalcDurationMs": 29.786000000000005,
"layouts": 4,
"layoutDurationMs": 1.888,
"taskDurationMs": 144.864,
"heapDeltaBytes": 4964056,
"heapUsedBytes": 70621448,
"domNodes": 122,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.572999999999999,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 119.00399999990441,
"styleRecalcs": 8,
"styleRecalcDurationMs": 17.709000000000003,
"layouts": 3,
"layoutDurationMs": 1.33,
"taskDurationMs": 84.55499999999999,
"heapDeltaBytes": 3029704,
"heapUsedBytes": 68540212,
"domNodes": 128,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.32,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote The shard matrix did not pass, so these totals cannot be confirmed comparable with a whole merge.
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
CI failure triaged: Checked the job log directly. All 133 Playwright tests in this shard passed: The job is marked "failure" solely because the subsequent That's a transient network error in GitHub's artifact-upload service, unrelated to this PR's diff — nothing in The rest of the run ( Generated by Claude Code |
|
🔗 Commit SHA: 5d85b04 | Docs | View more details | Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18616 +/- ##
=========================================
Coverage 84.55% 84.56%
=========================================
Files 2326 2293 -33
Lines 131759 131094 -665
Branches 35536 33481 -2055
=========================================
- Hits 111415 110854 -561
+ Misses 19999 19939 -60
+ Partials 345 301 -44
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 42 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
inspected the complete six-file diff and all current-head review threads at 5d85b047491d44888e2eb32aca639b1fbaba054f. The new root-only locator seam preserves strict subgraph delimiter handling while allowing the insert_workflow remapped leaf IDs, and the unit plus callback-path regressions cover both acceptance and rejection branches. Hosted checks are terminal with no adverse result, and there are no unresolved review threads. Leaving a COMMENT disposition because the authenticated actor is not supplying the independent human gate; assigning DrJKL for that disposition.
…w node ids in locator/callback path (#18616) (#18618) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449)_ Backport of #18616 to `cloud/1.54`. Manual cherry-pick, same approach as #18608: `cloud/1.54` now has #18604's execution-id fix (via #18608), and #18616 is the follow-up that fixes the *sibling* locator-id path (`createNodeLocatorId`/`locatorIdFromState`/`getNodeByLocatorId`), used to resolve the live `LGraphNode` for widget callback dispatch and navigation, for the same colon-bearing `insert_workflow` node ids. ## Before Moving a widget on an `insert_workflow`-materialized node (comfy-multi-player, PM-1580) updates the widget's stored value, but the underlying node's `widget.callback` — which drives dependent UI, control-after-generate, dynamic input wiring, etc. — never fires, because `createNodeLocatorId` rejected the colon-bearing id and `getHostNode` resolved no live `LGraphNode`. The same path also silently broke "Enter Subgraph" navigation and promoted-widget preview locator ids for these nodes. ## After `createLeafNodeLocatorId` (mirroring `createLeafNodeExecutionId` from #18604) keeps a root-level colon-bearing id whole instead of rejecting it, while a genuinely subgraph-nested id still goes through the strict, delimiter-aware path unchanged. `locatorIdFromState`, `getNodeByLocatorId`, and the promoted-widget preview locator (`widgetNodeLocatorId`) now agree on this leaf-tolerant encoding/decoding, so `getHostNode` resolves the real `LGraphNode` and `live.widget.callback` fires normally. ## Cherry-pick details - Source commit: 5d85b04 (single self-contained commit from #18616, `claude/fix-node-locator-id-colon-rejection`) - `git cherry-pick -m 1` applied cleanly onto `cloud/1.54` (post-#18608) — no conflicts, since `nodeIdentification.ts`, `graphTraversalUtil.ts`, and `processedWidgetRenderModel.ts` already had #18604/#18608's sibling execution-id fix in place. - Committer identity normalized to `claude[bot]` (author was already `claude[bot]`; no AI co-author trailer was present in the original commit body, so none needed stripping). ## Testing - `pnpm vitest run` on `nodeIdentification.test.ts`, `graphTraversalUtil.test.ts`, and `useProcessedWidgets.test.ts` (which exercises `processedWidgetRenderModel.ts`'s `getHostNode`) against `cloud/1.54`'s actual code — 186 tests passed. - `vue-tsc --noEmit` — clean. - `eslint` and `oxfmt --check` on all 6 touched files — clean. Ref: #18616 (source PR, still open on `main` at cherry-pick time but CI-green and single-commit) 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY --- _Generated by [Claude Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
|
|
…low nodes Widgets on nodes inside a subgraph inserted via insert_workflow did not render in Vue mode once the subgraph was entered (litegraph rendering and execution were unaffected, since both read node.widgets directly). Root cause: comfy-multi-player's insert_workflow remaps every node id it inserts, including a subgraph DEFINITION's interior nodes, to a derived string carrying colons unrelated to subgraph scoping (e.g. insert:<opId>:root/definition:<defId>:node:<originalId>, remap.ts's derivedId). PR #18604/#18616 (PM-1580) already made createLeafNodeExecutionId/createLeafNodeLocatorId tolerate such a colon-bearing id for a ROOT-owned node, but both explicitly fell back to the strict, delimiter-aware path once the node was subgraph-owned, returning null. computeProcessedWidgets treats a null execution id as "nothing to render" and bails with an empty widget list. Fix: extend the leaf-tolerant handling to a subgraph-owned node too. - nodeIdentification.ts: createLeafNodeLocatorId now encodes a colon-bearing local id as `${subgraphUuid}:${nodeId}` instead of rejecting it; the new parseLeafNodeLocatorId decodes it back by splitting on the first colon only (mirroring stripGraphPrefix's existing technique for widget ids). - graphTraversalUtil.ts: getNodeByLocatorId uses the new leaf-tolerant parser; executionIdFromState's fallback and createExecutionIdFromPath's leaf segment are likewise leaf-tolerant regardless of subgraph ownership; getExecutionIdByNode's root branch uses createLeafNodeExecutionId for symmetry. Verified against real nightly CRDT captures of the "Text to Image (Z-Image-Turbo)" template (Jo Zhang) showing the exact insert:<opId>:root/definition:... id shape at the moment the bug reproduced. Adds insertWorkflowSubgraphInteriorWidgets.regression.test.ts: drives the real insert_workflow pipeline to materialize a subgraph-interior node and asserts computeProcessedWidgets renders it in Vue mode, covering combo, int, float, text and toggle widgets on a synthetic node plus the real CLIPTextEncode/EmptySD3LatentImage/KSampler widget shapes from the Z-Image-Turbo capture.
…w node ids in locator/callback path (#18616) (#18618) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449)_ Backport of #18616 to `cloud/1.54`. Manual cherry-pick, same approach as #18608: `cloud/1.54` now has #18604's execution-id fix (via #18608), and #18616 is the follow-up that fixes the *sibling* locator-id path (`createNodeLocatorId`/`locatorIdFromState`/`getNodeByLocatorId`), used to resolve the live `LGraphNode` for widget callback dispatch and navigation, for the same colon-bearing `insert_workflow` node ids. ## Before Moving a widget on an `insert_workflow`-materialized node (comfy-multi-player, PM-1580) updates the widget's stored value, but the underlying node's `widget.callback` — which drives dependent UI, control-after-generate, dynamic input wiring, etc. — never fires, because `createNodeLocatorId` rejected the colon-bearing id and `getHostNode` resolved no live `LGraphNode`. The same path also silently broke "Enter Subgraph" navigation and promoted-widget preview locator ids for these nodes. ## After `createLeafNodeLocatorId` (mirroring `createLeafNodeExecutionId` from #18604) keeps a root-level colon-bearing id whole instead of rejecting it, while a genuinely subgraph-nested id still goes through the strict, delimiter-aware path unchanged. `locatorIdFromState`, `getNodeByLocatorId`, and the promoted-widget preview locator (`widgetNodeLocatorId`) now agree on this leaf-tolerant encoding/decoding, so `getHostNode` resolves the real `LGraphNode` and `live.widget.callback` fires normally. ## Cherry-pick details - Source commit: 5d85b04 (single self-contained commit from #18616, `claude/fix-node-locator-id-colon-rejection`) - `git cherry-pick -m 1` applied cleanly onto `cloud/1.54` (post-#18608) — no conflicts, since `nodeIdentification.ts`, `graphTraversalUtil.ts`, and `processedWidgetRenderModel.ts` already had #18604/#18608's sibling execution-id fix in place. - Committer identity normalized to `claude[bot]` (author was already `claude[bot]`; no AI co-author trailer was present in the original commit body, so none needed stripping). ## Testing - `pnpm vitest run` on `nodeIdentification.test.ts`, `graphTraversalUtil.test.ts`, and `useProcessedWidgets.test.ts` (which exercises `processedWidgetRenderModel.ts`'s `getHostNode`) against `cloud/1.54`'s actual code — 186 tests passed. - `vue-tsc --noEmit` — clean. - `eslint` and `oxfmt --check` on all 6 touched files — clean. Ref: #18616 (source PR, still open on `main` at cherry-pick time but CI-green and single-commit) 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY --- _Generated by [Claude Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_ (cherry picked from commit 0ec045e)
## Summary Ports to `core/1.54` every merged `main` Agent fix that `cloud/1.54` carries and core does not (the Agent UI catch-up from #18622, the cloud-only CRDT and workflow fixes, and the round-2 fixes), so both release lines are symmetric ahead of the local-agent rollout. ## Changes - **What**: `cherry-pick -x`, in three groups: - Agent UI, as in #18622: #17339, #17908, #17420, #18348, #18043, #17621 (without its two `src/lib/litegraph/` files; a 5 px HUD offset in `SideToolbar.vue` compensates), #17471, #17690. - Cloud-only fixes: #18063, #18073, #18064, #18033, #18289, #18604, #18616, #18376. - Round 2: #17568, #17628, #16491, #18453, #17767, #18431 (from #18571), #18603. - **Already on `core/1.54`**: #17439 (#18161), #17912 (#18186), #18391 (#18595). - **Excluded**: #17730 (core lacks its three files), #18421 (dead code on core builds), #16917 (conflicts with later core changes), #18066 (Christian's request), #18375 and #18251 (need their litegraph hunks). ## Review Focus - On this line the Agent panel registers only in cloud builds (`src/extensions/core/index.ts:41-44`); the shared chrome from #17621 and #17471 and the host telemetry from #18376 and #18603 ship in every build. - `HostTelemetrySink.ts` and its test equal `main`'s files (#18376, then #18603 on top). - #18064: `agentConversationHostDoc.test.ts` keeps this line's file; #18063's new test uses `main`'s version (multi-player 0.3.x stamps). - Supersedes #18571 and the closed #18637. Linear: [PM-1657](https://linear.app/comfyorg/issue/PM-1657), [PM-1656](https://linear.app/comfyorg/issue/PM-1656) ## Screenshots (if applicable) Visual changes are the ones reviewed on `main` and carried to cloud in #18622. --------- Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: ryan-di <ryan.weihao.di@gmail.com> Co-authored-by: jaeone lee <89377375+jaeone94@users.noreply.github.com> Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Comfy Org PR Bot <snomiao+comfy-pr@gmail.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Hunter <huntcsg@users.noreply.github.com> Co-authored-by: Maanil Verma <vermaMaanil97@gmail.com>
|
|
|
|
|
|
## What Allow **Queue Selected Output Nodes** to execute an Agent-inserted root output whose raw node ID contains colons, such as `insert:<opId>:root:node:<originalId>`. `getExecutionIdsForSelectedNodes()` still used strict multi-segment execution-ID construction for the root leaf. That returns `null` for the colon-bearing IDs created by `insert_workflow`, so selecting the inserted `SaveImage` output produced “Could not resolve path to selected nodes” even though the full workflow validated and was ready to run. The root case now uses the existing `createLeafNodeExecutionId()` contract added for PM-1580. Nested paths remain on the strict delimiter-aware path. ## User evidence - Production Agent feedback surfaced 2026-10-07 from a `prod-v2` session on Agent release `v0.381.0`. - The affected workflow came from an Agent-inserted Krea template and had root IDs in the `insert:...:root:node:...` form. - Agent-side validation reported 22 converted nodes, zero errors/warnings, `ready_to_run: true`, and `spends_credits: false`; selected-output queueing failed before execution. - Related earlier locator/callback repair: Comfy-Org#18616 / PM-1580. This closes the analogous selected-output execution helper gap. ## Test plan - `pnpm vitest run src/utils/graphTraversalUtil.test.ts` — 115 passed - `pnpm exec oxfmt --check src/utils/graphTraversalUtil.ts src/utils/graphTraversalUtil.test.ts` - `pnpm exec oxlint --type-aware src/utils/graphTraversalUtil.ts src/utils/graphTraversalUtil.test.ts` - `pnpm exec eslint --no-cache src/utils/graphTraversalUtil.ts src/utils/graphTraversalUtil.test.ts` - `pnpm typecheck:app` - Commit and push hooks passed, including the changed-file fallow audit. No feature flag, exposure, workflow content, model choice, or credit behavior changes.
Requested by Christian Byrne · Slack thread
What
Follow-up to #18604, which fixed the execution-id path (
createNodeExecutionId/executionIdFromState) for comfy-multi-player'sinsert_workflowremapped node ids (insert:<opId>:root:node:<originalId>, PM-1580), but left the locator-id path —createNodeLocatorId/locatorIdFromState/getNodeByLocatorId, used to resolve the liveLGraphNodefor callback dispatch and navigation — rejecting the same colon-bearing ids.createNodeLocatorIdrejects any colon in a root-level local id, solocatorIdFromStatereturnednullfor these nodes.getHostNode(processedWidgetRenderModel.ts) callslocatorIdFromState, so it resolved no liveLGraphNodefor an inserted node.resolveLiveWidgetContextthen gothostNode = nulland returned{}(nolivecontext).createWidgetUpdateHandler,widgetValueStore.setValue(id, newValue)still ran (the stored value updated correctly), butlive.widget.callback?.(...)was skipped sincelivewas undefined. Net effect: widget callbacks silently never fired for agent-inserted nodes, even though the stored value looked correct.getNodeByLocatorId's parse side (parseNodeLocatorId) had the same colon rejection, so even a correctly leaf-encoded locator id couldn't be resolved back to a node.Before: moving a widget on an
insert_workflow-materialized node updates the widget's stored value, but the underlying node'swidget.callback(which drives dependent UI, control-after-generate, dynamic input wiring, etc.) never fires. The samelocatorIdFromState/createNodeLocatorIdpath also silently breaks "Enter Subgraph" navigation and promoted-widget preview locator ids for these nodes.After:
createLeafNodeLocatorId(mirroring the siblingcreateLeafNodeExecutionIdfrom #18604) keeps a root-level colon-bearing id whole instead of rejecting it, while a genuinely subgraph-nested id still goes through the strict, delimiter-aware path unchanged.locatorIdFromState,getNodeByLocatorId, and the promoted-widget preview locator (widgetNodeLocatorId) now agree on this leaf-tolerant encoding/decoding, sogetHostNoderesolves the realLGraphNodeandlive.widget.callbackfires normally.Scope confirmation
LGraphNode.vue'snodeLocatorId(drives "Enter Subgraph" and thelgraphNoderesolution used by promoted previews / GLSL preview) callslocatorIdFromStatedirectly, so it is covered by this fix with no separate test needed — same function, same code path.widgetNodeLocatorId()'s promoted-widget preview locator calledcreateNodeLocatorIddirectly (not throughlocatorIdFromState), so it would not have been fixed by patchinglocatorIdFromStatealone; it's explicitly switched tocreateLeafNodeLocatorIdin this PR. No dedicated test was added for this call site specifically (it has no colon-bearing-id test coverage before or after), since the underlying encode/decode logic is exercised directly innodeIdentification.test.ts/graphTraversalUtil.test.ts.Test plan
createLeafNodeLocatorIdunit tests innodeIdentification.test.ts— ordinary colon-free id, colon-bearing root id (PM-1580), still-strict rejection for a genuinely subgraph-nested colon-bearing id, empty id.locatorIdFromStateregression tests ingraphTraversalUtil.test.ts— root id, subgraph id, colon-bearing root id, and a no-regression case for a real subgraph-owned colon-bearing id.useProcessedWidgets.test.tsasserting the livewidget.callbackactually fires (not just that the stored value updates) for a colon-bearing node id.git stash/git stash popred→green check).pnpm vitest runon all touched/related suites:nodeIdentification,graphTraversalUtil, all ofvueNodes, all ofworkbench/extensions/agent/crdt— 161 files, 2218 passed.vue-tsc --noEmitclean.eslintandoxfmt --checkclean on touched files; pre-commit hooks (oxfmt/oxlint/eslint/typecheck) passed.🤖 Generated with Claude Code
https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY
Generated by Claude Code