Skip to content

[backport cloud/1.54] test: cover mouse-driven autogrow reference alignment - #18370

Merged
comfy-pr-bot merged 1 commit into
cloud/1.54from
backport-18101-to-cloud-1.54
Sep 24, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.54from
backport-18101-to-cloud-1.54

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #18101 to cloud/1.54

Automatically created by backport workflow.

@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Sep 22, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) September 22, 2026 05:11
@vercel

vercel Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
billing-web-test Error Error Sep 24, 2026 1:10am UTC
1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 24, 2026 1:10am UTC

Request Review

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1946 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1925 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • New-test walkthrough (chromium, recorded video): View Report

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.1 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.7 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.7 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.1 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.6 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.7 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 69ms TBT · 79.8 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.9 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 167.0 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 17ms TBT · 178.0 MB heap
vue-node-resize-workload: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 40ms TBT · 177.2 MB heap
vue-zoom-out-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 173.3 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.3 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 375ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 61.8 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -195
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 25ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 73
canvas-mouse-sweep: task duration 712ms
canvas-mouse-sweep: script duration 117ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 70.2 MB
canvas-mouse-sweep: DOM nodes -282
canvas-mouse-sweep: event listeners -177
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 14ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 261ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.1 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 11ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 352ms
dom-widget-clipping: script duration 117ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 60.2 MB
dom-widget-clipping: DOM nodes 21
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 451ms
large-graph-idle: script duration 29ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.1 MB
large-graph-idle: DOM nodes -268
large-graph-idle: event listeners -161
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1174ms
large-graph-pan: script duration 562ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 82.7 MB
large-graph-pan: DOM nodes -269
large-graph-pan: event listeners -160
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 63
large-graph-zoom: task duration 1194ms
large-graph-zoom: script duration 513ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 80.7 MB
large-graph-zoom: DOM nodes -283
large-graph-zoom: event listeners -177
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 42
legacy-node-drag: task duration 1577ms
legacy-node-drag: script duration 763ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 84.1 MB
legacy-node-drag: DOM nodes 4
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 7
minimap-idle: task duration 382ms
minimap-idle: script duration 26ms
minimap-idle: TBT 0ms
minimap-idle: heap used 81.3 MB
minimap-idle: DOM nodes -273
minimap-idle: event listeners -192
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 287ms
subgraph-dom-widget-clipping: script duration 95ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.1 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 410ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 62.6 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -242
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 25ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 656ms
subgraph-mouse-sweep: script duration 92ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 65.7 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -208
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 10ms
subgraph-transition-enter: style recalc duration 21ms
subgraph-transition-enter: layout count 17
subgraph-transition-enter: style recalc count 21
subgraph-transition-enter: task duration 585ms
subgraph-transition-enter: script duration 20ms
subgraph-transition-enter: TBT 69ms
subgraph-transition-enter: heap used 79.8 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 43ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 4307ms
viewport-pan-sweep: script duration 1921ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 76.9 MB
viewport-pan-sweep: DOM nodes -270
viewport-pan-sweep: event listeners -158
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 11709ms
vue-large-graph-idle: script duration 179ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 167.0 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14934
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 15ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 74
vue-large-graph-pan: task duration 14498ms
vue-large-graph-pan: script duration 652ms
vue-large-graph-pan: TBT 17ms
vue-large-graph-pan: heap used 178.0 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14931
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 52ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4259ms
vue-node-resize-workload: script duration 69ms
vue-node-resize-workload: TBT 40ms
vue-node-resize-workload: heap used 177.2 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14931
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 6025ms
vue-zoom-out-idle: script duration 89ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 173.3 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -8
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 13ms
workflow-execution: layout count 2
workflow-execution: style recalc count 11
workflow-execution: task duration 61ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.3 MB
workflow-execution: DOM nodes 114
workflow-execution: event listeners 50
Raw data
{
  "timestamp": "2026-09-24T01:22:06.002Z",
  "gitSha": "a9645b3f2e560ffacefdaf5712660dc74369fcd9",
  "branch": "backport-18101-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2020.2219999999897,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.279,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 304.35400000000004,
      "heapDeltaBytes": -10058920,
      "heapUsedBytes": 60398484,
      "domNodes": -278,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 9.383999999999999,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2006.4260000000331,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.6240000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 446.01099999999997,
      "heapDeltaBytes": -655548,
      "heapUsedBytes": 69242168,
      "domNodes": -281,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 11.536999999999999,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1736.64100000002,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 25.245000000000005,
      "layouts": 14,
      "layoutDurationMs": 3.9960000000000004,
      "taskDurationMs": 727.3149999999999,
      "heapDeltaBytes": 13351540,
      "heapUsedBytes": 83545860,
      "domNodes": -281,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 119.149,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1743.0880000000002,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 25.562,
      "layouts": 14,
      "layoutDurationMs": 4.0920000000000005,
      "taskDurationMs": 695.7860000000001,
      "heapDeltaBytes": -6926876,
      "heapUsedBytes": 63609368,
      "domNodes": -282,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 114.502,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1658.2970000000046,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 12.187,
      "layouts": 6,
      "layoutDurationMs": 1.0479999999999998,
      "taskDurationMs": 215.39399999999998,
      "heapDeltaBytes": 4182680,
      "heapUsedBytes": 74729012,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 8.020000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1655.7909999999652,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 14.87,
      "layouts": 6,
      "layoutDurationMs": 1.1049999999999998,
      "taskDurationMs": 306.224,
      "heapDeltaBytes": 4241844,
      "heapUsedBytes": 74430944,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 13.601,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 567.4319999999966,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 11.897,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 371.07500000000005,
      "heapDeltaBytes": -8191792,
      "heapUsedBytes": 63252444,
      "domNodes": 20,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 125.393,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 530.4869999999937,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 9.443,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 333.515,
      "heapDeltaBytes": -7857272,
      "heapUsedBytes": 63029840,
      "domNodes": 22,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 108.747,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2035.5189999999652,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 4.683000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 534.558,
      "heapDeltaBytes": 10898992,
      "heapUsedBytes": 87128816,
      "domNodes": -270,
      "jsHeapTotalBytes": -1675264,
      "scriptDurationMs": 31.797,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2016.758999999979,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 4.545000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 367.1289999999999,
      "heapDeltaBytes": 11021000,
      "heapUsedBytes": 87097420,
      "domNodes": -266,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 25.580999999999992,
      "eventListeners": -160,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2426.9120000000157,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 13.593999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1193.797,
      "heapDeltaBytes": 22027404,
      "heapUsedBytes": 87999900,
      "domNodes": -272,
      "jsHeapTotalBytes": 1536000,
      "scriptDurationMs": 575.557,
      "eventListeners": -160,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2434.3559999999798,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 14.484,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1154.194,
      "heapDeltaBytes": -18253308,
      "heapUsedBytes": 85339992,
      "domNodes": -266,
      "jsHeapTotalBytes": -1675264,
      "scriptDurationMs": 548.294,
      "eventListeners": -160,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3415.391999999997,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 13.443999999999997,
      "layouts": 60,
      "layoutDurationMs": 13.842000000000002,
      "taskDurationMs": 1253.5569999999998,
      "heapDeltaBytes": 13776948,
      "heapUsedBytes": 92959856,
      "domNodes": -292,
      "jsHeapTotalBytes": 3043328,
      "scriptDurationMs": 532.4639999999999,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3149.06000000002,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 13.305000000000001,
      "layouts": 60,
      "layoutDurationMs": 12.931999999999999,
      "taskDurationMs": 1133.586,
      "heapDeltaBytes": -2726920,
      "heapUsedBytes": 76190044,
      "domNodes": -274,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 492.62500000000006,
      "eventListeners": -158,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3017.8359999999884,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 8.324000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1576.431,
      "heapDeltaBytes": 17983364,
      "heapUsedBytes": 86064004,
      "domNodes": 6,
      "jsHeapTotalBytes": 1990656,
      "scriptDurationMs": 760.517,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3096.3100000000168,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 7.016000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1576.854,
      "heapDeltaBytes": 22149460,
      "heapUsedBytes": 90221408,
      "domNodes": 2,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 766.3720000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2034.5320000000129,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.915000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 364.034,
      "heapDeltaBytes": 8801404,
      "heapUsedBytes": 87029464,
      "domNodes": -270,
      "jsHeapTotalBytes": -2461696,
      "scriptDurationMs": 23.46,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2019.301999999982,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.888000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 400.113,
      "heapDeltaBytes": 5917956,
      "heapUsedBytes": 83492748,
      "domNodes": -276,
      "jsHeapTotalBytes": -1675264,
      "scriptDurationMs": 28.53000000000001,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 396.40500000001566,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 9.998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 264.13100000000003,
      "heapDeltaBytes": 14489184,
      "heapUsedBytes": 86224092,
      "domNodes": 22,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 89.726,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 513.5579999999891,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.187,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 309.063,
      "heapDeltaBytes": 14610180,
      "heapUsedBytes": 88023820,
      "domNodes": 20,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 99.29899999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.8849999999875,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.347999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 401.7060000000001,
      "heapDeltaBytes": -9960864,
      "heapUsedBytes": 62900240,
      "domNodes": -296,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 9.369,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.5420000000008,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.617000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 417.79999999999995,
      "heapDeltaBytes": -5055480,
      "heapUsedBytes": 68381708,
      "domNodes": -296,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 10.333,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1707.6309999999921,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 25.97,
      "layouts": 18,
      "layoutDurationMs": 4.896999999999999,
      "taskDurationMs": 670.4519999999999,
      "heapDeltaBytes": -12798692,
      "heapUsedBytes": 60174284,
      "domNodes": -295,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 93.15100000000001,
      "eventListeners": -208,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1693.3049999999525,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 24.77,
      "layouts": 18,
      "layoutDurationMs": 4.95,
      "taskDurationMs": 641.965,
      "heapDeltaBytes": 4406500,
      "heapUsedBytes": 77710728,
      "domNodes": -297,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 91.38499999999999,
      "eventListeners": -208,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 833.4879999999885,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 21.122000000000003,
      "layouts": 17,
      "layoutDurationMs": 10.31,
      "taskDurationMs": 584.6510000000001,
      "heapDeltaBytes": -7125932,
      "heapUsedBytes": 83636880,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 19.537,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 69,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8969.10200000002,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 41.857,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4128.840999999999,
      "heapDeltaBytes": 17321896,
      "heapUsedBytes": 93814300,
      "domNodes": -269,
      "jsHeapTotalBytes": 122880,
      "scriptDurationMs": 1870.1399999999999,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9688.608999999986,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 43.892,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4484.208,
      "heapDeltaBytes": -8669444,
      "heapUsedBytes": 67495832,
      "domNodes": -270,
      "jsHeapTotalBytes": -888832,
      "scriptDurationMs": 1972.276,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12611.124999999958,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11605.778,
      "heapDeltaBytes": -54705896,
      "heapUsedBytes": 179283896,
      "domNodes": -8068,
      "jsHeapTotalBytes": -19009536,
      "scriptDurationMs": 174.20000000000002,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12569.982000000038,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11812.500999999998,
      "heapDeltaBytes": -65831156,
      "heapUsedBytes": 170954356,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12759040,
      "scriptDurationMs": 183.78499999999997,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14715.517000000034,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 13.884000000000007,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14328.063000000002,
      "heapDeltaBytes": -37765484,
      "heapUsedBytes": 186925264,
      "domNodes": -8068,
      "jsHeapTotalBytes": -18362368,
      "scriptDurationMs": 644.8860000000001,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 31,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15042.882999999962,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 15.519000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14667.115999999998,
      "heapDeltaBytes": -46305208,
      "heapUsedBytes": 186289520,
      "domNodes": -8068,
      "jsHeapTotalBytes": -20127744,
      "scriptDurationMs": 658.427,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 3,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4240.639999999985,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 51.28099999999999,
      "layouts": 20,
      "layoutDurationMs": 22.76,
      "taskDurationMs": 4153.348999999999,
      "heapDeltaBytes": -34179796,
      "heapUsedBytes": 185330404,
      "domNodes": -8068,
      "jsHeapTotalBytes": 21745664,
      "scriptDurationMs": 66.01400000000001,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 16,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4453.740999999923,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 52.62500000000001,
      "layouts": 20,
      "layoutDurationMs": 22.487999999999992,
      "taskDurationMs": 4364.749,
      "heapDeltaBytes": -40132604,
      "heapUsedBytes": 186381380,
      "domNodes": -8068,
      "jsHeapTotalBytes": 16576512,
      "scriptDurationMs": 72.901,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 63,
      "frameDurationMs": 17.220000000000013,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6278.692999999976,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5959.785999999999,
      "heapDeltaBytes": 8756228,
      "heapUsedBytes": 191241088,
      "domNodes": 0,
      "jsHeapTotalBytes": -9961472,
      "scriptDurationMs": 88.534,
      "eventListeners": -8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6351.40100000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6090.399999999999,
      "heapDeltaBytes": 5687044,
      "heapUsedBytes": 172100372,
      "domNodes": 0,
      "jsHeapTotalBytes": -15728640,
      "scriptDurationMs": 90.24399999999999,
      "eventListeners": -8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 70.37900000000263,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 10.408000000000001,
      "layouts": 2,
      "layoutDurationMs": 0.5339999999999999,
      "taskDurationMs": 53.07299999999999,
      "heapDeltaBytes": 3094904,
      "heapUsedBytes": 71528392,
      "domNodes": 107,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 5.3100000000000005,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "workflow-execution",
      "durationMs": 417.2889999999825,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 14.73,
      "layouts": 2,
      "layoutDurationMs": 0.4760000000000001,
      "taskDurationMs": 69.68500000000002,
      "heapDeltaBytes": 4749732,
      "heapUsedBytes": 73836472,
      "domNodes": 121,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 6.015,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50465 75671 66.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.6% 275
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.4% 260
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 22, 2026
@datadog-official

This comment has been minimized.

@codecov

codecov Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #18370   +/-   ##
=============================================
  Coverage              ?   83.74%           
=============================================
  Files                 ?     2110           
  Lines                 ?   125125           
  Branches              ?    33850           
=============================================
  Hits                  ?   104790           
  Misses                ?    20156           
  Partials              ?      179           
Flag Coverage Δ
e2e 66.70% <ø> (?)
unit 78.80% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

christian-byrne added a commit that referenced this pull request Sep 22, 2026
… Image node bypassing upload (#18465)

Automated backport of #18180 to `cloud/1.54`.

The bot's auto-backport (`comfy-pr-bot`) failed on this branch with
merge conflicts in:
- `src/extensions/core/load3d/Load3DConfiguration.test.ts`
- `src/extensions/core/load3d/Load3DConfiguration.ts`
- `src/utils/createAnnotatedPath.test.ts`

## Root cause of the conflict

Not a stacking conflict against any of the PRs the bot listed as
still-open on `cloud/1.54` (#18418, #18411, #18370, #18367, #18355,
#18351) — none of them touch these files. The real cause is identical to
the `core/1.54` backport: `cloud/1.54` never received an
**already-merged, unrelated** PR, #17537 ("Load3D preview capture stale
after agent-driven model_file change"), which is not on the bot's
open-PR list and is not itself labeled for backport. That PR:
- added a `DEFAULT_GIZMO`/`GizmoConfig` block to
`Load3DConfiguration.ts` right next to the `parseAnnotatedFilename`
helper that #18180 deletes (textual adjacency, not a real dependency —
the gizmo code was left out, since it's out of scope here and
`cloud/1.54` has no other reference to it), and added
`ComfyApi`/`ComfyApp` test imports unused on this branch (dropped),
- moved the `ResultItem` type from `@/schemas/apiSchema` to
`@/platform/remote/comfyui/execution/types` on `main`, which
`cloud/1.54` hasn't picked up (kept the branch's existing
`@/schemas/apiSchema` import), and
- added an `app.getRandParam()` call inside `nodeOutputStore.ts`
(already present on `cloud/1.54` from an earlier point, unrelated to
#18180) whose test mock in `nodeOutputStore.test.ts` was missing
`getRandParam`, only surfaced now because #18180's new test is the first
to exercise `getNodeImageUrls()` on this file — added the missing mock
entry.

Resolved by taking #18180's actual change (removing the local
`parseAnnotatedFilename` in favor of the shared `parseAnnotatedPath`
util) while leaving everything from #17537 out, since it isn't part of
this branch.

## Verification
- `pnpm exec vitest run` on the touched spec files
(`Load3DConfiguration.test.ts`, `createAnnotatedPath.test.ts`,
`nodeOutputStore.test.ts`, `imageUtil.test.ts`) — all pass (113/113)
- `pnpm typecheck` — clean
- `pnpm exec eslint` on changed files — no errors (2 pre-existing
`apiSchema` deprecation warnings, unrelated to this change)
- `pnpm exec oxfmt --check` on changed files — clean
- The new Playwright e2e (`assetPanelDragOntoLoadImageWidget.spec.ts`)
was not run locally (no backend available), consistent with the original
PR's own review notes.

<!-- ccr-slack-attribution -->
_Requested by **Christian Byrne** · [Slack
thread](https://comfy-org.slack.com/archives/C0BGH348Z0C/p1789875316334739)_

---
_Generated by [Claude
Code](https://claude.ai/code/session_01Ws2BqUcMwaeUuPpKdYNxPV)_

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: bymyself <cbyrne@comfy.org>
## Summary

- Mouse-driven reference-image alignment coverage only; no product fix
claimed.
- Five source links and the empty trailing slot are asserted.
- Unrelated runtime changes removed from this PR.

<details><summary>Full context for agent readers</summary>

The [original
report](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789782395656129)
described port/label drift while stress-testing the in-app agent. This
test uses mouse connections, not agent synchronization. It must not be
used to close that incident. [The agent slot-identity
fix](#18279) remains
separate.

The earlier test failure was a fixed-coordinate drag losing its target
during canvas auto-pan. Keeping the viewport stable makes this mouse
scenario pass without a product-code change. This is coverage of working
behavior, not a reproduced product regression or a TDD bug-fix claim.

The takeover rebuilds the test on current main rather than carrying
parent-branch widget-rebinding and formatting changes. Primary commit
authorship is preserved; the co-author trailer is removed as requested.
The retained test now checks the exact five source identities, ordered
image_1 through image_6 slots, row labels, and link-endpoint alignment.
It captures the full workflow and an enlarged node.

Local Chromium QA passed, including three consecutive runs without
retries. Browser TypeScript, scoped lint and format passed. Fresh hosted
CI and actual bot review remain required before merge; the previous
CodeRabbit success status represented a skipped review.

Cross-model review: Gemini Skeptic and Evidence-Seeded lenses completed.
Refreshed slot indexes inside each alignment retry. Rejected tolerance
widening without evidence of rounding failures, and rejected an
asynchronous-autogrow claim after inspecting the synchronous connection
callback and the drag helper's existing frame wait. The
architecture-lens alternate provider was not verified as a different
model and is not counted as cross-model evidence.

Glossary: autogrow means creating the next empty input automatically; QA
means exercising the rendered application; CI means hosted automated
checks; TDD means a test demonstrated failing before its corresponding
production fix.

</details>

---------

Co-authored-by: christian-byrne <cbyrne@comfy.org>
@comfy-pr-bot
comfy-pr-bot merged commit 9f75ecd into cloud/1.54 Sep 24, 2026
91 of 92 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-18101-to-cloud-1.54 branch September 24, 2026 02:08
christian-byrne pushed a commit that referenced this pull request Sep 24, 2026
… window (#18674)

<!-- ccr-slack-attribution -->
Automated backport of #18599 to `cloud/1.54`, after the backport bot's
automated cherry-pick attempt failed on a merge conflict.

## Summary

Cherry-picks e346ef9 (#18599) onto
`cloud/1.54`. That PR gives the unified-remint post-401 retry fetch a
fresh timeout window instead of letting it inherit whatever was left of
the original request's 60s deadline (Sentry
`CLOUD-FRONTEND-STAGING-4MF`/`4MG`).

## Conflict and resolution

- `src/scripts/api.ts` and `src/platform/auth/unified/remintRetry.ts`
cherry-picked cleanly with no conflicts.
- `src/scripts/api.fetchApi.test.ts` conflicted because three other open
PRs (#18644, #18479, #18370) are stacked on `cloud/1.54` touching the
same file, and because `cloud/1.54`'s mocking setup for this file
predates several refactors that already landed on `main`
(`fromPartial`/`vi.mock(import(...))` typed mocks, and a
`firebaseIdentity` auth wrapper that doesn't exist on `cloud/1.54`).
Resolved by keeping `cloud/1.54`'s existing plain `vi.mock('module',
factory)` style and layering in only the additions the new `post-401
retry timeout budget` test needs (the `trackUnifiedAuthRetry` mock, the
`mockDistribution`/`isCloud` toggle, a `useFeatureFlags` mock, and
`vuefire`/`firebase/auth` stubs matching the convention already used in
`authStore.test.ts`), instead of pulling over `main`'s newer typed-mock
plumbing verbatim.
- Also fixed two latent issues surfaced while getting the cherry-picked
tests to actually pass on this branch (not part of the original PR's
intent, but required for the cherry-pick to work):
- `src/platform/auth/unified/remintRetry.test.ts`'s new test referenced
`useWorkspaceAuthStore()` directly (that's `main`'s current test style),
but `cloud/1.54`'s version of this file mocks the store via a
`mockRemint` const instead and never imports `useWorkspaceAuthStore` —
fixed to use `mockRemint.mockResolvedValue(...)`.
- `src/scripts/api.ts`'s new retry-timeout breadcrumb called a bare
`addBreadcrumb(...)`, but this file imports Sentry as `import * as
Sentry from '@sentry/vue'` — fixed to `Sentry.addBreadcrumb(...)`.

## Verification

- `pnpm vitest run src/scripts/api.fetchApi.test.ts
src/platform/auth/unified/remintRetry.test.ts` — 41/41 tests pass.
- `pnpm exec eslint` on the four touched files — clean (pre-existing,
unrelated `api.ts` lint findings elsewhere in the file are untouched by
this diff).
- `pnpm run typecheck` (`vue-tsc --noEmit`) — clean.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_0137jzrG6RSp5e6YgGp8kxdY

---
_Generated by [Claude
Code](https://claude.ai/code/session_0137jzrG6RSp5e6YgGp8kxdY)_

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: dante01yoon <bunggl@naver.com>
claude Bot added a commit that referenced this pull request Sep 24, 2026
…roups (#18275)

<!-- ccr-slack-attribution -->
_Requested by **Christian Byrne** · [Slack
thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789965317152049?thread_ts=1789965317.152049&cid=C0BGH348Z0C)_

Fixes agent-authored nodes with more than one autogrow group (e.g. a
reference node with separate image and video reference groups) losing
track of which wire goes where after the agent chat materializes the
node.

**Before:** For a node like `MiniMaxH3ReferenceToVideo`, which has two
independent autogrow groups (`ref_images`, `ref_videos`) alongside
scalar widgets (`width`, `height`, `length`, `ref_image_size`), both the
agent panel and the canvas painted wires onto the wrong inputs after the
node was built or reopened — a Load Image could land on
`ref_image_size`, a text input on `length`, a Math node on `ref_videos`,
and `width`/`height` could show as `0`. The server's own view of the
graph was correctly wired, so pressing Run submitted the client's
shifted (wrong) values and failed with type errors that didn't actually
exist. Reopening the tab reconstructed the slots differently each time.

**After:** For a document that is already correctly wired, projecting it
onto the live canvas now lands every wire on the input it was actually
connected to, and the value submitted on Run matches what's shown on
canvas, regardless of how many autogrow groups the node has or how their
growth interleaves with each other and with the node's scalar widgets.
This covers the document-to-live projection direction only; the outbound
leg (minting a link back into the host document) can still corrupt a
node's addressing before this projection ever runs on it — see "Known
issue" below and #18332.

- **What**: `node.configure()` and autogrow growth (`COMFY_AUTOGROW_V3`)
can reorder or insert a node's live inputs after the agent CRDT follower
has already built its link adapters against the saved document's input
*positions*. With one autogrow group this only shifts a couple of
neighboring scalar widgets; with two or more groups growing on the same
node, the drift compounds across the whole input list. The fix re-points
the follower's link adapters, and the incoming reconcile/connect
handling, at the input with the same *name* as the saved slot, instead
of the same index — reusing the link realignment ordinary node loading
already relies on, and extending the reconcile/connect path to resolve
by name. A live-only input (one no document occurrence matches) is
retained, rather than dropped along with the rest of the document's
positional replacement, only when it classifies as a real autogrow group
member — via a live query, this follower's own remembered answer, the
node type's static `COMFY_AUTOGROW_V3` definition, or (last resort) the
name-shape heuristic; a genuine removal still lets the document win.
Duplicate input names on one node are matched pairwise by occurrence
(the Nth document occurrence against the Nth live occurrence), not by
first match. Node-data-store slot arrays are now refilled in place
rather than reassigned, so any reactive view already holding that array
keeps its identity across a resync.
- **How**: Added a regression fixture and CRDT-follower test modeled on
a node with two interleaved autogrow groups plus adjacent scalar widgets
(the shape a single-group fixture can't exercise) — confirmed it fails
on the unfixed code, then confirmed the by-name realignment above
(generalized, not per-pair) makes it pass without further
special-casing.

The live-node autogrow-membership port collapsed "the live node can't
answer yet" and "the live node answered no" into the same `undefined`,
so an activate/resubscribe race could drop an explicit-name autogrow
spare. The port now returns a tagged `unavailable`/`member`/`notMember`
result and only the last two are authoritative. When the port is
`unavailable`, provenance falls back in this order: this follower's own
remembered live answer, then the node type's own static
`COMFY_AUTOGROW_V3` definition, and only then the name-shape heuristic.
The membership classification against a static schema (explicit `names`
list vs. trailing ordinal) is one predicate shared with
`dynamicWidgets.ts`'s live registration rather than a second
implementation.

`graphMutations.ts`)

The remembered answers are addressable only from the node incarnation
that produced them:

- **Graph scope in the key.** One `GraphMutations` instance is retained
per cloud workflow while resolving the current local workflow's scope on
every batch, so the key is `rootGraphId` + `owningGraphId` + node id for
remember, read and forget alike.
- **Per-mutation transactional writes.** `batch()` opens a draft before
`prepare()`; every `member`/`notMember` write and forget (replace,
`deleteNode`, `removeMissing`, `clearSemanticGraph`) is staged into that
draft, journaled under the mutation that produced it. `commit()` applies
one mutation's journaled writes to the persisted store immediately after
that mutation's own graph effect lands, and only when that effect
actually landed — a `connect` whose `replaceLink` returns `undefined` (a
stale expected occupant, an ID collision, or a newly-occupied target)
never publishes the write it staged. A later mutation in the same batch
throwing therefore still keeps every earlier mutation's already-applied
write, and a `prepare()` rejection leaves the persisted store completely
untouched. Within `prepare()` itself, a mutation can still see an
earlier mutation's own staged (not yet committed) answer for the same
node — its pending overlay chains onto the nearest earlier-indexed
mutation's still-pending one, so two mutations prepared back to back in
one batch agree on the same name's classification — but nothing outside
that single `prepare()`/`commit()` pass, including a later batch's own
`currentView()` reads, ever sees a same-batch mutation's answer before
its own `commit()` iteration actually applies it.
- **Definition-identity revalidation.** Each entry stores the
`ComfyNodeDefImpl` it was answered against; a re-registration under the
same type name constructs a new one, so the current definition always
beats stale memory. Node type is still part of the entry for the case
where another writer changes a node's type without this instance
observing it.

Also fixed a real race in the turn step: `agentConversationStore.ingest`
only routes `agent_message_done` while the store already holds the ack's
`message_id`, so the host must not answer before the assistant
placeholder `startTurn` renders, or the turn hangs on a live Stop button
forever.

`agentCrdtMultiAutogrowRealign.spec.ts` sets sentinel widget values
through the UI and inspects the submitted-prompt payload by name across
three scenarios: a same-page tab-switch resubscribe, an actual
save-and-reload of the same workflow, and a reload of a workflow whose
saved bytes were corrupted after the save. The tab-switch case fills its
sentinels *before* switching tabs and re-verifies those same values
afterward, so a reconcile that resets or shifts an existing scalar
during replay fails it, not just one that mis-wires a link.

Three defects in the reload path (the second and third scenarios) are
fixed here:

- `mockSavedWorkflowPersistence` never served the `GET
/api/userdata?dir=workflows&...` listing (its `**/api/userdata/*`
pattern cannot match a URL with no path segment after `userdata`), so
after a reload `workflowStore`'s `syncEntities` saw an empty listing,
dropped the saved path from `openWorkflowPaths`, and the agent panel's
workflow picker — which lists `openWorkflows` — came up **empty**. The
reopen step then waited on a menu item that could never appear. This is
the state the hosted runs were failing in; no timeout could help.
- The saved-path GET counter route could never match an
`encodeURIComponent`-encoded userdata path
(`/api/userdata/workflows%2F<name>.json`), so the "the reopen really
read the file" assertion polled a counter stuck at zero. It is now
counted inside the persistence mock, and only for GETs it actually
answered from retained saved bytes.
- Saving under the default `Unsaved Workflow` name made the reopen
indistinguishable from the fresh tab a reload always offers; it now
saves under an explicit name through the Save As UI.

**Spec structure.** The 506-line free-standing scenario function is
replaced by a fixture-owned harness
(`browser_tests/fixtures/helpers/MultiAutogrowRealignHarness.ts`,
registered via `browser_tests/fixtures/multiAutogrowRealignFixture.ts`),
per `browser_tests/README.md`. The spec file now contains only imports,
`test.describe`, `test.describe.configure` and three `test()` bodies
whose acts and assertions read in order. Per-test budgets drop from 240s
to 90s/120s/120s.

With the empty picker fixed, the second-turn reattach case reaches its
assertions for the first time and fails deterministically: after save →
reload → reattach, a link is dropped with
`error_reconciling_agent_incompatible_link_type`. The live graph is
correct (origin `VIDEO`, target `VIDEO`); the **host document** is not —
node 2's doc inputs are in document name order (`prompt` at index 4,
`ref_videos.ref_video_1` at index 7) but the link values were written by
LIVE position, so `"link": 204` sits on the `prompt` (`STRING`) input
and the link tuple reads `[204, 1, 3, 2, 4, "VIDEO"]`.
`excludeIncompatibleLinks` then correctly refuses it.

That is the same positional-vs-named confusion this PR fixes on the
inbound path, occurring on the page → host doc leg through the real
`applyOps` from `@comfyorg/comfy-multi-player`. Fixing it means changing
the mint/outbound leg, which is a different code path needing its own
design and regressions.

**This defect is NOT covered by this PR.** It is not exercised by
`agentCrdtMultiAutogrowRealign.spec.ts` (verifies the inbound/reconcile
path only) and it is not exercised by
`agentFollowerReloadBinding.spec.ts` either — that spec reattaches an
ordinary scalar widget edit on a single-input node, never a
multi-autogrow node, and never mints an outbound link at all. Rather
than ship a red test or weaken an assertion in this PR, the reproduction
is tracked separately with a real failing unit test: #18332 (branch
`test/agent-crdt-outbound-link-position-bug`,
`src/workbench/extensions/agent/crdt/linkMintOutboundPositionCorruption.test.ts`).

- `realignInputLinkSlots` (already used by ordinary graph loading) is
now also invoked after agent materialization; it iterates all of a
node's named links in passes, so it isn't limited to a single autogrow
group.
- `mergeInputSlotsByName`/`hasNonGrowthInputSetChange` in
`graphMutations.ts`: a live-only input only survives when it is a
widget-promoted input slot (the wire format never carries one as a named
input either way) or classifies as an autogrow group member (and, unless
the caller opts into `preserveLinkedAutogrow`, is unlinked); any other
live-only input means the whole input set changed, and the document's
list and order replace it positionally. See
`docs/adr/CRDT-INPUTS-0030-preserve-named-input-targets.md` for the full
rule.
- `createAutogrowMemory`'s read contract: an entry is trusted only when
the graph scope, the node type, and the node definition object all still
match. Its writes are gated on the producing mutation's own commit
result — see "Autogrow memory lifecycle" above.

- [x] **Red/green on each of the cache and commit-ordering blockers.**
Each fix was reverted in isolation and the matching case confirmed to
fail, then restored:
- dropping the graph scope from the key fails `does not let one graph
scope read another scope's remembered autogrow answer on the same
GraphMutations instance`
- making `remember()` write straight to the real map fails `does not
leak the live answer a rejected batch resolved while preparing`
- dropping the `nodeDef` identity clause fails `prefers a re-registered
node definition over an autogrow answer remembered under the definition
it replaced`
- dropping the `nodeType` clause fails `does not apply a remembered
autogrow answer to a node id another writer has since given a different
type`
- moving `beginMutation` back to prepare-only fails `journals a connect
mutation's commit-time autogrow answer under its own index, not the
batch's last-prepared one`
- removing the `committed` gate on `connect`'s memory publication fails
`does not publish a connect mutation's staged autogrow answer when its
own replaceLink fails to land`
- reverting `refillArray` to a spread-based `splice` fails `updateNode
refills a slot list long enough to overflow a spread-based splice,
without changing array identity`
- **(round 8)** ordering `nodeStore.registerNode()` before
`deps.layout.createNode()` (the pre-fix shape) fails `keeps an earlier
mutation's remembered autogrow answer when a later mutation in the same
batch throws`'s new node-3-absence assertion
- **(round 8)** reverting the autogrow-memory draft to a single shared
`shadow` (no per-mutation pending overlay / `rollbackMutation`) fails
`does not leak a failed connect's staged autogrow answer to a later
connect in the same batch`
- **(round 9)** deleting the incumbent before `deps.layout.createNode()`
in a type-changing `replaceNode` (the pre-fix shape) fails `keeps the
incumbent node fully intact when a type-changing replace throws creating
its layout`
- **(round 9)** reverting `currentView` to check only the current
mutation's own pending overlay and the confirmed shadow fails `lets a
mutation see an earlier mutation's still-pending autogrow answer from
the same batch`, while `does not leak a failed connect's staged autogrow
answer to a later connect in the same batch` (round 8) keeps passing
under the fixed, chained version
- **(round 9)** restoring `preserveLinkedAutogrow`'s blanket
non-plain-object early return fails `drops a linked, non-plain runtime
slot the document dropped, even with preserveLinkedAutogrow set`
- **(round 9)** removing the new widget-promoted-slot exception fails
`retains a widget-promoted input slot no document snapshot ever lists`,
and (caught only by the full suite, not this file's own unit tests)
regresses `agentNodeMaterializer.inputOrder.test.ts`'s `preserves named
targets when an agent reconnect follows growth that moves width`
- [x] `pnpm exec vue-tsc --noEmit` and `pnpm exec vue-tsc --noEmit -p
browser_tests/tsconfig.json` — clean
- [x] `pnpm oxlint` (type-aware, whole repo) — no new warnings on
`graphMutations.ts`/`nodeDataStore.ts`; `pnpm exec eslint
src/workbench/extensions/agent/crdt/graphMutations.ts
src/workbench/extensions/agent/crdt/graphMutations.test.ts
src/stores/nodeDataStore.ts src/stores/nodeDataStore.test.ts` — clean;
`pnpm exec oxfmt --check .` — clean; `pnpm knip` — clean
- [x] `pnpm fallow audit --base origin/main` — `complexity_introduced:
2`, `dead_code_introduced: 0`, `duplication_introduced: 0`; the 2
introduced complexity findings are `LGraphCanvas.deselectAll` and
`widgetMap.adoptConcreteWidget`, neither touched this round or by this
PR — `graphMutations.ts`'s own `prepare`/`commit` findings are still
`introduced: false` (pre-existing baseline). The overall verdict is
`fail` only from those two plus unrelated inherited styling/complexity
drift on `main` since this branch's base; nothing under
`src/workbench/extensions/agent/crdt/` or `src/stores/nodeDataStore.ts`
is newly introduced.
- [x] `pnpm vitest run src/workbench/extensions/agent/crdt/
src/stores/nodeDataStore.test.ts` — 57 files, **885 passed, 5 expected
fail**
- [ ] The browser spec reorder (fill-then-switch-then-reverify) was not
re-executed locally this round — this session had no dev server or
backend available. It only reorders existing `test.step`s around
already-existing harness methods (`fillSentinelWidgetValues`,
`expectSentinelWidgetValues`, `switchTabsAwayAndBack`), with no new
harness API surface, and typechecks clean. Hosted CI is the authority
for this file, as it was for the prior round's own claim.

**Known CI blocker (not addressed here):** `Check for AI agent co-author
trailers` fails on 2 pre-existing commits on this branch that need a
history rewrite (rewording). Destructive git history operations are
outside what this session's own permission system allows regardless of
reviewer sign-off; a human with push access to this branch needs to do
that reword directly.

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: bymyself <cbyrne@comfy.org>
Co-authored-by: Amp <amp@ampcode.com>

Automated backport of #18275 hit cherry-pick conflicts; resolved manually:

- browser_tests/fixtures/agentConversationFixture.ts: dropped from this
  backport. The file doesn't exist on cloud/1.54 (added by the still-
  unbackported #17875) and nothing on this branch imports it, including
  the new agentCrdtMultiAutogrowRealign.spec.ts.
- src/lib/litegraph/src/LGraphCanvas.ts (selectItems): kept cloud/1.54's
  existing body. The only diff here was an unrelated Array.from -> spread
  refactor picked up as context noise from #17048 (ownsSelectable filter),
  which also isn't on cloud/1.54.
- src/core/graph/widgets/dynamicWidgets.ts, AgentPanelRoot.vue: additive
  conflicts, took the incoming side. Dropped an incoming useSettingStore
  import in AgentPanelRoot.vue that belonged to a separate, unbackported
  PR (#17730) and was unused on this branch.
- src/workbench/extensions/agent/crdt/graphMutations.ts: took the new
  by-name `connect` handler wholesale (the actual fix). This uncovered a
  missing dependency: linkPresentationStore, introduced by unbackported
  #17875 and used (in code already present before #18275 on main) to
  preserve link presentation across a replace/displace. Ported
  src/types/linkPresentation.ts and src/stores/linkPresentationStore.ts
  (+ its unit test) from main, and added the missing
  `const linkPresentationStore = useLinkPresentationStore()` wiring that
  #18275's diff never touched because it already existed upstream of the
  cherry-pick's base.
- graphMutations.test.ts: same missing-dependency shape, but for the test
  file the only pre-existing usages of linkPresentationStore live in other
  unbackported PRs' test blocks that aren't part of this branch, so the
  import ended up unused; removed it.
- Checked open backport PRs against cloud/1.54 stacking on the same files
  (#18475, #18473, #18418, #18411, #18370, #18367, #18355, #18351): none
  of them are merged into cloud/1.54 yet, so no additional stacking
  conflicts applied.

Verification: pnpm typecheck clean; pnpm vitest run on the directly
relevant suites (graphMutations.test.ts, dynamicWidgets.test.ts,
linkStore.test.ts, nodeDataStore.test.ts, linkPresentationStore.test.ts,
crdtSession.test.ts, agentNodeMaterializer.multiAutogrow.test.ts) is 209
passed / 1 expected-fail; eslint and oxlint clean on all changed files.
comfy-pr-bot pushed a commit that referenced this pull request Sep 24, 2026
…ss multiple autogrow groups (#18479)

Backport of #18275 to `cloud/1.54`.

Manual backport: the automated backport bot hit cherry-pick conflicts
and requested a manual one.

## Conflict resolution notes

- `browser_tests/fixtures/agentConversationFixture.ts`: dropped from
this backport. The file doesn't exist on `cloud/1.54` (added by the
still-unbackported #17875) and nothing on this branch imports it,
including the new `agentCrdtMultiAutogrowRealign.spec.ts`.
- `src/lib/litegraph/src/LGraphCanvas.ts` (`selectItems`): kept
`cloud/1.54`'s existing body. The only diff here was an unrelated
`Array.from` -> spread refactor picked up as context noise from #17048's
`ownsSelectable` filter, which also isn't on `cloud/1.54`.
- `src/core/graph/widgets/dynamicWidgets.ts`, `AgentPanelRoot.vue`:
additive conflicts, took the incoming side. Dropped an incoming
`useSettingStore` import in `AgentPanelRoot.vue` that belonged to a
separate, unbackported PR (#17730) and was unused on this branch.
- `src/workbench/extensions/agent/crdt/graphMutations.ts`: took the new
by-name `connect` handler wholesale (the actual fix). This uncovered a
missing dependency: `linkPresentationStore`, introduced by unbackported
#17875 and used (in code already present before #18275 on `main`) to
preserve link presentation across a replace/displace. Ported
`src/types/linkPresentation.ts` and
`src/stores/linkPresentationStore.ts` (+ its unit test) from `main`, and
added the missing `const linkPresentationStore =
useLinkPresentationStore()` wiring that #18275's diff never touched
because it already existed upstream of the cherry-pick's base.
- `graphMutations.test.ts`: same missing-dependency shape, but for the
test file the only pre-existing usages of `linkPresentationStore` live
in other unbackported PRs' test blocks that aren't part of this branch,
so the import ended up unused; removed it.
- Checked open backport PRs against `cloud/1.54` stacking on the same
files (#18475, #18473, #18418, #18411, #18370, #18367, #18355, #18351):
none of them are merged into `cloud/1.54` yet, so no additional stacking
conflicts applied.

## Verification

- `pnpm typecheck`: clean
- `pnpm vitest run` on the directly relevant suites
(`graphMutations.test.ts`, `dynamicWidgets.test.ts`,
`linkStore.test.ts`, `nodeDataStore.test.ts`,
`linkPresentationStore.test.ts`, `crdtSession.test.ts`,
`agentNodeMaterializer.multiAutogrow.test.ts`): 209 passed, 1 expected
fail
- `eslint` / `oxlint` on all changed files: clean

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01XqLXka9Jsg8EMTYmsnZjjv

---
_Generated by [Claude
Code](https://claude.ai/code/session_01XqLXka9Jsg8EMTYmsnZjjv)_

---------

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>

This branch had an error being deployed

1 failed deployment
Preview – billing-web-test — 59807d75 Deployed Sep 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants