Repository navigation
[Backport cloud/1.54] test: cover asset panel drag onto existing Load Image node bypassing upload - #18465
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1937 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-22T22:36:39.727Z",
"gitSha": "6a65ff26c3455a083350036126b6ce103e83c1d0",
"branch": "backport-18180-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2055.8920000000285,
"styleRecalcs": 11,
"styleRecalcDurationMs": 13.408999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 573.4,
"heapDeltaBytes": 8252844,
"heapUsedBytes": 78025916,
"domNodes": -279,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.514999999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2039.2030000000432,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.16,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.18600000000004,
"heapDeltaBytes": -11110456,
"heapUsedBytes": 59134488,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.6099999999999985,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1919.8089999999866,
"styleRecalcs": 79,
"styleRecalcDurationMs": 32.415,
"layouts": 14,
"layoutDurationMs": 3.862,
"taskDurationMs": 911.265,
"heapDeltaBytes": 12071400,
"heapUsedBytes": 83032956,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 166.977,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1805.9950000000526,
"styleRecalcs": 76,
"styleRecalcDurationMs": 28.427999999999997,
"layouts": 14,
"layoutDurationMs": 4.14,
"taskDurationMs": 864.933,
"heapDeltaBytes": -5781256,
"heapUsedBytes": 63532000,
"domNodes": -279,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 160.836,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1685.2360000000317,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.426000000000002,
"layouts": 6,
"layoutDurationMs": 1.1700000000000002,
"taskDurationMs": 395.382,
"heapDeltaBytes": 4659776,
"heapUsedBytes": 75614132,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 14.017999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1666.4330000000973,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.450000000000001,
"layouts": 6,
"layoutDurationMs": 0.9359999999999997,
"taskDurationMs": 353.175,
"heapDeltaBytes": 4657856,
"heapUsedBytes": 75264540,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.693000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 644.8250000000257,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.317,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.62800000000004,
"heapDeltaBytes": -7876080,
"heapUsedBytes": 63178024,
"domNodes": 16,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 162.97500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 645.9180000000515,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.181000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.039,
"heapDeltaBytes": 18677528,
"heapUsedBytes": 88680152,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 160.844,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2054.8839999999586,
"styleRecalcs": 6,
"styleRecalcDurationMs": 9.259999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 619.9789999999999,
"heapDeltaBytes": 10942984,
"heapUsedBytes": 86878624,
"domNodes": -268,
"jsHeapTotalBytes": -892928,
"scriptDurationMs": 37.994,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2041.3730000000214,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.469999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.8190000000001,
"heapDeltaBytes": 10458828,
"heapUsedBytes": 86808156,
"domNodes": -268,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 32.337,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2259.3069999999784,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.726999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1679.6899999999998,
"heapDeltaBytes": -8091080,
"heapUsedBytes": 68303708,
"domNodes": -281,
"jsHeapTotalBytes": 155648,
"scriptDurationMs": 814.585,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2241.4440000000013,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.403000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1689.226,
"heapDeltaBytes": -7383796,
"heapUsedBytes": 68980320,
"domNodes": -278,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 832.638,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3547.766000000024,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.797,
"layouts": 60,
"layoutDurationMs": 11.827999999999998,
"taskDurationMs": 1732.7280000000003,
"heapDeltaBytes": 9699588,
"heapUsedBytes": 76912684,
"domNodes": -279,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 795.4259999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3572.0260000000508,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.700000000000001,
"layouts": 60,
"layoutDurationMs": 12.177,
"taskDurationMs": 1739.189,
"heapDeltaBytes": 10902436,
"heapUsedBytes": 89409396,
"domNodes": 8,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 795.504,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3152.134999999987,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.6,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1951.42,
"heapDeltaBytes": 21748156,
"heapUsedBytes": 90116376,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 975.4079999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3025.256000000013,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.375999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1920.4749999999997,
"heapDeltaBytes": 22115620,
"heapUsedBytes": 90389776,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 975.177,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2014.6700000000237,
"styleRecalcs": 2,
"styleRecalcDurationMs": 2.012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 595.461,
"heapDeltaBytes": 22150344,
"heapUsedBytes": 88341232,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.33,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2061.3499999999476,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.585,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 611.3120000000001,
"heapDeltaBytes": 5635020,
"heapUsedBytes": 83042028,
"domNodes": -280,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 34.05899999999999,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.0699999999642,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.246,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.01199999999994,
"heapDeltaBytes": 14981452,
"heapUsedBytes": 88255064,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 141.53199999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 576.7590000000382,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.415,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.84099999999995,
"heapDeltaBytes": 14199844,
"heapUsedBytes": 86302168,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 141.61300000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1990.4970000000048,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.221,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.46200000000005,
"heapDeltaBytes": 1062096,
"heapUsedBytes": 66641680,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7.541999999999996,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2006.6779999999653,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.261999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.123,
"heapDeltaBytes": 732920,
"heapUsedBytes": 66181632,
"domNodes": 18,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 7.390999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1701.5529999999899,
"styleRecalcs": 77,
"styleRecalcDurationMs": 25.728,
"layouts": 18,
"layoutDurationMs": 4.560999999999999,
"taskDurationMs": 802.1279999999999,
"heapDeltaBytes": 11183600,
"heapUsedBytes": 84105244,
"domNodes": -296,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 108.024,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.9679999998998,
"styleRecalcs": 76,
"styleRecalcDurationMs": 26.453999999999997,
"layouts": 18,
"layoutDurationMs": 4.9350000000000005,
"taskDurationMs": 815.899,
"heapDeltaBytes": 11079924,
"heapUsedBytes": 83839760,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 112.142,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.9690000000928,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.172999999999995,
"layouts": 15,
"layoutDurationMs": 15.706000000000001,
"taskDurationMs": 905.0420000000001,
"heapDeltaBytes": 20772996,
"heapUsedBytes": 104022612,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 29.673,
"eventListeners": 2387,
"totalBlockingTimeMs": 146,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8930.932999999983,
"styleRecalcs": 246,
"styleRecalcDurationMs": 37.784,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6089.694,
"heapDeltaBytes": 9236976,
"heapUsedBytes": 85146608,
"domNodes": -271,
"jsHeapTotalBytes": -962560,
"scriptDurationMs": 2761.985,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8577.083000000017,
"styleRecalcs": 247,
"styleRecalcDurationMs": 37.925,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5875.303,
"heapDeltaBytes": 9292784,
"heapUsedBytes": 85220352,
"domNodes": -272,
"jsHeapTotalBytes": -143360,
"scriptDurationMs": 2675.4139999999998,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17820.52799999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17124.008,
"heapDeltaBytes": -53840296,
"heapUsedBytes": 181878440,
"domNodes": -8068,
"jsHeapTotalBytes": -14856192,
"scriptDurationMs": 298.268,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17195.87100000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16681.869,
"heapDeltaBytes": -54577736,
"heapUsedBytes": 178649100,
"domNodes": -8068,
"jsHeapTotalBytes": -16932864,
"scriptDurationMs": 282.766,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20607.83600000002,
"styleRecalcs": 167,
"styleRecalcDurationMs": 16.473000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20168.714,
"heapDeltaBytes": -38730992,
"heapUsedBytes": 192466664,
"domNodes": -8068,
"jsHeapTotalBytes": -18857984,
"scriptDurationMs": 943.1220000000001,
"eventListeners": -14927,
"totalBlockingTimeMs": 34,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20825.34799999996,
"styleRecalcs": 175,
"styleRecalcDurationMs": 17.891999999999964,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20445.827999999998,
"heapDeltaBytes": -44454164,
"heapUsedBytes": 179834216,
"domNodes": -8068,
"jsHeapTotalBytes": -16351232,
"scriptDurationMs": 903.4060000000001,
"eventListeners": -14927,
"totalBlockingTimeMs": 114,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6090.31200000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.26800000000001,
"layouts": 20,
"layoutDurationMs": 23.03899999999999,
"taskDurationMs": 5980.529,
"heapDeltaBytes": -35253864,
"heapUsedBytes": 182207660,
"domNodes": -8067,
"jsHeapTotalBytes": 17080320,
"scriptDurationMs": 100.22600000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 378,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6298.067999999944,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.13299999999995,
"layouts": 20,
"layoutDurationMs": 22.07100000000001,
"taskDurationMs": 6158.828,
"heapDeltaBytes": -45158692,
"heapUsedBytes": 183135832,
"domNodes": -8067,
"jsHeapTotalBytes": 7380992,
"scriptDurationMs": 111.63100000000001,
"eventListeners": -14927,
"totalBlockingTimeMs": 476,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8497.316999999952,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8253.147000000003,
"heapDeltaBytes": 24771044,
"heapUsedBytes": 181990136,
"domNodes": 0,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 129.2,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8585.500000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8388.899,
"heapDeltaBytes": 4925000,
"heapUsedBytes": 178774024,
"domNodes": 0,
"jsHeapTotalBytes": -13107200,
"scriptDurationMs": 130.11400000000006,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 92.68799999995281,
"styleRecalcs": 7,
"styleRecalcDurationMs": 11.646,
"layouts": 2,
"layoutDurationMs": 0.591,
"taskDurationMs": 67.11900000000001,
"heapDeltaBytes": 3104644,
"heapUsedBytes": 71038408,
"domNodes": 107,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.272,
"eventListeners": 35,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 442.698000000064,
"styleRecalcs": 14,
"styleRecalcDurationMs": 18.003999999999998,
"layouts": 2,
"layoutDurationMs": 0.4729999999999999,
"taskDurationMs": 89.5,
"heapDeltaBytes": 4754696,
"heapUsedBytes": 72676496,
"domNodes": 121,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.5840000000000005,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
…upload (#18180) <!-- ccr-slack-attribution --> _Requested by **Jo Zhang** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789875316334739)_ Dragging an item out of the Asset Library panel onto an **existing** Load Image node's widget (not empty canvas) updates the widget's filename correctly, but the node's preview shows a broken image / "Image does not exist" instead of the picture. This adds a failing (`test.fail`) e2e repro. No fix included, per the reporting thread's request. `MediaAssetCard.vue`'s `dragStart()` reads the asset's *original* output location straight off its metadata (`filename`/`subfolder`/`type` — e.g. `ComfyUI_temp_<random>_00001_.png [temp]`, the same shape `folder_paths.py`'s own temp-file naming produces) and publishes it as `application/x-comfy-asset-info`. `useNodeDragAndDrop.ts`'s drop handler sees that MIME type and treats it as an already-uploaded `ResultItem`, calling `onResultItemDrop` -> `onUploadComplete` directly (`useNodeImageUpload.ts`). That path never POSTs to `/upload/image` the way a real OS file drag or paste does, so nothing copies (or even checks for) the file at the location the card's metadata names. When that location was the ephemeral `temp` folder from a since-finished job, the widget value becomes a real-looking annotated path that nothing backs, and the live preview's `/view` request 404s. This is a **different mechanism** from two other bugs in this area: - The agent-CRDT stale-preview family: writes bypass `widget.callback`/`onWidgetChanged`, leaving a valid-but-stale image on screen until refresh. Here the callback/`onWidgetChanged` chain runs exactly as designed — the value it commits was just never a real, current upload. - The open "resolve annotated widget values to their own directory" fix (#15065): that fixes `nodeOutputStore.createOutputs` mis-parsing an annotated `[output]`/`[temp]` value into the wrong `/view` query params. That PR's own description scopes out "the drag-drop preview-restore... half" of this bug family as a separate, unaddressed issue — this PR is that other half. Even with #15065's URL-parsing fix applied, this repro still 404s, because the dragged asset's file was never re-uploaded/verified to exist at all; only its *reported* location is now correctly formatted. - **What**: `browser_tests/tests/sidebar/assetPanelDragOntoLoadImageWidget.spec.ts` — mocks a job-grouped, `temp`-tagged Cloud asset (mirroring a stale intermediate output from a finished job), loads `widgets/load_image_widget`, drags the asset card onto the existing Load Image node, then asserts: the widget value becomes the annotated temp-folder filename, no request ever hits `/upload/image`, and the node's image-load-error state (`TestIds.errors.imageLoadError`) becomes visible. - Test only, no production code changed. - The e2e was not run locally (no ComfyUI/Cloud backend available in this environment); lint, format, and both typecheck scopes (`browser_tests` and the whole app) pass. CI should confirm this fails for the intended reason (broken-image/404, not a setup error) before anyone builds a fix on top of it. - Repro-only per request — no production fix included. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01Ws2BqUcMwaeUuPpKdYNxPV --- _Generated by [Claude Code](https://claude.ai/code/session_01Ws2BqUcMwaeUuPpKdYNxPV)_ --------- Co-authored-by: bymyself <cbyrne@comfy.org> (cherry picked from commit d3b73c8)
8900f10 to
46f2f3f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #18465 +/- ##
=============================================
Coverage ? 83.62%
=============================================
Files ? 2098
Lines ? 124085
Branches ? 33552
=============================================
Hits ? 103766
Misses ? 20141
Partials ? 178
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Automated backport of #18180 to
cloud/1.54.The bot's auto-backport (
comfy-pr-bot) failed on this branch with merge conflicts in:src/extensions/core/load3d/Load3DConfiguration.test.tssrc/extensions/core/load3d/Load3DConfiguration.tssrc/utils/createAnnotatedPath.test.tsRoot cause of the conflict
Not a stacking conflict against any of the PRs the bot listed as still-open on
cloud/1.54(#18418, #18411, #18370, #18367, #18355, #18351) — none of them touch these files. The real cause is identical to thecore/1.54backport:cloud/1.54never received an already-merged, unrelated PR, #17537 ("Load3D preview capture stale after agent-driven model_file change"), which is not on the bot's open-PR list and is not itself labeled for backport. That PR:DEFAULT_GIZMO/GizmoConfigblock toLoad3DConfiguration.tsright next to theparseAnnotatedFilenamehelper that test: cover asset panel drag onto existing Load Image node bypassing upload #18180 deletes (textual adjacency, not a real dependency — the gizmo code was left out, since it's out of scope here andcloud/1.54has no other reference to it), and addedComfyApi/ComfyApptest imports unused on this branch (dropped),ResultItemtype from@/schemas/apiSchemato@/platform/remote/comfyui/execution/typesonmain, whichcloud/1.54hasn't picked up (kept the branch's existing@/schemas/apiSchemaimport), andapp.getRandParam()call insidenodeOutputStore.ts(already present oncloud/1.54from an earlier point, unrelated to test: cover asset panel drag onto existing Load Image node bypassing upload #18180) whose test mock innodeOutputStore.test.tswas missinggetRandParam, only surfaced now because test: cover asset panel drag onto existing Load Image node bypassing upload #18180's new test is the first to exercisegetNodeImageUrls()on this file — added the missing mock entry.Resolved by taking #18180's actual change (removing the local
parseAnnotatedFilenamein favor of the sharedparseAnnotatedPathutil) while leaving everything from #17537 out, since it isn't part of this branch.Verification
pnpm exec vitest runon the touched spec files (Load3DConfiguration.test.ts,createAnnotatedPath.test.ts,nodeOutputStore.test.ts,imageUtil.test.ts) — all pass (113/113)pnpm typecheck— cleanpnpm exec eslinton changed files — no errors (2 pre-existingapiSchemadeprecation warnings, unrelated to this change)pnpm exec oxfmt --checkon changed files — cleanassetPanelDragOntoLoadImageWidget.spec.ts) was not run locally (no backend available), consistent with the original PR's own review notes.Requested by Christian Byrne · Slack thread
Generated by Claude Code