Skip to content

[Backport cloud/1.54] test: cover asset panel drag onto existing Load Image node bypassing upload - #18465

Merged
christian-byrne merged 1 commit into
cloud/1.54from
backport-18180-to-cloud-1.54
Sep 22, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.54from
backport-18180-to-cloud-1.54

Conversation

@claude

@claude claude Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Automated backport of #18180 to cloud/1.54.

The bot's auto-backport (comfy-pr-bot) failed on this branch with merge conflicts in:

  • src/extensions/core/load3d/Load3DConfiguration.test.ts
  • src/extensions/core/load3d/Load3DConfiguration.ts
  • src/utils/createAnnotatedPath.test.ts

Root cause of the conflict

Not a stacking conflict against any of the PRs the bot listed as still-open on cloud/1.54 (#18418, #18411, #18370, #18367, #18355, #18351) — none of them touch these files. The real cause is identical to the core/1.54 backport: cloud/1.54 never received an already-merged, unrelated PR, #17537 ("Load3D preview capture stale after agent-driven model_file change"), which is not on the bot's open-PR list and is not itself labeled for backport. That PR:

Resolved by taking #18180's actual change (removing the local parseAnnotatedFilename in favor of the shared parseAnnotatedPath util) while leaving everything from #17537 out, since it isn't part of this branch.

Verification

  • pnpm exec vitest run on the touched spec files (Load3DConfiguration.test.ts, createAnnotatedPath.test.ts, nodeOutputStore.test.ts, imageUtil.test.ts) — all pass (113/113)
  • pnpm typecheck — clean
  • pnpm exec eslint on changed files — no errors (2 pre-existing apiSchema deprecation warnings, unrelated to this change)
  • pnpm exec oxfmt --check on changed files — clean
  • The new Playwright e2e (assetPanelDragOntoLoadImageWidget.spec.ts) was not run locally (no backend available), consistent with the original PR's own review notes.

Requested by Christian Byrne · Slack thread


Generated by Claude Code

@claude
claude Bot requested review from a team and jtydhr88 as code owners September 22, 2026 22:13
@vercel

vercel Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 22, 2026 10:19pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 2f60b439-7b62-4993-aa00-65a7bb5f8201

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1937 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1916 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/22/2026, 10:21:27 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.4 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.9 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.4 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.8 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.3 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.7 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.1 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 146ms TBT · 99.2 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.2 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.9 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 74ms TBT · 177.5 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 427ms TBT · 174.2 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 172.0 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.5 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 10ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 532ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 65.4 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -180
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 30ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 888ms
canvas-mouse-sweep: script duration 164ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 69.9 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -181
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 374ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.9 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 443ms
dom-widget-clipping: script duration 162ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.4 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 606ms
large-graph-idle: script duration 35ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.8 MB
large-graph-idle: DOM nodes -268
large-graph-idle: event listeners -163
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1684ms
large-graph-pan: script duration 824ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 65.5 MB
large-graph-pan: DOM nodes -280
large-graph-pan: event listeners -192
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1736ms
large-graph-zoom: script duration 795ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 79.3 MB
large-graph-zoom: DOM nodes -136
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1936ms
legacy-node-drag: script duration 975ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 86.1 MB
legacy-node-drag: DOM nodes 1
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 603ms
minimap-idle: script duration 35ms
minimap-idle: TBT 0ms
minimap-idle: heap used 81.7 MB
minimap-idle: DOM nodes -277
minimap-idle: event listeners -178
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 414ms
subgraph-dom-widget-clipping: script duration 142ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.2 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 433ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 63.3 MB
subgraph-idle: DOM nodes 19
subgraph-idle: event listeners 6
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 26ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 809ms
subgraph-mouse-sweep: script duration 110ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 80.1 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -211
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 905ms
subgraph-transition-enter: script duration 30ms
subgraph-transition-enter: TBT 146ms
subgraph-transition-enter: heap used 99.2 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 38ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 5982ms
viewport-pan-sweep: script duration 2719ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 81.2 MB
viewport-pan-sweep: DOM nodes -272
viewport-pan-sweep: event listeners -161
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16903ms
vue-large-graph-idle: script duration 291ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 171.9 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14932
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 17ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 171
vue-large-graph-pan: task duration 20307ms
vue-large-graph-pan: script duration 923ms
vue-large-graph-pan: TBT 74ms
vue-large-graph-pan: heap used 177.5 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14927
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 82ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6070ms
vue-node-resize-workload: script duration 106ms
vue-node-resize-workload: TBT 427ms
vue-node-resize-workload: heap used 174.2 MB
vue-node-resize-workload: DOM nodes -8067
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8321ms
vue-zoom-out-idle: script duration 130ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 172.0 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -11
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 2
workflow-execution: style recalc count 11
workflow-execution: task duration 78ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.5 MB
workflow-execution: DOM nodes 114
workflow-execution: event listeners 51
Raw data
{
  "timestamp": "2026-09-22T22:36:39.727Z",
  "gitSha": "6a65ff26c3455a083350036126b6ce103e83c1d0",
  "branch": "backport-18180-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2055.8920000000285,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 13.408999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 573.4,
      "heapDeltaBytes": 8252844,
      "heapUsedBytes": 78025916,
      "domNodes": -279,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 9.514999999999999,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2039.2030000000432,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.16,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 490.18600000000004,
      "heapDeltaBytes": -11110456,
      "heapUsedBytes": 59134488,
      "domNodes": -280,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 7.6099999999999985,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1919.8089999999866,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 32.415,
      "layouts": 14,
      "layoutDurationMs": 3.862,
      "taskDurationMs": 911.265,
      "heapDeltaBytes": 12071400,
      "heapUsedBytes": 83032956,
      "domNodes": -280,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 166.977,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1805.9950000000526,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 28.427999999999997,
      "layouts": 14,
      "layoutDurationMs": 4.14,
      "taskDurationMs": 864.933,
      "heapDeltaBytes": -5781256,
      "heapUsedBytes": 63532000,
      "domNodes": -279,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 160.836,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1685.2360000000317,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 17.426000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.1700000000000002,
      "taskDurationMs": 395.382,
      "heapDeltaBytes": 4659776,
      "heapUsedBytes": 75614132,
      "domNodes": 77,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 14.017999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1666.4330000000973,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.450000000000001,
      "layouts": 6,
      "layoutDurationMs": 0.9359999999999997,
      "taskDurationMs": 353.175,
      "heapDeltaBytes": 4657856,
      "heapUsedBytes": 75264540,
      "domNodes": 76,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 10.693000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 644.8250000000257,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.317,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 443.62800000000004,
      "heapDeltaBytes": -7876080,
      "heapUsedBytes": 63178024,
      "domNodes": 16,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 162.97500000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 645.9180000000515,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.181000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 443.039,
      "heapDeltaBytes": 18677528,
      "heapUsedBytes": 88680152,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 160.844,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2054.8839999999586,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 9.259999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 619.9789999999999,
      "heapDeltaBytes": 10942984,
      "heapUsedBytes": 86878624,
      "domNodes": -268,
      "jsHeapTotalBytes": -892928,
      "scriptDurationMs": 37.994,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2041.3730000000214,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.469999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 592.8190000000001,
      "heapDeltaBytes": 10458828,
      "heapUsedBytes": 86808156,
      "domNodes": -268,
      "jsHeapTotalBytes": -1679360,
      "scriptDurationMs": 32.337,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2259.3069999999784,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 12.726999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1679.6899999999998,
      "heapDeltaBytes": -8091080,
      "heapUsedBytes": 68303708,
      "domNodes": -281,
      "jsHeapTotalBytes": 155648,
      "scriptDurationMs": 814.585,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2241.4440000000013,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.403000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1689.226,
      "heapDeltaBytes": -7383796,
      "heapUsedBytes": 68980320,
      "domNodes": -278,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 832.638,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3547.766000000024,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.797,
      "layouts": 60,
      "layoutDurationMs": 11.827999999999998,
      "taskDurationMs": 1732.7280000000003,
      "heapDeltaBytes": 9699588,
      "heapUsedBytes": 76912684,
      "domNodes": -279,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 795.4259999999999,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3572.0260000000508,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 13.700000000000001,
      "layouts": 60,
      "layoutDurationMs": 12.177,
      "taskDurationMs": 1739.189,
      "heapDeltaBytes": 10902436,
      "heapUsedBytes": 89409396,
      "domNodes": 8,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 795.504,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3152.134999999987,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.6,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1951.42,
      "heapDeltaBytes": 21748156,
      "heapUsedBytes": 90116376,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 975.4079999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3025.256000000013,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.375999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1920.4749999999997,
      "heapDeltaBytes": 22115620,
      "heapUsedBytes": 90389776,
      "domNodes": 2,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 975.177,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2014.6700000000237,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 2.012,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 595.461,
      "heapDeltaBytes": 22150344,
      "heapUsedBytes": 88341232,
      "domNodes": -274,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 36.33,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2061.3499999999476,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.585,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 611.3120000000001,
      "heapDeltaBytes": 5635020,
      "heapUsedBytes": 83042028,
      "domNodes": -280,
      "jsHeapTotalBytes": -1679360,
      "scriptDurationMs": 34.05899999999999,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 595.0699999999642,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.246,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 420.01199999999994,
      "heapDeltaBytes": 14981452,
      "heapUsedBytes": 88255064,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 141.53199999999998,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 576.7590000000382,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.415,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 408.84099999999995,
      "heapDeltaBytes": 14199844,
      "heapUsedBytes": 86302168,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 141.61300000000003,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1990.4970000000048,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.221,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 438.46200000000005,
      "heapDeltaBytes": 1062096,
      "heapUsedBytes": 66641680,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 7.541999999999996,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2006.6779999999653,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.261999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 428.123,
      "heapDeltaBytes": 732920,
      "heapUsedBytes": 66181632,
      "domNodes": 18,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 7.390999999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1701.5529999999899,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 25.728,
      "layouts": 18,
      "layoutDurationMs": 4.560999999999999,
      "taskDurationMs": 802.1279999999999,
      "heapDeltaBytes": 11183600,
      "heapUsedBytes": 84105244,
      "domNodes": -296,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 108.024,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1723.9679999998998,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 26.453999999999997,
      "layouts": 18,
      "layoutDurationMs": 4.9350000000000005,
      "taskDurationMs": 815.899,
      "heapDeltaBytes": 11079924,
      "heapUsedBytes": 83839760,
      "domNodes": -295,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 112.142,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1383.9690000000928,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 32.172999999999995,
      "layouts": 15,
      "layoutDurationMs": 15.706000000000001,
      "taskDurationMs": 905.0420000000001,
      "heapDeltaBytes": 20772996,
      "heapUsedBytes": 104022612,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 29.673,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 146,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8930.932999999983,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 37.784,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6089.694,
      "heapDeltaBytes": 9236976,
      "heapUsedBytes": 85146608,
      "domNodes": -271,
      "jsHeapTotalBytes": -962560,
      "scriptDurationMs": 2761.985,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8577.083000000017,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 37.925,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5875.303,
      "heapDeltaBytes": 9292784,
      "heapUsedBytes": 85220352,
      "domNodes": -272,
      "jsHeapTotalBytes": -143360,
      "scriptDurationMs": 2675.4139999999998,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17820.52799999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17124.008,
      "heapDeltaBytes": -53840296,
      "heapUsedBytes": 181878440,
      "domNodes": -8068,
      "jsHeapTotalBytes": -14856192,
      "scriptDurationMs": 298.268,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17195.87100000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16681.869,
      "heapDeltaBytes": -54577736,
      "heapUsedBytes": 178649100,
      "domNodes": -8068,
      "jsHeapTotalBytes": -16932864,
      "scriptDurationMs": 282.766,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20607.83600000002,
      "styleRecalcs": 167,
      "styleRecalcDurationMs": 16.473000000000017,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20168.714,
      "heapDeltaBytes": -38730992,
      "heapUsedBytes": 192466664,
      "domNodes": -8068,
      "jsHeapTotalBytes": -18857984,
      "scriptDurationMs": 943.1220000000001,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 34,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20825.34799999996,
      "styleRecalcs": 175,
      "styleRecalcDurationMs": 17.891999999999964,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20445.827999999998,
      "heapDeltaBytes": -44454164,
      "heapUsedBytes": 179834216,
      "domNodes": -8068,
      "jsHeapTotalBytes": -16351232,
      "scriptDurationMs": 903.4060000000001,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 114,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6090.31200000004,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 83.26800000000001,
      "layouts": 20,
      "layoutDurationMs": 23.03899999999999,
      "taskDurationMs": 5980.529,
      "heapDeltaBytes": -35253864,
      "heapUsedBytes": 182207660,
      "domNodes": -8067,
      "jsHeapTotalBytes": 17080320,
      "scriptDurationMs": 100.22600000000001,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 378,
      "frameDurationMs": 17.779999999999987,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6298.067999999944,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 80.13299999999995,
      "layouts": 20,
      "layoutDurationMs": 22.07100000000001,
      "taskDurationMs": 6158.828,
      "heapDeltaBytes": -45158692,
      "heapUsedBytes": 183135832,
      "domNodes": -8067,
      "jsHeapTotalBytes": 7380992,
      "scriptDurationMs": 111.63100000000001,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 476,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8497.316999999952,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8253.147000000003,
      "heapDeltaBytes": 24771044,
      "heapUsedBytes": 181990136,
      "domNodes": 0,
      "jsHeapTotalBytes": -786432,
      "scriptDurationMs": 129.2,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8585.500000000025,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8388.899,
      "heapDeltaBytes": 4925000,
      "heapUsedBytes": 178774024,
      "domNodes": 0,
      "jsHeapTotalBytes": -13107200,
      "scriptDurationMs": 130.11400000000006,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 92.68799999995281,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 11.646,
      "layouts": 2,
      "layoutDurationMs": 0.591,
      "taskDurationMs": 67.11900000000001,
      "heapDeltaBytes": 3104644,
      "heapUsedBytes": 71038408,
      "domNodes": 107,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.272,
      "eventListeners": 35,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 442.698000000064,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 18.003999999999998,
      "layouts": 2,
      "layoutDurationMs": 0.4729999999999999,
      "taskDurationMs": 89.5,
      "heapDeltaBytes": 4754696,
      "heapUsedBytes": 72676496,
      "domNodes": 121,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 7.5840000000000005,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 50315 75455 66.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 78.3% 264
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.4% 260
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 22, 2026
…upload (#18180)

<!-- ccr-slack-attribution -->
_Requested by **Jo Zhang** · [Slack
thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789875316334739)_

Dragging an item out of the Asset Library panel onto an **existing**
Load Image node's widget (not empty canvas) updates the widget's
filename correctly, but the node's preview shows a broken image / "Image
does not exist" instead of the picture. This adds a failing
(`test.fail`) e2e repro. No fix included, per the reporting thread's
request.

`MediaAssetCard.vue`'s `dragStart()` reads the asset's *original* output
location straight off its metadata (`filename`/`subfolder`/`type` — e.g.
`ComfyUI_temp_<random>_00001_.png [temp]`, the same shape
`folder_paths.py`'s own temp-file naming produces) and publishes it as
`application/x-comfy-asset-info`. `useNodeDragAndDrop.ts`'s drop handler
sees that MIME type and treats it as an already-uploaded `ResultItem`,
calling `onResultItemDrop` -> `onUploadComplete` directly
(`useNodeImageUpload.ts`). That path never POSTs to `/upload/image` the
way a real OS file drag or paste does, so nothing copies (or even checks
for) the file at the location the card's metadata names. When that
location was the ephemeral `temp` folder from a since-finished job, the
widget value becomes a real-looking annotated path that nothing backs,
and the live preview's `/view` request 404s.

This is a **different mechanism** from two other bugs in this area:
- The agent-CRDT stale-preview family: writes bypass
`widget.callback`/`onWidgetChanged`, leaving a valid-but-stale image on
screen until refresh. Here the callback/`onWidgetChanged` chain runs
exactly as designed — the value it commits was just never a real,
current upload.
- The open "resolve annotated widget values to their own directory" fix
(#15065): that fixes `nodeOutputStore.createOutputs` mis-parsing an
annotated `[output]`/`[temp]` value into the wrong `/view` query params.
That PR's own description scopes out "the drag-drop preview-restore...
half" of this bug family as a separate, unaddressed issue — this PR is
that other half. Even with #15065's URL-parsing fix applied, this repro
still 404s, because the dragged asset's file was never
re-uploaded/verified to exist at all; only its *reported* location is
now correctly formatted.

- **What**:
`browser_tests/tests/sidebar/assetPanelDragOntoLoadImageWidget.spec.ts`
— mocks a job-grouped, `temp`-tagged Cloud asset (mirroring a stale
intermediate output from a finished job), loads
`widgets/load_image_widget`, drags the asset card onto the existing Load
Image node, then asserts: the widget value becomes the annotated
temp-folder filename, no request ever hits `/upload/image`, and the
node's image-load-error state (`TestIds.errors.imageLoadError`) becomes
visible.
- Test only, no production code changed.

- The e2e was not run locally (no ComfyUI/Cloud backend available in
this environment); lint, format, and both typecheck scopes
(`browser_tests` and the whole app) pass. CI should confirm this fails
for the intended reason (broken-image/404, not a setup error) before
anyone builds a fix on top of it.
- Repro-only per request — no production fix included.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01Ws2BqUcMwaeUuPpKdYNxPV

---
_Generated by [Claude
Code](https://claude.ai/code/session_01Ws2BqUcMwaeUuPpKdYNxPV)_

---------

Co-authored-by: bymyself <cbyrne@comfy.org>
(cherry picked from commit d3b73c8)
@claude
claude Bot force-pushed the backport-18180-to-cloud-1.54 branch from 8900f10 to 46f2f3f Compare September 22, 2026 22:19
@codecov

codecov Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #18465   +/-   ##
=============================================
  Coverage              ?   83.62%           
=============================================
  Files                 ?     2098           
  Lines                 ?   124085           
  Branches              ?    33552           
=============================================
  Hits                  ?   103766           
  Misses                ?    20141           
  Partials              ?      178           
Flag Coverage Δ
e2e 66.69% <100.00%> (?)
unit 78.60% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/extensions/core/load3d/Load3DConfiguration.ts 90.00% <100.00%> (ø)
src/stores/nodeOutputStore.ts 88.67% <100.00%> (ø)
src/utils/createAnnotatedPath.ts 100.00% <100.00%> (ø)
src/utils/imageUtil.ts 72.09% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne merged commit 8ead7a7 into cloud/1.54 Sep 22, 2026
90 checks passed
@christian-byrne
christian-byrne deleted the backport-18180-to-cloud-1.54 branch September 22, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants