Repository navigation
[backport cloud/1.54] Give unified-remint retry fetch its own timeout window - #18674
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1945 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-24T02:20:25.804Z",
"gitSha": "fbdf2e720bb1c675895fbb317ab6ebb2969bc411",
"branch": "backport-18599-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2069.334000000026,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.297999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 627.67,
"heapDeltaBytes": 9301228,
"heapUsedBytes": 80378036,
"domNodes": -283,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 12.188999999999998,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2039.743000000044,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.055000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 572.891,
"heapDeltaBytes": -3128440,
"heapUsedBytes": 67268392,
"domNodes": -284,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 11.085999999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1910.9090000000606,
"styleRecalcs": 81,
"styleRecalcDurationMs": 39.012,
"layouts": 14,
"layoutDurationMs": 4.784,
"taskDurationMs": 980.255,
"heapDeltaBytes": 11993204,
"heapUsedBytes": 82426872,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 155.42099999999996,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1941.077000000064,
"styleRecalcs": 79,
"styleRecalcDurationMs": 35.627,
"layouts": 14,
"layoutDurationMs": 4.38,
"taskDurationMs": 1003.963,
"heapDeltaBytes": 484848,
"heapUsedBytes": 70916864,
"domNodes": -281,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 157.589,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1734.119000000078,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.292,
"layouts": 6,
"layoutDurationMs": 1.1160000000000003,
"taskDurationMs": 441.0820000000001,
"heapDeltaBytes": 4633652,
"heapUsedBytes": 75788784,
"domNodes": 75,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 15.092,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1678.087000000005,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.015,
"layouts": 6,
"layoutDurationMs": 1.1340000000000001,
"taskDurationMs": 400.367,
"heapDeltaBytes": 4644916,
"heapUsedBytes": 75919036,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.659999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 718.1399999999485,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.314,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.32800000000003,
"heapDeltaBytes": 18653372,
"heapUsedBytes": 88768992,
"domNodes": 14,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 164.076,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 722.7229999999736,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.054999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.67499999999995,
"heapDeltaBytes": 18318400,
"heapUsedBytes": 88812332,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 163.692,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2035.6949999999188,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.9209999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 671.806,
"heapDeltaBytes": 10585500,
"heapUsedBytes": 86976252,
"domNodes": -272,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 32.59300000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2041.7560000000776,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.442,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 724.7139999999999,
"heapDeltaBytes": 4639740,
"heapUsedBytes": 80560048,
"domNodes": -285,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 35.237,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 3007.718999999952,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.711,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1951.2199999999998,
"heapDeltaBytes": 7505376,
"heapUsedBytes": 84466104,
"domNodes": -248,
"jsHeapTotalBytes": 1433600,
"scriptDurationMs": 934.7630000000001,
"eventListeners": -190,
"totalBlockingTimeMs": 1,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2766.272000000072,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.517000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1727.2390000000003,
"heapDeltaBytes": 26897752,
"heapUsedBytes": 93352700,
"domNodes": -278,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 814.8369999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3867.100999999934,
"styleRecalcs": 61,
"styleRecalcDurationMs": 11.701000000000002,
"layouts": 60,
"layoutDurationMs": 13.141000000000002,
"taskDurationMs": 1863.972,
"heapDeltaBytes": 8807016,
"heapUsedBytes": 76438888,
"domNodes": 2,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 796.5640000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3912.017999999989,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.939,
"layouts": 60,
"layoutDurationMs": 13.392999999999999,
"taskDurationMs": 1849.2920000000001,
"heapDeltaBytes": 9600712,
"heapUsedBytes": 76930260,
"domNodes": -280,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 792.6,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3097.2719999999754,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.679,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2107.961,
"heapDeltaBytes": 22525356,
"heapUsedBytes": 89529744,
"domNodes": -11,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1009.6209999999999,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3146.871000000033,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.528999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2087.809,
"heapDeltaBytes": 25989932,
"heapUsedBytes": 94383108,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1001.882,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2054.975999999897,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.9209999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 714.703,
"heapDeltaBytes": 6149468,
"heapUsedBytes": 83335952,
"domNodes": -283,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 35.72599999999999,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2027.674000000161,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.790999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 684.425,
"heapDeltaBytes": 9222208,
"heapUsedBytes": 87827540,
"domNodes": -268,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 37.786,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 756.4449999999852,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.768999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.837,
"heapDeltaBytes": 15045996,
"heapUsedBytes": 88183188,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 154.60999999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 620.9580000002006,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.585,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.00300000000004,
"heapDeltaBytes": 15024560,
"heapUsedBytes": 88436580,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 137.59099999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2027.6890000000094,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.746000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 553.2269999999999,
"heapDeltaBytes": 496352,
"heapUsedBytes": 73095740,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.497,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2033.1529999999702,
"styleRecalcs": 12,
"styleRecalcDurationMs": 11.167000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 598.087,
"heapDeltaBytes": -5402620,
"heapUsedBytes": 68181288,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 11.533000000000001,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1804.9800000000005,
"styleRecalcs": 79,
"styleRecalcDurationMs": 36.172999999999995,
"layouts": 18,
"layoutDurationMs": 6.164999999999999,
"taskDurationMs": 1001.244,
"heapDeltaBytes": -9453768,
"heapUsedBytes": 62271696,
"domNodes": -297,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 119.222,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1823.5469999999623,
"styleRecalcs": 77,
"styleRecalcDurationMs": 29.711999999999996,
"layouts": 18,
"layoutDurationMs": 5.252,
"taskDurationMs": 949.169,
"heapDeltaBytes": 2091728,
"heapUsedBytes": 75264932,
"domNodes": -295,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 113.78900000000002,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1416.1329999999452,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.011000000000003,
"layouts": 15,
"layoutDurationMs": 15.030000000000001,
"taskDurationMs": 994.3140000000002,
"heapDeltaBytes": -7150052,
"heapUsedBytes": 82889996,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 31.644,
"eventListeners": 2385,
"totalBlockingTimeMs": 143,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 12618.724999999926,
"styleRecalcs": 247,
"styleRecalcDurationMs": 53.62799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8220.58,
"heapDeltaBytes": -7911836,
"heapUsedBytes": 68665912,
"domNodes": -274,
"jsHeapTotalBytes": 1208320,
"scriptDurationMs": 3488.806,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9282.04699999992,
"styleRecalcs": 246,
"styleRecalcDurationMs": 35.755,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6307.831,
"heapDeltaBytes": 12993716,
"heapUsedBytes": 89720388,
"domNodes": -270,
"jsHeapTotalBytes": -1220608,
"scriptDurationMs": 2768.8559999999998,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15987.537999999971,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15438.490999999998,
"heapDeltaBytes": -54823600,
"heapUsedBytes": 184958288,
"domNodes": -8068,
"jsHeapTotalBytes": -17256448,
"scriptDurationMs": 278.549,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15836.806999999908,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15428.616999999998,
"heapDeltaBytes": -56450920,
"heapUsedBytes": 176847532,
"domNodes": -8068,
"jsHeapTotalBytes": -16142336,
"scriptDurationMs": 288.462,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 19113.390999999978,
"styleRecalcs": 136,
"styleRecalcDurationMs": 18.488000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18876.482,
"heapDeltaBytes": -34054528,
"heapUsedBytes": 194123188,
"domNodes": -8068,
"jsHeapTotalBytes": -17326080,
"scriptDurationMs": 892.6339999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 81,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 19442.943000000014,
"styleRecalcs": 150,
"styleRecalcDurationMs": 20.69599999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19220.361999999997,
"heapDeltaBytes": -53139964,
"heapUsedBytes": 186991656,
"domNodes": -8068,
"jsHeapTotalBytes": -17809408,
"scriptDurationMs": 939.595,
"eventListeners": -14931,
"totalBlockingTimeMs": 36,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 5898.315000000025,
"styleRecalcs": 20,
"styleRecalcDurationMs": 109.17000000000004,
"layouts": 20,
"layoutDurationMs": 33.23000000000001,
"taskDurationMs": 5801.784000000001,
"heapDeltaBytes": -33991012,
"heapUsedBytes": 191125332,
"domNodes": -8067,
"jsHeapTotalBytes": 3325952,
"scriptDurationMs": 113.303,
"eventListeners": -14929,
"totalBlockingTimeMs": 500,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5766.685999999936,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.33399999999999,
"layouts": 20,
"layoutDurationMs": 25.965000000000003,
"taskDurationMs": 5682.681999999999,
"heapDeltaBytes": -36043280,
"heapUsedBytes": 182193120,
"domNodes": -8068,
"jsHeapTotalBytes": 16502784,
"scriptDurationMs": 114.659,
"eventListeners": -14931,
"totalBlockingTimeMs": 284,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8032.332999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7841.4969999999985,
"heapDeltaBytes": 37460460,
"heapUsedBytes": 200727180,
"domNodes": -2,
"jsHeapTotalBytes": -11272192,
"scriptDurationMs": 126.51899999999993,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8001.845000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7801.447000000001,
"heapDeltaBytes": 3813756,
"heapUsedBytes": 179666676,
"domNodes": 0,
"jsHeapTotalBytes": -18350080,
"scriptDurationMs": 127.94800000000006,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 487.64599999992697,
"styleRecalcs": 10,
"styleRecalcDurationMs": 16.659999999999997,
"layouts": 3,
"layoutDurationMs": 0.8299999999999997,
"taskDurationMs": 121.00099999999999,
"heapDeltaBytes": 4778128,
"heapUsedBytes": 73222544,
"domNodes": 118,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.253,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 114.19199999977536,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.187,
"layouts": 2,
"layoutDurationMs": 0.7599999999999998,
"taskDurationMs": 84.63600000000001,
"heapDeltaBytes": 3001352,
"heapUsedBytes": 72245236,
"domNodes": 106,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.64,
"eventListeners": 35,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
<!-- ccr-slack-attribution --> _Requested via [Slack thread](https://comfy-organization.slack.com/archives/C09KFK2ABB8/p1790161872557349)_ Fixes the pattern behind Sentry `CLOUD-FRONTEND-STAGING-4MF`/`4MG`: the unified-remint retry fetch could spuriously time out under staging load because it inherited whatever was left of the original request's 60s deadline instead of getting a full one. - **What**: `fetchApi()` (`src/scripts/api.ts`) armed a single 60s `AbortSignal` and passed it straight through to `fetchWithUnifiedRemint()`. On a 401, that function re-mints the unified Cloud JWT (`tryRemintToken` → `workspaceAuthStore.remintUnifiedOnce()` → `unifiedUser()` → `unifiedSessionClient.remint()` → `exchangeToken()`, each step with its own independent ~15s ceiling) before retrying the original request — but the retry reused the *same* original signal, so its effective budget was `60s minus whatever the re-mint round trip already spent`, not a fresh 60s. Under load, a slower-than-usual re-mint could leave the retry only a few seconds before it was aborted with `TimeoutError: Fetch timeout`, even though every individual step was within its own budget. `fetchWithUnifiedRemint()` (`src/platform/auth/unified/remintRetry.ts`) now takes an optional 4th parameter, `freshRetrySignal?: () => AbortSignal | undefined`, called only if a retry actually happens; its return value replaces the original `init.signal` on the retry `fetch`. `fetchApi()` passes a callback that mints a new `AbortController` + `setTimeout` (same duration, same `DOMException('Fetch timeout', 'TimeoutError')` construction as the existing timeout, so Sentry grouping stays consistent) combined with the caller's own `signal` via `AbortSignal.any`, and cleans up the new timer in the existing `.finally()`. `fetchWithUnifiedRemint()` has two other call sites (`globalSettingsApi.ts`, `authStore.ts`) that pass no signal at all today; the new parameter is optional and defaults to `undefined`, which keeps their behavior byte-for-byte unchanged (they can't produce this `TimeoutError` in the first place — only a benign `TypeError: Failed to fetch`). - **Breaking**: none - **Dependencies**: none - `remintRetry.ts`: build the retry `fetch`'s `init` from `freshRetrySignal()` when supplied, instead of always spreading the original `init` (which carried the shrunk signal). - `api.ts`: `freshRetrySignal` is only constructed when `timeout` is non-null (i.e. `timeoutMs` wasn't explicitly disabled), and only actually invoked by `fetchWithUnifiedRemint` if a 401 retry happens — a request that never gets a 401 pays no extra cost. - `src/scripts/api.ts`, `fetchApi()`: the new `freshRetrySignal` closure and its timer's cleanup in `.finally()` (no leaked timers on either the happy path or an error path). - `src/platform/auth/unified/remintRetry.ts`, `fetchWithUnifiedRemint()`: the retry `init` construction now branches on whether `freshRetrySignal` was supplied. - Confirmed the two other callers (`globalSettingsApi.ts`, `authStore.ts`) are unaffected — they don't pass a signal today, and the new parameter is optional and off by default. - `src/platform/auth/unified/remintRetry.test.ts`: new cases assert the retry `fetch` receives the object returned by `freshRetrySignal()` (not the original `init.signal`) when supplied, and that the callback is never called when no retry happens. - `src/scripts/api.fetchApi.test.ts`: new regression test with fake timers simulates a 401 → 55s re-mint → 30s retry sequence. Verified (via `git stash` of only the source changes, keeping the new tests) that both new tests fail against the pre-fix code — the retry test rejects with the abort from the stale signal at t=60s — and pass once the fix is restored. Fixes the pattern behind Sentry `CLOUD-FRONTEND-STAGING-4MF`/`CLOUD-FRONTEND-STAGING-4MG`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_0137jzrG6RSp5e6YgGp8kxdY --- _Generated by [Claude Code](https://claude.ai/code/session_0137jzrG6RSp5e6YgGp8kxdY)_ --------- Co-authored-by: dante01yoon <bunggl@naver.com> (cherry picked from commit e346ef9)
4171869 to
ca9aec9
Compare
|
The Generated by Claude Code |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.54 #18674 +/- ##
=============================================
Coverage ? 83.75%
=============================================
Files ? 2110
Lines ? 125154
Branches ? 31715
=============================================
Hits ? 104826
Misses ? 20149
Partials ? 179
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Automated backport of #18599 to
cloud/1.54, after the backport bot's automated cherry-pick attempt failed on a merge conflict.Summary
Cherry-picks e346ef9 (#18599) onto
cloud/1.54. That PR gives the unified-remint post-401 retry fetch a fresh timeout window instead of letting it inherit whatever was left of the original request's 60s deadline (SentryCLOUD-FRONTEND-STAGING-4MF/4MG).Conflict and resolution
src/scripts/api.tsandsrc/platform/auth/unified/remintRetry.tscherry-picked cleanly with no conflicts.src/scripts/api.fetchApi.test.tsconflicted because three other open PRs ([backport cloud/1.54] perf: cut lint and typecheck time and memory (manual, lint-staged, CI) #18644, [backport cloud/1.54] fix(agent-crdt): realign named input links across multiple autogrow groups #18479, [backport cloud/1.54] test: cover mouse-driven autogrow reference alignment #18370) are stacked oncloud/1.54touching the same file, and becausecloud/1.54's mocking setup for this file predates several refactors that already landed onmain(fromPartial/vi.mock(import(...))typed mocks, and afirebaseIdentityauth wrapper that doesn't exist oncloud/1.54). Resolved by keepingcloud/1.54's existing plainvi.mock('module', factory)style and layering in only the additions the newpost-401 retry timeout budgettest needs (thetrackUnifiedAuthRetrymock, themockDistribution/isCloudtoggle, auseFeatureFlagsmock, andvuefire/firebase/authstubs matching the convention already used inauthStore.test.ts), instead of pulling overmain's newer typed-mock plumbing verbatim.src/platform/auth/unified/remintRetry.test.ts's new test referenceduseWorkspaceAuthStore()directly (that'smain's current test style), butcloud/1.54's version of this file mocks the store via amockRemintconst instead and never importsuseWorkspaceAuthStore— fixed to usemockRemint.mockResolvedValue(...).src/scripts/api.ts's new retry-timeout breadcrumb called a bareaddBreadcrumb(...), but this file imports Sentry asimport * as Sentry from '@sentry/vue'— fixed toSentry.addBreadcrumb(...).Verification
pnpm vitest run src/scripts/api.fetchApi.test.ts src/platform/auth/unified/remintRetry.test.ts— 41/41 tests pass.pnpm exec eslinton the four touched files — clean (pre-existing, unrelatedapi.tslint findings elsewhere in the file are untouched by this diff).pnpm run typecheck(vue-tsc --noEmit) — clean.🤖 Generated with Claude Code
https://claude.ai/code/session_0137jzrG6RSp5e6YgGp8kxdY
Generated by Claude Code