Skip to content

[backport cloud/1.54] fix(agent-crdt): realign named input links across multiple autogrow groups - #18479

Merged
comfy-pr-bot merged 4 commits into
cloud/1.54from
backport-18275-to-cloud-1.54
Sep 24, 2026
Merged

comfy-pr-bot merged 4 commits into
cloud/1.54from
backport-18275-to-cloud-1.54

Conversation

@claude

@claude claude Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Backport of #18275 to cloud/1.54.

Manual backport: the automated backport bot hit cherry-pick conflicts and requested a manual one.

Conflict resolution notes

Verification

  • pnpm typecheck: clean
  • pnpm vitest run on the directly relevant suites (graphMutations.test.ts, dynamicWidgets.test.ts, linkStore.test.ts, nodeDataStore.test.ts, linkPresentationStore.test.ts, crdtSession.test.ts, agentNodeMaterializer.multiAutogrow.test.ts): 209 passed, 1 expected fail
  • eslint / oxlint on all changed files: clean

🤖 Generated with Claude Code

https://claude.ai/code/session_01XqLXka9Jsg8EMTYmsnZjjv


Generated by Claude Code

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 336ffb35-4226-400f-a657-2f5287bd1c85

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
billing-web-test Error Error Sep 24, 2026 4:44am UTC
1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 24, 2026 4:44am UTC

Request Review

@claude claude Bot added the backport Backporting a PR onto a release candidate label Sep 22, 2026
@github-actions
github-actions Bot requested a review from huang47 September 22, 2026 23:27
@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1944 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1923 / ❌ 0 / ⚠️ 2 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/24/2026, 04:45:57 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.7 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.1 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.1 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.1 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.8 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.9 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 148ms TBT · 82.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 90.2 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 164.5 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 100ms TBT · 164.0 MB heap
vue-node-resize-workload: · 56.2 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 478ms TBT · 170.8 MB heap
vue-zoom-out-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.9 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 566ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 64.7 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -182
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 32ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 77
canvas-mouse-sweep: task duration 929ms
canvas-mouse-sweep: script duration 168ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 63.1 MB
canvas-mouse-sweep: DOM nodes -279
canvas-mouse-sweep: event listeners -194
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 33
canvas-zoom-sweep: task duration 380ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.6 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 465ms
dom-widget-clipping: script duration 167ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 60.2 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 657ms
large-graph-idle: script duration 36ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 80.9 MB
large-graph-idle: DOM nodes -277
large-graph-idle: event listeners -177
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1727ms
large-graph-pan: script duration 836ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 73.1 MB
large-graph-pan: DOM nodes -266
large-graph-pan: event listeners -192
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1796ms
large-graph-zoom: script duration 804ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.1 MB
large-graph-zoom: DOM nodes -284
large-graph-zoom: event listeners -93
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1991ms
legacy-node-drag: script duration 973ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 86.8 MB
legacy-node-drag: DOM nodes -150
legacy-node-drag: event listeners 89
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 3
minimap-idle: task duration 627ms
minimap-idle: script duration 36ms
minimap-idle: TBT 0ms
minimap-idle: heap used 82.8 MB
minimap-idle: DOM nodes -141
minimap-idle: event listeners -94
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 419ms
subgraph-dom-widget-clipping: script duration 143ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.2 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 523ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 67.9 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -225
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 27ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 831ms
subgraph-mouse-sweep: script duration 113ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 64.9 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -212
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 1003ms
subgraph-transition-enter: script duration 33ms
subgraph-transition-enter: TBT 148ms
subgraph-transition-enter: heap used 82.9 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 35ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 6234ms
viewport-pan-sweep: script duration 2928ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 90.2 MB
viewport-pan-sweep: DOM nodes -271
viewport-pan-sweep: event listeners -146
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16758ms
vue-large-graph-idle: script duration 278ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 164.5 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14930
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 168
vue-large-graph-pan: task duration 20797ms
vue-large-graph-pan: script duration 954ms
vue-large-graph-pan: TBT 100ms
vue-large-graph-pan: heap used 164.0 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14928
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 26ms
vue-node-resize-workload: style recalc duration 85ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6125ms
vue-node-resize-workload: script duration 116ms
vue-node-resize-workload: TBT 478ms
vue-node-resize-workload: heap used 170.8 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14929
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8451ms
vue-zoom-out-idle: script duration 159ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 169.7 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -11
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 2
workflow-execution: style recalc count 7
workflow-execution: task duration 74ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.9 MB
workflow-execution: DOM nodes 127
workflow-execution: event listeners 17
Raw data
{
  "timestamp": "2026-09-24T04:55:34.722Z",
  "gitSha": "c4ee2c5dc6fa7a8e2e3e84273b6a897fc332940d",
  "branch": "backport-18275-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2062.6909999999725,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.986999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 582.5659999999999,
      "heapDeltaBytes": 4260172,
      "heapUsedBytes": 75188260,
      "domNodes": -279,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 9.086,
      "eventListeners": -168,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2054.0490000000773,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.836999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 548.845,
      "heapDeltaBytes": -10052516,
      "heapUsedBytes": 60524008,
      "domNodes": -282,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 10.466,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1896.7519999999922,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 32.168,
      "layouts": 14,
      "layoutDurationMs": 4.361000000000001,
      "taskDurationMs": 905.178,
      "heapDeltaBytes": -2977960,
      "heapUsedBytes": 67183656,
      "domNodes": -278,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 164.45399999999998,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1888.6869999998908,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 32.239000000000004,
      "layouts": 14,
      "layoutDurationMs": 4.234,
      "taskDurationMs": 951.8330000000002,
      "heapDeltaBytes": -5186928,
      "heapUsedBytes": 65232732,
      "domNodes": -280,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 172.008,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1720.782999999983,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 16.479,
      "layouts": 6,
      "layoutDurationMs": 0.9609999999999999,
      "taskDurationMs": 361.283,
      "heapDeltaBytes": 4666232,
      "heapUsedBytes": 75690396,
      "domNodes": 78,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 11.223,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1738.3370000000014,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 18.16,
      "layouts": 6,
      "layoutDurationMs": 1.1869999999999998,
      "taskDurationMs": 397.913,
      "heapDeltaBytes": 4271544,
      "heapUsedBytes": 74398996,
      "domNodes": 77,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 13.552999999999995,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 671.0299999999734,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.433999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 455.48300000000006,
      "heapDeltaBytes": -7841916,
      "heapUsedBytes": 63012820,
      "domNodes": 18,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 164.958,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 716.4020000000164,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.589,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 474.94100000000003,
      "heapDeltaBytes": -7878876,
      "heapUsedBytes": 63177180,
      "domNodes": 16,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 168.811,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2041.7380000000094,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.7820000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 609.6460000000001,
      "heapDeltaBytes": 10374376,
      "heapUsedBytes": 86794288,
      "domNodes": -274,
      "jsHeapTotalBytes": -2199552,
      "scriptDurationMs": 36.54600000000001,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2072.3230000000967,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.745000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 703.5330000000001,
      "heapDeltaBytes": 6172376,
      "heapUsedBytes": 82911760,
      "domNodes": -279,
      "jsHeapTotalBytes": -626688,
      "scriptDurationMs": 34.96500000000001,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2380.8239999999614,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.492000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1723.136,
      "heapDeltaBytes": 7605336,
      "heapUsedBytes": 85041456,
      "domNodes": -247,
      "jsHeapTotalBytes": 122880,
      "scriptDurationMs": 856.812,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2357.8849999998965,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.188999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1729.971,
      "heapDeltaBytes": -8810932,
      "heapUsedBytes": 68298760,
      "domNodes": -285,
      "jsHeapTotalBytes": 684032,
      "scriptDurationMs": 816.1310000000001,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3666.2390000000187,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 13.417000000000002,
      "layouts": 60,
      "layoutDurationMs": 12.406,
      "taskDurationMs": 1819.747,
      "heapDeltaBytes": -4569248,
      "heapUsedBytes": 74485348,
      "domNodes": -289,
      "jsHeapTotalBytes": 4091904,
      "scriptDurationMs": 800.015,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3652.0009999999274,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.993000000000002,
      "layouts": 60,
      "layoutDurationMs": 11.943999999999999,
      "taskDurationMs": 1772.824,
      "heapDeltaBytes": 9188008,
      "heapUsedBytes": 76652320,
      "domNodes": -279,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 807.355,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3112.7749999999423,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.782000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1951.509,
      "heapDeltaBytes": 25985576,
      "heapUsedBytes": 94399588,
      "domNodes": -11,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 957.6210000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3190.699999999879,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 6.914,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2030.6850000000002,
      "heapDeltaBytes": 6965812,
      "heapUsedBytes": 87677824,
      "domNodes": -288,
      "jsHeapTotalBytes": 53248,
      "scriptDurationMs": 987.8509999999999,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2048.665000000028,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 6.461999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 659.327,
      "heapDeltaBytes": 7280216,
      "heapUsedBytes": 85721008,
      "domNodes": -272,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 35.157999999999994,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2006.7320000000564,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.8749999999999973,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 594.5140000000001,
      "heapDeltaBytes": 21783544,
      "heapUsedBytes": 87845972,
      "domNodes": -9,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 36.669000000000004,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 593.7400000000252,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.817,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 412.662,
      "heapDeltaBytes": 14743268,
      "heapUsedBytes": 88075108,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 142.45999999999998,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 605.8000000000447,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 12.278,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 426.071,
      "heapDeltaBytes": 13757260,
      "heapUsedBytes": 86455924,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 144.387,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.7120000000932,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.194,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 494.939,
      "heapDeltaBytes": 1529228,
      "heapUsedBytes": 74857928,
      "domNodes": -295,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 8.650000000000002,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.160999999869,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.77,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 550.352,
      "heapDeltaBytes": -5742136,
      "heapUsedBytes": 67620368,
      "domNodes": -295,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 10.408000000000001,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1723.5500000000457,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 26.827,
      "layouts": 18,
      "layoutDurationMs": 4.526000000000001,
      "taskDurationMs": 809.9399999999999,
      "heapDeltaBytes": 5463080,
      "heapUsedBytes": 78783324,
      "domNodes": -296,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 110.552,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1736.2140000000181,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 28.119999999999997,
      "layouts": 18,
      "layoutDurationMs": 4.699,
      "taskDurationMs": 851.165,
      "heapDeltaBytes": -15492696,
      "heapUsedBytes": 57297688,
      "domNodes": -296,
      "jsHeapTotalBytes": 7069696,
      "scriptDurationMs": 114.75200000000001,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1418.0199999999559,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 31.954000000000004,
      "layouts": 16,
      "layoutDurationMs": 15.774,
      "taskDurationMs": 1002.813,
      "heapDeltaBytes": -9094556,
      "heapUsedBytes": 86962984,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 32.88,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 148,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9198.298000000023,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 35.092999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6345.632,
      "heapDeltaBytes": 22602228,
      "heapUsedBytes": 99330108,
      "domNodes": -271,
      "jsHeapTotalBytes": -958464,
      "scriptDurationMs": 3054.6530000000002,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8890.480999999909,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 35.709,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6122.979000000001,
      "heapDeltaBytes": 13319328,
      "heapUsedBytes": 89890804,
      "domNodes": -270,
      "jsHeapTotalBytes": -925696,
      "scriptDurationMs": 2801.315,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17210.932999999954,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16671.832,
      "heapDeltaBytes": -71761140,
      "heapUsedBytes": 166357344,
      "domNodes": -8068,
      "jsHeapTotalBytes": -18001920,
      "scriptDurationMs": 276.926,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17411.293999999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16845.008,
      "heapDeltaBytes": -33212652,
      "heapUsedBytes": 178629184,
      "domNodes": -8068,
      "jsHeapTotalBytes": -9187328,
      "scriptDurationMs": 278.52099999999996,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20926.86900000001,
      "styleRecalcs": 168,
      "styleRecalcDurationMs": 18.411000000000012,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20515.962,
      "heapDeltaBytes": -39239816,
      "heapUsedBytes": 178902672,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10235904,
      "scriptDurationMs": 935.028,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 37,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21427.392000000054,
      "styleRecalcs": 167,
      "styleRecalcDurationMs": 19.957,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21078.99,
      "heapDeltaBytes": -53162404,
      "heapUsedBytes": 165011456,
      "domNodes": -8068,
      "jsHeapTotalBytes": -11022336,
      "scriptDurationMs": 972.1829999999999,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 163,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6202.643999999964,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 78.71799999999996,
      "layouts": 20,
      "layoutDurationMs": 23.366,
      "taskDurationMs": 6094.0120000000015,
      "heapDeltaBytes": -38985272,
      "heapUsedBytes": 178395348,
      "domNodes": -8068,
      "jsHeapTotalBytes": 12046336,
      "scriptDurationMs": 116.81599999999999,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 428,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6272.2080000000915,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 92.167,
      "layouts": 20,
      "layoutDurationMs": 28.876000000000012,
      "taskDurationMs": 6155.599999999999,
      "heapDeltaBytes": -38314148,
      "heapUsedBytes": 179709532,
      "domNodes": -8068,
      "jsHeapTotalBytes": 13602816,
      "scriptDurationMs": 115.173,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 527,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8707.470000000058,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8408.998,
      "heapDeltaBytes": 22452168,
      "heapUsedBytes": 178946408,
      "domNodes": 0,
      "jsHeapTotalBytes": -6029312,
      "scriptDurationMs": 141.58899999999997,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8914.248000000043,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8492.350999999999,
      "heapDeltaBytes": 17138564,
      "heapUsedBytes": 176966232,
      "domNodes": 0,
      "jsHeapTotalBytes": -16252928,
      "scriptDurationMs": 175.82799999999997,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 104.82300000001032,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 14.338000000000001,
      "layouts": 2,
      "layoutDurationMs": 1.15,
      "taskDurationMs": 77.268,
      "heapDeltaBytes": 3081004,
      "heapUsedBytes": 72211520,
      "domNodes": 128,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 8.543999999999999,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 105.43699999993805,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 15.199,
      "layouts": 2,
      "layoutDurationMs": 1.264,
      "taskDurationMs": 70.26899999999999,
      "heapDeltaBytes": 2991084,
      "heapUsedBytes": 72375876,
      "domNodes": 126,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 5.467,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50509 75722 66.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.6% 275
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.4% 260
src/scripts/pnginfo.ts 21.4% 221

@claude

claude Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor Author

The "Check for AI agent co-author trailers" check is failing on commit fbbaba3be8b because of one trailer line: Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>.

Fixing this needs a git history reword (git rebase -i to drop that trailer line, then force-push) — destructive history rewrites are outside what this session's permission system allows, the same blocker #18275 hit earlier (which DrJKL resolved by pushing the reword directly). A human with push access to this branch will need to do the same here.


Generated by Claude Code

@datadog-official

This comment has been minimized.

@codecov

codecov Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.61303% with 49 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../workbench/extensions/agent/crdt/graphMutations.ts 92.62% 25 Missing ⚠️
src/workbench/extensions/agent/AgentPanelRoot.vue 0.00% 10 Missing ⚠️
src/core/graph/widgets/dynamicWidgets.ts 65.21% 8 Missing ⚠️
src/stores/nodeDataStore.ts 84.84% 5 Missing ⚠️
src/stores/linkStore.ts 96.42% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #18479   +/-   ##
=============================================
  Coverage              ?   83.78%           
=============================================
  Files                 ?     2112           
  Lines                 ?   125591           
  Branches              ?    34000           
=============================================
  Hits                  ?   105223           
  Misses                ?    20189           
  Partials              ?      179           
Flag Coverage Δ
e2e 66.71% <40.67%> (?)
unit 78.86% <91.42%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...form/workflow/validation/schemas/workflowSchema.ts 97.53% <100.00%> (ø)
src/stores/linkPresentationStore.ts 100.00% <100.00%> (ø)
.../extensions/agent/crdt/__fixtures__/crdtSession.ts 97.95% <100.00%> (ø)
...agent/crdt/__fixtures__/multiAutogrowInputOrder.ts 100.00% <100.00%> (ø)
.../workbench/extensions/agent/crdt/docFrameClient.ts 98.88% <100.00%> (ø)
...ench/extensions/agent/crdt/liveWidgetProjection.ts 92.45% <100.00%> (ø)
src/stores/linkStore.ts 99.02% <96.42%> (ø)
src/stores/nodeDataStore.ts 91.90% <84.84%> (ø)
src/core/graph/widgets/dynamicWidgets.ts 92.82% <65.21%> (ø)
src/workbench/extensions/agent/AgentPanelRoot.vue 90.10% <0.00%> (ø)
... and 1 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 23, 2026
christian-byrne pushed a commit that referenced this pull request Sep 23, 2026
… workflow connections after dynamic input reordering (#18509)

<!-- ccr-slack-attribution -->
_Requested by **Christian Byrne** · [Slack
thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790128455751879?thread_ts=1789965317.152049&cid=C0BGH348Z0C)_

## Summary

Manual backport of #17221 to `core/1.54`. Christian asked for this
directly in Slack to unblock backporting #18479 (the `cloud/1.54`
counterpart of #18275), which depends on #17221's name-based CRDT
input-targeting architecture that `core/1.54` currently lacks (it
resolves inputs positionally). An automated backport was not attempted
since this was a deliberately-requested manual op.

Original PR #17221: "MiniMax template wiring (PM-993): preserve agent
workflow connections after dynamic input reordering." Fixes
[PM-993](https://linear.app/comfy-org/issue/PM-993): document links
could target the wrong MiniMax input after node configuration or
autogrow changed the live input order. Resolves document input targets
by name (not position) during initial materialization, reconcile, and
remote connect; preserves live order/extra inputs when every document
input name exists live; keeps outputs index-based. See
`docs/adr/CRDT-INPUTS-0030-preserve-named-input-targets.md`.

## Conflict resolution notes

- `docs/adr/README.md`: inserted the new `CRDT-INPUTS-0030` row into
`core/1.54`'s existing ADR index in alphabetical order, rather than
importing `main`'s full index (`core/1.54` doesn't carry the many other
ADRs added on `main` since it branched).
- `src/workbench/extensions/agent/crdt/graphMutations.test.ts`:
adjacent-import conflict only, kept both sides' new imports.
- `src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts`:
the conflict's "theirs" side pulled in
`BatchOutcome`/`DocFrameTransport` imports that actually predate #17221
on `main` (added by a separate, still-unbackported PR) and have no
corresponding usage in this file on `core/1.54`. Kept only the
`GraphOperation` import #17221 itself adds (used by the `enqueue`-wiring
hunk); dropped the other two as unused (`vue-tsc` TS6133) rather than
smuggling in that unrelated PR's imports.
- `src/workbench/extensions/agent/crdt/graphMutations.ts` and
`agentNodeMaterializer.ts`: applied cleanly, no conflicts.

## Dropped from this backport (not present, and not required, on
`core/1.54`)

- `browser_tests/fixtures/agentConversationFixture.ts` (modified) and
`browser_tests/tests/agent/agentConversationReplay.spec.ts` (added):
this E2E spec and its fixture edit depend on agent-conversation E2E
harness infrastructure from other PRs never backported to `core/1.54` —
the fixture file itself doesn't exist on this branch at all. Dropping it
doesn't affect the runtime fix; it's Playwright coverage only.
- `browser_tests/fixtures/data/minimaxAutogrowReload.ts` and
`browser_tests/fixtures/utils/minimaxAutogrowReload.ts` (both added):
fixture data/utilities consumed exclusively by the spec above; dropped
as dead code once that spec was dropped.

All runtime code (`graphMutations.ts`, `agentNodeMaterializer.ts`) and
all Vitest unit coverage for the CRDT input-targeting logic
(`graphMutations.test.ts`, the new
`agentNodeMaterializer.inputOrder.test.ts` + its new fixtures,
`nodeDataStore.test.ts`, `useAgentCrdtFollower.test.ts`) are included,
unchanged in substance from #17221.

## Verification

- `pnpm typecheck` — clean
- `pnpm lint` on the changed files (`eslint` directly; full-repo `pnpm
lint` hit an unrelated OOM kill on this container's `oxlint`
vitest-cleanup pass, not caused by this diff) — clean
- `pnpm format:check` — clean, all matched files correctly formatted
- `pnpm test:unit` on the directly relevant suites
(`graphMutations.test.ts`, `agentNodeMaterializer.inputOrder.test.ts`,
`useAgentCrdtFollower.test.ts`, `nodeDataStore.test.ts`) — 4 test files
passed (4), 146 tests passed, 1 expected fail. (An unrelated,
pre-existing failure in `AgentPanelRoot.test.ts` — a file this backport
never touches — showed up when `pnpm test:unit` was run without file
filtering in this environment; it is a happy-dom
`Blob.stream`/iframe-loading quirk in media-upload tests, confirmed
unrelated by running the four target files directly.)

## Does this unblock #18275's own core/1.54 backport?

Partially. Landing this PR removes the primary architectural blocker:
`core/1.54` will have
`mergeInputSlotsByName`/`resolveConnectTargetInputs` and the rest of the
name-based input-targeting rework that #18275 builds directly on top of
(its own PR body calls out
`mergeInputSlotsByName`/`hasNonGrowthInputSetChange` in
`graphMutations.ts` as the base it extends).

However, `core/1.54` has at least one more gap of the same shape that
the `cloud/1.54` backport (#18479) also hit: it's missing
`src/stores/linkPresentationStore.ts` and
`src/types/linkPresentation.ts` (introduced by a separate,
still-unbackported PR), which #18275's `graphMutations.ts` diff uses to
preserve link presentation across a replace/displace. `core/1.54` is
also still missing `browser_tests/fixtures/agentConversationFixture.ts`,
same as `cloud/1.54`.

So #18275's `core/1.54` backport won't be a fully clean cherry-pick once
this lands — it will need the same kind of targeted fix #18479 already
proved out for `cloud/1.54` (porting
`linkPresentationStore.ts`/`linkPresentation.ts` + their unit test from
`main`, and dropping the `agentConversationFixture`-dependent E2E spec).
But it removes the one prerequisite this task was scoped to: the base
architecture #18275 assumes is now present.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01XqLXka9Jsg8EMTYmsnZjjv

Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com>
@claude

claude Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

Investigated the playwright-tests (cloud) timeout (timed out twice at the 15-min budget, runs 35810479712 originally and its one re-run). Root-cause findings:

  • The cancelled run's blob report was destroyed by the hard cancel, so CI logs alone can't name the specific failing/slow tests — the dot-reporter's ×/T markers in the log are position-only, not attributable to test names.
  • Config review: the cloud project differs from chromium only by a tag filter (grep: /@cloud/) — same 15s default timeout, fully-mocked backend like every other shard. It is not hitting a real remote cloud backend.
  • This PR's only new @cloud test (agentCrdtMultiAutogrowRealign.spec.ts, 2 tests) uses custom 90s/120s timeouts; combined with the project's retries: 3, a genuinely flaky instance could burn most of the 15-min budget on one worker — a plausible but unconfirmed hypothesis.
  • Tried to reproduce locally with --project=cloud agentCrdtMultiAutogrowRealign --repeat-each=5 in this sandbox: all 10 runs failed identically at fixture setup (45s timeout waiting for the "Ask Comfy Agent" button) before reaching either test's own assertions — a 100%-repro boot/feature-flag-gate stall specific to this sandbox environment, not an intermittent CRDT-specific failure. So the local run is inconclusive either way on the flake hypothesis.
  • Cross-check: other unrelated backport PRs against the same base branch complete their regular chromium-sharded jobs in 10-12 minutes on this CI infra, suggesting the suite already runs close to the wall-clock limit generally.

No code fix pushed — I don't have a confirmed, fixable defect, only an unconfirmed hypothesis, and the one allowed CI re-run already destroyed the evidence needed to confirm it. Recommend a maintainer with a full CI-equivalent environment re-run --project=cloud agentCrdtMultiAutogrowRealign --repeat-each=5 to get a clean signal, and separately consider whether the cloud shard's 15-minute budget needs revisiting given it's now timed out twice.


Generated by Claude Code

christian-byrne pushed a commit that referenced this pull request Sep 24, 2026
… window (#18674)

<!-- ccr-slack-attribution -->
Automated backport of #18599 to `cloud/1.54`, after the backport bot's
automated cherry-pick attempt failed on a merge conflict.

## Summary

Cherry-picks e346ef9 (#18599) onto
`cloud/1.54`. That PR gives the unified-remint post-401 retry fetch a
fresh timeout window instead of letting it inherit whatever was left of
the original request's 60s deadline (Sentry
`CLOUD-FRONTEND-STAGING-4MF`/`4MG`).

## Conflict and resolution

- `src/scripts/api.ts` and `src/platform/auth/unified/remintRetry.ts`
cherry-picked cleanly with no conflicts.
- `src/scripts/api.fetchApi.test.ts` conflicted because three other open
PRs (#18644, #18479, #18370) are stacked on `cloud/1.54` touching the
same file, and because `cloud/1.54`'s mocking setup for this file
predates several refactors that already landed on `main`
(`fromPartial`/`vi.mock(import(...))` typed mocks, and a
`firebaseIdentity` auth wrapper that doesn't exist on `cloud/1.54`).
Resolved by keeping `cloud/1.54`'s existing plain `vi.mock('module',
factory)` style and layering in only the additions the new `post-401
retry timeout budget` test needs (the `trackUnifiedAuthRetry` mock, the
`mockDistribution`/`isCloud` toggle, a `useFeatureFlags` mock, and
`vuefire`/`firebase/auth` stubs matching the convention already used in
`authStore.test.ts`), instead of pulling over `main`'s newer typed-mock
plumbing verbatim.
- Also fixed two latent issues surfaced while getting the cherry-picked
tests to actually pass on this branch (not part of the original PR's
intent, but required for the cherry-pick to work):
- `src/platform/auth/unified/remintRetry.test.ts`'s new test referenced
`useWorkspaceAuthStore()` directly (that's `main`'s current test style),
but `cloud/1.54`'s version of this file mocks the store via a
`mockRemint` const instead and never imports `useWorkspaceAuthStore` —
fixed to use `mockRemint.mockResolvedValue(...)`.
- `src/scripts/api.ts`'s new retry-timeout breadcrumb called a bare
`addBreadcrumb(...)`, but this file imports Sentry as `import * as
Sentry from '@sentry/vue'` — fixed to `Sentry.addBreadcrumb(...)`.

## Verification

- `pnpm vitest run src/scripts/api.fetchApi.test.ts
src/platform/auth/unified/remintRetry.test.ts` — 41/41 tests pass.
- `pnpm exec eslint` on the four touched files — clean (pre-existing,
unrelated `api.ts` lint findings elsewhere in the file are untouched by
this diff).
- `pnpm run typecheck` (`vue-tsc --noEmit`) — clean.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_0137jzrG6RSp5e6YgGp8kxdY

---
_Generated by [Claude
Code](https://claude.ai/code/session_0137jzrG6RSp5e6YgGp8kxdY)_

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: dante01yoon <bunggl@naver.com>
claude Bot and others added 4 commits September 24, 2026 04:39
…roups (#18275)

<!-- ccr-slack-attribution -->
_Requested by **Christian Byrne** · [Slack
thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789965317152049?thread_ts=1789965317.152049&cid=C0BGH348Z0C)_

Fixes agent-authored nodes with more than one autogrow group (e.g. a
reference node with separate image and video reference groups) losing
track of which wire goes where after the agent chat materializes the
node.

**Before:** For a node like `MiniMaxH3ReferenceToVideo`, which has two
independent autogrow groups (`ref_images`, `ref_videos`) alongside
scalar widgets (`width`, `height`, `length`, `ref_image_size`), both the
agent panel and the canvas painted wires onto the wrong inputs after the
node was built or reopened — a Load Image could land on
`ref_image_size`, a text input on `length`, a Math node on `ref_videos`,
and `width`/`height` could show as `0`. The server's own view of the
graph was correctly wired, so pressing Run submitted the client's
shifted (wrong) values and failed with type errors that didn't actually
exist. Reopening the tab reconstructed the slots differently each time.

**After:** For a document that is already correctly wired, projecting it
onto the live canvas now lands every wire on the input it was actually
connected to, and the value submitted on Run matches what's shown on
canvas, regardless of how many autogrow groups the node has or how their
growth interleaves with each other and with the node's scalar widgets.
This covers the document-to-live projection direction only; the outbound
leg (minting a link back into the host document) can still corrupt a
node's addressing before this projection ever runs on it — see "Known
issue" below and #18332.

- **What**: `node.configure()` and autogrow growth (`COMFY_AUTOGROW_V3`)
can reorder or insert a node's live inputs after the agent CRDT follower
has already built its link adapters against the saved document's input
*positions*. With one autogrow group this only shifts a couple of
neighboring scalar widgets; with two or more groups growing on the same
node, the drift compounds across the whole input list. The fix re-points
the follower's link adapters, and the incoming reconcile/connect
handling, at the input with the same *name* as the saved slot, instead
of the same index — reusing the link realignment ordinary node loading
already relies on, and extending the reconcile/connect path to resolve
by name. A live-only input (one no document occurrence matches) is
retained, rather than dropped along with the rest of the document's
positional replacement, only when it classifies as a real autogrow group
member — via a live query, this follower's own remembered answer, the
node type's static `COMFY_AUTOGROW_V3` definition, or (last resort) the
name-shape heuristic; a genuine removal still lets the document win.
Duplicate input names on one node are matched pairwise by occurrence
(the Nth document occurrence against the Nth live occurrence), not by
first match. Node-data-store slot arrays are now refilled in place
rather than reassigned, so any reactive view already holding that array
keeps its identity across a resync.
- **How**: Added a regression fixture and CRDT-follower test modeled on
a node with two interleaved autogrow groups plus adjacent scalar widgets
(the shape a single-group fixture can't exercise) — confirmed it fails
on the unfixed code, then confirmed the by-name realignment above
(generalized, not per-pair) makes it pass without further
special-casing.

The live-node autogrow-membership port collapsed "the live node can't
answer yet" and "the live node answered no" into the same `undefined`,
so an activate/resubscribe race could drop an explicit-name autogrow
spare. The port now returns a tagged `unavailable`/`member`/`notMember`
result and only the last two are authoritative. When the port is
`unavailable`, provenance falls back in this order: this follower's own
remembered live answer, then the node type's own static
`COMFY_AUTOGROW_V3` definition, and only then the name-shape heuristic.
The membership classification against a static schema (explicit `names`
list vs. trailing ordinal) is one predicate shared with
`dynamicWidgets.ts`'s live registration rather than a second
implementation.

`graphMutations.ts`)

The remembered answers are addressable only from the node incarnation
that produced them:

- **Graph scope in the key.** One `GraphMutations` instance is retained
per cloud workflow while resolving the current local workflow's scope on
every batch, so the key is `rootGraphId` + `owningGraphId` + node id for
remember, read and forget alike.
- **Per-mutation transactional writes.** `batch()` opens a draft before
`prepare()`; every `member`/`notMember` write and forget (replace,
`deleteNode`, `removeMissing`, `clearSemanticGraph`) is staged into that
draft, journaled under the mutation that produced it. `commit()` applies
one mutation's journaled writes to the persisted store immediately after
that mutation's own graph effect lands, and only when that effect
actually landed — a `connect` whose `replaceLink` returns `undefined` (a
stale expected occupant, an ID collision, or a newly-occupied target)
never publishes the write it staged. A later mutation in the same batch
throwing therefore still keeps every earlier mutation's already-applied
write, and a `prepare()` rejection leaves the persisted store completely
untouched. Within `prepare()` itself, a mutation can still see an
earlier mutation's own staged (not yet committed) answer for the same
node — its pending overlay chains onto the nearest earlier-indexed
mutation's still-pending one, so two mutations prepared back to back in
one batch agree on the same name's classification — but nothing outside
that single `prepare()`/`commit()` pass, including a later batch's own
`currentView()` reads, ever sees a same-batch mutation's answer before
its own `commit()` iteration actually applies it.
- **Definition-identity revalidation.** Each entry stores the
`ComfyNodeDefImpl` it was answered against; a re-registration under the
same type name constructs a new one, so the current definition always
beats stale memory. Node type is still part of the entry for the case
where another writer changes a node's type without this instance
observing it.

Also fixed a real race in the turn step: `agentConversationStore.ingest`
only routes `agent_message_done` while the store already holds the ack's
`message_id`, so the host must not answer before the assistant
placeholder `startTurn` renders, or the turn hangs on a live Stop button
forever.

`agentCrdtMultiAutogrowRealign.spec.ts` sets sentinel widget values
through the UI and inspects the submitted-prompt payload by name across
three scenarios: a same-page tab-switch resubscribe, an actual
save-and-reload of the same workflow, and a reload of a workflow whose
saved bytes were corrupted after the save. The tab-switch case fills its
sentinels *before* switching tabs and re-verifies those same values
afterward, so a reconcile that resets or shifts an existing scalar
during replay fails it, not just one that mis-wires a link.

Three defects in the reload path (the second and third scenarios) are
fixed here:

- `mockSavedWorkflowPersistence` never served the `GET
/api/userdata?dir=workflows&...` listing (its `**/api/userdata/*`
pattern cannot match a URL with no path segment after `userdata`), so
after a reload `workflowStore`'s `syncEntities` saw an empty listing,
dropped the saved path from `openWorkflowPaths`, and the agent panel's
workflow picker — which lists `openWorkflows` — came up **empty**. The
reopen step then waited on a menu item that could never appear. This is
the state the hosted runs were failing in; no timeout could help.
- The saved-path GET counter route could never match an
`encodeURIComponent`-encoded userdata path
(`/api/userdata/workflows%2F<name>.json`), so the "the reopen really
read the file" assertion polled a counter stuck at zero. It is now
counted inside the persistence mock, and only for GETs it actually
answered from retained saved bytes.
- Saving under the default `Unsaved Workflow` name made the reopen
indistinguishable from the fresh tab a reload always offers; it now
saves under an explicit name through the Save As UI.

**Spec structure.** The 506-line free-standing scenario function is
replaced by a fixture-owned harness
(`browser_tests/fixtures/helpers/MultiAutogrowRealignHarness.ts`,
registered via `browser_tests/fixtures/multiAutogrowRealignFixture.ts`),
per `browser_tests/README.md`. The spec file now contains only imports,
`test.describe`, `test.describe.configure` and three `test()` bodies
whose acts and assertions read in order. Per-test budgets drop from 240s
to 90s/120s/120s.

With the empty picker fixed, the second-turn reattach case reaches its
assertions for the first time and fails deterministically: after save →
reload → reattach, a link is dropped with
`error_reconciling_agent_incompatible_link_type`. The live graph is
correct (origin `VIDEO`, target `VIDEO`); the **host document** is not —
node 2's doc inputs are in document name order (`prompt` at index 4,
`ref_videos.ref_video_1` at index 7) but the link values were written by
LIVE position, so `"link": 204` sits on the `prompt` (`STRING`) input
and the link tuple reads `[204, 1, 3, 2, 4, "VIDEO"]`.
`excludeIncompatibleLinks` then correctly refuses it.

That is the same positional-vs-named confusion this PR fixes on the
inbound path, occurring on the page → host doc leg through the real
`applyOps` from `@comfyorg/comfy-multi-player`. Fixing it means changing
the mint/outbound leg, which is a different code path needing its own
design and regressions.

**This defect is NOT covered by this PR.** It is not exercised by
`agentCrdtMultiAutogrowRealign.spec.ts` (verifies the inbound/reconcile
path only) and it is not exercised by
`agentFollowerReloadBinding.spec.ts` either — that spec reattaches an
ordinary scalar widget edit on a single-input node, never a
multi-autogrow node, and never mints an outbound link at all. Rather
than ship a red test or weaken an assertion in this PR, the reproduction
is tracked separately with a real failing unit test: #18332 (branch
`test/agent-crdt-outbound-link-position-bug`,
`src/workbench/extensions/agent/crdt/linkMintOutboundPositionCorruption.test.ts`).

- `realignInputLinkSlots` (already used by ordinary graph loading) is
now also invoked after agent materialization; it iterates all of a
node's named links in passes, so it isn't limited to a single autogrow
group.
- `mergeInputSlotsByName`/`hasNonGrowthInputSetChange` in
`graphMutations.ts`: a live-only input only survives when it is a
widget-promoted input slot (the wire format never carries one as a named
input either way) or classifies as an autogrow group member (and, unless
the caller opts into `preserveLinkedAutogrow`, is unlinked); any other
live-only input means the whole input set changed, and the document's
list and order replace it positionally. See
`docs/adr/CRDT-INPUTS-0030-preserve-named-input-targets.md` for the full
rule.
- `createAutogrowMemory`'s read contract: an entry is trusted only when
the graph scope, the node type, and the node definition object all still
match. Its writes are gated on the producing mutation's own commit
result — see "Autogrow memory lifecycle" above.

- [x] **Red/green on each of the cache and commit-ordering blockers.**
Each fix was reverted in isolation and the matching case confirmed to
fail, then restored:
- dropping the graph scope from the key fails `does not let one graph
scope read another scope's remembered autogrow answer on the same
GraphMutations instance`
- making `remember()` write straight to the real map fails `does not
leak the live answer a rejected batch resolved while preparing`
- dropping the `nodeDef` identity clause fails `prefers a re-registered
node definition over an autogrow answer remembered under the definition
it replaced`
- dropping the `nodeType` clause fails `does not apply a remembered
autogrow answer to a node id another writer has since given a different
type`
- moving `beginMutation` back to prepare-only fails `journals a connect
mutation's commit-time autogrow answer under its own index, not the
batch's last-prepared one`
- removing the `committed` gate on `connect`'s memory publication fails
`does not publish a connect mutation's staged autogrow answer when its
own replaceLink fails to land`
- reverting `refillArray` to a spread-based `splice` fails `updateNode
refills a slot list long enough to overflow a spread-based splice,
without changing array identity`
- **(round 8)** ordering `nodeStore.registerNode()` before
`deps.layout.createNode()` (the pre-fix shape) fails `keeps an earlier
mutation's remembered autogrow answer when a later mutation in the same
batch throws`'s new node-3-absence assertion
- **(round 8)** reverting the autogrow-memory draft to a single shared
`shadow` (no per-mutation pending overlay / `rollbackMutation`) fails
`does not leak a failed connect's staged autogrow answer to a later
connect in the same batch`
- **(round 9)** deleting the incumbent before `deps.layout.createNode()`
in a type-changing `replaceNode` (the pre-fix shape) fails `keeps the
incumbent node fully intact when a type-changing replace throws creating
its layout`
- **(round 9)** reverting `currentView` to check only the current
mutation's own pending overlay and the confirmed shadow fails `lets a
mutation see an earlier mutation's still-pending autogrow answer from
the same batch`, while `does not leak a failed connect's staged autogrow
answer to a later connect in the same batch` (round 8) keeps passing
under the fixed, chained version
- **(round 9)** restoring `preserveLinkedAutogrow`'s blanket
non-plain-object early return fails `drops a linked, non-plain runtime
slot the document dropped, even with preserveLinkedAutogrow set`
- **(round 9)** removing the new widget-promoted-slot exception fails
`retains a widget-promoted input slot no document snapshot ever lists`,
and (caught only by the full suite, not this file's own unit tests)
regresses `agentNodeMaterializer.inputOrder.test.ts`'s `preserves named
targets when an agent reconnect follows growth that moves width`
- [x] `pnpm exec vue-tsc --noEmit` and `pnpm exec vue-tsc --noEmit -p
browser_tests/tsconfig.json` — clean
- [x] `pnpm oxlint` (type-aware, whole repo) — no new warnings on
`graphMutations.ts`/`nodeDataStore.ts`; `pnpm exec eslint
src/workbench/extensions/agent/crdt/graphMutations.ts
src/workbench/extensions/agent/crdt/graphMutations.test.ts
src/stores/nodeDataStore.ts src/stores/nodeDataStore.test.ts` — clean;
`pnpm exec oxfmt --check .` — clean; `pnpm knip` — clean
- [x] `pnpm fallow audit --base origin/main` — `complexity_introduced:
2`, `dead_code_introduced: 0`, `duplication_introduced: 0`; the 2
introduced complexity findings are `LGraphCanvas.deselectAll` and
`widgetMap.adoptConcreteWidget`, neither touched this round or by this
PR — `graphMutations.ts`'s own `prepare`/`commit` findings are still
`introduced: false` (pre-existing baseline). The overall verdict is
`fail` only from those two plus unrelated inherited styling/complexity
drift on `main` since this branch's base; nothing under
`src/workbench/extensions/agent/crdt/` or `src/stores/nodeDataStore.ts`
is newly introduced.
- [x] `pnpm vitest run src/workbench/extensions/agent/crdt/
src/stores/nodeDataStore.test.ts` — 57 files, **885 passed, 5 expected
fail**
- [ ] The browser spec reorder (fill-then-switch-then-reverify) was not
re-executed locally this round — this session had no dev server or
backend available. It only reorders existing `test.step`s around
already-existing harness methods (`fillSentinelWidgetValues`,
`expectSentinelWidgetValues`, `switchTabsAwayAndBack`), with no new
harness API surface, and typechecks clean. Hosted CI is the authority
for this file, as it was for the prior round's own claim.

**Known CI blocker (not addressed here):** `Check for AI agent co-author
trailers` fails on 2 pre-existing commits on this branch that need a
history rewrite (rewording). Destructive git history operations are
outside what this session's own permission system allows regardless of
reviewer sign-off; a human with push access to this branch needs to do
that reword directly.

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: bymyself <cbyrne@comfy.org>
Co-authored-by: Amp <amp@ampcode.com>

Automated backport of #18275 hit cherry-pick conflicts; resolved manually:

- browser_tests/fixtures/agentConversationFixture.ts: dropped from this
  backport. The file doesn't exist on cloud/1.54 (added by the still-
  unbackported #17875) and nothing on this branch imports it, including
  the new agentCrdtMultiAutogrowRealign.spec.ts.
- src/lib/litegraph/src/LGraphCanvas.ts (selectItems): kept cloud/1.54's
  existing body. The only diff here was an unrelated Array.from -> spread
  refactor picked up as context noise from #17048 (ownsSelectable filter),
  which also isn't on cloud/1.54.
- src/core/graph/widgets/dynamicWidgets.ts, AgentPanelRoot.vue: additive
  conflicts, took the incoming side. Dropped an incoming useSettingStore
  import in AgentPanelRoot.vue that belonged to a separate, unbackported
  PR (#17730) and was unused on this branch.
- src/workbench/extensions/agent/crdt/graphMutations.ts: took the new
  by-name `connect` handler wholesale (the actual fix). This uncovered a
  missing dependency: linkPresentationStore, introduced by unbackported
  #17875 and used (in code already present before #18275 on main) to
  preserve link presentation across a replace/displace. Ported
  src/types/linkPresentation.ts and src/stores/linkPresentationStore.ts
  (+ its unit test) from main, and added the missing
  `const linkPresentationStore = useLinkPresentationStore()` wiring that
  #18275's diff never touched because it already existed upstream of the
  cherry-pick's base.
- graphMutations.test.ts: same missing-dependency shape, but for the test
  file the only pre-existing usages of linkPresentationStore live in other
  unbackported PRs' test blocks that aren't part of this branch, so the
  import ended up unused; removed it.
- Checked open backport PRs against cloud/1.54 stacking on the same files
  (#18475, #18473, #18418, #18411, #18370, #18367, #18355, #18351): none
  of them are merged into cloud/1.54 yet, so no additional stacking
  conflicts applied.

Verification: pnpm typecheck clean; pnpm vitest run on the directly
relevant suites (graphMutations.test.ts, dynamicWidgets.test.ts,
linkStore.test.ts, nodeDataStore.test.ts, linkPresentationStore.test.ts,
crdtSession.test.ts, agentNodeMaterializer.multiAutogrow.test.ts) is 209
passed / 1 expected-fail; eslint and oxlint clean on all changed files.
Keeps both new imports in AgentPanelRoot.vue (useSettingStore from
cloud/1.54 and LiveAutogrowGroupAnswer from the #18275 backport);
neither side removed the other's usage.
@claude
claude Bot force-pushed the backport-18275-to-cloud-1.54 branch from 63a1574 to c8f020a Compare September 24, 2026 04:44
@comfy-pr-bot
comfy-pr-bot merged commit 662620a into cloud/1.54 Sep 24, 2026
90 of 91 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-18275-to-cloud-1.54 branch September 24, 2026 05:08
christian-byrne pushed a commit that referenced this pull request Sep 25, 2026
… after dynamic input reordering (#17221)

Fixes [PM-993](https://linear.app/comfy-org/issue/PM-993): document
links can target the wrong MiniMax input after node configuration or
autogrow changes the live input order.

- Resolve document input targets by name during initial materialization,
reconcile, and remote connect. Preserve live order and extra inputs when
every document input name exists live; otherwise use the document input
list and order.
- Incoming connect preserves matching runtime slot instances and shared
arrays, including multiple connects in one batch. Commit the prepared
slot order without re-merging it, and reject a target that slot
validation removed before changing the graph.
- Keep outputs index-based. Document the durable name-targeting rule
separately from the interim store-first implementation and its [FE-2504
migration](https://linear.app/comfyorg/issue/FE-2504/agentcrdt-remove-store-first-remote-apply-and-every-reconciliation)
in the
[ADR](https://github.com/Comfy-Org/ComfyUI_frontend/blob/ryandi/pm-994-minimax-wiring-investigation/docs/adr/CRDT-INPUTS-0030-preserve-named-input-targets.md).
- Surface all fixture cleanup failures, supply the bound root graph
required by current main, and align regression data, utilities and
assertions with repository conventions.

Authoritative snapshot reconciliation retains slot arrays but can
replace slot instances and lose runtime-only metadata. That existing
preservation gap is separate follow-up work, not fixed by the
incoming-connect path. Duplicate input names resolve to the first match;
uniqueness is not enforced here. Producer-side/local-to-document
addressing remains outside this PR under the [Option A
ruling](https://github.com/christian-byrne/blocked-on-christian/issues/448).

- Local CRDT suites and nodeDataStore: 54 files, 825 passed and 6
expected failures. The final review regression failed before the
resolved-target bounds fix and passes afterward.
- Application/browser typechecks, full lint, formatting, Knip and ADR
validation passed during this follow-up; affected tests and commit hooks
were rerun for the final fix.
- The cloud browser regression covers live graph serialize/configure,
not direct CRDT-document inspection. No local browser execution was
performed during this follow-up; see the current remote CI checks for
automated browser results.
- Integrated remote PR head 322e726 and main 23559a8. The fixture
now supplies boundRootGraphId, resolving the build/typecheck failures
seen when CI combined the previous head with newer main.

---------

Co-authored-by: Terry Jia <terryjia88@gmail.com>
Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Co-authored-by: Amp <amp@ampcode.com>

## Backport notes (core/1.54)

Manual backport of #17221 onto core/1.54. Requested by Christian Byrne to
unblock the core/1.54 backport of #18479 (cloud/1.54's #18275 counterpart),
which depends on this PR's name-based CRDT input-targeting architecture.

Conflicts resolved:
- docs/adr/README.md: inserted the new CRDT-INPUTS-0030 row into
  core/1.54's existing ADR index instead of importing main's full index
  (core/1.54 does not carry the many other ADRs added on main since).
- src/workbench/extensions/agent/crdt/graphMutations.test.ts: kept both
  sides' new imports (no substantive logic conflict, just adjacent import
  lines).
- src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts: the
  conflict's theirs-side pulled in BatchOutcome/DocFrameTransport imports
  that predate #17221 on main (added by a separate, still-unbackported
  PR) and have no corresponding usage in this file on core/1.54. Kept
  only the GraphOperation import that #17221 itself adds and that the
  enqueue-wiring hunk actually uses; dropped the other two as unused
  (vue-tsc TS6133) rather than smuggling in that unrelated PR's imports.

Dropped from this backport (not present, and not required, on core/1.54):
- browser_tests/fixtures/agentConversationFixture.ts (modified) and
  browser_tests/tests/agent/agentConversationReplay.spec.ts (added): this
  E2E spec and its fixture edits depend on agent-conversation E2E harness
  additions from other PRs never backported to core/1.54. The file itself
  is missing on this branch, so the modify/delete conflict is a real gap,
  not something introduced by this commit.
- browser_tests/fixtures/data/minimaxAutogrowReload.ts and
  browser_tests/fixtures/utils/minimaxAutogrowReload.ts (both added):
  test-only fixture data/utilities consumed exclusively by the spec above;
  dropped as dead code once that spec was dropped.

All runtime code (graphMutations.ts, agentNodeMaterializer.ts) and all
Vitest unit coverage for the CRDT input-targeting logic (graphMutations.test.ts,
agentNodeMaterializer.inputOrder.test.ts + its new fixtures, nodeDataStore.test.ts,
useAgentCrdtFollower.test.ts) are included unchanged in substance.
christian-byrne added a commit that referenced this pull request Sep 25, 2026
…s multiple autogrow groups (#18512)

&lt;!-- ccr-slack-attribution --&gt;
_Requested by **Christian Byrne** · [Slack
thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790128455751879?thread_ts=1789965317.152049&cid=C0BGH348Z0C)_

## Summary

Manual backport of #18275 to `core/1.54`, following the same pattern
proven for the `cloud/1.54` backport (#18479).

**STACKED ON #18509 — do not merge this before #18509 merges.** This
branch is based on `backport-17221-to-core-1.54` (#18509's head), not on
`origin/core/1.54` directly, because `core/1.54` proper still resolves
agent CRDT inputs positionally and lacks the name-based input-targeting
architecture from #17221 that #18275 builds directly on top of
(`mergeInputSlotsByName`/`hasNonGrowthInputSetChange` in
`graphMutations.ts`). Once #18509 merges into `core/1.54`, this PR's
base should be retargeted/rebased onto `core/1.54` before merging.

## Conflict resolution notes

- `browser_tests/fixtures/agentConversationFixture.ts`: dropped. Doesn't
exist on this branch (added by still-unbackported #17875); nothing here
imports it, including the new `agentCrdtMultiAutogrowRealign.spec.ts`
(only comment references, no real import).
- `src/lib/litegraph/src/LGraphCanvas.ts` (`selectItems`): kept this
branch's existing body. The only diff was an unrelated `Array.from` →
spread refactor from #17048's `ownsSelectable` filter, which isn't on
this branch (`ownsSelectable` doesn't exist anywhere in `src/`).
- `src/core/graph/widgets/dynamicWidgets.ts`, `AgentPanelRoot.vue`:
additive conflicts, took the incoming side. Dropped an incoming
`useSettingStore` import in `AgentPanelRoot.vue` (belongs to
unbackported #17730, unused here).
- `src/workbench/extensions/agent/crdt/graphMutations.ts`: took the new
by-name `connect`/`commitUpsertNode` handlers wholesale (the actual
fix). Uncovered missing dependency: `linkPresentationStore` (from
unbackported #17875). Ported `src/types/linkPresentation.ts` and
`src/stores/linkPresentationStore.ts` (+ unit test) from `main`, and
wired `const linkPresentationStore = useLinkPresentationStore()`.
- `graphMutations.test.ts`: same missing-dependency shape;
`useLinkPresentationStore` import ended up unused in the test file,
removed it.

## Additional gaps beyond the cloud/1.54 backport's notes (found and
verified, not just copied)

- `browser_tests/fixtures/agentFollowerHostSocket.ts` was missing
(needed by the new `MultiAutogrowRealignHarness.ts`). Ported verbatim
from `main`, which required exporting `DOC_PROTOCOL_VERSION` from
`docFrameClient.ts` (it was a local `const`).
- `commitUpsertNode`'s call to `applyWidgetValues` used a 5th
`guardLocalEdits` argument that only exists on `main` via unbackported
PR #18361 (the "local-edit guard" feature, already on `cloud/1.54` via
#18423 but not on `core/1.54`). Dropped the extra argument to match this
branch's existing 4-parameter `applyWidgetValues` — this guard is
unrelated to #18275's actual fix (named-link realignment), so dropping
it doesn't affect this PR's mechanism; it just means core/1.54 doesn't
yet get #18361's separate improvement.
- `zAutogrowOptions` import in `graphMutations.ts`: verified this
already resolves fine — `@/schemas/nodeDefSchema` re-exports
`@comfyorg/object-info-parser`, which already defines it. Not a gap.
- `zComfyApiWorkflow` in `workflowSchema.ts` (used by the new
`MultiAutogrowRealignHarness.ts`): wasn't exported on this branch (only
`ComfyApiWorkflow` the type was). Exported it, matching how `main`
already exports it.
- `MultiAutogrowRealignHarness.ts` / `savedWorkflowPersistence.ts`
imported `PromptResponse`/`UserDataFullInfo` from
`@/platform/remote/comfyui/types`, a module that doesn't exist on this
older branch. Both types live in `@/schemas/apiSchema` here; fixed the
import paths.
- `reconcileAutogrowInputs` (new additive export in `dynamicWidgets.ts`)
has no caller on this branch — its only call site on `main` is in
`agentNodeMaterializer.ts`, added by a separate, unbackported PR (not
#18275's own diff, and not #17221's either). Dropped it as dead code
rather than smuggling in that unrelated PR's wiring.

## Verification

- `pnpm typecheck` — clean
- `pnpm exec eslint` on all changed files — clean
- `pnpm exec oxfmt --check` on all changed files — clean, all correctly
formatted
- `pnpm knip` — clean
- `pnpm vitest run` on `graphMutations.test.ts`,
`dynamicWidgets.test.ts`, `linkStore.test.ts`, `nodeDataStore.test.ts`,
`linkPresentationStore.test.ts`, `crdtSession.test.ts`,
`agentNodeMaterializer.multiAutogrow.test.ts` — 7 files, 198 passed / 1
expected fail
- `pnpm exec playwright test --list` — collects cleanly, no
`@e2e/fixtures` resolution errors (2237 tests / 367 files total,
including the 2 new specs in `agentCrdtMultiAutogrowRealign.spec.ts`)

---------

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XqLXka9Jsg8EMTYmsnZjjv

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01XqLXka9Jsg8EMTYmsnZjjv

---
_Generated by [Claude
Code](https://claude.ai/code/session_01XqLXka9Jsg8EMTYmsnZjjv)_

---------

Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com>
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: bymyself <cbyrne@comfy.org>
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: Claude <noreply@anthropic.com>

This branch had an error being deployed

1 failed deployment
Preview – billing-web-test — c8f020ab Deployed Sep 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-docs Agent product architecture, contracts or documentation agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants