Repository navigation
[backport core/1.54] fix: stop agent turn on Escape after submitting via mouse click on Send - #18334
Conversation
…nd (#18296) Escape now stops an in-progress agent turn even when the turn was started by clicking the Send button with the mouse, not just when it was started by pressing Enter. - What: Before, pressing Escape stopped the agent turn only if the composer's prompt editor still had keyboard focus. Submitting with Enter never moves focus away, so Escape worked there. Clicking Send with the mouse moves focus to the button instead (or leaves it on <body> in Safari/Firefox), so the Escape-to-stop handler wired only to the editor's own keydown event never saw the keypress and the turn kept running. Added a `registerEscapeOverride` hook in `platform/keybindings/escapeOverride.ts` that `keybindingService` consults before dispatching the default bare-Escape keybinding; the agent composer registers into it while a turn is running so it can stop the run regardless of where focus landed after the click, without `keybindingService` importing from `workbench/`. - Breaking: none - Dependencies: none Backport of merge commit c23a1e6 onto core/1.54. Cherry-pick conflicts in `keybindingService.escape.test.ts` and `Composer.test.ts` were resolved by keeping core/1.54's existing test content (which predates an unrelated main-only mocking/test refactor not present on this branch) and adding only the new Escape-override tests from #18296 on top of it.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1934 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-22T02:26:45.979Z",
"gitSha": "ac205937ca388056031210b658b02ee7af5bfc02",
"branch": "backport-18296-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2056.174999999996,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.482000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 605.946,
"heapDeltaBytes": -1041640,
"heapUsedBytes": 69642940,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 11.867000000000003,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2034.6130000000358,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.421000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 512.12,
"heapDeltaBytes": 171608,
"heapUsedBytes": 70315360,
"domNodes": -279,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.683,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1861.6480000000024,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.535,
"layouts": 14,
"layoutDurationMs": 4.119000000000001,
"taskDurationMs": 910.967,
"heapDeltaBytes": -3773236,
"heapUsedBytes": 67004736,
"domNodes": -277,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 164.875,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1824.752999999987,
"styleRecalcs": 74,
"styleRecalcDurationMs": 30.021,
"layouts": 14,
"layoutDurationMs": 4.224,
"taskDurationMs": 888.9110000000002,
"heapDeltaBytes": -703020,
"heapUsedBytes": 64032000,
"domNodes": -282,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 164.408,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1730.9870000000274,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.758000000000003,
"layouts": 6,
"layoutDurationMs": 1.0110000000000001,
"taskDurationMs": 391.235,
"heapDeltaBytes": 4604564,
"heapUsedBytes": 75444376,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.081,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1663.838999999939,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.522000000000002,
"layouts": 6,
"layoutDurationMs": 0.9750000000000002,
"taskDurationMs": 391.963,
"heapDeltaBytes": 4649836,
"heapUsedBytes": 75690276,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.6,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 692.3300000000268,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.932,
"heapDeltaBytes": 18383452,
"heapUsedBytes": 88592260,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 163.27800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 691.0799999999995,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.857000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.41799999999995,
"heapDeltaBytes": 18390272,
"heapUsedBytes": 88820796,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 175.315,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2046.7689999999834,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.523999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 684.52,
"heapDeltaBytes": 8152920,
"heapUsedBytes": 83777268,
"domNodes": -276,
"jsHeapTotalBytes": -892928,
"scriptDurationMs": 36.756,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2035.6089999999085,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.475,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 615.318,
"heapDeltaBytes": 11027084,
"heapUsedBytes": 86860792,
"domNodes": -270,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 34.211000000000006,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2669.009000000017,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.057999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1820.9519999999998,
"heapDeltaBytes": 9588108,
"heapUsedBytes": 86960724,
"domNodes": -248,
"jsHeapTotalBytes": 643072,
"scriptDurationMs": 895.3639999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2367.810000000077,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.782999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1649.8079999999998,
"heapDeltaBytes": 26794640,
"heapUsedBytes": 92881908,
"domNodes": 2,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 827.62,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3712.3090000000047,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.102,
"layouts": 60,
"layoutDurationMs": 12.508000000000001,
"taskDurationMs": 1796.662,
"heapDeltaBytes": 12397192,
"heapUsedBytes": 80105116,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 800.57,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3825.9289999999737,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.076999999999998,
"layouts": 60,
"layoutDurationMs": 12.123000000000001,
"taskDurationMs": 1878.238,
"heapDeltaBytes": -2250476,
"heapUsedBytes": 76723560,
"domNodes": -285,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 848.5500000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3131.426000000033,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.8500000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1984.4189999999999,
"heapDeltaBytes": 22128880,
"heapUsedBytes": 89688040,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 958.624,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3148.3970000000454,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.8119999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2024.719,
"heapDeltaBytes": 12868044,
"heapUsedBytes": 93826580,
"domNodes": -281,
"jsHeapTotalBytes": -1523712,
"scriptDurationMs": 989.344,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1999.6620000000007,
"styleRecalcs": 1,
"styleRecalcDurationMs": 1.0000000000000009,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 573.1569999999999,
"heapDeltaBytes": 21700928,
"heapUsedBytes": 88588168,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 38.592,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2060.45000000006,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.864000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 651.7210000000001,
"heapDeltaBytes": 6459500,
"heapUsedBytes": 83395012,
"domNodes": -278,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 36.586000000000006,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 658.3160000000134,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.556,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.45300000000003,
"heapDeltaBytes": 14626888,
"heapUsedBytes": 86629508,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 155.567,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 622.8140000000622,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.523,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.43,
"heapDeltaBytes": 14198068,
"heapUsedBytes": 86586536,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 147.88099999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2024.518999999998,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.915000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 553.32,
"heapDeltaBytes": -13181848,
"heapUsedBytes": 59173028,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 11.117999999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2014.5400000000109,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.248,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.71999999999997,
"heapDeltaBytes": -6710820,
"heapUsedBytes": 66201316,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.783,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1741.7260000000283,
"styleRecalcs": 77,
"styleRecalcDurationMs": 29.526999999999997,
"layouts": 18,
"layoutDurationMs": 5.492,
"taskDurationMs": 874.102,
"heapDeltaBytes": -15649940,
"heapUsedBytes": 57057068,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 118.68999999999998,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1735.4720000000725,
"styleRecalcs": 77,
"styleRecalcDurationMs": 29.705000000000002,
"layouts": 18,
"layoutDurationMs": 5.666999999999999,
"taskDurationMs": 882.2730000000001,
"heapDeltaBytes": -6034724,
"heapUsedBytes": 65900748,
"domNodes": -295,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 119.07600000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.260000000032,
"styleRecalcs": 20,
"styleRecalcDurationMs": 34.30199999999999,
"layouts": 16,
"layoutDurationMs": 16.485999999999997,
"taskDurationMs": 1007.236,
"heapDeltaBytes": 21944208,
"heapUsedBytes": 106435160,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 33.153999999999996,
"eventListeners": 2385,
"totalBlockingTimeMs": 145,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9013.921000000038,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.544000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6155.74,
"heapDeltaBytes": 9023668,
"heapUsedBytes": 85048012,
"domNodes": -268,
"jsHeapTotalBytes": 610304,
"scriptDurationMs": 2770.4809999999998,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8812.995,
"styleRecalcs": 247,
"styleRecalcDurationMs": 36.104,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6030.5109999999995,
"heapDeltaBytes": 13569824,
"heapUsedBytes": 89238692,
"domNodes": -270,
"jsHeapTotalBytes": 643072,
"scriptDurationMs": 2731.919,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17425.478999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16869.192000000003,
"heapDeltaBytes": -39559840,
"heapUsedBytes": 177993120,
"domNodes": -8068,
"jsHeapTotalBytes": -8400896,
"scriptDurationMs": 287.433,
"eventListeners": -14937,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17510.290000000055,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16844.432,
"heapDeltaBytes": -57558476,
"heapUsedBytes": 178843372,
"domNodes": -8068,
"jsHeapTotalBytes": -16375808,
"scriptDurationMs": 289.64300000000003,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21255.674,
"styleRecalcs": 171,
"styleRecalcDurationMs": 19.959000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20888.724,
"heapDeltaBytes": -39332304,
"heapUsedBytes": 192456760,
"domNodes": -8068,
"jsHeapTotalBytes": -20807680,
"scriptDurationMs": 897.6809999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 134,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21410.48699999999,
"styleRecalcs": 167,
"styleRecalcDurationMs": 18.274999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20956.128,
"heapDeltaBytes": -55799396,
"heapUsedBytes": 168752528,
"domNodes": -8068,
"jsHeapTotalBytes": -16134144,
"scriptDurationMs": 954.3660000000001,
"eventListeners": -14925,
"totalBlockingTimeMs": 75,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6214.676999999994,
"styleRecalcs": 20,
"styleRecalcDurationMs": 102.02099999999997,
"layouts": 20,
"layoutDurationMs": 29.045,
"taskDurationMs": 6126.852,
"heapDeltaBytes": -43096300,
"heapUsedBytes": 175729908,
"domNodes": -8068,
"jsHeapTotalBytes": 8445952,
"scriptDurationMs": 113.45600000000002,
"eventListeners": -14927,
"totalBlockingTimeMs": 607,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6275.810999999976,
"styleRecalcs": 20,
"styleRecalcDurationMs": 95.466,
"layouts": 20,
"layoutDurationMs": 27.977000000000015,
"taskDurationMs": 6131.535000000001,
"heapDeltaBytes": -55198856,
"heapUsedBytes": 176475544,
"domNodes": -8068,
"jsHeapTotalBytes": -573440,
"scriptDurationMs": 109.634,
"eventListeners": -14925,
"totalBlockingTimeMs": 380,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8974.300000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8529.11,
"heapDeltaBytes": 4403692,
"heapUsedBytes": 176781604,
"domNodes": 0,
"jsHeapTotalBytes": -16777216,
"scriptDurationMs": 174.79,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8931.513999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8548.139,
"heapDeltaBytes": 2162256,
"heapUsedBytes": 179135764,
"domNodes": 0,
"jsHeapTotalBytes": -18612224,
"scriptDurationMs": 149.2110000000001,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 110.70899999998574,
"styleRecalcs": 9,
"styleRecalcDurationMs": 16.544000000000004,
"layouts": 3,
"layoutDurationMs": 1.432,
"taskDurationMs": 81.571,
"heapDeltaBytes": 3120260,
"heapUsedBytes": 71819204,
"domNodes": 112,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.377,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 98.3330000000251,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.432000000000002,
"layouts": 2,
"layoutDurationMs": 0.6749999999999999,
"taskDurationMs": 70.57000000000002,
"heapDeltaBytes": 3006944,
"heapUsedBytes": 71295828,
"domNodes": 106,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.808,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.54 #18334 +/- ##
=============================================
- Coverage 83.54% 83.54% -0.01%
=============================================
Files 2094 2095 +1
Lines 123479 123511 +32
Branches 31432 31443 +11
=============================================
+ Hits 103165 103185 +20
- Misses 20135 20147 +12
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…ir real slot after an agent slot sync (PM-1449) (#18339) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789965308493739)_ ## Summary Backport of #18279 to `core/1.54`. The automated backport failed with a merge conflict, so this is a manual cherry-pick of merge commit `566c343fb95e77ee04c4dc3aa02ea40bcb416e66`. A hand-wired connection into an autogrow port could be serialized against the wrong input after an agent slot sync. `updateNodeSlots` replaced the store's slot arrays even though the live `LGraphNode` retained the original arrays, leaving serialization and the canvas with different slot layouts. The fix preserves the registered input/output arrays and patches matching slot objects in place instead of reassigning them. ## Conflict resolution Conflicts were in `src/stores/nodeDataStore.ts` and `src/stores/nodeDataStore.test.ts`: - `nodeDataStore.ts`: `updateNodeSlots` conflicted because `core/1.54`'s current version does a plain array reassignment (`state.inputs = slots.inputs`), while #18279 replaces that with the occurrence-aware `mergeSlotsByName` in-place patch, which is the entire point of this fix. Took the incoming (PR) side; `mergeSlotsByName`/`patchInputSlot`/`patchOutputSlot`/`copyInputSlot`/`copyOutputSlot` all merged in cleanly elsewhere in the file. - `nodeDataStore.test.ts`: an import conflict (`core/1.54` already has `createTestingPinia`/`setActivePinia`/`beforeEach` for existing tests; #18279 added `vi` for its new tests) was resolved by merging both import sets. A second conflict was a pure addition (`keeps live slot edits visible after a remote slot sync` test) with nothing on the `core/1.54` side to reconcile against, so it was taken as-is. `src/workbench/extensions/agent/crdt/graphMutations.ts` and its test file auto-merged cleanly with no conflicts. ## Is this a real conflict or a stacking conflict? Checked #18337, #18334, and #17872 (the other open PRs against `core/1.54` the backport bot flagged as possible stacking candidates): none of them touch `src/stores/nodeDataStore.ts` or `nodeDataStore.test.ts`. This is a real, direct conflict between #18279's rewrite of `updateNodeSlots` and `core/1.54`'s pre-existing simpler implementation, not a stacking conflict with any of those three PRs. ## Verification - `pnpm vitest run src/stores/nodeDataStore.test.ts` — 31 passed. - `pnpm vitest run src/workbench/extensions/agent/crdt/graphMutations.test.ts src/core/graph/widgets/dynamicWidgets.test.ts` — 71 passed, 1 expected failure (matches the original PR's reported results). - `pnpm typecheck` — passed. - `eslint` on the 4 changed files — passed. - Working tree matches the 4 files changed by #18279 exactly (`nodeDataStore.ts`, `nodeDataStore.test.ts`, `graphMutations.ts`, `graphMutations.test.ts`), no stray diffs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01PqHg3D8o2RbujF1t4dz4J6 --- _Generated by [Claude Code](https://claude.ai/code/session_01PqHg3D8o2RbujF1t4dz4J6)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Amp <amp@ampcode.com>
…Image node bypassing upload (#18464) Automated backport of #18180 to `core/1.54`. The bot's auto-backport (`comfy-pr-bot`) failed on this branch with merge conflicts in: - `src/extensions/core/load3d/Load3DConfiguration.test.ts` - `src/extensions/core/load3d/Load3DConfiguration.ts` - `src/utils/createAnnotatedPath.test.ts` ## Root cause of the conflict Not a stacking conflict against any of the PRs the bot listed as still-open on `core/1.54` (#18417, #18410, #18407, #18369, #18354, #18334, #17872) — none of them touch these files. The real cause is that `core/1.54` never received an **already-merged, unrelated** PR: #17537 ("Load3D preview capture stale after agent-driven model_file change"), which is not on the bot's open-PR list and is not itself labeled for backport. That PR: - added a `DEFAULT_GIZMO`/`GizmoConfig` block to `Load3DConfiguration.ts` right next to the `parseAnnotatedFilename` helper that #18180 deletes (textual adjacency, not a real dependency — I did not port the gizmo code, since it's out of scope here and `core/1.54` has no other reference to it), and added `ComfyApi`/`ComfyApp` test imports unused on this branch (dropped), - moved the `ResultItem` type from `@/schemas/apiSchema` to `@/platform/remote/comfyui/execution/types` on `main`, which `core/1.54` hasn't picked up (kept the branch's existing `@/schemas/apiSchema` import), and - added an `app.getRandParam()` call inside `nodeOutputStore.ts` (already present on `core/1.54` from an earlier point, unrelated to #18180) whose test mock in `nodeOutputStore.test.ts` was missing `getRandParam`, only surfaced now because #18180's new test is the first to exercise `getNodeImageUrls()` on this file — added the missing mock entry. Resolved by taking #18180's actual change (removing the local `parseAnnotatedFilename` in favor of the shared `parseAnnotatedPath` util) while leaving everything from #17537 out, since it isn't part of this branch. ## Verification - `pnpm exec vitest run` on the touched spec files (`Load3DConfiguration.test.ts`, `createAnnotatedPath.test.ts`, `nodeOutputStore.test.ts`, `imageUtil.test.ts`) — all pass (113/113) - `pnpm typecheck` — clean - `pnpm exec eslint` on changed files — no errors (2 pre-existing `apiSchema` deprecation warnings, unrelated to this change) - `pnpm exec oxfmt --check` on changed files — clean - The new Playwright e2e (`assetPanelDragOntoLoadImageWidget.spec.ts`) was not run locally (no backend available), consistent with the original PR's own review notes. <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-org.slack.com/archives/C0BGH348Z0C/p1789875316334739)_ --- _Generated by [Claude Code](https://claude.ai/code/session_01Ws2BqUcMwaeUuPpKdYNxPV)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: bymyself <cbyrne@comfy.org>
…window (#18673) Automated backport of #18599 to `core/1.54`. The backport bot's automated cherry-pick attempt failed with a merge conflict in `src/scripts/api.fetchApi.test.ts` (several other open PRs — #18660, #18369, #18334, #17872 — are stacked against `core/1.54` touching the same file), so this was done manually. ## What conflicted and how it was resolved - **`src/scripts/api.fetchApi.test.ts`**: only the import/mock-setup header conflicted. `core/1.54`'s auth mocking is older than `main`'s: this branch's `authStore` still talks to Firebase directly through `vuefire` + `firebase/auth` (no `firebaseIdentity` port exists here yet), so the new `describe('post-401 retry timeout budget')` test's `beforeEach` was adapted to mock `vuefire`/`firebase/auth` directly (matching the pattern already used in this branch's `authStore.test.ts`) instead of spying on `firebaseIdentity.onUserChanged`/`onTokenChanged`. The new `trackUnifiedAuthRetry`/`mockDistribution`/`mockFeatureFlags` mocks were kept, simplified to this branch's non-`fromPartial` mocking style. - **`src/platform/auth/unified/remintRetry.test.ts`**: auto-merged, but the new test referenced `useWorkspaceAuthStore()` directly; this branch's file mocks that whole module via a hoisted `mockRemint` instead, so the test was updated to use `mockRemint.mockResolvedValue(...)` like every other test in the file. - **`src/scripts/api.ts`**: auto-merged, but the new timeout-retry code called `addBreadcrumb(...)` directly; this branch imports Sentry as `import * as Sentry from '@sentry/vue'` (not a named `addBreadcrumb` import), so the call was changed to `Sentry.addBreadcrumb(...)` to match this branch's existing convention (used a few lines above in the same file). - **`src/platform/auth/unified/remintRetry.ts`**: auto-merged cleanly, no changes needed. ## Verification - `pnpm typecheck` — clean - `pnpm lint` (eslint on the touched files; `src/scripts/api.ts` is repo-ignored from eslint on this branch) — clean, no new oxlint/eslint issues - `src/scripts/api.fetchApi.test.ts` — 18/18 passing - `src/platform/auth/unified/remintRetry.test.ts` — 23/23 passing - Pre-commit hooks (oxfmt, oxlint --fix, eslint --fix, typecheck) ran clean on commit 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_0137jzrG6RSp5e6YgGp8kxdY --- _Generated by [Claude Code](https://claude.ai/code/session_0137jzrG6RSp5e6YgGp8kxdY)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: dante01yoon <bunggl@naver.com>
…assets flag, retire Comfy.Assets.UseAssetAPI (#18727) Manual backport of #17117 to `core/1.54`. The automated backport failed with merge conflicts (#17117 (comment)). Cherry-picked from dffad2d (`git cherry-pick -x`). ## Why #17117 retires the hidden `Comfy.Assets.UseAssetAPI` setting and the `Comfy.ToggleAssetAPI` command. The model library, sidebar tab and model store follow `useFeatureFlags().flags.assetsEnabled` (cloud, or the server advertises the `assets` feature). `Comfy.BrowseModelAssets` opens the browser through `openModelLibraryBrowser()`, and the widget asset-picker gate is renamed to `shouldUseWidgetAssetPicker` / `isWidgetAssetPickerEnabled` and fixed to `isCloud`. Without it, a stale persisted setting can still route the model library to `/api/assets` on a backend that doesn't serve it. ## Dependency check The bot flagged a possible stacking conflict with #18722, #18683, #18334 and #17872. None of the four touch any file changed by #17117, so they aren't the cause. The conflicts are real and come from main-only test refactors that aren't on `core/1.54`: the `vi.mock(import(...))` migrations (#17173, #17175, #17176, #17178, #17179) and the global-Pinia test migrations (#17231, #17234, #17235, #17236, #17237, #17270), plus #16891. All production code, locale, script and e2e changes applied cleanly. ## Conflict resolution All 7 conflicts were in unit tests. Each one keeps `core/1.54`'s mocking style (hoisted `vi.mock` stores, no global Pinia) and ports only the setting-to-flag change: - `src/components/sidebar/tabs/ModelLibrarySidebarTab.test.ts`: kept the target's store/download/setting mocks. Dropped the `Comfy.Assets.UseAssetAPI` branch and added a `useFeatureFlags` mock (`featureFlagState.assetsEnabled`) in its place. - `src/composables/useCoreCommands.test.ts`: kept the target's mocks and `createMockSettingStore`. Added the `useFeatureFlags` mock. The `BrowseModelAssets` tests toggle `assetsEnabled` instead of the setting. - `src/platform/assets/services/assetService.test.ts`: kept the target's imports and mocks. Took the rename to `shouldUseWidgetAssetPicker` and removed the setting-store mock. - `src/platform/assets/utils/assetPreviewUtil.test.ts`: kept the target's `vi.mock` style. Added the `useFeatureFlags` mock and removed the `isAssetAPIEnabled` / `getServerFeature` mocks. - `src/renderer/extensions/vueNodes/widgets/composables/useComboWidget.test.ts`: kept the target's two remote-combo tests, which are absent on main. Took the renamed test and the `shouldUseWidgetAssetPicker` mock. - `src/stores/modelStore.test.ts`: kept the target's `mockDistribution` mock. Took #17117's `remoteConfig` holder mock and reactive `serverFeatures` state, so the store's flag watcher fires and state doesn't leak between tests. - `src/stores/workspace/sidebarTabStore.test.ts`: kept the target's command/menu/setting store mocks. Added the `useFeatureFlags` and `openModelLibraryBrowser` mocks and dropped the `Comfy.Assets.UseAssetAPI` setting reads. No other changes from main are included. ## Validation - Static check: no remaining `Comfy.Assets.UseAssetAPI`, `isAssetAPIEnabled`, `shouldUseAssetBrowser`, `ToggleAssetAPI` or `usesAssetApi` references in `src`, `browser_tests`, `scripts` or `.github`. - `pnpm install --frozen-lockfile`: ok - `pnpm typecheck`: clean - `eslint`, `oxlint`, `oxfmt --check` on changed files: 0 errors - `vitest run` on the touched tests plus `src/stores`, `src/platform/assets`, `src/components/sidebar` and `src/composables/useFeatureFlags*`: 129 files, 2339 passed - `vitest run` on `scripts/checkAssetsFlagArtifact.test.ts`, `widgetInputs`, `missingModelPipeline`, `src/renderer/extensions/vueNodes/widgets` and `useCoreCommands`: 66 files, 960 passed - `vite build` followed by `EXPECTED_DISTRIBUTION=localhost EXPECTED_FRONTEND_COMMIT=<HEAD> pnpm test:assets-flag-artifact`: pass - Local e2e against a real ComfyUI backend without `--enable-assets` (`/api/features` reports `assets: false`), with a temporary request guard that is not included in this PR: - A walk of the sidebars, model library refresh, asset/model commands, missing-model workflows, upload and run, the assets sidebar, linear mode and vue-node dropdowns: 10/10 passed. This covered a user with a stale persisted `Comfy.Assets.UseAssetAPI=true`. No `/api/assets*` requests were made. - `browser_tests/tests/sidebar/modelLibrary.spec.ts`: 13/13 passed with no `/api/assets*` requests.
Requested by Christian Byrne · Slack thread
Backport of #18296 to
core/1.54.Before: Pressing Escape stopped an in-progress agent turn only if the composer's prompt editor still had keyboard focus. Submitting with Enter never moves focus away, so Escape worked there, but clicking Send with the mouse moves focus to the button (or leaves it on
<body>in Safari/Firefox), so the editor-scoped Escape handler never saw the keypress and the turn kept running.After: A
registerEscapeOverridehook (src/platform/keybindings/escapeOverride.ts) is consulted bykeybindingServicebefore it dispatches the default bare-Escape keybinding. The agent composer registers into this hook while a turn is running, so Escape stops the run regardless of where focus landed after a mouse click on Send, withoutkeybindingServiceimporting fromworkbench/. Escape still does nothing once focus has genuinely left the composer for another part of the page.Cherry-pick conflicts in
keybindingService.escape.test.tsandComposer.test.tswere caused by an unrelated, not-yet-backported test/mocking refactor already onmain(unrelated to #18296). Resolved by keepingcore/1.54's existing test content/style intact and adding only the new Escape-override tests and imports introduced by #18296 on top of it. Verified withpnpm typecheck,eslinton changed files, and the fullkeybindingService.escape.test.ts+escapeOverride.test.ts+Composer.test.tssuites (109 tests, all passing).🤖 Generated with Claude Code
https://claude.ai/code/session_017F6NfYxdCmZEFy9ut4cdUN
Generated by Claude Code