Repository navigation
[backport core/1.54] refactor(assets): gate asset surfaces on server assets flag, retire Comfy.Assets.UseAssetAPI - #18727
Conversation
…omfy.Assets.UseAssetAPI (#17117) Retires the hidden `Comfy.Assets.UseAssetAPI` setting. Asset surfaces now follow the backend's `assets` capability flag. Widget-embedded model pickers stay cloud-only, under a name that says so. The backend already advertises `assets` support, so a hidden client override was redundant — and on core it could force asset mode against a server with no `/assets` endpoints. The gate functions were misleadingly named. `isAssetAPIEnabled` / `shouldUseAssetBrowser` read as "is the asset API on", but actually gated *widget* pickers — which are cloud-only because `MODEL_NODE_MAPPINGS` is only maintained for cloud. They're now `isWidgetAssetPickerEnabled` / `shouldUseWidgetAssetPicker`, hardcoded to `isCloud`. 67 files, small surface: **18 production**, 30 one-line locale deletions, 19 test migration. Commit 1 is production, commits 2–3 are tests. Unchanged for default settings on cloud, and on core without `--enable-assets`. **Core+ (`--enable-assets`)** — the model library enters asset mode. Six deliberate consequences, each already asserted by `modelLibraryAssetMode.spec.ts`: 1. Tree data from `/assets` instead of `api.getModels` 2. `visibleModelFolders` hides loaded-but-empty folders 3. The `supportsModelTypeTags` watcher goes live 4. Refresh issues `POST /assets/seed` via `requestModelScan()` 5. The per-folder extension allowlist applies client-side 6. The tab hides "Load all folders" and eager-loads on mount, bypassing `Comfy.ModelLibrary.AutoLoadAll` — the most visible off-cloud change **Anyone who had flipped the hidden setting:** - Cloud, set `false` → asset surfaces return; that opt-out is deliberately retired - Core, set `true` → no longer forces asset mode at servers that can't serve it (broken by construction) - Core−, palette command → silent no-op instead of a dialog offering to enable an API the server lacks **Deliberately untouched:** `Comfy.ModelLibrary.UseAssetBrowser` (sidebar-vs-modal), `Comfy.Assets.Sidebar.ViewMode`, `MODEL_NODE_MAPPINGS`. This PR edits `scripts/checkAssetsFlagArtifact.ts`, which statically proves non-cloud bundles strip the widget gate. Its non-cloud invariant is byte-identical — only the cloud regex and the function locator changed, tracking the rename. Verified against real builds for all three distributions, and mutation-tested: reverting the gate to a runtime setting read, or flipping its polarity, both still fail the check. Full unit suite and all touched e2e specs pass. `Comfy_ToggleAssetAPI` and its `menuLabels` mirror are removed from all 15 locales. The command is gone, so the keys are unreachable — a pure deletion, no translation pass. `pnpm locale:check`: 0 prunable keys, was 28. (cherry picked from commit dffad2d)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1954 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-25T10:55:06.982Z",
"gitSha": "a150f83a70bbd0c8243ad9872414f5398ba5489a",
"branch": "backport-17117-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2036.3699999999767,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.683,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 309.243,
"heapDeltaBytes": 5023756,
"heapUsedBytes": 75328428,
"domNodes": -276,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 5.787999999999998,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 1993.4709999999995,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.1049999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 276.958,
"heapDeltaBytes": -371000,
"heapUsedBytes": 70176868,
"domNodes": -279,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 5.015000000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1687.7440000000092,
"styleRecalcs": 74,
"styleRecalcDurationMs": 20.581000000000003,
"layouts": 14,
"layoutDurationMs": 3.5050000000000003,
"taskDurationMs": 519.255,
"heapDeltaBytes": 5432528,
"heapUsedBytes": 74506944,
"domNodes": -276,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 88.9,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1706.440999999984,
"styleRecalcs": 75,
"styleRecalcDurationMs": 20.063,
"layouts": 14,
"layoutDurationMs": 3.3240000000000003,
"taskDurationMs": 517.963,
"heapDeltaBytes": -7551920,
"heapUsedBytes": 63540964,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 90.359,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1654.7909999999888,
"styleRecalcs": 29,
"styleRecalcDurationMs": 10.204999999999998,
"layouts": 6,
"layoutDurationMs": 0.879,
"taskDurationMs": 199.588,
"heapDeltaBytes": 4606072,
"heapUsedBytes": 75495740,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 6.395,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1660.3810000000294,
"styleRecalcs": 30,
"styleRecalcDurationMs": 9.909999999999998,
"layouts": 6,
"layoutDurationMs": 0.916,
"taskDurationMs": 205.4,
"heapDeltaBytes": 4612220,
"heapUsedBytes": 75801484,
"domNodes": 77,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 6.886,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 464.37199999999734,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.156,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 286.174,
"heapDeltaBytes": 18384016,
"heapUsedBytes": 88478768,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 100.36700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 427.8939999999807,
"styleRecalcs": 13,
"styleRecalcDurationMs": 6.968,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 286.542,
"heapDeltaBytes": -7870656,
"heapUsedBytes": 62795388,
"domNodes": 22,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 100.657,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2025.4160000000354,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.572,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.723,
"heapDeltaBytes": 8988520,
"heapUsedBytes": 85143644,
"domNodes": -268,
"jsHeapTotalBytes": -888832,
"scriptDurationMs": 20.835,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2031.4009999999598,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.020999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 323.64099999999996,
"heapDeltaBytes": -15889572,
"heapUsedBytes": 87429024,
"domNodes": -267,
"jsHeapTotalBytes": -851968,
"scriptDurationMs": 17.230000000000004,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2102.739999999983,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.228,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 987.9530000000001,
"heapDeltaBytes": -3413712,
"heapUsedBytes": 73377976,
"domNodes": -270,
"jsHeapTotalBytes": 385024,
"scriptDurationMs": 481.106,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2114.4740000000297,
"styleRecalcs": 70,
"styleRecalcDurationMs": 13.587,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1031.3249999999998,
"heapDeltaBytes": 1774160,
"heapUsedBytes": 78564672,
"domNodes": -236,
"jsHeapTotalBytes": 1433600,
"scriptDurationMs": 523.26,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3095.062999999982,
"styleRecalcs": 67,
"styleRecalcDurationMs": 14.329,
"layouts": 60,
"layoutDurationMs": 12.205999999999998,
"taskDurationMs": 1084.3529999999998,
"heapDeltaBytes": -6365388,
"heapUsedBytes": 75429200,
"domNodes": -268,
"jsHeapTotalBytes": -888832,
"scriptDurationMs": 482.48999999999995,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3138.0229999999756,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.575000000000001,
"layouts": 60,
"layoutDurationMs": 12.331999999999999,
"taskDurationMs": 1081.525,
"heapDeltaBytes": -10742780,
"heapUsedBytes": 71222396,
"domNodes": -284,
"jsHeapTotalBytes": 3043328,
"scriptDurationMs": 474.85599999999994,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2147.167999999965,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.282,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1165.656,
"heapDeltaBytes": 17533392,
"heapUsedBytes": 85588432,
"domNodes": 8,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 585.38,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2270.992000000035,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.037999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1260.144,
"heapDeltaBytes": 18666952,
"heapUsedBytes": 86740484,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 639.1089999999999,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2007.3150000000055,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.596000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 296.65799999999996,
"heapDeltaBytes": 21787400,
"heapUsedBytes": 88106824,
"domNodes": -272,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 16.659,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2020.509000000004,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.385000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 356.29799999999994,
"heapDeltaBytes": 4888180,
"heapUsedBytes": 82602196,
"domNodes": -274,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 20.698,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 397.6700000000051,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.862,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 253.17299999999997,
"heapDeltaBytes": 14241784,
"heapUsedBytes": 86548588,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 87.803,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 394.48300000003655,
"styleRecalcs": 49,
"styleRecalcDurationMs": 9.142000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 246.25000000000003,
"heapDeltaBytes": 14684728,
"heapUsedBytes": 88074224,
"domNodes": 24,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 84.393,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1989.970000000028,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.677,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 283.844,
"heapDeltaBytes": 5027708,
"heapUsedBytes": 78111356,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 4.915000000000001,
"eventListeners": -208,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1993.7799999999584,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.654,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 273.068,
"heapDeltaBytes": 8090640,
"heapUsedBytes": 80702600,
"domNodes": -298,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 4.363,
"eventListeners": -208,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.9469999999894,
"styleRecalcs": 78,
"styleRecalcDurationMs": 21.436999999999998,
"layouts": 18,
"layoutDurationMs": 4.189,
"taskDurationMs": 543.7919999999999,
"heapDeltaBytes": -6520192,
"heapUsedBytes": 66534324,
"domNodes": -294,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 74.82300000000001,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.0470000000491,
"styleRecalcs": 78,
"styleRecalcDurationMs": 21.068,
"layouts": 18,
"layoutDurationMs": 4.082000000000001,
"taskDurationMs": 450.60699999999997,
"heapDeltaBytes": 20054812,
"heapUsedBytes": 85375056,
"domNodes": 38,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 68.226,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 800.2440000000206,
"styleRecalcs": 21,
"styleRecalcDurationMs": 20.258000000000006,
"layouts": 17,
"layoutDurationMs": 9.942000000000002,
"taskDurationMs": 536.6359999999999,
"heapDeltaBytes": 19151836,
"heapUsedBytes": 109944192,
"domNodes": 13751,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 17.690000000000005,
"eventListeners": 2385,
"totalBlockingTimeMs": 61,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8107.096000000012,
"styleRecalcs": 248,
"styleRecalcDurationMs": 37.193999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3338.0710000000004,
"heapDeltaBytes": 13084624,
"heapUsedBytes": 89196148,
"domNodes": -266,
"jsHeapTotalBytes": -663552,
"scriptDurationMs": 1647.059,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8118.739000000005,
"styleRecalcs": 251,
"styleRecalcDurationMs": 39.051,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3353.6710000000003,
"heapDeltaBytes": 2280244,
"heapUsedBytes": 78270752,
"domNodes": -267,
"jsHeapTotalBytes": -663552,
"scriptDurationMs": 1629.213,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11094.78299999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10366.812000000002,
"heapDeltaBytes": -40778396,
"heapUsedBytes": 183803212,
"domNodes": -8068,
"jsHeapTotalBytes": -9940992,
"scriptDurationMs": 143.404,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10784.051999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10133.109,
"heapDeltaBytes": -33267876,
"heapUsedBytes": 178572568,
"domNodes": -8072,
"jsHeapTotalBytes": -19009536,
"scriptDurationMs": 130.918,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13990.215999999975,
"styleRecalcs": 70,
"styleRecalcDurationMs": 12.067999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13386.977,
"heapDeltaBytes": -33959176,
"heapUsedBytes": 193549896,
"domNodes": -8068,
"jsHeapTotalBytes": -9379840,
"scriptDurationMs": 565.711,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13746.481999999958,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.878,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13108.462000000001,
"heapDeltaBytes": -30507924,
"heapUsedBytes": 179075012,
"domNodes": -8068,
"jsHeapTotalBytes": -18026496,
"scriptDurationMs": 588.02,
"eventListeners": -14931,
"totalBlockingTimeMs": 5,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 3939.5299999999907,
"styleRecalcs": 20,
"styleRecalcDurationMs": 49.13000000000001,
"layouts": 20,
"layoutDurationMs": 17.22299999999999,
"taskDurationMs": 3806.9889999999996,
"heapDeltaBytes": -37513868,
"heapUsedBytes": 181451608,
"domNodes": -8068,
"jsHeapTotalBytes": 16502784,
"scriptDurationMs": 62.471,
"eventListeners": -14933,
"totalBlockingTimeMs": 6,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 3822.4729999999454,
"styleRecalcs": 20,
"styleRecalcDurationMs": 47.9,
"layouts": 20,
"layoutDurationMs": 17.142000000000003,
"taskDurationMs": 3712.1359999999995,
"heapDeltaBytes": -33579520,
"heapUsedBytes": 185014216,
"domNodes": -8068,
"jsHeapTotalBytes": 15208448,
"scriptDurationMs": 58.33999999999999,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5260.610999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4778.005,
"heapDeltaBytes": 14280,
"heapUsedBytes": 179637616,
"domNodes": 0,
"jsHeapTotalBytes": -29622272,
"scriptDurationMs": 61.72899999999998,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5295.21299999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4840.830999999999,
"heapDeltaBytes": 8215828,
"heapUsedBytes": 179610292,
"domNodes": 0,
"jsHeapTotalBytes": -22282240,
"scriptDurationMs": 64.55300000000003,
"eventListeners": -9,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 71.14999999998872,
"styleRecalcs": 7,
"styleRecalcDurationMs": 9.808000000000002,
"layouts": 3,
"layoutDurationMs": 1.161,
"taskDurationMs": 46.698,
"heapDeltaBytes": 3085944,
"heapUsedBytes": 71185296,
"domNodes": 125,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 4.559,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 423.50999999996475,
"styleRecalcs": 13,
"styleRecalcDurationMs": 13.184000000000001,
"layouts": 3,
"layoutDurationMs": 0.714,
"taskDurationMs": 64.18300000000002,
"heapDeltaBytes": 4762848,
"heapUsedBytes": 73215708,
"domNodes": 119,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.639,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d430bbcc71
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| watch( | ||
| () => flags.assetsEnabled, | ||
| async (enabled) => { | ||
| if (enabled) await withLoadFailureToast(() => modelStore.loadModels()) | ||
| } |
There was a problem hiding this comment.
Serialize the late-capability eager load
When the assets flag arrives after GraphView has populated the folder names but before their contents are loaded, this watcher races the flags.assetsEnabled watcher in modelStore.ts. The store watcher snapshots the old folders as uninitialized and starts rebuilding them, while this call loads those old folder instances through their captured legacy api.getModels function; the rebuild then replaces them with fresh asset-backed but still-unloaded folders, so the awaited eager load completes against detached objects and the asset tree/search remains empty until a manual expansion or search. Chain this eager load after the capability rebuild, or make the store own both operations.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Rejected for this backport: the same code is on main from #17117. Being fixed on main, and that fix will be offered as its own backport.
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.54 #18727 +/- ##
==========================================
Coverage 83.77% 83.78%
==========================================
Files 2104 2105 +1
Lines 124698 124683 -15
Branches 31573 31564 -9
==========================================
- Hits 104464 104462 -2
+ Misses 20055 20043 -12
+ Partials 179 178 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @synap5e.
Found 8 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 2 |
| 🟢 Low | 5 |
Panel: 8/8 reviewers contributed findings.
| } | ||
| }) | ||
|
|
||
| watch( |
There was a problem hiding this comment.
🟠 High — This watcher and the new watch(() => flags.assetsEnabled) added to modelStore in this same PR both fire on the same flag flip. The store watcher is created first, so its reloadModels() snapshots previouslyLoaded and commits fresh (Uninitialized) folder objects, while this loadModels() populates the pre-flip folder objects still bound to the legacy api.getModels closure — the eager load is discarded and the tree renders folders with no contents (and no spinner) until a manual refresh, having spent N requests on the endpoint the flip was meant to switch away from. Let the store's reload own the eager load instead of racing it from the component. Raised by 8 of 8 reviewers (claude-opus-5-thinking-max adversarial and edge-case, gpt-5.6-sol-max adversarial and edge-case, gemini-3.1-pro adversarial and edge-case, kimi-k3-max adversarial and edge-case).
There was a problem hiding this comment.
Rejected for this backport: the same code is on main from #17117. Being fixed on main, and that fix will be offered as its own backport.
| * safe by design: prepareModelFolders()'s request-id discipline makes the | ||
| * stale response a no-op, so no debouncing is needed here. | ||
| */ | ||
| watch( |
There was a problem hiding this comment.
🟡 Medium — This watcher reloads on every transition of assetsEnabled, including true -> false, and unlike the adjacent supportsModelTypeTags watcher and the scan subscription it carries neither a modelDataConsumed guard nor any debounce. A server that re-sends differing feature_flags payloads (e.g. WS reconnect flapping) therefore amplifies each message into invalidateModelBuckets() plus a fresh paginated asset walk, with no cancellation of the in-flight one. Guard on the enabling transition and coalesce or cancel the way the scan path does. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max edge-case).
There was a problem hiding this comment.
Rejected: out of scope for a backport (identical to #17117 on main). A modelDataConsumed guard would also leave the boot-built folders on the wrong data source.
| import { useToastStore } from '@/platform/updates/common/toastStore' | ||
|
|
||
| export async function openModelLibraryBrowser(): Promise<void> { | ||
| if (!useFeatureFlags().flags.assetsEnabled) return |
There was a problem hiding this comment.
🟡 Medium — On a backend without the assets capability this returns with no toast, dialog, or log, while Comfy.BrowseModelAssets stays registered and visible in the command palette and keybindings — invoking it becomes a dead click indistinguishable from a hung UI, where the removed code at least explained the situation. Surface a toast, or gate the command's registration/enablement on flags.assetsEnabled. Raised by 5 of 8 reviewers (claude-opus-5-thinking-max edge-case, kimi-k3-max adversarial and edge-case, claude-opus-5-thinking-max adversarial, gemini-3.1-pro edge-case).
There was a problem hiding this comment.
Rejected: deliberate in #17117. The command does nothing when the server doesn't advertise assets.
| // Cloud always has assets enabled, so the unmocked asset endpoints would 403 | ||
| // and workflow restore would throw uncaught. One glob covers every shape boot | ||
| // asks for: `/api/assets`, `?query`, `/seed`, `/<id>`. | ||
| await page.route('**/api/assets**', (route) => { |
There was a problem hiding this comment.
🟢 Low — The comment claims this glob covers /api/assets/<id>, but every match is fulfilled with a collection body; assetService.getAssetDetails() validates that path against assetItemSchema, so a list-shaped payload fails and throws Invalid asset response against zod schema — the same class of uncaught boot-chain throw this mock exists to prevent. Route the detail shape separately (or return an asset object). The identical block is duplicated verbatim in browser_tests/tests/dialogs/checkoutRecovery.spec.ts and browser_tests/tests/dialogs/pricingTableDeepLink.spec.ts. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, claude-opus-5-thinking-max adversarial).
There was a problem hiding this comment.
Rejected: out of scope for a backport. The fixture is identical on main, and no current test fetches those paths.
| watch( | ||
| () => flags.assetsEnabled, | ||
| () => { | ||
| reloadModels().catch((error) => { |
There was a problem hiding this comment.
🟢 Low — The doc comment above asserts two concurrent reloadModels() calls are safe because request-id discipline no-ops the stale one, but that only holds when the newer request succeeds. If one handshake flips both assetsEnabled and supportsModelTypeTags and the second reload rejects or hangs, the first reload's result is discarded as stale and nothing commits, leaving folders built for the previous API/tag scheme. Raised by 1 of 8 reviewers (gpt-5.6-sol-max edge-case).
There was a problem hiding this comment.
Rejected: out of scope for a backport (identical to #17117 on main); noted for main.
| test.beforeEach(async ({ assetApi: _, comfyPage }) => { | ||
| await comfyPage.featureFlags.setServerFlagsPersistent({ | ||
| supports_model_type_tags: true | ||
| supports_model_type_tags: true, |
There was a problem hiding this comment.
🟢 Low — setServerFlagsPersistent mutates the flags on an already-booted app, so adding assets: true here now trips the new modelStore watcher immediately and the walk request can complete before waitForResponse is attached two lines below, hanging this beforeEach. The replaced initialSettings applied before page load, so no mid-test flip occurred; register the response promise before flipping the flag. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
There was a problem hiding this comment.
Rejected: nothing loads folder contents before the tab opens, so the flip only fetches folder names.
| reportError(new Error(error.message), { | ||
| errorType: 'model_node_creation_failure', | ||
| tags: { code: error.code }, | ||
| context: { assetId: error.assetId, details: error.details } |
There was a problem hiding this comment.
🟢 Low — error.details is forwarded verbatim into reportError context, which lands in Sentry extra and Datadog RUM, whereas the replaced code only wrote to the local console. Depending on the failure path that blob can carry asset payloads, model filenames, and tags; consider reporting code/assetId only, or redacting details before it leaves the machine. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
There was a problem hiding this comment.
Rejected: details carries validation errors, tags and node types, nothing sensitive.
| nonCloud: /^return\s*(?:false|!1)\s*;?$/, | ||
| cloud: | ||
| /^return\s*(?:!!\s*)?[\w$.]+(?:\(\))?\.get\(\s*(['"`])Comfy\.Assets\.UseAssetAPI\1\s*\)\s*;?$/ | ||
| cloud: /^return\s*(?:true|!0)\s*;?$/ |
There was a problem hiding this comment.
🟢 Low — With the cloud leg reduced to a static true/!0, both legs now assert a constant the bundler already folds — and a function whose entire body is a build-time constant is a prime inlining candidate, which would make assetApiGates throw Expected one widget asset-picker gate ... found 0 on a build that is perfectly safe. Worth pinning the symbol against inlining (or checking the sourcemap) rather than relying on output.keepNames alone; note also that the CI error text in build-cloud-frontend/action.yaml still frames failures as the gate 'correctly rejecting an unsafe build', which overstates what the cloud leg proves now. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
There was a problem hiding this comment.
Rejected: an inlined gate makes the checker fail loudly. It can't let an unsafe build pass.
…e node/title/widget state (#18075) Manual backport of #18075 to core/1.54. Automated backport failed: #18075 (comment) Cherry-picked from 96821ac. Dependency check: the bot flagged a possible stacking conflict with #18727, #18722, #18683, #17872 (all still open against core/1.54). None of those touch graphMutations.ts, graphMutations.test.ts or agentConversationFixture.ts, so they are not the cause. The real causes: - graphMutations.ts: core/1.54 predates #18191 ("keep the ghost placement flag out of the document"), which hoisted node flags into a local `flags` variable (`cloneNodeFlags`) reused by `lastSerialization`. #18191 has no needs-backport label and was never backported here. Resolved by keeping core/1.54's existing flags handling (`cloneRecord(payload.flags)` / `structuredClone(payload)`) and porting only #18075's actual change: `resolveNodeTitle` plus the new `titleReconcileBaseline` field. - graphMutations.test.ts: pure insertion, no real conflict — accepted the new test cases as-is. - browser_tests/fixtures/agentConversationFixture.ts and the new browser_tests/tests/agent/agentCrdtReconcileOverwrite.spec.ts: this fixture (and the wider main-only agent Playwright test scaffolding it depends on, e.g. agentTabSwitchCatchUp.spec.ts) does not exist on core/1.54 at all — introduced by main-only work, not by any of the PRs above. Dropped from this backport along with the Topbar.ts#openBlankTabAndReturn() helper added only for that spec, so the branch keeps compiling. The runtime fix ships with its Vitest regression coverage (graphMutations.test.ts, agentNodeMaterializer.test.ts); the e2e visual-proof spec is left for a follow-up once the agent Playwright fixture infrastructure itself is backported. Validation on this branch: - pnpm exec vitest run src/workbench/extensions/agent - pnpm exec eslint / pnpm exec oxfmt --check on touched files - pnpm typecheck
…e node/title/widget state (#18075) (#18758) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-org.slack.com/archives/C0BGH348Z0C/p1789514768597649)_ Manual backport of #18075 to `core/1.54`. The automated backport failed with merge conflicts: #18075 (comment) Cherry-picked from `96821ace03bc81d7a29965751a401fcf1818cae3` (`git cherry-pick -x -m 1`). ## Dependency check The bot flagged a possible stacking conflict with #18727, #18722, #18683, #17872 (all still open against `core/1.54`). None of them touch `graphMutations.ts`, `graphMutations.test.ts`, or `agentConversationFixture.ts` — they are not the cause of this conflict. The real causes: - **`graphMutations.ts`** — `core/1.54` predates #18191 ("keep the ghost placement flag out of the document"), which hoisted node flags into a local `flags` variable (`cloneNodeFlags`) that `lastSerialization` also started reusing. #18191 is merged to `main` but carries no `needs-backport` label and was never backported to `core/1.54`. Resolved by keeping `core/1.54`'s existing flags handling (`flags: cloneRecord(payload.flags)` / `lastSerialization: structuredClone(payload)`) and porting only #18075's actual change: `resolveNodeTitle(payload, incumbent)` for the title, plus the new `titleReconcileBaseline` field feeding it. - **`graphMutations.test.ts`** — pure insertion (no code on the `HEAD` side of the conflict), accepted the new test cases as-is. - **`browser_tests/fixtures/agentConversationFixture.ts`** and the new **`browser_tests/tests/agent/agentCrdtReconcileOverwrite.spec.ts`** — this Playwright fixture (and the wider main-only agent-test scaffolding it depends on, e.g. `agentTabSwitchCatchUp.spec.ts`) does not exist on `core/1.54` at all; it isn't introduced by any of the PRs above. Dropped from this backport, along with the `Topbar.ts#openBlankTabAndReturn()` helper added only for that spec, so the branch keeps compiling. The runtime fix ships with its Vitest regression coverage (`graphMutations.test.ts`, `agentNodeMaterializer.test.ts`); the e2e visual-proof spec is left for a follow-up once the agent Playwright fixture infrastructure itself is backported. ## Validation - `pnpm exec vitest run src/workbench/extensions/agent` — 1 pre-existing, unrelated failure in `AgentPanelRoot.test.ts` (confirmed present on `core/1.54` before this backport, untouched by this diff); everything else passes, including the 2 intentional `it.fails` cases this PR introduces. - `pnpm exec eslint` / `pnpm exec oxfmt --check` clean on all touched files. - `pnpm typecheck` clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01L4WMaCPdk7KSva7vwKfz19 --- _Generated by [Claude Code](https://claude.ai/code/session_01L4WMaCPdk7KSva7vwKfz19)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
…assets flag, retire Comfy.Assets.UseAssetAPI (#18729) Manual backport of #17117 to `core/1.53`. The automated backport failed with merge conflicts (#17117 (comment)). Cherry-picked from dffad2d (`git cherry-pick -x`). ## Why On `core/1.53`, the hidden `Comfy.Assets.UseAssetAPI` setting and the `Comfy.ToggleAssetAPI` / `Comfy.BrowseModelAssets` palette commands can put the model library in asset mode against a server that doesn't advertise the `assets` feature, so it calls `/api/assets` on a backend that doesn't serve it. This ties the model library, sidebar tab, model store and those commands to the server assets flag (`useFeatureFlags().flags.assetsEnabled`) and removes the setting and toggle command. ## Dependency check No open PRs target `core/1.53`. As with #18727 (`core/1.54`) and #18728 (`cloud/1.54`), the conflicts are real and come from main-only test-mock migrations and files that don't exist on this branch. ## Conflict resolution 14 files: - `.github/actions/build-cloud-frontend/action.yaml`: kept `core/1.53`. #17117 only reworded a step that isn't present here. - `scripts/checkAssetsFlagArtifact.ts`, `scripts/checkAssetsFlagArtifact.test.ts`: not carried. They, and the CI wiring and build manifest they depend on, come from #16480 and #16570, which aren't on `core/1.53`. Verified locally that the gate still compiles to the expected per-distribution constant on this branch. Adding the check to 1.53 would be a separate backport of those PRs. - `src/stores/modelStore.ts`, `src/stores/workspace/sidebarTabStore.ts`, `src/composables/useCoreCommands.ts`: took #17117. `usesAssetApi` and `Comfy.ToggleAssetAPI` are removed, and `Comfy.BrowseModelAssets` opens through `openModelLibraryBrowser()`. - `src/platform/assets/services/assetService.ts`: took the `isWidgetAssetPickerEnabled` rename and dropped `EXPERIMENTAL_WARNING`. Kept `core/1.53`'s `result.error ? … : 'Unknown validation error'` guard in `getAssetDetails`. - Unit tests (`ModelLibrarySidebarTab.test.ts`, `useCoreCommands.test.ts`, `assetService.test.ts`, `assetPreviewUtil.test.ts`, `useComboWidget.test.ts`, `modelStore.test.ts`, `sidebarTabStore.test.ts`): kept `core/1.53`'s mocking style and ported only the setting-to-flag change. `modelStore.test.ts` also takes #17117's `remoteConfig` holder mock so state doesn't leak between tests. No other changes from main are included. ## Validation - `pnpm typecheck` and `pnpm typecheck:browser`: clean - `eslint` on changed files: clean - `vitest run` on the touched tests: 292 passed (`modelStore.test.ts` 46/46) - Local e2e against a real ComfyUI backend without `--enable-assets`, with a temporary request guard that is not included in this PR: - Targeted spec: 10/10 passed with no `/api/assets*` requests, including a user with a stale persisted `Comfy.Assets.UseAssetAPI=true`. - Full non-cloud e2e run: no unexpected `/api/assets*` requests. - Negative control: the same guard on unpatched `core/1.53` recorded `/api/assets` and `/api/assets/seed` requests with the server flag off.
|
Please hold approval for now: |
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed on merit as part of the core/1.54 queue drain now that #18823 has repaired the branch (row bp-3).
Verdict: technically sound, no adaptation defect. Not merged by this pass — see "who acts" below.
What I verified
The specific risk on this branch right now is the class that caused the six-hour outage: carrier #18722 landed a file importing @/platform/remote/comfyui/types, a module that exists on main and not on core/1.54. A backport that is merely green on a stale base can still carry that. So I tested the merge result, not the branch in isolation.
Merged d430bbcc7168eb49e242c8c787859d8a7c78920c onto the current repaired tip 9439d31a3e4730690180701d232fd47de381e55d locally — clean, no conflicts — and ran the three checks that actually catch a missing dependency:
| Check | Result at the merge result |
|---|---|
pnpm typecheck |
clean |
pnpm typecheck:browser |
clean |
pnpm knip:no-cache |
clean |
typecheck:browser (vue-tsc over browser_tests/) and knip are what lint-and-format runs, and they are exactly what a main-only import path trips. No #18722-class defect in this carrier. src/platform/assets/composables/openModelLibraryBrowser.ts is added by the diff itself rather than assumed present, which is the correct handling.
The conflict-resolution write-up in the PR body is unusually good — the point that all 7 conflicts are unit tests and each keeps core/1.54's mocking style while porting only the setting-to-flag change matches what I see in the diff. Dropping the main-only vi.mock(import(...)) and global-Pinia migrations is right; those are harness refactors, not behaviour.
Two things before this merges
- It needs
gh pr update-branchand fresh CI. Its current greenlint-and-formatran at a head that predates #18722 (merge-basewith the tip isec1f98d6a8), so it has never been tested against the break or the repair. My local run above is evidence that it will pass, not a substitute for the required check at the real head. Refreshing is also what makes it mergeable — it isBLOCKEDtoday. - Expect
Vercel – billing-web-testto fail. It fails identically on every PR on this branch regardless of diff; it is a branch-wide Vercel git-integration artifact. Recorded exception with a 2026-10-09 sunset in this program's backport policy. It waives that one status and nothing else.
Who acts
Not this program. Our core/1.54 merge grant is scoped to Agent backports and proved prerequisites; #17117 is asset-surface gating and falls outside it, so a merge here is the owning team's call, not ours — which is why this is a COMMENT and not an approval.
I am also deliberately not approving: backport-auto-merge.yaml merges a backport-labelled PR immediately on approval once required checks are green, so approving this while it sits on a pre-repair base would merge it unbound to any head I actually reviewed. That is the same shape as the bypass that broke this branch. Refresh first, then approve.
@synap5e — over to you for (1); the change itself reads good to me.
Receipt: reports/jobs/bp-3.md.
|
One constraint to add to the "refresh, then approve" step, because it is not removed by refreshing. @synap5e asked on this PR at 04:01Z to hold approval so this lands together with the backport of #18781. That backport does not exist yet: #18781 is still open against The reason is the window that is already open on So there are two independent gates here, and the refresh only clears the first:
Worth being explicit because |
christian-byrne
left a comment
There was a problem hiding this comment.
Verified rather than rubber-stamped: the changed-file list matches the original PR exactly, and the diff contains no conflict markers. Required checks on this branch are lint-and-format, test and e2e-status; any other red check here is advisory and does not gate the merge.
Manual backport of #17117 to
core/1.54. The automated backport failed with merge conflicts (#17117 (comment)).Cherry-picked from dffad2d (
git cherry-pick -x).Why
#17117 retires the hidden
Comfy.Assets.UseAssetAPIsetting and theComfy.ToggleAssetAPIcommand. The model library, sidebar tab and model store followuseFeatureFlags().flags.assetsEnabled(cloud, or the server advertises theassetsfeature).Comfy.BrowseModelAssetsopens the browser throughopenModelLibraryBrowser(), and the widget asset-picker gate is renamed toshouldUseWidgetAssetPicker/isWidgetAssetPickerEnabledand fixed toisCloud. Without it, a stale persisted setting can still route the model library to/api/assetson a backend that doesn't serve it.Dependency check
The bot flagged a possible stacking conflict with #18722, #18683, #18334 and #17872. None of the four touch any file changed by #17117, so they aren't the cause. The conflicts are real and come from main-only test refactors that aren't on
core/1.54: thevi.mock(import(...))migrations (#17173, #17175, #17176, #17178, #17179) and the global-Pinia test migrations (#17231, #17234, #17235, #17236, #17237, #17270), plus #16891. All production code, locale, script and e2e changes applied cleanly.Conflict resolution
All 7 conflicts were in unit tests. Each one keeps
core/1.54's mocking style (hoistedvi.mockstores, no global Pinia) and ports only the setting-to-flag change:src/components/sidebar/tabs/ModelLibrarySidebarTab.test.ts: kept the target's store/download/setting mocks. Dropped theComfy.Assets.UseAssetAPIbranch and added auseFeatureFlagsmock (featureFlagState.assetsEnabled) in its place.src/composables/useCoreCommands.test.ts: kept the target's mocks andcreateMockSettingStore. Added theuseFeatureFlagsmock. TheBrowseModelAssetstests toggleassetsEnabledinstead of the setting.src/platform/assets/services/assetService.test.ts: kept the target's imports and mocks. Took the rename toshouldUseWidgetAssetPickerand removed the setting-store mock.src/platform/assets/utils/assetPreviewUtil.test.ts: kept the target'svi.mockstyle. Added theuseFeatureFlagsmock and removed theisAssetAPIEnabled/getServerFeaturemocks.src/renderer/extensions/vueNodes/widgets/composables/useComboWidget.test.ts: kept the target's two remote-combo tests, which are absent on main. Took the renamed test and theshouldUseWidgetAssetPickermock.src/stores/modelStore.test.ts: kept the target'smockDistributionmock. Took refactor(assets): gate asset surfaces on server assets flag, retire Comfy.Assets.UseAssetAPI #17117'sremoteConfigholder mock and reactiveserverFeaturesstate, so the store's flag watcher fires and state doesn't leak between tests.src/stores/workspace/sidebarTabStore.test.ts: kept the target's command/menu/setting store mocks. Added theuseFeatureFlagsandopenModelLibraryBrowsermocks and dropped theComfy.Assets.UseAssetAPIsetting reads.No other changes from main are included.
Validation
Comfy.Assets.UseAssetAPI,isAssetAPIEnabled,shouldUseAssetBrowser,ToggleAssetAPIorusesAssetApireferences insrc,browser_tests,scriptsor.github.pnpm install --frozen-lockfile: okpnpm typecheck: cleaneslint,oxlint,oxfmt --checkon changed files: 0 errorsvitest runon the touched tests plussrc/stores,src/platform/assets,src/components/sidebarandsrc/composables/useFeatureFlags*: 129 files, 2339 passedvitest runonscripts/checkAssetsFlagArtifact.test.ts,widgetInputs,missingModelPipeline,src/renderer/extensions/vueNodes/widgetsanduseCoreCommands: 66 files, 960 passedvite buildfollowed byEXPECTED_DISTRIBUTION=localhost EXPECTED_FRONTEND_COMMIT=<HEAD> pnpm test:assets-flag-artifact: pass--enable-assets(/api/featuresreportsassets: false), with a temporary request guard that is not included in this PR:Comfy.Assets.UseAssetAPI=true. No/api/assets*requests were made.browser_tests/tests/sidebar/modelLibrary.spec.ts: 13/13 passed with no/api/assets*requests.