Repository navigation
test: pin PM-1303 Flux2ImageNode prompt box collapse across generations - #18098
Conversation
Candidate repros for the prompt text box vanishing after a second generation on a Flux2ImageNode, one per hypothesis: - A (widget re-registration / type reset) and B (autogrow splice) pass on the localhost execution path, ruling them out there. - C (CRDT follower reconcile overwriting the prompt) reproduces as a Vitest it.fails on a live litegraph node: the catch-up frame rewrites the typed prompt with the doc's mint-time empty string. - D (persistent progress-text row) reproduces as Playwright test.fail: showTextPreview's $$node-text-preview widget is never removed after execution_success, and its expanding grid row plus the image preview shrink the prompt textarea from ~243px to ~58px inside the node. The screenshot test documents that on this path the textarea collapses rather than leaving the DOM.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2054 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.93 MB gzip 🔴 +320 BDetailsSummary
Category Glance App Entry Points — 3.81 kB (baseline 3.81 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 638 kB (baseline 638 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.87 MB (baseline 3.86 MB) • 🔴 +771 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 566 kB (baseline 566 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 19 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.7 MB (baseline 17.7 MB) • ⚪ 0 BBundles that do not match a named category
Status: 73 added / 73 removed / 227 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-20T08:14:30.848Z",
"gitSha": "8564ffd7502868509bccc938fa765ec4163b3247",
"branch": "test/pm-1303-flux-prompt-textbox-vanish-repro",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1992.5289999999904,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.2700000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 268.36000000000007,
"heapDeltaBytes": 14711112,
"heapUsedBytes": 76706576,
"domNodes": -259,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 5.864000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1991.6190000000142,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.181,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 277.84,
"heapDeltaBytes": -4990388,
"heapUsedBytes": 57328652,
"domNodes": -261,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 10.337999999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1692.5800000000208,
"styleRecalcs": 74,
"styleRecalcDurationMs": 22.798,
"layouts": 14,
"layoutDurationMs": 4.500000000000001,
"taskDurationMs": 565.858,
"heapDeltaBytes": 67272,
"heapUsedBytes": 62370396,
"domNodes": -261,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 108.93700000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1693.61200000003,
"styleRecalcs": 73,
"styleRecalcDurationMs": 24.621,
"layouts": 14,
"layoutDurationMs": 4.651,
"taskDurationMs": 583.3699999999999,
"heapDeltaBytes": 15687948,
"heapUsedBytes": 77457644,
"domNodes": -259,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 111.38300000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.5439999999608,
"styleRecalcs": 31,
"styleRecalcDurationMs": 11.668999999999999,
"layouts": 6,
"layoutDurationMs": 1.1400000000000001,
"taskDurationMs": 205.756,
"heapDeltaBytes": 1820460,
"heapUsedBytes": 64097784,
"domNodes": 75,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8.788000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.8180000000884,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.171999999999999,
"layouts": 6,
"layoutDurationMs": 1.145,
"taskDurationMs": 236.504,
"heapDeltaBytes": 2819628,
"heapUsedBytes": 69924064,
"domNodes": 76,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 10.929000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 434.0310000000045,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.372999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 284.292,
"heapDeltaBytes": 18058348,
"heapUsedBytes": 80404644,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 105.334,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 558.9519999999766,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.918000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.421,
"heapDeltaBytes": 17845768,
"heapUsedBytes": 79884200,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 126.04200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 1995.1709999999707,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.087,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 356.828,
"heapDeltaBytes": 1064596,
"heapUsedBytes": 79447240,
"domNodes": -247,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 25.155000000000005,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2026.9079999999349,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.751,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 345.77599999999995,
"heapDeltaBytes": 2766916,
"heapUsedBytes": 82514320,
"domNodes": -239,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 28.843,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2098.6219999999776,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.257,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1050.079,
"heapDeltaBytes": 15435848,
"heapUsedBytes": 79447708,
"domNodes": -248,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 532.278,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2104.697999999985,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.090999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1012.8300000000002,
"heapDeltaBytes": 19424008,
"heapUsedBytes": 83524220,
"domNodes": 10,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 529.376,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3123.708000000022,
"styleRecalcs": 67,
"styleRecalcDurationMs": 15.706999999999999,
"layouts": 60,
"layoutDurationMs": 14.261,
"taskDurationMs": 1167.578,
"heapDeltaBytes": -12603320,
"heapUsedBytes": 67983956,
"domNodes": -261,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 510.656,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3151.5759999999773,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.716000000000001,
"layouts": 60,
"layoutDurationMs": 14.417000000000002,
"taskDurationMs": 1137.3580000000002,
"heapDeltaBytes": 7827088,
"heapUsedBytes": 73979312,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 515.343,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2110.983000000033,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.072000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1219.9710000000002,
"heapDeltaBytes": 20818780,
"heapUsedBytes": 86526836,
"domNodes": 10,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 627.4949999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2236.4080000000968,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.598000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1267.7179999999998,
"heapDeltaBytes": 17174528,
"heapUsedBytes": 82734108,
"domNodes": 8,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 640.44,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2009.172000000035,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.989000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 344.27099999999996,
"heapDeltaBytes": -3597952,
"heapUsedBytes": 83703628,
"domNodes": -241,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 25.759999999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2021.349999999984,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.9060000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.26900000000006,
"heapDeltaBytes": -3365612,
"heapUsedBytes": 83910348,
"domNodes": -246,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 27.027999999999995,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 446.9509999999559,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.25,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 283.471,
"heapDeltaBytes": 14158208,
"heapUsedBytes": 76984988,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 98.48899999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 437.8320000000713,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.180000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 292.072,
"heapDeltaBytes": 14439532,
"heapUsedBytes": 78018120,
"domNodes": 21,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 100.634,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1988.2029999999986,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.799,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 270.882,
"heapDeltaBytes": 1689752,
"heapUsedBytes": 65090436,
"domNodes": -273,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 5.0070000000000014,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1987.936999999988,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.321,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 331.421,
"heapDeltaBytes": -3409064,
"heapUsedBytes": 60202640,
"domNodes": -273,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.886,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1687.3560000000225,
"styleRecalcs": 80,
"styleRecalcDurationMs": 25.159000000000002,
"layouts": 18,
"layoutDurationMs": 5.836,
"taskDurationMs": 539.7120000000001,
"heapDeltaBytes": 6142964,
"heapUsedBytes": 75523948,
"domNodes": -272,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 77.39999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1673.3239999999796,
"styleRecalcs": 80,
"styleRecalcDurationMs": 24.552,
"layouts": 18,
"layoutDurationMs": 5.271,
"taskDurationMs": 546.3420000000001,
"heapDeltaBytes": -1492576,
"heapUsedBytes": 62037692,
"domNodes": -273,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 82.921,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 783.284999999978,
"styleRecalcs": 18,
"styleRecalcDurationMs": 19.394999999999996,
"layouts": 5,
"layoutDurationMs": 8.338,
"taskDurationMs": 571.558,
"heapDeltaBytes": -8279808,
"heapUsedBytes": 81028012,
"domNodes": 13587,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 19.352,
"eventListeners": 2383,
"totalBlockingTimeMs": 70,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8165.2520000000095,
"styleRecalcs": 248,
"styleRecalcDurationMs": 40.872,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3960.718,
"heapDeltaBytes": -1267028,
"heapUsedBytes": 78016812,
"domNodes": -242,
"jsHeapTotalBytes": 479232,
"scriptDurationMs": 1915.552,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8428.526000000034,
"styleRecalcs": 249,
"styleRecalcDurationMs": 43.238,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4144.215,
"heapDeltaBytes": 404348,
"heapUsedBytes": 80019632,
"domNodes": -244,
"jsHeapTotalBytes": -569344,
"scriptDurationMs": 1990.8849999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11819.327999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11213.129,
"heapDeltaBytes": -43818320,
"heapUsedBytes": 186499368,
"domNodes": -8061,
"jsHeapTotalBytes": -8183808,
"scriptDurationMs": 150.542,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 11812.211000000047,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11118.203,
"heapDeltaBytes": -27510640,
"heapUsedBytes": 194291672,
"domNodes": -8062,
"jsHeapTotalBytes": -15187968,
"scriptDurationMs": 179.99200000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13975.048000000015,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.587999999999989,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13714.972,
"heapDeltaBytes": -32835080,
"heapUsedBytes": 197472628,
"domNodes": -8062,
"jsHeapTotalBytes": -4276224,
"scriptDurationMs": 602.375,
"eventListeners": -14928,
"totalBlockingTimeMs": 24,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14221.834000000057,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.046999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13788.695,
"heapDeltaBytes": -51995872,
"heapUsedBytes": 178478384,
"domNodes": -8061,
"jsHeapTotalBytes": -15523840,
"scriptDurationMs": 596.736,
"eventListeners": -14928,
"totalBlockingTimeMs": 3,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4475.392,
"styleRecalcs": 20,
"styleRecalcDurationMs": 55.463000000000015,
"layouts": 20,
"layoutDurationMs": 23.923,
"taskDurationMs": 4451.542999999999,
"heapDeltaBytes": -37995036,
"heapUsedBytes": 196743088,
"domNodes": -8062,
"jsHeapTotalBytes": 17031168,
"scriptDurationMs": 71.14,
"eventListeners": -14928,
"totalBlockingTimeMs": 118,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4261.175999999978,
"styleRecalcs": 20,
"styleRecalcDurationMs": 52.71199999999998,
"layouts": 20,
"layoutDurationMs": 20.882000000000012,
"taskDurationMs": 4192.699,
"heapDeltaBytes": -52826368,
"heapUsedBytes": 178120816,
"domNodes": -8062,
"jsHeapTotalBytes": 22224896,
"scriptDurationMs": 65.194,
"eventListeners": -14928,
"totalBlockingTimeMs": 22,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6030.549000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5860.117000000001,
"heapDeltaBytes": 34400624,
"heapUsedBytes": 196556928,
"domNodes": 0,
"jsHeapTotalBytes": -19922944,
"scriptDurationMs": 85.99699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5863.191999999913,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5561.906000000001,
"heapDeltaBytes": -20709976,
"heapUsedBytes": 169371708,
"domNodes": 0,
"jsHeapTotalBytes": -18612224,
"scriptDurationMs": 76.409,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 445.5409999999347,
"styleRecalcs": 15,
"styleRecalcDurationMs": 21.966,
"layouts": 5,
"layoutDurationMs": 2.5500000000000003,
"taskDurationMs": 103.75400000000002,
"heapDeltaBytes": 5165244,
"heapUsedBytes": 66722012,
"domNodes": 149,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.649000000000001,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 67.64800000007654,
"styleRecalcs": 4,
"styleRecalcDurationMs": 10.384999999999998,
"layouts": 3,
"layoutDurationMs": 1.365,
"taskDurationMs": 52.074,
"heapDeltaBytes": 3055644,
"heapUsedBytes": 64889384,
"domNodes": 127,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 4.559,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 38cc119a2141464c267d0b8c3b3b7c3bb148af97
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Updating Playwright Expectations |
|
Investigated the 1. Missing Linux baselines (expected, per The 2. A second, unrelated failure worth a look: hypothesis D (Running status line) unexpectedly passed in CI
I didn't touch the test file since resolving it means a judgment call on the actual investigation conclusion (is the status line reliably cleared on CI's headless path and the local repro was environment-specific, or is this timing-flaky). Worth a re-run/second look before merging — if it keeps unexpectedly passing, the Generated by Claude Code |
The "Running status line is cleared" test.fail() disagreed with the PR's local repro on CI (Expected to fail, but passed), because whether the leftover $$node-text-preview text renders as hidden is a layout-timing race, not a reliable signal of whether the row was ever removed. Keep the height-collapse test.fail() as the stable D repro.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18098 +/- ##
==========================================
+ Coverage 82.77% 83.86% +1.08%
==========================================
Files 2936 2254 -682
Lines 144439 128307 -16132
Branches 39004 33165 -5839
==========================================
- Hits 119562 107600 -11962
+ Misses 23620 20418 -3202
+ Partials 1257 289 -968
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 811 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium Recorded test titles:
|
| snapshot | status | changed pixels | | --- | --- | --- | | `tests/vueNodes/widgets/flux2ImagePromptRerun.spec.ts-snapshots/flux2-prompt-after-run-1-chromium-linux.png` | new | n/a | | `tests/vueNodes/widgets/flux2ImagePromptRerun.spec.ts-snapshots/flux2-prompt-after-run-2-chromium-linux.png` | new | n/a | | `tests/vueNodes/widgets/flux2ImagePromptRerun.spec.ts-snapshots/flux2-prompt-before-runs-chromium-linux.png` | new | n/a | Screenshot capture is not bit-deterministic; small pixel deltas are usually text rasterization noise. Confirm each rewrite corresponds to a test expected to change.
useNodeProgressText().removeTextPreview had no callers, so the $$node-text-preview row added by showTextPreview during a run's progress_text events was never cleared. Its EXPANDING_TYPES row then kept the node's completed status line forever, starving the prompt textarea's height on Flux2ImageNode (PM-1303/PM-1310). Clear it for every node in the job at the same point execution state is reset (success, error, and interrupted all funnel through resetExecutionState), symmetric to where it is added in handleProgressText. Flips hypothesis D from test.fail() to a normal assertion now that the textarea keeps its height across two generations.
…oval removeTextPreview spliced the $$node-text-preview widget out of node.widgets but never removed it from widgetValueStore, which is what Vue node rendering actually keys its widget list off of (see the ADR-ECS-0008 store-over-instance-state architecture). The stale store entry kept its row in the node's grid layout after resetExecutionState called removeTextPreview, so the prompt textarea stayed collapsed across generations even though the litegraph model was clean — exactly the failure the new playwright tests (hypothesis D, screenshot) caught in CI. Call widgetValueStore().deleteWidget() alongside the node.widgets splice so the store's node-widget order drops the id too.
The store-registration fix (f81f88f) correctly removes the stale $$node-text-preview widget from node.widgets and widgetValueStore (the after-run-1 screenshot shrinks by ~57px once the row is gone, proving the removal fires), but the prompt textarea never reclaims that freed grid row and stays collapsed at ~58px across two generations. CI confirmed this deterministically across 3 retries on the same commit (identical 57.600006103515625 height each time), so this is not a timing flake. The remaining bug is in how WidgetGrid.vue's auto-sized rows do (not) redistribute freed space back to a surviving expanding widget, not in leftover widget-registration state, so it needs a separate fix. Revert the hypothesis-D assertion to test.fail() so it documents the real, still-open regression instead of asserting a fix that CI shows is incomplete.
|
Root-caused the Not a flake, not a stale-baseline-only issue. Both failures reproduced deterministically — the sharded job retried the height assertion 3x and got the identical What's actually happening: the two follow-up fixes ( But the prompt textarea itself never reclaims that freed height — it stays collapsed at ~58px across both generations, identical to the original bug report. So hypothesis D still reproduces; the earlier commit's move from Given this PR's own stated scope ("No fix code" — pin repros for each hypothesis), I reverted the hypothesis-D assertion back to Also applied Generated by Claude Code |
|
The "1 failed" on dafaba3 is Cause: the committed baseline (from Also found: the Generated by Claude Code |
| snapshot | status | changed pixels | | --- | --- | --- | | `tests/vueNodes/widgets/flux2ImagePromptRerun.spec.ts-snapshots/flux2-prompt-after-run-1-chromium-linux.png` | modified | 28238B -> 25653B | | `tests/vueNodes/widgets/flux2ImagePromptRerun.spec.ts-snapshots/flux2-prompt-after-run-2-chromium-linux.png` | modified | 28238B -> 25653B | Screenshot capture is not bit-deterministic; small pixel deltas are usually text rasterization noise. Confirm each rewrite corresponds to a test expected to change.
christian-byrne
left a comment
There was a problem hiding this comment.
The bounded progress-widget cleanup is verified. The original prompt-height defect remains open and transfers to the completion lane on merge.
Full context for agent readers
Reviewed terminal success/error/interruption cleanup, widget registry removal, workflow identity and subgraph-scoped node resolution. Review found a cross-workflow same-node-ID bug; its counterexample failed before the repair and passes now. All 141 execution-store tests pass. Browser checks pass for retained prompt type/value, widget ordering and cleanup from both node and registry. The existing height-collapse test remains expected-failing; the inspected recording shows intact text and no stale Running line, but a still-collapsed textarea. Source/browser types, lint, format, Cloud build and push-time Knip pass.
The full screenshot scenario previously stopped at an eight-pixel initial-baseline mismatch; no golden was rewritten. A mismatched Cloud-build/Chromium-project attempt failed at boot and was replaced by the correct localhost-surface run, not counted as acceptance. The separate synchronized-document overwrite reproduction remains expected-failing and is not fixed by cleanup.
Remaining assignment and release acceptance stay open with Christian's completion lane and the program successor. Neither 1.54 target is qualified for automatic backport labels. Native checks and normal merge queue remain gates.
Glossary: expected failure records an unresolved defect; widget registry stores widget identity/value separately from the live node.
…fixture The prompt-reconcile suite added on main (#18098) constructs createGraphMutations without the placement port this branch made a required dependency, so every CI job that typechecks the PR merge ref failed. The inert placement fixture keeps that suite's behavior unchanged.
## Summary Keep expanding prompt widgets usable when an image preview appears after generation. ## Changes - Reserve preview height only for image nodes with expanding widgets. Image-only galleries keep their flexible sizing. - Remove the transient preview allowance when saving a user resize, avoiding repeated-generation size growth. - Turn the remaining expected failure from #18098 into a passing regression test. ## Review Focus Preview height allocation and authored versus rendered node size. This fixes the reproduced prompt-collapse symptom, not every reported workflow-overwrite issue in [the Flux incident](https://linear.app/comfyorg/issue/PM-1303) and [its reproduction task](https://linear.app/comfyorg/issue/PM-1310). Those incidents and release acceptance remain open with the program completion owner. <details><summary>Full context for agent readers</summary> Validated on Node 26.8.2: five Flux repeated-generation browser cases plus the existing image-grid vertical/horizontal resize case; 22 LGraphNode component tests; main/browser typechecks; targeted lint/format and commit hooks. The parent independently repeated all six browser cases and inspected the after-second-generation screenshot. The initial broad preview allocation failed image-grid resizing and was corrected before publication. The preview allowance is 220px minimum image height + 8px preview margin + 4px content gap. It applies only when the widget registry says a rendered widget expands. No backend or persisted workflow schema changes. Tracking: program task claude-handoff-9 retains the original incident, stale-document overwrite discrimination and core/1.54 plus cloud/1.54 qualification. Backport labels require independent release-target qualification; this source PR alone is not release completion. </details>
|
|
|
|
…ns (#18098) Remove stale execution progress widgets. Preserve other workflows' widgets. Prompt-height collapse remains unresolved. <details><summary>Full context for agent readers</summary> This began as reproduction-only coverage, but now includes production cleanup in `executionStore`: completion, interruption and error remove the progress widget from the viewed workflow before queued-job state is deleted. Review found and repaired a cross-workflow bug: identical node IDs in another tab must not be cleaned up. Cleanup also uses the existing subgraph-aware execution-ID mapping. This is a partial fix for the [Flux prompt incident](https://linear.app/comfyorg/issue/PM-1303) and its [reproduction task](https://linear.app/comfyorg/issue/PM-1310), not closure of either. The prompt stays registered and retains its typed text through two generations, but remains vertically collapsed. The height assertion stays expected-failing. A separate conflict-free replicated data type (CRDT) reconciliation test retains the known stale-snapshot value-overwrite reproduction; that is not fixed here. Christian's [completion lane](https://ampcode.com/threads/T-01a0bb17-0593-72cc-840e-4120f777fdf0) takes the broader assignment on merge: repair prompt-height allocation, resolve or rule out the Cloud reconciliation candidate against the original workflow, and verify both 1.54 releases. Program tracking is in `claude-handoff-9` on the [program board](https://github.com/christian-byrne/in-app-agent-program/blob/main/todo.md). No clean-backport label until full target-native source, API and fixture qualification. Original context: [Christian's Slack request](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789700733927729), [preserved Claude session](https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1). </details> - Execution store: 141 tests pass, including success/error/interruption cleanup and cross-workflow/subgraph exclusions. The cross-workflow counterexample failed before the guard. - Browser: prompt type, registration, and node/registry cleanup pass; retained height-collapse case remains expected-failing. The final recording shows intact text, no stale Running line, and a still-collapsed textarea. - Reconciliation reproduction: one pass, one existing expected failure. - Source/browser typechecks, lint/format and Cloud build pass. Native checks remain merge gates. - Full screenshot scenario retains a local eight-pixel initial-baseline mismatch; no golden was rewritten. A later mistaken Cloud-build/Chromium-project run failed during boot and is not counted as behavioral evidence. The successful rerun used the matching localhost surface and Chromium project. Glossary: progress widget is the temporary execution-status row; CRDT is the synchronized graph document; an expected failure records an unresolved defect, not a completed fix. --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: bymyself <cbyrne@comfy.org> ## Manual backport notes (core/1.54) Automated backport failed on `src/stores/executionStore.test.ts` (target's hoisted-mocks block already had more mocks than this PR's simpler version). Resolved by keeping target's block and adding `mockRemoveTextPreview` to it. Other fixes needed to make the cherry-pick compile/pass on this branch: - Added missing `fromPartial` (`@total-typescript/shoehorn`) and `useWorkflowStore` imports the new tests need, matching main's imports that target's test file predates. - Replaced `useWorkflowStore().activeWorkflow = ...` (target's mock exposes `activeWorkflow` as a read-only getter) with the existing `mockActiveWorkflow.value = ...` pattern already used elsewhere in this file, and set it from `store.queuedJobs['job-1'].workflow` (not the local `workflow` var) so it holds the same Vue-reactivity-wrapped reference as `queuedJobs`, matching production `workflowStore`/`queuedJobs` identity semantics that target's shallowRef-based mock doesn't reproduce otherwise. - Dropped `src/workbench/extensions/agent/crdt/ecsFollowerAdapter.promptReconcile.test.ts`. It imports `AgentCrdtProjection` from `./agentCrdtProjection`, a module that doesn't exist on core/1.54 (refactored away in #16908, split into `ecsFollowerAdapter.ts`/`graphMutations.ts`/`followerDoc.ts`). This test is an unrelated CRDT-reconciliation reproduction the PR body explicitly says is "not fixed here"; porting it to the refactored API is out of scope for this backport. Verified: `pnpm exec vitest run src/stores/executionStore.test.ts` (138/138 pass), `pnpm exec vue-tsc --noEmit`, `pnpm exec oxlint` all clean on this branch.
…ns (#18098) Remove stale execution progress widgets. Preserve other workflows' widgets. Prompt-height collapse remains unresolved. <details><summary>Full context for agent readers</summary> This began as reproduction-only coverage, but now includes production cleanup in `executionStore`: completion, interruption and error remove the progress widget from the viewed workflow before queued-job state is deleted. Review found and repaired a cross-workflow bug: identical node IDs in another tab must not be cleaned up. Cleanup also uses the existing subgraph-aware execution-ID mapping. This is a partial fix for the [Flux prompt incident](https://linear.app/comfyorg/issue/PM-1303) and its [reproduction task](https://linear.app/comfyorg/issue/PM-1310), not closure of either. The prompt stays registered and retains its typed text through two generations, but remains vertically collapsed. The height assertion stays expected-failing. A separate conflict-free replicated data type (CRDT) reconciliation test retains the known stale-snapshot value-overwrite reproduction; that is not fixed here. Christian's [completion lane](https://ampcode.com/threads/T-01a0bb17-0593-72cc-840e-4120f777fdf0) takes the broader assignment on merge: repair prompt-height allocation, resolve or rule out the Cloud reconciliation candidate against the original workflow, and verify both 1.54 releases. Program tracking is in `claude-handoff-9` on the [program board](https://github.com/christian-byrne/in-app-agent-program/blob/main/todo.md). No clean-backport label until full target-native source, API and fixture qualification. Original context: [Christian's Slack request](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789700733927729), [preserved Claude session](https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1). </details> - Execution store: 141 tests pass, including success/error/interruption cleanup and cross-workflow/subgraph exclusions. The cross-workflow counterexample failed before the guard. - Browser: prompt type, registration, and node/registry cleanup pass; retained height-collapse case remains expected-failing. The final recording shows intact text, no stale Running line, and a still-collapsed textarea. - Reconciliation reproduction: one pass, one existing expected failure. - Source/browser typechecks, lint/format and Cloud build pass. Native checks remain merge gates. - Full screenshot scenario retains a local eight-pixel initial-baseline mismatch; no golden was rewritten. A later mistaken Cloud-build/Chromium-project run failed during boot and is not counted as behavioral evidence. The successful rerun used the matching localhost surface and Chromium project. Glossary: progress widget is the temporary execution-status row; CRDT is the synchronized graph document; an expected failure records an unresolved defect, not a completed fix. --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: bymyself <cbyrne@comfy.org> ## Manual backport notes (cloud/1.54) Automated backport failed on `src/stores/executionStore.test.ts` (target's hoisted-mocks block already had more mocks than this PR's simpler version). Resolved by keeping target's block and adding `mockRemoveTextPreview` to it. Other fixes needed to make the cherry-pick compile/pass on this branch: - Added missing `fromPartial` (`@total-typescript/shoehorn`) and `useWorkflowStore` imports the new tests need, matching main's imports that target's test file predates. - Replaced `useWorkflowStore().activeWorkflow = ...` (target's mock exposes `activeWorkflow` as a read-only getter) with the existing `mockActiveWorkflow.value = ...` pattern already used elsewhere in this file, and set it from `store.queuedJobs['job-1'].workflow` (not the local `workflow` var) so it holds the same Vue-reactivity-wrapped reference as `queuedJobs`, matching production `workflowStore`/`queuedJobs` identity semantics that target's shallowRef-based mock doesn't reproduce otherwise. - Dropped `src/workbench/extensions/agent/crdt/ecsFollowerAdapter.promptReconcile.test.ts`. It imports `AgentCrdtProjection` from `./agentCrdtProjection`, a module that doesn't exist on cloud/1.54 (refactored away in #16908, split into `ecsFollowerAdapter.ts`/`graphMutations.ts`/`followerDoc.ts`). This test is an unrelated CRDT-reconciliation reproduction the PR body explicitly says is "not fixed here"; porting it to the refactored API is out of scope for this backport. Verified: `pnpm exec vitest run src/stores/executionStore.test.ts` (138/138 pass), `pnpm exec vue-tsc --noEmit`, `pnpm exec oxlint` all clean on this branch.
…apse across generations (#18098) (#18514) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789700733927729)_ Manual backport of #18098 to `core/1.54`. The automated backport failed with a merge conflict in `src/stores/executionStore.test.ts` (comment: #18098 (comment)). ## Why manual Target's hoisted-mocks block in the test file already had more mocks (from separate, already-landed test-infra work on this branch) than the version this PR's diff was based on. Resolved by keeping target's block and adding this PR's `mockRemoveTextPreview` mock into it, rather than accepting either side wholesale. Verified the diff is not already effectively present on `core/1.54` (`git diff --cached origin/core/1.54` was non-empty after the cherry-pick — this is a real, needed backport, not a stacking false-positive). ## Additional fixes required on top of the raw cherry-pick - Added missing `fromPartial` (`@total-typescript/shoehorn`) and `useWorkflowStore` imports the new tests need (present on `main`, absent from target's older version of the test file). - Target's `workflowStore` mock exposes `activeWorkflow` as a read-only getter (`useWorkflowStore().activeWorkflow = ...` throws). Switched the new tests to the existing `mockActiveWorkflow.value = ...` pattern already used elsewhere in the file, sourcing the value from `store.queuedJobs['job-1'].workflow` (not the local `workflow` var) so it carries the same Vue-reactivity-wrapped identity as `queuedJobs`, which is what the new production check (`job.workflow === workflowStore.activeWorkflow`) in `executionStore.ts` relies on. The target's `shallowRef`-based mock doesn't reproduce that identity automatically the way `main`'s un-mocked real Pinia store does. - Dropped `src/workbench/extensions/agent/crdt/ecsFollowerAdapter.promptReconcile.test.ts`. It imports `AgentCrdtProjection` from `./agentCrdtProjection`, a module that doesn't exist on `core/1.54` (refactored away in #16908, split into `ecsFollowerAdapter.ts`/`graphMutations.ts`/`followerDoc.ts`). This test is an unrelated CRDT-reconciliation reproduction that #18098's own description says is "not fixed here"; porting it to the refactored API is out of scope for this backport. ## Verification - `pnpm exec vitest run src/stores/executionStore.test.ts` — 138/138 pass - `pnpm exec vue-tsc --noEmit` — clean - `pnpm exec oxlint` on changed files — clean 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1 --- _Generated by [Claude Code](https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
…lapse across generations (#18098) (#18515) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789700733927729)_ Manual backport of #18098 to `cloud/1.54`. The automated backport failed with a merge conflict in `src/stores/executionStore.test.ts` (comment: #18098 (comment)). ## Why manual Same conflict shape as the `core/1.54` backport (#see companion PR): target's hoisted-mocks block in the test file already had more mocks than the version this PR's diff was based on. `cloud/1.54`'s pre-cherry-pick `executionStore.test.ts`/`executionStore.ts`/`useNodeProgressText.ts` are byte-identical to `core/1.54`'s, so the same resolution was reused verbatim. Verified the diff is not already effectively present on `cloud/1.54` (`git diff --cached origin/cloud/1.54` was non-empty after the cherry-pick — this is a real, needed backport, not a stacking false-positive). ## Additional fixes required on top of the raw cherry-pick - Added missing `fromPartial` (`@total-typescript/shoehorn`) and `useWorkflowStore` imports the new tests need (present on `main`, absent from target's older version of the test file). - Target's `workflowStore` mock exposes `activeWorkflow` as a read-only getter (`useWorkflowStore().activeWorkflow = ...` throws). Switched the new tests to the existing `mockActiveWorkflow.value = ...` pattern already used elsewhere in the file, sourcing the value from `store.queuedJobs['job-1'].workflow` (not the local `workflow` var) so it carries the same Vue-reactivity-wrapped identity as `queuedJobs`, which is what the new production check (`job.workflow === workflowStore.activeWorkflow`) in `executionStore.ts` relies on. - Dropped `src/workbench/extensions/agent/crdt/ecsFollowerAdapter.promptReconcile.test.ts`. It imports `AgentCrdtProjection` from `./agentCrdtProjection`, a module that doesn't exist on `cloud/1.54` (refactored away in #16908, split into `ecsFollowerAdapter.ts`/`graphMutations.ts`/`followerDoc.ts`). This test is an unrelated CRDT-reconciliation reproduction that #18098's own description says is "not fixed here"; porting it to the refactored API is out of scope for this backport. ## Verification - `pnpm exec vitest run src/stores/executionStore.test.ts` — 138/138 pass - `pnpm exec vue-tsc --noEmit` — clean - `pnpm exec oxlint` on changed files — clean 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1 --- _Generated by [Claude Code](https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
|
|
Summary
Remove stale execution progress widgets. Preserve other workflows' widgets. Prompt-height collapse remains unresolved.
Full context for agent readers
This began as reproduction-only coverage, but now includes production cleanup in
executionStore: completion, interruption and error remove the progress widget from the viewed workflow before queued-job state is deleted. Review found and repaired a cross-workflow bug: identical node IDs in another tab must not be cleaned up. Cleanup also uses the existing subgraph-aware execution-ID mapping.This is a partial fix for the Flux prompt incident and its reproduction task, not closure of either. The prompt stays registered and retains its typed text through two generations, but remains vertically collapsed. The height assertion stays expected-failing. A separate conflict-free replicated data type (CRDT) reconciliation test retains the known stale-snapshot value-overwrite reproduction; that is not fixed here.
Christian's completion lane takes the broader assignment on merge: repair prompt-height allocation, resolve or rule out the Cloud reconciliation candidate against the original workflow, and verify both 1.54 releases. Program tracking is in
claude-handoff-9on the program board. No clean-backport label until full target-native source, API and fixture qualification.Original context: Christian's Slack request, preserved Claude session.
Test Plan
Glossary: progress widget is the temporary execution-status row; CRDT is the synchronized graph document; an expected failure records an unresolved defect, not a completed fix.