Repository navigation
[backport core/1.54] fix: keep hand-wired autogrow connections on their real slot after an agent slot sync (PM-1449) - #18339
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
… agent slot sync (PM-1449) (#18279) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789985885071859)_ A hand-wired connection into an autogrow port could be serialized against the wrong input after an agent slot sync. `updateNodeSlots` replaced the store's slot arrays even though the live `LGraphNode` retained the original arrays, leaving serialization and the canvas with different slot layouts. - Preserve the registered input and output arrays and patch matching slot objects in place. - Match duplicate names occurrence by occurrence. Insert incoming-only slots before the next matching live slot while retaining existing-only slots and their order. - Treat `NodeInputSlot` and `NodeOutputSlot` connectivity as link-store-owned explicitly, without probing prototypes or reading deprecated `link`/`links` accessors. - Reduce CRDT slot records to supported serialized fields before they reach live slot objects. - Cover the PM-1449 serialization path, middle insertion, duplicate input/output names, external runtime fields, live output identity/reactivity, partial snapshots, and self-aliased live slots. The `updateNodeSlots` signature is unchanged. `LGraphNode` binds its slot arrays to the registered `NodeState` when it is constructed. Reassigning `state.inputs` or `state.outputs` later detached the store from the live node. Subsequent local autogrow and connection changes updated the canvas array, while `LGraph.serialize()` read the stale store array and associated positional topology with the wrong slot. The fix keeps the shared arrays stable. Existing slot objects also remain stable so Vue dependents continue to invalidate through the reactive object. Connectivity remains authoritative in `linkStore` for live slot classes and in the descriptor for plain store records. - #18021 addresses the same array-detachment root cause for queued execution. - #18101 covers a separate dynamic-widget slot-offset issue. - #18275 changes agent input reconciliation and may overlap when either PR rebases onto the other. - `pnpm vitest run src/stores/nodeDataStore.test.ts` — 29 passed. - `pnpm vitest run src/workbench/extensions/agent/crdt/graphMutations.test.ts` — 50 passed, 1 expected failure. - `pnpm vitest run src/workbench/extensions/agent src/stores/nodeDataStore.test.ts src/core/graph/widgets/dynamicWidgets.test.ts` — 123 files, 1,919 passed, 7 expected failures. - `pnpm typecheck` — passed. - Scoped ESLint, type-aware oxlint, and oxfmt checks — passed. - Commit hook checks and pre-push `knip --cache` — passed. Fixes PM-1449 (child of PM-1442). --------- Co-authored-by: Amp <amp@ampcode.com>
440b5b0 to
521ecfe
Compare
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1932 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-22T03:35:31.132Z",
"gitSha": "a0faa200ecc50c757c0db847bd6489b957b4a6f7",
"branch": "backport-18279-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2066.654000000028,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.641,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.9079999999999,
"heapDeltaBytes": -11075096,
"heapUsedBytes": 58617968,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 17.070999999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2011.1950000000434,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.874999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.372,
"heapDeltaBytes": 524324,
"heapUsedBytes": 65003440,
"domNodes": 12,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8.452000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1789.2719999999827,
"styleRecalcs": 75,
"styleRecalcDurationMs": 29.717999999999993,
"layouts": 14,
"layoutDurationMs": 4.022,
"taskDurationMs": 809.81,
"heapDeltaBytes": -5032332,
"heapUsedBytes": 65659648,
"domNodes": -279,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 129.595,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1724.183000000039,
"styleRecalcs": 73,
"styleRecalcDurationMs": 24.312,
"layouts": 14,
"layoutDurationMs": 3.867,
"taskDurationMs": 738.452,
"heapDeltaBytes": 12914040,
"heapUsedBytes": 82676984,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 123.904,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1658.6209999999255,
"styleRecalcs": 29,
"styleRecalcDurationMs": 13.989999999999998,
"layouts": 6,
"layoutDurationMs": 1.094,
"taskDurationMs": 331.188,
"heapDeltaBytes": 4353016,
"heapUsedBytes": 75466460,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.633,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.5609999999378,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.685,
"layouts": 6,
"layoutDurationMs": 1.335,
"taskDurationMs": 393.09399999999994,
"heapDeltaBytes": 4251528,
"heapUsedBytes": 74240856,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 16.641999999999996,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 679.1390000000206,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.828999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.719,
"heapDeltaBytes": -8218496,
"heapUsedBytes": 62686684,
"domNodes": 14,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 145.459,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 571.2140000000545,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.859,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.17999999999995,
"heapDeltaBytes": 17511576,
"heapUsedBytes": 88095552,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 134.16500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2037.3460000000136,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 658.858,
"heapDeltaBytes": -15607812,
"heapUsedBytes": 86915088,
"domNodes": -263,
"jsHeapTotalBytes": -331776,
"scriptDurationMs": 34.653000000000006,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2041.1220000000867,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.195,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.7789999999999,
"heapDeltaBytes": 9380484,
"heapUsedBytes": 85419992,
"domNodes": -271,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 32.726000000000006,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2499.30999999998,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.367000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1580.025,
"heapDeltaBytes": 6912488,
"heapUsedBytes": 84254456,
"domNodes": -280,
"jsHeapTotalBytes": 118784,
"scriptDurationMs": 723.985,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2174.126000000001,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.964,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1400.2559999999999,
"heapDeltaBytes": -9322584,
"heapUsedBytes": 67410556,
"domNodes": -277,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 653.1450000000001,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3266.019999999969,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.787999999999998,
"layouts": 60,
"layoutDurationMs": 12.857,
"taskDurationMs": 1556.895,
"heapDeltaBytes": 11761576,
"heapUsedBytes": 80159260,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 674.947,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3502.153000000021,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.656999999999998,
"layouts": 60,
"layoutDurationMs": 12.235,
"taskDurationMs": 1592.93,
"heapDeltaBytes": -1638508,
"heapUsedBytes": 77663612,
"domNodes": -278,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 713.847,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2800.6209999999783,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.062000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1825.0509999999997,
"heapDeltaBytes": -7023280,
"heapUsedBytes": 72594800,
"domNodes": -248,
"jsHeapTotalBytes": -368640,
"scriptDurationMs": 848.396,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2606.7580000000135,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.513,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1689.0489999999998,
"heapDeltaBytes": 791076,
"heapUsedBytes": 80787184,
"domNodes": -250,
"jsHeapTotalBytes": -212992,
"scriptDurationMs": 824.519,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2022.0809999999574,
"styleRecalcs": 5,
"styleRecalcDurationMs": 6.408,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 582.61,
"heapDeltaBytes": 21857716,
"heapUsedBytes": 87696828,
"domNodes": -271,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.423000000000005,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2024.279999999976,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.415000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.3939999999999,
"heapDeltaBytes": 5510336,
"heapUsedBytes": 82797268,
"domNodes": -276,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 30.229,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 525.5319999999983,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.76,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 345.81700000000006,
"heapDeltaBytes": 14743056,
"heapUsedBytes": 87860060,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 115.561,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 690.3630000000476,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.514999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.74399999999997,
"heapDeltaBytes": 13888248,
"heapUsedBytes": 86267384,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 152.402,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2004.7710000000052,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.7059999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.2090000000001,
"heapDeltaBytes": -960916,
"heapUsedBytes": 72159464,
"domNodes": -293,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 11.413,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1990.6330000000025,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.5040000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.962,
"heapDeltaBytes": -8822736,
"heapUsedBytes": 63273412,
"domNodes": -294,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.205999999999998,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1746.5629999999805,
"styleRecalcs": 77,
"styleRecalcDurationMs": 24.861,
"layouts": 18,
"layoutDurationMs": 4.585000000000001,
"taskDurationMs": 752.9599999999999,
"heapDeltaBytes": -8513908,
"heapUsedBytes": 63245968,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 97.524,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1721.341999999936,
"styleRecalcs": 77,
"styleRecalcDurationMs": 24.980000000000004,
"layouts": 18,
"layoutDurationMs": 4.4079999999999995,
"taskDurationMs": 732.34,
"heapDeltaBytes": -10069276,
"heapUsedBytes": 61056564,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 94.866,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1234.410999999909,
"styleRecalcs": 20,
"styleRecalcDurationMs": 25.856000000000005,
"layouts": 16,
"layoutDurationMs": 11.419000000000002,
"taskDurationMs": 830.9050000000002,
"heapDeltaBytes": 22705880,
"heapUsedBytes": 95025504,
"domNodes": 13751,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 28.148,
"eventListeners": 2385,
"totalBlockingTimeMs": 85,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8626.864999999952,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.38999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5035.279,
"heapDeltaBytes": 2520284,
"heapUsedBytes": 78423560,
"domNodes": -243,
"jsHeapTotalBytes": 1429504,
"scriptDurationMs": 2227.9460000000004,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8353.84499999998,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.718,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4800.251,
"heapDeltaBytes": -20895368,
"heapUsedBytes": 81084152,
"domNodes": -263,
"jsHeapTotalBytes": -368640,
"scriptDurationMs": 2125.3080000000004,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15719.275000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15348.550000000001,
"heapDeltaBytes": -46718868,
"heapUsedBytes": 165928948,
"domNodes": -8068,
"jsHeapTotalBytes": -9965568,
"scriptDurationMs": 255.80999999999997,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 15183.70500000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14799.659,
"heapDeltaBytes": -54942940,
"heapUsedBytes": 169163300,
"domNodes": -8068,
"jsHeapTotalBytes": -10166272,
"scriptDurationMs": 237.48400000000004,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 17839.859000000048,
"styleRecalcs": 125,
"styleRecalcDurationMs": 16.945000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17625.394,
"heapDeltaBytes": -11968152,
"heapUsedBytes": 192285600,
"domNodes": -8068,
"jsHeapTotalBytes": -11325440,
"scriptDurationMs": 762.1510000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 20,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 17606.829999999944,
"styleRecalcs": 130,
"styleRecalcDurationMs": 16.274999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17346.102000000003,
"heapDeltaBytes": -38105060,
"heapUsedBytes": 192072212,
"domNodes": -8068,
"jsHeapTotalBytes": -12124160,
"scriptDurationMs": 752.826,
"eventListeners": -14931,
"totalBlockingTimeMs": 5,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5528.646000000094,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.42500000000003,
"layouts": 20,
"layoutDurationMs": 22.173,
"taskDurationMs": 5501.294000000001,
"heapDeltaBytes": -70666316,
"heapUsedBytes": 164920976,
"domNodes": -8068,
"jsHeapTotalBytes": 9760768,
"scriptDurationMs": 101.27399999999999,
"eventListeners": -14929,
"totalBlockingTimeMs": 225,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5574.116000000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.23399999999998,
"layouts": 20,
"layoutDurationMs": 22.38699999999999,
"taskDurationMs": 5499.315,
"heapDeltaBytes": -54335328,
"heapUsedBytes": 177281540,
"domNodes": -8068,
"jsHeapTotalBytes": 12075008,
"scriptDurationMs": 119.83399999999999,
"eventListeners": -14929,
"totalBlockingTimeMs": 367,
"frameDurationMs": 17.773333333333298,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7473.510000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7310.048999999999,
"heapDeltaBytes": 6435816,
"heapUsedBytes": 191924900,
"domNodes": 0,
"jsHeapTotalBytes": -10485760,
"scriptDurationMs": 119.03999999999998,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7374.510999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7271.783999999999,
"heapDeltaBytes": -11654572,
"heapUsedBytes": 163108120,
"domNodes": 0,
"jsHeapTotalBytes": -18087936,
"scriptDurationMs": 144.18100000000007,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 76.65700000006836,
"styleRecalcs": 7,
"styleRecalcDurationMs": 9.993,
"layouts": 2,
"layoutDurationMs": 0.526,
"taskDurationMs": 57.865000000000016,
"heapDeltaBytes": 3098236,
"heapUsedBytes": 71843636,
"domNodes": 107,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.263999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 443.5869999999795,
"styleRecalcs": 14,
"styleRecalcDurationMs": 17.212,
"layouts": 4,
"layoutDurationMs": 1.6150000000000002,
"taskDurationMs": 89.12500000000001,
"heapDeltaBytes": 4744288,
"heapUsedBytes": 73552976,
"domNodes": 119,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.524000000000001,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.54 #18339 +/- ##
=============================================
- Coverage 83.54% 83.54% -0.01%
=============================================
Files 2094 2094
Lines 123479 123550 +71
Branches 31432 33303 +1871
=============================================
+ Hits 103165 103221 +56
- Misses 20135 20150 +15
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Requested by Christian Byrne · Slack thread
Summary
Backport of #18279 to
core/1.54. The automated backport failed with a merge conflict, so this is a manual cherry-pick of merge commit566c343fb95e77ee04c4dc3aa02ea40bcb416e66.A hand-wired connection into an autogrow port could be serialized against the wrong input after an agent slot sync.
updateNodeSlotsreplaced the store's slot arrays even though the liveLGraphNoderetained the original arrays, leaving serialization and the canvas with different slot layouts. The fix preserves the registered input/output arrays and patches matching slot objects in place instead of reassigning them.Conflict resolution
Conflicts were in
src/stores/nodeDataStore.tsandsrc/stores/nodeDataStore.test.ts:nodeDataStore.ts:updateNodeSlotsconflicted becausecore/1.54's current version does a plain array reassignment (state.inputs = slots.inputs), while fix: keep hand-wired autogrow connections on their real slot after an agent slot sync (PM-1449) #18279 replaces that with the occurrence-awaremergeSlotsByNamein-place patch, which is the entire point of this fix. Took the incoming (PR) side;mergeSlotsByName/patchInputSlot/patchOutputSlot/copyInputSlot/copyOutputSlotall merged in cleanly elsewhere in the file.nodeDataStore.test.ts: an import conflict (core/1.54already hascreateTestingPinia/setActivePinia/beforeEachfor existing tests; fix: keep hand-wired autogrow connections on their real slot after an agent slot sync (PM-1449) #18279 addedvifor its new tests) was resolved by merging both import sets. A second conflict was a pure addition (keeps live slot edits visible after a remote slot synctest) with nothing on thecore/1.54side to reconcile against, so it was taken as-is.src/workbench/extensions/agent/crdt/graphMutations.tsand its test file auto-merged cleanly with no conflicts.Is this a real conflict or a stacking conflict?
Checked #18337, #18334, and #17872 (the other open PRs against
core/1.54the backport bot flagged as possible stacking candidates): none of them touchsrc/stores/nodeDataStore.tsornodeDataStore.test.ts. This is a real, direct conflict between #18279's rewrite ofupdateNodeSlotsandcore/1.54's pre-existing simpler implementation, not a stacking conflict with any of those three PRs.Verification
pnpm vitest run src/stores/nodeDataStore.test.ts— 31 passed.pnpm vitest run src/workbench/extensions/agent/crdt/graphMutations.test.ts src/core/graph/widgets/dynamicWidgets.test.ts— 71 passed, 1 expected failure (matches the original PR's reported results).pnpm typecheck— passed.eslinton the 4 changed files — passed.nodeDataStore.ts,nodeDataStore.test.ts,graphMutations.ts,graphMutations.test.ts), no stray diffs.🤖 Generated with Claude Code
https://claude.ai/code/session_01PqHg3D8o2RbujF1t4dz4J6
Generated by Claude Code