Repository navigation
[backport core/1.54] Fix duplicate-name stale workflow binding resolution - #18722
Conversation
## Summary Reject stale Agent workflow bindings when the target ID has a duplicated cloud name instead of resolving the unrelated saved tab and graph. ## Changes - **What**: Resolve ID-to-name identity from the full cloud index while retaining the duplicate-filtered name-to-ID inference map. Add fresh-store regressions for both resolver entry points and a browser scenario with duplicate target IDs plus a uniquely named saved `Portrait` tab. - **Dependencies**: None. ## Review Focus The lookup is intentionally asymmetric: duplicated names remain unsafe for name-to-ID inference, while an exact target ID can still retrieve its indexed name for stale-binding rejection. This is separate from the refresh-cache work in #17509 and does not modify that branch. Focused Vitest is red on `origin/main` (both entry points select `Portrait`) and green here (14/14). ESLint, formatting, full `pnpm typecheck`, browser typecheck, and the push-time `knip` gate pass. The new Playwright case is checked in but runtime proof is blocked on this worker: both it and the unchanged `agentWorkflowSelection` smoke case time out before assertions because the Agent entry button is absent on the local current-main surface. No live model call was made. ## Screenshots (if applicable) The browser run produced traces/video for the pre-assertion harness blocker; no passing screenshot is claimed.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
🎭 Playwright: ✅ 1954 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-24T19:17:50.636Z",
"gitSha": "c6bb8f12d24ffd2a8c50b23b04466cd7a307ac1a",
"branch": "backport-18155-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2072.2729999999956,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.5470000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 544.3530000000001,
"heapDeltaBytes": -521484,
"heapUsedBytes": 69787760,
"domNodes": -281,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 8.183,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2047.3329999999805,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.700999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.71099999999996,
"heapDeltaBytes": -9108524,
"heapUsedBytes": 61102588,
"domNodes": -279,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 8.227000000000002,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1796.8820000000392,
"styleRecalcs": 73,
"styleRecalcDurationMs": 25.82,
"layouts": 14,
"layoutDurationMs": 3.901,
"taskDurationMs": 843.091,
"heapDeltaBytes": -7441940,
"heapUsedBytes": 62626700,
"domNodes": -281,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 156.895,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1812.8589999999463,
"styleRecalcs": 72,
"styleRecalcDurationMs": 25.876000000000005,
"layouts": 14,
"layoutDurationMs": 4.205,
"taskDurationMs": 850.303,
"heapDeltaBytes": -8420136,
"heapUsedBytes": 61035560,
"domNodes": -281,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 155.114,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.6169999999806,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.091000000000001,
"layouts": 6,
"layoutDurationMs": 1.164,
"taskDurationMs": 347.37000000000006,
"heapDeltaBytes": 4630692,
"heapUsedBytes": 75755836,
"domNodes": 74,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.434000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1712.2359999999617,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.763,
"layouts": 6,
"layoutDurationMs": 0.905,
"taskDurationMs": 350.981,
"heapDeltaBytes": 4591364,
"heapUsedBytes": 75550832,
"domNodes": 74,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.273000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 758.5169999999835,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.541000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.713,
"heapDeltaBytes": 18679020,
"heapUsedBytes": 82732464,
"domNodes": 14,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 175.44299999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 633.9009999999803,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.359,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.67500000000007,
"heapDeltaBytes": -7868512,
"heapUsedBytes": 63016748,
"domNodes": 22,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 160.56,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2018.4229999999843,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.406000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 558.523,
"heapDeltaBytes": 10923328,
"heapUsedBytes": 87132364,
"domNodes": -273,
"jsHeapTotalBytes": -2461696,
"scriptDurationMs": 30.268000000000004,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2005.4280000000517,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.6150000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.143,
"heapDeltaBytes": 22181632,
"heapUsedBytes": 87974788,
"domNodes": -272,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.480999999999995,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2239.215999999999,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.805000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1631.5819999999999,
"heapDeltaBytes": 2833916,
"heapUsedBytes": 80174720,
"domNodes": -252,
"jsHeapTotalBytes": 1171456,
"scriptDurationMs": 846.733,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2254.4639999999845,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.638,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1642.3990000000001,
"heapDeltaBytes": 2982108,
"heapUsedBytes": 80233640,
"domNodes": -281,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 804.61,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3533.695000000023,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.401,
"layouts": 60,
"layoutDurationMs": 11.543999999999999,
"taskDurationMs": 1700.53,
"heapDeltaBytes": 9772392,
"heapUsedBytes": 76917504,
"domNodes": -280,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 789.809,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3554.738000000043,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.115,
"layouts": 60,
"layoutDurationMs": 11.443999999999999,
"taskDurationMs": 1667.455,
"heapDeltaBytes": 10203044,
"heapUsedBytes": 76925188,
"domNodes": -279,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 777.9469999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3014.1980000000217,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.568000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1845.689,
"heapDeltaBytes": 18262920,
"heapUsedBytes": 86301948,
"domNodes": 0,
"jsHeapTotalBytes": 2252800,
"scriptDurationMs": 924.948,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3121.5929999999616,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.697000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1974.5199999999998,
"heapDeltaBytes": 4423140,
"heapUsedBytes": 85005044,
"domNodes": -285,
"jsHeapTotalBytes": 315392,
"scriptDurationMs": 999.74,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2055.8619999999905,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.7570000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 605.609,
"heapDeltaBytes": 5782120,
"heapUsedBytes": 83232668,
"domNodes": -279,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 31.199000000000005,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2028.630000000021,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.045,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.853,
"heapDeltaBytes": 10012936,
"heapUsedBytes": 88179232,
"domNodes": -268,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 31.264,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 605.4629999999861,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.523,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.58399999999995,
"heapDeltaBytes": 13896420,
"heapUsedBytes": 86414352,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 142.91899999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 585.8060000000478,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.709,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.40500000000003,
"heapDeltaBytes": 14650896,
"heapUsedBytes": 88047372,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 137.739,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2020.40599999998,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.731000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.98600000000005,
"heapDeltaBytes": 6758956,
"heapUsedBytes": 79044832,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.601,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 1990.3869999999984,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.174999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 421.89799999999997,
"heapDeltaBytes": 689536,
"heapUsedBytes": 66213496,
"domNodes": 18,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 7.227000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1771.7369999999732,
"styleRecalcs": 79,
"styleRecalcDurationMs": 28.98,
"layouts": 18,
"layoutDurationMs": 4.196,
"taskDurationMs": 815.978,
"heapDeltaBytes": -5883652,
"heapUsedBytes": 67351492,
"domNodes": -294,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 106.129,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1741.8499999999995,
"styleRecalcs": 77,
"styleRecalcDurationMs": 25.49,
"layouts": 18,
"layoutDurationMs": 4.797,
"taskDurationMs": 809.441,
"heapDeltaBytes": -4696624,
"heapUsedBytes": 67943380,
"domNodes": -298,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 109.94699999999999,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.2659999999642,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.878000000000004,
"layouts": 14,
"layoutDurationMs": 15.440999999999997,
"taskDurationMs": 928.4920000000001,
"heapDeltaBytes": 20127348,
"heapUsedBytes": 104495916,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 29.967000000000002,
"eventListeners": 2385,
"totalBlockingTimeMs": 147,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8421.228999999983,
"styleRecalcs": 249,
"styleRecalcDurationMs": 34.581,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5721.231,
"heapDeltaBytes": -8099320,
"heapUsedBytes": 68219428,
"domNodes": -281,
"jsHeapTotalBytes": 1208320,
"scriptDurationMs": 2689.658,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8430.377000000022,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.384,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5794.075000000001,
"heapDeltaBytes": 9515712,
"heapUsedBytes": 85035880,
"domNodes": -245,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 2735.3360000000002,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16714.563999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16254.939,
"heapDeltaBytes": -45288972,
"heapUsedBytes": 177437788,
"domNodes": -8068,
"jsHeapTotalBytes": -22622208,
"scriptDurationMs": 297.822,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16725.299000000065,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16133.811999999998,
"heapDeltaBytes": -41355172,
"heapUsedBytes": 176779248,
"domNodes": -8068,
"jsHeapTotalBytes": -10760192,
"scriptDurationMs": 298.599,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20436.976000000017,
"styleRecalcs": 172,
"styleRecalcDurationMs": 16.405,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20043.382999999998,
"heapDeltaBytes": -61737336,
"heapUsedBytes": 169022752,
"domNodes": -8068,
"jsHeapTotalBytes": -19312640,
"scriptDurationMs": 892.306,
"eventListeners": -14929,
"totalBlockingTimeMs": 128,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20441.833999999973,
"styleRecalcs": 169,
"styleRecalcDurationMs": 16.768000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20104.004,
"heapDeltaBytes": -38857532,
"heapUsedBytes": 179076200,
"domNodes": -8068,
"jsHeapTotalBytes": -11825152,
"scriptDurationMs": 917.7330000000001,
"eventListeners": -14927,
"totalBlockingTimeMs": 87,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6065.45299999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.79799999999997,
"layouts": 20,
"layoutDurationMs": 21.62300000000002,
"taskDurationMs": 5973.4,
"heapDeltaBytes": -56362544,
"heapUsedBytes": 176223904,
"domNodes": -8068,
"jsHeapTotalBytes": 3756032,
"scriptDurationMs": 111.32200000000002,
"eventListeners": -14929,
"totalBlockingTimeMs": 359,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6129.071999999951,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.839,
"layouts": 20,
"layoutDurationMs": 21.684999999999995,
"taskDurationMs": 6019.827000000001,
"heapDeltaBytes": -55507892,
"heapUsedBytes": 183973424,
"domNodes": -8068,
"jsHeapTotalBytes": 12644352,
"scriptDurationMs": 105.667,
"eventListeners": -14929,
"totalBlockingTimeMs": 401,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8444.127999999979,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8212.152,
"heapDeltaBytes": 14685956,
"heapUsedBytes": 179687896,
"domNodes": 0,
"jsHeapTotalBytes": -20185088,
"scriptDurationMs": 126.71,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8829.566999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8495.529,
"heapDeltaBytes": 20836092,
"heapUsedBytes": 179668648,
"domNodes": 0,
"jsHeapTotalBytes": -7340032,
"scriptDurationMs": 143.84900000000002,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 110.99400000000514,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.027000000000001,
"layouts": 2,
"layoutDurationMs": 1.34,
"taskDurationMs": 74.068,
"heapDeltaBytes": 3067896,
"heapUsedBytes": 71207188,
"domNodes": 129,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.308000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 106.49999999998272,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.676999999999996,
"layouts": 2,
"layoutDurationMs": 1.193,
"taskDurationMs": 74.185,
"heapDeltaBytes": 2968496,
"heapUsedBytes": 72194864,
"domNodes": 127,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.113000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 1 Pipeline job failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 6a57004 | Docs | View more details | Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #18722 +/- ##
============================================
Coverage 83.76% 83.76%
============================================
Files 2103 2103
Lines 124649 124647 -2
Branches 31559 33421 +1862
============================================
+ Hits 104412 104413 +1
+ Misses 20058 20055 -3
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…e node/title/widget state (#18075) Manual backport of #18075 to core/1.54. Automated backport failed: #18075 (comment) Cherry-picked from 96821ac. Dependency check: the bot flagged a possible stacking conflict with #18727, #18722, #18683, #17872 (all still open against core/1.54). None of those touch graphMutations.ts, graphMutations.test.ts or agentConversationFixture.ts, so they are not the cause. The real causes: - graphMutations.ts: core/1.54 predates #18191 ("keep the ghost placement flag out of the document"), which hoisted node flags into a local `flags` variable (`cloneNodeFlags`) reused by `lastSerialization`. #18191 has no needs-backport label and was never backported here. Resolved by keeping core/1.54's existing flags handling (`cloneRecord(payload.flags)` / `structuredClone(payload)`) and porting only #18075's actual change: `resolveNodeTitle` plus the new `titleReconcileBaseline` field. - graphMutations.test.ts: pure insertion, no real conflict — accepted the new test cases as-is. - browser_tests/fixtures/agentConversationFixture.ts and the new browser_tests/tests/agent/agentCrdtReconcileOverwrite.spec.ts: this fixture (and the wider main-only agent Playwright test scaffolding it depends on, e.g. agentTabSwitchCatchUp.spec.ts) does not exist on core/1.54 at all — introduced by main-only work, not by any of the PRs above. Dropped from this backport along with the Topbar.ts#openBlankTabAndReturn() helper added only for that spec, so the branch keeps compiling. The runtime fix ships with its Vitest regression coverage (graphMutations.test.ts, agentNodeMaterializer.test.ts); the e2e visual-proof spec is left for a follow-up once the agent Playwright fixture infrastructure itself is backported. Validation on this branch: - pnpm exec vitest run src/workbench/extensions/agent - pnpm exec eslint / pnpm exec oxfmt --check on touched files - pnpm typecheck
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed under the 1.54 backport grant (core/1.54 + cloud/1.54, standing). COMMENT rather than APPROVE: I authored the source commit, so an approval record here would be self-approval in substance. The grant permits the merge without one.
Cherry-pick fidelity. Content-identical to the merged source e5a6ab01b7b146e517c42e05ea4cee8b79ff1df7 (#18155) — diffed the added/removed lines of this PR against the source commit, zero divergence. Source stat 261 insertions(+), 5 deletions(-) across 3 files matches this PR exactly.
The fix is at the cause, not the symptom. cloudIdsByName is deliberately ambiguity-free — it only keeps names appearing exactly once. indexedNameFor was reverse-scanning that map by id, so a workflow whose name is duplicated is absent from it, returned undefined, and bindingIsStale short-circuited to false at the indexedName === undefined guard. A stale binding was therefore never detected precisely in the duplicate-name case it needed to be. Reading cloudIndex (which retains duplicates) fixes the lookup at its source.
The bindingIsStale line-110 change from cloudIdsByName.get to cloudIndex.find widens what counts as stale, and that widening is safe: control only reaches it when indexedName !== boundName, so workflowId is not among the workflows named boundName, and any id found there is necessarily !== workflowId. find-picks-first among duplicates cannot change the boolean.
Regression coverage verified red-on-parent. Reverting only useAgentWorkflowResolver.ts to its pre-fix content and keeping the new tests: 4 failed / 12 passed. With the fix: 16/16 green. The failing case is the intended one — rejects a stale storedWorkflowFor binding when the bound name is duplicated in the cloud index. Plus a 217-line black-box browser spec (agentDuplicateWorkflowNameBinding.spec.ts), so this is harness-covered, not unit-only.
Checks at this exact head. test, storybook-build, validate-licenses, validate-fonts, scan, playwright-video-new-tests all green. The three pr-risk entries are cancelled, not failed — gh pr checks renders both as "fail". No human objections, no review comments outstanding.
Merging under the grant.
…e node/title/widget state (#18075) (#18758) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-org.slack.com/archives/C0BGH348Z0C/p1789514768597649)_ Manual backport of #18075 to `core/1.54`. The automated backport failed with merge conflicts: #18075 (comment) Cherry-picked from `96821ace03bc81d7a29965751a401fcf1818cae3` (`git cherry-pick -x -m 1`). ## Dependency check The bot flagged a possible stacking conflict with #18727, #18722, #18683, #17872 (all still open against `core/1.54`). None of them touch `graphMutations.ts`, `graphMutations.test.ts`, or `agentConversationFixture.ts` — they are not the cause of this conflict. The real causes: - **`graphMutations.ts`** — `core/1.54` predates #18191 ("keep the ghost placement flag out of the document"), which hoisted node flags into a local `flags` variable (`cloneNodeFlags`) that `lastSerialization` also started reusing. #18191 is merged to `main` but carries no `needs-backport` label and was never backported to `core/1.54`. Resolved by keeping `core/1.54`'s existing flags handling (`flags: cloneRecord(payload.flags)` / `lastSerialization: structuredClone(payload)`) and porting only #18075's actual change: `resolveNodeTitle(payload, incumbent)` for the title, plus the new `titleReconcileBaseline` field feeding it. - **`graphMutations.test.ts`** — pure insertion (no code on the `HEAD` side of the conflict), accepted the new test cases as-is. - **`browser_tests/fixtures/agentConversationFixture.ts`** and the new **`browser_tests/tests/agent/agentCrdtReconcileOverwrite.spec.ts`** — this Playwright fixture (and the wider main-only agent-test scaffolding it depends on, e.g. `agentTabSwitchCatchUp.spec.ts`) does not exist on `core/1.54` at all; it isn't introduced by any of the PRs above. Dropped from this backport, along with the `Topbar.ts#openBlankTabAndReturn()` helper added only for that spec, so the branch keeps compiling. The runtime fix ships with its Vitest regression coverage (`graphMutations.test.ts`, `agentNodeMaterializer.test.ts`); the e2e visual-proof spec is left for a follow-up once the agent Playwright fixture infrastructure itself is backported. ## Validation - `pnpm exec vitest run src/workbench/extensions/agent` — 1 pre-existing, unrelated failure in `AgentPanelRoot.test.ts` (confirmed present on `core/1.54` before this backport, untouched by this diff); everything else passes, including the 2 intentional `it.fails` cases this PR introduces. - `pnpm exec eslint` / `pnpm exec oxfmt --check` clean on all touched files. - `pnpm typecheck` clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01L4WMaCPdk7KSva7vwKfz19 --- _Generated by [Claude Code](https://claude.ai/code/session_01L4WMaCPdk7KSva7vwKfz19)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
…ui/types (#18823) ## Summary The #18722 backport carrier (`68fc0f639e`) landed `browser_tests/tests/agent/agentDuplicateWorkflowNameBinding.spec.ts` without `src/platform/remote/comfyui/types.ts`. That module exists on `main` (added in #17789) but not on `core/1.54`, so every PR against `core/1.54` since has failed the required `lint-and-format` check identically: ``` browser_tests/tests/agent/agentDuplicateWorkflowNameBinding.spec.ts(10,39): error TS2307: Cannot find module '@/platform/remote/comfyui/types' ``` (`typecheck-aux` TS2307 + `repo-checks` knip unresolved import → `lint-and-format` gate red.) This backports **only the `UserDataFullInfo` type the spec imports**. The rest of `main`'s module has no consumer on this branch and would fail knip's unused-export check. `cloud/1.54` does **not** need this fix: its copy of the spec was adapted during cherry-pick to import `UserDataFullInfo` from `@/schemas/apiSchema`, which still exists there; `typecheck:browser` and `knip` are clean on `cloud/1.54` as-is, and adding this file there fails knip (unused file). ## Verification - Red on parent: `pnpm typecheck:browser` on `core/1.54` fails with the TS2307 above; green with this commit. - `pnpm typecheck`, `pnpm typecheck:browser`, `pnpm knip:no-cache`, eslint + oxfmt on the new file: all clean locally. Unblocks #18810 and #18811 (P0 backport carriers). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
… or node reference (#18693) (#18835) Backport of #18693 (`facbca7658dd361ff5f5edaf5ff5404d582e0a64`, merged to `main` 2026-09-25T07:11Z) to `cloud/1.54`. ## Why this branch #18693 fixes the agent editing a different workflow than the one the user is looking at — writes land on a document nobody is watching. Production (`cloud.comfy.org`) serves `cloud/1.54` by pinned SHA, so the fix on `main` alone reaches no user. This is the P0 carrier for the branch production is pinned from. ## Cherry-pick adaptations (context only, no behavior change) `cloud/1.54` lacks several main-only commits that #18693's diff sits next to (agent telemetry instrumentation #18665/#18503, workspace-scoped persistence #17765, `retainStagedNode` staging, the `Topbar` browser-test helper). The conflicts were all context drift from those; the fix's own logic is unchanged: - `useCanvasSelection.ts`: took #18693's `onNodesAdded` option + `stageUserSelection()`; did NOT pull in main's unrelated `retainStagedNode`/`retainOffSelectionNodes`; the one call site uses this branch's `[...nodes]` instead of main's `projectedNodes`. - `useAgentWorkflowSelection.ts`: kept this branch's 2-arg `commitWorkflowTarget` — the `source`/`previousWorkflowId` params exist on main only for bind telemetry (`onTargetBound`), which is absent here. #18693's `onVisibleWorkflowChanged` and its wiring are byte-identical to source. - `useAgentSession.ts`: #18693's hoisted `stored`/`workflow.initialize` startup logic taken verbatim; storage key adapted to this branch's `THREAD_STORAGE_KEY` (main uses workspace-scoped `threadStorageKey` from #17765). - `AgentPanelRoot.vue`: `start()` moved after the new active-workflow watcher per source; `onNewChat` follow/retain logic taken verbatim minus the telemetry `source` arg (main-only); did not pull in main's approval-telemetry functions. - `AgentPanelRoot.test.ts`: new behavior tests taken from source; three main-only test helpers mapped to this branch's existing idioms (`useWorkflowService()` → the file's `workflowService` mock, `StorageKeys.agentThread('personal')` → `'Comfy.Agent.ThreadId'`, `syncFakeSelection()` → `canvasStore.updateSelectedItems()`). - `agentWorkflowSelection.spec.ts`: kept this branch's tab locator (no `Topbar` helper here); took #18693's assertion changes. - `docs/adr/README.md`: kept this branch's index table, inserted the AGENT-TARGET-0037 row. ## Local gates on this head (per the #18722 lesson: markers prove lines arrived, not their dependencies) - `pnpm typecheck` ✅ - `pnpm typecheck:browser` ✅ - `pnpm knip:no-cache` ✅ - `pnpm vitest run` on the five touched suites: 316/316 ✅ ## Red on parent With production files reverted to the parent (`7b4d950b52`) and the new tests kept, `AgentPanelRoot.test.ts -t 'follows the visible workflow'` fails (target does not follow the visible tab); green with the fix. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com>
…assets flag, retire Comfy.Assets.UseAssetAPI (#18727) Manual backport of #17117 to `core/1.54`. The automated backport failed with merge conflicts (#17117 (comment)). Cherry-picked from dffad2d (`git cherry-pick -x`). ## Why #17117 retires the hidden `Comfy.Assets.UseAssetAPI` setting and the `Comfy.ToggleAssetAPI` command. The model library, sidebar tab and model store follow `useFeatureFlags().flags.assetsEnabled` (cloud, or the server advertises the `assets` feature). `Comfy.BrowseModelAssets` opens the browser through `openModelLibraryBrowser()`, and the widget asset-picker gate is renamed to `shouldUseWidgetAssetPicker` / `isWidgetAssetPickerEnabled` and fixed to `isCloud`. Without it, a stale persisted setting can still route the model library to `/api/assets` on a backend that doesn't serve it. ## Dependency check The bot flagged a possible stacking conflict with #18722, #18683, #18334 and #17872. None of the four touch any file changed by #17117, so they aren't the cause. The conflicts are real and come from main-only test refactors that aren't on `core/1.54`: the `vi.mock(import(...))` migrations (#17173, #17175, #17176, #17178, #17179) and the global-Pinia test migrations (#17231, #17234, #17235, #17236, #17237, #17270), plus #16891. All production code, locale, script and e2e changes applied cleanly. ## Conflict resolution All 7 conflicts were in unit tests. Each one keeps `core/1.54`'s mocking style (hoisted `vi.mock` stores, no global Pinia) and ports only the setting-to-flag change: - `src/components/sidebar/tabs/ModelLibrarySidebarTab.test.ts`: kept the target's store/download/setting mocks. Dropped the `Comfy.Assets.UseAssetAPI` branch and added a `useFeatureFlags` mock (`featureFlagState.assetsEnabled`) in its place. - `src/composables/useCoreCommands.test.ts`: kept the target's mocks and `createMockSettingStore`. Added the `useFeatureFlags` mock. The `BrowseModelAssets` tests toggle `assetsEnabled` instead of the setting. - `src/platform/assets/services/assetService.test.ts`: kept the target's imports and mocks. Took the rename to `shouldUseWidgetAssetPicker` and removed the setting-store mock. - `src/platform/assets/utils/assetPreviewUtil.test.ts`: kept the target's `vi.mock` style. Added the `useFeatureFlags` mock and removed the `isAssetAPIEnabled` / `getServerFeature` mocks. - `src/renderer/extensions/vueNodes/widgets/composables/useComboWidget.test.ts`: kept the target's two remote-combo tests, which are absent on main. Took the renamed test and the `shouldUseWidgetAssetPicker` mock. - `src/stores/modelStore.test.ts`: kept the target's `mockDistribution` mock. Took #17117's `remoteConfig` holder mock and reactive `serverFeatures` state, so the store's flag watcher fires and state doesn't leak between tests. - `src/stores/workspace/sidebarTabStore.test.ts`: kept the target's command/menu/setting store mocks. Added the `useFeatureFlags` and `openModelLibraryBrowser` mocks and dropped the `Comfy.Assets.UseAssetAPI` setting reads. No other changes from main are included. ## Validation - Static check: no remaining `Comfy.Assets.UseAssetAPI`, `isAssetAPIEnabled`, `shouldUseAssetBrowser`, `ToggleAssetAPI` or `usesAssetApi` references in `src`, `browser_tests`, `scripts` or `.github`. - `pnpm install --frozen-lockfile`: ok - `pnpm typecheck`: clean - `eslint`, `oxlint`, `oxfmt --check` on changed files: 0 errors - `vitest run` on the touched tests plus `src/stores`, `src/platform/assets`, `src/components/sidebar` and `src/composables/useFeatureFlags*`: 129 files, 2339 passed - `vitest run` on `scripts/checkAssetsFlagArtifact.test.ts`, `widgetInputs`, `missingModelPipeline`, `src/renderer/extensions/vueNodes/widgets` and `useCoreCommands`: 66 files, 960 passed - `vite build` followed by `EXPECTED_DISTRIBUTION=localhost EXPECTED_FRONTEND_COMMIT=<HEAD> pnpm test:assets-flag-artifact`: pass - Local e2e against a real ComfyUI backend without `--enable-assets` (`/api/features` reports `assets: false`), with a temporary request guard that is not included in this PR: - A walk of the sidebars, model library refresh, asset/model commands, missing-model workflows, upload and run, the assets sidebar, linear mode and vue-node dropdowns: 10/10 passed. This covered a user with a stale persisted `Comfy.Assets.UseAssetAPI=true`. No `/api/assets*` requests were made. - `browser_tests/tests/sidebar/modelLibrary.spec.ts`: 13/13 passed with no `/api/assets*` requests.
…or node reference (#18693) (#18836) Backport of #18693 (`facbca7658dd361ff5f5edaf5ff5404d582e0a64`, merged to `main` 2026-09-25T07:11Z) to `core/1.54`. Companion to the `cloud/1.54` carrier #18835. ## Why #18693 fixes the agent editing a different workflow than the one the user is looking at — writes land on a document nobody is watching. `core/1.54` feeds the `comfyui-frontend-package` PyPI train for Desktop/local. ## Cherry-pick adaptations (context only, no behavior change) Same class of drift as the cloud carrier (see #18835), plus four core-specific ones: - `agentNewChatTargetWorkflow.spec.ts` (modify/delete): this spec does not exist on the `core/1.54` train; per the #18810 precedent it was **not introduced**. - `RunNoticeBanner.vue`: core still has the pre-#18052 palette (`bg-primary-background`, `font-medium`; the core backport of #18052 is still open as #18793). #18693's `context`/`showTarget` logic applied onto core's palette classes verbatim; no styling change smuggled in. - Test `retains an explicitly chosen target across panel reopen and New Chat`: core's variant of this test had drifted from main's, so #18693's rewrite hunk missed it. Applied the source's post-change version by hand (`retains an explicitly chosen target across a plain panel reopen`) — New Chat now resumes following, which is exactly the behavior #18693 ships. - Three new tests assert `selection: { node_ids, workflow_id }` in the send payload; `core/1.54` predates #17327 (selection scoping), so its payload has no nested `workflow_id`. Matchers narrowed to `{ node_ids }` on this branch only; top-level `workflow_id` assertions (the target-binding behavior under test) are untouched. - Did not introduce the two `agentGraphActivityStore` tests riding as pre-image context in one hunk — that store is not on this train. ## Local gates on this head (per the #18722 lesson) - `pnpm typecheck` ✅ - `pnpm typecheck:browser` ✅ - `pnpm knip:no-cache` ✅ - `pnpm vitest run` on the five touched suites: 302/302 ✅ ## Red on parent With production files reverted to the parent (`9439d31a3e`) and the new tests kept, `AgentPanelRoot.test.ts -t 'follows the visible workflow'` fails; green with the fix. Note: `Vercel – billing-web-test` fails branch-wide on every `core/1.54` PR (recorded exception in the program's backport policy, sunset 2026-10-09); it is unrelated to this diff. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com>
Eight backport carriers each dropped their black-box proof spec because the agent conversation-replay harness family was never backported, so most agent CRDT fixes on this line ship with unit coverage only. Christian ruled on 2026-09-26 that 1.54 has another week and the test infra should be carried. Test infrastructure only; no product file is touched. Carried from main, byte-identical except where this branch's surface differs: - browser_tests/fixtures/agentConversationFixture.ts - browser_tests/fixtures/data/agent/agentConversation.ts (+ .test.ts) - browser_tests/fixtures/data/agent/agentConversationExpectations.ts - browser_tests/fixtures/data/agent/agentHumanAddBlueprints.ts - browser_tests/fixtures/data/agentReplayNodeDefs.ts - browser_tests/fixtures/utils/agentReplayNodeContract.ts (+ .test.ts) - browser_tests/tests/agent/agentConversationReplay.spec.ts - browser_tests/tests/agent/agentWidgetTypingReconcile.spec.ts - browser_tests/tests/agent/agentHumanAddTabSwitch.spec.ts Branch adaptations, each with a comment at the site saying why: - agentConversation.ts drops the messageDraft slot of zAgentWsEvent. zAgentMessageDraftEvent arrived with #18551 (streaming reply), which is not on this branch. - agentPanelFixture.ts gains mockWorkflowPersistence and the vueNodes boot option. UserDataFullInfo comes from @/schemas/apiSchema, not main's @/platform/remote/comfyui/types, which does not exist here -- the same adaptation savedWorkflowPersistence.ts already carries. - agentConversationFixture.ts waits on PrimeVue's .p-blockui-mask instead of data-testid="app-loading-overlay", which App.vue does not render here. - agentConversationHostDoc.ts apply() takes RecordedGraphOperation[]. - Topbar gains tabs; selectors gains topbar.workflowTab, whose test id WorkflowTab.vue already renders on this branch. - globals.d.ts gains TabSwitchLens and window.__tabSwitchLens. - Four exports in agentConversation.ts are module-local here; their only consumer on main is scripts/agentConversationAssemble.ts, not backported. The 15 recorded conversation JSON files are already on this branch and byte-identical to main (#18585/#18586), so this is harness code only. Not carried, deliberately: main's agentFollowerHostSocket.ts, whose newer members this harness does not use and which imports @/platform/remote/comfyui/execution/types -- absent here, the same missing module that left core/1.54 red for six hours (#18722); the recording-authoring tools under scripts/ and tools/test-recorder; agentConversationCapabilityMatrix.
Eight backport carriers each dropped their black-box proof spec because the agent conversation-replay harness family was never backported, so most agent CRDT fixes on this line ship with unit coverage only. Christian ruled on 2026-09-26 that 1.54 has another week and the test infra should be carried. Test infrastructure only; no product file is touched. Carried from main, byte-identical except where this branch's surface differs: - browser_tests/fixtures/agentConversationFixture.ts - browser_tests/fixtures/data/agent/agentConversation.ts (+ .test.ts) - browser_tests/fixtures/data/agent/agentConversationExpectations.ts - browser_tests/fixtures/data/agent/agentHumanAddBlueprints.ts - browser_tests/fixtures/data/agentReplayNodeDefs.ts - browser_tests/fixtures/utils/agentReplayNodeContract.ts (+ .test.ts) - browser_tests/tests/agent/agentConversationReplay.spec.ts - browser_tests/tests/agent/agentWidgetTypingReconcile.spec.ts - browser_tests/tests/agent/agentHumanAddTabSwitch.spec.ts Branch adaptations, each with a comment at the site saying why: - agentConversation.ts drops the messageDraft slot of zAgentWsEvent. zAgentMessageDraftEvent arrived with #18551 (streaming reply), which is not on this branch. - agentPanelFixture.ts gains mockWorkflowPersistence and the vueNodes boot option. UserDataFullInfo comes from @/schemas/apiSchema, not main's @/platform/remote/comfyui/types, which does not exist here -- the same adaptation savedWorkflowPersistence.ts already carries. - agentConversationFixture.ts waits on PrimeVue's .p-blockui-mask instead of data-testid="app-loading-overlay", which App.vue does not render here. - agentConversationHostDoc.ts apply() takes RecordedGraphOperation[]. - Topbar gains tabs; selectors gains topbar.workflowTab, whose test id WorkflowTab.vue already renders on this branch. - globals.d.ts gains TabSwitchLens and window.__tabSwitchLens. - Four exports in agentConversation.ts are module-local here; their only consumer on main is scripts/agentConversationAssemble.ts, not backported. The 15 recorded conversation JSON files are already on this branch and byte-identical to main (#18585/#18586), so this is harness code only. Not carried, deliberately: main's agentFollowerHostSocket.ts, whose newer members this harness does not use and which imports @/platform/remote/comfyui/execution/types -- absent here, the same missing module that left core/1.54 red for six hours (#18722); the recording-authoring tools under scripts/ and tools/test-recorder; agentConversationCapabilityMatrix.
…18968) ## Summary Backports the agent conversation-replay test harness to `cloud/1.54` so the release line can replay the 15 recorded agent conversations it already carries. Test infrastructure only — no product file is touched. ## Changes - **What**: the harness family (`agentConversationFixture.ts`, `data/agent/agentConversation.ts`, `agentConversationExpectations.ts`, `agentHumanAddBlueprints.ts`, `data/agentReplayNodeDefs.ts`, `utils/agentReplayNodeContract.ts`), the two harness self-tests, and three black-box specs that consume it. Small additive hunks to `agentPanelFixture.ts`, `agentConversationHostDoc.ts`, `components/Topbar.ts`, `selectors.ts` and `types/globals.d.ts`. - **Dependencies**: none new. The 17 recorded-conversation JSON files landed earlier (#18585/#18586) and are byte-identical to `main`. ### Why Eight carriers each dropped their black-box proof spec one at a time, for the same reason: this harness family (from unbackported #16764 / #17537 / #17875 / #18164) does not exist on the 1.54 pair, so most agent CRDT fixes on this line ship with unit coverage only. #18758 recorded the intended remedy — "left for a follow-up once the agent Playwright fixture infrastructure itself is backported". Christian ruled on 2026-09-26 that 1.54 has another week and the test infra should be carried, which is this PR. `agentWidgetTypingReconcile.spec.ts` is the payoff worth naming: it is the black-box proof of the widget-typing garble fix (PM-1191/PM-1697), a P0 that is live in production on this line with no e2e coverage here until now. ## Review Focus Everything came from `main` byte-identical except the adaptations below, each commented at the site: | Adaptation | Why | |---|---| | `agentConversation.ts` drops the `messageDraft` slot of `zAgentWsEvent` | `zAgentMessageDraftEvent` arrived with #18551 (streaming reply), which is not on this branch. Re-add it if #18551 is carried. | | `mockWorkflowPersistence` reads `UserDataFullInfo` from `@/schemas/apiSchema` | `main` reads it from `@/platform/remote/comfyui/types`, which does not exist here. `browser_tests/fixtures/utils/savedWorkflowPersistence.ts` already carries exactly this adaptation. | | `reloadWithoutLocalWorkflow()` waits on `.p-blockui-mask` | `App.vue` on this branch renders PrimeVue `BlockUI`, not `data-testid="app-loading-overlay"`. `ComfyPage` already matches the mask this way. | | `HostDoc.apply()` takes `RecordedGraphOperation[]` | matches `main`; the applier is the only judge of a recorded op. | | `Topbar.tabs` + `TestIds.topbar.workflowTab` | `WorkflowTab.vue` already renders `data-testid="workflow-tab"` on this branch. | | four exports in `agentConversation.ts` are module-local | their only consumer on `main` is `scripts/agentConversationAssemble.ts`, which is not backported. | **Deliberately not carried**, and the one that matters for review: - `main`'s newer `agentFollowerHostSocket.ts`. This harness uses none of its added members, and it imports `@/platform/remote/comfyui/execution/types` — absent on this branch. That is the same missing-module shape that left `core/1.54` red for six hours after #18722, so the branch's existing socket is kept as-is. - The recording-authoring side (`scripts/agentConversation{Assemble,FromLangfuse,Record}.ts`, `tools/test-recorder/.../agentReplay.ts`, `agentConversationCapabilityMatrix`). A release branch needs to replay the recordings it has, not author new ones. Verified locally against this branch: `pnpm typecheck` and `pnpm typecheck:browser` clean, `pnpm knip` clean, `pnpm lint` 0 errors, the three carried vitest files 33/33 green, and `playwright --project=cloud` on `agentConversationReplay.spec.ts` 19/20 and `agentWidgetTypingReconcile.spec.ts` 1/1. Two `agentHumanAddTabSwitch` subgraph-blueprint cases and the one `@screenshot` case cannot be judged outside the CI container — both behave identically on a `main` checkout in the same local setup, so CI is the arbiter for those three.
Two follow-ups to the cherry-pick, both test-only: - agentReplyDrafts.spec.ts reads UserDataFullInfo from @/schemas/apiSchema. main reads it from @/platform/remote/comfyui/types, which does not exist on this branch -- the same missing module that left core/1.54 red for six hours after #18722. - drops the harness note about the absent messageDraft slot, which this PR restores.
Backport of #18155 to
core/1.54Automatically created by backport workflow.