Repository navigation
[backport core/1.55] FE-3135 fix(billing): show Subscription paused copy for payment_failed renewals (#19677) - #19746
Conversation
…d renewals (#19677) Show the Subscription paused copy for `payment_failed` renewals instead of "update payment to avoid a pause", and give the member Subscription paused banner the informational (grey) icon. `v1_payment_recovery` went to 100% in prod today, so this banner is live. For a `payment_failed` renewal the run button is already locked (`CloudRunButtonWrapper` locks on `payment_failed` regardless of the flag), yet the settings banner says "Update payment to avoid a pause", which describes a warning stage that does not exist. Per design review (Alex), until BE-6970 records failed renewals as `paused`, `payment_failed` should read as paused. About 850 workspaces are in `payment_failed` today. The banner copy for `payment_failed` was written for a dunning model where a failed payment is a warning before a pause. The backend never set `paused` on renewal failure (BE-6970), so `payment_failed` is the blocked state in practice, and the copy disagrees with the run lock. - **What**: - `paymentFailedView` reuses `pausedView` (title, body, Update payment) and keeps Pay invoice when a hosted https invoice URL exists. - Paused member banner is muted (grey circle-alert), matching the design reference; owner stays amber. - Removes the now-unused `billingStatus.warning` strings and the invoice amount formatting (Stripe decimal tables) that only fed that copy. - Who sees it is unchanged: `payment_failed` is still owner-only. - Temporary mapping, tied to BE-6970 in a one-line comment. When failed renewals arrive as `paused`, `payment_failed` stops being the blocked state and this can be revisited. - No E2E added: this is copy and icon selection inside the settings banner, driven by billing state that Playwright cannot put a real workspace into; `BillingStatusBanner.test.ts` covers the payment_failed copy and actions. - Design reference: [Subscription paused, owner](https://www.figma.com/design/CkFTD4c20PyRGpNVAJgpfV/Workspaces--BIlling--Team-Plans?node-id=7186-30645), [member](https://www.figma.com/design/CkFTD4c20PyRGpNVAJgpfV/Workspaces--BIlling--Team-Plans?node-id=7186-30669). | # | Step | Status | |---|------|--------| | 1 | Ramp `v1_payment_recovery` to 100% | done | | **2** | **Payment failed reads as paused; member paused icon grey (this PR)** | **this PR** | | 3 | Split Members credit limits off `billing_control_enabled` (#19641) | in review | | 4 | `billing_control_enabled` banner copy/roles per design review | next | | 5 | New "Plan ended" banner + Members footer | after 4 | | 6 | Ramp `billing_control_enabled`, then remove both gates | after 3-5 | ```mermaid flowchart LR A[1 ramp v1_payment_recovery] --> B[2 payment_failed copy - this PR]:::me C[3 split flags #19641] --> D[4 banner copy fixes] D --> F[6 ramp + remove gates] E[5 Plan ended banner] --> F B --> F classDef me fill:#3b5bdb,color:#fff ``` **AS IS** — `payment_failed`, owner: "Payment failed … update payment to avoid a pause". Paused member: amber icon. Captured from Storybook (`DISTRIBUTION=cloud`): real banner logic, demo billing data. `payment_failed`, owner (old): <img width="900" alt="AS IS payment_failed owner" src="https://github.com/user-attachments/assets/6c46c7dc-99ae-4f75-b3a8-d2c93157e236" /> Paused, member (old): <img width="900" alt="AS IS paused member" src="https://github.com/user-attachments/assets/d8bf876f-cfc5-4db9-9ad3-7127bd8e621c" /> **TO BE** — `payment_failed`, owner: "Subscription paused … Update payment to resume". Paused member: grey icon. `payment_failed`, owner (new): <img width="900" alt="TO BE payment_failed owner" src="https://github.com/user-attachments/assets/36cbf1db-c745-44e7-a74b-b776aecfd253" /> Paused, member (new): <img width="900" alt="TO BE paused member" src="https://github.com/user-attachments/assets/deedd2e7-4c1d-4f8d-8568-e192fa0bcd72" /> - Fixes FE-3135 (cherry picked from commit 13a9333) ## Backport adaptation (core/1.55) core/1.55 predates main's refactor of the banner into per-kind view factories, and has no renewal-invoice support at all: `BannerView` has no `payInvoiceUrl`, the template has no Pay invoice button, there is no `payInvoice` string, and `useBillingContext` does not expose `renewalInvoice`. The upstream diff was therefore applied as behaviour, not as text: - `BillingStatusBanner.vue` — kept this branch's single `switch`-based `banner` computed instead of taking main's `pausedView`/ `paymentFailedView` factories (accept-theirs would have produced a broken hybrid, and would also have dragged in the unrelated `isEnterprisePlan` ending-copy change that is not on this branch). `paymentFailed` now shares the `paused` case, and `paused` is muted for members — the two behaviours this PR actually ships. The Pay invoice part is omitted: that feature does not exist on this branch. - `BillingStatusBanner.test.ts` — dropped the `renewal invoice` describe block (exercises the Pay invoice button and `state.renewalInvoice`, neither of which exists here). Kept the renamed payment_failed test and its updated paused-copy assertions. - `src/locales/en/main.json` — removed the now-unused `billingStatus.warning` strings. Verified the banner was their only consumer on this branch. `bodyWithAmount` was never on this branch.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2146 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (7 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since cc2945c0325048da3fa43d9d6b11959dc6205539
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-01T23:29:05.333Z",
"gitSha": "996bc3d0229bd1f5515274e6e6e09acab30b5717",
"branch": "glary/carrier-backport-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.8830000000257,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.563,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.739,
"heapDeltaBytes": -7779436,
"heapUsedBytes": 60174556,
"domNodes": -260,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 11.347,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2014.314000000013,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.576,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.79799999999994,
"heapDeltaBytes": -5367112,
"heapUsedBytes": 62444528,
"domNodes": -262,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 9.681,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1759.3219999999974,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.384,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 826.824,
"heapDeltaBytes": 12758160,
"heapUsedBytes": 80606360,
"domNodes": -255,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 154.191,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1766.666999999984,
"styleRecalcs": 45,
"styleRecalcDurationMs": 16.583000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 808.2309999999999,
"heapDeltaBytes": 4883056,
"heapUsedBytes": 72243044,
"domNodes": -260,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 149.85700000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.1640000000107,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.019000000000002,
"layouts": 6,
"layoutDurationMs": 1.19,
"taskDurationMs": 343.23800000000006,
"heapDeltaBytes": 3100916,
"heapUsedBytes": 70832936,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.460000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.2880000000623,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.134,
"layouts": 6,
"layoutDurationMs": 1.1800000000000004,
"taskDurationMs": 339.44399999999996,
"heapDeltaBytes": 3099500,
"heapUsedBytes": 70748584,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.899999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 676.3870000000338,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.525,
"heapDeltaBytes": 18981944,
"heapUsedBytes": 86631304,
"domNodes": 22,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 166.171,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 642.5560000000132,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.632999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.844,
"heapDeltaBytes": 18536480,
"heapUsedBytes": 86572588,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 161.921,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1170.031999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 839.2559999999999,
"heapDeltaBytes": 38292036,
"heapUsedBytes": 108140760,
"domNodes": 0,
"jsHeapTotalBytes": 19034112,
"scriptDurationMs": 67.536,
"eventListeners": 0,
"totalBlockingTimeMs": 551,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1198.1829999999718,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 892.8829999999999,
"heapDeltaBytes": 9477956,
"heapUsedBytes": 100085076,
"domNodes": -295,
"jsHeapTotalBytes": 22695936,
"scriptDurationMs": 61.683,
"eventListeners": -195,
"totalBlockingTimeMs": 577,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 842.7280000000223,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.9349999999998,
"heapDeltaBytes": 14884068,
"heapUsedBytes": 91635740,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 145.88,
"eventListeners": 0,
"totalBlockingTimeMs": 222,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.9919999999574,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.0979999999997,
"heapDeltaBytes": 14478592,
"heapUsedBytes": 90217712,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 140.51999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9543.83200000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8624.269999999999,
"heapDeltaBytes": 1363188,
"heapUsedBytes": 83928484,
"domNodes": -14,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 6894.853999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 316,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9257.396999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8409.158,
"heapDeltaBytes": -351468,
"heapUsedBytes": 82715108,
"domNodes": -18,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 7006.009,
"eventListeners": 0,
"totalBlockingTimeMs": 608,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8957.650999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8191.139,
"heapDeltaBytes": -11563392,
"heapUsedBytes": 69524012,
"domNodes": -12,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 6508.103,
"eventListeners": 0,
"totalBlockingTimeMs": 230,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8914.612999999918,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8153.616,
"heapDeltaBytes": 1295704,
"heapUsedBytes": 83411904,
"domNodes": -12,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 6528.406999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 278,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2046.4020000000005,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.541000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 634.4799999999999,
"heapDeltaBytes": -2879976,
"heapUsedBytes": 83710816,
"domNodes": -241,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 37.89999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2041.6940000000068,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.805999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.283,
"heapDeltaBytes": -3260488,
"heapUsedBytes": 83560308,
"domNodes": -243,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 35.858000000000004,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2248.1579999999894,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.824999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1659.9020000000003,
"heapDeltaBytes": -7166668,
"heapUsedBytes": 80647892,
"domNodes": -247,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 821.548,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2267.1799999999394,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.810999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1693.4539999999997,
"heapDeltaBytes": -10660708,
"heapUsedBytes": 77235392,
"domNodes": -244,
"jsHeapTotalBytes": 2613248,
"scriptDurationMs": 846.0289999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3550.3530000000296,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.720000000000004,
"layouts": 60,
"layoutDurationMs": 15.01,
"taskDurationMs": 1767.257,
"heapDeltaBytes": -15815848,
"heapUsedBytes": 73484308,
"domNodes": -256,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 793.103,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3448.4509999999773,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.152999999999999,
"layouts": 60,
"layoutDurationMs": 14.767000000000001,
"taskDurationMs": 1672.087,
"heapDeltaBytes": 10158012,
"heapUsedBytes": 75381244,
"domNodes": -252,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 774.6179999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3167.7049999999554,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.998999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1969.8060000000003,
"heapDeltaBytes": 29583900,
"heapUsedBytes": 95818188,
"domNodes": 8,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 1013.0539999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3036.3250000000335,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.703999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1824.698,
"heapDeltaBytes": 387848,
"heapUsedBytes": 91584368,
"domNodes": -247,
"jsHeapTotalBytes": -602112,
"scriptDurationMs": 1003.995,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2074.290000000019,
"styleRecalcs": 8,
"styleRecalcDurationMs": 10.756000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 643.363,
"heapDeltaBytes": -7308924,
"heapUsedBytes": 81634028,
"domNodes": -249,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 36.284,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2013.5609999999815,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.247,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.607,
"heapDeltaBytes": 20127672,
"heapUsedBytes": 84421912,
"domNodes": -252,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.871,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 597.4029999999857,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.591000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.755,
"heapDeltaBytes": 14058784,
"heapUsedBytes": 84042024,
"domNodes": 22,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 153.21099999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 572.9489999999942,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.738000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.58900000000006,
"heapDeltaBytes": 13383412,
"heapUsedBytes": 83680024,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 143.489,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2035.3540000000407,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.138,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 562.822,
"heapDeltaBytes": 11612488,
"heapUsedBytes": 81569316,
"domNodes": -276,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 11.951,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2003.217999999947,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.363999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.665,
"heapDeltaBytes": 9733936,
"heapUsedBytes": 79715632,
"domNodes": -276,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.179000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1716.5730000000394,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.082,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 758.8199999999999,
"heapDeltaBytes": 6593172,
"heapUsedBytes": 76509148,
"domNodes": -278,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 106.282,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1751.4959999999746,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.191,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 765.7420000000001,
"heapDeltaBytes": -7225324,
"heapUsedBytes": 63054152,
"domNodes": -278,
"jsHeapTotalBytes": 7331840,
"scriptDurationMs": 105.84199999999998,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.1939999999186,
"styleRecalcs": 16,
"styleRecalcDurationMs": 29.603000000000005,
"layouts": 5,
"layoutDurationMs": 12.613999999999997,
"taskDurationMs": 1007.1280000000003,
"heapDeltaBytes": -906776,
"heapUsedBytes": 95992284,
"domNodes": 13667,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 32.937,
"eventListeners": 2383,
"totalBlockingTimeMs": 125,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8540.907000000005,
"styleRecalcs": 251,
"styleRecalcDurationMs": 42.104,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6028.456999999999,
"heapDeltaBytes": -2238388,
"heapUsedBytes": 78096936,
"domNodes": -240,
"jsHeapTotalBytes": 708608,
"scriptDurationMs": 2824.402,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8268.924999999967,
"styleRecalcs": 251,
"styleRecalcDurationMs": 40.602,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5640.482000000001,
"heapDeltaBytes": -6475104,
"heapUsedBytes": 80505660,
"domNodes": -239,
"jsHeapTotalBytes": -532480,
"scriptDurationMs": 2684.5179999999996,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17482.35799999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17313.737,
"heapDeltaBytes": -39822324,
"heapUsedBytes": 182096256,
"domNodes": -8061,
"jsHeapTotalBytes": -12378112,
"scriptDurationMs": 281.00500000000005,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17687.91299999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17475.761,
"heapDeltaBytes": -72869640,
"heapUsedBytes": 168039128,
"domNodes": -8062,
"jsHeapTotalBytes": -10604544,
"scriptDurationMs": 286.30199999999996,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 24889.37499999997,
"styleRecalcs": 171,
"styleRecalcDurationMs": 27.94100000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24827.394,
"heapDeltaBytes": -39844608,
"heapUsedBytes": 182530972,
"domNodes": -8065,
"jsHeapTotalBytes": -17739776,
"scriptDurationMs": 1039.024,
"eventListeners": -14928,
"totalBlockingTimeMs": 285,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "vue-large-graph-pan",
"durationMs": 21826.958999999988,
"styleRecalcs": 153,
"styleRecalcDurationMs": 19.682000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21667.356000000003,
"heapDeltaBytes": -72078944,
"heapUsedBytes": 168032308,
"domNodes": -8061,
"jsHeapTotalBytes": -18780160,
"scriptDurationMs": 955.2750000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 171,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6693.075000000022,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.35300000000001,
"layouts": 20,
"layoutDurationMs": 27.75699999999999,
"taskDurationMs": 6667.735000000001,
"heapDeltaBytes": -41267244,
"heapUsedBytes": 179411076,
"domNodes": -8061,
"jsHeapTotalBytes": 8323072,
"scriptDurationMs": 131.44099999999997,
"eventListeners": -14928,
"totalBlockingTimeMs": 489,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6477.750000000015,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.81199999999998,
"layouts": 20,
"layoutDurationMs": 24.895,
"taskDurationMs": 6436.828,
"heapDeltaBytes": -23465284,
"heapUsedBytes": 192082868,
"domNodes": -8061,
"jsHeapTotalBytes": 13312000,
"scriptDurationMs": 123.09599999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 447,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8886.010000000057,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8840.157000000001,
"heapDeltaBytes": -4607036,
"heapUsedBytes": 166067476,
"domNodes": 0,
"jsHeapTotalBytes": -11796480,
"scriptDurationMs": 165.02799999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8652.76300000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8597.962999999998,
"heapDeltaBytes": 3801176,
"heapUsedBytes": 178951304,
"domNodes": 0,
"jsHeapTotalBytes": -11272192,
"scriptDurationMs": 130.22,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 486.1670000000231,
"styleRecalcs": 20,
"styleRecalcDurationMs": 29.19,
"layouts": 4,
"layoutDurationMs": 1.9220000000000002,
"taskDurationMs": 148.19899999999998,
"heapDeltaBytes": 5339540,
"heapUsedBytes": 71036624,
"domNodes": 151,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 19.772,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 116.13399999998819,
"styleRecalcs": 8,
"styleRecalcDurationMs": 17.866,
"layouts": 3,
"layoutDurationMs": 0.998,
"taskDurationMs": 81.32699999999998,
"heapDeltaBytes": 3065148,
"heapUsedBytes": 68766684,
"domNodes": 108,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.065999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
No action needed on the CodeRabbit message above — it's a "review skipped" status note, not a finding. The skip is intentional and correct. This repo's own ignore_title_keywords:
- '[release]'
- '[backport'and this PR's title starts with So I'm deliberately not retriggering the review or renaming the PR: renaming to get past the filter would break the documented backport title convention and circumvent a config this repo set on purpose for exactly this class of PR. Review coverage for this change is instead:
Leaving this to CI to gate as normal. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.55 #19746 +/- ##
==========================================
Coverage 84.69% 84.70%
==========================================
Files 2315 2315
Lines 132028 132027 -1
Branches 35254 35256 +2
==========================================
+ Hits 111824 111832 +8
+ Misses 19845 19836 -9
Partials 359 359
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…copy for payment_failed renewals (#19677) (#19748) *PR Created by the Glary-Bot Agent* --- Manual backport of #19677 to `cloud/1.55`, from the v1.56.2 backport-status report. Companion to #19746 (`core/1.55`). Cherry-picked from upstream merge commit `13a9333e54`. Requested in [#frontend-releases](https://comfy-organization.slack.com/archives/C09K9TPU2G7/p1790847308032919) as a cherry-pick "carrier" backport, one per target branch. #19677 is the only PR the report flags for `cloud/1.55` that is actually backportable, so this carrier carries one commit — see "Why this carrier holds one commit" below. ## Why For a `payment_failed` renewal the run button is already locked, but the settings banner said "Update payment to avoid a pause" — copy describing a warning stage that does not exist, because the backend never sets `paused` on renewal failure (BE-6970). `payment_failed` now reads as paused, and the member paused banner gets the informational grey icon. ## Conflict resolution Identical to #19746: `BillingStatusBanner.vue` and `BillingStatusBanner.test.ts` are **byte-identical** between `core/1.55` and `cloud/1.55` at their bases (verified by blob hash), so this is the same resolution. `cloud/1.55` predates main's refactor of this banner into per-kind view factories, and has no renewal-invoice support: `BannerView` has no `payInvoiceUrl`, the template has no Pay invoice button, there is no `payInvoice` string, and `useBillingContext` does not expose `renewalInvoice`. The upstream diff was applied as behaviour, not as text. - **`BillingStatusBanner.vue`** — kept this branch's single `switch`-based `banner` computed rather than main's `pausedView()`/`paymentFailedView()` factories. Accept-theirs would have produced a broken hybrid and dragged in an unrelated `isEnterprisePlan` ending-copy change not on this branch. `paymentFailed` now shares the `paused` case, and `paused` is muted for members. The Pay invoice branch is omitted — that feature does not exist here. - **`BillingStatusBanner.test.ts`** — dropped upstream's edits to the `renewal invoice` describe block; that block does not exist on this branch. Kept the renamed payment_failed test and its updated paused-copy assertions. - **`src/locales/en/main.json`** — removed the now-unused `billingStatus.warning` strings. This file is *not* identical between the 1.55 branches, so the conflict was resolved in place rather than by reusing the `core/1.55` blob; the `billingStatus` sub-tree is identical (verified by hash) and the banner was the strings' only consumer. Semantics preserved exactly: upstream's `pausedView()` is `{ muted: !canManage, title: paused.title, body: canManage ? paused.body : paused.memberBody, action: canManage ? 'updatePayment' : null, dismissible: false }`, and the merged `case 'paused'/'paymentFailed'` arm reproduces that. `useBillingBanner` gates `paymentFailed` on `canManage`, so the newly-gated `action` and `muted` resolve to the same values upstream produces. No backport-only compatibility shim was needed; no public API shape or callback signature changed. The resulting net diff is identical to #19746 (3 files, +7/−24). ## Validation - `pnpm test:unit BillingStatusBanner.test.ts` — 20/20 passing - `pnpm typecheck` — exit 0 - `pnpm exec oxfmt --check` on changed files — clean - Rendered verification was done on the identical `core/1.55` component tree (see #19746 for screenshots and the live-DOM icon-class/colour table): `payment_failed` owner flips from "Payment failed / …avoid a pause" to "Subscription paused / …Update payment to resume", and the paused **member** icon flips from amber `icon-[lucide--triangle-alert]` `rgb(252,191,100)` to grey `icon-[lucide--circle-alert]` `rgb(73,74,80)`, with the paused owner unchanged. No E2E added — matching upstream, which notes Playwright cannot put a real workspace into these billing states. ## Why this carrier holds one commit The report flagged four PRs as "❗ Need backport". Two cannot be carried: - **#19053** ("restore live turn after panel remount", PM-1776) — **not merged.** Only `refs/pull/19053/head` exists; it is 69 commits ahead of `main` with no squash commit, which is why the report listed it without a `(#NNNNN)` suffix. There is nothing to cherry-pick. - **#19240** ("say when the open workflow is deleted") — flagged for `cloud/1.55`, but its **prerequisite is missing on every target branch.** Its mechanism marks the target unavailable so the in-chat notice from #18866 renders. Neither `markWorkflowTargetUnavailable`/`targetUnavailable` nor the `targetWorkflowUnavailable` string exists on `core/1.54`, `cloud/1.54`, `core/1.55` or `cloud/1.55`, and the 1.55 branches still use the older `WorkflowTargetSelection` model instead of `TargetTracking` — so the cherry-pick does not even apply here. Carrying it would set a state nothing renders, a silent no-op defeating the fix. It needs #18866 backported first. #18074 is labelled `core/1.54` + `cloud/1.54` only, so it is not in this branch's scope. Original PR: #19677 / Original commit: `13a9333e5426d6e2e2f5f61d3da72a8184176a75` Justification: Standing Agent release-backport grant; independent exact-head audit found faithful cloud/1.55 adaptation, all hosted checks are terminal green at aed7958, and the live target advanced by three commits with zero changed-file overlap. REVIEW_REQUIRED alone is not an added approval requirement for this grant. Co-authored-by: Dante <bunggl@naver.com>
christian-byrne
left a comment
There was a problem hiding this comment.
Target-refresh review at the new exact head — merging under the standing Agent release-backport grant.
This is a COMMENT, not an approval: I am authenticated as the PR author, and the grant explicitly
forbids manufacturing an approval record.
Why the head moved
The carrier was 2 commits behind core/1.55 and the target-aware guard refused on target-tip
staleness alone — nothing else. I merged the target branch in (no rebase, no force-push):
- previous head
6fc92b38b2c726d8df6ea807673d39d0bfe938f3 - merged-in
core/1.55tipcc2945c0325048da3fa43d9d6b11959dc6205539 - new head
b5f4303dd827196e45bd18bc17cab5c652733028
The merge was conflict-free.
Proof the merged tree is the target tip plus exactly this carrier's delta
git diff --stat origin/core/1.55 b5f4303dd8:
src/locales/en/main.json | 4 ----
.../dialogs/settings/BillingStatusBanner.test.ts | 15 ++++-----------
.../components/dialogs/settings/BillingStatusBanner.vue | 12 +++---------
3 files changed, 7 insertions(+), 24 deletions(-)
Identical to the pre-merge delta — the target merge added no payload. Stronger: this delta is
byte-identical to the upstream source commit aed795880dc552b53d8fd55bd7c1adc099d07c1c on main
(#19677) and to the already-merged cloud/1.55 twin 26c10985c6 (#19748). Same 3 files, same
+7/−24, same hunks.
Target-specific applicability
Billing UI, so verified as behaviour and not merely as a compile:
BillingStatusBanner.test.ts asserts rendered DOM through screen.getByRole('status'), so it pins
the user-visible copy, not an internal call.
npx vitest run src/platform/workspace/components/dialogs/settings/BillingStatusBanner.test.ts
at the merged headb5f4303dd8— 20/20 passing. It asserts apayment_failedrenewal now reads
"Subscription paused" / "Update payment to resume" rather than the old "Payment failed" /
"…avoid a pause" warning copy, for both the owner and the personal-workspace path.npx vue-tsc --noEmitat the merged head — exit 0. Run deliberately: #18722 admin-merged over a
lint-and-formatFAILURE and leftcore/1.54red for six hours, and typecheck is exactly what
catches that class.- No black-box coverage exists for these banner states on any branch —
grepforpayment_failed/
Subscription pausedacrossbrowser_tests/returns only billing mocks, no assertion. Upstream
added none either, noting Playwright cannot drive a real workspace into these billing states. So
there is no release-branch black-box case to run, and none was weakened or skipped.
Gate
scripts/check-merge-ready.sh Comfy-Org/ComfyUI_frontend 19746 --target-branch core/1.55 re-run at
the new exact head after all required checks went terminal.
No Vercel – billing-web-test status is present on this carrier, so the core/1.54/cloud/1.54
waiver is not relied on here and was not extended to the 1.55 line. Every check is green on its own.
No review threads, no human objections. REVIEW_REQUIRED alone is not an added approval requirement
under this grant.
Gate output at the merged head
MERGE READY: https://github.com/Comfy-Org/ComfyUI_frontend/pull/19746
base: core/1.55@cc2945c0325048da3fa43d9d6b11959dc6205539 (ancestor of head)
head: b5f4303dd827196e45bd18bc17cab5c652733028
checks: 104 completed; success/neutral/skipped only
test receipts: no older than base commit 2026-10-01T22:47:29Z
reviews: no unresolved threads or later reviewer objections
All required checks terminal: 90 pass, 15 skipped, 0 failures.
Merging with --squash --admin --match-head-commit b5f4303dd827196e45bd18bc17cab5c652733028.
PR Created by the Glary-Bot Agent
Manual backport of #19677 to
core/1.55, from the v1.56.2 backport-status report.Cherry-picked from upstream merge commit
13a9333e54.Requested in #frontend-releases as a cherry-pick "carrier" backport, one per target branch. #19677 is the only PR the report flags for
core/1.55that is actually backportable, so this carrier carries one commit — see "Why this carrier holds one commit" below.Why
For a
payment_failedrenewal the run button is already locked, but the settings banner said "Update payment to avoid a pause" — copy describing a warning stage that does not exist, because the backend never setspausedon renewal failure (BE-6970).payment_failednow reads as paused, and the member paused banner gets the informational grey icon.Conflict resolution
core/1.55predates main's refactor of this banner into per-kind view factories, and has no renewal-invoice support at all:BannerViewhas nopayInvoiceUrl, the template has no Pay invoice button, there is nopayInvoicestring, anduseBillingContextdoes not exposerenewalInvoice. The upstream diff was therefore applied as behaviour, not as text.BillingStatusBanner.vue— kept this branch's singleswitch-basedbannercomputed rather than taking main'spausedView()/paymentFailedView()factories. Accept-theirs here would have produced a broken hybrid, and would also have dragged in an unrelatedisEnterprisePlanending-copy change that is not on this branch.paymentFailednow shares thepausedcase, andpausedis muted for members — the two behaviours this PR actually ships. The Pay invoice branch is omitted because that feature does not exist here.BillingStatusBanner.test.ts— dropped upstream's edits to therenewal invoicedescribe block; that block does not exist on this branch (it exercises the Pay invoice button andstate.renewalInvoice). Kept the renamed payment_failed test and its updated paused-copy assertions.src/locales/en/main.json— removed the now-unusedbillingStatus.warningstrings. Verified the banner was their only consumer on this branch;bodyWithAmountwas never here.Semantics are preserved exactly: upstream's
pausedView()is{ muted: !canManage, title: paused.title, body: canManage ? paused.body : paused.memberBody, action: canManage ? 'updatePayment' : null, dismissible: false }, and the mergedcase 'paused'/'paymentFailed'arm reproduces that.useBillingBannergatespaymentFailedoncanManage, so the newly-gatedactionandmutedresolve to the same values upstream produces.No backport-only compatibility shim was needed; no public API shape or callback signature changed.
Validation
pnpm test:unit BillingStatusBanner.test.ts— 20/20 passingpnpm typecheck— exit 0pnpm exec eslint/oxfmt --checkon changed files — 0 errors, clean formatDISTRIBUTION=cloud) in a browser and read the live DOM, before and after:PaymentDeclined(payment_failed, owner)PausedMembericon-[lucide--triangle-alert] text-warning-background→ amberrgb(252,191,100)icon-[lucide--circle-alert] text-muted-foreground→ greyrgb(73,74,80)PausedOwnerpayment_failedrenders a single "Update payment" action and no Pay invoice button, as expected on this branch.No E2E added — matching upstream, which notes Playwright cannot put a real workspace into these billing states;
BillingStatusBanner.test.tscovers the copy and actions.Why this carrier holds one commit
The report flagged four PRs as "❗ Need backport". Two cannot be carried:
refs/pull/19053/headexists; it is 69 commits ahead ofmainwith no squash commit, which is why the report listed it without a(#NNNNN)suffix. There is nothing to cherry-pick.markWorkflowTargetUnavailable/targetUnavailablenor thetargetWorkflowUnavailablestring exists oncore/1.54,cloud/1.54,core/1.55orcloud/1.55, and the 1.55 branches still use the olderWorkflowTargetSelectionmodel instead ofTargetTracking. Cherry-picking it alone would set a state nothing renders — a silent no-op defeating the fix. It needs fix(agent): reopen saved workflows from chat history #18866 backported first.#18074 is labelled
core/1.54+cloud/1.54only, so it is not in this branch's scope.Original PR: #19677 / Original commit:
13a9333e5426d6e2e2f5f61d3da72a8184176a75Screenshots