Repository navigation
Fix duplicate-name stale workflow binding resolution - #18155
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2119 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle: 9.98 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.87 kB (baseline 3.87 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.44 MB (baseline 1.44 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 28 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.94 MB (baseline 3.94 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 577 kB (baseline 577 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.8 MB (baseline 17.8 MB) • ⚪ 0 BBundles that do not match a named category Status: 302 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T10:02:55.676Z",
"gitSha": "e880ad972e450cc5b36b07842d0594d283659ba2",
"branch": "christian-byrne/evpub-1-duplicate-binding",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2017.9650000000038,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.8900000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.804,
"heapDeltaBytes": -7276052,
"heapUsedBytes": 60463428,
"domNodes": -261,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.863000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1990.713000000028,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.03,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.12,
"heapDeltaBytes": 9075312,
"heapUsedBytes": 76795444,
"domNodes": -261,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.441999999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1793.1140000000028,
"styleRecalcs": 45,
"styleRecalcDurationMs": 16.209,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 845.9420000000001,
"heapDeltaBytes": 10879364,
"heapUsedBytes": 78669572,
"domNodes": -262,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 156.84699999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1774.116000000049,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.850000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 851.895,
"heapDeltaBytes": 9787904,
"heapUsedBytes": 77357184,
"domNodes": -261,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 150.081,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.2789999999868,
"styleRecalcs": 33,
"styleRecalcDurationMs": 17.092000000000002,
"layouts": 6,
"layoutDurationMs": 1.588,
"taskDurationMs": 364.011,
"heapDeltaBytes": 2544148,
"heapUsedBytes": 70088280,
"domNodes": 79,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 14.034,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.983000000013,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.381999999999998,
"layouts": 6,
"layoutDurationMs": 1.406,
"taskDurationMs": 372.739,
"heapDeltaBytes": 3101956,
"heapUsedBytes": 70679580,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.124000000000004,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 651.3459999999895,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.629000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.59999999999997,
"heapDeltaBytes": 18958876,
"heapUsedBytes": 86492620,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 159.352,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 634.7650000000158,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.671000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.05899999999997,
"heapDeltaBytes": 18911468,
"heapUsedBytes": 86589792,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 157.137,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1225.5139999999756,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 926.8470000000001,
"heapDeltaBytes": -17002652,
"heapUsedBytes": 73147140,
"domNodes": -295,
"jsHeapTotalBytes": 20054016,
"scriptDurationMs": 69.24699999999999,
"eventListeners": -217,
"totalBlockingTimeMs": 559,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1275.7039999999051,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 958.7780000000001,
"heapDeltaBytes": -16405176,
"heapUsedBytes": 73695228,
"domNodes": -295,
"jsHeapTotalBytes": 19791872,
"scriptDurationMs": 68.55699999999999,
"eventListeners": -217,
"totalBlockingTimeMs": 583,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 810.750999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.549,
"heapDeltaBytes": 14613256,
"heapUsedBytes": 91157156,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 134.01000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 189,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 798.0830000000196,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.01600000000013,
"heapDeltaBytes": 14937904,
"heapUsedBytes": 90345496,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 135.34099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 186,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9195.778000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8235.865,
"heapDeltaBytes": 10133260,
"heapUsedBytes": 91719416,
"domNodes": -16,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 6681.374000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 518,
"frameDurationMs": 19.439999999999962,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9131.771999999955,
"styleRecalcs": 1,
"styleRecalcDurationMs": 1.0560000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8365.758999999998,
"heapDeltaBytes": 17635380,
"heapUsedBytes": 81516724,
"domNodes": -270,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 6566.339,
"eventListeners": -174,
"totalBlockingTimeMs": 196,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10071.63399999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9171.341999999999,
"heapDeltaBytes": 21734480,
"heapUsedBytes": 97567044,
"domNodes": -8,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 7630.489,
"eventListeners": 0,
"totalBlockingTimeMs": 927,
"frameDurationMs": 18.889999999999965,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9465.443999999934,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8563.867999999999,
"heapDeltaBytes": -9018836,
"heapUsedBytes": 72976228,
"domNodes": -18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 6790.329,
"eventListeners": 0,
"totalBlockingTimeMs": 339,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2043.566999999996,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.6720000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 641.3310000000001,
"heapDeltaBytes": -2964300,
"heapUsedBytes": 83505000,
"domNodes": -242,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 44.78199999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2072.108000000071,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.193,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 673.809,
"heapDeltaBytes": -6876340,
"heapUsedBytes": 80006588,
"domNodes": -248,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 36.23,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2621.9559999999547,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.661000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1739.8460000000002,
"heapDeltaBytes": 21060656,
"heapUsedBytes": 85116240,
"domNodes": -242,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 861.906,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2550.177000000076,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.696000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1760.3650000000002,
"heapDeltaBytes": -3090740,
"heapUsedBytes": 84361144,
"domNodes": -248,
"jsHeapTotalBytes": 1564672,
"scriptDurationMs": 848.662,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3686.8870000000697,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.055999999999997,
"layouts": 60,
"layoutDurationMs": 13.784999999999998,
"taskDurationMs": 1749.152,
"heapDeltaBytes": 8444164,
"heapUsedBytes": 74159720,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 780.6070000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3601.8629999999803,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.709000000000001,
"layouts": 60,
"layoutDurationMs": 14.777999999999999,
"taskDurationMs": 1731.744,
"heapDeltaBytes": 7990688,
"heapUsedBytes": 74436228,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 781.252,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3094.787999999994,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.563,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1950.664,
"heapDeltaBytes": 21664228,
"heapUsedBytes": 88085336,
"domNodes": 4,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 965.0930000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3189.301999999998,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.692000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1936.258,
"heapDeltaBytes": -3085816,
"heapUsedBytes": 88142568,
"domNodes": -253,
"jsHeapTotalBytes": 446464,
"scriptDurationMs": 1021.8479999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2031.0099999999238,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.232,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 602.1970000000001,
"heapDeltaBytes": -4176612,
"heapUsedBytes": 84033412,
"domNodes": -246,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 33.599000000000004,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2022.0050000000356,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.847000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 642.82,
"heapDeltaBytes": -4458368,
"heapUsedBytes": 84463392,
"domNodes": -244,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 36.702,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 621.5490000000727,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.268999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.451,
"heapDeltaBytes": 13436200,
"heapUsedBytes": 83699016,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 146.753,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.916000000002,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.886,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.08000000000004,
"heapDeltaBytes": 14067872,
"heapUsedBytes": 84002752,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 141.898,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1992.768999999953,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.644,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.77399999999994,
"heapDeltaBytes": 3997624,
"heapUsedBytes": 74032740,
"domNodes": -278,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.097000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2037.576999999942,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.020999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.192,
"heapDeltaBytes": 6343892,
"heapUsedBytes": 76426456,
"domNodes": -274,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.215000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.818000000008,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.241,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 811.8249999999999,
"heapDeltaBytes": 7295016,
"heapUsedBytes": 77194404,
"domNodes": -276,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 108.93799999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1720.2030000000832,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.228000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 824.7490000000001,
"heapDeltaBytes": 7028576,
"heapUsedBytes": 77193656,
"domNodes": -277,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 111.03600000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.4340000000184,
"styleRecalcs": 16,
"styleRecalcDurationMs": 25.439000000000004,
"layouts": 5,
"layoutDurationMs": 11.089000000000002,
"taskDurationMs": 921.044,
"heapDeltaBytes": -6280064,
"heapUsedBytes": 81646104,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 30.780999999999995,
"eventListeners": 2383,
"totalBlockingTimeMs": 133,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8862.302999999996,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.044000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6147.184,
"heapDeltaBytes": -4973120,
"heapUsedBytes": 81689880,
"domNodes": -219,
"jsHeapTotalBytes": 2056192,
"scriptDurationMs": 2821.965,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9184.751000000006,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.278000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6253.693,
"heapDeltaBytes": 13130536,
"heapUsedBytes": 99209200,
"domNodes": -252,
"jsHeapTotalBytes": 4153344,
"scriptDurationMs": 2889.158,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15250.009999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15022.286999999998,
"heapDeltaBytes": -69474736,
"heapUsedBytes": 168620516,
"domNodes": -8094,
"jsHeapTotalBytes": -8843264,
"scriptDurationMs": 227.962,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 11182.551999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10662.605,
"heapDeltaBytes": -46930788,
"heapUsedBytes": 200836076,
"domNodes": -8061,
"jsHeapTotalBytes": -12783616,
"scriptDurationMs": 188.72300000000004,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18513.204999999973,
"styleRecalcs": 133,
"styleRecalcDurationMs": 16.956,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18405.524999999998,
"heapDeltaBytes": -51557572,
"heapUsedBytes": 189415376,
"domNodes": -8061,
"jsHeapTotalBytes": -17047552,
"scriptDurationMs": 916.11,
"eventListeners": -14928,
"totalBlockingTimeMs": 31,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18249.720000000023,
"styleRecalcs": 127,
"styleRecalcDurationMs": 16.681,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18115.931000000004,
"heapDeltaBytes": -39455456,
"heapUsedBytes": 179539040,
"domNodes": -8061,
"jsHeapTotalBytes": -18096128,
"scriptDurationMs": 891.8699999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 26,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5514.537000000018,
"styleRecalcs": 20,
"styleRecalcDurationMs": 89.641,
"layouts": 20,
"layoutDurationMs": 31.967999999999996,
"taskDurationMs": 5490.4220000000005,
"heapDeltaBytes": -39077208,
"heapUsedBytes": 176137268,
"domNodes": -8061,
"jsHeapTotalBytes": 11739136,
"scriptDurationMs": 96.218,
"eventListeners": -14928,
"totalBlockingTimeMs": 421,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5712.350000000015,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.63299999999998,
"layouts": 20,
"layoutDurationMs": 27.175000000000004,
"taskDurationMs": 5647.732999999999,
"heapDeltaBytes": -57485068,
"heapUsedBytes": 183755512,
"domNodes": -8061,
"jsHeapTotalBytes": 13692928,
"scriptDurationMs": 104.29799999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 361,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7667.580999999927,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7533.262000000001,
"heapDeltaBytes": -7567108,
"heapUsedBytes": 170704120,
"domNodes": 0,
"jsHeapTotalBytes": -23592960,
"scriptDurationMs": 112.342,
"eventListeners": -1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7604.206999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7467.924999999999,
"heapDeltaBytes": 2735516,
"heapUsedBytes": 197137772,
"domNodes": 0,
"jsHeapTotalBytes": -29884416,
"scriptDurationMs": 117.64400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 99.7899999999845,
"styleRecalcs": 5,
"styleRecalcDurationMs": 15.161,
"layouts": 3,
"layoutDurationMs": 1.729,
"taskDurationMs": 75.20500000000003,
"heapDeltaBytes": 3153504,
"heapUsedBytes": 68781016,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.219000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 464.2420000000129,
"styleRecalcs": 13,
"styleRecalcDurationMs": 20.424,
"layouts": 3,
"layoutDurationMs": 0.8490000000000001,
"taskDurationMs": 124.561,
"heapDeltaBytes": 4782844,
"heapUsedBytes": 70463204,
"domNodes": 117,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.61,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since fce6d77e36b3f3ec7c00ce405c56628eabc55a12
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe workflow resolver now checks Cloud index entries directly when it resolves workflow names and stale bindings. Unit and browser tests cover duplicate names, stale binding removal, local workflow resolution, and the saved ChangesWorkflow resolution
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~15 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable merge-blocking issue is established; complete the normal checks before merging. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18155 +/- ##
==========================================
+ Coverage 84.51% 84.53% +0.02%
==========================================
Files 2319 2288 -31
Lines 131403 130883 -520
Branches 33551 35305 +1754
==========================================
- Hits 111059 110648 -411
+ Misses 20008 19935 -73
+ Partials 336 300 -36
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 43 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
The one-line resolver change is the right shape and I can follow why it fixes the reported case: with image_z_image_turbo duplicated, cloudIdsByName drops it, so the old indexedNameFor returned undefined, bindingIsStale short-circuited to false, and resolveWorkflow handed back the unrelated Portrait tab. Reading the identity from cloudIndex instead makes indexedName available while keeping name -> id inference duplicate-safe, and the lookup is deterministic because it keys on the server-assigned id, not on the name. The two it.for regressions cover both entry points.
Three things below: one blocking (the new Playwright case is red in CI for a fixable reason), plus two questions.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 5 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 3 |
| 🟢 Low | 1 |
Panel: 8/8 reviewers contributed findings.
Addresses review feedback: #18155 (comment)
Addresses review feedback: #18155 (comment)
Addresses review feedback: #18155 (comment)
Addresses review feedback: #18155 (comment)
Addresses review feedback: #18155 (comment)
This comment has been minimized.
This comment has been minimized.
Addresses review feedback: #18155 (comment)
Addresses review feedback: #18155 (comment)
|
@coderabbitai review |
✅ Action performedReview finished.
|
dante01yoon
left a comment
There was a problem hiding this comment.
Re-reviewed the current head and the prior findings are resolved. The fix now covers duplicate names on both target and bound sides using the raw cloud index while preserving generated API response types. The cloud E2E is tagged for the correct lane, hydrates a message carrying the target workflow ID, opens the stale-bound tab before restoration, and positively verifies binding removal. Hosted unit, typecheck, lint, Playwright, and E2E gates are green.
|
@christian-byrne Successfully backported to #18722 |
|
@christian-byrne Successfully backported to #18723 |
## Summary Reject stale Agent workflow bindings when the target ID has a duplicated cloud name instead of resolving the unrelated saved tab and graph. ## Changes - **What**: Resolve ID-to-name identity from the full cloud index while retaining the duplicate-filtered name-to-ID inference map. Add fresh-store regressions for both resolver entry points and a browser scenario with duplicate target IDs plus a uniquely named saved `Portrait` tab. - **Dependencies**: None. ## Review Focus The lookup is intentionally asymmetric: duplicated names remain unsafe for name-to-ID inference, while an exact target ID can still retrieve its indexed name for stale-binding rejection. This is separate from the refresh-cache work in #17509 and does not modify that branch. Focused Vitest is red on `origin/main` (both entry points select `Portrait`) and green here (14/14). ESLint, formatting, full `pnpm typecheck`, browser typecheck, and the push-time `knip` gate pass. The new Playwright case is checked in but runtime proof is blocked on this worker: both it and the unchanged `agentWorkflowSelection` smoke case time out before assertions because the Agent entry button is absent on the local current-main surface. No live model call was made. ## Screenshots (if applicable) The browser run produced traces/video for the pre-assertion harness blocker; no passing screenshot is claimed. (cherry picked from commit e5a6ab0) (cherry picked from commit 15ce2ee)
## Summary Consolidates the verified fixes that landed on `cloud/1.54` but were absent from `cloud/1.55`: - #17486 keeps promoted dynamic-combo child links when loading workflows. - #18599 gives unified-remint retries a fresh timeout window. - #18093 allows nodes to shrink after content growth and tab switches. - #18155 resolves stale Agent bindings when workflows share a name. - #18693 keeps the Agent target aligned with the visible workflow until send or node reference. - #18619 waits for open dialogs before showing Agent consent. - #18061 deselects a node when its composer reference is removed. - #18392 marks video reply assets correctly. - #18664 records Agent panel visibility and page-hide teardown correctly. - #18911 restores Agent onboarding focus, navigation, and replay behavior. - #18911 remains deliberately excluded: its activation-telemetry substrate is cloud/1.54-only, and the original backport records that scope. This is the consolidated `cloud/1.55` carrier from the 1.54→1.55 release audit. The already-open saved-workflow backport remains in #19732 and is intentionally not duplicated here. ## Validation - Release-branch conflicts were resolved against the current cloud/1.55 Agent targeting, consent, and onboarding implementations. - CI is the authoritative full suite. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com> Co-authored-by: Maanil Verma <vermaMaanil97@gmail.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: dante01yoon <bunggl@naver.com> Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com> Co-authored-by: Hunter <huntcsg@users.noreply.github.com> Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com>
## Summary Reject stale Agent workflow bindings when the target ID has a duplicated cloud name instead of resolving the unrelated saved tab and graph. ## Changes - **What**: Resolve ID-to-name identity from the full cloud index while retaining the duplicate-filtered name-to-ID inference map. Add fresh-store regressions for both resolver entry points and a browser scenario with duplicate target IDs plus a uniquely named saved `Portrait` tab. - **Dependencies**: None. ## Review Focus The lookup is intentionally asymmetric: duplicated names remain unsafe for name-to-ID inference, while an exact target ID can still retrieve its indexed name for stale-binding rejection. This is separate from the refresh-cache work in #17509 and does not modify that branch. Focused Vitest is red on `origin/main` (both entry points select `Portrait`) and green here (14/14). ESLint, formatting, full `pnpm typecheck`, browser typecheck, and the push-time `knip` gate pass. The new Playwright case is checked in but runtime proof is blocked on this worker: both it and the unchanged `agentWorkflowSelection` smoke case time out before assertions because the Agent entry button is absent on the local current-main surface. No live model call was made. ## Screenshots (if applicable) The browser run produced traces/video for the pre-assertion harness blocker; no passing screenshot is claimed. (cherry picked from commit e5a6ab0)
## Summary Carries the fixes that landed on `core/1.54` but were absent from `core/1.55`: - #17486 keeps promoted dynamic-combo child links when loading workflows. - #18599 gives unified-remint retries a fresh timeout window. - #18093 allows nodes to shrink after content growth and tab switches. - #18155 resolves stale Agent bindings when workflows share a name. - #18693 keeps the Agent target aligned with the visible workflow until send or node reference. - #18619 waits for open dialogs before showing Agent consent. - #18061 deselects a node when its composer reference is removed. - #18392 marks video reply assets correctly. This is the consolidated `core/1.55` carrier from the 1.54→1.55 release audit. ## Validation - Cherry-picks applied cleanly except for release-branch adaptations in Agent consent and workflow targeting. - Local typecheck is running; CI is the authoritative full suite. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: Maanil Verma <vermaMaanil97@gmail.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: dante01yoon <bunggl@naver.com> Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com> Co-authored-by: GitHub Action <action@github.com>
Summary
Reject stale Agent workflow bindings when the target ID has a duplicated cloud name instead of resolving the unrelated saved tab and graph.
Changes
Portraittab.Review Focus
The lookup is intentionally asymmetric: duplicated names remain unsafe for name-to-ID inference, while an exact target ID can still retrieve its indexed name for stale-binding rejection. This is separate from the refresh-cache work in #17509 and does not modify that branch.
Focused Vitest is red on
origin/main(both entry points selectPortrait) and green here (14/14). ESLint, formatting, fullpnpm typecheck, browser typecheck, and the push-timeknipgate pass. The new Playwright case is checked in but runtime proof is blocked on this worker: both it and the unchangedagentWorkflowSelectionsmoke case time out before assertions because the Agent entry button is absent on the local current-main surface. No live model call was made.Screenshots (if applicable)
The browser run produced traces/video for the pre-assertion harness blocker; no passing screenshot is claimed.