Repository navigation
[Backport core/1.54] test: repro agent-CRDT reconcile overwriting live node/title/widget state (#18075) - #18758
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1954 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-25T02:13:52.026Z",
"gitSha": "190b4d157e1cabd4f563db585d916c1e4b61b731",
"branch": "backport-18075-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2111.405999999988,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.918,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 660.923,
"heapDeltaBytes": -12911656,
"heapUsedBytes": 56577060,
"domNodes": -279,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 10.075999999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2051.3489999999592,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.837000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.237,
"heapDeltaBytes": -7806352,
"heapUsedBytes": 63419748,
"domNodes": -283,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.607999999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1842.7259999999706,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.239,
"layouts": 14,
"layoutDurationMs": 4.195,
"taskDurationMs": 874.014,
"heapDeltaBytes": -13776172,
"heapUsedBytes": 56981700,
"domNodes": -279,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 145.33599999999998,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1830.383999999981,
"styleRecalcs": 75,
"styleRecalcDurationMs": 29.205999999999996,
"layouts": 14,
"layoutDurationMs": 4.043,
"taskDurationMs": 897.8699999999999,
"heapDeltaBytes": -5128532,
"heapUsedBytes": 64915100,
"domNodes": -281,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 152.84900000000002,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1754.6820000000025,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.722,
"layouts": 6,
"layoutDurationMs": 1.096,
"taskDurationMs": 357.83200000000005,
"heapDeltaBytes": 4673680,
"heapUsedBytes": 75531644,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.453999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.9189999999808,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.598,
"layouts": 6,
"layoutDurationMs": 1.2939999999999998,
"taskDurationMs": 359.009,
"heapDeltaBytes": 4285580,
"heapUsedBytes": 74104680,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.202,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 649.9589999999671,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.947999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.25399999999996,
"heapDeltaBytes": -8249344,
"heapUsedBytes": 63010944,
"domNodes": 18,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 152.63299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 670.125999999982,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.981,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.49999999999994,
"heapDeltaBytes": 18709584,
"heapUsedBytes": 89071348,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 161.70499999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2039.1730000000052,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.1339999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 623.5089999999999,
"heapDeltaBytes": 5565008,
"heapUsedBytes": 82609680,
"domNodes": -279,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 32.382000000000005,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2069.975999999997,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.523,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 638.4820000000001,
"heapDeltaBytes": 7157604,
"heapUsedBytes": 82907348,
"domNodes": -279,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 34.75800000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2216.4840000000368,
"styleRecalcs": 62,
"styleRecalcDurationMs": 8.740000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1606.3,
"heapDeltaBytes": 19672960,
"heapUsedBytes": 85868144,
"domNodes": -284,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 810.923,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2176.979000000074,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.205,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1551.0980000000002,
"heapDeltaBytes": 18160760,
"heapUsedBytes": 84709984,
"domNodes": -273,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 766.4499999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3613.8619999999264,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.498000000000003,
"layouts": 60,
"layoutDurationMs": 13.617,
"taskDurationMs": 1759.3020000000001,
"heapDeltaBytes": -7178624,
"heapUsedBytes": 71062548,
"domNodes": -289,
"jsHeapTotalBytes": 3043328,
"scriptDurationMs": 764.605,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3474.4630000000143,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.794999999999998,
"layouts": 60,
"layoutDurationMs": 13.182999999999998,
"taskDurationMs": 1675.8449999999998,
"heapDeltaBytes": 11746420,
"heapUsedBytes": 79702456,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 760.3969999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3125.106999999957,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.506,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1911.2659999999998,
"heapDeltaBytes": 19414832,
"heapUsedBytes": 87882948,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 957.0640000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3133.2989999999654,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.607000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1984.165,
"heapDeltaBytes": 2835764,
"heapUsedBytes": 84572620,
"domNodes": -288,
"jsHeapTotalBytes": 315392,
"scriptDurationMs": 979.0550000000001,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2001.7390000000432,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.1339999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 548.4119999999999,
"heapDeltaBytes": 21569712,
"heapUsedBytes": 88108644,
"domNodes": -275,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 38.01700000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2046.214999999961,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.244000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 626.6870000000001,
"heapDeltaBytes": 5978984,
"heapUsedBytes": 83267080,
"domNodes": -279,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 33.459,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.1189999999542,
"styleRecalcs": 45,
"styleRecalcDurationMs": 10.016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.37899999999996,
"heapDeltaBytes": 14508376,
"heapUsedBytes": 87000592,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 144.401,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 605.5850000000191,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.362000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.41700000000003,
"heapDeltaBytes": 14753668,
"heapUsedBytes": 87902980,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 141.754,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2033.512000000087,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.609000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.733,
"heapDeltaBytes": 1489316,
"heapUsedBytes": 74827008,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.086,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2016.399999999976,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.788999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.25699999999995,
"heapDeltaBytes": -4425800,
"heapUsedBytes": 68859792,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.331999999999999,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1759.123000000045,
"styleRecalcs": 78,
"styleRecalcDurationMs": 27.337,
"layouts": 18,
"layoutDurationMs": 5.3149999999999995,
"taskDurationMs": 827.604,
"heapDeltaBytes": -7132432,
"heapUsedBytes": 65162928,
"domNodes": -296,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 112.268,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.059000000072,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.411,
"layouts": 18,
"layoutDurationMs": 4.783,
"taskDurationMs": 788.8499999999999,
"heapDeltaBytes": -13946336,
"heapUsedBytes": 58868008,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 105.095,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.1359999999513,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.429,
"layouts": 15,
"layoutDurationMs": 14.038000000000002,
"taskDurationMs": 930.0459999999997,
"heapDeltaBytes": 21972636,
"heapUsedBytes": 106589036,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 29.52700000000001,
"eventListeners": 2387,
"totalBlockingTimeMs": 125,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8334.215000000086,
"styleRecalcs": 248,
"styleRecalcDurationMs": 43.608999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5758.054999999999,
"heapDeltaBytes": 12278856,
"heapUsedBytes": 89002624,
"domNodes": -272,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 2638.08,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8368.592999999919,
"styleRecalcs": 248,
"styleRecalcDurationMs": 39.719,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5706.818,
"heapDeltaBytes": 22454028,
"heapUsedBytes": 98811960,
"domNodes": -283,
"jsHeapTotalBytes": 2482176,
"scriptDurationMs": 2590.712,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18116.23600000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17414.7,
"heapDeltaBytes": -57734744,
"heapUsedBytes": 176657932,
"domNodes": -8068,
"jsHeapTotalBytes": -11825152,
"scriptDurationMs": 324.626,
"eventListeners": -14929,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18130.764999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17427.67,
"heapDeltaBytes": -54995172,
"heapUsedBytes": 178359092,
"domNodes": -8068,
"jsHeapTotalBytes": -16797696,
"scriptDurationMs": 302.21,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22612.39400000011,
"styleRecalcs": 171,
"styleRecalcDurationMs": 21.35799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22301.134000000002,
"heapDeltaBytes": -49675940,
"heapUsedBytes": 178856344,
"domNodes": -8068,
"jsHeapTotalBytes": -17780736,
"scriptDurationMs": 918.223,
"eventListeners": -14925,
"totalBlockingTimeMs": 83,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-large-graph-pan",
"durationMs": 22104.639999999905,
"styleRecalcs": 168,
"styleRecalcDurationMs": 20.88500000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21877.558,
"heapDeltaBytes": -26143468,
"heapUsedBytes": 178578552,
"domNodes": -8068,
"jsHeapTotalBytes": -9449472,
"scriptDurationMs": 896.869,
"eventListeners": -14931,
"totalBlockingTimeMs": 38,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6508.130000000051,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.565,
"layouts": 20,
"layoutDurationMs": 24.198999999999998,
"taskDurationMs": 6400.774000000001,
"heapDeltaBytes": -41016440,
"heapUsedBytes": 176007828,
"domNodes": -8068,
"jsHeapTotalBytes": 12881920,
"scriptDurationMs": 138.651,
"eventListeners": -14931,
"totalBlockingTimeMs": 384,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6573.929000000021,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.93200000000006,
"layouts": 20,
"layoutDurationMs": 25.314000000000004,
"taskDurationMs": 6526.3730000000005,
"heapDeltaBytes": -38965936,
"heapUsedBytes": 179939104,
"domNodes": -8068,
"jsHeapTotalBytes": 13602816,
"scriptDurationMs": 125.54100000000001,
"eventListeners": -14927,
"totalBlockingTimeMs": 456,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9229.831999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8828.047000000002,
"heapDeltaBytes": -1416932,
"heapUsedBytes": 178345416,
"domNodes": 0,
"jsHeapTotalBytes": -15728640,
"scriptDurationMs": 153.15999999999997,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9250.809000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9035.303,
"heapDeltaBytes": 1481140,
"heapUsedBytes": 179116228,
"domNodes": 0,
"jsHeapTotalBytes": -12058624,
"scriptDurationMs": 151.79299999999995,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 95.55600000010145,
"styleRecalcs": 6,
"styleRecalcDurationMs": 12.239,
"layouts": 2,
"layoutDurationMs": 0.749,
"taskDurationMs": 66.676,
"heapDeltaBytes": 3007100,
"heapUsedBytes": 72268172,
"domNodes": 104,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 4.7959999999999985,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 486.5029999999706,
"styleRecalcs": 11,
"styleRecalcDurationMs": 21.444000000000006,
"layouts": 3,
"layoutDurationMs": 0.985,
"taskDurationMs": 131.071,
"heapDeltaBytes": 4770528,
"heapUsedBytes": 73189336,
"domNodes": 115,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.366999999999999,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
christian-byrne
left a comment
There was a problem hiding this comment.
reviewed exact head 58ad7d7029b3a1bfff63e9fce7e6fc78ef03a835 against core/1.54. The conflict resolution keeps the target branch’s existing flag serialization, ports only the title reconcile baseline, and omits the unavailable main-only browser fixture/helper. Focused unit tests pass (125 plus 3 expected failures); target typecheck, type-aware oxlint, and ESLint pass. No unresolved review threads.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #18758 +/- ##
==========================================
Coverage 83.77% 83.77%
==========================================
Files 2104 2104
Lines 124685 124693 +8
Branches 31570 31574 +4
==========================================
+ Hits 104449 104462 +13
+ Misses 20057 20052 -5
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
|
taking over this Claude-authored carrier to refresh it onto the live |
…e node/title/widget state (#18075) Manual backport of #18075 to core/1.54. Automated backport failed: #18075 (comment) Cherry-picked from 96821ac. Dependency check: the bot flagged a possible stacking conflict with #18727, #18722, #18683, #17872 (all still open against core/1.54). None of those touch graphMutations.ts, graphMutations.test.ts or agentConversationFixture.ts, so they are not the cause. The real causes: - graphMutations.ts: core/1.54 predates #18191 ("keep the ghost placement flag out of the document"), which hoisted node flags into a local `flags` variable (`cloneNodeFlags`) reused by `lastSerialization`. #18191 has no needs-backport label and was never backported here. Resolved by keeping core/1.54's existing flags handling (`cloneRecord(payload.flags)` / `structuredClone(payload)`) and porting only #18075's actual change: `resolveNodeTitle` plus the new `titleReconcileBaseline` field. - graphMutations.test.ts: pure insertion, no real conflict — accepted the new test cases as-is. - browser_tests/fixtures/agentConversationFixture.ts and the new browser_tests/tests/agent/agentCrdtReconcileOverwrite.spec.ts: this fixture (and the wider main-only agent Playwright test scaffolding it depends on, e.g. agentTabSwitchCatchUp.spec.ts) does not exist on core/1.54 at all — introduced by main-only work, not by any of the PRs above. Dropped from this backport along with the Topbar.ts#openBlankTabAndReturn() helper added only for that spec, so the branch keeps compiling. The runtime fix ships with its Vitest regression coverage (graphMutations.test.ts, agentNodeMaterializer.test.ts); the e2e visual-proof spec is left for a follow-up once the agent Playwright fixture infrastructure itself is backported. Validation on this branch: - pnpm exec vitest run src/workbench/extensions/agent - pnpm exec eslint / pnpm exec oxfmt --check on touched files - pnpm typecheck
58ad7d7 to
4264b8c
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
re-reviewed rebased exact head 4264b8cb9a948bc12ce1fa00b2d3dc8ee251321c against live core/1.54 tip dfb42a403d3934f099fb15e3471ee7414e742c7f. The patch is unchanged semantically; focused unit tests pass (125 plus 3 expected failures), target typecheck, type-aware oxlint, and ESLint pass, and the force-push used an exact lease on the prior head.
|
The Generated by Claude Code |
|
exact-head local verification is green at |
…ve node/title/widget state (#18075) (#18759) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-org.slack.com/archives/C0BGH348Z0C/p1789514768597649)_ Manual backport of #18075 to `cloud/1.54`. The automated backport failed with merge conflicts: #18075 (comment) Cherry-picked from `96821ace03bc81d7a29965751a401fcf1818cae3` (`git cherry-pick -x -m 1`). ## Dependency check The bot flagged a possible stacking conflict with #18728, #18723 (both still open against `cloud/1.54`). Neither touches `graphMutations.ts`, `graphMutations.test.ts`, or `agentConversationFixture.ts` — they are not the cause of this conflict. The real causes (same underlying gap as the `core/1.54` backport, #18758): - **`graphMutations.ts`** — `cloud/1.54` predates #18191 ("keep the ghost placement flag out of the document"), which hoisted node flags into a local `flags` variable (`cloneNodeFlags`) that `lastSerialization` also started reusing. #18191 is merged to `main` but carries no `needs-backport` label and was never backported to `cloud/1.54`. Resolved by keeping `cloud/1.54`'s existing flags handling (`flags: cloneRecord(payload.flags)` / `lastSerialization: structuredClone(payload)`) and porting only #18075's actual change: `resolveNodeTitle(payload, incumbent)` for the title, plus the new `titleReconcileBaseline` field feeding it. - **`graphMutations.test.ts`** — pure insertion (no code on the `HEAD` side of the conflict), accepted the new test cases as-is. - **`browser_tests/fixtures/agentConversationFixture.ts`** and the new **`browser_tests/tests/agent/agentCrdtReconcileOverwrite.spec.ts`** — this Playwright fixture (and the wider main-only agent-test scaffolding it depends on, e.g. `agentTabSwitchCatchUp.spec.ts`) does not exist on `cloud/1.54` at all; it isn't introduced by either PR above. Dropped from this backport, along with the `Topbar.ts#openBlankTabAndReturn()` helper added only for that spec, so the branch keeps compiling. The runtime fix ships with its Vitest regression coverage (`graphMutations.test.ts`, `agentNodeMaterializer.test.ts`); the e2e visual-proof spec is left for a follow-up once the agent Playwright fixture infrastructure itself is backported. ## Validation - `pnpm exec vitest run src/workbench/extensions/agent/crdt` — 827 passed, 5 expected-fail (the intentional `it.fails` cases this PR introduces/carries). - `pnpm exec eslint` / `pnpm exec oxfmt --check` clean on all touched files. - `pnpm typecheck` clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01L4WMaCPdk7KSva7vwKfz19 --- _Generated by [Claude Code](https://claude.ai/code/session_01L4WMaCPdk7KSva7vwKfz19)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
|
correction: |
…18968) ## Summary Backports the agent conversation-replay test harness to `cloud/1.54` so the release line can replay the 15 recorded agent conversations it already carries. Test infrastructure only — no product file is touched. ## Changes - **What**: the harness family (`agentConversationFixture.ts`, `data/agent/agentConversation.ts`, `agentConversationExpectations.ts`, `agentHumanAddBlueprints.ts`, `data/agentReplayNodeDefs.ts`, `utils/agentReplayNodeContract.ts`), the two harness self-tests, and three black-box specs that consume it. Small additive hunks to `agentPanelFixture.ts`, `agentConversationHostDoc.ts`, `components/Topbar.ts`, `selectors.ts` and `types/globals.d.ts`. - **Dependencies**: none new. The 17 recorded-conversation JSON files landed earlier (#18585/#18586) and are byte-identical to `main`. ### Why Eight carriers each dropped their black-box proof spec one at a time, for the same reason: this harness family (from unbackported #16764 / #17537 / #17875 / #18164) does not exist on the 1.54 pair, so most agent CRDT fixes on this line ship with unit coverage only. #18758 recorded the intended remedy — "left for a follow-up once the agent Playwright fixture infrastructure itself is backported". Christian ruled on 2026-09-26 that 1.54 has another week and the test infra should be carried, which is this PR. `agentWidgetTypingReconcile.spec.ts` is the payoff worth naming: it is the black-box proof of the widget-typing garble fix (PM-1191/PM-1697), a P0 that is live in production on this line with no e2e coverage here until now. ## Review Focus Everything came from `main` byte-identical except the adaptations below, each commented at the site: | Adaptation | Why | |---|---| | `agentConversation.ts` drops the `messageDraft` slot of `zAgentWsEvent` | `zAgentMessageDraftEvent` arrived with #18551 (streaming reply), which is not on this branch. Re-add it if #18551 is carried. | | `mockWorkflowPersistence` reads `UserDataFullInfo` from `@/schemas/apiSchema` | `main` reads it from `@/platform/remote/comfyui/types`, which does not exist here. `browser_tests/fixtures/utils/savedWorkflowPersistence.ts` already carries exactly this adaptation. | | `reloadWithoutLocalWorkflow()` waits on `.p-blockui-mask` | `App.vue` on this branch renders PrimeVue `BlockUI`, not `data-testid="app-loading-overlay"`. `ComfyPage` already matches the mask this way. | | `HostDoc.apply()` takes `RecordedGraphOperation[]` | matches `main`; the applier is the only judge of a recorded op. | | `Topbar.tabs` + `TestIds.topbar.workflowTab` | `WorkflowTab.vue` already renders `data-testid="workflow-tab"` on this branch. | | four exports in `agentConversation.ts` are module-local | their only consumer on `main` is `scripts/agentConversationAssemble.ts`, which is not backported. | **Deliberately not carried**, and the one that matters for review: - `main`'s newer `agentFollowerHostSocket.ts`. This harness uses none of its added members, and it imports `@/platform/remote/comfyui/execution/types` — absent on this branch. That is the same missing-module shape that left `core/1.54` red for six hours after #18722, so the branch's existing socket is kept as-is. - The recording-authoring side (`scripts/agentConversation{Assemble,FromLangfuse,Record}.ts`, `tools/test-recorder/.../agentReplay.ts`, `agentConversationCapabilityMatrix`). A release branch needs to replay the recordings it has, not author new ones. Verified locally against this branch: `pnpm typecheck` and `pnpm typecheck:browser` clean, `pnpm knip` clean, `pnpm lint` 0 errors, the three carried vitest files 33/33 green, and `playwright --project=cloud` on `agentConversationReplay.spec.ts` 19/20 and `agentWidgetTypingReconcile.spec.ts` 1/1. Two `agentHumanAddTabSwitch` subgraph-blueprint cases and the one `@screenshot` case cannot be judged outside the CI container — both behave identically on a `main` checkout in the same local setup, so CI is the arbiter for those three.
Requested by Christian Byrne · Slack thread
Manual backport of #18075 to
core/1.54. The automated backport failed with merge conflicts: #18075 (comment)Cherry-picked from
96821ace03bc81d7a29965751a401fcf1818cae3(git cherry-pick -x -m 1).Dependency check
The bot flagged a possible stacking conflict with #18727, #18722, #18683, #17872 (all still open against
core/1.54). None of them touchgraphMutations.ts,graphMutations.test.ts, oragentConversationFixture.ts— they are not the cause of this conflict.The real causes:
graphMutations.ts—core/1.54predates fix(agent-crdt): keep the ghost placement flag out of the document #18191 ("keep the ghost placement flag out of the document"), which hoisted node flags into a localflagsvariable (cloneNodeFlags) thatlastSerializationalso started reusing. fix(agent-crdt): keep the ghost placement flag out of the document #18191 is merged tomainbut carries noneeds-backportlabel and was never backported tocore/1.54. Resolved by keepingcore/1.54's existing flags handling (flags: cloneRecord(payload.flags)/lastSerialization: structuredClone(payload)) and porting only test: repro agent-CRDT reconcile overwriting live node/title/widget state #18075's actual change:resolveNodeTitle(payload, incumbent)for the title, plus the newtitleReconcileBaselinefield feeding it.graphMutations.test.ts— pure insertion (no code on theHEADside of the conflict), accepted the new test cases as-is.browser_tests/fixtures/agentConversationFixture.tsand the newbrowser_tests/tests/agent/agentCrdtReconcileOverwrite.spec.ts— this Playwright fixture (and the wider main-only agent-test scaffolding it depends on, e.g.agentTabSwitchCatchUp.spec.ts) does not exist oncore/1.54at all; it isn't introduced by any of the PRs above. Dropped from this backport, along with theTopbar.ts#openBlankTabAndReturn()helper added only for that spec, so the branch keeps compiling. The runtime fix ships with its Vitest regression coverage (graphMutations.test.ts,agentNodeMaterializer.test.ts); the e2e visual-proof spec is left for a follow-up once the agent Playwright fixture infrastructure itself is backported.Validation
pnpm exec vitest run src/workbench/extensions/agent— 1 pre-existing, unrelated failure inAgentPanelRoot.test.ts(confirmed present oncore/1.54before this backport, untouched by this diff); everything else passes, including the 2 intentionalit.failscases this PR introduces.pnpm exec eslint/pnpm exec oxfmt --checkclean on all touched files.pnpm typecheckclean.🤖 Generated with Claude Code
https://claude.ai/code/session_01L4WMaCPdk7KSva7vwKfz19
Generated by Claude Code