Repository navigation
[backport core/1.54] fix(agent): stop remote setWidget ops clobbering an in-progress local edit (#18766) - #18810
Conversation
… edit (#18766) Typing into any text widget while the agent panel is open garbles — the cursor jumps and fast typing deletes letters (PM-1191, PM-1697, live on cloud at 5% exposure). Root cause: the incremental `setWidget` apply path writes remote doc-frame values into `widgetValueStore` with no in-progress-local-edit guard, so the host's echo of the user's *own* keystroke ops (whole-value, stale by however many keystrokes are in flight) deletes text under the cursor. The same unguarded path let an agent turn's `set_widget` overwrite a widget the user was mid-editing. - **What**: `graphMutations.ts` — the incremental `setWidget` commit now consults the same `skipStaleReconcile` local-dirty guard the full-reconcile path already uses: a remote value that differs from a locally-dirty widget is skipped until the document catches up to the local value; the write that finally matches clears the mark (its context-carrying no-op write), after which remote/agent writes land normally. The old escape hatch that let a single-widget op bypass the guard "regardless of value" is retired — that bypass *was* the garble. - **Pins flipped green honestly** (each red on parent, green here): - `graphMutations.test.ts` "preserves a locally newer widget value across a direct setWidget op" (`it.fails` → `it`), plus a new round-trip test covering skip-stale-echo → catch-up-clears → agent-write-lands. - `agentCrdtReconcileOverwrite.spec.ts` widget-overwrite case (`test.fail()` removed; now proves the agent frame really applied via the CRDT debug-panel outcomes counter *and* that the user's text survived). - `agentConversationReplay.spec.ts` "keeps prompt keystrokes when a doc frame resyncs the widget" (`test.fail()` removed — with this fix it passes deterministically, not by echo-latency luck; supersedes the marker-only removal in #18649). - Two unit tests that pinned the old escape-hatch contract are updated to the new one (a differing remote write holds; only a matching one resolves the mark). The trade: a widget stranded dirty by an unsuppressed structural replay now stays local-valued until a matching remote write, instead of being unstuck by the next agent op — the suppression brackets those tests also pin are what prevent that state. - The guard-clearing rule: convergence relies on the user's own minted keystroke ops echoing back; once the echo value equals the local value, the contexted write clears `locallyDirtyWidgets`. Verified in `graphMutations.test.ts` round-trip test. - Open test PRs [#18089](#18089) and [#18705](#18705) both flip to "expected to fail, but passed" when run against this branch (verified locally; #18705's attachment shows the stale echo arriving and being skipped) — their `test.fail()` markers should drop on rebase after this merges. - Freeze note: this is the authorized P0 exception to the informal remote-ops freeze. `graphMutations.ts` is deleted by the #18700 refactor; the property this restores — *a local edit in progress is never overwritten by a remote or reconciled write* — must be re-asserted on the new graph-API apply path (own-actor echo skip at follower entry + a provenance-aware guard at the widget setter). The three flipped black-box/unit pins are the acceptance tests for that re-assertion; they survive the refactor even though this implementation does not. Evidence: reported by four users over ten days (Memie 09-15 w/ CRDT debug report `F0C22E6U70E`, Denys 09-22, Luke 09-24, Doug 09-24 Silverside demo).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1954 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-25T09:29:25.258Z",
"gitSha": "ecf6b15744c61fdfbea1a576c5538a5f36a6851f",
"branch": "backport-18766-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2049.1310000000453,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.050000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.34100000000007,
"heapDeltaBytes": 3768392,
"heapUsedBytes": 74142280,
"domNodes": -283,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.891,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2038.456999999994,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.888000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.831,
"heapDeltaBytes": 1812640,
"heapUsedBytes": 71529368,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 9.052000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2092.609999999979,
"styleRecalcs": 78,
"styleRecalcDurationMs": 37.268,
"layouts": 14,
"layoutDurationMs": 4.726,
"taskDurationMs": 1051.205,
"heapDeltaBytes": -6670368,
"heapUsedBytes": 63423788,
"domNodes": -282,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 174.54600000000002,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1808.1870000000322,
"styleRecalcs": 75,
"styleRecalcDurationMs": 28.915000000000003,
"layouts": 14,
"layoutDurationMs": 3.9430000000000005,
"taskDurationMs": 810.799,
"heapDeltaBytes": 24201264,
"heapUsedBytes": 88742108,
"domNodes": 38,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 149.66899999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1684.597999999994,
"styleRecalcs": 29,
"styleRecalcDurationMs": 14.355999999999998,
"layouts": 6,
"layoutDurationMs": 1.274,
"taskDurationMs": 351.75800000000004,
"heapDeltaBytes": 3779436,
"heapUsedBytes": 67436244,
"domNodes": 74,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 11.604,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1729.761999999937,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.75,
"layouts": 6,
"layoutDurationMs": 1.3840000000000001,
"taskDurationMs": 357.57,
"heapDeltaBytes": 4285332,
"heapUsedBytes": 74747176,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.451999999999996,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 659.199000000001,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.884,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.774,
"heapDeltaBytes": -8207436,
"heapUsedBytes": 62963192,
"domNodes": 18,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 157.79500000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 684.6699999999828,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.4159999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.15000000000003,
"heapDeltaBytes": -7887240,
"heapUsedBytes": 62946460,
"domNodes": 16,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 155.261,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2067.651000000012,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.750000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 637.836,
"heapDeltaBytes": 9502732,
"heapUsedBytes": 85911588,
"domNodes": -271,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 38.083000000000006,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2037.6909999999953,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.133000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 607.9069999999999,
"heapDeltaBytes": 10999808,
"heapUsedBytes": 86971428,
"domNodes": -273,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 34.556000000000004,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2325.039000000004,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.417000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1722.7859999999998,
"heapDeltaBytes": 9498240,
"heapUsedBytes": 87015952,
"domNodes": -273,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 858.8430000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2268.326000000002,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1638.5899999999997,
"heapDeltaBytes": 8183756,
"heapUsedBytes": 85214308,
"domNodes": -279,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 792.569,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3605.1049999999805,
"styleRecalcs": 63,
"styleRecalcDurationMs": 14.445000000000004,
"layouts": 60,
"layoutDurationMs": 13.619,
"taskDurationMs": 1798.9250000000002,
"heapDeltaBytes": -7192524,
"heapUsedBytes": 71271924,
"domNodes": -289,
"jsHeapTotalBytes": 2519040,
"scriptDurationMs": 776.19,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3538.877999999954,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.784000000000002,
"layouts": 60,
"layoutDurationMs": 13.227999999999998,
"taskDurationMs": 1721.523,
"heapDeltaBytes": 10076908,
"heapUsedBytes": 77213068,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 793.3639999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3163.43599999999,
"styleRecalcs": 42,
"styleRecalcDurationMs": 7.793999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2058.095,
"heapDeltaBytes": 11575112,
"heapUsedBytes": 92374224,
"domNodes": -286,
"jsHeapTotalBytes": 577536,
"scriptDurationMs": 1008.534,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3087.5449999999773,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.351999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1890.6490000000001,
"heapDeltaBytes": 26196036,
"heapUsedBytes": 93830300,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 949.1329999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2069.927000000007,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.0779999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 629.8770000000002,
"heapDeltaBytes": 8874832,
"heapUsedBytes": 86580640,
"domNodes": -281,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 36.922000000000004,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2004.3470000000525,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.5140000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.6339999999999,
"heapDeltaBytes": 21771420,
"heapUsedBytes": 88267352,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.305,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 589.1480000000229,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.569999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.76099999999997,
"heapDeltaBytes": 14689904,
"heapUsedBytes": 88077048,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 142.893,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.1819999999898,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.502000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.478,
"heapDeltaBytes": 14701292,
"heapUsedBytes": 87912176,
"domNodes": 16,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 141.824,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2015.2219999999943,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.703000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.293,
"heapDeltaBytes": 5090644,
"heapUsedBytes": 78394280,
"domNodes": -299,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.392,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2023.7840000000347,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.784,
"heapDeltaBytes": -9960680,
"heapUsedBytes": 62667444,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.929000000000002,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.5790000000293,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.032999999999998,
"layouts": 18,
"layoutDurationMs": 5.282,
"taskDurationMs": 808.8729999999999,
"heapDeltaBytes": -1769140,
"heapUsedBytes": 71738804,
"domNodes": -296,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 106.316,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1717.4830000000156,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.435000000000002,
"layouts": 18,
"layoutDurationMs": 4.766,
"taskDurationMs": 812.3249999999999,
"heapDeltaBytes": -6191028,
"heapUsedBytes": 66921948,
"domNodes": -295,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 105.424,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.5029999999952,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.489000000000008,
"layouts": 15,
"layoutDurationMs": 14.609,
"taskDurationMs": 936.6929999999998,
"heapDeltaBytes": 22038936,
"heapUsedBytes": 106224912,
"domNodes": 13751,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 31.441999999999997,
"eventListeners": 2387,
"totalBlockingTimeMs": 128,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8400.597000000005,
"styleRecalcs": 249,
"styleRecalcDurationMs": 41.941,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5828.559,
"heapDeltaBytes": -8099868,
"heapUsedBytes": 68467296,
"domNodes": -280,
"jsHeapTotalBytes": 1470464,
"scriptDurationMs": 2645.748,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8314.944000000083,
"styleRecalcs": 245,
"styleRecalcDurationMs": 38.818,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5799.519,
"heapDeltaBytes": 14202856,
"heapUsedBytes": 90764960,
"domNodes": -274,
"jsHeapTotalBytes": -1187840,
"scriptDurationMs": 2671.617,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18284.29699999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17682.347999999998,
"heapDeltaBytes": -46182264,
"heapUsedBytes": 193801536,
"domNodes": -8068,
"jsHeapTotalBytes": -17518592,
"scriptDurationMs": 309.42199999999997,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18548.890999999912,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17754.385,
"heapDeltaBytes": -58412212,
"heapUsedBytes": 179293592,
"domNodes": -8068,
"jsHeapTotalBytes": -12443648,
"scriptDurationMs": 319.458,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22884.20100000002,
"styleRecalcs": 177,
"styleRecalcDurationMs": 22.104000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22619.695,
"heapDeltaBytes": -59755124,
"heapUsedBytes": 169193908,
"domNodes": -8068,
"jsHeapTotalBytes": -19615744,
"scriptDurationMs": 949.3430000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 108,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22658.064000000082,
"styleRecalcs": 177,
"styleRecalcDurationMs": 22.461999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22253.784,
"heapDeltaBytes": -34697620,
"heapUsedBytes": 183684364,
"domNodes": -8068,
"jsHeapTotalBytes": -11878400,
"scriptDurationMs": 994.856,
"eventListeners": -14929,
"totalBlockingTimeMs": 124,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6612.2300000000105,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.37300000000002,
"layouts": 20,
"layoutDurationMs": 24.67599999999999,
"taskDurationMs": 6541.893,
"heapDeltaBytes": -55796448,
"heapUsedBytes": 176919112,
"domNodes": -8068,
"jsHeapTotalBytes": 4792320,
"scriptDurationMs": 119.911,
"eventListeners": -14927,
"totalBlockingTimeMs": 522,
"frameDurationMs": 17.773333333333298,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6489.296000000081,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.567,
"layouts": 20,
"layoutDurationMs": 23.938000000000002,
"taskDurationMs": 6409.814,
"heapDeltaBytes": -55520864,
"heapUsedBytes": 183853968,
"domNodes": -8068,
"jsHeapTotalBytes": 12972032,
"scriptDurationMs": 122.96000000000001,
"eventListeners": -14931,
"totalBlockingTimeMs": 442,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9299.23500000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8995.036999999998,
"heapDeltaBytes": 17781108,
"heapUsedBytes": 186839424,
"domNodes": 0,
"jsHeapTotalBytes": -7602176,
"scriptDurationMs": 178.23,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9188.00299999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8881.644999999999,
"heapDeltaBytes": -3728964,
"heapUsedBytes": 176654720,
"domNodes": 0,
"jsHeapTotalBytes": -25427968,
"scriptDurationMs": 187.39700000000005,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 475.0410000000329,
"styleRecalcs": 17,
"styleRecalcDurationMs": 21.497999999999998,
"layouts": 3,
"layoutDurationMs": 1.481,
"taskDurationMs": 113.82900000000001,
"heapDeltaBytes": 4926976,
"heapUsedBytes": 73839216,
"domNodes": 143,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.266000000000002,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 100.54999999999836,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.541999999999998,
"layouts": 2,
"layoutDurationMs": 1.15,
"taskDurationMs": 67.435,
"heapDeltaBytes": 2937052,
"heapUsedBytes": 71702256,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 3.705,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #18810 +/- ##
==========================================
Coverage 83.77% 83.77%
==========================================
Files 2104 2104
Lines 124691 124692 +1
Branches 33436 33437 +1
==========================================
+ Hits 104455 104462 +7
+ Misses 20057 20051 -6
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Held, not stalled —
That spec arrived on This carrier changes two files, neither under Unblocking condition: either backport The same two fixes are already landed on |
…ui/types (#18823) ## Summary The #18722 backport carrier (`68fc0f639e`) landed `browser_tests/tests/agent/agentDuplicateWorkflowNameBinding.spec.ts` without `src/platform/remote/comfyui/types.ts`. That module exists on `main` (added in #17789) but not on `core/1.54`, so every PR against `core/1.54` since has failed the required `lint-and-format` check identically: ``` browser_tests/tests/agent/agentDuplicateWorkflowNameBinding.spec.ts(10,39): error TS2307: Cannot find module '@/platform/remote/comfyui/types' ``` (`typecheck-aux` TS2307 + `repo-checks` knip unresolved import → `lint-and-format` gate red.) This backports **only the `UserDataFullInfo` type the spec imports**. The rest of `main`'s module has no consumer on this branch and would fail knip's unused-export check. `cloud/1.54` does **not** need this fix: its copy of the spec was adapted during cherry-pick to import `UserDataFullInfo` from `@/schemas/apiSchema`, which still exists there; `typecheck:browser` and `knip` are clean on `cloud/1.54` as-is, and adding this file there fails knip (unused file). ## Verification - Red on parent: `pnpm typecheck:browser` on `core/1.54` fails with the TS2307 above; green with this commit. - `pnpm typecheck`, `pnpm typecheck:browser`, `pnpm knip:no-cache`, eslint + oxfmt on the new file: all clean locally. Unblocks #18810 and #18811 (P0 backport carriers). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
christian-byrne
left a comment
There was a problem hiding this comment.
Backport-grant review (program rows bp-1/corefix-1; authenticated as the author, so COMMENT not APPROVE — per program/release-backport-authority.md, Christian's September 16 grant for core/1.54 carriers).
Reviewed head: 4447714c4d2ac6345c8f5f8ea79bc7058c146e89 (base refreshed onto the #18823 branch repair).
Diff review vs source #18766: graphMutations.ts production diff byte-identical to source; graphMutations.test.ts adapted exactly as the PR body documents; the three source browser specs are modify/delete conflicts absent from the 1.54 train and were correctly not introduced. Marker evidence (skipStaleReconcile 4→5) and red-on-parent proof are in the carrier body.
Checks at this head: lint-and-format ✅, test ✅, e2e-status ✅; scripts/check-merge-ready.sh --target-branch core/1.54 reports MERGE READY (no adverse status). P0: prod keystroke-clobber echo bug, QA-unblocking priority.
…or node reference (#18693) (#18836) Backport of #18693 (`facbca7658dd361ff5f5edaf5ff5404d582e0a64`, merged to `main` 2026-09-25T07:11Z) to `core/1.54`. Companion to the `cloud/1.54` carrier #18835. ## Why #18693 fixes the agent editing a different workflow than the one the user is looking at — writes land on a document nobody is watching. `core/1.54` feeds the `comfyui-frontend-package` PyPI train for Desktop/local. ## Cherry-pick adaptations (context only, no behavior change) Same class of drift as the cloud carrier (see #18835), plus four core-specific ones: - `agentNewChatTargetWorkflow.spec.ts` (modify/delete): this spec does not exist on the `core/1.54` train; per the #18810 precedent it was **not introduced**. - `RunNoticeBanner.vue`: core still has the pre-#18052 palette (`bg-primary-background`, `font-medium`; the core backport of #18052 is still open as #18793). #18693's `context`/`showTarget` logic applied onto core's palette classes verbatim; no styling change smuggled in. - Test `retains an explicitly chosen target across panel reopen and New Chat`: core's variant of this test had drifted from main's, so #18693's rewrite hunk missed it. Applied the source's post-change version by hand (`retains an explicitly chosen target across a plain panel reopen`) — New Chat now resumes following, which is exactly the behavior #18693 ships. - Three new tests assert `selection: { node_ids, workflow_id }` in the send payload; `core/1.54` predates #17327 (selection scoping), so its payload has no nested `workflow_id`. Matchers narrowed to `{ node_ids }` on this branch only; top-level `workflow_id` assertions (the target-binding behavior under test) are untouched. - Did not introduce the two `agentGraphActivityStore` tests riding as pre-image context in one hunk — that store is not on this train. ## Local gates on this head (per the #18722 lesson) - `pnpm typecheck` ✅ - `pnpm typecheck:browser` ✅ - `pnpm knip:no-cache` ✅ - `pnpm vitest run` on the five touched suites: 302/302 ✅ ## Red on parent With production files reverted to the parent (`9439d31a3e`) and the new tests kept, `AgentPanelRoot.test.ts -t 'follows the visible workflow'` fails; green with the fix. Note: `Vercel – billing-web-test` fails branch-wide on every `core/1.54` PR (recorded exception in the program's backport policy, sunset 2026-10-09); it is unrelated to this diff. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com>
Backport of #18766 to
core/1.54. Original authorship and commit message preserved (cherry-pick of the squashed merge commit, not a re-authored patch).Why
Typing into any text widget while the agent panel is open garbles the text: the host echoes the user's own
set_widgetops back as whole-value doc frames that are stale by however many keystrokes are in flight, and replaying one deletes text under the cursor. Reported on prodcloud.comfy.orgby four users over ten days and hit the Silverside customer demo.core/1.54is the train published to PyPI ascomfyui-frontend-package(latest:1.54.7), i.e. the Local/Desktop agent surface.The automatic backport workflow ran on #18766 and failed with cherry-pick conflicts on all four targets, so this carrier is a hand cherry-pick.
Conflict resolution
browser_tests/tests/agent/*.spec.tsfiles in the source PR are modify/delete conflicts here: none of them exists on the 1.54 train. Kept the branch's state, so no spec was deleted and none was newly introduced (verified withgit diff --diff-filter=D). The behaviour is pinned on this branch by the unit tests below instead.graphMutations.test.ts— content conflict resolved by taking the incoming side (the source PR's three unit tests; no same-named test exists on this branch).No package, lockfile, core-type or business-logic conflict arose; nothing was resolved creatively.
Marker evidence
skipStaleReconcileoccurrences insrc/workbench/extensions/agent/crdt/graphMutations.ts: 4 before → 5 after on this branch (5 onmain). The one added call site — the incrementalsetWidgetcase consulting the local-dirty guard — is the fix.Verification
pnpm test:unit src/workbench/extensions/agent/crdt/graphMutations.test.tsgreen on this branch (NODE_OPTIONS=--no-experimental-webstorage). Proved red-on-parent honestly rather than trusting a clean pick: reverting only thegraphMutations.tshunk and rerunning turns 4 tests red, including the PM-1191/PM-1697 keystroke-echo round trip.Carried by the in-app-agent program row
bp-1.