Repository navigation
fix(e2e): import UserDataFullInfo from apiSchema on core/1.54 - #18807
christian-byrne wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
🎭 Playwright: ✅ 1952 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-25T07:27:03.850Z",
"gitSha": "56f8d949b958668715c599901589d00dccea7663",
"branch": "fix/core-1-54-userdatafullinfo-import",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2024.041000000011,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.221000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.697,
"heapDeltaBytes": 4820952,
"heapUsedBytes": 75022696,
"domNodes": -282,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.8420000000000005,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1991.3460000000214,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.393,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 310.683,
"heapDeltaBytes": 859608,
"heapUsedBytes": 65483500,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 6.789999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1822.892999999965,
"styleRecalcs": 70,
"styleRecalcDurationMs": 20.113,
"layouts": 14,
"layoutDurationMs": 3.662,
"taskDurationMs": 709.74,
"heapDeltaBytes": -7709588,
"heapUsedBytes": 62346312,
"domNodes": -284,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 96.121,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1710.9800000000064,
"styleRecalcs": 73,
"styleRecalcDurationMs": 16.095,
"layouts": 14,
"layoutDurationMs": 2.492,
"taskDurationMs": 577.546,
"heapDeltaBytes": -9521336,
"heapUsedBytes": 60234508,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 91.496,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1669.0849999999955,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.784,
"layouts": 6,
"layoutDurationMs": 1.1060000000000003,
"taskDurationMs": 249.31300000000002,
"heapDeltaBytes": 4651848,
"heapUsedBytes": 75077584,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 8.074000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1658.4980000000087,
"styleRecalcs": 31,
"styleRecalcDurationMs": 9.283,
"layouts": 6,
"layoutDurationMs": 0.852,
"taskDurationMs": 232.84699999999998,
"heapDeltaBytes": 4606732,
"heapUsedBytes": 74864816,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7.302,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 536.9269999999915,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.153,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 333.898,
"heapDeltaBytes": -7888720,
"heapUsedBytes": 62736432,
"domNodes": 22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 113.86399999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 509.92500000000973,
"styleRecalcs": 13,
"styleRecalcDurationMs": 4.817000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 287.69800000000004,
"heapDeltaBytes": 17750020,
"heapUsedBytes": 87973896,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 95.574,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2038.3310000000279,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.919999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.8,
"heapDeltaBytes": 10598032,
"heapUsedBytes": 86631748,
"domNodes": -270,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 25.318,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2008.3789999999908,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.099999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.614,
"heapDeltaBytes": 7963060,
"heapUsedBytes": 84255120,
"domNodes": -264,
"jsHeapTotalBytes": -888832,
"scriptDurationMs": 24.574000000000005,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2081.1860000000024,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.042000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1022.2319999999999,
"heapDeltaBytes": 18597916,
"heapUsedBytes": 85053364,
"domNodes": -268,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 482.79400000000004,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2136.435000000006,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.165,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1095.243,
"heapDeltaBytes": 3348596,
"heapUsedBytes": 80050116,
"domNodes": -276,
"jsHeapTotalBytes": -1187840,
"scriptDurationMs": 492.0709999999999,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3122.993000000008,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.595,
"layouts": 60,
"layoutDurationMs": 11.219,
"taskDurationMs": 1220.477,
"heapDeltaBytes": -8892176,
"heapUsedBytes": 69406264,
"domNodes": -286,
"jsHeapTotalBytes": 3043328,
"scriptDurationMs": 499.964,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3058.6979999999926,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.117,
"layouts": 60,
"layoutDurationMs": 9.828999999999999,
"taskDurationMs": 1118.634,
"heapDeltaBytes": 8518880,
"heapUsedBytes": 76545096,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 481.049,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2157.662000000016,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.148,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1283.2259999999999,
"heapDeltaBytes": 15460964,
"heapUsedBytes": 83519456,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 615.0070000000001,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2216.981999999973,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.8519999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1328.0470000000003,
"heapDeltaBytes": -9136808,
"heapUsedBytes": 71995096,
"domNodes": -246,
"jsHeapTotalBytes": 159744,
"scriptDurationMs": 616.702,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2016.871999999978,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.504999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.061,
"heapDeltaBytes": 6084628,
"heapUsedBytes": 84132272,
"domNodes": -277,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 29.953,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2019.3719999999757,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.094000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.486,
"heapDeltaBytes": 4242496,
"heapUsedBytes": 81352264,
"domNodes": -278,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 25.881999999999994,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 413.5180000000105,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.683,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 268.258,
"heapDeltaBytes": 13888604,
"heapUsedBytes": 86377212,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 84.135,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 412.8450000000612,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.779,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 269.96999999999997,
"heapDeltaBytes": 14999520,
"heapUsedBytes": 87985084,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 85.89899999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2010.4670000000056,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.722999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 360.321,
"heapDeltaBytes": -9549952,
"heapUsedBytes": 63291408,
"domNodes": -289,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.854999999999999,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1989.6019999999908,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.055000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.456,
"heapDeltaBytes": -11856848,
"heapUsedBytes": 60034212,
"domNodes": -295,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 5.605,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.2860000000146,
"styleRecalcs": 79,
"styleRecalcDurationMs": 16.975,
"layouts": 18,
"layoutDurationMs": 2.8330000000000006,
"taskDurationMs": 551.813,
"heapDeltaBytes": -14513900,
"heapUsedBytes": 58405824,
"domNodes": -294,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 62.888,
"eventListeners": -208,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1676.4410000000112,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.746999999999996,
"layouts": 18,
"layoutDurationMs": 2.543,
"taskDurationMs": 541.4570000000001,
"heapDeltaBytes": -9293880,
"heapUsedBytes": 63175824,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 61.586999999999996,
"eventListeners": -238,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 832.6089999999908,
"styleRecalcs": 20,
"styleRecalcDurationMs": 22.186999999999998,
"layouts": 16,
"layoutDurationMs": 9.668,
"taskDurationMs": 611.1869999999999,
"heapDeltaBytes": 21877084,
"heapUsedBytes": 105920004,
"domNodes": 13751,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 19.689999999999998,
"eventListeners": 2385,
"totalBlockingTimeMs": 97,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8109.655999999973,
"styleRecalcs": 249,
"styleRecalcDurationMs": 27.514999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3928.967,
"heapDeltaBytes": 10481944,
"heapUsedBytes": 87061472,
"domNodes": -268,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 1770.294,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8149.391000000037,
"styleRecalcs": 249,
"styleRecalcDurationMs": 24.645999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3674.3390000000004,
"heapDeltaBytes": 13389988,
"heapUsedBytes": 89398984,
"domNodes": -266,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 1609.0549999999998,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 9853.801999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8982.474,
"heapDeltaBytes": -34287544,
"heapUsedBytes": 184256308,
"domNodes": -8068,
"jsHeapTotalBytes": -4415488,
"scriptDurationMs": 125.533,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 9998.508000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8965.673,
"heapDeltaBytes": -53237628,
"heapUsedBytes": 185104512,
"domNodes": -8068,
"jsHeapTotalBytes": -11972608,
"scriptDurationMs": 120.169,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13554.270000000031,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.418999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13047.215999999999,
"heapDeltaBytes": -34447788,
"heapUsedBytes": 183419396,
"domNodes": -8068,
"jsHeapTotalBytes": -14761984,
"scriptDurationMs": 682.9150000000001,
"eventListeners": -14931,
"totalBlockingTimeMs": 40,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 12595.99700000001,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.868999999999991,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11896.143000000002,
"heapDeltaBytes": -28965300,
"heapUsedBytes": 188391508,
"domNodes": -8068,
"jsHeapTotalBytes": -10829824,
"scriptDurationMs": 592.163,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 3782.4870000000033,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.31100000000001,
"layouts": 20,
"layoutDurationMs": 31.949999999999992,
"taskDurationMs": 3638.8250000000003,
"heapDeltaBytes": -40677052,
"heapUsedBytes": 177955768,
"domNodes": -8068,
"jsHeapTotalBytes": 11575296,
"scriptDurationMs": 54.550000000000004,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 3580.2189999999428,
"styleRecalcs": 20,
"styleRecalcDurationMs": 52.32000000000001,
"layouts": 20,
"layoutDurationMs": 19.130999999999997,
"taskDurationMs": 3435.997,
"heapDeltaBytes": -31773788,
"heapUsedBytes": 186275584,
"domNodes": -8068,
"jsHeapTotalBytes": 15990784,
"scriptDurationMs": 53.339,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5679.9189999999835,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5244.629,
"heapDeltaBytes": 749600,
"heapUsedBytes": 178342436,
"domNodes": 0,
"jsHeapTotalBytes": -24903680,
"scriptDurationMs": 80.89299999999999,
"eventListeners": -6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5753.638000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5343.094000000001,
"heapDeltaBytes": 11346308,
"heapUsedBytes": 177861552,
"domNodes": 0,
"jsHeapTotalBytes": -13107200,
"scriptDurationMs": 74.02300000000001,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 441.7500000000132,
"styleRecalcs": 19,
"styleRecalcDurationMs": 17.537,
"layouts": 5,
"layoutDurationMs": 2.029,
"taskDurationMs": 95.48899999999999,
"heapDeltaBytes": 5071012,
"heapUsedBytes": 73603912,
"domNodes": 149,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 10.041000000000002,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 80.88499999996657,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.944,
"layouts": 2,
"layoutDurationMs": 0.8960000000000001,
"taskDurationMs": 44.945,
"heapDeltaBytes": 2959504,
"heapUsedBytes": 71110384,
"domNodes": 123,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 3.3099999999999987,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #18807 +/- ##
=============================================
- Coverage 83.77% 83.77% -0.01%
=============================================
Files 2104 2104
Lines 124691 124691
Branches 33436 31573 -1863
=============================================
- Hits 104458 104456 -2
- Misses 20054 20056 +2
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Closing as superseded by #18823. Same break, two competing fixes. Both this PR and #18823 address the Verified before closing, at the current
Merging this instead would now actively re-break the branch. #18823 added Keeping the import byte-identical to Closed by the |
core/1.54is red for every open backport, not just one. Three checks fail on all of them and all three have the same single cause:typecheck-aux— the TS2307 aboverepo-checks— knipUnresolved imports (1), same file and linelint-and-format— required check, aggregatestypecheck-auxsrc/platform/remote/comfyui/types.tsexists onmainbut not oncore/1.54. The spec arrived here in68fc0f639("[backport core/1.54] Fix duplicate-name stale workflow binding resolution", #18722) carrying the main-branch import path, without the module behind it.The four sibling files on this branch all import the same type from
@/schemas/apiSchema, which exports it atapiSchema.ts:501:browser_tests/fixtures/agentWorkflowSelectionFixture.ts:3browser_tests/tests/agent/agentCanvasLagsToolCallCompletion.spec.ts:8browser_tests/tests/agent/agentPanelMocks.ts:13browser_tests/tests/agent/agentStaleWorkflowTabBinding.spec.ts:10This changes the one outlier to match them. One line, type-only, no runtime effect.
cloud/1.54already had this corrected ina9d314220("[backport cloud/1.54] Agent fix gap sweep", #18257), so this brings core into line with cloud rather than inventing anything.Impact
Seven backports are stranded behind this on the 1.54 branches: #18793, #18794, #18783, #18782, #18728, #18727, #17872. They should go green once their heads are updated from the fixed base.
Vercel – billing-web-testalso fails on these PRs. It is a separate pre-existing issue and is not a required check, so it does not block.