Repository navigation
[backport core/1.54] feat(agent): follow visible workflow until send or node reference (#18693) - #18836
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1954 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-25T11:53:44.873Z",
"gitSha": "0d6b9ce50470f70dec8e93f0fac2ff128877389e",
"branch": "bp4/backport-18693-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2073.3469999999556,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.597000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 609.7280000000001,
"heapDeltaBytes": 1484592,
"heapUsedBytes": 70949600,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.302999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2048.170999999968,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.274,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.62899999999996,
"heapDeltaBytes": 5140204,
"heapUsedBytes": 76313076,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.321000000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2164.5189999999843,
"styleRecalcs": 80,
"styleRecalcDurationMs": 36.242999999999995,
"layouts": 14,
"layoutDurationMs": 4.279,
"taskDurationMs": 1122.2060000000001,
"heapDeltaBytes": 4991704,
"heapUsedBytes": 75851212,
"domNodes": -282,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 189.434,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1834.6380000000408,
"styleRecalcs": 75,
"styleRecalcDurationMs": 29.555999999999997,
"layouts": 14,
"layoutDurationMs": 3.9110000000000005,
"taskDurationMs": 886.6610000000001,
"heapDeltaBytes": 13185056,
"heapUsedBytes": 83900696,
"domNodes": -281,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 160.07399999999998,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.945999999989,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.031,
"layouts": 6,
"layoutDurationMs": 0.9660000000000001,
"taskDurationMs": 401.964,
"heapDeltaBytes": 4652276,
"heapUsedBytes": 75473952,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.752999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1668.1449999999813,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.934999999999997,
"layouts": 6,
"layoutDurationMs": 1.102,
"taskDurationMs": 365.55199999999996,
"heapDeltaBytes": 4262064,
"heapUsedBytes": 74720256,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.434000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 741.6079999999852,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.884999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.07,
"heapDeltaBytes": -7542696,
"heapUsedBytes": 63290216,
"domNodes": 14,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 177.505,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 634.6090000000117,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.557999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.87799999999993,
"heapDeltaBytes": 18030444,
"heapUsedBytes": 88302460,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 158.327,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2050.342999999998,
"styleRecalcs": 4,
"styleRecalcDurationMs": 6.297000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 775.615,
"heapDeltaBytes": 11029836,
"heapUsedBytes": 87000032,
"domNodes": -274,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 44.309000000000005,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2044.4740000000365,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.810999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 707.819,
"heapDeltaBytes": 10907804,
"heapUsedBytes": 87345252,
"domNodes": -274,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 39.594,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2890.3359999999907,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.098999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1827.0720000000003,
"heapDeltaBytes": 26452972,
"heapUsedBytes": 92494296,
"domNodes": -275,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 880.021,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2364.163000000076,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.149000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1712.358,
"heapDeltaBytes": -10237216,
"heapUsedBytes": 67307296,
"domNodes": -280,
"jsHeapTotalBytes": 946176,
"scriptDurationMs": 849.38,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3802.144999999996,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.154000000000003,
"layouts": 60,
"layoutDurationMs": 12.328,
"taskDurationMs": 1851.031,
"heapDeltaBytes": 8184760,
"heapUsedBytes": 76060320,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 818.13,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3654.3459999999186,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.891,
"layouts": 60,
"layoutDurationMs": 11.642000000000001,
"taskDurationMs": 1748.0089999999998,
"heapDeltaBytes": 8197396,
"heapUsedBytes": 76202288,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 786.4870000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3333.3560000000375,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.46,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2199.497,
"heapDeltaBytes": 8757836,
"heapUsedBytes": 89426656,
"domNodes": -286,
"jsHeapTotalBytes": 577536,
"scriptDurationMs": 1087.3970000000002,
"eventListeners": 18,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3163.640999999984,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.106,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2071.781,
"heapDeltaBytes": 26111192,
"heapUsedBytes": 93384592,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1047.383,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2011.7520000000013,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.7180000000000009,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 590.933,
"heapDeltaBytes": 21783480,
"heapUsedBytes": 88082672,
"domNodes": -276,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.19800000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2010.8789999999317,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.9010000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.1650000000001,
"heapDeltaBytes": 21975712,
"heapUsedBytes": 88627428,
"domNodes": -273,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 38.897,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 656.0960000000478,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.344,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.11999999999995,
"heapDeltaBytes": 14272412,
"heapUsedBytes": 86798156,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 148.445,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 628.8110000000415,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.899000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.97599999999994,
"heapDeltaBytes": 15056208,
"heapUsedBytes": 88204240,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 144.231,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2018.7839999999824,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.469,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 626.89,
"heapDeltaBytes": -13972320,
"heapUsedBytes": 59337120,
"domNodes": -298,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 13.572999999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.9590000000144,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.809,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 529.6959999999999,
"heapDeltaBytes": -9319752,
"heapUsedBytes": 63764044,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 9.347000000000001,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1770.559999999989,
"styleRecalcs": 78,
"styleRecalcDurationMs": 30.376,
"layouts": 18,
"layoutDurationMs": 5.143,
"taskDurationMs": 937.114,
"heapDeltaBytes": 5277828,
"heapUsedBytes": 78362332,
"domNodes": -296,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 125.114,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1740.5009999999947,
"styleRecalcs": 78,
"styleRecalcDurationMs": 28.769999999999996,
"layouts": 18,
"layoutDurationMs": 5.04,
"taskDurationMs": 816.4200000000002,
"heapDeltaBytes": -5101304,
"heapUsedBytes": 60906656,
"domNodes": -299,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 110.04,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.7970000000114,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.89,
"layouts": 15,
"layoutDurationMs": 15.344,
"taskDurationMs": 939.7599999999999,
"heapDeltaBytes": 20812172,
"heapUsedBytes": 104144076,
"domNodes": 13751,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 29.227999999999998,
"eventListeners": 2387,
"totalBlockingTimeMs": 144,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 9174.265999999989,
"styleRecalcs": 247,
"styleRecalcDurationMs": 38.065000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6303.967,
"heapDeltaBytes": 13440324,
"heapUsedBytes": 90013124,
"domNodes": -271,
"jsHeapTotalBytes": -172032,
"scriptDurationMs": 2813.815,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8988.923999999997,
"styleRecalcs": 248,
"styleRecalcDurationMs": 37.759,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6130.865,
"heapDeltaBytes": 8425060,
"heapUsedBytes": 84916488,
"domNodes": -273,
"jsHeapTotalBytes": -696320,
"scriptDurationMs": 2767.445,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17867.659000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17170.614,
"heapDeltaBytes": -49106100,
"heapUsedBytes": 183458880,
"domNodes": -8068,
"jsHeapTotalBytes": -10334208,
"scriptDurationMs": 295.00100000000003,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17606.435999999918,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16900.638,
"heapDeltaBytes": -55334940,
"heapUsedBytes": 181668496,
"domNodes": -8068,
"jsHeapTotalBytes": -14331904,
"scriptDurationMs": 286.08500000000004,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21451.509000000045,
"styleRecalcs": 169,
"styleRecalcDurationMs": 21.688999999999957,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21224.536,
"heapDeltaBytes": -40005896,
"heapUsedBytes": 183357628,
"domNodes": -8068,
"jsHeapTotalBytes": -16789504,
"scriptDurationMs": 951.0459999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 53,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20701.68799999999,
"styleRecalcs": 165,
"styleRecalcDurationMs": 19.459999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20375.755,
"heapDeltaBytes": -47587608,
"heapUsedBytes": 182715000,
"domNodes": -8068,
"jsHeapTotalBytes": -20885504,
"scriptDurationMs": 949.785,
"eventListeners": -14929,
"totalBlockingTimeMs": 126,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6127.489000000025,
"styleRecalcs": 20,
"styleRecalcDurationMs": 85.57399999999998,
"layouts": 20,
"layoutDurationMs": 23.015999999999995,
"taskDurationMs": 6010.817999999999,
"heapDeltaBytes": -55033228,
"heapUsedBytes": 176386580,
"domNodes": -8068,
"jsHeapTotalBytes": 5066752,
"scriptDurationMs": 108.009,
"eventListeners": -14929,
"totalBlockingTimeMs": 390,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6215.843999999947,
"styleRecalcs": 20,
"styleRecalcDurationMs": 99.87399999999997,
"layouts": 20,
"layoutDurationMs": 29.910000000000007,
"taskDurationMs": 6139.571999999999,
"heapDeltaBytes": -37472728,
"heapUsedBytes": 181056156,
"domNodes": -8068,
"jsHeapTotalBytes": 12029952,
"scriptDurationMs": 141.591,
"eventListeners": -14931,
"totalBlockingTimeMs": 400,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8375.549999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8198.368,
"heapDeltaBytes": 16430048,
"heapUsedBytes": 178028116,
"domNodes": 0,
"jsHeapTotalBytes": -15466496,
"scriptDurationMs": 129.34200000000007,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8722.566000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8419.12,
"heapDeltaBytes": 5550324,
"heapUsedBytes": 178228028,
"domNodes": 0,
"jsHeapTotalBytes": -11796480,
"scriptDurationMs": 157.99799999999996,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 142.96100000001388,
"styleRecalcs": 10,
"styleRecalcDurationMs": 18.773999999999997,
"layouts": 3,
"layoutDurationMs": 1.9129999999999998,
"taskDurationMs": 96.73200000000001,
"heapDeltaBytes": 3356992,
"heapUsedBytes": 72593276,
"domNodes": 150,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.085000000000001,
"eventListeners": 38,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 135.20700000003671,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.51,
"layouts": 2,
"layoutDurationMs": 0.6589999999999999,
"taskDurationMs": 80.94700000000002,
"heapDeltaBytes": 3004900,
"heapUsedBytes": 71473916,
"domNodes": 108,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.330999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
christian-byrne
left a comment
There was a problem hiding this comment.
Backport review under the Agent 1.54 release-backport grant (program/release-backport-authority.md; Christian 2026-09-16/09-20, coordinator thread T-01a0a6f4-ce4d-71c8-aa44-be96c230a4e5). Reviewed as carrier author, so this is an honest COMMENT review, not an approval.
Evidence at head d07e3b4:
- Hunk-level comparison vs source facbca7 performed; deviations are exactly the six documented adaptation sites in the PR body (palette-context banner, absent-train spec not introduced, drifted reopen test rewritten to source's post-change form, selection.workflow_id matcher narrowed pre-#17327, graph-activity tests not introduced, THREAD_STORAGE_KEY).
- Local gates on this exact head: pnpm typecheck ✅, pnpm typecheck:browser ✅, pnpm knip:no-cache ✅, vitest 302/302 on the five touched suites ✅.
- Red-on-parent: with production files reverted to parent 9439d31 and the new tests kept, 'follows the visible workflow while preserving a typed draft before Send' fails; green with the fix.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.54 #18836 +/- ##
============================================
Coverage 83.78% 83.78%
============================================
Files 2105 2105
Lines 124681 124732 +51
Branches 33428 31585 -1843
============================================
+ Hits 104464 104510 +46
- Misses 20039 20044 +5
Partials 178 178
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Carrier refreshed onto the moved target tip (
|
d07e3b4 to
4f25806
Compare
…8693) Internal testers reported friction from having to choose a target workflow before chatting. This PR selects the visible workflow automatically and makes the target behavior clear: - Fresh chats follow tab changes, keeping the typed draft, until a successful manual target selection, a node reference, or Send. Workflow references alone do not stop following. - These actions retain the target; Send does so even if the request fails. Users can still change targets explicitly. - New Chat resumes following unless the carried draft contains node references; those keep their original target. Reopened conversations retain their target. - The existing composer tip explains following or a visible/target mismatch. **Show target** opens the target without changing it. (cherry picked from commit facbca7)
4f25806 to
cc3aeaf
Compare
|
Second refresh: target tip moved again (#18727 landed → |
|
Recorded merge judgment over
|
Backport of #18693 (
facbca7658dd361ff5f5edaf5ff5404d582e0a64, merged tomain2026-09-25T07:11Z) tocore/1.54. Companion to thecloud/1.54carrier #18835.Why
#18693 fixes the agent editing a different workflow than the one the user is looking at — writes land on a document nobody is watching.
core/1.54feeds thecomfyui-frontend-packagePyPI train for Desktop/local.Cherry-pick adaptations (context only, no behavior change)
Same class of drift as the cloud carrier (see #18835), plus four core-specific ones:
agentNewChatTargetWorkflow.spec.ts(modify/delete): this spec does not exist on thecore/1.54train; per the [backport core/1.54] fix(agent): stop remote setWidget ops clobbering an in-progress local edit (#18766) #18810 precedent it was not introduced.RunNoticeBanner.vue: core still has the pre-fix(agent): use a neutral color palette and lighter text in the agent panel #18052 palette (bg-primary-background,font-medium; the core backport of fix(agent): use a neutral color palette and lighter text in the agent panel #18052 is still open as [backport core/1.54] fix(agent): use a neutral color palette and lighter text in the agent panel #18793). feat(agent): follow visible workflow until send or node reference #18693'scontext/showTargetlogic applied onto core's palette classes verbatim; no styling change smuggled in.retains an explicitly chosen target across panel reopen and New Chat: core's variant of this test had drifted from main's, so feat(agent): follow visible workflow until send or node reference #18693's rewrite hunk missed it. Applied the source's post-change version by hand (retains an explicitly chosen target across a plain panel reopen) — New Chat now resumes following, which is exactly the behavior feat(agent): follow visible workflow until send or node reference #18693 ships.selection: { node_ids, workflow_id }in the send payload;core/1.54predates PM-856: fix(agent): scope selected nodes to their workflow #17327 (selection scoping), so its payload has no nestedworkflow_id. Matchers narrowed to{ node_ids }on this branch only; top-levelworkflow_idassertions (the target-binding behavior under test) are untouched.agentGraphActivityStoretests riding as pre-image context in one hunk — that store is not on this train.Local gates on this head (per the #18722 lesson)
pnpm typecheck✅pnpm typecheck:browser✅pnpm knip:no-cache✅pnpm vitest runon the five touched suites: 302/302 ✅Red on parent
With production files reverted to the parent (
9439d31a3e) and the new tests kept,AgentPanelRoot.test.ts -t 'follows the visible workflow'fails; green with the fix.Note:
Vercel – billing-web-testfails branch-wide on everycore/1.54PR (recorded exception in the program's backport policy, sunset 2026-10-09); it is unrelated to this diff.🤖 Generated with Claude Code