Skip to content

[backport cloud/1.54] feat(agent): follow visible workflow until send or node reference (#18693) - #18835

Merged
christian-byrne merged 1 commit into
cloud/1.54from
bp4/backport-18693-cloud-1.54
Sep 25, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.54from
bp4/backport-18693-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backport of #18693 (facbca7658dd361ff5f5edaf5ff5404d582e0a64, merged to main 2026-09-25T07:11Z) to cloud/1.54.

Why this branch

#18693 fixes the agent editing a different workflow than the one the user is looking at — writes land on a document nobody is watching. Production (cloud.comfy.org) serves cloud/1.54 by pinned SHA, so the fix on main alone reaches no user. This is the P0 carrier for the branch production is pinned from.

Cherry-pick adaptations (context only, no behavior change)

cloud/1.54 lacks several main-only commits that #18693's diff sits next to (agent telemetry instrumentation #18665/#18503, workspace-scoped persistence #17765, retainStagedNode staging, the Topbar browser-test helper). The conflicts were all context drift from those; the fix's own logic is unchanged:

  • useCanvasSelection.ts: took feat(agent): follow visible workflow until send or node reference #18693's onNodesAdded option + stageUserSelection(); did NOT pull in main's unrelated retainStagedNode/retainOffSelectionNodes; the one call site uses this branch's [...nodes] instead of main's projectedNodes.
  • useAgentWorkflowSelection.ts: kept this branch's 2-arg commitWorkflowTarget — the source/previousWorkflowId params exist on main only for bind telemetry (onTargetBound), which is absent here. feat(agent): follow visible workflow until send or node reference #18693's onVisibleWorkflowChanged and its wiring are byte-identical to source.
  • useAgentSession.ts: feat(agent): follow visible workflow until send or node reference #18693's hoisted stored/workflow.initialize startup logic taken verbatim; storage key adapted to this branch's THREAD_STORAGE_KEY (main uses workspace-scoped threadStorageKey from fix: scope Agent persistence to workspace (FE-2405) #17765).
  • AgentPanelRoot.vue: start() moved after the new active-workflow watcher per source; onNewChat follow/retain logic taken verbatim minus the telemetry source arg (main-only); did not pull in main's approval-telemetry functions.
  • AgentPanelRoot.test.ts: new behavior tests taken from source; three main-only test helpers mapped to this branch's existing idioms (useWorkflowService() → the file's workflowService mock, StorageKeys.agentThread('personal') → 'Comfy.Agent.ThreadId', syncFakeSelection() → canvasStore.updateSelectedItems()).
  • agentWorkflowSelection.spec.ts: kept this branch's tab locator (no Topbar helper here); took feat(agent): follow visible workflow until send or node reference #18693's assertion changes.
  • docs/adr/README.md: kept this branch's index table, inserted the AGENT-TARGET-0037 row.

Local gates on this head (per the #18722 lesson: markers prove lines arrived, not their dependencies)

  • pnpm typecheck ✅
  • pnpm typecheck:browser ✅
  • pnpm knip:no-cache ✅
  • pnpm vitest run on the five touched suites: 316/316 ✅

Red on parent

With production files reverted to the parent (7b4d950b52) and the new tests kept, AgentPanelRoot.test.ts -t 'follows the visible workflow' fails (target does not follow the visible tab); green with the fix.

🤖 Generated with Claude Code

…8693)

Internal testers reported friction from having to choose a target
workflow before chatting. This PR selects the visible workflow
automatically and makes the target behavior clear:

- Fresh chats follow tab changes, keeping the typed draft, until a
successful manual target selection, a node reference, or Send. Workflow
references alone do not stop following.
- These actions retain the target; Send does so even if the request
fails. Users can still change targets explicitly.
- New Chat resumes following unless the carried draft contains node
references; those keep their original target. Reopened conversations
retain their target.
- The existing composer tip explains following or a visible/target
mismatch. **Show target** opens the target without changing it.

(cherry picked from commit facbca7)
@vercel

vercel Bot commented Sep 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
billing-web-test Error Error Sep 25, 2026 10:46am UTC
1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 25, 2026 10:46am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: b5c54f5d-3774-4838-9743-dd6c53e3c59d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1958 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1937 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/25/2026, 10:48:44 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.0 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.7 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.1 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.9 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.1 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 80ms TBT · 79.7 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
vue-large-graph-idle: · 59.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 175.0 MB heap
vue-large-graph-pan: · 59.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 2ms TBT · 173.3 MB heap
vue-node-resize-workload: · 59.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 52ms TBT · 174.4 MB heap
vue-zoom-out-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 178.8 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 363ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 63.2 MB
canvas-idle: DOM nodes -139
canvas-idle: event listeners -78
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 24ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 73
canvas-mouse-sweep: task duration 643ms
canvas-mouse-sweep: script duration 115ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 60.2 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -192
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 14ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 30
canvas-zoom-sweep: task duration 257ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.0 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 321ms
dom-widget-clipping: script duration 109ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 85.0 MB
dom-widget-clipping: DOM nodes 20
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 2ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 4
large-graph-idle: task duration 418ms
large-graph-idle: script duration 28ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.5 MB
large-graph-idle: DOM nodes -273
large-graph-idle: event listeners -161
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1191ms
large-graph-pan: script duration 584ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 83.2 MB
large-graph-pan: DOM nodes -118
large-graph-pan: event listeners -92
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 14ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 64
large-graph-zoom: task duration 1228ms
large-graph-zoom: script duration 525ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.7 MB
large-graph-zoom: DOM nodes -133
large-graph-zoom: event listeners -90
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 44
legacy-node-drag: task duration 1430ms
legacy-node-drag: script duration 686ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 84.3 MB
legacy-node-drag: DOM nodes -135
legacy-node-drag: event listeners 89
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 382ms
minimap-idle: script duration 24ms
minimap-idle: TBT 0ms
minimap-idle: heap used 80.4 MB
minimap-idle: DOM nodes -271
minimap-idle: event listeners -192
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 297ms
subgraph-dom-widget-clipping: script duration 99ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.1 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 347ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 63.9 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -240
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 24ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 555ms
subgraph-mouse-sweep: script duration 82ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 71.1 MB
subgraph-mouse-sweep: DOM nodes -131
subgraph-mouse-sweep: event listeners -117
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 12ms
subgraph-transition-enter: style recalc duration 26ms
subgraph-transition-enter: layout count 17
subgraph-transition-enter: style recalc count 21
subgraph-transition-enter: task duration 715ms
subgraph-transition-enter: script duration 24ms
subgraph-transition-enter: TBT 80ms
subgraph-transition-enter: heap used 79.7 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 43ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 4180ms
viewport-pan-sweep: script duration 1860ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 71.8 MB
viewport-pan-sweep: DOM nodes -253
viewport-pan-sweep: event listeners -160
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 11259ms
vue-large-graph-idle: script duration 162ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 175.0 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14934
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 14ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 70
vue-large-graph-pan: task duration 14189ms
vue-large-graph-pan: script duration 629ms
vue-large-graph-pan: TBT 2ms
vue-large-graph-pan: heap used 173.3 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14930
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 21ms
vue-node-resize-workload: style recalc duration 55ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4218ms
vue-node-resize-workload: script duration 96ms
vue-node-resize-workload: TBT 52ms
vue-node-resize-workload: heap used 174.4 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14931
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 5527ms
vue-zoom-out-idle: script duration 79ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 178.8 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -8
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 13ms
workflow-execution: layout count 3
workflow-execution: style recalc count 10
workflow-execution: task duration 66ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.4 MB
workflow-execution: DOM nodes 126
workflow-execution: event listeners 49
Raw data
{
  "timestamp": "2026-09-25T10:55:39.010Z",
  "gitSha": "d03e1b50adf8607dc17f0a40c64230011f21c86e",
  "branch": "bp4/backport-18693-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2003.9689999999837,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.406000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 320.65,
      "heapDeltaBytes": 5050720,
      "heapUsedBytes": 75904596,
      "domNodes": -278,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 6.917000000000002,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2016.4949999999635,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.774000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 406.055,
      "heapDeltaBytes": -13434852,
      "heapUsedBytes": 56545660,
      "domNodes": 1,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 10.419999999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1741.504999999961,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 24.383000000000003,
      "layouts": 14,
      "layoutDurationMs": 4.019,
      "taskDurationMs": 673.5450000000001,
      "heapDeltaBytes": -5427432,
      "heapUsedBytes": 64911328,
      "domNodes": -280,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 125.51,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1729.011000000014,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 22.99,
      "layouts": 14,
      "layoutDurationMs": 3.8640000000000003,
      "taskDurationMs": 612.7429999999999,
      "heapDeltaBytes": -9462908,
      "heapUsedBytes": 61401072,
      "domNodes": -282,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 104.489,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1704.8710000000256,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 14.045,
      "layouts": 6,
      "layoutDurationMs": 1.096,
      "taskDurationMs": 290.03999999999996,
      "heapDeltaBytes": 4579572,
      "heapUsedBytes": 75410012,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 13.286999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1718.511000000035,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 14.313999999999998,
      "layouts": 6,
      "layoutDurationMs": 0.9759999999999999,
      "taskDurationMs": 223.456,
      "heapDeltaBytes": 4694228,
      "heapUsedBytes": 75555004,
      "domNodes": 77,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 9.068999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 459.4280000000026,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 7.771999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 292.713,
      "heapDeltaBytes": 18759856,
      "heapUsedBytes": 89298948,
      "domNodes": 22,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 100.383,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 549.5180000000346,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.262,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 348.371,
      "heapDeltaBytes": 18029928,
      "heapUsedBytes": 88871924,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 118.30300000000001,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2040.0510000000054,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 344.704,
      "heapDeltaBytes": 11015672,
      "heapUsedBytes": 87347840,
      "domNodes": -280,
      "jsHeapTotalBytes": -1675264,
      "scriptDurationMs": 25.035,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2022.9389999999512,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 4.64,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 491.187,
      "heapDeltaBytes": -15153980,
      "heapUsedBytes": 87840556,
      "domNodes": -266,
      "jsHeapTotalBytes": -1638400,
      "scriptDurationMs": 30.035999999999994,
      "eventListeners": -160,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2080.9240000000386,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 11.741999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1037.4650000000001,
      "heapDeltaBytes": 18931564,
      "heapUsedBytes": 85949224,
      "domNodes": 10,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 537.618,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3082.6150000000325,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 15.307999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1344.007,
      "heapDeltaBytes": 11319144,
      "heapUsedBytes": 88441632,
      "domNodes": -245,
      "jsHeapTotalBytes": 122880,
      "scriptDurationMs": 630.964,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3285.759999999982,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 15.099,
      "layouts": 60,
      "layoutDurationMs": 13.106,
      "taskDurationMs": 1222.378,
      "heapDeltaBytes": -2653480,
      "heapUsedBytes": 76216032,
      "domNodes": -272,
      "jsHeapTotalBytes": -1675264,
      "scriptDurationMs": 511.567,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3651.1780000000726,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 12.933,
      "layouts": 60,
      "layoutDurationMs": 13.504999999999997,
      "taskDurationMs": 1234.0249999999999,
      "heapDeltaBytes": 12238240,
      "heapUsedBytes": 80436124,
      "domNodes": 6,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 538.949,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2510.003999999981,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 7.33,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1359.963,
      "heapDeltaBytes": 21921952,
      "heapUsedBytes": 88126588,
      "domNodes": -278,
      "jsHeapTotalBytes": 942080,
      "scriptDurationMs": 654.184,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2986.0380000000077,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 8.733,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1500.5190000000002,
      "heapDeltaBytes": 20644356,
      "heapUsedBytes": 88735860,
      "domNodes": 8,
      "jsHeapTotalBytes": 1728512,
      "scriptDurationMs": 718.382,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2028.0799999999317,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.438999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 398.587,
      "heapDeltaBytes": 8661528,
      "heapUsedBytes": 87076876,
      "domNodes": -268,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 26.554000000000002,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2004.6539999999595,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.097000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 365.445,
      "heapDeltaBytes": 3953084,
      "heapUsedBytes": 81568644,
      "domNodes": -273,
      "jsHeapTotalBytes": -2199552,
      "scriptDurationMs": 22.331999999999997,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 525.8850000000166,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 10.761999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 327.152,
      "heapDeltaBytes": 15121460,
      "heapUsedBytes": 87630272,
      "domNodes": 22,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 107.634,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 427.92900000006284,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 9.460999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 266.927,
      "heapDeltaBytes": 14008688,
      "heapUsedBytes": 86607164,
      "domNodes": 20,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 90.32799999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1992.8140000000099,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.586000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 295.54200000000003,
      "heapDeltaBytes": -6357448,
      "heapUsedBytes": 66254200,
      "domNodes": -296,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 5.418999999999999,
      "eventListeners": -238,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1991.1429999999655,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.495,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 397.65099999999995,
      "heapDeltaBytes": -5751056,
      "heapUsedBytes": 67698912,
      "domNodes": -296,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 10.798,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1677.6499999999714,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 21.876,
      "layouts": 18,
      "layoutDurationMs": 4.418,
      "taskDurationMs": 470.473,
      "heapDeltaBytes": 20077008,
      "heapUsedBytes": 85505632,
      "domNodes": 35,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 74.278,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1701.6279999999142,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 26.011,
      "layouts": 18,
      "layoutDurationMs": 4.942,
      "taskDurationMs": 638.8710000000001,
      "heapDeltaBytes": -9142000,
      "heapUsedBytes": 63520304,
      "domNodes": -296,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 89.128,
      "eventListeners": -238,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 882.0240000000013,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 26.047,
      "layouts": 17,
      "layoutDurationMs": 12.363,
      "taskDurationMs": 715.4100000000001,
      "heapDeltaBytes": -7189372,
      "heapUsedBytes": 83591452,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 23.98399999999999,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 80,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8458.080999999993,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 42.44,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4052.1259999999993,
      "heapDeltaBytes": -8728168,
      "heapUsedBytes": 67564292,
      "domNodes": -266,
      "jsHeapTotalBytes": -626688,
      "scriptDurationMs": 1826.945,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9170.270999999957,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 43.773,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4307.314,
      "heapDeltaBytes": 6250776,
      "heapUsedBytes": 82939760,
      "domNodes": -240,
      "jsHeapTotalBytes": 2220032,
      "scriptDurationMs": 1893.5700000000002,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12597.608000000037,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11989.02,
      "heapDeltaBytes": -42401828,
      "heapUsedBytes": 182840264,
      "domNodes": -8068,
      "jsHeapTotalBytes": -18444288,
      "scriptDurationMs": 182.99400000000006,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 11265.670999999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10529.412,
      "heapDeltaBytes": -35032140,
      "heapUsedBytes": 184089196,
      "domNodes": -8068,
      "jsHeapTotalBytes": -7352320,
      "scriptDurationMs": 140.90400000000002,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15256.309999999985,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 14.934000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14816.848,
      "heapDeltaBytes": -46474432,
      "heapUsedBytes": 180003916,
      "domNodes": -8068,
      "jsHeapTotalBytes": -19337216,
      "scriptDurationMs": 664.149,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 3,
      "frameDurationMs": 17.223333333333237,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14001.850999999988,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.594999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13561.799,
      "heapDeltaBytes": -35774804,
      "heapUsedBytes": 183518228,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10760192,
      "scriptDurationMs": 593.607,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4507.313999999951,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 61.555,
      "layouts": 20,
      "layoutDurationMs": 22.88000000000001,
      "taskDurationMs": 4453.049,
      "heapDeltaBytes": -38804412,
      "heapUsedBytes": 188247108,
      "domNodes": -8068,
      "jsHeapTotalBytes": 9564160,
      "scriptDurationMs": 77.907,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 104,
      "frameDurationMs": 17.220000000000013,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4101.183999999989,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 48.71899999999999,
      "layouts": 20,
      "layoutDurationMs": 18.375000000000004,
      "taskDurationMs": 3982.799,
      "heapDeltaBytes": -48963580,
      "heapUsedBytes": 177456496,
      "domNodes": -8068,
      "jsHeapTotalBytes": 6352896,
      "scriptDurationMs": 114.37,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6279.894000000013,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6066.958000000001,
      "heapDeltaBytes": 16749968,
      "heapUsedBytes": 185425260,
      "domNodes": 0,
      "jsHeapTotalBytes": -18087936,
      "scriptDurationMs": 87.98899999999999,
      "eventListeners": -8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 5334.0409999999565,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4986.853999999999,
      "heapDeltaBytes": 8909328,
      "heapUsedBytes": 189477092,
      "domNodes": 0,
      "jsHeapTotalBytes": -29097984,
      "scriptDurationMs": 69.32700000000003,
      "eventListeners": -8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 432.7049999999417,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 17.035999999999998,
      "layouts": 3,
      "layoutDurationMs": 1.5540000000000003,
      "taskDurationMs": 90.21000000000001,
      "heapDeltaBytes": 5023172,
      "heapUsedBytes": 74359776,
      "domNodes": 149,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 10.703999999999999,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 60.79699999997956,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 8.213,
      "layouts": 2,
      "layoutDurationMs": 0.619,
      "taskDurationMs": 41.92299999999999,
      "heapDeltaBytes": 3055192,
      "heapUsedBytes": 71235272,
      "domNodes": 103,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 3.341,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50612 75772 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.6% 275
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.4% 260
src/scripts/pnginfo.ts 21.4% 221

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport review under the Agent 1.54 release-backport grant (program/release-backport-authority.md; Christian 2026-09-16/09-20, coordinator thread T-01a0a6f4-ce4d-71c8-aa44-be96c230a4e5). Reviewed as carrier author, so this is an honest COMMENT review, not an approval.

Evidence at head 0115461:

  • Hunk-level comparison vs source facbca7: agentPanelStore.ts, AgentPanel.vue, useAgentDraftSubmission.ts, main.json, ADR — byte-identical to source hunks. Deviations exist only in the four documented adaptation sites (THREAD_STORAGE_KEY, 2-arg commitWorkflowTarget, [...nodes] staging call, absent comment block) and are context-only.
  • Local gates on this exact head: pnpm typecheck ✅, pnpm typecheck:browser ✅, pnpm knip:no-cache ✅ (the #18722 failure class), vitest 316/316 on the five touched suites ✅.
  • Red-on-parent: with production files reverted to parent 7b4d950 and the new tests kept, 'follows the visible workflow while preserving a typed draft before Send' fails; green with the fix.

@codecov

codecov Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.76543% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/workbench/extensions/agent/AgentPanelRoot.vue 93.33% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #18835   +/-   ##
=============================================
  Coverage              ?   83.81%           
=============================================
  Files                 ?     2113           
  Lines                 ?   125709           
  Branches              ?    34040           
=============================================
  Hits                  ?   105369           
  Misses                ?    20161           
  Partials              ?      179           
Flag Coverage Δ
e2e 66.80% <26.31%> (?)
unit 78.88% <98.76%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...h/extensions/agent/components/agent/AgentPanel.vue 96.77% <100.00%> (ø)
...ensions/agent/components/agent/RunNoticeBanner.vue 100.00% <100.00%> (ø)
...agent/composables/agent/useAgentDraftSubmission.ts 100.00% <100.00%> (ø)
...ensions/agent/composables/agent/useAgentSession.ts 97.48% <100.00%> (ø)
...ent/composables/agent/useAgentWorkflowSelection.ts 92.85% <100.00%> (ø)
...ions/agent/composables/agent/useCanvasSelection.ts 100.00% <100.00%> (ø)
...h/extensions/agent/stores/agent/agentPanelStore.ts 98.75% <100.00%> (ø)
src/workbench/extensions/agent/AgentPanelRoot.vue 90.13% <93.33%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Recorded merge judgment over Vercel – billing-web-test (per the recorded-exception provision in program/release-backport-authority.md, sunset 2026-10-09):

  • Named head: 0115461c35dc28e508da9eb1e87fb32fccc6fa71 — the reviewed head; merge is bound to it with --match-head-commit.
  • Gate output at this head: NOT MERGE READY: commit statuses are not green at 0115461c35...: Vercel – billing-web-test=failure — that status is the ONLY refusal.
  • Required-check tally at this head: lint-and-format ✅ test ✅ e2e-status ✅ (all completed success). Every other check/status green or skipped.
  • Branch-wide evidence on THIS branch: Vercel – billing-web-test was FAILURE at the heads of both cloud/1.54 carriers merged through the authorized flow this morning ([backport cloud/1.54] fix(agent): stop remote setWidget ops clobbering an in-progress local edit (#18766) #18808 → 21f9395454, [backport cloud/1.54] fix(agent): derive paywall visibility from current billing state (#18590) #18809 → 7b4d950b52), and it is not in the branch's required checks (ruleset requires lint-and-format, test, e2e-status). It is the same Vercel git-integration artifact recorded for core/1.54.
  • File overlap: zero — this diff touches src/workbench/extensions/agent/, browser_tests/tests/agent/, docs/adr/ and src/locales/; no billing paths.
  • The recorded exception names core/1.54; the identical failure pattern on cloud/1.54 is flagged in the bp-4 receipt for the operator to widen or fix at the source. This judgment waives that one status and nothing else.

@christian-byrne
christian-byrne merged commit c9288c9 into cloud/1.54 Sep 25, 2026
99 of 100 checks passed
@christian-byrne
christian-byrne deleted the bp4/backport-18693-cloud-1.54 branch September 25, 2026 11:05
christian-byrne added a commit that referenced this pull request Sep 25, 2026
…or node reference (#18693) (#18836)

Backport of #18693 (`facbca7658dd361ff5f5edaf5ff5404d582e0a64`, merged
to `main` 2026-09-25T07:11Z) to `core/1.54`. Companion to the
`cloud/1.54` carrier #18835.

## Why

#18693 fixes the agent editing a different workflow than the one the
user is looking at — writes land on a document nobody is watching.
`core/1.54` feeds the `comfyui-frontend-package` PyPI train for
Desktop/local.

## Cherry-pick adaptations (context only, no behavior change)

Same class of drift as the cloud carrier (see #18835), plus four
core-specific ones:

- `agentNewChatTargetWorkflow.spec.ts` (modify/delete): this spec does
not exist on the `core/1.54` train; per the #18810 precedent it was
**not introduced**.
- `RunNoticeBanner.vue`: core still has the pre-#18052 palette
(`bg-primary-background`, `font-medium`; the core backport of #18052 is
still open as #18793). #18693's `context`/`showTarget` logic applied
onto core's palette classes verbatim; no styling change smuggled in.
- Test `retains an explicitly chosen target across panel reopen and New
Chat`: core's variant of this test had drifted from main's, so #18693's
rewrite hunk missed it. Applied the source's post-change version by hand
(`retains an explicitly chosen target across a plain panel reopen`) —
New Chat now resumes following, which is exactly the behavior #18693
ships.
- Three new tests assert `selection: { node_ids, workflow_id }` in the
send payload; `core/1.54` predates #17327 (selection scoping), so its
payload has no nested `workflow_id`. Matchers narrowed to `{ node_ids }`
on this branch only; top-level `workflow_id` assertions (the
target-binding behavior under test) are untouched.
- Did not introduce the two `agentGraphActivityStore` tests riding as
pre-image context in one hunk — that store is not on this train.

## Local gates on this head (per the #18722 lesson)

- `pnpm typecheck` ✅
- `pnpm typecheck:browser` ✅
- `pnpm knip:no-cache` ✅
- `pnpm vitest run` on the five touched suites: 302/302 ✅

## Red on parent

With production files reverted to the parent (`9439d31a3e`) and the new
tests kept, `AgentPanelRoot.test.ts -t 'follows the visible workflow'`
fails; green with the fix.

Note: `Vercel – billing-web-test` fails branch-wide on every `core/1.54`
PR (recorded exception in the program's backport policy, sunset
2026-10-09); it is unrelated to this diff.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com>
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-docs Agent product architecture, contracts or documentation agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 27, 2026

This branch had an error being deployed

1 failed deployment
Preview – billing-web-test — 0115461c Deployed Sep 25, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-docs Agent product architecture, contracts or documentation agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants