Repository navigation
[backport cloud/1.54] feat(agent): follow visible workflow until send or node reference (#18693) - #18835
Conversation
…8693) Internal testers reported friction from having to choose a target workflow before chatting. This PR selects the visible workflow automatically and makes the target behavior clear: - Fresh chats follow tab changes, keeping the typed draft, until a successful manual target selection, a node reference, or Send. Workflow references alone do not stop following. - These actions retain the target; Send does so even if the request fails. Users can still change targets explicitly. - New Chat resumes following unless the carried draft contains node references; those keep their original target. Reopened conversations retain their target. - The existing composer tip explains following or a visible/target mismatch. **Show target** opens the target without changing it. (cherry picked from commit facbca7)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1958 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-25T10:55:39.010Z",
"gitSha": "d03e1b50adf8607dc17f0a40c64230011f21c86e",
"branch": "bp4/backport-18693-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2003.9689999999837,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.406000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 320.65,
"heapDeltaBytes": 5050720,
"heapUsedBytes": 75904596,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.917000000000002,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2016.4949999999635,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.774000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.055,
"heapDeltaBytes": -13434852,
"heapUsedBytes": 56545660,
"domNodes": 1,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.419999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1741.504999999961,
"styleRecalcs": 74,
"styleRecalcDurationMs": 24.383000000000003,
"layouts": 14,
"layoutDurationMs": 4.019,
"taskDurationMs": 673.5450000000001,
"heapDeltaBytes": -5427432,
"heapUsedBytes": 64911328,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 125.51,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1729.011000000014,
"styleRecalcs": 72,
"styleRecalcDurationMs": 22.99,
"layouts": 14,
"layoutDurationMs": 3.8640000000000003,
"taskDurationMs": 612.7429999999999,
"heapDeltaBytes": -9462908,
"heapUsedBytes": 61401072,
"domNodes": -282,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 104.489,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1704.8710000000256,
"styleRecalcs": 29,
"styleRecalcDurationMs": 14.045,
"layouts": 6,
"layoutDurationMs": 1.096,
"taskDurationMs": 290.03999999999996,
"heapDeltaBytes": 4579572,
"heapUsedBytes": 75410012,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.286999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1718.511000000035,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.313999999999998,
"layouts": 6,
"layoutDurationMs": 0.9759999999999999,
"taskDurationMs": 223.456,
"heapDeltaBytes": 4694228,
"heapUsedBytes": 75555004,
"domNodes": 77,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 9.068999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 459.4280000000026,
"styleRecalcs": 14,
"styleRecalcDurationMs": 7.771999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 292.713,
"heapDeltaBytes": 18759856,
"heapUsedBytes": 89298948,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 100.383,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 549.5180000000346,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.262,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 348.371,
"heapDeltaBytes": 18029928,
"heapUsedBytes": 88871924,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 118.30300000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2040.0510000000054,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 344.704,
"heapDeltaBytes": 11015672,
"heapUsedBytes": 87347840,
"domNodes": -280,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 25.035,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2022.9389999999512,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.64,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.187,
"heapDeltaBytes": -15153980,
"heapUsedBytes": 87840556,
"domNodes": -266,
"jsHeapTotalBytes": -1638400,
"scriptDurationMs": 30.035999999999994,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2080.9240000000386,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.741999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1037.4650000000001,
"heapDeltaBytes": 18931564,
"heapUsedBytes": 85949224,
"domNodes": 10,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 537.618,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3082.6150000000325,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.307999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1344.007,
"heapDeltaBytes": 11319144,
"heapUsedBytes": 88441632,
"domNodes": -245,
"jsHeapTotalBytes": 122880,
"scriptDurationMs": 630.964,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3285.759999999982,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.099,
"layouts": 60,
"layoutDurationMs": 13.106,
"taskDurationMs": 1222.378,
"heapDeltaBytes": -2653480,
"heapUsedBytes": 76216032,
"domNodes": -272,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 511.567,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3651.1780000000726,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.933,
"layouts": 60,
"layoutDurationMs": 13.504999999999997,
"taskDurationMs": 1234.0249999999999,
"heapDeltaBytes": 12238240,
"heapUsedBytes": 80436124,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 538.949,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2510.003999999981,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.33,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1359.963,
"heapDeltaBytes": 21921952,
"heapUsedBytes": 88126588,
"domNodes": -278,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 654.184,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2986.0380000000077,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.733,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1500.5190000000002,
"heapDeltaBytes": 20644356,
"heapUsedBytes": 88735860,
"domNodes": 8,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 718.382,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2028.0799999999317,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.438999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.587,
"heapDeltaBytes": 8661528,
"heapUsedBytes": 87076876,
"domNodes": -268,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 26.554000000000002,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2004.6539999999595,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.097000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.445,
"heapDeltaBytes": 3953084,
"heapUsedBytes": 81568644,
"domNodes": -273,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 22.331999999999997,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 525.8850000000166,
"styleRecalcs": 49,
"styleRecalcDurationMs": 10.761999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 327.152,
"heapDeltaBytes": 15121460,
"heapUsedBytes": 87630272,
"domNodes": 22,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 107.634,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 427.92900000006284,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.460999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 266.927,
"heapDeltaBytes": 14008688,
"heapUsedBytes": 86607164,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 90.32799999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1992.8140000000099,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.586000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 295.54200000000003,
"heapDeltaBytes": -6357448,
"heapUsedBytes": 66254200,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 5.418999999999999,
"eventListeners": -238,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1991.1429999999655,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.495,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.65099999999995,
"heapDeltaBytes": -5751056,
"heapUsedBytes": 67698912,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 10.798,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.6499999999714,
"styleRecalcs": 77,
"styleRecalcDurationMs": 21.876,
"layouts": 18,
"layoutDurationMs": 4.418,
"taskDurationMs": 470.473,
"heapDeltaBytes": 20077008,
"heapUsedBytes": 85505632,
"domNodes": 35,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 74.278,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1701.6279999999142,
"styleRecalcs": 78,
"styleRecalcDurationMs": 26.011,
"layouts": 18,
"layoutDurationMs": 4.942,
"taskDurationMs": 638.8710000000001,
"heapDeltaBytes": -9142000,
"heapUsedBytes": 63520304,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 89.128,
"eventListeners": -238,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 882.0240000000013,
"styleRecalcs": 21,
"styleRecalcDurationMs": 26.047,
"layouts": 17,
"layoutDurationMs": 12.363,
"taskDurationMs": 715.4100000000001,
"heapDeltaBytes": -7189372,
"heapUsedBytes": 83591452,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 23.98399999999999,
"eventListeners": 2385,
"totalBlockingTimeMs": 80,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8458.080999999993,
"styleRecalcs": 249,
"styleRecalcDurationMs": 42.44,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4052.1259999999993,
"heapDeltaBytes": -8728168,
"heapUsedBytes": 67564292,
"domNodes": -266,
"jsHeapTotalBytes": -626688,
"scriptDurationMs": 1826.945,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9170.270999999957,
"styleRecalcs": 250,
"styleRecalcDurationMs": 43.773,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4307.314,
"heapDeltaBytes": 6250776,
"heapUsedBytes": 82939760,
"domNodes": -240,
"jsHeapTotalBytes": 2220032,
"scriptDurationMs": 1893.5700000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12597.608000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11989.02,
"heapDeltaBytes": -42401828,
"heapUsedBytes": 182840264,
"domNodes": -8068,
"jsHeapTotalBytes": -18444288,
"scriptDurationMs": 182.99400000000006,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11265.670999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10529.412,
"heapDeltaBytes": -35032140,
"heapUsedBytes": 184089196,
"domNodes": -8068,
"jsHeapTotalBytes": -7352320,
"scriptDurationMs": 140.90400000000002,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 15256.309999999985,
"styleRecalcs": 73,
"styleRecalcDurationMs": 14.934000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14816.848,
"heapDeltaBytes": -46474432,
"heapUsedBytes": 180003916,
"domNodes": -8068,
"jsHeapTotalBytes": -19337216,
"scriptDurationMs": 664.149,
"eventListeners": -14929,
"totalBlockingTimeMs": 3,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14001.850999999988,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.594999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13561.799,
"heapDeltaBytes": -35774804,
"heapUsedBytes": 183518228,
"domNodes": -8068,
"jsHeapTotalBytes": -10760192,
"scriptDurationMs": 593.607,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4507.313999999951,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.555,
"layouts": 20,
"layoutDurationMs": 22.88000000000001,
"taskDurationMs": 4453.049,
"heapDeltaBytes": -38804412,
"heapUsedBytes": 188247108,
"domNodes": -8068,
"jsHeapTotalBytes": 9564160,
"scriptDurationMs": 77.907,
"eventListeners": -14931,
"totalBlockingTimeMs": 104,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4101.183999999989,
"styleRecalcs": 20,
"styleRecalcDurationMs": 48.71899999999999,
"layouts": 20,
"layoutDurationMs": 18.375000000000004,
"taskDurationMs": 3982.799,
"heapDeltaBytes": -48963580,
"heapUsedBytes": 177456496,
"domNodes": -8068,
"jsHeapTotalBytes": 6352896,
"scriptDurationMs": 114.37,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6279.894000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6066.958000000001,
"heapDeltaBytes": 16749968,
"heapUsedBytes": 185425260,
"domNodes": 0,
"jsHeapTotalBytes": -18087936,
"scriptDurationMs": 87.98899999999999,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5334.0409999999565,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4986.853999999999,
"heapDeltaBytes": 8909328,
"heapUsedBytes": 189477092,
"domNodes": 0,
"jsHeapTotalBytes": -29097984,
"scriptDurationMs": 69.32700000000003,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 432.7049999999417,
"styleRecalcs": 14,
"styleRecalcDurationMs": 17.035999999999998,
"layouts": 3,
"layoutDurationMs": 1.5540000000000003,
"taskDurationMs": 90.21000000000001,
"heapDeltaBytes": 5023172,
"heapUsedBytes": 74359776,
"domNodes": 149,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.703999999999999,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 60.79699999997956,
"styleRecalcs": 5,
"styleRecalcDurationMs": 8.213,
"layouts": 2,
"layoutDurationMs": 0.619,
"taskDurationMs": 41.92299999999999,
"heapDeltaBytes": 3055192,
"heapUsedBytes": 71235272,
"domNodes": 103,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 3.341,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
christian-byrne
left a comment
There was a problem hiding this comment.
Backport review under the Agent 1.54 release-backport grant (program/release-backport-authority.md; Christian 2026-09-16/09-20, coordinator thread T-01a0a6f4-ce4d-71c8-aa44-be96c230a4e5). Reviewed as carrier author, so this is an honest COMMENT review, not an approval.
Evidence at head 0115461:
- Hunk-level comparison vs source facbca7: agentPanelStore.ts, AgentPanel.vue, useAgentDraftSubmission.ts, main.json, ADR — byte-identical to source hunks. Deviations exist only in the four documented adaptation sites (THREAD_STORAGE_KEY, 2-arg commitWorkflowTarget, [...nodes] staging call, absent comment block) and are context-only.
- Local gates on this exact head: pnpm typecheck ✅, pnpm typecheck:browser ✅, pnpm knip:no-cache ✅ (the #18722 failure class), vitest 316/316 on the five touched suites ✅.
- Red-on-parent: with production files reverted to parent 7b4d950 and the new tests kept, 'follows the visible workflow while preserving a typed draft before Send' fails; green with the fix.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.54 #18835 +/- ##
=============================================
Coverage ? 83.81%
=============================================
Files ? 2113
Lines ? 125709
Branches ? 34040
=============================================
Hits ? 105369
Misses ? 20161
Partials ? 179
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Recorded merge judgment over
|
…or node reference (#18693) (#18836) Backport of #18693 (`facbca7658dd361ff5f5edaf5ff5404d582e0a64`, merged to `main` 2026-09-25T07:11Z) to `core/1.54`. Companion to the `cloud/1.54` carrier #18835. ## Why #18693 fixes the agent editing a different workflow than the one the user is looking at — writes land on a document nobody is watching. `core/1.54` feeds the `comfyui-frontend-package` PyPI train for Desktop/local. ## Cherry-pick adaptations (context only, no behavior change) Same class of drift as the cloud carrier (see #18835), plus four core-specific ones: - `agentNewChatTargetWorkflow.spec.ts` (modify/delete): this spec does not exist on the `core/1.54` train; per the #18810 precedent it was **not introduced**. - `RunNoticeBanner.vue`: core still has the pre-#18052 palette (`bg-primary-background`, `font-medium`; the core backport of #18052 is still open as #18793). #18693's `context`/`showTarget` logic applied onto core's palette classes verbatim; no styling change smuggled in. - Test `retains an explicitly chosen target across panel reopen and New Chat`: core's variant of this test had drifted from main's, so #18693's rewrite hunk missed it. Applied the source's post-change version by hand (`retains an explicitly chosen target across a plain panel reopen`) — New Chat now resumes following, which is exactly the behavior #18693 ships. - Three new tests assert `selection: { node_ids, workflow_id }` in the send payload; `core/1.54` predates #17327 (selection scoping), so its payload has no nested `workflow_id`. Matchers narrowed to `{ node_ids }` on this branch only; top-level `workflow_id` assertions (the target-binding behavior under test) are untouched. - Did not introduce the two `agentGraphActivityStore` tests riding as pre-image context in one hunk — that store is not on this train. ## Local gates on this head (per the #18722 lesson) - `pnpm typecheck` ✅ - `pnpm typecheck:browser` ✅ - `pnpm knip:no-cache` ✅ - `pnpm vitest run` on the five touched suites: 302/302 ✅ ## Red on parent With production files reverted to the parent (`9439d31a3e`) and the new tests kept, `AgentPanelRoot.test.ts -t 'follows the visible workflow'` fails; green with the fix. Note: `Vercel – billing-web-test` fails branch-wide on every `core/1.54` PR (recorded exception in the program's backport policy, sunset 2026-10-09); it is unrelated to this diff. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com>
Backport of #18693 (
facbca7658dd361ff5f5edaf5ff5404d582e0a64, merged tomain2026-09-25T07:11Z) tocloud/1.54.Why this branch
#18693 fixes the agent editing a different workflow than the one the user is looking at — writes land on a document nobody is watching. Production (
cloud.comfy.org) servescloud/1.54by pinned SHA, so the fix onmainalone reaches no user. This is the P0 carrier for the branch production is pinned from.Cherry-pick adaptations (context only, no behavior change)
cloud/1.54lacks several main-only commits that #18693's diff sits next to (agent telemetry instrumentation #18665/#18503, workspace-scoped persistence #17765,retainStagedNodestaging, theTopbarbrowser-test helper). The conflicts were all context drift from those; the fix's own logic is unchanged:useCanvasSelection.ts: took feat(agent): follow visible workflow until send or node reference #18693'sonNodesAddedoption +stageUserSelection(); did NOT pull in main's unrelatedretainStagedNode/retainOffSelectionNodes; the one call site uses this branch's[...nodes]instead of main'sprojectedNodes.useAgentWorkflowSelection.ts: kept this branch's 2-argcommitWorkflowTarget— thesource/previousWorkflowIdparams exist on main only for bind telemetry (onTargetBound), which is absent here. feat(agent): follow visible workflow until send or node reference #18693'sonVisibleWorkflowChangedand its wiring are byte-identical to source.useAgentSession.ts: feat(agent): follow visible workflow until send or node reference #18693's hoistedstored/workflow.initializestartup logic taken verbatim; storage key adapted to this branch'sTHREAD_STORAGE_KEY(main uses workspace-scopedthreadStorageKeyfrom fix: scope Agent persistence to workspace (FE-2405) #17765).AgentPanelRoot.vue:start()moved after the new active-workflow watcher per source;onNewChatfollow/retain logic taken verbatim minus the telemetrysourcearg (main-only); did not pull in main's approval-telemetry functions.AgentPanelRoot.test.ts: new behavior tests taken from source; three main-only test helpers mapped to this branch's existing idioms (useWorkflowService()→ the file'sworkflowServicemock,StorageKeys.agentThread('personal')→'Comfy.Agent.ThreadId',syncFakeSelection()→canvasStore.updateSelectedItems()).agentWorkflowSelection.spec.ts: kept this branch's tab locator (noTopbarhelper here); took feat(agent): follow visible workflow until send or node reference #18693's assertion changes.docs/adr/README.md: kept this branch's index table, inserted the AGENT-TARGET-0037 row.Local gates on this head (per the #18722 lesson: markers prove lines arrived, not their dependencies)
pnpm typecheck✅pnpm typecheck:browser✅pnpm knip:no-cache✅pnpm vitest runon the five touched suites: 316/316 ✅Red on parent
With production files reverted to the parent (
7b4d950b52) and the new tests kept,AgentPanelRoot.test.ts -t 'follows the visible workflow'fails (target does not follow the visible tab); green with the fix.🤖 Generated with Claude Code