Repository navigation
[backport core/1.54] fix(agent-crdt): realign named input links across multiple autogrow groups - #18512
Conversation
… after dynamic input reordering (#17221) Fixes [PM-993](https://linear.app/comfy-org/issue/PM-993): document links can target the wrong MiniMax input after node configuration or autogrow changes the live input order. - Resolve document input targets by name during initial materialization, reconcile, and remote connect. Preserve live order and extra inputs when every document input name exists live; otherwise use the document input list and order. - Incoming connect preserves matching runtime slot instances and shared arrays, including multiple connects in one batch. Commit the prepared slot order without re-merging it, and reject a target that slot validation removed before changing the graph. - Keep outputs index-based. Document the durable name-targeting rule separately from the interim store-first implementation and its [FE-2504 migration](https://linear.app/comfyorg/issue/FE-2504/agentcrdt-remove-store-first-remote-apply-and-every-reconciliation) in the [ADR](https://github.com/Comfy-Org/ComfyUI_frontend/blob/ryandi/pm-994-minimax-wiring-investigation/docs/adr/CRDT-INPUTS-0030-preserve-named-input-targets.md). - Surface all fixture cleanup failures, supply the bound root graph required by current main, and align regression data, utilities and assertions with repository conventions. Authoritative snapshot reconciliation retains slot arrays but can replace slot instances and lose runtime-only metadata. That existing preservation gap is separate follow-up work, not fixed by the incoming-connect path. Duplicate input names resolve to the first match; uniqueness is not enforced here. Producer-side/local-to-document addressing remains outside this PR under the [Option A ruling](https://github.com/christian-byrne/blocked-on-christian/issues/448). - Local CRDT suites and nodeDataStore: 54 files, 825 passed and 6 expected failures. The final review regression failed before the resolved-target bounds fix and passes afterward. - Application/browser typechecks, full lint, formatting, Knip and ADR validation passed during this follow-up; affected tests and commit hooks were rerun for the final fix. - The cloud browser regression covers live graph serialize/configure, not direct CRDT-document inspection. No local browser execution was performed during this follow-up; see the current remote CI checks for automated browser results. - Integrated remote PR head 322e726 and main 23559a8. The fixture now supplies boundRootGraphId, resolving the build/typecheck failures seen when CI combined the previous head with newer main. --------- Co-authored-by: Terry Jia <terryjia88@gmail.com> Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: Amp <amp@ampcode.com> ## Backport notes (core/1.54) Manual backport of #17221 onto core/1.54. Requested by Christian Byrne to unblock the core/1.54 backport of #18479 (cloud/1.54's #18275 counterpart), which depends on this PR's name-based CRDT input-targeting architecture. Conflicts resolved: - docs/adr/README.md: inserted the new CRDT-INPUTS-0030 row into core/1.54's existing ADR index instead of importing main's full index (core/1.54 does not carry the many other ADRs added on main since). - src/workbench/extensions/agent/crdt/graphMutations.test.ts: kept both sides' new imports (no substantive logic conflict, just adjacent import lines). - src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts: the conflict's theirs-side pulled in BatchOutcome/DocFrameTransport imports that predate #17221 on main (added by a separate, still-unbackported PR) and have no corresponding usage in this file on core/1.54. Kept only the GraphOperation import that #17221 itself adds and that the enqueue-wiring hunk actually uses; dropped the other two as unused (vue-tsc TS6133) rather than smuggling in that unrelated PR's imports. Dropped from this backport (not present, and not required, on core/1.54): - browser_tests/fixtures/agentConversationFixture.ts (modified) and browser_tests/tests/agent/agentConversationReplay.spec.ts (added): this E2E spec and its fixture edits depend on agent-conversation E2E harness additions from other PRs never backported to core/1.54. The file itself is missing on this branch, so the modify/delete conflict is a real gap, not something introduced by this commit. - browser_tests/fixtures/data/minimaxAutogrowReload.ts and browser_tests/fixtures/utils/minimaxAutogrowReload.ts (both added): test-only fixture data/utilities consumed exclusively by the spec above; dropped as dead code once that spec was dropped. All runtime code (graphMutations.ts, agentNodeMaterializer.ts) and all Vitest unit coverage for the CRDT input-targeting logic (graphMutations.test.ts, agentNodeMaterializer.inputOrder.test.ts + its new fixtures, nodeDataStore.test.ts, useAgentCrdtFollower.test.ts) are included unchanged in substance.
…roups (#18275) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789965317152049?thread_ts=1789965317.152049&cid=C0BGH348Z0C)_ Fixes agent-authored nodes with more than one autogrow group (e.g. a reference node with separate image and video reference groups) losing track of which wire goes where after the agent chat materializes the node. **Before:** For a node like `MiniMaxH3ReferenceToVideo`, which has two independent autogrow groups (`ref_images`, `ref_videos`) alongside scalar widgets (`width`, `height`, `length`, `ref_image_size`), both the agent panel and the canvas painted wires onto the wrong inputs after the node was built or reopened — a Load Image could land on `ref_image_size`, a text input on `length`, a Math node on `ref_videos`, and `width`/`height` could show as `0`. The server's own view of the graph was correctly wired, so pressing Run submitted the client's shifted (wrong) values and failed with type errors that didn't actually exist. Reopening the tab reconstructed the slots differently each time. **After:** For a document that is already correctly wired, projecting it onto the live canvas now lands every wire on the input it was actually connected to, and the value submitted on Run matches what's shown on canvas, regardless of how many autogrow groups the node has or how their growth interleaves with each other and with the node's scalar widgets. This covers the document-to-live projection direction only; the outbound leg (minting a link back into the host document) can still corrupt a node's addressing before this projection ever runs on it — see "Known issue" below and #18332. - **What**: `node.configure()` and autogrow growth (`COMFY_AUTOGROW_V3`) can reorder or insert a node's live inputs after the agent CRDT follower has already built its link adapters against the saved document's input *positions*. With one autogrow group this only shifts a couple of neighboring scalar widgets; with two or more groups growing on the same node, the drift compounds across the whole input list. The fix re-points the follower's link adapters, and the incoming reconcile/connect handling, at the input with the same *name* as the saved slot, instead of the same index — reusing the link realignment ordinary node loading already relies on, and extending the reconcile/connect path to resolve by name. A live-only input (one no document occurrence matches) is retained, rather than dropped along with the rest of the document's positional replacement, only when it classifies as a real autogrow group member — via a live query, this follower's own remembered answer, the node type's static `COMFY_AUTOGROW_V3` definition, or (last resort) the name-shape heuristic; a genuine removal still lets the document win. Duplicate input names on one node are matched pairwise by occurrence (the Nth document occurrence against the Nth live occurrence), not by first match. Node-data-store slot arrays are now refilled in place rather than reassigned, so any reactive view already holding that array keeps its identity across a resync. - **How**: Added a regression fixture and CRDT-follower test modeled on a node with two interleaved autogrow groups plus adjacent scalar widgets (the shape a single-group fixture can't exercise) — confirmed it fails on the unfixed code, then confirmed the by-name realignment above (generalized, not per-pair) makes it pass without further special-casing. The live-node autogrow-membership port collapsed "the live node can't answer yet" and "the live node answered no" into the same `undefined`, so an activate/resubscribe race could drop an explicit-name autogrow spare. The port now returns a tagged `unavailable`/`member`/`notMember` result and only the last two are authoritative. When the port is `unavailable`, provenance falls back in this order: this follower's own remembered live answer, then the node type's own static `COMFY_AUTOGROW_V3` definition, and only then the name-shape heuristic. The membership classification against a static schema (explicit `names` list vs. trailing ordinal) is one predicate shared with `dynamicWidgets.ts`'s live registration rather than a second implementation. `graphMutations.ts`) The remembered answers are addressable only from the node incarnation that produced them: - **Graph scope in the key.** One `GraphMutations` instance is retained per cloud workflow while resolving the current local workflow's scope on every batch, so the key is `rootGraphId` + `owningGraphId` + node id for remember, read and forget alike. - **Per-mutation transactional writes.** `batch()` opens a draft before `prepare()`; every `member`/`notMember` write and forget (replace, `deleteNode`, `removeMissing`, `clearSemanticGraph`) is staged into that draft, journaled under the mutation that produced it. `commit()` applies one mutation's journaled writes to the persisted store immediately after that mutation's own graph effect lands, and only when that effect actually landed — a `connect` whose `replaceLink` returns `undefined` (a stale expected occupant, an ID collision, or a newly-occupied target) never publishes the write it staged. A later mutation in the same batch throwing therefore still keeps every earlier mutation's already-applied write, and a `prepare()` rejection leaves the persisted store completely untouched. Within `prepare()` itself, a mutation can still see an earlier mutation's own staged (not yet committed) answer for the same node — its pending overlay chains onto the nearest earlier-indexed mutation's still-pending one, so two mutations prepared back to back in one batch agree on the same name's classification — but nothing outside that single `prepare()`/`commit()` pass, including a later batch's own `currentView()` reads, ever sees a same-batch mutation's answer before its own `commit()` iteration actually applies it. - **Definition-identity revalidation.** Each entry stores the `ComfyNodeDefImpl` it was answered against; a re-registration under the same type name constructs a new one, so the current definition always beats stale memory. Node type is still part of the entry for the case where another writer changes a node's type without this instance observing it. Also fixed a real race in the turn step: `agentConversationStore.ingest` only routes `agent_message_done` while the store already holds the ack's `message_id`, so the host must not answer before the assistant placeholder `startTurn` renders, or the turn hangs on a live Stop button forever. `agentCrdtMultiAutogrowRealign.spec.ts` sets sentinel widget values through the UI and inspects the submitted-prompt payload by name across three scenarios: a same-page tab-switch resubscribe, an actual save-and-reload of the same workflow, and a reload of a workflow whose saved bytes were corrupted after the save. The tab-switch case fills its sentinels *before* switching tabs and re-verifies those same values afterward, so a reconcile that resets or shifts an existing scalar during replay fails it, not just one that mis-wires a link. Three defects in the reload path (the second and third scenarios) are fixed here: - `mockSavedWorkflowPersistence` never served the `GET /api/userdata?dir=workflows&...` listing (its `**/api/userdata/*` pattern cannot match a URL with no path segment after `userdata`), so after a reload `workflowStore`'s `syncEntities` saw an empty listing, dropped the saved path from `openWorkflowPaths`, and the agent panel's workflow picker — which lists `openWorkflows` — came up **empty**. The reopen step then waited on a menu item that could never appear. This is the state the hosted runs were failing in; no timeout could help. - The saved-path GET counter route could never match an `encodeURIComponent`-encoded userdata path (`/api/userdata/workflows%2F<name>.json`), so the "the reopen really read the file" assertion polled a counter stuck at zero. It is now counted inside the persistence mock, and only for GETs it actually answered from retained saved bytes. - Saving under the default `Unsaved Workflow` name made the reopen indistinguishable from the fresh tab a reload always offers; it now saves under an explicit name through the Save As UI. **Spec structure.** The 506-line free-standing scenario function is replaced by a fixture-owned harness (`browser_tests/fixtures/helpers/MultiAutogrowRealignHarness.ts`, registered via `browser_tests/fixtures/multiAutogrowRealignFixture.ts`), per `browser_tests/README.md`. The spec file now contains only imports, `test.describe`, `test.describe.configure` and three `test()` bodies whose acts and assertions read in order. Per-test budgets drop from 240s to 90s/120s/120s. With the empty picker fixed, the second-turn reattach case reaches its assertions for the first time and fails deterministically: after save → reload → reattach, a link is dropped with `error_reconciling_agent_incompatible_link_type`. The live graph is correct (origin `VIDEO`, target `VIDEO`); the **host document** is not — node 2's doc inputs are in document name order (`prompt` at index 4, `ref_videos.ref_video_1` at index 7) but the link values were written by LIVE position, so `"link": 204` sits on the `prompt` (`STRING`) input and the link tuple reads `[204, 1, 3, 2, 4, "VIDEO"]`. `excludeIncompatibleLinks` then correctly refuses it. That is the same positional-vs-named confusion this PR fixes on the inbound path, occurring on the page → host doc leg through the real `applyOps` from `@comfyorg/comfy-multi-player`. Fixing it means changing the mint/outbound leg, which is a different code path needing its own design and regressions. **This defect is NOT covered by this PR.** It is not exercised by `agentCrdtMultiAutogrowRealign.spec.ts` (verifies the inbound/reconcile path only) and it is not exercised by `agentFollowerReloadBinding.spec.ts` either — that spec reattaches an ordinary scalar widget edit on a single-input node, never a multi-autogrow node, and never mints an outbound link at all. Rather than ship a red test or weaken an assertion in this PR, the reproduction is tracked separately with a real failing unit test: #18332 (branch `test/agent-crdt-outbound-link-position-bug`, `src/workbench/extensions/agent/crdt/linkMintOutboundPositionCorruption.test.ts`). - `realignInputLinkSlots` (already used by ordinary graph loading) is now also invoked after agent materialization; it iterates all of a node's named links in passes, so it isn't limited to a single autogrow group. - `mergeInputSlotsByName`/`hasNonGrowthInputSetChange` in `graphMutations.ts`: a live-only input only survives when it is a widget-promoted input slot (the wire format never carries one as a named input either way) or classifies as an autogrow group member (and, unless the caller opts into `preserveLinkedAutogrow`, is unlinked); any other live-only input means the whole input set changed, and the document's list and order replace it positionally. See `docs/adr/CRDT-INPUTS-0030-preserve-named-input-targets.md` for the full rule. - `createAutogrowMemory`'s read contract: an entry is trusted only when the graph scope, the node type, and the node definition object all still match. Its writes are gated on the producing mutation's own commit result — see "Autogrow memory lifecycle" above. - [x] **Red/green on each of the cache and commit-ordering blockers.** Each fix was reverted in isolation and the matching case confirmed to fail, then restored: - dropping the graph scope from the key fails `does not let one graph scope read another scope's remembered autogrow answer on the same GraphMutations instance` - making `remember()` write straight to the real map fails `does not leak the live answer a rejected batch resolved while preparing` - dropping the `nodeDef` identity clause fails `prefers a re-registered node definition over an autogrow answer remembered under the definition it replaced` - dropping the `nodeType` clause fails `does not apply a remembered autogrow answer to a node id another writer has since given a different type` - moving `beginMutation` back to prepare-only fails `journals a connect mutation's commit-time autogrow answer under its own index, not the batch's last-prepared one` - removing the `committed` gate on `connect`'s memory publication fails `does not publish a connect mutation's staged autogrow answer when its own replaceLink fails to land` - reverting `refillArray` to a spread-based `splice` fails `updateNode refills a slot list long enough to overflow a spread-based splice, without changing array identity` - **(round 8)** ordering `nodeStore.registerNode()` before `deps.layout.createNode()` (the pre-fix shape) fails `keeps an earlier mutation's remembered autogrow answer when a later mutation in the same batch throws`'s new node-3-absence assertion - **(round 8)** reverting the autogrow-memory draft to a single shared `shadow` (no per-mutation pending overlay / `rollbackMutation`) fails `does not leak a failed connect's staged autogrow answer to a later connect in the same batch` - **(round 9)** deleting the incumbent before `deps.layout.createNode()` in a type-changing `replaceNode` (the pre-fix shape) fails `keeps the incumbent node fully intact when a type-changing replace throws creating its layout` - **(round 9)** reverting `currentView` to check only the current mutation's own pending overlay and the confirmed shadow fails `lets a mutation see an earlier mutation's still-pending autogrow answer from the same batch`, while `does not leak a failed connect's staged autogrow answer to a later connect in the same batch` (round 8) keeps passing under the fixed, chained version - **(round 9)** restoring `preserveLinkedAutogrow`'s blanket non-plain-object early return fails `drops a linked, non-plain runtime slot the document dropped, even with preserveLinkedAutogrow set` - **(round 9)** removing the new widget-promoted-slot exception fails `retains a widget-promoted input slot no document snapshot ever lists`, and (caught only by the full suite, not this file's own unit tests) regresses `agentNodeMaterializer.inputOrder.test.ts`'s `preserves named targets when an agent reconnect follows growth that moves width` - [x] `pnpm exec vue-tsc --noEmit` and `pnpm exec vue-tsc --noEmit -p browser_tests/tsconfig.json` — clean - [x] `pnpm oxlint` (type-aware, whole repo) — no new warnings on `graphMutations.ts`/`nodeDataStore.ts`; `pnpm exec eslint src/workbench/extensions/agent/crdt/graphMutations.ts src/workbench/extensions/agent/crdt/graphMutations.test.ts src/stores/nodeDataStore.ts src/stores/nodeDataStore.test.ts` — clean; `pnpm exec oxfmt --check .` — clean; `pnpm knip` — clean - [x] `pnpm fallow audit --base origin/main` — `complexity_introduced: 2`, `dead_code_introduced: 0`, `duplication_introduced: 0`; the 2 introduced complexity findings are `LGraphCanvas.deselectAll` and `widgetMap.adoptConcreteWidget`, neither touched this round or by this PR — `graphMutations.ts`'s own `prepare`/`commit` findings are still `introduced: false` (pre-existing baseline). The overall verdict is `fail` only from those two plus unrelated inherited styling/complexity drift on `main` since this branch's base; nothing under `src/workbench/extensions/agent/crdt/` or `src/stores/nodeDataStore.ts` is newly introduced. - [x] `pnpm vitest run src/workbench/extensions/agent/crdt/ src/stores/nodeDataStore.test.ts` — 57 files, **885 passed, 5 expected fail** - [ ] The browser spec reorder (fill-then-switch-then-reverify) was not re-executed locally this round — this session had no dev server or backend available. It only reorders existing `test.step`s around already-existing harness methods (`fillSentinelWidgetValues`, `expectSentinelWidgetValues`, `switchTabsAwayAndBack`), with no new harness API surface, and typechecks clean. Hosted CI is the authority for this file, as it was for the prior round's own claim. **Known CI blocker (not addressed here):** `Check for AI agent co-author trailers` fails on 2 pre-existing commits on this branch that need a history rewrite (rewording). Destructive git history operations are outside what this session's own permission system allows regardless of reviewer sign-off; a human with push access to this branch needs to do that reword directly. --------- Co-authored-by: bymyself <cbyrne@comfy.org> Co-authored-by: Amp <amp@ampcode.com>
- export zComfyApiWorkflow from workflowSchema.ts (already exported on main) - fix @/platform/remote/comfyui/types import paths to @/schemas/apiSchema (that module doesn't exist on core/1.54) - wire up linkPresentationStore in graphMutations.ts and drop the guardLocalEdits arg (local-edit guard feature from unbackported #18361 isn't on this branch) - drop unused reconcileAutogrowInputs export (its only caller is in an unbackported PR's diff to agentNodeMaterializer.ts)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1952 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-25T14:43:22.476Z",
"gitSha": "5f1d72ed40782eb66075cb8ec3907816db1aa254",
"branch": "backport-18275-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2029.7879999999964,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.0459999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.612,
"heapDeltaBytes": 641384,
"heapUsedBytes": 64730360,
"domNodes": 16,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8.926,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2066.214000000002,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.9799999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 515.6,
"heapDeltaBytes": 3383168,
"heapUsedBytes": 73521908,
"domNodes": -283,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.545,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1882.3869999999943,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.302999999999997,
"layouts": 14,
"layoutDurationMs": 4.149,
"taskDurationMs": 892.4090000000001,
"heapDeltaBytes": -6403852,
"heapUsedBytes": 63639112,
"domNodes": -281,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 164.516,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1868.2140000000231,
"styleRecalcs": 76,
"styleRecalcDurationMs": 31.595,
"layouts": 14,
"layoutDurationMs": 4.362,
"taskDurationMs": 905.2239999999999,
"heapDeltaBytes": 12693936,
"heapUsedBytes": 83793764,
"domNodes": -281,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 164.198,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.4299999999466,
"styleRecalcs": 33,
"styleRecalcDurationMs": 16.099000000000004,
"layouts": 6,
"layoutDurationMs": 1.09,
"taskDurationMs": 352.899,
"heapDeltaBytes": 4704516,
"heapUsedBytes": 75591068,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.244,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000007,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1746.8849999999065,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.221,
"layouts": 6,
"layoutDurationMs": 1.125,
"taskDurationMs": 384.82800000000003,
"heapDeltaBytes": 4617688,
"heapUsedBytes": 75541664,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.881000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 668.4730000000059,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.479999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.67,
"heapDeltaBytes": -8238236,
"heapUsedBytes": 63031424,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 165.68300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 644.403999999895,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.627999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.186,
"heapDeltaBytes": -7597856,
"heapUsedBytes": 63525160,
"domNodes": 18,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 161.192,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2044.0450000000396,
"styleRecalcs": 5,
"styleRecalcDurationMs": 6.017999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 629.46,
"heapDeltaBytes": 10575268,
"heapUsedBytes": 86959500,
"domNodes": -270,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 36.389,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2041.6609999999764,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.560000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 604.0319999999999,
"heapDeltaBytes": 10439004,
"heapUsedBytes": 87077112,
"domNodes": -271,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 32.672999999999995,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2482.141000000013,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.714000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1739.729,
"heapDeltaBytes": 12207508,
"heapUsedBytes": 89795476,
"domNodes": -276,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 865.796,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2293.9199999999573,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.883999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1623.3280000000004,
"heapDeltaBytes": 18590128,
"heapUsedBytes": 85119436,
"domNodes": -278,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 821.8639999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3730.1439999999957,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.355999999999996,
"layouts": 60,
"layoutDurationMs": 12.182000000000002,
"taskDurationMs": 1799.211,
"heapDeltaBytes": -3041896,
"heapUsedBytes": 75733000,
"domNodes": -281,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 795.766,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3482.6980000000276,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.761,
"layouts": 60,
"layoutDurationMs": 11.642999999999999,
"taskDurationMs": 1674.0009999999997,
"heapDeltaBytes": 8495280,
"heapUsedBytes": 76476388,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 766.7750000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3110.656000000006,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.656000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1906.208,
"heapDeltaBytes": 17858772,
"heapUsedBytes": 86058548,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 944.737,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3127.228999999943,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.809000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1912.904,
"heapDeltaBytes": 25526764,
"heapUsedBytes": 94064600,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 958.208,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2009.8900000000413,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.9669999999999991,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 535.9580000000001,
"heapDeltaBytes": 21687896,
"heapUsedBytes": 88790492,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.641000000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2061.5940000000137,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.434000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 621.102,
"heapDeltaBytes": 4737040,
"heapUsedBytes": 82360064,
"domNodes": -279,
"jsHeapTotalBytes": -2461696,
"scriptDurationMs": 34.947,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 604.1299999999978,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.41400000000004,
"heapDeltaBytes": 15008280,
"heapUsedBytes": 88263460,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 144.56,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 626.2309999999616,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.964000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.022,
"heapDeltaBytes": 14958700,
"heapUsedBytes": 88261948,
"domNodes": 16,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 141.23100000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.991000000004,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.330000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.29400000000004,
"heapDeltaBytes": -5719164,
"heapUsedBytes": 67592900,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.568999999999999,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.029999999996,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.629,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.26300000000003,
"heapDeltaBytes": 9217996,
"heapUsedBytes": 82610240,
"domNodes": -297,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.011000000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.6610000000023,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.147000000000002,
"layouts": 18,
"layoutDurationMs": 4.623,
"taskDurationMs": 816.287,
"heapDeltaBytes": 10745820,
"heapUsedBytes": 83971212,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 113.22299999999998,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1737.2719999999617,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.426,
"layouts": 18,
"layoutDurationMs": 4.261,
"taskDurationMs": 809.889,
"heapDeltaBytes": 9690360,
"heapUsedBytes": 82765408,
"domNodes": -298,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 108.848,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.3219999999933,
"styleRecalcs": 18,
"styleRecalcDurationMs": 32.57899999999999,
"layouts": 14,
"layoutDurationMs": 15.856000000000002,
"taskDurationMs": 928.3970000000002,
"heapDeltaBytes": -5342912,
"heapUsedBytes": 87511564,
"domNodes": 13751,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 31.957999999999995,
"eventListeners": 2385,
"totalBlockingTimeMs": 140,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8457.135000000051,
"styleRecalcs": 247,
"styleRecalcDurationMs": 34.985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5876.1630000000005,
"heapDeltaBytes": 9255452,
"heapUsedBytes": 85588096,
"domNodes": -272,
"jsHeapTotalBytes": -663552,
"scriptDurationMs": 2704.113,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8554.533000000105,
"styleRecalcs": 247,
"styleRecalcDurationMs": 35.914,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5920.482,
"heapDeltaBytes": 4413732,
"heapUsedBytes": 80831512,
"domNodes": -272,
"jsHeapTotalBytes": -925696,
"scriptDurationMs": 2703.6169999999997,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17936.441000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17059.902000000002,
"heapDeltaBytes": -41228004,
"heapUsedBytes": 176749556,
"domNodes": -8068,
"jsHeapTotalBytes": -9203712,
"scriptDurationMs": 340.46999999999997,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18001.19500000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17213.105,
"heapDeltaBytes": -61828784,
"heapUsedBytes": 178251816,
"domNodes": -8068,
"jsHeapTotalBytes": -18001920,
"scriptDurationMs": 285.64500000000004,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21624.95999999999,
"styleRecalcs": 176,
"styleRecalcDurationMs": 19.94600000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21230.543,
"heapDeltaBytes": -33777440,
"heapUsedBytes": 184381524,
"domNodes": -8068,
"jsHeapTotalBytes": -11616256,
"scriptDurationMs": 1009.485,
"eventListeners": -14927,
"totalBlockingTimeMs": 132,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21825.984999999946,
"styleRecalcs": 170,
"styleRecalcDurationMs": 18.265000000000033,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21554.577999999998,
"heapDeltaBytes": -37485192,
"heapUsedBytes": 168793280,
"domNodes": -8068,
"jsHeapTotalBytes": -12337152,
"scriptDurationMs": 911.512,
"eventListeners": -14925,
"totalBlockingTimeMs": 37,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6400.19000000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 88.87799999999996,
"layouts": 20,
"layoutDurationMs": 24.36999999999999,
"taskDurationMs": 6249.101000000001,
"heapDeltaBytes": -48247880,
"heapUsedBytes": 182947176,
"domNodes": -8068,
"jsHeapTotalBytes": 9523200,
"scriptDurationMs": 116.30600000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 557,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6521.067000000016,
"styleRecalcs": 20,
"styleRecalcDurationMs": 99.99199999999998,
"layouts": 20,
"layoutDurationMs": 31.701000000000008,
"taskDurationMs": 6403.324,
"heapDeltaBytes": -56550564,
"heapUsedBytes": 174659084,
"domNodes": -8068,
"jsHeapTotalBytes": 1658880,
"scriptDurationMs": 134.88,
"eventListeners": -14931,
"totalBlockingTimeMs": 413,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9191.838000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8667.321,
"heapDeltaBytes": 23540872,
"heapUsedBytes": 180207512,
"domNodes": 0,
"jsHeapTotalBytes": -8126464,
"scriptDurationMs": 151.59199999999996,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9288.329999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8993.041,
"heapDeltaBytes": 16175276,
"heapUsedBytes": 180097884,
"domNodes": 0,
"jsHeapTotalBytes": -9437184,
"scriptDurationMs": 168.16000000000008,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 471.7509999999834,
"styleRecalcs": 19,
"styleRecalcDurationMs": 21.634,
"layouts": 3,
"layoutDurationMs": 1.4989999999999999,
"taskDurationMs": 119.32399999999998,
"heapDeltaBytes": 5062360,
"heapUsedBytes": 73492484,
"domNodes": 147,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 12.633999999999999,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 94.2969999999832,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.340000000000002,
"layouts": 2,
"layoutDurationMs": 0.588,
"taskDurationMs": 71.73599999999999,
"heapDeltaBytes": 3005040,
"heapUsedBytes": 72209744,
"domNodes": 106,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.467000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
CI failure: AI agent co-author trailersThe The exact flagged trailer line from the job log: Fixing this requires a git history rewrite ( This is the same blocker #18275 and #18479 hit before this; both were resolved by a maintainer (DrJKL) pushing the reword directly. A human with push access to this branch needs to do the same here. Generated by Claude Code |
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.54 #18512 +/- ##
=============================================
+ Coverage 83.78% 83.81% +0.02%
=============================================
Files 2105 2107 +2
Lines 124732 125139 +407
Branches 33452 33575 +123
=============================================
+ Hits 104509 104885 +376
- Misses 20045 20076 +31
Partials 178 178
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
- agentConversationHostDoc.ts: add HostDoc.subscribeRefused(), backported from #18213 (never backported to core/1.54), which agentFollowerHostSocket.ts (#18275) already calls. - MultiAutogrowRealignHarness.ts: fix mocked PromptResponse to match this branch's apiSchema (no number field, error is required), instead of the main-branch shape the backport picked up. Fixes pnpm typecheck:browser failures in the lint-and-format CI check.
|
Investigated the
No code fix pushed — I don't have a confirmed, fixable defect, only an unconfirmed hypothesis. Recommend a maintainer with a full CI-equivalent environment re-run Generated by Claude Code |
…thub.com/Comfy-Org/comfyui_frontend into backport-18275-to-core-1.54 # Conflicts: # src/workbench/extensions/agent/crdt/graphMutations.ts
c0406c2 to
caf244d
Compare
Status from the
|
| Old head / tree | c0406c26e2304e23b7829d7367cfd1df1e9df19c / 6638f2d8c46618dc96228734082d4cace85bb520 |
| New head / tree | caf244dd9ce590b701372d3c0e6e2ec126c21e25 / 6638f2d8c46618dc96228734082d4cace85bb520 |
| Tree equality | identical; git diff <old> <new> = 0 lines |
| Removed | exactly one line, the forbidden trailer |
| Preserved | Co-authored-by: bymyself and Co-authored-by: Amp; all 8 commits' tree, author, author-date and subject byte-identical |
| Push | --force-with-lease bound to the old head |
Check AI Co-Authors is success at the new head. No published core/1.54 commit was rewritten — the branch tip is still an ancestor of the new head.
Backport correctness: reviewed and clean
The file set legitimately diverges from source #18275, which is the same shape as the defect that broke this branch — so it was checked specifically:
- It adds
linkPresentationStore.ts,types/linkPresentation.tsand browser fixtures that exist onmainbut not here. That is the correct handling — bringing the dependency instead of leaving a dangling import, which is exactly what [backport core/1.54] Fix duplicate-name stale workflow binding resolution #18722 failed to do.knippassing proves none is orphaned. - The
Merge commit '4aa5c6f60d…'is already an ancestor ofcore/1.54(an earlier backport), not foreignmaincontent. - The omitted
LGraphCanvas.tshunk from source is a pure style edit (Array.from(x)→[...x]). - Bundled prerequisite MiniMax template wiring (PM-993): preserve agent workflow connections after dynamic input reordering #17221 is merged on
main(4e497de33e) and a genuine ancestor of fix(agent-crdt): realign named input links across multiple autogrow groups #18275 there.
At the merge result onto the current tip: pnpm typecheck, pnpm typecheck:browser, pnpm knip:no-cache, oxfmt --check and pnpm lint (0 errors) all clean; the touched unit suites pass 220 with 2 expected-fail pins.
Blocked: playwright-tests (cloud) exceeds its 15-minute job budget
e2e-status is FAILURE, and it is a required check — not covered by the branch's Vercel – billing-web-test exception, which waives that one status and nothing else. So this is not merged.
It is a timeout, not a test regression. ci-tests-e2e.yaml sets timeout-minutes: 15 on the playwright-tests matrix job. Both attempts died at the wall while still actively running tests:
| Head | cloud job | Result |
|---|---|---|
#18793 f49e6bce65 |
10:38:39 → 10:50:46 (~12m07s) | ✅ 231 tests, 227 passed (9.7m) |
#18782 03f7c40060 |
10:43:12 → 10:55:13 (~12m01s) | ✅ 231 tests |
| this PR attempt 1 | 11:10:47 → 11:25:54 (15m07s) | ✖ cancelled at the cap |
| this PR attempt 2 | same wall | ✖ cancelled at the cap |
Attempt 2 logged Running 233 tests using 2 workers and reached ~187 before The operation was canceled. No blob report was written, so the run produced no test-level verdict.
The cloud project on this branch already sits at ~12 of 15 minutes (80% of budget). This PR adds two @cloud-tagged tests (agentCrdtMultiAutogrowRealign.spec.ts, tagged ['@cloud', '@agent', '@vue-nodes']) plus retry churn, which tips it over. Re-running is not a fix — it failed identically twice.
What would unblock it
One of, and all of them are owning-team calls rather than this row's:
- Raise
timeout-minuteson theplaywright-testsmatrix job in.github/workflows/ci-tests-e2e.yaml:130for this branch — the cheapest fix, and the budget is genuinely too tight at 80% baseline. - Shard the
cloudproject the waychromiumis already sharded (16 ways). - Make the new spec cheaper, or drop its
@cloudtag if chromium coverage is sufficient.
Note this is a pre-existing budget problem this carrier exposes, not one it created — any PR adding a @cloud test on core/1.54 will hit the same wall.
Also still true: the PR is 2 commits behind (untested delta = #18793 + #18782, zero file overlap per the gate's own advisory, and verified clean locally at the merge result). That part is a recorded-judgment matter; the e2e-status failure is not, and is the reason this stays open.
Receipt: reports/jobs/bp-3.md.
…nutes (#18852) ## Summary Backport of [#17398](#17398) (`21750678e3`) — raises the `playwright-tests` job timeout from 15 to 30 minutes. `cloud/1.54` never received it because the branch was cut four days before it landed. ## Changes - **What**: `timeout-minutes: 15` -> `30` on the `playwright-tests` job. Two lines, clean cherry-pick, workflow-only. - **Breaking**: none. ## Review Focus **Why this branch is missing the fix.** `cloud/1.54` and `core/1.54` were both cut from `main` at `a15c5351b` on 2026-09-07. #17398 merged on 2026-09-11. `core/1.55` and `cloud/1.55` were cut 2026-09-23 and do carry it. The 1.54 pair are the only active branches still at 15 minutes, purely by cut date. **This branch has the same exposure.** `playwright-tests (cloud)` on [#18694](#18694 run [35965823183](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35965823183) took **708s — 79% of the 900s cap** on a passing run. Its sibling branch `core/1.54` sits in the same 62-78% band and has already lost a PR to this: [#18512](#18512) is blocked on required check `e2e-status` because the cloud job is cancelled at 15m07s, twice, with no blob report and therefore no test-level verdict. A cancelled required check reads as a real test failure. With ~3 minutes of slack and 1-2 ordinarily-flaky tests per run under `retries: 3`, one bad burst is enough. Pre-empting it here rather than after it blocks an agent backport on this branch too. **Note for whoever approves:** `backport-auto-merge.yaml` merges `backport`-labelled PRs on approval once required checks are green, so approving this is merging it. **Companions:** [#18851](#18851) is the same backport to `core/1.54`. [#18850](#18850) shards the cloud project on `main`, where the job is now at 20.3 of its 30 minutes and growing ~1.3 min/day — so the timeout does not need raising a third time.
…utes (#18851) ## Summary Backport of [#17398](#17398) (`21750678e3`) — raises the `playwright-tests` job timeout from 15 to 30 minutes. `core/1.54` never received it because the branch was cut four days before it landed. ## Changes - **What**: `timeout-minutes: 15` -> `30` on the `playwright-tests` job. Two lines, clean cherry-pick, workflow-only. - **Breaking**: none. ## Review Focus **Why this branch is missing the fix.** `core/1.54` and `cloud/1.54` were both cut from `main` at `a15c5351b` on 2026-09-07. #17398 merged on 2026-09-11. `core/1.55` and `cloud/1.55` were cut 2026-09-23 and do carry it. So the 1.54 pair are the only active branches still at 15 minutes, purely by cut date — not by decision. **The branch has no usable slack at 15 minutes.** `playwright-tests (cloud)` on recent `core/1.54` runs: | run | cloud job | % of the 900s cap | |---|---|---| | [36062187628](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36062187628) | 701s | 78% | | [36127290454](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36127290454) | 697s | 77% | | [36117634179](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36117634179) | 623s | 69% | | [36119756279](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36119756279) | 615s | 68% | | [36130212622](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36130212622) | 561s | 62% | That is 62-78% consumed on a *passing* run, leaving roughly three minutes of headroom. Those same passing runs each carry 1-2 flaky tests that recover on retry, which is normal — but with `retries: 3` and a 15s per-test timeout, one bad burst costs more than the remaining slack. The result is a **cancelled** job, and a cancelled required check is indistinguishable from a real test failure to anyone reading the PR. **What it is blocking now.** [#18512](#18512) — the last carrier in a merged chain of user-visible agent fixes — is stuck on required check `e2e-status` for exactly this. Its run [36126194869](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36126194869) was killed at 15m07s with 181 of 233 results emitted and no blob report written, so there is no test-level verdict at all. Re-running was tried twice and failed identically. Every other matrix job in that run passed in 157-218s; only `cloud` died. This is not one PR's problem: any `core/1.54` PR that adds a `@cloud` test hits the same wall. **Note for whoever approves:** `backport-auto-merge.yaml` merges `backport`-labelled PRs on approval once required checks are green, so approving this is merging it. **Related, not included here:** `cloud/1.54` has the identical gap and the same exposure (708s = 79% of cap on [#18694](#18694 run) — see the companion backport. And on `main`, where this job is now at 20.3 of its 30 minutes and growing, [#18850](#18850) shards the cloud project so the timeout does not need raising a third time.
|
The 15-minute cap is cleared. This PR is still blocked — on the merits, and there is now a real test-level verdict for the first time. #18851 merged to What changed
The two failures are this PR's own new specBoth fail at the same line of the same helper, on every attempt including all retries:
It is specific to
|
…so 'server' reaches the backend catalog (#18860) ## Summary Backports the **test-fixture subset** of #17730 to `core/1.54`: `bootAgentApp` now passes `objectInfo` through to `mockCloudBoot`, so `objectInfo: 'server'` stops being swallowed and the empty `{}` `/api/object_info` mock is no longer registered last (Playwright runs the most-recently-registered matching route first, so that empty mock was shadowing every node-def route a harness registers before boot). ## Changes - **What**: `browser_tests/fixtures/agentPanelFixture.ts` + `browser_tests/fixtures/utils/cloudBootMocks.ts` — the exact fixture hunks `cloud/1.54` received inside #18550 (manual backport of #17730, source squash `7806755421`). Byte-identical to both `cloud/1.54` and `main` after this change. **Test infrastructure only** — no `src/` changes; the #17730 product feature stays excluded from `core/1.54` exactly as #18631 recorded ("core lacks its three files"). ## Review Focus This is the root cause of the two deterministic failures blocking #18512 (run [36138115446](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36138115446)): `agentCrdtMultiAutogrowRealign.spec.ts` boots with `objectInfo: 'server'` and registers its node defs before boot, which only works with the post-#17730 fixture semantics. On this branch the app booted with an **empty node catalog**, `LiteGraph.createNode` returned null for the fixture types, the CRDT materializer fell back to `missingNode()`, and the target node rendered slots but zero widgets — hence no `textbox "prompt"`. This is a test-env artifact, **not** a product accessibility divergence: with the catalog actually served, `core/1.54` renders the prompt textarea with the correct accessible name. Local verification at `core/1.54` + #18512 carrier head: - Both `agentCrdtMultiAutogrowRealign` tests: red before this change, **green after** (1.8s / 4.5s). - Full `--project=cloud` suite: 225 passed; the 6 local failures are identical with and without this change (pre-existing local-env artifacts, all green in CI baseline). - `typecheck:browser`, `eslint`, `oxfmt --check`: clean.
|
Recorded merge judgment (program-authorized 1.54 backport flow)
|
…xture helper (#17403) (#18876) ## Summary Restores fixture-contract parity with `main` and `cloud/1.54`: adds the `NodeSlotReference.expectLinkCount` helper from #17403 to `browser_tests/fixtures/utils/litegraphUtils.ts`. The file is **byte-identical to both `origin/main` and `origin/cloud/1.54`** (blob `d3a1e76d0e`). ## Why Program audit row `bpaudit-1` (silently-dropped backport collateral, follow-up to the #17730/#18860 fixture-semantics incident) found this as the one remaining undecided test-infrastructure divergence on the 1.54 pair: - `cloud/1.54` received this exact hunk as a hand-carried adaptation inside #18257 because a picked spec needed it. - `core/1.54` never received #17403 by any route, so the next spec backport written against main's fixture contract that calls `expectLinkCount` fails on core only — the same failure shape that cost three days on #18512 (see #18860). ## Scope - Test infrastructure only: one fixture method, 3 lines, no product code. - No consumer on this branch yet; `getLinkCount` (which it wraps) already exists here. - No behavior change to any existing test. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
<!-- ccr-slack-attribution -->
Requested by Christian Byrne · Slack thread
Summary
Manual backport of #18275 to
core/1.54, following the same pattern proven for thecloud/1.54backport (#18479).STACKED ON #18509 — do not merge this before #18509 merges. This branch is based on
backport-17221-to-core-1.54(#18509's head), not onorigin/core/1.54directly, becausecore/1.54proper still resolves agent CRDT inputs positionally and lacks the name-based input-targeting architecture from #17221 that #18275 builds directly on top of (mergeInputSlotsByName/hasNonGrowthInputSetChangeingraphMutations.ts). Once #18509 merges intocore/1.54, this PR's base should be retargeted/rebased ontocore/1.54before merging.Conflict resolution notes
browser_tests/fixtures/agentConversationFixture.ts: dropped. Doesn't exist on this branch (added by still-unbackported fix(models): answer the switch question when the run answers it first #17875); nothing here imports it, including the newagentCrdtMultiAutogrowRealign.spec.ts(only comment references, no real import).src/lib/litegraph/src/LGraphCanvas.ts(selectItems): kept this branch's existing body. The only diff was an unrelatedArray.from→ spread refactor from feat: add selectionStore and derive canvasStore selection (FE-2040) #17048'sownsSelectablefilter, which isn't on this branch (ownsSelectabledoesn't exist anywhere insrc/).src/core/graph/widgets/dynamicWidgets.ts,AgentPanelRoot.vue: additive conflicts, took the incoming side. Dropped an incominguseSettingStoreimport inAgentPanelRoot.vue(belongs to unbackported feat(agent): show graph activity while the agent writes nodes #17730, unused here).src/workbench/extensions/agent/crdt/graphMutations.ts: took the new by-nameconnect/commitUpsertNodehandlers wholesale (the actual fix). Uncovered missing dependency:linkPresentationStore(from unbackported fix(models): answer the switch question when the run answers it first #17875). Portedsrc/types/linkPresentation.tsandsrc/stores/linkPresentationStore.ts(+ unit test) frommain, and wiredconst linkPresentationStore = useLinkPresentationStore().graphMutations.test.ts: same missing-dependency shape;useLinkPresentationStoreimport ended up unused in the test file, removed it.Additional gaps beyond the cloud/1.54 backport's notes (found and verified, not just copied)
browser_tests/fixtures/agentFollowerHostSocket.tswas missing (needed by the newMultiAutogrowRealignHarness.ts). Ported verbatim frommain, which required exportingDOC_PROTOCOL_VERSIONfromdocFrameClient.ts(it was a localconst).commitUpsertNode's call toapplyWidgetValuesused a 5thguardLocalEditsargument that only exists onmainvia unbackported PR fix(agent): don't let CRDT reconcile clobber a fresher live widget value #18361 (the "local-edit guard" feature, already oncloud/1.54via [backport cloud/1.54] fix(agent): preserve fresher live widget values during CRDT reconcile #18423 but not oncore/1.54). Dropped the extra argument to match this branch's existing 4-parameterapplyWidgetValues— this guard is unrelated to fix(agent-crdt): realign named input links across multiple autogrow groups #18275's actual fix (named-link realignment), so dropping it doesn't affect this PR's mechanism; it just means core/1.54 doesn't yet get fix(agent): don't let CRDT reconcile clobber a fresher live widget value #18361's separate improvement.zAutogrowOptionsimport ingraphMutations.ts: verified this already resolves fine —@/schemas/nodeDefSchemare-exports@comfyorg/object-info-parser, which already defines it. Not a gap.zComfyApiWorkflowinworkflowSchema.ts(used by the newMultiAutogrowRealignHarness.ts): wasn't exported on this branch (onlyComfyApiWorkflowthe type was). Exported it, matching howmainalready exports it.MultiAutogrowRealignHarness.ts/savedWorkflowPersistence.tsimportedPromptResponse/UserDataFullInfofrom@/platform/remote/comfyui/types, a module that doesn't exist on this older branch. Both types live in@/schemas/apiSchemahere; fixed the import paths.reconcileAutogrowInputs(new additive export indynamicWidgets.ts) has no caller on this branch — its only call site onmainis inagentNodeMaterializer.ts, added by a separate, unbackported PR (not fix(agent-crdt): realign named input links across multiple autogrow groups #18275's own diff, and not MiniMax template wiring (PM-993): preserve agent workflow connections after dynamic input reordering #17221's either). Dropped it as dead code rather than smuggling in that unrelated PR's wiring.Verification
pnpm typecheck— cleanpnpm exec eslinton all changed files — cleanpnpm exec oxfmt --checkon all changed files — clean, all correctly formattedpnpm knip— cleanpnpm vitest runongraphMutations.test.ts,dynamicWidgets.test.ts,linkStore.test.ts,nodeDataStore.test.ts,linkPresentationStore.test.ts,crdtSession.test.ts,agentNodeMaterializer.multiAutogrow.test.ts— 7 files, 198 passed / 1 expected failpnpm exec playwright test --list— collects cleanly, no@e2e/fixturesresolution errors (2237 tests / 367 files total, including the 2 new specs inagentCrdtMultiAutogrowRealign.spec.ts)Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01XqLXka9Jsg8EMTYmsnZjjv
🤖 Generated with Claude Code
https://claude.ai/code/session_01XqLXka9Jsg8EMTYmsnZjjv
Generated by Claude Code