Repository navigation
[backport core/1.54] fix(ci): restore missing @/platform/remote/comfyui/types - #18823
Conversation
The #18722 backport carrier (68fc0f6) landed agentDuplicateWorkflowNameBinding.spec.ts without src/platform/remote/comfyui/types.ts, which exists on main (added in #17789). The missing module has failed typecheck-aux (TS2307) and repo-checks (knip unresolved import) on every PR against this branch since, turning the required lint-and-format check red branch-wide. Backport only the UserDataFullInfo type the spec imports; the rest of main's module has no consumer on this branch and would fail knip's unused-export check.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1954 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-25T09:04:32.847Z",
"gitSha": "9aa20ab9043870439db3108b76140539995c0781",
"branch": "backport-18722-types-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2085.222999999985,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.705000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.473,
"heapDeltaBytes": -4934948,
"heapUsedBytes": 64761820,
"domNodes": -271,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 13.436,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2046.6159999999718,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.857,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.66599999999994,
"heapDeltaBytes": -13040676,
"heapUsedBytes": 56492680,
"domNodes": 4,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.013000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1736.3730000000146,
"styleRecalcs": 73,
"styleRecalcDurationMs": 26.002,
"layouts": 14,
"layoutDurationMs": 3.7630000000000003,
"taskDurationMs": 792.3789999999999,
"heapDeltaBytes": -4206868,
"heapUsedBytes": 67108652,
"domNodes": -282,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 128.49099999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1747.1779999999626,
"styleRecalcs": 73,
"styleRecalcDurationMs": 24.118000000000002,
"layouts": 14,
"layoutDurationMs": 3.441,
"taskDurationMs": 722.652,
"heapDeltaBytes": -4611844,
"heapUsedBytes": 65833292,
"domNodes": -281,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 125.67600000000002,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1674.6860000000083,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.133000000000001,
"layouts": 6,
"layoutDurationMs": 0.928,
"taskDurationMs": 334.37,
"heapDeltaBytes": 4270360,
"heapUsedBytes": 75343564,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 13.003000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1671.0950000000366,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.713,
"layouts": 6,
"layoutDurationMs": 0.9009999999999999,
"taskDurationMs": 290.911,
"heapDeltaBytes": 4665940,
"heapUsedBytes": 75734020,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 9.900999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 572.8599999999915,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.276999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.397,
"heapDeltaBytes": -7940668,
"heapUsedBytes": 62927484,
"domNodes": 20,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 129.49099999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 568.7669999999798,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.2379999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.027,
"heapDeltaBytes": 17746856,
"heapUsedBytes": 88342320,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 132.82300000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2024.8619999999846,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.419,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 629.902,
"heapDeltaBytes": 8140532,
"heapUsedBytes": 84844348,
"domNodes": -270,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 32.899,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2057.502999999997,
"styleRecalcs": 7,
"styleRecalcDurationMs": 11.695,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 523.449,
"heapDeltaBytes": 8678024,
"heapUsedBytes": 85053636,
"domNodes": -272,
"jsHeapTotalBytes": -364544,
"scriptDurationMs": 32.214000000000006,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2415.777999999989,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.764999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1503.6600000000003,
"heapDeltaBytes": 11455584,
"heapUsedBytes": 88537020,
"domNodes": -278,
"jsHeapTotalBytes": -663552,
"scriptDurationMs": 686.909,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2143.8940000000457,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.463999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1354.962,
"heapDeltaBytes": 8617780,
"heapUsedBytes": 86444832,
"domNodes": -273,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 665.334,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3583.4800000000087,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.291,
"layouts": 60,
"layoutDurationMs": 12.603,
"taskDurationMs": 1632.932,
"heapDeltaBytes": -7254092,
"heapUsedBytes": 71804812,
"domNodes": -288,
"jsHeapTotalBytes": 4091904,
"scriptDurationMs": 693.195,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3191.3749999999936,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.080999999999998,
"layouts": 60,
"layoutDurationMs": 11.565000000000001,
"taskDurationMs": 1367.9510000000002,
"heapDeltaBytes": 8513316,
"heapUsedBytes": 76208504,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 609.665,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2700.7600000000025,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.127000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1723.1349999999998,
"heapDeltaBytes": 17916592,
"heapUsedBytes": 85583628,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 818.249,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2430.7979999999816,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.452000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1620.0679999999998,
"heapDeltaBytes": 4435212,
"heapUsedBytes": 85220444,
"domNodes": -276,
"jsHeapTotalBytes": -1257472,
"scriptDurationMs": 777.6050000000001,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2005.548000000033,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.2900000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 509.737,
"heapDeltaBytes": 21661928,
"heapUsedBytes": 88745156,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.33600000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2008.301000000074,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.271000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.8050000000001,
"heapDeltaBytes": 21649520,
"heapUsedBytes": 88675972,
"domNodes": 10,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 29.050000000000008,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 555.6819999999902,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 376.61,
"heapDeltaBytes": 14164436,
"heapUsedBytes": 86814736,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 123.80300000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 513.4890000000496,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.347999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 334.82500000000005,
"heapDeltaBytes": 14242512,
"heapUsedBytes": 86748628,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 112.97299999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2039.9590000000103,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.748999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.22900000000004,
"heapDeltaBytes": 5662844,
"heapUsedBytes": 78677416,
"domNodes": -296,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.353000000000002,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2017.6379999999199,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.1259999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.38000000000005,
"heapDeltaBytes": 5954812,
"heapUsedBytes": 79344100,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 7.017,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1758.9179999999942,
"styleRecalcs": 77,
"styleRecalcDurationMs": 24.816000000000003,
"layouts": 18,
"layoutDurationMs": 4.272,
"taskDurationMs": 723.797,
"heapDeltaBytes": -6719576,
"heapUsedBytes": 66675040,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 93.559,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.890000000063,
"styleRecalcs": 77,
"styleRecalcDurationMs": 22.792,
"layouts": 18,
"layoutDurationMs": 4.07,
"taskDurationMs": 686.767,
"heapDeltaBytes": 1117944,
"heapUsedBytes": 73599892,
"domNodes": -297,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 95.524,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 883.878999999979,
"styleRecalcs": 19,
"styleRecalcDurationMs": 25.084000000000003,
"layouts": 15,
"layoutDurationMs": 11.843000000000002,
"taskDurationMs": 709.5259999999998,
"heapDeltaBytes": 22570928,
"heapUsedBytes": 104433228,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 22.413000000000004,
"eventListeners": 2385,
"totalBlockingTimeMs": 88,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9077.584000000003,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.746,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5235.445,
"heapDeltaBytes": 8821748,
"heapUsedBytes": 84994444,
"domNodes": -268,
"jsHeapTotalBytes": 385024,
"scriptDurationMs": 2246.8529999999996,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8383.85900000003,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.731,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4787.864,
"heapDeltaBytes": 13397596,
"heapUsedBytes": 89274148,
"domNodes": -270,
"jsHeapTotalBytes": -663552,
"scriptDurationMs": 2155.0119999999997,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15142.743999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14662.626000000002,
"heapDeltaBytes": -38954056,
"heapUsedBytes": 178801932,
"domNodes": -8068,
"jsHeapTotalBytes": -11792384,
"scriptDurationMs": 224.98399999999998,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15139.76100000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14673.503,
"heapDeltaBytes": -61343848,
"heapUsedBytes": 176478332,
"domNodes": -8068,
"jsHeapTotalBytes": -16756736,
"scriptDurationMs": 259.31100000000004,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 17840.77100000002,
"styleRecalcs": 130,
"styleRecalcDurationMs": 14.91400000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17480.767,
"heapDeltaBytes": -29214064,
"heapUsedBytes": 188822580,
"domNodes": -8068,
"jsHeapTotalBytes": -11587584,
"scriptDurationMs": 724.1850000000001,
"eventListeners": -14931,
"totalBlockingTimeMs": 3,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17633.196999999996,
"styleRecalcs": 130,
"styleRecalcDurationMs": 15.22799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17414.357,
"heapDeltaBytes": -55181724,
"heapUsedBytes": 165183616,
"domNodes": -8068,
"jsHeapTotalBytes": -11313152,
"scriptDurationMs": 750.2090000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 13,
"frameDurationMs": 17.216666666666665,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5417.040000000043,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.807,
"layouts": 20,
"layoutDurationMs": 33.71,
"taskDurationMs": 5319.103999999999,
"heapDeltaBytes": -63227148,
"heapUsedBytes": 179032972,
"domNodes": -8068,
"jsHeapTotalBytes": 3211264,
"scriptDurationMs": 91.28599999999999,
"eventListeners": -14931,
"totalBlockingTimeMs": 432,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5363.849999999957,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.01399999999997,
"layouts": 20,
"layoutDurationMs": 32.17,
"taskDurationMs": 5286.937,
"heapDeltaBytes": -32284640,
"heapUsedBytes": 176960368,
"domNodes": -8097,
"jsHeapTotalBytes": 13668352,
"scriptDurationMs": 91.287,
"eventListeners": -14931,
"totalBlockingTimeMs": 308,
"frameDurationMs": 18.329999999999988,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7467.950999999971,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7294.809000000001,
"heapDeltaBytes": 14168848,
"heapUsedBytes": 177873380,
"domNodes": 0,
"jsHeapTotalBytes": -19922944,
"scriptDurationMs": 109.77600000000004,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7522.870000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7438.995,
"heapDeltaBytes": -19620304,
"heapUsedBytes": 163616888,
"domNodes": 0,
"jsHeapTotalBytes": -24641536,
"scriptDurationMs": 124.1,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 462.19700000006014,
"styleRecalcs": 12,
"styleRecalcDurationMs": 16.477,
"layouts": 3,
"layoutDurationMs": 0.8079999999999999,
"taskDurationMs": 104.199,
"heapDeltaBytes": 4782480,
"heapUsedBytes": 73827204,
"domNodes": 122,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.321999999999998,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 78.63399999996545,
"styleRecalcs": 6,
"styleRecalcDurationMs": 9.785000000000002,
"layouts": 2,
"layoutDurationMs": 0.606,
"taskDurationMs": 54.42899999999999,
"heapDeltaBytes": 2997892,
"heapUsedBytes": 72018220,
"domNodes": 104,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 3.556,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.799999999999727
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #18823 +/- ##
=============================================
- Coverage 83.77% 83.76% -0.01%
=============================================
Files 2104 2104
Lines 124691 124691
Branches 33436 31573 -1863
=============================================
- Hits 104458 104451 -7
- Misses 20054 20061 +7
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Backport-grant review (program row corefix-1, authenticated as the author, so COMMENT not APPROVE — per program/release-backport-authority.md, Christian's September 16 grant covering core/1.54 and cloud/1.54 carriers).
Reviewed head: 45b12836974baed5763d435a6152d0a08d7217e4
Diff review: one added file, src/platform/remote/comfyui/types.ts, containing only the UserDataFullInfo type that agentDuplicateWorkflowNameBinding.spec.ts (landed by #18722 without its dependency) imports. Deliberately narrower than main's module: the other exports have no consumer on this branch and would fail knip's unused-export check.
Evidence: red-on-parent (TS2307 at spec line 10) / green-with-fix via pnpm typecheck:browser; pnpm typecheck, pnpm knip:no-cache, eslint, oxfmt all clean locally. Required checks at this head: lint-and-format ✅ (first green on core/1.54 since #18722), test ✅, e2e-status ✅.
Recorded judgment on the sole adverse signal: Vercel – billing-web-test is a commit status failing identically on every core/1.54 PR (verified on #18655, #18670, #18673, #18722, #18810, #18811, including pre-break merges) — a branch-wide Vercel git-integration artifact with zero file overlap with this type-only diff. scripts/check-merge-ready.sh --target-branch core/1.54 refusal on that status is recorded in the program receipt (reports/jobs/corefix-1.md); merging on explicit judgment per the program's exact-head policy.
Summary
The #18722 backport carrier (
68fc0f639e) landedbrowser_tests/tests/agent/agentDuplicateWorkflowNameBinding.spec.tswithoutsrc/platform/remote/comfyui/types.ts. That module exists onmain(added in #17789) but not oncore/1.54, so every PR againstcore/1.54since has failed the requiredlint-and-formatcheck identically:(
typecheck-auxTS2307 +repo-checksknip unresolved import →lint-and-formatgate red.)This backports only the
UserDataFullInfotype the spec imports. The rest ofmain's module has no consumer on this branch and would fail knip's unused-export check.cloud/1.54does not need this fix: its copy of the spec was adapted during cherry-pick to importUserDataFullInfofrom@/schemas/apiSchema, which still exists there;typecheck:browserandknipare clean oncloud/1.54as-is, and adding this file there fails knip (unused file).Verification
pnpm typecheck:browseroncore/1.54fails with the TS2307 above; green with this commit.pnpm typecheck,pnpm typecheck:browser,pnpm knip:no-cache, eslint + oxfmt on the new file: all clean locally.Unblocks #18810 and #18811 (P0 backport carriers).
🤖 Generated with Claude Code