Repository navigation
[backport core/1.54] fix(agent): derive paywall visibility from current billing state (#18590) - #18811
Conversation
) ## Summary Keep recorded paywall denials in the conversation store while tracking which paywall turns a later funded billing update has resolved. This avoids treating the current billing snapshot as the state of every historical denial: - a fresh 402 remains visible even when the cached subscription still says funds are available; - a later funded billing update hides paywalls that were already present; - a transient `subscription: null` does not restore resolved cards; and - running out of funds again leaves old cards hidden while a new denial appears normally. ## Changes - Replace destructive paywall removal with a private set of resolved paywall turn IDs. - Derive visible conversation entries from recorded messages and that resolution set. - Resolve existing paywalls when the subscription emits a funded update. Unknown and unfunded updates do not change prior resolutions. - Reset resolution state with the conversation lifecycle. - Remove the global `hasFunds` projection helper and its synthetic hydration cases. Persisted transcript normalization does not produce paywall parts. The store action changes from `setPaywallsResolved(boolean)` to `resolvePaywalls()`. The agent panel is its only caller. ## Verification - `pnpm test:unit src/workbench/extensions/agent/AgentPanelRoot.test.ts src/workbench/extensions/agent/stores/agent/agentConversationStore.test.ts` (291 passed) - `pnpm typecheck` - targeted ESLint and oxfmt checks on all changed files - `git diff --check` The cloud E2E paywall tests failed on the previous head because the fresh denial card was hidden. This update adds component coverage for that sequence; CI will exercise the existing cloud specs on the pushed head. --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: Christian Byrne <cbyrne@comfy.org>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1952 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-25T09:30:03.410Z",
"gitSha": "e5217b593ca28472733e355b452769e309b03957",
"branch": "backport-18590-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2071.595000000002,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.2970000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.56,
"heapDeltaBytes": 596208,
"heapUsedBytes": 64840304,
"domNodes": 14,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 11.183000000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2028.872999999976,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.034,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 549.227,
"heapDeltaBytes": -9988356,
"heapUsedBytes": 60240392,
"domNodes": -283,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.779000000000002,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2170.831000000021,
"styleRecalcs": 81,
"styleRecalcDurationMs": 37.881,
"layouts": 14,
"layoutDurationMs": 4.761,
"taskDurationMs": 1115.267,
"heapDeltaBytes": -6783160,
"heapUsedBytes": 63582748,
"domNodes": -285,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 198.28699999999998,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1945.19600000001,
"styleRecalcs": 78,
"styleRecalcDurationMs": 37.492999999999995,
"layouts": 14,
"layoutDurationMs": 4.6499999999999995,
"taskDurationMs": 958.4370000000001,
"heapDeltaBytes": 8775276,
"heapUsedBytes": 79014128,
"domNodes": -282,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 171.41400000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.2189999999678,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.093,
"layouts": 6,
"layoutDurationMs": 1.2,
"taskDurationMs": 451.796,
"heapDeltaBytes": 4634260,
"heapUsedBytes": 75763892,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 16.326,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1756.3780000000406,
"styleRecalcs": 32,
"styleRecalcDurationMs": 20.602000000000004,
"layouts": 6,
"layoutDurationMs": 1.3110000000000002,
"taskDurationMs": 430.818,
"heapDeltaBytes": 4317668,
"heapUsedBytes": 74341616,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 14.661999999999997,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 686.555999999996,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.927999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.41499999999996,
"heapDeltaBytes": -7860468,
"heapUsedBytes": 63289720,
"domNodes": 18,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 164.525,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 756.5759999999955,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.725,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.8809999999999,
"heapDeltaBytes": -7896408,
"heapUsedBytes": 63263012,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 177.093,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2059.7360000000435,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.384,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 696.2350000000001,
"heapDeltaBytes": 10586164,
"heapUsedBytes": 86845676,
"domNodes": -272,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 35.84000000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2071.86999999999,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.938999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 700.433,
"heapDeltaBytes": 5067996,
"heapUsedBytes": 81830092,
"domNodes": -278,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 38.15200000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2881.857000000025,
"styleRecalcs": 66,
"styleRecalcDurationMs": 14.124999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1879.918,
"heapDeltaBytes": 15866664,
"heapUsedBytes": 93290980,
"domNodes": -272,
"jsHeapTotalBytes": -2236416,
"scriptDurationMs": 908.483,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2726.1219999999184,
"styleRecalcs": 67,
"styleRecalcDurationMs": 16.466,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1865.2420000000002,
"heapDeltaBytes": 7180132,
"heapUsedBytes": 84698744,
"domNodes": -252,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 903.6909999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 4135.081000000014,
"styleRecalcs": 63,
"styleRecalcDurationMs": 14.849999999999998,
"layouts": 60,
"layoutDurationMs": 14.251000000000001,
"taskDurationMs": 2020.74,
"heapDeltaBytes": -9080796,
"heapUsedBytes": 69998932,
"domNodes": -290,
"jsHeapTotalBytes": 1994752,
"scriptDurationMs": 876.294,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4006.25100000002,
"styleRecalcs": 63,
"styleRecalcDurationMs": 14.967,
"layouts": 60,
"layoutDurationMs": 13.546,
"taskDurationMs": 1975.188,
"heapDeltaBytes": -6349428,
"heapUsedBytes": 72433992,
"domNodes": -256,
"jsHeapTotalBytes": -888832,
"scriptDurationMs": 900.166,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3355.612000000008,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.890000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2172.799,
"heapDeltaBytes": 22178588,
"heapUsedBytes": 90004124,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1077.197,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3147.6670000000695,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.393000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2055.1940000000004,
"heapDeltaBytes": 25180220,
"heapUsedBytes": 92646912,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1013.8910000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2091.167999999982,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.7589999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 824.873,
"heapDeltaBytes": 7060808,
"heapUsedBytes": 84369548,
"domNodes": -281,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 47.600000000000016,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2057.790999999952,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.201999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 706.059,
"heapDeltaBytes": 5617624,
"heapUsedBytes": 82567356,
"domNodes": -287,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 39.482000000000006,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 641.3879999999494,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.87,
"heapDeltaBytes": 14180624,
"heapUsedBytes": 86796060,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 147.783,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 644.7910000000547,
"styleRecalcs": 48,
"styleRecalcDurationMs": 14.942,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.586,
"heapDeltaBytes": 14220944,
"heapUsedBytes": 86711264,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 149.688,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2032.8349999999773,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.468000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.63,
"heapDeltaBytes": -5598444,
"heapUsedBytes": 67735776,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 11.037,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2018.0820000000494,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.416,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.902,
"heapDeltaBytes": -7061472,
"heapUsedBytes": 65434052,
"domNodes": -299,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 10.515,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1799.9710000000277,
"styleRecalcs": 77,
"styleRecalcDurationMs": 31.47,
"layouts": 18,
"layoutDurationMs": 5.193,
"taskDurationMs": 944.431,
"heapDeltaBytes": -7464072,
"heapUsedBytes": 65082928,
"domNodes": -295,
"jsHeapTotalBytes": 7331840,
"scriptDurationMs": 123.02499999999999,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1747.6910000000316,
"styleRecalcs": 78,
"styleRecalcDurationMs": 28.270000000000003,
"layouts": 18,
"layoutDurationMs": 4.713,
"taskDurationMs": 898.2510000000001,
"heapDeltaBytes": -813476,
"heapUsedBytes": 71754812,
"domNodes": -296,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 120.002,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1419.2620000000034,
"styleRecalcs": 18,
"styleRecalcDurationMs": 35.21000000000001,
"layouts": 14,
"layoutDurationMs": 15.59,
"taskDurationMs": 1004.013,
"heapDeltaBytes": -5527752,
"heapUsedBytes": 87746828,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 33.324999999999996,
"eventListeners": 2387,
"totalBlockingTimeMs": 150,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10972.720000000038,
"styleRecalcs": 245,
"styleRecalcDurationMs": 40.465999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6993.536,
"heapDeltaBytes": 14568852,
"heapUsedBytes": 91138928,
"domNodes": -277,
"jsHeapTotalBytes": -434176,
"scriptDurationMs": 3213.5420000000004,
"eventListeners": -140,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666673,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 9784.257000000025,
"styleRecalcs": 247,
"styleRecalcDurationMs": 41.425,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6421.127,
"heapDeltaBytes": 8633932,
"heapUsedBytes": 84936680,
"domNodes": -276,
"jsHeapTotalBytes": 90112,
"scriptDurationMs": 2905.0689999999995,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 19094.96399999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18629.746,
"heapDeltaBytes": -57703524,
"heapUsedBytes": 180404732,
"domNodes": -8068,
"jsHeapTotalBytes": -14594048,
"scriptDurationMs": 353.36899999999997,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18591.989000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18174.545000000002,
"heapDeltaBytes": -39202000,
"heapUsedBytes": 194852256,
"domNodes": -8068,
"jsHeapTotalBytes": -15421440,
"scriptDurationMs": 320.79,
"eventListeners": -14927,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 22158.972000000005,
"styleRecalcs": 175,
"styleRecalcDurationMs": 22.01000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21928.621,
"heapDeltaBytes": -30150316,
"heapUsedBytes": 182685308,
"domNodes": -8072,
"jsHeapTotalBytes": -16953344,
"scriptDurationMs": 1036.395,
"eventListeners": -14927,
"totalBlockingTimeMs": 103,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 23512.917000000016,
"styleRecalcs": 176,
"styleRecalcDurationMs": 25.428000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23317.693,
"heapDeltaBytes": -40819868,
"heapUsedBytes": 192335612,
"domNodes": -8068,
"jsHeapTotalBytes": -21069824,
"scriptDurationMs": 1149.881,
"eventListeners": -14927,
"totalBlockingTimeMs": 264,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6629.565000000013,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.43400000000001,
"layouts": 20,
"layoutDurationMs": 24.145999999999987,
"taskDurationMs": 6543.6630000000005,
"heapDeltaBytes": -46939868,
"heapUsedBytes": 176341824,
"domNodes": -8068,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 123.554,
"eventListeners": -14927,
"totalBlockingTimeMs": 512,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6734.737000000109,
"styleRecalcs": 20,
"styleRecalcDurationMs": 85.75099999999996,
"layouts": 20,
"layoutDurationMs": 25.132,
"taskDurationMs": 6639.4890000000005,
"heapDeltaBytes": -37588800,
"heapUsedBytes": 180832644,
"domNodes": -8068,
"jsHeapTotalBytes": 11522048,
"scriptDurationMs": 146.491,
"eventListeners": -14931,
"totalBlockingTimeMs": 484,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9544.042999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9405.045000000002,
"heapDeltaBytes": 2220784,
"heapUsedBytes": 179566060,
"domNodes": 0,
"jsHeapTotalBytes": -18350080,
"scriptDurationMs": 169.33200000000005,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9260.378000000059,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9000.328,
"heapDeltaBytes": 7130508,
"heapUsedBytes": 179546128,
"domNodes": 0,
"jsHeapTotalBytes": -9437184,
"scriptDurationMs": 160.841,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 109.10799999999199,
"styleRecalcs": 9,
"styleRecalcDurationMs": 14.620000000000001,
"layouts": 3,
"layoutDurationMs": 1.269,
"taskDurationMs": 78.02599999999998,
"heapDeltaBytes": 3200912,
"heapUsedBytes": 72449884,
"domNodes": 111,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.697999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 123.36899999991147,
"styleRecalcs": 7,
"styleRecalcDurationMs": 16.331000000000003,
"layouts": 2,
"layoutDurationMs": 0.9089999999999999,
"taskDurationMs": 79.199,
"heapDeltaBytes": 3016224,
"heapUsedBytes": 71545020,
"domNodes": 106,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.458000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
This comment has been minimized.
This comment has been minimized.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #18811 +/- ##
============================================
Coverage 83.77% 83.77%
============================================
Files 2104 2104
Lines 124691 124697 +6
Branches 33436 31572 -1864
============================================
+ Hits 104455 104465 +10
+ Misses 20057 20053 -4
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Held, not stalled —
That spec arrived on This carrier changes two files, neither under Unblocking condition: either backport The same two fixes are already landed on |
…ui/types (#18823) ## Summary The #18722 backport carrier (`68fc0f639e`) landed `browser_tests/tests/agent/agentDuplicateWorkflowNameBinding.spec.ts` without `src/platform/remote/comfyui/types.ts`. That module exists on `main` (added in #17789) but not on `core/1.54`, so every PR against `core/1.54` since has failed the required `lint-and-format` check identically: ``` browser_tests/tests/agent/agentDuplicateWorkflowNameBinding.spec.ts(10,39): error TS2307: Cannot find module '@/platform/remote/comfyui/types' ``` (`typecheck-aux` TS2307 + `repo-checks` knip unresolved import → `lint-and-format` gate red.) This backports **only the `UserDataFullInfo` type the spec imports**. The rest of `main`'s module has no consumer on this branch and would fail knip's unused-export check. `cloud/1.54` does **not** need this fix: its copy of the spec was adapted during cherry-pick to import `UserDataFullInfo` from `@/schemas/apiSchema`, which still exists there; `typecheck:browser` and `knip` are clean on `cloud/1.54` as-is, and adding this file there fails knip (unused file). ## Verification - Red on parent: `pnpm typecheck:browser` on `core/1.54` fails with the TS2307 above; green with this commit. - `pnpm typecheck`, `pnpm typecheck:browser`, `pnpm knip:no-cache`, eslint + oxfmt on the new file: all clean locally. Unblocks #18810 and #18811 (P0 backport carriers). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
christian-byrne
left a comment
There was a problem hiding this comment.
Backport-grant review (program rows bp-1/corefix-1; authenticated as the author, so COMMENT not APPROVE — per program/release-backport-authority.md, Christian's September 16 grant for core/1.54 carriers).
Reviewed head: 41366f58f2285febfa87cf5c7112431a1b19dd41 (base refreshed onto the #18823 branch repair).
Diff review vs source #18590: AgentPanelRoot.vue, agentConversationStore.ts, agentConversationStore.test.ts byte-identical to source; AgentPanelRoot.test.ts differs only by the documented toTurnId import-line adaptation. Marker evidence (resolvedPaywallIds 0→6, setPaywallsResolved 2→0) in the carrier body; app typecheck green at this head confirms compilability of the export-block resolution.
Checks at this head: lint-and-format ✅, test ✅, e2e-status ✅.
Recorded judgment on the two gate refusals:
- Staleness: head is 1 commit behind
core/1.54— the untested delta is exactly #18810 (94e5101d9b,crdt/graphMutations.{ts,test.ts}).check-merge-ready.shadvisory: ZERO file overlap with this diff (agent panel + conversation store). The delta cannot interact. Vercel – billing-web-test: commit status failing identically on every core/1.54 PR (verified #18655, #18670, #18673, #18722, #18810, #18823) — branch-wide Vercel git-integration artifact, no overlap with this diff. Same judgment recorded on #18823's merge; flagged to the operator in reports/jobs/corefix-1.md.
P0: paywall persists after payment; QA-unblocking priority.
Backport of #18590 to
core/1.54. Original authorship and commit message preserved (cherry-pick of the squashed merge commit, not a re-authored patch).Why
The paywall card persists after payment — the user pays, stays blocked, and is told to add credits again. The fix stops treating the current billing snapshot as the state of every historical denial: recorded paywall denials stay in the store and a separate set tracks which turns a later funded billing update has resolved.
core/1.54is the train published to PyPI ascomfyui-frontend-package(latest:1.54.7), i.e. the Local/Desktop agent surface.The automatic backport workflow ran on #18590 and failed with cherry-pick conflicts on all four targets, so this carrier is a hand cherry-pick.
Conflict resolution
agentConversationStore.tsstore-export block — conflict resolved to exportresolvePaywallsonly. The source commit also exportsclaimPaywallImpression, which is amain-only helper that does not exist anywhere on the release trains; exporting it here would not compile. Nothing else about the fix depends on it.AgentPanelRoot.test.ts— the new cases calltoTurnId, and this branch imports onlyzAgentWsEventfrom./schemas/agentApiSchema. AddedtoTurnIdto that existing import; the helper itself already exists on this branch (agentApiSchema.ts:33), so this is an import line, not a backported helper.No package, lockfile, core-type or business-logic conflict arose; nothing was resolved creatively.
Marker evidence
In
agentConversationStore.ts:resolvedPaywallIds0 before → 6 after (the resolution set that is the fix),setPaywallsResolved2 → 0. InAgentPanelRoot.vue:setPaywallsResolved1 → 0,resolvePaywalls0 → 1. Established on this branch before and after rather than assumed from a clean pick.Verification
pnpm test:unit src/workbench/extensions/agent/stores/agent/agentConversationStore.test.ts src/workbench/extensions/agent/AgentPanelRoot.test.tsgreen on this branch (NODE_OPTIONS=--no-experimental-webstorage).Carried by the in-app-agent program row
bp-1.