Repository navigation
test(agent): backport the conversation-replay harness to cloud/1.54 - #18968
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1958 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-26T08:07:23.369Z",
"gitSha": "b3f2b4b942e57fbdc45e14d9fe77beef58fd12c0",
"branch": "backport/agent-replay-harness-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2025.306999999998,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.499999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.73400000000004,
"heapDeltaBytes": 1464452,
"heapUsedBytes": 71022652,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 8.301999999999996,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2011.3059999999905,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.964,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.643,
"heapDeltaBytes": -11165564,
"heapUsedBytes": 58466784,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.403,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1739.93999999999,
"styleRecalcs": 74,
"styleRecalcDurationMs": 22.986,
"layouts": 14,
"layoutDurationMs": 3.437,
"taskDurationMs": 678.726,
"heapDeltaBytes": 24261516,
"heapUsedBytes": 88956264,
"domNodes": 37,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 122.99999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1726.709000000028,
"styleRecalcs": 74,
"styleRecalcDurationMs": 23.446,
"layouts": 14,
"layoutDurationMs": 3.7469999999999994,
"taskDurationMs": 727.4480000000001,
"heapDeltaBytes": -6616680,
"heapUsedBytes": 63529928,
"domNodes": -278,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 121.44200000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1667.1349999999734,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.629000000000001,
"layouts": 6,
"layoutDurationMs": 0.9610000000000001,
"taskDurationMs": 308.281,
"heapDeltaBytes": 4224052,
"heapUsedBytes": 74804044,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 13.322000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1673.0479999999943,
"styleRecalcs": 30,
"styleRecalcDurationMs": 13.437000000000001,
"layouts": 6,
"layoutDurationMs": 0.9890000000000001,
"taskDurationMs": 298.85699999999997,
"heapDeltaBytes": 4664088,
"heapUsedBytes": 75887140,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.488000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 564.2239999999674,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.848,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 379.519,
"heapDeltaBytes": 18273924,
"heapUsedBytes": 88774800,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 133.75300000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 546.5510000000222,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.521,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.652,
"heapDeltaBytes": -8167772,
"heapUsedBytes": 63312580,
"domNodes": 20,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 127.81600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2029.8760000000016,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.4339999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.061,
"heapDeltaBytes": 11092908,
"heapUsedBytes": 87621480,
"domNodes": -272,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 28.580999999999996,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2051.7429999999877,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.5959999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.93199999999996,
"heapDeltaBytes": 10790500,
"heapUsedBytes": 87503712,
"domNodes": -270,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 35.894999999999996,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2182.431000000008,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.591999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1313.15,
"heapDeltaBytes": -14113736,
"heapUsedBytes": 90595080,
"domNodes": -270,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 626.702,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2173.9089999999806,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.626999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1389.31,
"heapDeltaBytes": 879808,
"heapUsedBytes": 78281500,
"domNodes": -272,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 679.89,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3220.359999999971,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.064,
"layouts": 60,
"layoutDurationMs": 11.873000000000001,
"taskDurationMs": 1510.099,
"heapDeltaBytes": -3396784,
"heapUsedBytes": 75939792,
"domNodes": -288,
"jsHeapTotalBytes": 4616192,
"scriptDurationMs": 655.5260000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3168.5830000000124,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.520999999999999,
"layouts": 60,
"layoutDurationMs": 11.718,
"taskDurationMs": 1417.1359999999997,
"heapDeltaBytes": 8100796,
"heapUsedBytes": 76206172,
"domNodes": 2,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 630.965,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2283.3099999999718,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.110000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1627.1409999999998,
"heapDeltaBytes": -10275012,
"heapUsedBytes": 71496840,
"domNodes": -250,
"jsHeapTotalBytes": 159744,
"scriptDurationMs": 799.9309999999999,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2303.7649999999985,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.850999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1563.4850000000001,
"heapDeltaBytes": 16793524,
"heapUsedBytes": 84568084,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 773.1479999999999,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2029.9969999999803,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.7839999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.3019999999999,
"heapDeltaBytes": 8645460,
"heapUsedBytes": 86697880,
"domNodes": -274,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 29.309,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2002.6009999999133,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.9460000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.31200000000007,
"heapDeltaBytes": 21800540,
"heapUsedBytes": 88327528,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 28.000000000000004,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.9869999999978,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.388000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 350.88,
"heapDeltaBytes": 14844168,
"heapUsedBytes": 88372092,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 117.525,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 530.4039999999759,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.141,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 336.483,
"heapDeltaBytes": 14410900,
"heapUsedBytes": 86967376,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 115.335,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.642000000009,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.187999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.567,
"heapDeltaBytes": -10449960,
"heapUsedBytes": 61350708,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.190999999999998,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2020.5349999999953,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.224,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.55699999999996,
"heapDeltaBytes": -7630340,
"heapUsedBytes": 64759296,
"domNodes": -294,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 7.772000000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.8090000000443,
"styleRecalcs": 78,
"styleRecalcDurationMs": 22.804,
"layouts": 18,
"layoutDurationMs": 3.947,
"taskDurationMs": 667.459,
"heapDeltaBytes": 6596228,
"heapUsedBytes": 79147200,
"domNodes": -297,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 86.847,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1705.840999999964,
"styleRecalcs": 77,
"styleRecalcDurationMs": 22.778,
"layouts": 18,
"layoutDurationMs": 3.9779999999999998,
"taskDurationMs": 673.8389999999999,
"heapDeltaBytes": -6707584,
"heapUsedBytes": 66746244,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 91.16499999999999,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1116.7879999999855,
"styleRecalcs": 21,
"styleRecalcDurationMs": 28.407,
"layouts": 17,
"layoutDurationMs": 13.117999999999999,
"taskDurationMs": 793.0359999999998,
"heapDeltaBytes": 21826072,
"heapUsedBytes": 105756956,
"domNodes": 13751,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 25.16,
"eventListeners": 2387,
"totalBlockingTimeMs": 97,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8390.693,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.146,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4870.958,
"heapDeltaBytes": 11855568,
"heapUsedBytes": 88568820,
"domNodes": -269,
"jsHeapTotalBytes": 385024,
"scriptDurationMs": 2209.006,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8407.93700000006,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.41,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4716.905000000001,
"heapDeltaBytes": 5813260,
"heapUsedBytes": 82137772,
"domNodes": -273,
"jsHeapTotalBytes": 122880,
"scriptDurationMs": 2130.2879999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14818.270999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14551.184,
"heapDeltaBytes": -44342976,
"heapUsedBytes": 183222540,
"domNodes": -8068,
"jsHeapTotalBytes": -13811712,
"scriptDurationMs": 229.82499999999996,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 15062.193999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14592.695000000003,
"heapDeltaBytes": -29630536,
"heapUsedBytes": 182971348,
"domNodes": -8068,
"jsHeapTotalBytes": -12877824,
"scriptDurationMs": 223.518,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17525.484000000004,
"styleRecalcs": 133,
"styleRecalcDurationMs": 14.994000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17202.689,
"heapDeltaBytes": -21582356,
"heapUsedBytes": 189772000,
"domNodes": -8068,
"jsHeapTotalBytes": -11337728,
"scriptDurationMs": 729.6949999999999,
"eventListeners": -14931,
"totalBlockingTimeMs": 25,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 17675.720999999954,
"styleRecalcs": 133,
"styleRecalcDurationMs": 15.690999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17333.891,
"heapDeltaBytes": -27965624,
"heapUsedBytes": 190213236,
"domNodes": -8073,
"jsHeapTotalBytes": -12419072,
"scriptDurationMs": 759.371,
"eventListeners": -14933,
"totalBlockingTimeMs": 11,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5265.472999999985,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.53300000000001,
"layouts": 20,
"layoutDurationMs": 21.663,
"taskDurationMs": 5199.104,
"heapDeltaBytes": -40904020,
"heapUsedBytes": 181811744,
"domNodes": -8068,
"jsHeapTotalBytes": 10158080,
"scriptDurationMs": 88.14999999999999,
"eventListeners": -14933,
"totalBlockingTimeMs": 281,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5370.66399999992,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.737999999999964,
"layouts": 20,
"layoutDurationMs": 21.509,
"taskDurationMs": 5276.539000000001,
"heapDeltaBytes": -50564828,
"heapUsedBytes": 176245804,
"domNodes": -8068,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 118.62900000000002,
"eventListeners": -14931,
"totalBlockingTimeMs": 220,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7317.211999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7235.603000000001,
"heapDeltaBytes": 1467528,
"heapUsedBytes": 192388140,
"domNodes": -1,
"jsHeapTotalBytes": -21757952,
"scriptDurationMs": 108.775,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7441.601999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7259.639000000002,
"heapDeltaBytes": 24209056,
"heapUsedBytes": 183219080,
"domNodes": 0,
"jsHeapTotalBytes": -4980736,
"scriptDurationMs": 109.491,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 462.2269999999844,
"styleRecalcs": 18,
"styleRecalcDurationMs": 20.502,
"layouts": 5,
"layoutDurationMs": 1.8659999999999999,
"taskDurationMs": 111.86600000000001,
"heapDeltaBytes": 4999020,
"heapUsedBytes": 74315096,
"domNodes": 147,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 10.232,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 82.08700000000135,
"styleRecalcs": 6,
"styleRecalcDurationMs": 11.672,
"layouts": 2,
"layoutDurationMs": 0.941,
"taskDurationMs": 53.22400000000001,
"heapDeltaBytes": 2987828,
"heapUsedBytes": 72403080,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 3.4979999999999993,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
a9785ef to
a9162b8
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
Review — author's own, posted as a COMMENT
GitHub will not accept an author approving their own PR, so this is the honest record rather than a manufactured approval. Authority for a worker to review and merge an Agent backport onto cloud/1.54 is Christian's 2026-09-16 instruction plus the 2026-09-20 clarification; that grant covers the merge without an additional approval record, and it does not dismiss any human objection raised here.
What I checked, not just that it builds
- Every absent file was established by an import-closure walk, not a file list. The transitive
browser_testsclosure ofagentConversationFixture.tsonmainis 75 files; 42 are byte-identical here, 23 are ordinary forward drift, 10 are absent, and only 6 of those are the harness. That is howagentHumanAddBlueprints.tsgot included — it is absent from this branch and from the sizing this carry was scoped against. - The dependency that would have broken the branch was found and excluded.
main'sagentFollowerHostSocket.tsimports@/platform/remote/comfyui/execution/types, which does not exist oncloud/1.54. That is the same missing-module shape that leftcore/1.54red for six hours after #18722. This harness uses none of that file's newer members, so the branch's existing socket is untouched — the newer version is deliberately not carried. - The reverse trap too.
TestIds.app.loadingOverlaywas not added: nothing on this branch rendersdata-testid="app-loading-overlay", so the selector would resolve to nothing.TestIds.topbar.workflowTabwas added only after confirmingWorkflowTab.vuealready rendersdata-testid="workflow-tab"here. - Dropping the
messageDraftslot loses nothing. No recording on this branch carries a draft event, and neither the expectations file nor the fixture references one. If #18551 is carried, its own diff restores the slot in the right position. - The double route registration is
main's shape, not a new bug.mockWorkflowPersistenceregisters at boot andmockSavedWorkflowPersistenceonly when a spec opts intopersistSavedWorkflow(); later routes win and the saved-workflow mock falls back where it does not apply.
Test evidence at head a9162b8d89
| Check | Result |
|---|---|
pnpm typecheck / pnpm typecheck:browser |
clean |
pnpm knip:no-cache |
clean — no ignore entry, no new tag |
pnpm lint |
0 errors |
vitest (3 files) |
33/33 pass, including all 15 recordings validated |
playwright --project=cloud agentWidgetTypingReconcile |
1/1 pass |
playwright --project=cloud agentConversationReplay |
19/20 — every recording green |
playwright --project=cloud agentHumanAddTabSwitch |
4/6 |
On the three local failures: the two agentHumanAddTabSwitch subgraph-blueprint cases fail identically on a main checkout in the same local setup (bare cloud dev server, no ComfyUI backend or devtools; the blueprint path goes through canvas._deserializeItems), so they are an environment artifact, not a branch gap. The one @screenshot case differs by 1% of pixels, and goldens are rendered in the CI container — a locally regenerated golden would be wrong for CI, and this branch's golden legitimately differs from main's. CI is the arbiter for all three; if any of them is red here, the fix is to drop that spec or describe block rather than to weaken it.
Merge state
Not merging on this review. check-merge-ready.sh --target-branch cloud/1.54 must run at the then-current head immediately before any --admin merge, and the required set — lint-and-format, test, e2e-status — must all be green. lint-and-format passes. Vercel – billing-web-test fails, and that status is FAILURE at the head of every PR on this branch including #18963, #18959 and #18955, all three merged through the authorized flow; it is waived under the recorded exception (sunset 2026-10-09) and that waiver covers that status and nothing else.
Head history, for the record
First head was a9785ef179 (tree 1ba60f25b5). Check for AI agent co-author trailers failed on it. Under the message-only rewrite provision: only the forbidden trailer line was removed, giving head a9162b8d89 with tree 1ba60f25b5 — the same tree object — force-pushed with an exact lease. Checks were re-earned at the new head and the trailer check now passes.
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #18968 +/- ##
=============================================
Coverage ? 83.92%
=============================================
Files ? 2116
Lines ? 126040
Branches ? 34101
=============================================
Hits ? 105780
Misses ? 20083
Partials ? 177
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
CI result at
|
Eight backport carriers each dropped their black-box proof spec because the agent conversation-replay harness family was never backported, so most agent CRDT fixes on this line ship with unit coverage only. Christian ruled on 2026-09-26 that 1.54 has another week and the test infra should be carried. Test infrastructure only; no product file is touched. Carried from main, byte-identical except where this branch's surface differs: - browser_tests/fixtures/agentConversationFixture.ts - browser_tests/fixtures/data/agent/agentConversation.ts (+ .test.ts) - browser_tests/fixtures/data/agent/agentConversationExpectations.ts - browser_tests/fixtures/data/agent/agentHumanAddBlueprints.ts - browser_tests/fixtures/data/agentReplayNodeDefs.ts - browser_tests/fixtures/utils/agentReplayNodeContract.ts (+ .test.ts) - browser_tests/tests/agent/agentConversationReplay.spec.ts - browser_tests/tests/agent/agentWidgetTypingReconcile.spec.ts - browser_tests/tests/agent/agentHumanAddTabSwitch.spec.ts Branch adaptations, each with a comment at the site saying why: - agentConversation.ts drops the messageDraft slot of zAgentWsEvent. zAgentMessageDraftEvent arrived with #18551 (streaming reply), which is not on this branch. - agentPanelFixture.ts gains mockWorkflowPersistence and the vueNodes boot option. UserDataFullInfo comes from @/schemas/apiSchema, not main's @/platform/remote/comfyui/types, which does not exist here -- the same adaptation savedWorkflowPersistence.ts already carries. - agentConversationFixture.ts waits on PrimeVue's .p-blockui-mask instead of data-testid="app-loading-overlay", which App.vue does not render here. - agentConversationHostDoc.ts apply() takes RecordedGraphOperation[]. - Topbar gains tabs; selectors gains topbar.workflowTab, whose test id WorkflowTab.vue already renders on this branch. - globals.d.ts gains TabSwitchLens and window.__tabSwitchLens. - Four exports in agentConversation.ts are module-local here; their only consumer on main is scripts/agentConversationAssemble.ts, not backported. The 15 recorded conversation JSON files are already on this branch and byte-identical to main (#18585/#18586), so this is harness code only. Not carried, deliberately: main's agentFollowerHostSocket.ts, whose newer members this harness does not use and which imports @/platform/remote/comfyui/execution/types -- absent here, the same missing module that left core/1.54 red for six hours (#18722); the recording-authoring tools under scripts/ and tools/test-recorder; agentConversationCapabilityMatrix.
CI on cloud/1.54 runs this carrier's specs 271 passed / 1 failed, and the one failure is the @screenshot case. The canvas it renders matches this branch's committed golden exactly -- every node and every wire, including the one the second turn connects. The entire diff (1,428-2,729 px above threshold, on all four attempts) is a toast neither golden contains: Comfy Agent error -- Comfy Agent hit a server error. Masking the toast away would hide the only interesting thing the case found, and regenerating the golden would bake the error into the expectation. Parked with the lead recorded at the site instead, so the next reader sees why. The branch's golden PNG is left in place; it was already on this branch without its spec before this carrier.
e350e8e to
bc8c5c4
Compare
Recorded merge judgment at
|
Summary
Backports the agent conversation-replay test harness to
cloud/1.54so the release line can replay the 15 recorded agent conversations it already carries. Test infrastructure only — no product file is touched.Changes
agentConversationFixture.ts,data/agent/agentConversation.ts,agentConversationExpectations.ts,agentHumanAddBlueprints.ts,data/agentReplayNodeDefs.ts,utils/agentReplayNodeContract.ts), the two harness self-tests, and three black-box specs that consume it. Small additive hunks toagentPanelFixture.ts,agentConversationHostDoc.ts,components/Topbar.ts,selectors.tsandtypes/globals.d.ts.main.Why
Eight carriers each dropped their black-box proof spec one at a time, for the same reason: this harness family (from unbackported #16764 / #17537 / #17875 / #18164) does not exist on the 1.54 pair, so most agent CRDT fixes on this line ship with unit coverage only. #18758 recorded the intended remedy — "left for a follow-up once the agent Playwright fixture infrastructure itself is backported". Christian ruled on 2026-09-26 that 1.54 has another week and the test infra should be carried, which is this PR.
agentWidgetTypingReconcile.spec.tsis the payoff worth naming: it is the black-box proof of the widget-typing garble fix (PM-1191/PM-1697), a P0 that is live in production on this line with no e2e coverage here until now.Review Focus
Everything came from
mainbyte-identical except the adaptations below, each commented at the site:agentConversation.tsdrops themessageDraftslot ofzAgentWsEventzAgentMessageDraftEventarrived with #18551 (streaming reply), which is not on this branch. Re-add it if #18551 is carried.mockWorkflowPersistencereadsUserDataFullInfofrom@/schemas/apiSchemamainreads it from@/platform/remote/comfyui/types, which does not exist here.browser_tests/fixtures/utils/savedWorkflowPersistence.tsalready carries exactly this adaptation.reloadWithoutLocalWorkflow()waits on.p-blockui-maskApp.vueon this branch renders PrimeVueBlockUI, notdata-testid="app-loading-overlay".ComfyPagealready matches the mask this way.HostDoc.apply()takesRecordedGraphOperation[]main; the applier is the only judge of a recorded op.Topbar.tabs+TestIds.topbar.workflowTabWorkflowTab.vuealready rendersdata-testid="workflow-tab"on this branch.agentConversation.tsare module-localmainisscripts/agentConversationAssemble.ts, which is not backported.Deliberately not carried, and the one that matters for review:
main's neweragentFollowerHostSocket.ts. This harness uses none of its added members, and it imports@/platform/remote/comfyui/execution/types— absent on this branch. That is the same missing-module shape that leftcore/1.54red for six hours after [backport core/1.54] Fix duplicate-name stale workflow binding resolution #18722, so the branch's existing socket is kept as-is.scripts/agentConversation{Assemble,FromLangfuse,Record}.ts,tools/test-recorder/.../agentReplay.ts,agentConversationCapabilityMatrix). A release branch needs to replay the recordings it has, not author new ones.Verified locally against this branch:
pnpm typecheckandpnpm typecheck:browserclean,pnpm knipclean,pnpm lint0 errors, the three carried vitest files 33/33 green, andplaywright --project=cloudonagentConversationReplay.spec.ts19/20 andagentWidgetTypingReconcile.spec.ts1/1. TwoagentHumanAddTabSwitchsubgraph-blueprint cases and the one@screenshotcase cannot be judged outside the CI container — both behave identically on amaincheckout in the same local setup, so CI is the arbiter for those three.