Skip to content

test(agent): backport the conversation-replay harness to cloud/1.54 - #18968

Merged
christian-byrne merged 2 commits into
cloud/1.54from
backport/agent-replay-harness-cloud-1.54
Sep 26, 2026
Merged

christian-byrne merged 2 commits into
cloud/1.54from
backport/agent-replay-harness-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Backports the agent conversation-replay test harness to cloud/1.54 so the release line can replay the 15 recorded agent conversations it already carries. Test infrastructure only — no product file is touched.

Changes

Why

Eight carriers each dropped their black-box proof spec one at a time, for the same reason: this harness family (from unbackported #16764 / #17537 / #17875 / #18164) does not exist on the 1.54 pair, so most agent CRDT fixes on this line ship with unit coverage only. #18758 recorded the intended remedy — "left for a follow-up once the agent Playwright fixture infrastructure itself is backported". Christian ruled on 2026-09-26 that 1.54 has another week and the test infra should be carried, which is this PR.

agentWidgetTypingReconcile.spec.ts is the payoff worth naming: it is the black-box proof of the widget-typing garble fix (PM-1191/PM-1697), a P0 that is live in production on this line with no e2e coverage here until now.

Review Focus

Everything came from main byte-identical except the adaptations below, each commented at the site:

Adaptation Why
agentConversation.ts drops the messageDraft slot of zAgentWsEvent zAgentMessageDraftEvent arrived with #18551 (streaming reply), which is not on this branch. Re-add it if #18551 is carried.
mockWorkflowPersistence reads UserDataFullInfo from @/schemas/apiSchema main reads it from @/platform/remote/comfyui/types, which does not exist here. browser_tests/fixtures/utils/savedWorkflowPersistence.ts already carries exactly this adaptation.
reloadWithoutLocalWorkflow() waits on .p-blockui-mask App.vue on this branch renders PrimeVue BlockUI, not data-testid="app-loading-overlay". ComfyPage already matches the mask this way.
HostDoc.apply() takes RecordedGraphOperation[] matches main; the applier is the only judge of a recorded op.
Topbar.tabs + TestIds.topbar.workflowTab WorkflowTab.vue already renders data-testid="workflow-tab" on this branch.
four exports in agentConversation.ts are module-local their only consumer on main is scripts/agentConversationAssemble.ts, which is not backported.

Deliberately not carried, and the one that matters for review:

  • main's newer agentFollowerHostSocket.ts. This harness uses none of its added members, and it imports @/platform/remote/comfyui/execution/types — absent on this branch. That is the same missing-module shape that left core/1.54 red for six hours after [backport core/1.54] Fix duplicate-name stale workflow binding resolution #18722, so the branch's existing socket is kept as-is.
  • The recording-authoring side (scripts/agentConversation{Assemble,FromLangfuse,Record}.ts, tools/test-recorder/.../agentReplay.ts, agentConversationCapabilityMatrix). A release branch needs to replay the recordings it has, not author new ones.

Verified locally against this branch: pnpm typecheck and pnpm typecheck:browser clean, pnpm knip clean, pnpm lint 0 errors, the three carried vitest files 33/33 green, and playwright --project=cloud on agentConversationReplay.spec.ts 19/20 and agentWidgetTypingReconcile.spec.ts 1/1. Two agentHumanAddTabSwitch subgraph-blueprint cases and the one @screenshot case cannot be judged outside the CI container — both behave identically on a main checkout in the same local setup, so CI is the arbiter for those three.

@vercel

vercel Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
billing-web-test Error Error Sep 26, 2026 7:57am UTC
1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 26, 2026 7:57am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 9da9d144-7216-4a3d-b26c-60da52fd1be4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1958 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1937 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.7 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.5 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.5 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.4 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.5 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.6 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.1 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.6 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 97ms TBT · 100.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.4 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 174.6 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 18ms TBT · 181.2 MB heap
vue-node-resize-workload: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 251ms TBT · 170.7 MB heap
vue-zoom-out-idle: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 179.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.0 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 428ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 61.7 MB
canvas-idle: DOM nodes -131
canvas-idle: event listeners -95
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 23ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 703ms
canvas-mouse-sweep: script duration 122ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 72.7 MB
canvas-mouse-sweep: DOM nodes -121
canvas-mouse-sweep: event listeners -96
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 14ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 304ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.9 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 375ms
dom-widget-clipping: script duration 131ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.5 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 505ms
large-graph-idle: script duration 32ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.5 MB
large-graph-idle: DOM nodes -271
large-graph-idle: event listeners -160
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1351ms
large-graph-pan: script duration 653ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 80.5 MB
large-graph-pan: DOM nodes -271
large-graph-pan: event listeners -177
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 63
large-graph-zoom: task duration 1464ms
large-graph-zoom: script duration 643ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.5 MB
large-graph-zoom: DOM nodes -143
large-graph-zoom: event listeners -94
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 43
legacy-node-drag: task duration 1595ms
legacy-node-drag: script duration 787ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 74.4 MB
legacy-node-drag: DOM nodes -125
legacy-node-drag: event listeners 86
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 501ms
minimap-idle: script duration 29ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.5 MB
minimap-idle: DOM nodes -133
minimap-idle: event listeners -92
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 344ms
subgraph-dom-widget-clipping: script duration 116ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.6 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 417ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 60.1 MB
subgraph-idle: DOM nodes -294
subgraph-idle: event listeners -242
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 23ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 671ms
subgraph-mouse-sweep: script duration 89ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 69.6 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -226
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 28ms
subgraph-transition-enter: layout count 17
subgraph-transition-enter: style recalc count 21
subgraph-transition-enter: task duration 793ms
subgraph-transition-enter: script duration 25ms
subgraph-transition-enter: TBT 97ms
subgraph-transition-enter: heap used 100.9 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 38ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 4794ms
viewport-pan-sweep: script duration 2170ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 81.4 MB
viewport-pan-sweep: DOM nodes -271
viewport-pan-sweep: event listeners -174
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 14572ms
vue-large-graph-idle: script duration 227ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 174.6 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14935
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 15ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 133
vue-large-graph-pan: task duration 17268ms
vue-large-graph-pan: script duration 745ms
vue-large-graph-pan: TBT 18ms
vue-large-graph-pan: heap used 181.2 MB
vue-large-graph-pan: DOM nodes -8071
vue-large-graph-pan: event listeners -14932
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 22ms
vue-node-resize-workload: style recalc duration 63ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5238ms
vue-node-resize-workload: script duration 103ms
vue-node-resize-workload: TBT 251ms
vue-node-resize-workload: heap used 170.7 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14932
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7248ms
vue-zoom-out-idle: script duration 109ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 179.1 MB
vue-zoom-out-idle: DOM nodes -1
vue-zoom-out-idle: event listeners -10
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 16ms
workflow-execution: layout count 4
workflow-execution: style recalc count 12
workflow-execution: task duration 83ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 70.0 MB
workflow-execution: DOM nodes 136
workflow-execution: event listeners 42
Raw data
{
  "timestamp": "2026-09-26T08:07:23.369Z",
  "gitSha": "b3f2b4b942e57fbdc45e14d9fe77beef58fd12c0",
  "branch": "backport/agent-replay-harness-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2025.306999999998,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.499999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 426.73400000000004,
      "heapDeltaBytes": 1464452,
      "heapUsedBytes": 71022652,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 8.301999999999996,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2011.3059999999905,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.964,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 429.643,
      "heapDeltaBytes": -11165564,
      "heapUsedBytes": 58466784,
      "domNodes": -280,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 8.403,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1739.93999999999,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 22.986,
      "layouts": 14,
      "layoutDurationMs": 3.437,
      "taskDurationMs": 678.726,
      "heapDeltaBytes": 24261516,
      "heapUsedBytes": 88956264,
      "domNodes": 37,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 122.99999999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1726.709000000028,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 23.446,
      "layouts": 14,
      "layoutDurationMs": 3.7469999999999994,
      "taskDurationMs": 727.4480000000001,
      "heapDeltaBytes": -6616680,
      "heapUsedBytes": 63529928,
      "domNodes": -278,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 121.44200000000001,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1667.1349999999734,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 14.629000000000001,
      "layouts": 6,
      "layoutDurationMs": 0.9610000000000001,
      "taskDurationMs": 308.281,
      "heapDeltaBytes": 4224052,
      "heapUsedBytes": 74804044,
      "domNodes": 77,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 13.322000000000003,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1673.0479999999943,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 13.437000000000001,
      "layouts": 6,
      "layoutDurationMs": 0.9890000000000001,
      "taskDurationMs": 298.85699999999997,
      "heapDeltaBytes": 4664088,
      "heapUsedBytes": 75887140,
      "domNodes": 77,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.488000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 564.2239999999674,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.848,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 379.519,
      "heapDeltaBytes": 18273924,
      "heapUsedBytes": 88774800,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 133.75300000000001,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 546.5510000000222,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.521,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 370.652,
      "heapDeltaBytes": -8167772,
      "heapUsedBytes": 63312580,
      "domNodes": 20,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 127.81600000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2029.8760000000016,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 3.4339999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 510.061,
      "heapDeltaBytes": 11092908,
      "heapUsedBytes": 87621480,
      "domNodes": -272,
      "jsHeapTotalBytes": -2199552,
      "scriptDurationMs": 28.580999999999996,
      "eventListeners": -160,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2051.7429999999877,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 3.5959999999999983,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 499.93199999999996,
      "heapDeltaBytes": 10790500,
      "heapUsedBytes": 87503712,
      "domNodes": -270,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 35.894999999999996,
      "eventListeners": -160,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2182.431000000008,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 11.591999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1313.15,
      "heapDeltaBytes": -14113736,
      "heapUsedBytes": 90595080,
      "domNodes": -270,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 626.702,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2173.9089999999806,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 11.626999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1389.31,
      "heapDeltaBytes": 879808,
      "heapUsedBytes": 78281500,
      "domNodes": -272,
      "jsHeapTotalBytes": -139264,
      "scriptDurationMs": 679.89,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3220.359999999971,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 13.064,
      "layouts": 60,
      "layoutDurationMs": 11.873000000000001,
      "taskDurationMs": 1510.099,
      "heapDeltaBytes": -3396784,
      "heapUsedBytes": 75939792,
      "domNodes": -288,
      "jsHeapTotalBytes": 4616192,
      "scriptDurationMs": 655.5260000000001,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3168.5830000000124,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 10.520999999999999,
      "layouts": 60,
      "layoutDurationMs": 11.718,
      "taskDurationMs": 1417.1359999999997,
      "heapDeltaBytes": 8100796,
      "heapUsedBytes": 76206172,
      "domNodes": 2,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 630.965,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2283.3099999999718,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 8.110000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1627.1409999999998,
      "heapDeltaBytes": -10275012,
      "heapUsedBytes": 71496840,
      "domNodes": -250,
      "jsHeapTotalBytes": 159744,
      "scriptDurationMs": 799.9309999999999,
      "eventListeners": -14,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2303.7649999999985,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.850999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1563.4850000000001,
      "heapDeltaBytes": 16793524,
      "heapUsedBytes": 84568084,
      "domNodes": 0,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 773.1479999999999,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2029.9969999999803,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 3.7839999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 531.3019999999999,
      "heapDeltaBytes": 8645460,
      "heapUsedBytes": 86697880,
      "domNodes": -274,
      "jsHeapTotalBytes": -2199552,
      "scriptDurationMs": 29.309,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2002.6009999999133,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 2.9460000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 470.31200000000007,
      "heapDeltaBytes": 21800540,
      "heapUsedBytes": 88327528,
      "domNodes": 8,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 28.000000000000004,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 575.9869999999978,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 10.388000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 350.88,
      "heapDeltaBytes": 14844168,
      "heapUsedBytes": 88372092,
      "domNodes": 22,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 117.525,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 530.4039999999759,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 9.141,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 336.483,
      "heapDeltaBytes": 14410900,
      "heapUsedBytes": 86967376,
      "domNodes": 20,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 115.335,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2008.642000000009,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.187999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 403.567,
      "heapDeltaBytes": -10449960,
      "heapUsedBytes": 61350708,
      "domNodes": -294,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.190999999999998,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2020.5349999999953,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.224,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 429.55699999999996,
      "heapDeltaBytes": -7630340,
      "heapUsedBytes": 64759296,
      "domNodes": -294,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 7.772000000000001,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1693.8090000000443,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 22.804,
      "layouts": 18,
      "layoutDurationMs": 3.947,
      "taskDurationMs": 667.459,
      "heapDeltaBytes": 6596228,
      "heapUsedBytes": 79147200,
      "domNodes": -297,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 86.847,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1705.840999999964,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 22.778,
      "layouts": 18,
      "layoutDurationMs": 3.9779999999999998,
      "taskDurationMs": 673.8389999999999,
      "heapDeltaBytes": -6707584,
      "heapUsedBytes": 66746244,
      "domNodes": -296,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 91.16499999999999,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1116.7879999999855,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 28.407,
      "layouts": 17,
      "layoutDurationMs": 13.117999999999999,
      "taskDurationMs": 793.0359999999998,
      "heapDeltaBytes": 21826072,
      "heapUsedBytes": 105756956,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 25.16,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 97,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8390.693,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 37.146,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4870.958,
      "heapDeltaBytes": 11855568,
      "heapUsedBytes": 88568820,
      "domNodes": -269,
      "jsHeapTotalBytes": 385024,
      "scriptDurationMs": 2209.006,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8407.93700000006,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 38.41,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4716.905000000001,
      "heapDeltaBytes": 5813260,
      "heapUsedBytes": 82137772,
      "domNodes": -273,
      "jsHeapTotalBytes": 122880,
      "scriptDurationMs": 2130.2879999999996,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14818.270999999982,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14551.184,
      "heapDeltaBytes": -44342976,
      "heapUsedBytes": 183222540,
      "domNodes": -8068,
      "jsHeapTotalBytes": -13811712,
      "scriptDurationMs": 229.82499999999996,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15062.193999999978,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14592.695000000003,
      "heapDeltaBytes": -29630536,
      "heapUsedBytes": 182971348,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12877824,
      "scriptDurationMs": 223.518,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17525.484000000004,
      "styleRecalcs": 133,
      "styleRecalcDurationMs": 14.994000000000007,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17202.689,
      "heapDeltaBytes": -21582356,
      "heapUsedBytes": 189772000,
      "domNodes": -8068,
      "jsHeapTotalBytes": -11337728,
      "scriptDurationMs": 729.6949999999999,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 25,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17675.720999999954,
      "styleRecalcs": 133,
      "styleRecalcDurationMs": 15.690999999999983,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17333.891,
      "heapDeltaBytes": -27965624,
      "heapUsedBytes": 190213236,
      "domNodes": -8073,
      "jsHeapTotalBytes": -12419072,
      "scriptDurationMs": 759.371,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 11,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5265.472999999985,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 62.53300000000001,
      "layouts": 20,
      "layoutDurationMs": 21.663,
      "taskDurationMs": 5199.104,
      "heapDeltaBytes": -40904020,
      "heapUsedBytes": 181811744,
      "domNodes": -8068,
      "jsHeapTotalBytes": 10158080,
      "scriptDurationMs": 88.14999999999999,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 281,
      "frameDurationMs": 17.220000000000013,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5370.66399999992,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 63.737999999999964,
      "layouts": 20,
      "layoutDurationMs": 21.509,
      "taskDurationMs": 5276.539000000001,
      "heapDeltaBytes": -50564828,
      "heapUsedBytes": 176245804,
      "domNodes": -8068,
      "jsHeapTotalBytes": 4845568,
      "scriptDurationMs": 118.62900000000002,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 220,
      "frameDurationMs": 17.223333333333297,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7317.211999999983,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7235.603000000001,
      "heapDeltaBytes": 1467528,
      "heapUsedBytes": 192388140,
      "domNodes": -1,
      "jsHeapTotalBytes": -21757952,
      "scriptDurationMs": 108.775,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333237,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7441.601999999989,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7259.639000000002,
      "heapDeltaBytes": 24209056,
      "heapUsedBytes": 183219080,
      "domNodes": 0,
      "jsHeapTotalBytes": -4980736,
      "scriptDurationMs": 109.491,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 462.2269999999844,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 20.502,
      "layouts": 5,
      "layoutDurationMs": 1.8659999999999999,
      "taskDurationMs": 111.86600000000001,
      "heapDeltaBytes": 4999020,
      "heapUsedBytes": 74315096,
      "domNodes": 147,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 10.232,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 82.08700000000135,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 11.672,
      "layouts": 2,
      "layoutDurationMs": 0.941,
      "taskDurationMs": 53.22400000000001,
      "heapDeltaBytes": 2987828,
      "heapUsedBytes": 72403080,
      "domNodes": 124,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 3.4979999999999993,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50618 75805 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.6% 275
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.4% 260
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 26, 2026
@christian-byrne
christian-byrne force-pushed the backport/agent-replay-harness-cloud-1.54 branch from a9785ef to a9162b8 Compare September 26, 2026 07:13

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review — author's own, posted as a COMMENT

GitHub will not accept an author approving their own PR, so this is the honest record rather than a manufactured approval. Authority for a worker to review and merge an Agent backport onto cloud/1.54 is Christian's 2026-09-16 instruction plus the 2026-09-20 clarification; that grant covers the merge without an additional approval record, and it does not dismiss any human objection raised here.

What I checked, not just that it builds

  • Every absent file was established by an import-closure walk, not a file list. The transitive browser_tests closure of agentConversationFixture.ts on main is 75 files; 42 are byte-identical here, 23 are ordinary forward drift, 10 are absent, and only 6 of those are the harness. That is how agentHumanAddBlueprints.ts got included — it is absent from this branch and from the sizing this carry was scoped against.
  • The dependency that would have broken the branch was found and excluded. main's agentFollowerHostSocket.ts imports @/platform/remote/comfyui/execution/types, which does not exist on cloud/1.54. That is the same missing-module shape that left core/1.54 red for six hours after #18722. This harness uses none of that file's newer members, so the branch's existing socket is untouched — the newer version is deliberately not carried.
  • The reverse trap too. TestIds.app.loadingOverlay was not added: nothing on this branch renders data-testid="app-loading-overlay", so the selector would resolve to nothing. TestIds.topbar.workflowTab was added only after confirming WorkflowTab.vue already renders data-testid="workflow-tab" here.
  • Dropping the messageDraft slot loses nothing. No recording on this branch carries a draft event, and neither the expectations file nor the fixture references one. If #18551 is carried, its own diff restores the slot in the right position.
  • The double route registration is main's shape, not a new bug. mockWorkflowPersistence registers at boot and mockSavedWorkflowPersistence only when a spec opts into persistSavedWorkflow(); later routes win and the saved-workflow mock falls back where it does not apply.

Test evidence at head a9162b8d89

Check Result
pnpm typecheck / pnpm typecheck:browser clean
pnpm knip:no-cache clean — no ignore entry, no new tag
pnpm lint 0 errors
vitest (3 files) 33/33 pass, including all 15 recordings validated
playwright --project=cloud agentWidgetTypingReconcile 1/1 pass
playwright --project=cloud agentConversationReplay 19/20 — every recording green
playwright --project=cloud agentHumanAddTabSwitch 4/6

On the three local failures: the two agentHumanAddTabSwitch subgraph-blueprint cases fail identically on a main checkout in the same local setup (bare cloud dev server, no ComfyUI backend or devtools; the blueprint path goes through canvas._deserializeItems), so they are an environment artifact, not a branch gap. The one @screenshot case differs by 1% of pixels, and goldens are rendered in the CI container — a locally regenerated golden would be wrong for CI, and this branch's golden legitimately differs from main's. CI is the arbiter for all three; if any of them is red here, the fix is to drop that spec or describe block rather than to weaken it.

Merge state

Not merging on this review. check-merge-ready.sh --target-branch cloud/1.54 must run at the then-current head immediately before any --admin merge, and the required set — lint-and-format, test, e2e-status — must all be green. lint-and-format passes. Vercel – billing-web-test fails, and that status is FAILURE at the head of every PR on this branch including #18963, #18959 and #18955, all three merged through the authorized flow; it is waived under the recorded exception (sunset 2026-10-09) and that waiver covers that status and nothing else.

Head history, for the record

First head was a9785ef179 (tree 1ba60f25b5). Check for AI agent co-author trailers failed on it. Under the message-only rewrite provision: only the forbidden trailer line was removed, giving head a9162b8d89 with tree 1ba60f25b5 — the same tree object — force-pushed with an exact lease. Checks were re-earned at the new head and the trailer check now passes.

@datadog-official

This comment has been minimized.

@codecov

codecov Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #18968   +/-   ##
=============================================
  Coverage              ?   83.92%           
=============================================
  Files                 ?     2116           
  Lines                 ?   126040           
  Branches              ?    34101           
=============================================
  Hits                  ?   105780           
  Misses                ?    20083           
  Partials              ?      177           
Flag Coverage Δ
e2e 66.78% <ø> (?)
unit 79.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

CI result at a9162b8d89, and what it found

271 passed, 1 failed, 2 flaky in playwright-tests (cloud). The two flaky ones are pre-existing branch specs this PR does not touch (agentAutogrowTabSwitchReconcile, agentDuplicateWorkflowNameBinding); both passed on retry.

Two things worth stating, because both correct something I said earlier in this PR:

1. agentHumanAddTabSwitch.spec.ts passes in CI, all six cases. The two subgraph-blueprint cases that failed in my local run were an environment artifact, exactly as the main comparison suggested. Nothing to drop.

2. The one real failure is the @screenshot case, and it is a finding rather than a stale golden. I pulled the CI report artifact and compared the rendered canvas against this branch's committed golden pixel by pixel: the canvas matches exactly — every node, every wire, including the one the second turn connects, which is the thing that case exists to assert. The entire diff (1,428–2,729 px above Playwright's threshold, on all four attempts) is one toast that neither this branch's golden nor main's contains:

Comfy Agent error — Comfy Agent hit a server error.

So the replay raises an agent server error on this branch while every one of the 15 recorded conversations still replays green, and no non-screenshot assertion notices. I did not chase the cause: that is product debugging on a surface this PR deliberately does not touch.

I also did not do either of the two things that would have made it go away dishonestly — masking the toast out of the screenshot, or regenerating the golden with the error baked into it. e350e8e40c parks that one describe block with the lead written down at the site, and leaves the branch's golden PNG where it already was.

Everything else in the spec stays: all 15 recordings, the manual-title-across-update case, the live combo refresh, the active-widget edit, and the PM-993 MiniMax autogrow reload. Locally 19/19 after the change.

Eight backport carriers each dropped their black-box proof spec because the
agent conversation-replay harness family was never backported, so most agent
CRDT fixes on this line ship with unit coverage only. Christian ruled on
2026-09-26 that 1.54 has another week and the test infra should be carried.

Test infrastructure only; no product file is touched.

Carried from main, byte-identical except where this branch's surface differs:

- browser_tests/fixtures/agentConversationFixture.ts
- browser_tests/fixtures/data/agent/agentConversation.ts (+ .test.ts)
- browser_tests/fixtures/data/agent/agentConversationExpectations.ts
- browser_tests/fixtures/data/agent/agentHumanAddBlueprints.ts
- browser_tests/fixtures/data/agentReplayNodeDefs.ts
- browser_tests/fixtures/utils/agentReplayNodeContract.ts (+ .test.ts)
- browser_tests/tests/agent/agentConversationReplay.spec.ts
- browser_tests/tests/agent/agentWidgetTypingReconcile.spec.ts
- browser_tests/tests/agent/agentHumanAddTabSwitch.spec.ts

Branch adaptations, each with a comment at the site saying why:

- agentConversation.ts drops the messageDraft slot of zAgentWsEvent.
  zAgentMessageDraftEvent arrived with #18551 (streaming reply), which is not
  on this branch.
- agentPanelFixture.ts gains mockWorkflowPersistence and the vueNodes boot
  option. UserDataFullInfo comes from @/schemas/apiSchema, not main's
  @/platform/remote/comfyui/types, which does not exist here -- the same
  adaptation savedWorkflowPersistence.ts already carries.
- agentConversationFixture.ts waits on PrimeVue's .p-blockui-mask instead of
  data-testid="app-loading-overlay", which App.vue does not render here.
- agentConversationHostDoc.ts apply() takes RecordedGraphOperation[].
- Topbar gains tabs; selectors gains topbar.workflowTab, whose test id
  WorkflowTab.vue already renders on this branch.
- globals.d.ts gains TabSwitchLens and window.__tabSwitchLens.
- Four exports in agentConversation.ts are module-local here; their only
  consumer on main is scripts/agentConversationAssemble.ts, not backported.

The 15 recorded conversation JSON files are already on this branch and
byte-identical to main (#18585/#18586), so this is harness code only.

Not carried, deliberately: main's agentFollowerHostSocket.ts, whose newer
members this harness does not use and which imports
@/platform/remote/comfyui/execution/types -- absent here, the same missing
module that left core/1.54 red for six hours (#18722); the recording-authoring
tools under scripts/ and tools/test-recorder; agentConversationCapabilityMatrix.
CI on cloud/1.54 runs this carrier's specs 271 passed / 1 failed, and the one
failure is the @screenshot case. The canvas it renders matches this branch's
committed golden exactly -- every node and every wire, including the one the
second turn connects. The entire diff (1,428-2,729 px above threshold, on all
four attempts) is a toast neither golden contains:

  Comfy Agent error -- Comfy Agent hit a server error.

Masking the toast away would hide the only interesting thing the case found,
and regenerating the golden would bake the error into the expectation. Parked
with the lead recorded at the site instead, so the next reader sees why.

The branch's golden PNG is left in place; it was already on this branch
without its spec before this carrier.
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Recorded merge judgment at bc8c5c41a0b345f4609be3916146f363c7d0a439

Rebased onto cloud/1.54 tip 9b6ccb3d3f — the gate refused the previous head as stale, correctly — and re-earned every check at the new head. The tree is unchanged apart from that rebase; the diff is still 16 files, all under browser_tests/.

Required checks, all green at this exact head

SUCCESS   lint-and-format
SUCCESS   test
SUCCESS   e2e-status

e2e-status green means playwright-tests (cloud) is green, i.e. the carried specs — the 15 recorded conversations, the widget-typing P0 proof, and all six agentHumanAddTabSwitch cases — pass in the CI container against this branch.

The one refusal, and the recorded waiver

$ bash scripts/check-merge-ready.sh Comfy-Org/ComfyUI_frontend 18968 --target-branch cloud/1.54
NOT MERGE READY: commit statuses are not green at bc8c5c41a0b345f4609be3916146f363c7d0a439: Vercel – billing-web-test=failure

Vercel – billing-web-test is FAILURE at the head of every PR on this branch, including #18963, #18959 and #18955 — all three merged through the authorized flow. It is a Vercel git-integration artifact on release branches, not a signal about this diff, and a strict reading would make every cloud/1.54 merge permanently impossible, which the branch's own merge history contradicts. Waived under the recorded exception (sunset 2026-10-09). This waives that status and nothing else — every other check above is green, and any failure in lint-and-format / test / e2e-status would still refuse.

File overlap with the target branch: zero

Files changed by this PR: 16, all under browser_tests/.
Files changed on cloud/1.54 since this branch's merge base: none.
Overlap: none.

Authority

Christian's 2026-09-16 instruction plus the 2026-09-20 clarification let a worker review and merge an Agent backport onto cloud/1.54 once its own gates pass, without a second approval record. The review above is the author's own, posted as a COMMENT because GitHub will not accept a self-approval; no human objection is outstanding. Merging with --squash --admin --match-head-commit bc8c5c41a0b345f4609be3916146f363c7d0a439.

@christian-byrne
christian-byrne merged commit 9f02eda into cloud/1.54 Sep 26, 2026
94 of 95 checks passed
@christian-byrne
christian-byrne deleted the backport/agent-replay-harness-cloud-1.54 branch September 26, 2026 08:20
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-only Agent tests, fixtures and test support only; no production changes agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 27, 2026

This branch had an error being deployed

1 failed deployment
Preview – billing-web-test — bc8c5c41 Deployed Sep 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-only Agent tests, fixtures and test support only; no production changes agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants