Repository navigation
[backport core/1.54] feat(agent): update consent card launch video - #18782
Conversation
## Summary Linear issue: [DES-1204](https://linear.app/comfyorg/issue/DES-1204/des-update-launch-video-file-in-the-consent-card) The Comfy Agent consent card now plays the new launch video. ## Changes - **What**: - The consent card shows the new Comfy Agent launch video. It replaces the previous video. - The new video is 45 seconds long. The previous video was 22 seconds long. - The video is on the Comfy media server, not in this repository. The card uses three files: a WebM video, an MP4 video for older iPhones, and a still image that shows before the video starts. - The card plays the video muted. For this reason, the video files have no sound track. - The card layout does not change. ## Review Focus - The three files have new names (`agent-consent-v2-*`). As a result, the new video shows only after this PR merges. No browser shows an old cached copy. - The previous video files stay on the media server. The current release continues to use them. - Each new video file is approximately 5 MB. This is approximately 2 MB more than before, because the new video is two times longer. - The browser test now expects the new MP4 file name. The Storybook preview also uses the new files. ## Screenshots (if applicable) New Video https://media.comfy.org/website/comfy-agent/agent-consent-v2-1280.mp4
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
🎭 Playwright: ✅ 1954 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-25T10:51:15.939Z",
"gitSha": "dddf24dc300cdbfa4aee5a06ddcaaed88bf7144a",
"branch": "backport-18765-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2076.3259999999946,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.794,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 582.9290000000001,
"heapDeltaBytes": -12644332,
"heapUsedBytes": 57793296,
"domNodes": 7,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.997999999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2020.4370000000154,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.056,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.854,
"heapDeltaBytes": -11190776,
"heapUsedBytes": 59215640,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.698,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1776.724999999999,
"styleRecalcs": 74,
"styleRecalcDurationMs": 25.404000000000003,
"layouts": 14,
"layoutDurationMs": 3.8460000000000005,
"taskDurationMs": 839.004,
"heapDeltaBytes": 2275904,
"heapUsedBytes": 73549500,
"domNodes": -282,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 150.92600000000002,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1824.8829999999998,
"styleRecalcs": 74,
"styleRecalcDurationMs": 25.229,
"layouts": 14,
"layoutDurationMs": 3.731,
"taskDurationMs": 835.4860000000001,
"heapDeltaBytes": -3739448,
"heapUsedBytes": 67068088,
"domNodes": -279,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 155.25499999999997,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1750.788,
"styleRecalcs": 30,
"styleRecalcDurationMs": 18.934,
"layouts": 6,
"layoutDurationMs": 1.7200000000000002,
"taskDurationMs": 354.84700000000004,
"heapDeltaBytes": 4639824,
"heapUsedBytes": 75800564,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.967,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.0649999999432,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.790000000000001,
"layouts": 6,
"layoutDurationMs": 0.9990000000000001,
"taskDurationMs": 339.15099999999995,
"heapDeltaBytes": 4532560,
"heapUsedBytes": 75873600,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.250000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 606.86800000002,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.2799999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.93199999999996,
"heapDeltaBytes": -8235516,
"heapUsedBytes": 63206800,
"domNodes": 18,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 155.251,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 602.0609999999351,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.063999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.38300000000004,
"heapDeltaBytes": 18306472,
"heapUsedBytes": 88724388,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 158.109,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2016.7879999999627,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.860000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.603,
"heapDeltaBytes": -15902632,
"heapUsedBytes": 87898124,
"domNodes": -271,
"jsHeapTotalBytes": -1900544,
"scriptDurationMs": 28.165999999999997,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2046.4949999999362,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.0870000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.3960000000002,
"heapDeltaBytes": 11132084,
"heapUsedBytes": 87497888,
"domNodes": -269,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 30.625,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2247.4389999999858,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.870999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1618.0529999999999,
"heapDeltaBytes": 3553124,
"heapUsedBytes": 80805192,
"domNodes": -277,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 820.473,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2189.7649999999658,
"styleRecalcs": 64,
"styleRecalcDurationMs": 8.808,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1569.3490000000002,
"heapDeltaBytes": 14047432,
"heapUsedBytes": 82011560,
"domNodes": 4,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 807.804,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3448.3220000000188,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.175000000000004,
"layouts": 60,
"layoutDurationMs": 10.837000000000002,
"taskDurationMs": 1631.2930000000003,
"heapDeltaBytes": 7739828,
"heapUsedBytes": 75786764,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 752.105,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3496.4129999999614,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.129000000000003,
"layouts": 60,
"layoutDurationMs": 10.975999999999999,
"taskDurationMs": 1680.622,
"heapDeltaBytes": 10607768,
"heapUsedBytes": 77279132,
"domNodes": -277,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 781.149,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3118.718000000001,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.583000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1964.2419999999997,
"heapDeltaBytes": 4881968,
"heapUsedBytes": 85331488,
"domNodes": -284,
"jsHeapTotalBytes": -208896,
"scriptDurationMs": 980.726,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3067.809000000011,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.309,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1923.4889999999998,
"heapDeltaBytes": 24281628,
"heapUsedBytes": 94151700,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 964.1270000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2051.2389999999527,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.3840000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 583.002,
"heapDeltaBytes": 8692820,
"heapUsedBytes": 87096384,
"domNodes": -275,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 32.516000000000005,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2027.5260000000799,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.3440000000000034,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.5799999999999,
"heapDeltaBytes": 10053216,
"heapUsedBytes": 87928560,
"domNodes": -272,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 31.499,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 584.1899999999782,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.780999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.818,
"heapDeltaBytes": 15071448,
"heapUsedBytes": 88394316,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 136.54,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 578.689000000054,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.908,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.157,
"heapDeltaBytes": 14589164,
"heapUsedBytes": 87111128,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 138.96900000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2016.6210000000433,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.276000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.8610000000001,
"heapDeltaBytes": -14152128,
"heapUsedBytes": 59079572,
"domNodes": -297,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.190999999999998,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2034.893000000011,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.96,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.344,
"heapDeltaBytes": -8422028,
"heapUsedBytes": 65037912,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 6.992999999999999,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1732.93799999999,
"styleRecalcs": 77,
"styleRecalcDurationMs": 24.981,
"layouts": 18,
"layoutDurationMs": 4.3309999999999995,
"taskDurationMs": 775.494,
"heapDeltaBytes": -9267184,
"heapUsedBytes": 63302164,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 102.901,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.5370000000785,
"styleRecalcs": 77,
"styleRecalcDurationMs": 25.938000000000002,
"layouts": 18,
"layoutDurationMs": 3.9459999999999997,
"taskDurationMs": 784.937,
"heapDeltaBytes": -7248844,
"heapUsedBytes": 65310560,
"domNodes": -294,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 101.94,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.4460000001018,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.12,
"layouts": 15,
"layoutDurationMs": 15.161000000000001,
"taskDurationMs": 898.6840000000003,
"heapDeltaBytes": 21128984,
"heapUsedBytes": 110627684,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 30.455000000000002,
"eventListeners": 2385,
"totalBlockingTimeMs": 134,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8372.707999999988,
"styleRecalcs": 245,
"styleRecalcDurationMs": 30.999999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5731.915000000001,
"heapDeltaBytes": 25059648,
"heapUsedBytes": 90822136,
"domNodes": -272,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 2769.1820000000002,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8269.305000000031,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5604.988,
"heapDeltaBytes": 9511272,
"heapUsedBytes": 85636964,
"domNodes": -245,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 2628.002,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16449.100999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15578.412999999999,
"heapDeltaBytes": -26442884,
"heapUsedBytes": 176464536,
"domNodes": -8068,
"jsHeapTotalBytes": 11689984,
"scriptDurationMs": 255.751,
"eventListeners": -14917,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16362.60100000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15318.942,
"heapDeltaBytes": -41056832,
"heapUsedBytes": 176707212,
"domNodes": -8068,
"jsHeapTotalBytes": -12595200,
"scriptDurationMs": 275.25,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20403.54400000001,
"styleRecalcs": 176,
"styleRecalcDurationMs": 17.185000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20031.478,
"heapDeltaBytes": -52634284,
"heapUsedBytes": 164990620,
"domNodes": -8068,
"jsHeapTotalBytes": -9711616,
"scriptDurationMs": 944.981,
"eventListeners": -14927,
"totalBlockingTimeMs": 27,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20755.853000000003,
"styleRecalcs": 174,
"styleRecalcDurationMs": 16.54800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20311.426,
"heapDeltaBytes": -49775856,
"heapUsedBytes": 168820020,
"domNodes": -8068,
"jsHeapTotalBytes": -12017664,
"scriptDurationMs": 908.035,
"eventListeners": -14925,
"totalBlockingTimeMs": 53,
"frameDurationMs": 17.216666666666665,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 5920.73999999991,
"styleRecalcs": 20,
"styleRecalcDurationMs": 99.12700000000002,
"layouts": 20,
"layoutDurationMs": 33.917,
"taskDurationMs": 5761.909,
"heapDeltaBytes": -41683244,
"heapUsedBytes": 176682932,
"domNodes": -8068,
"jsHeapTotalBytes": 8691712,
"scriptDurationMs": 100.119,
"eventListeners": -14927,
"totalBlockingTimeMs": 325,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6044.483000000014,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.14399999999999,
"layouts": 20,
"layoutDurationMs": 21.798000000000012,
"taskDurationMs": 5882.6410000000005,
"heapDeltaBytes": -47385188,
"heapUsedBytes": 191862684,
"domNodes": -8068,
"jsHeapTotalBytes": 11882496,
"scriptDurationMs": 103.449,
"eventListeners": -14929,
"totalBlockingTimeMs": 475,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8271.988000000078,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7828.03,
"heapDeltaBytes": 24114784,
"heapUsedBytes": 182088264,
"domNodes": 0,
"jsHeapTotalBytes": -4456448,
"scriptDurationMs": 112.73699999999998,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8313.195999999949,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7904.790999999999,
"heapDeltaBytes": 28161720,
"heapUsedBytes": 192821288,
"domNodes": 0,
"jsHeapTotalBytes": -18612224,
"scriptDurationMs": 152.814,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.216666666666665,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 103.1510000000253,
"styleRecalcs": 7,
"styleRecalcDurationMs": 12.319000000000003,
"layouts": 2,
"layoutDurationMs": 0.5849999999999999,
"taskDurationMs": 71.09599999999999,
"heapDeltaBytes": 3118944,
"heapUsedBytes": 71876928,
"domNodes": 110,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.888,
"eventListeners": 35,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 86.49700000000848,
"styleRecalcs": 6,
"styleRecalcDurationMs": 11.449000000000002,
"layouts": 1,
"layoutDurationMs": 0.719,
"taskDurationMs": 58.528,
"heapDeltaBytes": 2981592,
"heapUsedBytes": 71490596,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 3.946999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #18782 +/- ##
============================================
Coverage 83.77% 83.77%
============================================
Files 2104 2104
Lines 124698 124698
Branches 31573 33437 +1864
============================================
+ Hits 104464 104470 +6
+ Misses 20055 20049 -6
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Grant review — core/1.54 backport carrier
Reviewed and merged under program/release-backport-authority.md (Christian's September 16 Agent-backport grant: workers may review and merge Agent backports targeting core/1.54 / cloud/1.54). Posting as a COMMENT rather than an approval because I am authenticated as the merging identity — the grant permits the merge without manufacturing an approval record.
Reviewed head: 03f7c40060489f48e59a467e2125e41708e0446c.
Source applicability
Backport of #18765 (merged to main 2026-09-25T04:01:51Z, 6c7c98f64e79003ac9cfb3158fefabd4f756c695). Agent-related, source already merged, same three files.
Carrier diff vs source diff is content-identical — the only difference in the whole diff is one hunk header offset (@@ -12,9 vs @@ -14,9 in useAgentConsent.ts), i.e. surrounding context on this branch, not a changed line.
The adaptation check this branch now requires
Carrier #18722 broke this branch by landing an import of a module that exists on main and not on core/1.54. Checked for that class explicitly at the merge-candidate head:
| Check | Result |
|---|---|
pnpm typecheck |
clean |
pnpm typecheck:browser |
clean |
pnpm knip:no-cache |
clean |
No new imports, no new modules — three string constants and the spec assertion that tracks them. The media assets the constants point at were verified to exist, since a consent card with a broken video is a user-visible consent-surface defect:
200 video/mp4 agent-consent-v2-1280.mp4
200 video/webm agent-consent-v2-1280.webm
200 image/jpeg agent-consent-v2-poster.jpg
Required checks at the reviewed head: lint-and-format ✅ · test ✅ · e2e-status ✅.
Recorded judgment — two non-required statuses
The exact-head gate (scripts/check-merge-ready.sh --target-branch core/1.54) refuses on two things, both recorded here per the policy's recorded-judgment provision:
1. Staleness — 1 commit behind. The untested delta is exactly #18793, which I merged minutes ago (0e91c54128055ad7999582bfc3b13832fdf7ab95). The gate's own advisory reads:
advisory: 03f7c40060489f48e59a467e2125e41708e0446c is 1 commits behind core/1.54
advisory: ZERO file overlap between this pull request and the untested delta
advisory: overlap is evidence for a recorded judgment, not permission to merge
Rather than rely on the overlap advisory alone, I merged this head onto the new tip locally and re-ran the three checks at that actual merge result: typecheck, typecheck:browser and knip:no-cache all clean. #18793 is 15 files of agent-panel colour constants; this PR is 3 consent-card files. No shared file.
2. Vercel – billing-web-test. FAILURE at the head of every PR on this branch regardless of diff (verified across #18655, #18670, #18673, #18722, #18810, #18811, #18793) — a branch-wide Vercel git-integration artifact, not a signal about this change. Covered by the dated exception in program/release-backport-authority.md, sunset 2026-10-09, which waives that one status and nothing else. Every required check is green; no other adverse check is present.
Merged with --match-head-commit bound to the reviewed head above.
Receipt: reports/jobs/bp-3.md (row bp-3).
Backport of #18765 to
core/1.54Automatically created by backport workflow.