Repository navigation
fix(agent): preserve node color and autogrow input labels across CRDT tab-switch reconcile - #18081
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2041 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.93 MB gzip 🟢 -2 BDetailsSummary
Category Glance App Entry Points — 3.81 kB (baseline 3.81 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 638 kB (baseline 638 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 28 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.86 MB (baseline 3.86 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 566 kB (baseline 566 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.7 MB (baseline 17.7 MB) • ⚪ 0 BBundles that do not match a named category
Status: 1 added / 1 removed / 299 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-20T05:29:19.695Z",
"gitSha": "b0c6df36e711284d1a49cf23503a09268796a19c",
"branch": "test/pm-1339-autogrow-crdt-reconcile-repro",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2053.9699999999925,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.774000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.18600000000004,
"heapDeltaBytes": 11138792,
"heapUsedBytes": 72447404,
"domNodes": -259,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 9.658,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1997.4939999999606,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.944999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 354.50800000000004,
"heapDeltaBytes": 15386480,
"heapUsedBytes": 76294484,
"domNodes": -264,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.714000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1868.073000000038,
"styleRecalcs": 77,
"styleRecalcDurationMs": 29.943,
"layouts": 14,
"layoutDurationMs": 4.515,
"taskDurationMs": 858.1089999999999,
"heapDeltaBytes": 104508,
"heapUsedBytes": 62411024,
"domNodes": -265,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 156.329,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1824.9099999999316,
"styleRecalcs": 76,
"styleRecalcDurationMs": 29.990999999999996,
"layouts": 14,
"layoutDurationMs": 4.463,
"taskDurationMs": 836.649,
"heapDeltaBytes": -361316,
"heapUsedBytes": 61881048,
"domNodes": -261,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 153.21,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.9419999999795,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.199,
"layouts": 6,
"layoutDurationMs": 1.1090000000000002,
"taskDurationMs": 331.415,
"heapDeltaBytes": 2160640,
"heapUsedBytes": 64154932,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.725000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.671999999965,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.712000000000002,
"layouts": 6,
"layoutDurationMs": 1.1209999999999998,
"taskDurationMs": 327.62,
"heapDeltaBytes": 2196544,
"heapUsedBytes": 64072984,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.325000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 628.3169999999814,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.121,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.281,
"heapDeltaBytes": 17896592,
"heapUsedBytes": 79934840,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 157.361,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 623.491999999942,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.231999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.89,
"heapDeltaBytes": 18232492,
"heapUsedBytes": 80271500,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 160.699,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2042.9230000000302,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.417000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.0550000000001,
"heapDeltaBytes": 1852072,
"heapUsedBytes": 82647908,
"domNodes": -249,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 33.672000000000004,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2049.0479999999707,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.666000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.561,
"heapDeltaBytes": 2661528,
"heapUsedBytes": 82730944,
"domNodes": -245,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 34.43599999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2140.5320000000074,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.021000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1530.7389999999998,
"heapDeltaBytes": 18124988,
"heapUsedBytes": 82604692,
"domNodes": -257,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 787.7620000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2165.5550000000403,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.23,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1558.1739999999998,
"heapDeltaBytes": 19321624,
"heapUsedBytes": 83606676,
"domNodes": -253,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 780.072,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3533.1840000000057,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.998999999999999,
"layouts": 60,
"layoutDurationMs": 14.690999999999999,
"taskDurationMs": 1668.117,
"heapDeltaBytes": 8423760,
"heapUsedBytes": 73893128,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 773.7080000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3527.302999999961,
"styleRecalcs": 61,
"styleRecalcDurationMs": 11.666999999999996,
"layouts": 60,
"layoutDurationMs": 14.168,
"taskDurationMs": 1648.4869999999999,
"heapDeltaBytes": 3610500,
"heapUsedBytes": 69562752,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 760.357,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3124.9349999999936,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.284999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1912.2939999999996,
"heapDeltaBytes": 24620884,
"heapUsedBytes": 90499908,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 980.297,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3058.589999999981,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.172999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1874.227,
"heapDeltaBytes": 20533632,
"heapUsedBytes": 86208048,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 962.6839999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2044.9480000000335,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.322000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 604.2299999999999,
"heapDeltaBytes": -7150408,
"heapUsedBytes": 80464848,
"domNodes": -256,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 35.05899999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2028.9579999999887,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.029999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 544.466,
"heapDeltaBytes": -3939404,
"heapUsedBytes": 83559676,
"domNodes": -250,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 32.989000000000004,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 558.3780000000047,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.365,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.454,
"heapDeltaBytes": 13792916,
"heapUsedBytes": 77224948,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 140.953,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 584.8099999999476,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.725,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.1,
"heapDeltaBytes": 13647356,
"heapUsedBytes": 76769560,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 140.549,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1991.290000000049,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.109000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.77900000000005,
"heapDeltaBytes": 17893816,
"heapUsedBytes": 81214488,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.498999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1991.264000000001,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.270999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 350.14599999999996,
"heapDeltaBytes": 2858360,
"heapUsedBytes": 66263864,
"domNodes": -275,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.395999999999997,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1719.095999999979,
"styleRecalcs": 79,
"styleRecalcDurationMs": 27.845000000000002,
"layouts": 18,
"layoutDurationMs": 5.361000000000001,
"taskDurationMs": 769.682,
"heapDeltaBytes": 12306080,
"heapUsedBytes": 75623332,
"domNodes": -273,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 103.20899999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1716.7550000000347,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.536000000000005,
"layouts": 18,
"layoutDurationMs": 5.21,
"taskDurationMs": 774.404,
"heapDeltaBytes": 1094872,
"heapUsedBytes": 64455548,
"domNodes": -275,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 103.26199999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.9399999999387,
"styleRecalcs": 17,
"styleRecalcDurationMs": 27.661000000000005,
"layouts": 5,
"layoutDurationMs": 11.788,
"taskDurationMs": 889.063,
"heapDeltaBytes": 20061264,
"heapUsedBytes": 102208532,
"domNodes": 13587,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 29.804000000000006,
"eventListeners": 2383,
"totalBlockingTimeMs": 132,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8327.99399999999,
"styleRecalcs": 246,
"styleRecalcDurationMs": 40.394999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5746.536,
"heapDeltaBytes": -5368620,
"heapUsedBytes": 75365028,
"domNodes": -253,
"jsHeapTotalBytes": -565248,
"scriptDurationMs": 2703.908,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8254.529000000048,
"styleRecalcs": 248,
"styleRecalcDurationMs": 39.440000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5607.726,
"heapDeltaBytes": -4912024,
"heapUsedBytes": 75243356,
"domNodes": -247,
"jsHeapTotalBytes": 479232,
"scriptDurationMs": 2666.7079999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17846.60500000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17457.011,
"heapDeltaBytes": -36426728,
"heapUsedBytes": 177171616,
"domNodes": -8061,
"jsHeapTotalBytes": -14254080,
"scriptDurationMs": 279.41299999999995,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17483.008999999925,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17095.807999999997,
"heapDeltaBytes": -25477192,
"heapUsedBytes": 190090700,
"domNodes": -8061,
"jsHeapTotalBytes": -8953856,
"scriptDurationMs": 272.769,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21604.228000000036,
"styleRecalcs": 153,
"styleRecalcDurationMs": 19.98999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21472.374,
"heapDeltaBytes": -51602320,
"heapUsedBytes": 166424060,
"domNodes": -8061,
"jsHeapTotalBytes": -13479936,
"scriptDurationMs": 893.141,
"eventListeners": -14928,
"totalBlockingTimeMs": 192,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21117.181000000073,
"styleRecalcs": 156,
"styleRecalcDurationMs": 18.862999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20920.782000000003,
"heapDeltaBytes": -26509376,
"heapUsedBytes": 190326948,
"domNodes": -8061,
"jsHeapTotalBytes": -17309696,
"scriptDurationMs": 850.3340000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 24,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6398.615000000007,
"styleRecalcs": 20,
"styleRecalcDurationMs": 70.94300000000001,
"layouts": 20,
"layoutDurationMs": 24.411,
"taskDurationMs": 6332.259,
"heapDeltaBytes": -38695584,
"heapUsedBytes": 182048708,
"domNodes": -8061,
"jsHeapTotalBytes": 14192640,
"scriptDurationMs": 120.63099999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 447,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6340.954000000011,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.48299999999999,
"layouts": 20,
"layoutDurationMs": 24.45399999999999,
"taskDurationMs": 6258.344999999999,
"heapDeltaBytes": -29884100,
"heapUsedBytes": 183814280,
"domNodes": -8061,
"jsHeapTotalBytes": 17133568,
"scriptDurationMs": 119.259,
"eventListeners": -14928,
"totalBlockingTimeMs": 442,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8756.759000000045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8674.194,
"heapDeltaBytes": 8910592,
"heapUsedBytes": 180160032,
"domNodes": 0,
"jsHeapTotalBytes": -18612224,
"scriptDurationMs": 133.55899999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8710.381999999981,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8505.918999999998,
"heapDeltaBytes": -19008872,
"heapUsedBytes": 168122968,
"domNodes": 0,
"jsHeapTotalBytes": -12582912,
"scriptDurationMs": 161.04399999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 105.52099999995335,
"styleRecalcs": 7,
"styleRecalcDurationMs": 16.413,
"layouts": 2,
"layoutDurationMs": 1.352,
"taskDurationMs": 80.87700000000001,
"heapDeltaBytes": 3086948,
"heapUsedBytes": 64755480,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.541,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 114.20599999996739,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.633000000000003,
"layouts": 2,
"layoutDurationMs": 0.6280000000000001,
"taskDurationMs": 79.595,
"heapDeltaBytes": 3045176,
"heapUsedBytes": 64593828,
"domNodes": 108,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.409,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3d800ea3d63ee77f5bdf8b78c0264c7d838f1057
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
b76f4e2 to
396ef32
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18081 +/- ##
==========================================
+ Coverage 82.78% 83.83% +1.04%
==========================================
Files 2938 2254 -684
Lines 144523 128216 -16307
Branches 39036 34782 -4254
==========================================
- Hits 119650 107490 -12160
+ Misses 23617 20437 -3180
+ Partials 1256 289 -967
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 777 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
835e4c9 to
48615dc
Compare
|
Reviewed as part of a sweep of the three open PM-1155-family PRs (#18079, #18081, #18089). Verdict: this is the one that actually fixes the bug — the PR description undersells it. What's really in this diff: despite the PR body describing a "failing repro… does not fix the underlying bug," the current diff on this branch also changes Correctness check (per the RCA): Coverage vs. the sibling tickets:
Merge-conflict heads up: #18079 and #18089 both insert a new test at the exact same point in 🤖 Generated with Claude Code |
28d617d to
7c6077d
Compare
…tab switch Adds a Playwright test.fail() repro: a node with an autogrow input group (e.g. GPT Image 2.5's model.images.image_N slots) loses its API-node color and shows the raw internal dotted input name instead of the short autogrow label once the tab is switched away and back after the in-app agent has wired something into one of those inputs over the CRDT graph-mutation layer. Root cause (no fix yet): nodeDataStore.ts's assignNodeFields, called from updateNode during the CRDT follower's tab-switch reconcile (useAgentCrdtFollower.ts / agentNodeMaterializer.ts), unconditionally resets color/bgcolor and replaces state.inputs wholesale from the CRDT payload, which never carries node color or the autogrow-computed localized_name.
The CRDT document never carries node color or the autogrow-computed localized_name/label, so a reconcile that wholesale-replaced these fields from the payload was wiping them. prepareNode/prepareInputSlots now fall back to the live node's existing color and, for an input slot matched by index and name, its existing localized_name/label, instead of losing them on a tab-switch-triggered reconcile.
vue-tsc's browser_tests project check flagged the raw numeric GPT_NODE_ID passed to graph.getNodeById, which expects the branded NodeId type.
prepareNode's CRAP score exceeded the fallow audit threshold after the color/label preservation fix added bgcolor/boxcolor/color fallback-to-existing logic on top of its existing resizable/shape/showAdvanced conditional spreads. Split both into resolveNodeColors and resolveNodeDisplayFlags, small single-purpose helpers colocated in the same file. No behavior change.
…putSlots/resolveNodeColors fallow's CRAP-score gate flagged two functions introduced by this PR at CRAP 31.6 (threshold 30): the prepareInputSlots map callback and resolveNodeColors. Extract applySlotLink/preserveSlotDisplayMetadata/ prepareInputSlot and resolveColorField as named helpers to lower branching per function without changing behavior.
This PR's actual fix in prepareNode/prepareInputSlots (preserving a live node's color and an autogrow input's friendly label across a CRDT reconcile) had only the new Playwright e2e spec covering it, no fast Vitest regression guard in this file. Adds one test proving the merge onto existing state, and one proving the merge doesn't turn into a pin: a doc payload that legitimately provides a new color, or a genuinely different input at the same slot index, must still take effect.
7c6077d to
f3ccb57
Compare
|
Thanks for the review. The PR description now leads with "This PR fixes that" rather than describing a repro-only change, so that's addressed. The unit-test coverage you added in commit Created by Claude Tag |
The spec referenced enMessages.agent.askComfyAgent, a key that only exists in translated locales and not in en/main.json, so the accessible name was undefined and the click matched all 67 buttons on the page. The actual entry button (AgentEntryButton.vue) uses agent.entryButton, matching the key other agent-panel tests already rely on.
Resolves the graphMutations.ts conflict: both branches independently appended new helper functions at the same insertion point (Bounds/ placeNewNode/withPlacedSerialization from this branch's template far- position fix, resolveNodeColors/resolveNodeDisplayFlags from main's PR #18081). Kept both blocks; neither depends on the other and each one's call sites elsewhere in the file were already merged cleanly.
… tab-switch reconcile (#18081) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789709391046969?thread_ts=1789709391.046969&cid=C0BGH348Z0C)_ Fixes an autogrow-node color and input label loss on tab switch: a CRDT reconcile in `graphMutations.ts` now merges onto the live node's state instead of wholesale-replacing it, so client-only presentation fields the CRDT document never carries survive a tab-switch reconcile. Includes the Playwright repro that pins the exact symptom (originally added as `test.fail()`, now passing as a normal `test()`) plus new unit coverage of the merge behavior. - **What**: Before this PR, a node with an autogrow input group (e.g. GPT Image 2.5's `model.images.image_N` slots) lost its API-node color and showed the raw internal dotted input name after the in-app agent wired something into it and the tab was switched away and back — a CRDT reconcile in `nodeDataStore.ts`'s `assignNodeFields` (via `updateNode`) unconditionally reset `color`/`bgcolor` and replaced `state.inputs` wholesale from a CRDT payload that never carries either. **This PR fixes that** in `src/workbench/extensions/agent/crdt/graphMutations.ts`: `resolveNodeColors` keeps the live node's `color`/`bgcolor`/`boxcolor` when the payload omits them, and `preserveSlotDisplayMetadata` (used by the new `prepareInputSlot`) keeps an existing input slot's `localized_name`/`label` when the payload's slot at the same index and name doesn't carry one — while still applying an explicit value the payload does set, and not carrying stale labels onto a genuinely different input at the same slot index. - **Tests**: `browser_tests/tests/agent/agentAutogrowTabSwitchReconcile.spec.ts` sets up the exact repro scenario (a wired autogrow node materialized via the CRDT graph-mutation layer), confirms the node renders correctly before the tab switch, switches to a new tab and back to force the CRDT follower's tab-switch reconcile (`useAgentCrdtFollower.ts`), and asserts the color and label are still correct afterward. This started as a `test.fail()` pinning the bug; with the fix in place it now passes as a normal `test()`. `graphMutations.test.ts` adds two unit-level regression guards for the same merge behavior (color/label preserved on an omitted-field reconcile; not stale when the payload does supply new values). - **Root cause / blast radius**: per the RCA in the spec file's header comment, this reconcile path (`prepareNode`/`prepareInputSlots`) is shared across every `reconcileNode` call, so the fix likely also addresses other reports of the same class of client-only-field loss on CRDT reconcile, not just the tab-switch trigger covered here. - **Breaking**: none - **Dependencies**: none - The merge logic in `graphMutations.ts` (`resolveNodeColors`, `preserveSlotDisplayMetadata`/`prepareInputSlot`): confirm it only fills in fields the payload omits and never masks a value the payload does set (see the second new unit test in `graphMutations.test.ts` for that guard). - The fix lives in the shared `prepareNode`/`prepareInputSlots` reconcile path, so it likely also resolves other reports of the same class of bug beyond the tab-switch trigger covered here. - Confirmed locally: the Playwright repro spec passes, and the new `graphMutations.test.ts` unit tests pass. <!-- Fixes #ISSUE_NUMBER --> N/A (non-visual regression test) 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01Mj4zDEXP8JxWeNcX24RGGw --------- Co-authored-by: bymyself <cbyrne@comfy.org> (cherry picked from commit 9f78312)
… tab-switch reconcile (#18081) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789709391046969?thread_ts=1789709391.046969&cid=C0BGH348Z0C)_ Fixes an autogrow-node color and input label loss on tab switch: a CRDT reconcile in `graphMutations.ts` now merges onto the live node's state instead of wholesale-replacing it, so client-only presentation fields the CRDT document never carries survive a tab-switch reconcile. Includes the Playwright repro that pins the exact symptom (originally added as `test.fail()`, now passing as a normal `test()`) plus new unit coverage of the merge behavior. - **What**: Before this PR, a node with an autogrow input group (e.g. GPT Image 2.5's `model.images.image_N` slots) lost its API-node color and showed the raw internal dotted input name after the in-app agent wired something into it and the tab was switched away and back — a CRDT reconcile in `nodeDataStore.ts`'s `assignNodeFields` (via `updateNode`) unconditionally reset `color`/`bgcolor` and replaced `state.inputs` wholesale from a CRDT payload that never carries either. **This PR fixes that** in `src/workbench/extensions/agent/crdt/graphMutations.ts`: `resolveNodeColors` keeps the live node's `color`/`bgcolor`/`boxcolor` when the payload omits them, and `preserveSlotDisplayMetadata` (used by the new `prepareInputSlot`) keeps an existing input slot's `localized_name`/`label` when the payload's slot at the same index and name doesn't carry one — while still applying an explicit value the payload does set, and not carrying stale labels onto a genuinely different input at the same slot index. - **Tests**: `browser_tests/tests/agent/agentAutogrowTabSwitchReconcile.spec.ts` sets up the exact repro scenario (a wired autogrow node materialized via the CRDT graph-mutation layer), confirms the node renders correctly before the tab switch, switches to a new tab and back to force the CRDT follower's tab-switch reconcile (`useAgentCrdtFollower.ts`), and asserts the color and label are still correct afterward. This started as a `test.fail()` pinning the bug; with the fix in place it now passes as a normal `test()`. `graphMutations.test.ts` adds two unit-level regression guards for the same merge behavior (color/label preserved on an omitted-field reconcile; not stale when the payload does supply new values). - **Root cause / blast radius**: per the RCA in the spec file's header comment, this reconcile path (`prepareNode`/`prepareInputSlots`) is shared across every `reconcileNode` call, so the fix likely also addresses other reports of the same class of client-only-field loss on CRDT reconcile, not just the tab-switch trigger covered here. - **Breaking**: none - **Dependencies**: none - The merge logic in `graphMutations.ts` (`resolveNodeColors`, `preserveSlotDisplayMetadata`/`prepareInputSlot`): confirm it only fills in fields the payload omits and never masks a value the payload does set (see the second new unit test in `graphMutations.test.ts` for that guard). - The fix lives in the shared `prepareNode`/`prepareInputSlots` reconcile path, so it likely also resolves other reports of the same class of bug beyond the tab-switch trigger covered here. - Confirmed locally: the Playwright repro spec passes, and the new `graphMutations.test.ts` unit tests pass. <!-- Fixes #ISSUE_NUMBER --> N/A (non-visual regression test) 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01Mj4zDEXP8JxWeNcX24RGGw --------- Co-authored-by: bymyself <cbyrne@comfy.org> (cherry picked from commit 9f78312)
…#18070) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789610676316069?thread_ts=1789610676.316069&cid=C0BGH348Z0C)_ ## Summary Fixes the false "invalid" red ring on combo widgets in agent workflow tabs by closing both mechanisms behind it. **Before:** repro-only. Two `it.fails` pins: `WidgetSelectDefault` marking an agent-created node's placeholder widget (`options: {}`) invalid, and `graphMutations.setWidget` writing the widget store without ever reaching the live widget's `callback`. **After:** - **Mechanism A (placeholder window)**: `WidgetSelectDefault.isInvalid` no longer flags a value while `options.values` is still undefined, so a placeholder widget's legitimate value renders clean until the node materializes. - **Mechanism B (contract gap)**: agent writes now run the same live-widget effects a human edit runs, per [ADR-CRDT-WIDGETS-0036](docs/adr/CRDT-WIDGETS-0036-agent-widget-writes-run-live-widget-effects.md). `GraphMutationsDeps` gains a required renderer-owned `widgets: SemanticWidgetEffectPort`; both follower write paths (named `set_widget`, positional reconcile) go through one `applyWidgetWrite` helper; a batch records an effect only when the write applied and the store's post-write value differs from the previous one (`Object.is` for primitives, structural equality for objects, so the clone every doc value takes cannot count as a change and a normalizing callback cannot loop through its mint echo); effects drain after `commit` in payload order, each call isolated behind `reportError('error_applying_agent_widget_effects')`. The new `createLiveWidgetEffectPort` resolves the live node the way the Vue render model does (`resolveLiveWidget`), requires the store to still own it (so an orphan left by an in-batch replace or delete never receives its successor's value), then assigns `widget.value`, runs `callback(value, canvas, node)` and `node.onWidgetChanged`, and redraws. Wired in `AgentPanelRoot.vue`. Concrete beneficiaries beyond the ring: Custom Combo's `option*` value setters (agent edits now rebuild its option list) and `PrimitiveNode`'s `callback → applyToGraph` (agent edits to a primitive now propagate to linked targets). An agent write also clears `required_input_missing` for that widget through the existing `onWidgetChanged` hook. ## Changes - `docs/adr/CRDT-WIDGETS-0036-agent-widget-writes-run-live-widget-effects.md` (+ README index row): the design, amended after adversarial review (structural change gate, ownership gating, placeholder semantics by live-node presence, `onWidgetChanged` contract, reentrancy and drain order, subgraph note). - `src/workbench/extensions/agent/crdt/graphMutations.ts`: `SemanticWidgetEffectPort`, `applyWidgetWrite`, post-commit drain. - `src/workbench/extensions/agent/crdt/liveWidgetEffects.ts` (new): `createLiveWidgetEffectPort({ getGraph, getCanvas })`, with the guards in a `resolveLiveWidget` helper. - `src/workbench/extensions/agent/crdt/__fixtures__/widgetEffectPorts.ts` (new): inert and recording ports for the other construction sites. - `src/workbench/extensions/agent/AgentPanelRoot.vue`: wiring. - `src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDefault.vue`: mechanism A. - Tests: the placeholder repro now a plain `it` (fixture adapted to a live `LGraph`; assertion unchanged); port-contract table in `graphMutations.test.ts`; `liveWidgetEffects.test.ts` (callback and `onWidgetChanged` arguments, no-ops for store-only nodes, missing widgets, a foreign root graph, the orphan after an in-batch `replaceNode`, drain-time resolution, `required_input_missing` clearing); mint-echo test in `agentCrdtProjection.integration.test.ts` (a callback that rewrites its own object value mints one human `set_widget`; the echo frame mints nothing). ## Red-Green Verification | Commit | CI | Purpose | |--------|----|---------| | `test(agent): pin live widget effects for agent writes` | red | Proves the tests catch the gap | | `fix(agent): run the live widget's effects for agent widget writes` | green | Proves the fix resolves it | ## Scope notes - The autogrow / node-field display bugs are out of scope here; they are a different mechanism (`prepareNode` replacing live node fields wholesale) and are owned by Comfy-Org#18081. - **Comfy-Org#18089** pins that a doc value must not overwrite a newer local value. Its recency guard lands inside the same `applyWidgetWrite` helper introduced here and should report `applied: false`, which by construction records no effect. Expect a small merge on that helper and on the `GraphMutationsDeps` type (Comfy-Org#18084 adds `placement`). - Extension authors: a widget's `callback` and its node's `onWidgetChanged` now also fire when the in-app agent changes the value, with `(value, canvas, node)` and no pointer arguments. Treat it as programmatic, like a remote option refresh. - Ring clearance for a combo whose callback rebuilds `options.values` additionally depends on that mutation being reactive (Custom Combo's `shallowReactive` splice is; a raw `widget.options.values = …` write is not). Documented in the ADR; a renderer concern outside this PR. - No e2e added: the agent replay harness needs a live CRDT-enabled backend. A follow-up may pin `aria-invalid` absence after an agent set plus tab switch next to `agentTabSwitchCatchUp.spec.ts`. ## Review Focus - `graphMutations.ts` `writeWidget` / `applyWidgetWrite` and the drain in `batch`. - `liveWidgetEffects.ts` ownership check (`useNodeDataStore().ownsNode`) and root-graph guard. - `pnpm exec vitest run src/workbench/extensions/agent/ src/renderer/extensions/vueNodes/widgets/ src/stores/`: all pass, 1 expected fail (pre-existing serialize pin). `pnpm typecheck`, `pnpm lint`, `pnpm format:check`, `pnpm knip`: clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01Nxv4TewGb9qXkwjUMofZ8D --- _Generated by [Claude Code](https://claude.ai/code/session_01Nxv4TewGb9qXkwjUMofZ8D)_ --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: bymyself <cbyrne@comfy.org>
## Summary Seventeen non-billing Agent sources are carried for `core/1.54`. Exact-head hosted checks and target-native replay acceptance pass; review remains. <details><summary>Full context for agent readers</summary> ## Changes - **Sources**: [18113](#18113), [18096](#18096), [18122](#18122), [18164](#18164), [18121](#18121), [18148](#18148), [18111](#18111), [18174](#18174), [17912](#17912), [18081](#18081), [16936](#16936), [18183](#18183), [18197](#18197), [18070](#18070), [18084](#18084), [18071](#18071), and [18107](#18107). - **New in this head**: PR 18107 rejects incompatible Agent-created links, retires incompatible retained links from the local projection, and keeps one bad link from blocking unrelated later edits. Main-only Load3D coverage is adapted onto the release-local unit, `HostDoc`, and tab-return harnesses. - **Dependencies**: no new package dependency; release lockfile pins are preserved. - **Exclusions**: billing/account work, protected source [17730](#17730), target-specific screenshot source [18168](#18168), separately owned focused carriers, and [18123](#18123), whose generic Vue-node test depends on [17576](#17576), absent from this release line. ## Review focus - PR 16936 adapts widget-state rebinding to the 1.54 store API without importing `main`'s newer visibility architecture. - PR 18070 runs target-local live widget projection callbacks with the canvas and owner node while retaining the release projection boundary. - PR 18084 adds placement as a renderer-owned port; resync materializations retain document coordinates, while new offscreen batches move together beside existing content. - The release browser harness seeds the same client-only API-node colors that normal node registration owns before testing whether a later CRDT reconcile preserves them. - This is not behavioral acceptance, deployment authorization, or a merge-check waiver. ## Exact-head verification Current head: `2bd4dace2e6207fede11d2ac219d691a811769dc`, verified under Node 25.9.0 and pnpm 11.13.1. - main typecheck passed with an 8 GiB heap at the production-identical parent; this head changes only the browser harness lifecycle; - the prior 146-test selection passed with 1 expected failure; - after repairing idempotent replay, 119 focused tests passed with 1 expected failure; - the exact head passes browser typecheck and adds a target-native check that the missing checkpoint value and `aria-invalid=true` survive tab return; - ancestor head `bd7da3cffd6dc349e1c48c5a277bc112cabd0e41` passed one zero-retry target-native warning-retention case with an inspected final frame; its [durable QA receipt](https://github.com/christian-byrne/in-app-agent-program/blob/7fa0ba4d731f00684388a45f1aeb1d24dc6f2280/reports/pr-ownership/2026-09-20-missing-model-tab-warning.md#1145-utc-exact-core-native-case-passes-final-warning-frame-inspected) is ancestry evidence, not acceptance of this newer head; - frozen installation and main typecheck pass at the production-identical parent; browser typecheck, target-native browser collection, formatting, ESLint, fixture mint/projection, and diff checks pass at this exact head; - the extended browser case commits pasted-node operations through the real `HostDoc` and asserts the pasted position survives another tab retarget; - parent head `389a3718bd2f637f704bde349068cbfd87cd9542` passed warning, node-presentation, and viewport assertions but stopped before paste because the zoom popup backdrop intercepted node selection; this head closes the popup through its real toggle and asserts it hidden before selection; - the first PR 18107 browser head stopped before app boot because the force-input string sink serialized one widget value while declaring no widgets; this head removes that non-widget value, and the exact fixture contract now mints and projects successfully; - parent head `366e0287095876351377f873688fece88eb90397` reached local paste but had already closed the Agent panel, which unmounted `AgentPanelRoot`, detached mint-port wiring, and disposed the CRDT follower; this head preserves the closed-panel screenshot, then reopens the panel and requires a fresh workflow subscription before mutation while retaining the unchanged `HostDoc` assertion; - one zero-retry target-native invocation passed the complete case at 13:44:02 UTC: warning retention, node presentation, popup closure, fresh subscription, local and host paste position after a second retarget, incompatible-link retirement, and the subsequent Agent edit; the [durable QA receipt](https://github.com/christian-byrne/in-app-agent-program/blob/28f5a4bb05318cc4e1a95d819951f7924bf9d2c2/reports/pr-ownership/2026-09-20-missing-model-tab-warning.md#1345-utc-both-lifecycle-corrected-candidates-pass-the-complete-native-case) includes inspected frames and cleanup; - PR 18107's exact-head focused coverage passes 63 tests with 1 expected failure; main and browser typechecks, targeted formatting and ESLint, and three affected Cloud-project browser cases also collect successfully; - targeted format and ESLint passed; - three affected Cloud-project browser cases collected successfully. Exact-head hosted checks and target-native replay acceptance pass. Review and the release-target merge-readiness gate remain required before merge. No deployment or check waiver is authorized. </details> Justification: Authorized Agent 1.54 release backport aggregate merged without standing human approval under the published release-backport authority; exact-head hosted checks, target-native replay acceptance, target-aware merge guard, adaptation review, and absence of unresolved human objections limit risk. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
## Summary Seventeen non-billing Agent sources are carried for `cloud/1.54`. The candidate now contains release `1.54.12`; fresh hosted checks and target-native replay acceptance passed. <details><summary>Full context for agent readers</summary> ## Changes - **Sources**: [18113](#18113), [18096](#18096), [18122](#18122), [18164](#18164), [18121](#18121), [18148](#18148), [18111](#18111), [18174](#18174), [17912](#17912), [18081](#18081), [16936](#16936), [18183](#18183), [18197](#18197), [18070](#18070), [18084](#18084), [18071](#18071), and [18107](#18107). - **New in this head**: PR 18107 rejects incompatible Agent-created links, retires incompatible retained links from the local projection, and keeps one bad link from blocking unrelated later edits. Main-only Load3D coverage is adapted onto the release-local unit, `HostDoc`, and tab-return harnesses. - **Dependencies**: no new package dependency; release lockfile pins are preserved. - **Exclusions**: billing/account work, protected source [17730](#17730), target-specific screenshot source [18168](#18168), separately owned focused carriers, and [18123](#18123), whose generic Vue-node test depends on [17576](#17576), absent from this release line. ## Review focus - PR 16936 adapts widget-state rebinding to the 1.54 store API without importing `main`'s newer visibility architecture. - PR 18070 runs target-local live widget projection callbacks with the canvas and owner node while retaining the release projection boundary. - PR 18084 adds placement as a renderer-owned port; resync materializations retain document coordinates, while new offscreen batches move together beside existing content. - The release browser harness seeds the same client-only API-node colors that normal node registration owns before testing whether a later CRDT reconcile preserves them. - This is not behavioral acceptance, deployment authorization, or a merge-check waiver. ## Exact-head verification Current head: `aabd82168d2d7b2f1b9f685a5477dcdc491d3b02`, verified locally under Node 25.9.0 and pnpm 11.13.1. - merged current `cloud/1.54` tip `d2667baf6bdb8664821b4bed7a7f5a1df65f9f49` cleanly; the imported release delta is limited to the package version and locale data; - frozen installation, 174 focused Agent/missing-model tests with 1 expected failure, main and browser typechecks, formatting, full ESLint with zero errors, the Cloud production build, target ancestry, and diff checks pass locally; - fresh exact-head hosted checks and one zero-retry target-native replay passed after the release target changed; - main typecheck passed with an 8 GiB heap at the production-identical parent; this head changes only the browser harness lifecycle; - the prior 146-test selection passed with 1 expected failure; - after repairing idempotent replay, 119 focused tests passed with 1 expected failure; - the exact head passes browser typecheck and adds a target-native check that the missing checkpoint value and `aria-invalid=true` survive tab return; - frozen installation and main typecheck pass at the production-identical parent; browser typecheck, target-native browser collection, formatting, ESLint, fixture mint/projection, and diff checks pass at this exact head; - the extended browser case commits pasted-node operations through the real `HostDoc` and asserts the pasted position survives another tab retarget; - parent head `dfe99947cffb5f31c5f4750113eb9770720e5eac` passed warning, node-presentation, and viewport assertions but stopped before paste because the zoom popup backdrop intercepted node selection; this head closes the popup through its real toggle and asserts it hidden before selection; - the first PR 18107 browser head stopped before app boot because the force-input string sink serialized one widget value while declaring no widgets; this head removes that non-widget value, and the exact fixture contract now mints and projects successfully; - parent head `5ec6c64e9b78b56b12350ae732dc1e1ea20052e0` reached local paste but had already closed the Agent panel, which unmounted `AgentPanelRoot`, detached mint-port wiring, and disposed the CRDT follower; this head preserves the closed-panel screenshot, then reopens the panel and requires a fresh workflow subscription before mutation while retaining the unchanged `HostDoc` assertion; - one zero-retry target-native invocation passed the complete case at 13:45:15 UTC: warning retention, node presentation, popup closure, fresh subscription, local and host paste position after a second retarget, incompatible-link retirement, and the subsequent Agent edit; the [durable QA receipt](https://github.com/christian-byrne/in-app-agent-program/blob/28f5a4bb05318cc4e1a95d819951f7924bf9d2c2/reports/pr-ownership/2026-09-20-missing-model-tab-warning.md#1345-utc-both-lifecycle-corrected-candidates-pass-the-complete-native-case) includes inspected frames and cleanup; - PR 18107's exact-head focused coverage passes 63 tests with 1 expected failure; main and browser typechecks, targeted formatting and ESLint, and three affected Cloud-project browser cases also collect successfully; - targeted format and ESLint passed; - three affected Cloud-project browser cases collected successfully. The prior replay receipt remains historical evidence for parent head `516f6b5f71e251b25985fb61715432f05249c4bd`. Fresh hosted checks and the fresh target-native replay passed at current head `aabd82168d2d7b2f1b9f685a5477dcdc491d3b02`; adaptation review and the release-target merge-readiness gate also passed. </details> Justification: Author-owned release aggregate merged under the published Agent 1.54 backport grant after exact-head hosted checks, target-native replay, adaptation review, target ancestry, and the target-aware merge guard passed; no independent approval was available. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
|
|
|
No new manual backport PRs needed. The fix and regressions are already present on both 1.54 release branches. Full context for agent readersThe newly triggered backport jobs conflict because this content was carried earlier by the catalogue sweep:
Read-back against current branch heads:
Both branches contain |
|
|
|
|
|
|
<!-- ccr-slack-attribution -->
Requested by Christian Byrne · Slack thread
Summary
Fixes an autogrow-node color and input label loss on tab switch: a CRDT reconcile in
graphMutations.tsnow merges onto the live node's state instead of wholesale-replacing it, so client-only presentation fields the CRDT document never carries survive a tab-switch reconcile. Includes the Playwright repro that pins the exact symptom (originally added astest.fail(), now passing as a normaltest()) plus new unit coverage of the merge behavior.Changes
model.images.image_Nslots) lost its API-node color and showed the raw internal dotted input name after the in-app agent wired something into it and the tab was switched away and back — a CRDT reconcile innodeDataStore.ts'sassignNodeFields(viaupdateNode) unconditionally resetcolor/bgcolorand replacedstate.inputswholesale from a CRDT payload that never carries either. This PR fixes that insrc/workbench/extensions/agent/crdt/graphMutations.ts:resolveNodeColorskeeps the live node'scolor/bgcolor/boxcolorwhen the payload omits them, andpreserveSlotDisplayMetadata(used by the newprepareInputSlot) keeps an existing input slot'slocalized_name/labelwhen the payload's slot at the same index and name doesn't carry one — while still applying an explicit value the payload does set, and not carrying stale labels onto a genuinely different input at the same slot index.browser_tests/tests/agent/agentAutogrowTabSwitchReconcile.spec.tssets up the exact repro scenario (a wired autogrow node materialized via the CRDT graph-mutation layer), confirms the node renders correctly before the tab switch, switches to a new tab and back to force the CRDT follower's tab-switch reconcile (useAgentCrdtFollower.ts), and asserts the color and label are still correct afterward. This started as atest.fail()pinning the bug; with the fix in place it now passes as a normaltest().graphMutations.test.tsadds two unit-level regression guards for the same merge behavior (color/label preserved on an omitted-field reconcile; not stale when the payload does supply new values).prepareNode/prepareInputSlots) is shared across everyreconcileNodecall, so the fix likely also addresses other reports of the same class of client-only-field loss on CRDT reconcile, not just the tab-switch trigger covered here.Review Focus
graphMutations.ts(resolveNodeColors,preserveSlotDisplayMetadata/prepareInputSlot): confirm it only fills in fields the payload omits and never masks a value the payload does set (see the second new unit test ingraphMutations.test.tsfor that guard).prepareNode/prepareInputSlotsreconcile path, so it likely also resolves other reports of the same class of bug beyond the tab-switch trigger covered here.graphMutations.test.tsunit tests pass.<!-- Fixes #ISSUE_NUMBER -->
Screenshots (if applicable)
N/A (non-visual regression test)
🤖 Generated with Claude Code
https://claude.ai/code/session_01Mj4zDEXP8JxWeNcX24RGGw