Repository navigation
fix(agent): flag LoadImage's image input as upload-capable in agent replay fixtures - #18338
Conversation
…eplay fixtures The LoadImage node def in browser_tests/fixtures/data/agentReplayNodeDefs.ts declared its `image` combo without `image_upload: true`, so Comfy.UploadImage's beforeRegisterNodeDef hook never found it and never wired imageInputName onto the `upload` input. useImageUploadWidget's constructor then throws for that input, LiteGraph.createNode catches the exception and returns null, and the node degrades to a broken placeholder instead of a real LoadImage node.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since ec5da77d0ff9a45d637bcfe128772ac8557e8a06
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2074 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle: 9.96 MB gzip 🟢 -561 BDetailsSummary
Category Glance App Entry Points — 3.87 kB (baseline 3.87 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.46 MB (baseline 1.46 MB) • 🟢 -57 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 123 kB (baseline 123 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.88 MB (baseline 3.88 MB) • 🟢 -2.19 kBStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 577 kB (baseline 577 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 19 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.8 MB (baseline 17.8 MB) • ⚪ 0 BBundles that do not match a named category
Status: 74 added / 74 removed / 228 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-22T02:49:51.137Z",
"gitSha": "c678fe7ec693f61a6a1cfe80201afd1b3f61c4ca",
"branch": "fix/agent-replay-loadimage-missing-upload-flag",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1990.4949999998962,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.684000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 342.604,
"heapDeltaBytes": 10456204,
"heapUsedBytes": 72748444,
"domNodes": -261,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 8.066,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1992.3310000000356,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.709999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 347.218,
"heapDeltaBytes": 15144368,
"heapUsedBytes": 77394788,
"domNodes": -262,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.9659999999999975,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1777.5899999999183,
"styleRecalcs": 74,
"styleRecalcDurationMs": 34.845,
"layouts": 14,
"layoutDurationMs": 4.104,
"taskDurationMs": 784.698,
"heapDeltaBytes": 2044208,
"heapUsedBytes": 64136264,
"domNodes": -262,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 177.79600000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1770.5780000000004,
"styleRecalcs": 74,
"styleRecalcDurationMs": 26.48,
"layouts": 14,
"layoutDurationMs": 4.114,
"taskDurationMs": 825.275,
"heapDeltaBytes": 2540448,
"heapUsedBytes": 64672224,
"domNodes": -261,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 163.676,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.8309999999947,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.959999999999999,
"layouts": 6,
"layoutDurationMs": 1.1210000000000002,
"taskDurationMs": 316.621,
"heapDeltaBytes": 2211588,
"heapUsedBytes": 64347676,
"domNodes": 74,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.262999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.14300000005,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.594999999999997,
"layouts": 6,
"layoutDurationMs": 1.01,
"taskDurationMs": 321.051,
"heapDeltaBytes": 2125700,
"heapUsedBytes": 64405600,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.768,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 612.5739999999951,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.684,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.367,
"heapDeltaBytes": 18216732,
"heapUsedBytes": 80481980,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 170.343,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 642.1589999999924,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.312,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.09,
"heapDeltaBytes": 18551968,
"heapUsedBytes": 80722600,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 173.714,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1149.1039999999657,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 770.18,
"heapDeltaBytes": 38353604,
"heapUsedBytes": 107407968,
"domNodes": 0,
"jsHeapTotalBytes": 20606976,
"scriptDurationMs": 66.654,
"eventListeners": 0,
"totalBlockingTimeMs": 550,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1181.051000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 832.3570000000001,
"heapDeltaBytes": 5107708,
"heapUsedBytes": 82990300,
"domNodes": 0,
"jsHeapTotalBytes": 18247680,
"scriptDurationMs": 70.587,
"eventListeners": 0,
"totalBlockingTimeMs": 562,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 866.7669999999816,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.7730000000004,
"heapDeltaBytes": 16003716,
"heapUsedBytes": 91940264,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 172.689,
"eventListeners": 0,
"totalBlockingTimeMs": 230,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 840.9030000000257,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.74899999999997,
"heapDeltaBytes": 14365964,
"heapUsedBytes": 90478964,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 162.798,
"eventListeners": 0,
"totalBlockingTimeMs": 228,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10886.735000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9911.663,
"heapDeltaBytes": -3636316,
"heapUsedBytes": 72603776,
"domNodes": -16,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 8486.108,
"eventListeners": 0,
"totalBlockingTimeMs": 1572,
"frameDurationMs": 18.889999999999965,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 12104.21299999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11161.791000000001,
"heapDeltaBytes": 12636340,
"heapUsedBytes": 94551932,
"domNodes": -12,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 9465.503999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1984,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10126.882000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9261.463000000002,
"heapDeltaBytes": -9315812,
"heapUsedBytes": 72687576,
"domNodes": -14,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7605.558999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1052,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10609.916999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9762.34,
"heapDeltaBytes": -10640352,
"heapUsedBytes": 71419196,
"domNodes": -12,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 8139.303,
"eventListeners": 0,
"totalBlockingTimeMs": 1323,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "large-graph-idle",
"durationMs": 2026.9819999999754,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.804999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.0519999999999,
"heapDeltaBytes": 2394548,
"heapUsedBytes": 83882820,
"domNodes": -248,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 32.12100000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2027.5729999999612,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.374000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.705,
"heapDeltaBytes": 3431992,
"heapUsedBytes": 83211256,
"domNodes": -250,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 32.67500000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2182.9669999999624,
"styleRecalcs": 65,
"styleRecalcDurationMs": 9.832,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1581.5780000000002,
"heapDeltaBytes": 16115884,
"heapUsedBytes": 80171832,
"domNodes": -254,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 828.8449999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2485.149999999976,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.689,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1731.719,
"heapDeltaBytes": 16493276,
"heapUsedBytes": 80558492,
"domNodes": -254,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 891.7819999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3531.970000000001,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.582,
"layouts": 60,
"layoutDurationMs": 12.475999999999999,
"taskDurationMs": 1659.3080000000002,
"heapDeltaBytes": 9541360,
"heapUsedBytes": 75421156,
"domNodes": -257,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 781.06,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3493.105000000014,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.019,
"layouts": 60,
"layoutDurationMs": 12.62,
"taskDurationMs": 1642.0430000000001,
"heapDeltaBytes": 10102808,
"heapUsedBytes": 75099148,
"domNodes": -261,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 770.424,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 2939.9009999999635,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.808000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1899.3219999999997,
"heapDeltaBytes": 17574128,
"heapUsedBytes": 83770092,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 989.4880000000002,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3134.284999999977,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.698,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1906.389,
"heapDeltaBytes": 23705180,
"heapUsedBytes": 89879308,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 1014.3439999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2031.2129999999797,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.42,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.1949999999999,
"heapDeltaBytes": -4358008,
"heapUsedBytes": 83998808,
"domNodes": -252,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 34.264999999999986,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.3150000000396,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.1129999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 564.233,
"heapDeltaBytes": -4190232,
"heapUsedBytes": 84081500,
"domNodes": -250,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 36.355,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 574.4120000000521,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.014999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.5700000000001,
"heapDeltaBytes": 13502848,
"heapUsedBytes": 77229920,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 140.27200000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.477999999971,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.029000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.66,
"heapDeltaBytes": 13116456,
"heapUsedBytes": 76794156,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 143.328,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2020.6539999999222,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.731000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.085,
"heapDeltaBytes": -3990732,
"heapUsedBytes": 65795132,
"domNodes": -276,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.57,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2000.990999999999,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.943000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.6939999999999,
"heapDeltaBytes": 12650600,
"heapUsedBytes": 76190768,
"domNodes": -276,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.624000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1720.668000000046,
"styleRecalcs": 78,
"styleRecalcDurationMs": 25.586,
"layouts": 18,
"layoutDurationMs": 4.64,
"taskDurationMs": 757.874,
"heapDeltaBytes": 12949172,
"heapUsedBytes": 76431248,
"domNodes": -277,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 105.81800000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1717.7540000000135,
"styleRecalcs": 78,
"styleRecalcDurationMs": 26.595,
"layouts": 18,
"layoutDurationMs": 4.493,
"taskDurationMs": 769.006,
"heapDeltaBytes": 17101292,
"heapUsedBytes": 80712380,
"domNodes": -276,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 104.505,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.4950000000154,
"styleRecalcs": 17,
"styleRecalcDurationMs": 28.329,
"layouts": 5,
"layoutDurationMs": 13.157000000000002,
"taskDurationMs": 878.8119999999997,
"heapDeltaBytes": -6417052,
"heapUsedBytes": 83396120,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 31.115999999999996,
"eventListeners": 2383,
"totalBlockingTimeMs": 152,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8421.637000000032,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.636,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5708.287,
"heapDeltaBytes": -6454836,
"heapUsedBytes": 80430588,
"domNodes": -250,
"jsHeapTotalBytes": -532480,
"scriptDurationMs": 2756.767,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8391.835000000014,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.519999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5761.23,
"heapDeltaBytes": -20218584,
"heapUsedBytes": 66375048,
"domNodes": -221,
"jsHeapTotalBytes": 3174400,
"scriptDurationMs": 2824.927,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16904.99800000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16391.337,
"heapDeltaBytes": -35919588,
"heapUsedBytes": 180979496,
"domNodes": -8061,
"jsHeapTotalBytes": -11313152,
"scriptDurationMs": 280.14500000000004,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12713.608000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11995.562999999998,
"heapDeltaBytes": -15746752,
"heapUsedBytes": 194171676,
"domNodes": -8061,
"jsHeapTotalBytes": -5545984,
"scriptDurationMs": 229.593,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20353.648000000023,
"styleRecalcs": 155,
"styleRecalcDurationMs": 18.946999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20028.124,
"heapDeltaBytes": -37939536,
"heapUsedBytes": 180383076,
"domNodes": -8061,
"jsHeapTotalBytes": -17797120,
"scriptDurationMs": 895.1569999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 34,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20614.6379999999,
"styleRecalcs": 170,
"styleRecalcDurationMs": 20.151000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20311.878999999997,
"heapDeltaBytes": -47352376,
"heapUsedBytes": 191314960,
"domNodes": -8061,
"jsHeapTotalBytes": -16293888,
"scriptDurationMs": 951.148,
"eventListeners": -14928,
"totalBlockingTimeMs": 62,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6096.351000000027,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.10199999999998,
"layouts": 20,
"layoutDurationMs": 22.971999999999994,
"taskDurationMs": 5999.277,
"heapDeltaBytes": -43047076,
"heapUsedBytes": 193450932,
"domNodes": -8065,
"jsHeapTotalBytes": 11730944,
"scriptDurationMs": 107.268,
"eventListeners": -14928,
"totalBlockingTimeMs": 492,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4743.413999999916,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.769,
"layouts": 20,
"layoutDurationMs": 23.712999999999997,
"taskDurationMs": 4614.7660000000005,
"heapDeltaBytes": -52621348,
"heapUsedBytes": 178678028,
"domNodes": -8061,
"jsHeapTotalBytes": 21897216,
"scriptDurationMs": 93.65300000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 98,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8366.494999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8100.899000000002,
"heapDeltaBytes": -1879432,
"heapUsedBytes": 177592960,
"domNodes": 0,
"jsHeapTotalBytes": -13631488,
"scriptDurationMs": 122.78100000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8430.405000000064,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8210.771999999999,
"heapDeltaBytes": 3959080,
"heapUsedBytes": 180849572,
"domNodes": 0,
"jsHeapTotalBytes": -6291456,
"scriptDurationMs": 130.55099999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 112.4609999999393,
"styleRecalcs": 9,
"styleRecalcDurationMs": 19.272000000000006,
"layouts": 2,
"layoutDurationMs": 1.303,
"taskDurationMs": 89.87900000000002,
"heapDeltaBytes": 3132636,
"heapUsedBytes": 64936624,
"domNodes": 131,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.563,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 104.42399999988083,
"styleRecalcs": 8,
"styleRecalcDurationMs": 17.106,
"layouts": 2,
"layoutDurationMs": 1.2399999999999998,
"taskDurationMs": 80.35000000000001,
"heapDeltaBytes": 2962296,
"heapUsedBytes": 64690336,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.652000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18338 +/- ##
==========================================
+ Coverage 83.26% 84.27% +1.00%
==========================================
Files 2981 2280 -701
Lines 146563 129412 -17151
Branches 39739 34952 -4787
==========================================
- Hits 122038 109059 -12979
+ Misses 23242 20057 -3185
+ Partials 1283 296 -987
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Source-only review: no introduced defect found in this fixture correction. The real media-combo predicate rejects the published base fixture and accepts this head; 60 existing neighboring contract tests pass. Browser replay and the author's 16/17 result were not independently verified. The inherited type/has_errors assertion can still accept a widget-less placeholder after error-flag reconciliation, so this is not red/green replay acceptance or release qualification.
|
Thanks for the source-only review, @christian-byrne. The caveat matches what the PR body already discloses: Generated by Claude Code |
christian-byrne
left a comment
There was a problem hiding this comment.
Approved: the one-line fixture correction matches the production LoadImage schema, introduces no lint suppression, has no unresolved review threads, and substantive exact-head CI is green. Local verification was intentionally not rerun due the active host resource constraint; this approval relies on the completed remote checks and source review.
|
|
|
Backport disposition: no release-line patch applies.
Full context for agent readersThe genuine workflow at https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35822481520 attempted both |
<!-- ccr-slack-attribution -->
Requested by Christian Byrne · Slack thread
Summary
browser_tests/fixtures/data/agentReplayNodeDefs.ts'sLoadImagefixture def was missingimage_upload: trueon itsimagecombo input, soComfy.UploadImage's hook never wiredimageInputNameonto theuploadinput, which broke node materialization forLoadImagein the agent replay suite.Before / After
Before:
LoadImage'simagecombo lackedimage_upload: true.Comfy.UploadImage'sbeforeRegisterNodeDefhook looks for exactly that flag to find which combo input anuploadinput augments; without it, the hook never ran, so theupload: ['IMAGEUPLOAD', {}]input the fixture declares never gotimageInputNameadded.useImageUploadWidget's widget constructor requires that augmentation and throws without it,LiteGraph.createNodecatches the throw and returnsnull, and callers that materialize agent-driven nodes (agentNodeMaterializer.ts'sLiteGraph.createNode(...) ?? missingNode(state)) fall back to a bare, widget-less placeholder for the node instead of a realLoadImage.After: the
imagecombo declaresimage_upload: true, matching the real backend'sLoadImagenode def. The hook finds it, wiresimageInputNameontoupload, andLoadImagenodes materialize normally with their full widget set.Fix
Added
image_upload: truetoLoadImage'simagecombo options inbrowser_tests/fixtures/data/agentReplayNodeDefs.ts, matching the shapeisMediaUploadComboInput(packages/object-info-parser/src/schemas/nodeDefSchema.ts) andComfy.UploadImage(src/extensions/core/uploadImage.ts) expect.How
useImageUploadWidget's constructor throwsImage upload widget requires imageInputName augmentation, which propagates throughnew ComfyNode(...)andLiteGraph.createNode(confirmed via instrumented console output and a full stack trace throughagentNodeMaterializer.ts:materialize→LiteGraphGlobal.createNode→addInputWidget→widgetConstructor).image_upload: truepresent, the hook wiresimageInputNameand node construction no longer throws.agentConversationReplay.spec.tssuite (@cloudproject) with the fix applied: 16/17 pass; the one failure (wire evidence › paints the wire the second turn connects @screenshot) is a pre-existing ~0.01% pixel screenshot diff that reproduces identically with the fix reverted, so it is unrelated to this change.pnpm typecheck,eslint,oxlint, andoxfmt --checkall pass on the touched file.Note on the red/green proof: while the underlying construction failure is real and directly confirmed via instrumented tracing (
LiteGraph.createNodereturnsnullandagentNodeMaterializer.tsfalls back tomissingNode(state)withhas_errors: true), the specificagent-workflow-editing-05case inagentConversationReplay.spec.tsdoes not itself go red on unmodifiedmainin this environment: a separate reactive reconciler (useNodeErrorFlagSync.ts'sreconcileNodeErrorFlags) resetshas_errorsback tofalseshortly afterward for any node whose type is registered (as opposed to genuinely missing from the catalog), and the test'sassertAgentReplayNodeContracthelper only checkstypeandhas_errors, not that the node actually carriesLoadImage's widgets/sockets. So the placeholder node passes the test's assertions even though it is a broken, widget-less object. The fix is still correct and necessary — it makes the fixture match the real productionLoadImagenode def and prevents the broken placeholder from being created in the first place — but this PR does not include a CI screenshot of a red run onmainfor this exact test case, since it is not currently red.🤖 Generated with Claude Code
https://claude.ai/code/session_019MkQxYEX6qo37qThfMVfQa
Generated by Claude Code