Repository navigation
[backport cloud/1.54] test(agent): pin the turn a transient socket reconnect abandons (PM-1199) (#18113) - #18532
claude[bot] wants to merge 1 commit into
Conversation
…199) (#18113) *PR Created by the Glary-Bot Agent* --- Failing regression coverage for PM-1199 / PM-1200. Test-only — no product code is touched, and the fix is deliberately out of scope. A user ran the agent in auto mode for a long stretch. The action stream stopped updating, the busy indicator was replaced by a "worked for 3m" summary as if the turn had finished, and the next message came back `Message failed to send: a turn is already in progress for this thread`. **No refresh and no tab close anywhere in the journey** — that is what makes this distinct from PM-1154 and PM-1043. The agent chat stream rides the shared ComfyUI websocket, so any transient close dispatches `reconnecting`. `useAgentSession.onStatus(false)` answers it with `abortActiveTurn()`, which settles the assistant message locally; `onStatus(true)` only sets a flag. Nothing re-attaches, and `agentConversationStore.ingest` then discards every later frame for that turn — `transport` is null and `dropBackgroundTurns()` emptied the map it would otherwise fall back to. The server never saw the socket go away, so its assistant row is still `streaming` and it keeps answering posts with 409 `TURN_IN_PROGRESS`. The user's own CRDT debug attachment carries a single `reconnected` event at 11:15:37 UTC with no reload, `Active agent request/turn id: none`, and a most-recent turn id of `local-error-…`. Full RCA on [PM-1199](https://linear.app/comfyorg/issue/PM-1199/fix-agent-stream-drops-mid-turn-with-no-refresh-leaving-no-working#comment-5804f260). Both frames come from the new fixture driving a real socket close — the second reproduces the reported strings verbatim. `browser_tests/tests/agent/agentTurnSurvivesSocketDrop.spec.ts` — five cases, three `test.fail()`: | Case | Pins | Today | |---|---|---| | keeps rendering the turn after the socket reconnects | post-reconnect deltas are dropped | `test.fail()` | | keeps the turn marked as running | `streaming` flips false, so ActivityTrace becomes the "Worked for …" summary and Stop reverts to Send | `test.fail()` | | does not reject the next message | the nudge comes back 409 `TURN_IN_PROGRESS` | `test.fail()` | | summarises a turn that ends normally | keeps the `workSummary` locator honest so the negatives above cannot pass vacuously | green | | keeps the turn running while audio decoding runs alongside it | Web Audio beside a live turn is harmless | green | `useAgentSession.test.ts` `(g3)`/`(g4)` — the same defect at the lowest level that proves it, as `it.fails`. Their double answers `getMessages` with a `streaming` transcript carrying the full reply, so a repair that re-hydrates on reconnect satisfies them just as well as one that re-attaches the local transport, and both wait 2s so a debounced recovery still trips them. Note `(g)` directly above them asserts today's behaviour as correct, with the comment *"Reconnection recovery is the CRDT follower's job now."* That is the decision that caused this: recovery was delegated for the **document** — `useAgentCrdtFollower` does resubscribe on `reconnected`, and the user's log shows it recovering in 458ms — and nobody was left owning the **conversation**. Whoever fixes this will need to invert `(g)`. - Browser spec: **5 passed** (3 expected-fail), 10 consecutive clean runs. - Unit: **74 passed / 2 expected fail**. - With the markers stripped, each case fails on its documented assertion — `POST_RECONNECT_TEXT` not visible / `Stop` not found / the 409 alert resolving to 1 / `'partial'` vs `'partial and the rest'`. - `vue-tsc` (both tsconfigs), `oxfmt`, `oxlint --type-aware`, `eslint`, `knip` clean. - Shared-fixture regression: `agentInlinePrompt` and `agentInlineReferences` still pass. `agentChatRefreshPersistence` fails identically on a pristine `main` in this sandbox — pre-existing, not from this branch. - **The suites are green by design and go non-zero the moment the product is fixed**, via the repo's existing mechanism (`groupNode.spec.ts`, `VirtualGrid.test.ts`). Playwright raises `Expected to fail, but passed.` and Vitest `Expect test to fail`. - `ws.ts` gains `nextWebSocket()` so a test can await the socket opened *after* a reconnect. `getWebSocket()` is unchanged for its ~25 existing consumers; replacing the single `resolve` slot with a `Set` also fixes a latent bug where a second concurrent waiter was stranded. - In the 409 case the nudge is driven **above** `test.fail()` on purpose: body-level `test.fail()` only sets the expected status when it executes, so once the client re-attaches and Send disappears, that click reports red by name rather than being absorbed. - `startTurn()` gates on the user bubble, not the Stop button. Stop renders from `isSending` before the POST leaves, and frames pushed in that window are dropped with no retry — that race made an earlier revision of this suite fail ~half the time. - The audio control does not call `useWaveAudioPlayer`, so it does not clear the whole audio path. What shows the playback was incidental is that the three socket specs reproduce every symptom with no audio at all. - `transcript()` and the cancel route in the fixture are deliberately unexercised; they keep the fake a faithful server so a re-hydrate repair does not look broken. Re-hydrate on `reconnected` instead of staying inert, **and** treat any `status === 'streaming'` assistant row as pending in `normalizeAgentTranscript` — today only a row carrying a `run_approval` ask re-attaches, which is why a refresh does not recover either. That pair also closes PM-1043 and PM-1154. The backend gap is separate: agent events have no `Last-Event-ID`/replay, so frames sent during the reconnect window are lost outright. Tracked in Linear as PM-1199 (parent) and PM-1200.   --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed the exact backport head b445573b4014671c6d583869bd4ce7aec6e3fd5d against merged source #18113. The cloud/1.54 carrier is conflict-free, changes only agentTurnLockFixture.ts and agentTurnSurvivesSocketDrop.spec.ts, and preserves the source regression intent without product-code drift. No unresolved review threads are present. Required target checks and black-box acceptance remain pending and still gate merge.
🎭 Playwright: ✅ 1937 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-23T04:35:00.915Z",
"gitSha": "e45f7e2a64722a45d765a06ef1bcf63e7541618d",
"branch": "backport-18113-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2081.83200000002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.298000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.421,
"heapDeltaBytes": -12433624,
"heapUsedBytes": 57596056,
"domNodes": -279,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 6.862,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2037.1220000000108,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.374000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.782,
"heapDeltaBytes": -12234280,
"heapUsedBytes": 57038636,
"domNodes": -278,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.308000000000002,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1743.7029999999822,
"styleRecalcs": 74,
"styleRecalcDurationMs": 16.328,
"layouts": 14,
"layoutDurationMs": 2.3,
"taskDurationMs": 620.342,
"heapDeltaBytes": -4312724,
"heapUsedBytes": 66735708,
"domNodes": -277,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 94.14299999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1693.7560000000076,
"styleRecalcs": 73,
"styleRecalcDurationMs": 16.232999999999997,
"layouts": 14,
"layoutDurationMs": 2.372,
"taskDurationMs": 607.249,
"heapDeltaBytes": 6789460,
"heapUsedBytes": 77937444,
"domNodes": -282,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 93.704,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1684.851999999978,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.642000000000001,
"layouts": 6,
"layoutDurationMs": 0.795,
"taskDurationMs": 277.89000000000004,
"heapDeltaBytes": 4651488,
"heapUsedBytes": 75184440,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8.335,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1658.5639999999557,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.841999999999999,
"layouts": 6,
"layoutDurationMs": 0.7170000000000001,
"taskDurationMs": 278.14,
"heapDeltaBytes": 4451544,
"heapUsedBytes": 75144472,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 7.873000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 519.6020000000203,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.395,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 326.165,
"heapDeltaBytes": 18093056,
"heapUsedBytes": 88295112,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 111.675,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 517.4509999999941,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.953,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 316.35400000000004,
"heapDeltaBytes": 18506364,
"heapUsedBytes": 88407912,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 105.196,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2071.9799999999964,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.426,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.7189999999999,
"heapDeltaBytes": 8348020,
"heapUsedBytes": 84582036,
"domNodes": -279,
"jsHeapTotalBytes": -368640,
"scriptDurationMs": 21.320999999999998,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2028.0779999999936,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.786999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.5679999999999,
"heapDeltaBytes": 8951640,
"heapUsedBytes": 85361016,
"domNodes": -269,
"jsHeapTotalBytes": -630784,
"scriptDurationMs": 26.500000000000004,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2168.76000000002,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.298,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1220.315,
"heapDeltaBytes": 1205044,
"heapUsedBytes": 77817572,
"domNodes": -239,
"jsHeapTotalBytes": 380928,
"scriptDurationMs": 576.1279999999999,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2102.5790000000484,
"styleRecalcs": 68,
"styleRecalcDurationMs": 7.624999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1155.6060000000002,
"heapDeltaBytes": 8892480,
"heapUsedBytes": 85029340,
"domNodes": -269,
"jsHeapTotalBytes": -405504,
"scriptDurationMs": 533.814,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3088.9470000000188,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.34,
"layouts": 60,
"layoutDurationMs": 7.561,
"taskDurationMs": 1188.2229999999997,
"heapDeltaBytes": 8280144,
"heapUsedBytes": 76074984,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 512.6659999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3018.389999999954,
"styleRecalcs": 60,
"styleRecalcDurationMs": 6.052999999999999,
"layouts": 60,
"layoutDurationMs": 7.656,
"taskDurationMs": 1162.927,
"heapDeltaBytes": 11477724,
"heapUsedBytes": 79817860,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 493.21799999999996,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2253.252000000032,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.051000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1354.743,
"heapDeltaBytes": -11341500,
"heapUsedBytes": 68702496,
"domNodes": -247,
"jsHeapTotalBytes": 155648,
"scriptDurationMs": 628.114,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2252.124999999978,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.076000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1314.0649999999998,
"heapDeltaBytes": 17965748,
"heapUsedBytes": 85538972,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 613.897,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2011.9439999999713,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.106000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.9580000000001,
"heapDeltaBytes": 21803868,
"heapUsedBytes": 88142224,
"domNodes": -271,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 19.104999999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2019.217000000026,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.791000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.5,
"heapDeltaBytes": 21865492,
"heapUsedBytes": 88125212,
"domNodes": -266,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 22.909,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 481.5969999999652,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.768,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 298.591,
"heapDeltaBytes": 13584304,
"heapUsedBytes": 79375724,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 97.433,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 491.9879999999921,
"styleRecalcs": 49,
"styleRecalcDurationMs": 7.956000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 290.59399999999994,
"heapDeltaBytes": 14576652,
"heapUsedBytes": 86339948,
"domNodes": 24,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 91.193,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1997.9129999999827,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.0619999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.626,
"heapDeltaBytes": 1118028,
"heapUsedBytes": 66927224,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 5.949000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1991.7069999999626,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.608999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.63000000000005,
"heapDeltaBytes": -4397312,
"heapUsedBytes": 68752384,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 5.807000000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.5179999999832,
"styleRecalcs": 77,
"styleRecalcDurationMs": 16.757,
"layouts": 18,
"layoutDurationMs": 2.698,
"taskDurationMs": 587.154,
"heapDeltaBytes": -6734248,
"heapUsedBytes": 66388000,
"domNodes": -295,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 66.262,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.298000000008,
"styleRecalcs": 78,
"styleRecalcDurationMs": 17.387,
"layouts": 18,
"layoutDurationMs": 2.6879999999999997,
"taskDurationMs": 588.912,
"heapDeltaBytes": -7698708,
"heapUsedBytes": 65553096,
"domNodes": -295,
"jsHeapTotalBytes": 7331840,
"scriptDurationMs": 67.45000000000002,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 899.2600000000266,
"styleRecalcs": 21,
"styleRecalcDurationMs": 22.977999999999998,
"layouts": 17,
"layoutDurationMs": 10.383000000000001,
"taskDurationMs": 693.813,
"heapDeltaBytes": 21919924,
"heapUsedBytes": 105910540,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 18.609,
"eventListeners": 2385,
"totalBlockingTimeMs": 115,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8168.432999999994,
"styleRecalcs": 248,
"styleRecalcDurationMs": 25.677,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4055.65,
"heapDeltaBytes": 998928,
"heapUsedBytes": 77464004,
"domNodes": -277,
"jsHeapTotalBytes": 643072,
"scriptDurationMs": 1784.0819999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8205.712999999945,
"styleRecalcs": 250,
"styleRecalcDurationMs": 21.114999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4045.4970000000003,
"heapDeltaBytes": -12234156,
"heapUsedBytes": 89887484,
"domNodes": -263,
"jsHeapTotalBytes": -892928,
"scriptDurationMs": 1763.245,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10674.502000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10078.713,
"heapDeltaBytes": -38220480,
"heapUsedBytes": 178509124,
"domNodes": -8068,
"jsHeapTotalBytes": -11530240,
"scriptDurationMs": 116.53,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 10592.039,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10025.411000000002,
"heapDeltaBytes": -37812360,
"heapUsedBytes": 179891396,
"domNodes": -8068,
"jsHeapTotalBytes": -12324864,
"scriptDurationMs": 112.241,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13125.016000000016,
"styleRecalcs": 65,
"styleRecalcDurationMs": 8.134000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12594.903,
"heapDeltaBytes": -34908736,
"heapUsedBytes": 184903056,
"domNodes": -8076,
"jsHeapTotalBytes": -14872576,
"scriptDurationMs": 578.6940000000001,
"eventListeners": -14933,
"totalBlockingTimeMs": 1,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 12971.17700000001,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.492,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12470.738000000001,
"heapDeltaBytes": -31742556,
"heapUsedBytes": 191988540,
"domNodes": -8068,
"jsHeapTotalBytes": -20480000,
"scriptDurationMs": 568.4970000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 3851.485000000025,
"styleRecalcs": 20,
"styleRecalcDurationMs": 54.408000000000015,
"layouts": 20,
"layoutDurationMs": 15.375,
"taskDurationMs": 3697.582000000001,
"heapDeltaBytes": -33371356,
"heapUsedBytes": 183611484,
"domNodes": -8068,
"jsHeapTotalBytes": 18857984,
"scriptDurationMs": 51.80500000000001,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 3839.666999999963,
"styleRecalcs": 20,
"styleRecalcDurationMs": 54.97299999999999,
"layouts": 20,
"layoutDurationMs": 15.119999999999994,
"taskDurationMs": 3698.3269999999993,
"heapDeltaBytes": -20376848,
"heapUsedBytes": 179438988,
"domNodes": -8072,
"jsHeapTotalBytes": 14716928,
"scriptDurationMs": 48.387,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5346.468000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5208.2300000000005,
"heapDeltaBytes": 11933340,
"heapUsedBytes": 184381788,
"domNodes": 0,
"jsHeapTotalBytes": -6291456,
"scriptDurationMs": 58.65799999999999,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5325.4779999999755,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5156.738,
"heapDeltaBytes": -17954724,
"heapUsedBytes": 178632316,
"domNodes": 0,
"jsHeapTotalBytes": -23855104,
"scriptDurationMs": 53.12800000000001,
"eventListeners": -6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 440.79700000003186,
"styleRecalcs": 20,
"styleRecalcDurationMs": 15.719000000000001,
"layouts": 4,
"layoutDurationMs": 1.214,
"taskDurationMs": 87.47500000000001,
"heapDeltaBytes": 5064408,
"heapUsedBytes": 74225228,
"domNodes": 151,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.186,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 78.07600000001003,
"styleRecalcs": 6,
"styleRecalcDurationMs": 10.113999999999997,
"layouts": 2,
"layoutDurationMs": 1.151,
"taskDurationMs": 53.82999999999999,
"heapDeltaBytes": 2998932,
"heapUsedBytes": 72123320,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 3.6560000000000015,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #18532 +/- ##
=============================================
Coverage ? 78.61%
=============================================
Files ? 2009
Lines ? 111110
Branches ? 31421
=============================================
Hits ? 87345
Misses ? 23586
Partials ? 179
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Closing: the compatible release-line reproduction is already present; this follow-up is harmful.
Full context for agent readersExact head: The original backport conflict was content overlap, not missing coverage. This PR replaces that compatible fixture with the final-main Hosted evidence: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35817673796/job/107045153860 No manual replacement backport is needed unless a product fix, rather than this test-only source PR, is later selected for the release. |
Manual backport of #18113 to
cloud/1.54. The automated backport failed with conflicts in:browser_tests/fixtures/agentTurnLockFixture.tsbrowser_tests/tests/agent/agentTurnSurvivesSocketDrop.spec.tssrc/workbench/extensions/agent/composables/agent/useAgentSession.test.tsSame conflict shape and resolution as the
core/1.54counterpart, #18531 — see that PR for the full writeup. Summary:Why this conflicted (not a stacking conflict)
Checked the PRs the bot flagged as possible stackers (#18479, #18478, #18473, #18418, #18411, #18370, #18367, #18351) — none touch any of the three conflicting files.
The actual cause: #18113 was already carried onto
cloud/1.54once, as one of seventeen sources bundled into #18185 ("Agent catalogue sweep 2"), merged 2026-09-20. That sweep grabbed an intermediate/pre-final revision of #18113's branch, socloud/1.54already had a draft version of the test suite (activityRowlocator) that predates the PR's final polish (workSummary/workingRow, stronger assertions).Conflict resolution
browser_tests/fixtures/agentTurnLockFixture.tsandbrowser_tests/tests/agent/agentTurnSurvivesSocketDrop.spec.ts: took the incoming (final test(agent): pin the turn a transient socket reconnect abandons (PM-1199) #18113 / currentmain) version wholesale. Confirmed theagent.worked/agent.workingi18n keys it relies on already exist oncloud/1.54, and nothing else references the oldactivityRowsymbol.src/workbench/extensions/agent/composables/agent/useAgentSession.test.ts: kept the branch's existing content. The PM-1199-specific(g3)/(g4)tests are byte-identical between both sides already; the rest of the diff was unrelated main-only style drift (setActivePiniapattern,vi.mock(import(...))) plus the PM-1429/PM-1430 tests only present oncloud/1.54(via [backport cloud/1.54] fix: flag a freshly created, unsaved tab as unbound for the agent (PM-1430) #18385) that aren't part of test(agent): pin the turn a transient socket reconnect abandons (PM-1199) #18113's diff.Verification
pnpm exec vitest run src/workbench/extensions/agent/composables/agent/useAgentSession.test.ts— 76 passed, 2 expected fail ((g3)/(g4)it.failspins).pnpm exec oxfmt --checkandpnpm exec oxlinton the three touched files — clean.pnpm run typecheck(vue-tsc) — clean.Requested by Christian Byrne in Slack
🤖 Generated with Claude Code
https://claude.ai/code/session_01WgCgZKjk1bLPcyYppEr9DZ
Generated by Claude Code