Skip to content

[backport cloud/1.54] test(agent): pin the turn a transient socket reconnect abandons (PM-1199) (#18113) - #18532

Closed
claude[bot] wants to merge 1 commit into
cloud/1.54from
backport-18113-to-cloud-1.54
Closed

claude[bot] wants to merge 1 commit into
cloud/1.54from
backport-18113-to-cloud-1.54

Conversation

@claude

@claude claude Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Manual backport of #18113 to cloud/1.54. The automated backport failed with conflicts in:

  • browser_tests/fixtures/agentTurnLockFixture.ts
  • browser_tests/tests/agent/agentTurnSurvivesSocketDrop.spec.ts
  • src/workbench/extensions/agent/composables/agent/useAgentSession.test.ts

Same conflict shape and resolution as the core/1.54 counterpart, #18531 — see that PR for the full writeup. Summary:

Why this conflicted (not a stacking conflict)

Checked the PRs the bot flagged as possible stackers (#18479, #18478, #18473, #18418, #18411, #18370, #18367, #18351) — none touch any of the three conflicting files.

The actual cause: #18113 was already carried onto cloud/1.54 once, as one of seventeen sources bundled into #18185 ("Agent catalogue sweep 2"), merged 2026-09-20. That sweep grabbed an intermediate/pre-final revision of #18113's branch, so cloud/1.54 already had a draft version of the test suite (activityRow locator) that predates the PR's final polish (workSummary/workingRow, stronger assertions).

Conflict resolution

Verification

  • pnpm exec vitest run src/workbench/extensions/agent/composables/agent/useAgentSession.test.ts — 76 passed, 2 expected fail ((g3)/(g4) it.fails pins).
  • pnpm exec oxfmt --check and pnpm exec oxlint on the three touched files — clean.
  • pnpm run typecheck (vue-tsc) — clean.
  • The Playwright spec needs the full e2e harness/dev server, unavailable in this sandbox; verified by inspection and lint/format only.

Requested by Christian Byrne in Slack

🤖 Generated with Claude Code

https://claude.ai/code/session_01WgCgZKjk1bLPcyYppEr9DZ


Generated by Claude Code

…199) (#18113)

*PR Created by the Glary-Bot Agent*

---

Failing regression coverage for PM-1199 / PM-1200. Test-only — no
product code is touched, and the fix is deliberately out of scope.

A user ran the agent in auto mode for a long stretch. The action stream
stopped updating, the busy indicator was replaced by a "worked for 3m"
summary as if the turn had finished, and the next message came back
`Message failed to send: a turn is already in progress for this thread`.
**No refresh and no tab close anywhere in the journey** — that is what
makes this distinct from PM-1154 and PM-1043.

The agent chat stream rides the shared ComfyUI websocket, so any
transient close dispatches `reconnecting`.
`useAgentSession.onStatus(false)` answers it with `abortActiveTurn()`,
which settles the assistant message locally; `onStatus(true)` only sets
a flag. Nothing re-attaches, and `agentConversationStore.ingest` then
discards every later frame for that turn — `transport` is null and
`dropBackgroundTurns()` emptied the map it would otherwise fall back to.
The server never saw the socket go away, so its assistant row is still
`streaming` and it keeps answering posts with 409 `TURN_IN_PROGRESS`.

The user's own CRDT debug attachment carries a single `reconnected`
event at 11:15:37 UTC with no reload, `Active agent request/turn id:
none`, and a most-recent turn id of `local-error-…`. Full RCA on
[PM-1199](https://linear.app/comfyorg/issue/PM-1199/fix-agent-stream-drops-mid-turn-with-no-refresh-leaving-no-working#comment-5804f260).

Both frames come from the new fixture driving a real socket close — the
second reproduces the reported strings verbatim.

`browser_tests/tests/agent/agentTurnSurvivesSocketDrop.spec.ts` — five
cases, three `test.fail()`:

| Case | Pins | Today |
|---|---|---|
| keeps rendering the turn after the socket reconnects | post-reconnect
deltas are dropped | `test.fail()` |
| keeps the turn marked as running | `streaming` flips false, so
ActivityTrace becomes the "Worked for …" summary and Stop reverts to
Send | `test.fail()` |
| does not reject the next message | the nudge comes back 409
`TURN_IN_PROGRESS` | `test.fail()` |
| summarises a turn that ends normally | keeps the `workSummary` locator
honest so the negatives above cannot pass vacuously | green |
| keeps the turn running while audio decoding runs alongside it | Web
Audio beside a live turn is harmless | green |

`useAgentSession.test.ts` `(g3)`/`(g4)` — the same defect at the lowest
level that proves it, as `it.fails`. Their double answers `getMessages`
with a `streaming` transcript carrying the full reply, so a repair that
re-hydrates on reconnect satisfies them just as well as one that
re-attaches the local transport, and both wait 2s so a debounced
recovery still trips them.

Note `(g)` directly above them asserts today's behaviour as correct,
with the comment *"Reconnection recovery is the CRDT follower's job
now."* That is the decision that caused this: recovery was delegated for
the **document** — `useAgentCrdtFollower` does resubscribe on
`reconnected`, and the user's log shows it recovering in 458ms — and
nobody was left owning the **conversation**. Whoever fixes this will
need to invert `(g)`.

- Browser spec: **5 passed** (3 expected-fail), 10 consecutive clean
runs.
- Unit: **74 passed / 2 expected fail**.
- With the markers stripped, each case fails on its documented assertion
— `POST_RECONNECT_TEXT` not visible / `Stop` not found / the 409 alert
resolving to 1 / `'partial'` vs `'partial and the rest'`.
- `vue-tsc` (both tsconfigs), `oxfmt`, `oxlint --type-aware`, `eslint`,
`knip` clean.
- Shared-fixture regression: `agentInlinePrompt` and
`agentInlineReferences` still pass. `agentChatRefreshPersistence` fails
identically on a pristine `main` in this sandbox — pre-existing, not
from this branch.

- **The suites are green by design and go non-zero the moment the
product is fixed**, via the repo's existing mechanism
(`groupNode.spec.ts`, `VirtualGrid.test.ts`). Playwright raises
`Expected to fail, but passed.` and Vitest `Expect test to fail`.
- `ws.ts` gains `nextWebSocket()` so a test can await the socket opened
*after* a reconnect. `getWebSocket()` is unchanged for its ~25 existing
consumers; replacing the single `resolve` slot with a `Set` also fixes a
latent bug where a second concurrent waiter was stranded.
- In the 409 case the nudge is driven **above** `test.fail()` on
purpose: body-level `test.fail()` only sets the expected status when it
executes, so once the client re-attaches and Send disappears, that click
reports red by name rather than being absorbed.
- `startTurn()` gates on the user bubble, not the Stop button. Stop
renders from `isSending` before the POST leaves, and frames pushed in
that window are dropped with no retry — that race made an earlier
revision of this suite fail ~half the time.
- The audio control does not call `useWaveAudioPlayer`, so it does not
clear the whole audio path. What shows the playback was incidental is
that the three socket specs reproduce every symptom with no audio at
all.
- `transcript()` and the cancel route in the fixture are deliberately
unexercised; they keep the fake a faithful server so a re-hydrate repair
does not look broken.

Re-hydrate on `reconnected` instead of staying inert, **and** treat any
`status === 'streaming'` assistant row as pending in
`normalizeAgentTranscript` — today only a row carrying a `run_approval`
ask re-attaches, which is why a refresh does not recover either. That
pair also closes PM-1043 and PM-1154. The backend gap is separate: agent
events have no `Last-Event-ID`/replay, so frames sent during the
reconnect window are lost outright.

Tracked in Linear as PM-1199 (parent) and PM-1200.

![Agent panel during a live turn: activity rows and a 'Working...'
indicator, composer showing
Stop](https://pub-1fd11710d4c8405b948c9edc4287a3f2.r2.dev/sessions/cca7a064c5ab1fccbfc3c8367ebd8086bf3cbff1df24560a205f802d91b7f1c9/pr-images/1789795900162-24da44b0-13b5-4937-9d3d-01b867432526.png)

![After a transient socket reconnect: the turn has collapsed into a
'Worked for 1.3 seconds' summary and the nudge is rejected with 'Message
failed to send: a turn is already in progress for this
thread'](https://pub-1fd11710d4c8405b948c9edc4287a3f2.r2.dev/sessions/cca7a064c5ab1fccbfc3c8367ebd8086bf3cbff1df24560a205f802d91b7f1c9/pr-images/1789795900710-0b800aed-8b7a-4c26-b021-dad37137ad95.png)

---------

Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
@claude claude Bot added the backport Backporting a PR onto a release candidate label Sep 23, 2026
@coderabbitai

coderabbitai Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 251e0784-7ca0-4231-993a-7f8c66c9839b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Sep 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 23, 2026 4:16am UTC

Request Review

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the exact backport head b445573b4014671c6d583869bd4ce7aec6e3fd5d against merged source #18113. The cloud/1.54 carrier is conflict-free, changes only agentTurnLockFixture.ts and agentTurnSurvivesSocketDrop.spec.ts, and preserves the source regression intent without product-code drift. No unresolved review threads are present. Required target checks and black-box acceptance remain pending and still gate merge.

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1937 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1916 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.7 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.7 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.3 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.5 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.1 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.0 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 115ms TBT · 101.0 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.8 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.9 MB heap
vue-large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 1ms TBT · 179.7 MB heap
vue-node-resize-workload: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 173.1 MB heap
vue-zoom-out-idle: · 59.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 173.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.8 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 6ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 456ms
canvas-idle: script duration 7ms
canvas-idle: TBT 0ms
canvas-idle: heap used 54.7 MB
canvas-idle: DOM nodes -279
canvas-idle: event listeners -196
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 2ms
canvas-mouse-sweep: style recalc duration 16ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 614ms
canvas-mouse-sweep: script duration 94ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 69.0 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -178
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 12ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 278ms
canvas-zoom-sweep: script duration 8ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.7 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 5ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 321ms
dom-widget-clipping: script duration 108ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 84.3 MB
dom-widget-clipping: DOM nodes 20
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 8
large-graph-idle: task duration 509ms
large-graph-idle: script duration 24ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 81.0 MB
large-graph-idle: DOM nodes -274
large-graph-idle: event listeners -175
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 8ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1188ms
large-graph-pan: script duration 555ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 77.7 MB
large-graph-pan: DOM nodes -254
large-graph-pan: event listeners -175
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 8ms
large-graph-zoom: style recalc duration 7ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1176ms
large-graph-zoom: script duration 503ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.3 MB
large-graph-zoom: DOM nodes 4
large-graph-zoom: event listeners 8
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 45
legacy-node-drag: task duration 1334ms
legacy-node-drag: script duration 621ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 73.5 MB
legacy-node-drag: DOM nodes -121
legacy-node-drag: event listeners 87
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 437ms
minimap-idle: script duration 21ms
minimap-idle: TBT 0ms
minimap-idle: heap used 84.1 MB
minimap-idle: DOM nodes -269
minimap-idle: event listeners -77
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 7ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 295ms
subgraph-dom-widget-clipping: script duration 94ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 79.0 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 5ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 382ms
subgraph-idle: script duration 6ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 64.7 MB
subgraph-idle: DOM nodes -139
subgraph-idle: event listeners -119
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 3ms
subgraph-mouse-sweep: style recalc duration 17ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 588ms
subgraph-mouse-sweep: script duration 67ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 62.9 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -240
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 10ms
subgraph-transition-enter: style recalc duration 23ms
subgraph-transition-enter: layout count 17
subgraph-transition-enter: style recalc count 21
subgraph-transition-enter: task duration 694ms
subgraph-transition-enter: script duration 19ms
subgraph-transition-enter: TBT 115ms
subgraph-transition-enter: heap used 101.0 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 23ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 4051ms
viewport-pan-sweep: script duration 1774ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 79.8 MB
viewport-pan-sweep: DOM nodes -270
viewport-pan-sweep: event listeners -161
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 10052ms
vue-large-graph-idle: script duration 114ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 170.9 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14935
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 9ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 66
vue-large-graph-pan: task duration 12533ms
vue-large-graph-pan: script duration 574ms
vue-large-graph-pan: TBT 1ms
vue-large-graph-pan: heap used 179.7 MB
vue-large-graph-pan: DOM nodes -8072
vue-large-graph-pan: event listeners -14931
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 15ms
vue-node-resize-workload: style recalc duration 55ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 3698ms
vue-node-resize-workload: script duration 50ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 173.1 MB
vue-node-resize-workload: DOM nodes -8070
vue-node-resize-workload: event listeners -14932
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 5182ms
vue-zoom-out-idle: script duration 56ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 173.1 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -7
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 13ms
workflow-execution: layout count 3
workflow-execution: style recalc count 13
workflow-execution: task duration 71ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.8 MB
workflow-execution: DOM nodes 138
workflow-execution: event listeners 41
Raw data
{
  "timestamp": "2026-09-23T04:35:00.915Z",
  "gitSha": "e45f7e2a64722a45d765a06ef1bcf63e7541618d",
  "branch": "backport-18113-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2081.83200000002,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.298000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 496.421,
      "heapDeltaBytes": -12433624,
      "heapUsedBytes": 57596056,
      "domNodes": -279,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 6.862,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2037.1220000000108,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 6.374000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 415.782,
      "heapDeltaBytes": -12234280,
      "heapUsedBytes": 57038636,
      "domNodes": -278,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 7.308000000000002,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1743.7029999999822,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 16.328,
      "layouts": 14,
      "layoutDurationMs": 2.3,
      "taskDurationMs": 620.342,
      "heapDeltaBytes": -4312724,
      "heapUsedBytes": 66735708,
      "domNodes": -277,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 94.14299999999999,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1693.7560000000076,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 16.232999999999997,
      "layouts": 14,
      "layoutDurationMs": 2.372,
      "taskDurationMs": 607.249,
      "heapDeltaBytes": 6789460,
      "heapUsedBytes": 77937444,
      "domNodes": -282,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 93.704,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1684.851999999978,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 13.642000000000001,
      "layouts": 6,
      "layoutDurationMs": 0.795,
      "taskDurationMs": 277.89000000000004,
      "heapDeltaBytes": 4651488,
      "heapUsedBytes": 75184440,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 8.335,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1658.5639999999557,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 10.841999999999999,
      "layouts": 6,
      "layoutDurationMs": 0.7170000000000001,
      "taskDurationMs": 278.14,
      "heapDeltaBytes": 4451544,
      "heapUsedBytes": 75144472,
      "domNodes": 77,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 7.873000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 519.6020000000203,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 5.395,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 326.165,
      "heapDeltaBytes": 18093056,
      "heapUsedBytes": 88295112,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 111.675,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 517.4509999999941,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 4.953,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 316.35400000000004,
      "heapDeltaBytes": 18506364,
      "heapUsedBytes": 88407912,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 105.196,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2071.9799999999964,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 5.426,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 516.7189999999999,
      "heapDeltaBytes": 8348020,
      "heapUsedBytes": 84582036,
      "domNodes": -279,
      "jsHeapTotalBytes": -368640,
      "scriptDurationMs": 21.320999999999998,
      "eventListeners": -160,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2028.0779999999936,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.786999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 500.5679999999999,
      "heapDeltaBytes": 8951640,
      "heapUsedBytes": 85361016,
      "domNodes": -269,
      "jsHeapTotalBytes": -630784,
      "scriptDurationMs": 26.500000000000004,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2168.76000000002,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 8.298,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1220.315,
      "heapDeltaBytes": 1205044,
      "heapUsedBytes": 77817572,
      "domNodes": -239,
      "jsHeapTotalBytes": 380928,
      "scriptDurationMs": 576.1279999999999,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2102.5790000000484,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 7.624999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1155.6060000000002,
      "heapDeltaBytes": 8892480,
      "heapUsedBytes": 85029340,
      "domNodes": -269,
      "jsHeapTotalBytes": -405504,
      "scriptDurationMs": 533.814,
      "eventListeners": -160,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3088.9470000000188,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 8.34,
      "layouts": 60,
      "layoutDurationMs": 7.561,
      "taskDurationMs": 1188.2229999999997,
      "heapDeltaBytes": 8280144,
      "heapUsedBytes": 76074984,
      "domNodes": 8,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 512.6659999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3018.389999999954,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 6.052999999999999,
      "layouts": 60,
      "layoutDurationMs": 7.656,
      "taskDurationMs": 1162.927,
      "heapDeltaBytes": 11477724,
      "heapUsedBytes": 79817860,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 493.21799999999996,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2253.252000000032,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 6.051000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1354.743,
      "heapDeltaBytes": -11341500,
      "heapUsedBytes": 68702496,
      "domNodes": -247,
      "jsHeapTotalBytes": 155648,
      "scriptDurationMs": 628.114,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2252.124999999978,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 4.076000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1314.0649999999998,
      "heapDeltaBytes": 17965748,
      "heapUsedBytes": 85538972,
      "domNodes": 6,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 613.897,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2011.9439999999713,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 2.106000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 425.9580000000001,
      "heapDeltaBytes": 21803868,
      "heapUsedBytes": 88142224,
      "domNodes": -271,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 19.104999999999997,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2019.217000000026,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 3.791000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 448.5,
      "heapDeltaBytes": 21865492,
      "heapUsedBytes": 88125212,
      "domNodes": -266,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 22.909,
      "eventListeners": -160,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 481.5969999999652,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 6.768,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 298.591,
      "heapDeltaBytes": 13584304,
      "heapUsedBytes": 79375724,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 97.433,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 491.9879999999921,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 7.956000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 290.59399999999994,
      "heapDeltaBytes": 14576652,
      "heapUsedBytes": 86339948,
      "domNodes": 24,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 91.193,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1997.9129999999827,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.0619999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 362.626,
      "heapDeltaBytes": 1118028,
      "heapUsedBytes": 66927224,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 5.949000000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1991.7069999999626,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.608999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 401.63000000000005,
      "heapDeltaBytes": -4397312,
      "heapUsedBytes": 68752384,
      "domNodes": -295,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 5.807000000000001,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1693.5179999999832,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 16.757,
      "layouts": 18,
      "layoutDurationMs": 2.698,
      "taskDurationMs": 587.154,
      "heapDeltaBytes": -6734248,
      "heapUsedBytes": 66388000,
      "domNodes": -295,
      "jsHeapTotalBytes": 7069696,
      "scriptDurationMs": 66.262,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1689.298000000008,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 17.387,
      "layouts": 18,
      "layoutDurationMs": 2.6879999999999997,
      "taskDurationMs": 588.912,
      "heapDeltaBytes": -7698708,
      "heapUsedBytes": 65553096,
      "domNodes": -295,
      "jsHeapTotalBytes": 7331840,
      "scriptDurationMs": 67.45000000000002,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 899.2600000000266,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 22.977999999999998,
      "layouts": 17,
      "layoutDurationMs": 10.383000000000001,
      "taskDurationMs": 693.813,
      "heapDeltaBytes": 21919924,
      "heapUsedBytes": 105910540,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 18.609,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 115,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8168.432999999994,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 25.677,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4055.65,
      "heapDeltaBytes": 998928,
      "heapUsedBytes": 77464004,
      "domNodes": -277,
      "jsHeapTotalBytes": 643072,
      "scriptDurationMs": 1784.0819999999999,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8205.712999999945,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 21.114999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4045.4970000000003,
      "heapDeltaBytes": -12234156,
      "heapUsedBytes": 89887484,
      "domNodes": -263,
      "jsHeapTotalBytes": -892928,
      "scriptDurationMs": 1763.245,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 10674.502000000019,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10078.713,
      "heapDeltaBytes": -38220480,
      "heapUsedBytes": 178509124,
      "domNodes": -8068,
      "jsHeapTotalBytes": -11530240,
      "scriptDurationMs": 116.53,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 10592.039,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10025.411000000002,
      "heapDeltaBytes": -37812360,
      "heapUsedBytes": 179891396,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12324864,
      "scriptDurationMs": 112.241,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 13125.016000000016,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 8.134000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12594.903,
      "heapDeltaBytes": -34908736,
      "heapUsedBytes": 184903056,
      "domNodes": -8076,
      "jsHeapTotalBytes": -14872576,
      "scriptDurationMs": 578.6940000000001,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 1,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 12971.17700000001,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 9.492,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12470.738000000001,
      "heapDeltaBytes": -31742556,
      "heapUsedBytes": 191988540,
      "domNodes": -8068,
      "jsHeapTotalBytes": -20480000,
      "scriptDurationMs": 568.4970000000001,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333326,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 3851.485000000025,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 54.408000000000015,
      "layouts": 20,
      "layoutDurationMs": 15.375,
      "taskDurationMs": 3697.582000000001,
      "heapDeltaBytes": -33371356,
      "heapUsedBytes": 183611484,
      "domNodes": -8068,
      "jsHeapTotalBytes": 18857984,
      "scriptDurationMs": 51.80500000000001,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 3839.666999999963,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 54.97299999999999,
      "layouts": 20,
      "layoutDurationMs": 15.119999999999994,
      "taskDurationMs": 3698.3269999999993,
      "heapDeltaBytes": -20376848,
      "heapUsedBytes": 179438988,
      "domNodes": -8072,
      "jsHeapTotalBytes": 14716928,
      "scriptDurationMs": 48.387,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 5346.468000000015,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5208.2300000000005,
      "heapDeltaBytes": 11933340,
      "heapUsedBytes": 184381788,
      "domNodes": 0,
      "jsHeapTotalBytes": -6291456,
      "scriptDurationMs": 58.65799999999999,
      "eventListeners": -8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 5325.4779999999755,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5156.738,
      "heapDeltaBytes": -17954724,
      "heapUsedBytes": 178632316,
      "domNodes": 0,
      "jsHeapTotalBytes": -23855104,
      "scriptDurationMs": 53.12800000000001,
      "eventListeners": -6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 440.79700000003186,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 15.719000000000001,
      "layouts": 4,
      "layoutDurationMs": 1.214,
      "taskDurationMs": 87.47500000000001,
      "heapDeltaBytes": 5064408,
      "heapUsedBytes": 74225228,
      "domNodes": 151,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 9.186,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 78.07600000001003,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 10.113999999999997,
      "layouts": 2,
      "layoutDurationMs": 1.151,
      "taskDurationMs": 53.82999999999999,
      "heapDeltaBytes": 2998932,
      "heapUsedBytes": 72123320,
      "domNodes": 124,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 3.6560000000000015,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

@codecov

codecov Bot commented Sep 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #18532   +/-   ##
=============================================
  Coverage              ?   78.61%           
=============================================
  Files                 ?     2009           
  Lines                 ?   111110           
  Branches              ?    31421           
=============================================
  Hits                  ?    87345           
  Misses                ?    23586           
  Partials              ?      179           
Flag Coverage Δ
unit 78.61% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne

Copy link
Copy Markdown
Contributor

Closing: the compatible release-line reproduction is already present; this follow-up is harmful.

Full context for agent readers

Exact head: b445573b4014671c6d583869bd4ce7aec6e3fd5d.

The original backport conflict was content overlap, not missing coverage. cloud/1.54 still uses ToolCallGroup.vue and its Ran 1 tool call activity row; the compatible socket-drop regression coverage tracked at https://linear.app/comfyorg/issue/PM-1199 was already bundled by #18185.

This PR replaces that compatible fixture with the final-main workSummary / workingRow form. The release UI does not render the live Working... row, so every affected case fails before reaching its intended reconnect assertion at browser_tests/fixtures/agentTurnLockFixture.ts:263.

Hosted evidence: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35817673796/job/107045153860

No manual replacement backport is needed unless a product fix, rather than this test-only source PR, is later selected for the release.

@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-test-only Agent tests, fixtures and test support only; no production changes agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-test-only Agent tests, fixtures and test support only; no production changes agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration backport Backporting a PR onto a release candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants