Repository navigation
[backport core/1.54] MiniMax template wiring (PM-993): preserve agent workflow connections after dynamic input reordering - #18509
Conversation
… after dynamic input reordering (#17221) Fixes [PM-993](https://linear.app/comfy-org/issue/PM-993): document links can target the wrong MiniMax input after node configuration or autogrow changes the live input order. - Resolve document input targets by name during initial materialization, reconcile, and remote connect. Preserve live order and extra inputs when every document input name exists live; otherwise use the document input list and order. - Incoming connect preserves matching runtime slot instances and shared arrays, including multiple connects in one batch. Commit the prepared slot order without re-merging it, and reject a target that slot validation removed before changing the graph. - Keep outputs index-based. Document the durable name-targeting rule separately from the interim store-first implementation and its [FE-2504 migration](https://linear.app/comfyorg/issue/FE-2504/agentcrdt-remove-store-first-remote-apply-and-every-reconciliation) in the [ADR](https://github.com/Comfy-Org/ComfyUI_frontend/blob/ryandi/pm-994-minimax-wiring-investigation/docs/adr/CRDT-INPUTS-0030-preserve-named-input-targets.md). - Surface all fixture cleanup failures, supply the bound root graph required by current main, and align regression data, utilities and assertions with repository conventions. Authoritative snapshot reconciliation retains slot arrays but can replace slot instances and lose runtime-only metadata. That existing preservation gap is separate follow-up work, not fixed by the incoming-connect path. Duplicate input names resolve to the first match; uniqueness is not enforced here. Producer-side/local-to-document addressing remains outside this PR under the [Option A ruling](https://github.com/christian-byrne/blocked-on-christian/issues/448). - Local CRDT suites and nodeDataStore: 54 files, 825 passed and 6 expected failures. The final review regression failed before the resolved-target bounds fix and passes afterward. - Application/browser typechecks, full lint, formatting, Knip and ADR validation passed during this follow-up; affected tests and commit hooks were rerun for the final fix. - The cloud browser regression covers live graph serialize/configure, not direct CRDT-document inspection. No local browser execution was performed during this follow-up; see the current remote CI checks for automated browser results. - Integrated remote PR head 322e726 and main 23559a8. The fixture now supplies boundRootGraphId, resolving the build/typecheck failures seen when CI combined the previous head with newer main. --------- Co-authored-by: Terry Jia <terryjia88@gmail.com> Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: Amp <amp@ampcode.com> ## Backport notes (core/1.54) Manual backport of #17221 onto core/1.54. Requested by Christian Byrne to unblock the core/1.54 backport of #18479 (cloud/1.54's #18275 counterpart), which depends on this PR's name-based CRDT input-targeting architecture. Conflicts resolved: - docs/adr/README.md: inserted the new CRDT-INPUTS-0030 row into core/1.54's existing ADR index instead of importing main's full index (core/1.54 does not carry the many other ADRs added on main since). - src/workbench/extensions/agent/crdt/graphMutations.test.ts: kept both sides' new imports (no substantive logic conflict, just adjacent import lines). - src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts: the conflict's theirs-side pulled in BatchOutcome/DocFrameTransport imports that predate #17221 on main (added by a separate, still-unbackported PR) and have no corresponding usage in this file on core/1.54. Kept only the GraphOperation import that #17221 itself adds and that the enqueue-wiring hunk actually uses; dropped the other two as unused (vue-tsc TS6133) rather than smuggling in that unrelated PR's imports. Dropped from this backport (not present, and not required, on core/1.54): - browser_tests/fixtures/agentConversationFixture.ts (modified) and browser_tests/tests/agent/agentConversationReplay.spec.ts (added): this E2E spec and its fixture edits depend on agent-conversation E2E harness additions from other PRs never backported to core/1.54. The file itself is missing on this branch, so the modify/delete conflict is a real gap, not something introduced by this commit. - browser_tests/fixtures/data/minimaxAutogrowReload.ts and browser_tests/fixtures/utils/minimaxAutogrowReload.ts (both added): test-only fixture data/utilities consumed exclusively by the spec above; dropped as dead code once that spec was dropped. All runtime code (graphMutations.ts, agentNodeMaterializer.ts) and all Vitest unit coverage for the CRDT input-targeting logic (graphMutations.test.ts, agentNodeMaterializer.inputOrder.test.ts + its new fixtures, nodeDataStore.test.ts, useAgentCrdtFollower.test.ts) are included unchanged in substance.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1938 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T02:45:34.634Z",
"gitSha": "b224f6c73c77c5929fd5d17e57908fc2ddd89b64",
"branch": "backport-17221-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.0150000000003,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.9319999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.695,
"heapDeltaBytes": 2854300,
"heapUsedBytes": 73633744,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.022000000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2028.801000000044,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.148,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.681,
"heapDeltaBytes": -7550240,
"heapUsedBytes": 63464968,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.813999999999998,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2081.5170000000194,
"styleRecalcs": 79,
"styleRecalcDurationMs": 35.67,
"layouts": 14,
"layoutDurationMs": 4.478000000000001,
"taskDurationMs": 1066.633,
"heapDeltaBytes": 2815492,
"heapUsedBytes": 73846760,
"domNodes": -283,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 164.284,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1890.8249999999498,
"styleRecalcs": 78,
"styleRecalcDurationMs": 26.996000000000002,
"layouts": 14,
"layoutDurationMs": 4.648,
"taskDurationMs": 862.7499999999999,
"heapDeltaBytes": -6478480,
"heapUsedBytes": 63474232,
"domNodes": -278,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 142.736,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1672.3220000000083,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.422,
"layouts": 6,
"layoutDurationMs": 1.1209999999999998,
"taskDurationMs": 375.87100000000004,
"heapDeltaBytes": 4362976,
"heapUsedBytes": 75360036,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.607999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.2890000000934,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.677,
"layouts": 6,
"layoutDurationMs": 1.0040000000000002,
"taskDurationMs": 356.84099999999995,
"heapDeltaBytes": 4632168,
"heapUsedBytes": 75657512,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.518,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 658.1249999999841,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.767,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 434.808,
"heapDeltaBytes": 18691832,
"heapUsedBytes": 82581348,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 148.96599999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 612.1919999999363,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.626000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 421.09400000000005,
"heapDeltaBytes": -7810992,
"heapUsedBytes": 63246800,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 144.199,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2035.462999999993,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.428999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 608.6109999999999,
"heapDeltaBytes": 10572832,
"heapUsedBytes": 87012484,
"domNodes": -269,
"jsHeapTotalBytes": -2727936,
"scriptDurationMs": 31.854000000000006,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2033.8269999999739,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.001999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 657.778,
"heapDeltaBytes": 4633180,
"heapUsedBytes": 80543628,
"domNodes": -281,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 40.95700000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2728.0910000000063,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.407,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1793.1559999999997,
"heapDeltaBytes": 11800872,
"heapUsedBytes": 89135128,
"domNodes": -272,
"jsHeapTotalBytes": -667648,
"scriptDurationMs": 845.8489999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2569.603000000029,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.804,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1716.436,
"heapDeltaBytes": 7158732,
"heapUsedBytes": 84615564,
"domNodes": -277,
"jsHeapTotalBytes": -1191936,
"scriptDurationMs": 834.49,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3804.350999999997,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.650000000000002,
"layouts": 60,
"layoutDurationMs": 13.384999999999998,
"taskDurationMs": 1852.571,
"heapDeltaBytes": 1619336,
"heapUsedBytes": 80050468,
"domNodes": -288,
"jsHeapTotalBytes": 3039232,
"scriptDurationMs": 784.8199999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3612.400999999977,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.298000000000004,
"layouts": 60,
"layoutDurationMs": 12.399000000000001,
"taskDurationMs": 1689.343,
"heapDeltaBytes": 10453796,
"heapUsedBytes": 77228268,
"domNodes": -274,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 744.81,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3503.237000000013,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.583000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2329.9939999999997,
"heapDeltaBytes": 370184,
"heapUsedBytes": 68190776,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 1121.427,
"eventListeners": 190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3205.1899999999023,
"styleRecalcs": 43,
"styleRecalcDurationMs": 10.888000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2034.1569999999995,
"heapDeltaBytes": 7502576,
"heapUsedBytes": 88566592,
"domNodes": -277,
"jsHeapTotalBytes": 835584,
"scriptDurationMs": 983.795,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2048.6040000000116,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.53,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 612.457,
"heapDeltaBytes": 7126556,
"heapUsedBytes": 84404692,
"domNodes": -272,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 33.86600000000001,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2053.358000000003,
"styleRecalcs": 7,
"styleRecalcDurationMs": 10.540999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 629.5450000000001,
"heapDeltaBytes": 7017936,
"heapUsedBytes": 84276012,
"domNodes": -273,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 32.05100000000001,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 662.5690000000191,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.531999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.55400000000003,
"heapDeltaBytes": 15142928,
"heapUsedBytes": 88223096,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 146.092,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 602.7379999999312,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.589000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.007,
"heapDeltaBytes": 14616160,
"heapUsedBytes": 87724668,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 135.12099999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2012.2870000000148,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.814,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.5090000000001,
"heapDeltaBytes": -8324084,
"heapUsedBytes": 63671824,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.09,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2020.921000000044,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.315999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.72099999999995,
"heapDeltaBytes": 7920804,
"heapUsedBytes": 81062292,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 6.897000000000002,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1734.722999999974,
"styleRecalcs": 77,
"styleRecalcDurationMs": 26.912000000000006,
"layouts": 18,
"layoutDurationMs": 4.879,
"taskDurationMs": 805.7370000000001,
"heapDeltaBytes": -15843076,
"heapUsedBytes": 57186244,
"domNodes": -296,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 95.09200000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.0930000000153,
"styleRecalcs": 77,
"styleRecalcDurationMs": 25.474999999999998,
"layouts": 18,
"layoutDurationMs": 5.117,
"taskDurationMs": 844.183,
"heapDeltaBytes": -6697776,
"heapUsedBytes": 66459204,
"domNodes": -296,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 101.049,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.4779999999682,
"styleRecalcs": 21,
"styleRecalcDurationMs": 30.153,
"layouts": 17,
"layoutDurationMs": 14.828999999999999,
"taskDurationMs": 962.7860000000002,
"heapDeltaBytes": -5250948,
"heapUsedBytes": 83763852,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 29.425,
"eventListeners": 2387,
"totalBlockingTimeMs": 134,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8443.240000000003,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.97,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5962.942,
"heapDeltaBytes": 2147020,
"heapUsedBytes": 78206292,
"domNodes": -278,
"jsHeapTotalBytes": 1691648,
"scriptDurationMs": 2672.864,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8301.300000000083,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.025999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5615.8330000000005,
"heapDeltaBytes": -7611464,
"heapUsedBytes": 68224352,
"domNodes": -277,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 2548.2479999999996,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15805.500999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15229.847,
"heapDeltaBytes": -34806376,
"heapUsedBytes": 176328812,
"domNodes": -8072,
"jsHeapTotalBytes": -19836928,
"scriptDurationMs": 269.36800000000005,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 15859.054000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15329.446,
"heapDeltaBytes": -35821804,
"heapUsedBytes": 182713708,
"domNodes": -8068,
"jsHeapTotalBytes": -3411968,
"scriptDurationMs": 248.31200000000004,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 18521.242000000027,
"styleRecalcs": 147,
"styleRecalcDurationMs": 15.953000000000022,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18254.055,
"heapDeltaBytes": -63190388,
"heapUsedBytes": 165515056,
"domNodes": -8068,
"jsHeapTotalBytes": -15933440,
"scriptDurationMs": 909.9520000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 63,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 19109.451000000037,
"styleRecalcs": 138,
"styleRecalcDurationMs": 17.483999999999973,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18837.844999999998,
"heapDeltaBytes": -39546328,
"heapUsedBytes": 165122804,
"domNodes": -8068,
"jsHeapTotalBytes": -9187328,
"scriptDurationMs": 886.343,
"eventListeners": -14931,
"totalBlockingTimeMs": 52,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5602.964000000043,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.87700000000002,
"layouts": 20,
"layoutDurationMs": 22.609999999999992,
"taskDurationMs": 5504.575999999999,
"heapDeltaBytes": -40710004,
"heapUsedBytes": 176315308,
"domNodes": -8068,
"jsHeapTotalBytes": 10473472,
"scriptDurationMs": 114.31799999999998,
"eventListeners": -14929,
"totalBlockingTimeMs": 278,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5786.934999999971,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.67500000000003,
"layouts": 20,
"layoutDurationMs": 24.805999999999994,
"taskDurationMs": 5709.562,
"heapDeltaBytes": -40158128,
"heapUsedBytes": 199244136,
"domNodes": -8068,
"jsHeapTotalBytes": 11640832,
"scriptDurationMs": 106.74,
"eventListeners": -14929,
"totalBlockingTimeMs": 315,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8029.928999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7917.385999999999,
"heapDeltaBytes": 12449628,
"heapUsedBytes": 168894516,
"domNodes": 0,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 114.53000000000002,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7993.303000000083,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7763.005999999999,
"heapDeltaBytes": -4528004,
"heapUsedBytes": 178816880,
"domNodes": 0,
"jsHeapTotalBytes": -4456448,
"scriptDurationMs": 145.12500000000006,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 92.40399999998772,
"styleRecalcs": 5,
"styleRecalcDurationMs": 10.894,
"layouts": 2,
"layoutDurationMs": 1.025,
"taskDurationMs": 65.78399999999999,
"heapDeltaBytes": 3010248,
"heapUsedBytes": 70990784,
"domNodes": 125,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 4.411,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 469.7759999999107,
"styleRecalcs": 18,
"styleRecalcDurationMs": 20.559,
"layouts": 3,
"layoutDurationMs": 1.4379999999999997,
"taskDurationMs": 114.583,
"heapDeltaBytes": 4918148,
"heapUsedBytes": 74072956,
"domNodes": 142,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.817000000000002,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.54 #18509 +/- ##
=============================================
+ Coverage 83.55% 83.58% +0.03%
=============================================
Files 2094 2096 +2
Lines 123648 123758 +110
Branches 31499 33398 +1899
=============================================
+ Hits 103315 103447 +132
+ Misses 20154 20132 -22
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 18 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…s multiple autogrow groups (#18512) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790128455751879?thread_ts=1789965317.152049&cid=C0BGH348Z0C)_ ## Summary Manual backport of #18275 to `core/1.54`, following the same pattern proven for the `cloud/1.54` backport (#18479). **STACKED ON #18509 — do not merge this before #18509 merges.** This branch is based on `backport-17221-to-core-1.54` (#18509's head), not on `origin/core/1.54` directly, because `core/1.54` proper still resolves agent CRDT inputs positionally and lacks the name-based input-targeting architecture from #17221 that #18275 builds directly on top of (`mergeInputSlotsByName`/`hasNonGrowthInputSetChange` in `graphMutations.ts`). Once #18509 merges into `core/1.54`, this PR's base should be retargeted/rebased onto `core/1.54` before merging. ## Conflict resolution notes - `browser_tests/fixtures/agentConversationFixture.ts`: dropped. Doesn't exist on this branch (added by still-unbackported #17875); nothing here imports it, including the new `agentCrdtMultiAutogrowRealign.spec.ts` (only comment references, no real import). - `src/lib/litegraph/src/LGraphCanvas.ts` (`selectItems`): kept this branch's existing body. The only diff was an unrelated `Array.from` → spread refactor from #17048's `ownsSelectable` filter, which isn't on this branch (`ownsSelectable` doesn't exist anywhere in `src/`). - `src/core/graph/widgets/dynamicWidgets.ts`, `AgentPanelRoot.vue`: additive conflicts, took the incoming side. Dropped an incoming `useSettingStore` import in `AgentPanelRoot.vue` (belongs to unbackported #17730, unused here). - `src/workbench/extensions/agent/crdt/graphMutations.ts`: took the new by-name `connect`/`commitUpsertNode` handlers wholesale (the actual fix). Uncovered missing dependency: `linkPresentationStore` (from unbackported #17875). Ported `src/types/linkPresentation.ts` and `src/stores/linkPresentationStore.ts` (+ unit test) from `main`, and wired `const linkPresentationStore = useLinkPresentationStore()`. - `graphMutations.test.ts`: same missing-dependency shape; `useLinkPresentationStore` import ended up unused in the test file, removed it. ## Additional gaps beyond the cloud/1.54 backport's notes (found and verified, not just copied) - `browser_tests/fixtures/agentFollowerHostSocket.ts` was missing (needed by the new `MultiAutogrowRealignHarness.ts`). Ported verbatim from `main`, which required exporting `DOC_PROTOCOL_VERSION` from `docFrameClient.ts` (it was a local `const`). - `commitUpsertNode`'s call to `applyWidgetValues` used a 5th `guardLocalEdits` argument that only exists on `main` via unbackported PR #18361 (the "local-edit guard" feature, already on `cloud/1.54` via #18423 but not on `core/1.54`). Dropped the extra argument to match this branch's existing 4-parameter `applyWidgetValues` — this guard is unrelated to #18275's actual fix (named-link realignment), so dropping it doesn't affect this PR's mechanism; it just means core/1.54 doesn't yet get #18361's separate improvement. - `zAutogrowOptions` import in `graphMutations.ts`: verified this already resolves fine — `@/schemas/nodeDefSchema` re-exports `@comfyorg/object-info-parser`, which already defines it. Not a gap. - `zComfyApiWorkflow` in `workflowSchema.ts` (used by the new `MultiAutogrowRealignHarness.ts`): wasn't exported on this branch (only `ComfyApiWorkflow` the type was). Exported it, matching how `main` already exports it. - `MultiAutogrowRealignHarness.ts` / `savedWorkflowPersistence.ts` imported `PromptResponse`/`UserDataFullInfo` from `@/platform/remote/comfyui/types`, a module that doesn't exist on this older branch. Both types live in `@/schemas/apiSchema` here; fixed the import paths. - `reconcileAutogrowInputs` (new additive export in `dynamicWidgets.ts`) has no caller on this branch — its only call site on `main` is in `agentNodeMaterializer.ts`, added by a separate, unbackported PR (not #18275's own diff, and not #17221's either). Dropped it as dead code rather than smuggling in that unrelated PR's wiring. ## Verification - `pnpm typecheck` — clean - `pnpm exec eslint` on all changed files — clean - `pnpm exec oxfmt --check` on all changed files — clean, all correctly formatted - `pnpm knip` — clean - `pnpm vitest run` on `graphMutations.test.ts`, `dynamicWidgets.test.ts`, `linkStore.test.ts`, `nodeDataStore.test.ts`, `linkPresentationStore.test.ts`, `crdtSession.test.ts`, `agentNodeMaterializer.multiAutogrow.test.ts` — 7 files, 198 passed / 1 expected fail - `pnpm exec playwright test --list` — collects cleanly, no `@e2e/fixtures` resolution errors (2237 tests / 367 files total, including the 2 new specs in `agentCrdtMultiAutogrowRealign.spec.ts`) --------- Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XqLXka9Jsg8EMTYmsnZjjv 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01XqLXka9Jsg8EMTYmsnZjjv --- _Generated by [Claude Code](https://claude.ai/code/session_01XqLXka9Jsg8EMTYmsnZjjv)_ --------- Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: bymyself <cbyrne@comfy.org> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: Claude <noreply@anthropic.com>
Requested by Christian Byrne · Slack thread
Summary
Manual backport of #17221 to
core/1.54. Christian asked for this directly in Slack to unblock backporting #18479 (thecloud/1.54counterpart of #18275), which depends on #17221's name-based CRDT input-targeting architecture thatcore/1.54currently lacks (it resolves inputs positionally). An automated backport was not attempted since this was a deliberately-requested manual op.Original PR #17221: "MiniMax template wiring (PM-993): preserve agent workflow connections after dynamic input reordering." Fixes PM-993: document links could target the wrong MiniMax input after node configuration or autogrow changed the live input order. Resolves document input targets by name (not position) during initial materialization, reconcile, and remote connect; preserves live order/extra inputs when every document input name exists live; keeps outputs index-based. See
docs/adr/CRDT-INPUTS-0030-preserve-named-input-targets.md.Conflict resolution notes
docs/adr/README.md: inserted the newCRDT-INPUTS-0030row intocore/1.54's existing ADR index in alphabetical order, rather than importingmain's full index (core/1.54doesn't carry the many other ADRs added onmainsince it branched).src/workbench/extensions/agent/crdt/graphMutations.test.ts: adjacent-import conflict only, kept both sides' new imports.src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts: the conflict's "theirs" side pulled inBatchOutcome/DocFrameTransportimports that actually predate MiniMax template wiring (PM-993): preserve agent workflow connections after dynamic input reordering #17221 onmain(added by a separate, still-unbackported PR) and have no corresponding usage in this file oncore/1.54. Kept only theGraphOperationimport MiniMax template wiring (PM-993): preserve agent workflow connections after dynamic input reordering #17221 itself adds (used by theenqueue-wiring hunk); dropped the other two as unused (vue-tscTS6133) rather than smuggling in that unrelated PR's imports.src/workbench/extensions/agent/crdt/graphMutations.tsandagentNodeMaterializer.ts: applied cleanly, no conflicts.Dropped from this backport (not present, and not required, on
core/1.54)browser_tests/fixtures/agentConversationFixture.ts(modified) andbrowser_tests/tests/agent/agentConversationReplay.spec.ts(added): this E2E spec and its fixture edit depend on agent-conversation E2E harness infrastructure from other PRs never backported tocore/1.54— the fixture file itself doesn't exist on this branch at all. Dropping it doesn't affect the runtime fix; it's Playwright coverage only.browser_tests/fixtures/data/minimaxAutogrowReload.tsandbrowser_tests/fixtures/utils/minimaxAutogrowReload.ts(both added): fixture data/utilities consumed exclusively by the spec above; dropped as dead code once that spec was dropped.All runtime code (
graphMutations.ts,agentNodeMaterializer.ts) and all Vitest unit coverage for the CRDT input-targeting logic (graphMutations.test.ts, the newagentNodeMaterializer.inputOrder.test.ts+ its new fixtures,nodeDataStore.test.ts,useAgentCrdtFollower.test.ts) are included, unchanged in substance from #17221.Verification
pnpm typecheck— cleanpnpm linton the changed files (eslintdirectly; full-repopnpm linthit an unrelated OOM kill on this container'soxlintvitest-cleanup pass, not caused by this diff) — cleanpnpm format:check— clean, all matched files correctly formattedpnpm test:uniton the directly relevant suites (graphMutations.test.ts,agentNodeMaterializer.inputOrder.test.ts,useAgentCrdtFollower.test.ts,nodeDataStore.test.ts) — 4 test files passed (4), 146 tests passed, 1 expected fail. (An unrelated, pre-existing failure inAgentPanelRoot.test.ts— a file this backport never touches — showed up whenpnpm test:unitwas run without file filtering in this environment; it is a happy-domBlob.stream/iframe-loading quirk in media-upload tests, confirmed unrelated by running the four target files directly.)Does this unblock #18275's own core/1.54 backport?
Partially. Landing this PR removes the primary architectural blocker:
core/1.54will havemergeInputSlotsByName/resolveConnectTargetInputsand the rest of the name-based input-targeting rework that #18275 builds directly on top of (its own PR body calls outmergeInputSlotsByName/hasNonGrowthInputSetChangeingraphMutations.tsas the base it extends).However,
core/1.54has at least one more gap of the same shape that thecloud/1.54backport (#18479) also hit: it's missingsrc/stores/linkPresentationStore.tsandsrc/types/linkPresentation.ts(introduced by a separate, still-unbackported PR), which #18275'sgraphMutations.tsdiff uses to preserve link presentation across a replace/displace.core/1.54is also still missingbrowser_tests/fixtures/agentConversationFixture.ts, same ascloud/1.54.So #18275's
core/1.54backport won't be a fully clean cherry-pick once this lands — it will need the same kind of targeted fix #18479 already proved out forcloud/1.54(portinglinkPresentationStore.ts/linkPresentation.ts+ their unit test frommain, and dropping theagentConversationFixture-dependent E2E spec). But it removes the one prerequisite this task was scoped to: the base architecture #18275 assumes is now present.🤖 Generated with Claude Code
https://claude.ai/code/session_01XqLXka9Jsg8EMTYmsnZjjv