Skip to content

feat(website): Workshop /models SEO integration branch - #19494

Merged
benjcooley merged 348 commits into
mainfrom
maanil/seo-integration
Sep 30, 2026
Merged

benjcooley merged 348 commits into
mainfrom
maanil/seo-integration

Conversation

@MaanilVerma

@MaanilVerma MaanilVerma commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Deploy gate: comfy-router#46 is merged and live (2026-09-30). Its follow-up comfy-router#48 (serves /hub/models.md instead of 301ing it to a /workflows 404) must be deployed before this merges. After the merge, purge Cloudflare for /hub/models*, /hub/workflows* and the 30 workflow names in hub-workflow-names.json. The redirects ship as 307; FE-3083 flips them to 308 later.

This branch combines every Workshop /models SEO PR, so merging it to main replaces merging them one by one. It also launches: #19405 commits launchedModelPages = 'all', so all 148 model pages become indexable in the same deploy as the URL move.

Part of FE-2912, FE-2942 (PR 2 is FE-3086), FE-2974 (/minimax 308 is FE-3087)
Fixes FE-2978, FE-2989, FE-2991, FE-2990, FE-2959, FE-2981, FE-2977, FE-2979, FE-3014, FE-2936, FE-2980, FE-2975, FE-3085, FE-2972, FE-2935, FE-2950, FE-2940, FE-2930, FE-2985, FE-2957, FE-2961, FE-2986, FE-2921, FE-2922, FE-2947

Changes

Router follow-up: comfy-router#48 (/hub/models.md routing, 324/324 router tests), deploy before this merges.

The included PRs, in merge order. Every head was checked as contained at the final tip.

PR Ticket What Ben
#18887 FE-2978 Pricing Product markup and full video uploadDate approved
#18889 FE-2989 A unique meta description on every model page approved
#18890 FE-2991 Model page JSON-LD, emitted once noindex lifts approved
#18892 FE-2990 Cleaner tag pills, guard against duplicate summaries approved
#18893 FE-2959, 2981, 2977, 2979 Social tags, hub title, Organization data. The FE-2977 title was confirmed by the owner approved
#19362 FE-3014 Every non-production build is noindex approved
#19366 FE-2936 Model titles lead with "API & Playground" approved
#19402 FE-2980 Every internal link ends with a slash, plus a CI check approved
#19419 FE-2975 Footer links the catalogue on every page and locale approved
#19476 FE-3085 NOINDEX_ROUTES decides noindex for serverless-animation approved; re-approval pending on a one-line follow-up (CodeRabbit approved)
#19359 FE-2974 One typed redirect list that generates vercel.json approved
#19369 FE-2972 A The old to new model URL map approved
#18891 FE-2935 Model content shows whatever the flag says approved
#18899 FE-2942 Model pages render in the static HTML approved
#18898 FE-2950 Catalogue h1 and A to Z links in the static HTML approved
#19375 FE-2940 Related models leave no page unlinked approved
#19385 FE-2930 Examples show the prompt that made them approved
#19394 FE-2985 Render guard e2e: no loader, no layout shift approved
#19357 FE-2957 robots.txt stops blocking our scripts and styles approved
#19360 FE-2961 Turning Workshop off keeps every Models page approved (a CodeRabbit changes-requested review is still open)
#19386 FE-2986 One registry of every Models address approved
#19421 FE-2972 B1 Model pages served at /hub/models approved
#19422 FE-2972 B2 Every old model URL redirects (307) approved
#19424 FE-2972 B3 Workflow pages at /hub/workflows with redirects approved
#19399 FE-2921 One switch decides model robots and sitemap listing approved
#19404 FE-2922 Clean markdown twins for model pages approved
#19405 FE-2947 Lifts noindex on every canonical model page approved
comfy-router#46 FE-3075 Serves /hub/models* from the website and routes /hub/workflows by manifest. Merged and live merged

These fixes exist only on this branch, because they only break once two PRs meet:

The conflict resolutions, briefly: ALTERNATE_TWIN_SOURCES stays deleted as #18898 wants, so /hub/models.md comes from the real catalogue. The hub keeps #18898's single static h1 instead of the WorkshopHero h1 that main's #19320 added. ExamplesTab keeps #19385's figure and caption with main's video poster. The #19399/#19405 indexing tests were rewritten for hub paths. The #19359 redirect test no longer builds /enterprise// from slash-ended routes. The #19369 URL-map test imports PROVIDER_NAMES from its new home. The full table of 47 resolutions is in the integration report.

Review Focus

QA

  • Gates: pnpm typecheck and website typecheck clean, pnpm lint 0 errors, eslint on apps/website clean, pnpm knip clean
  • Website unit: 547 files, 10347 passed, 4 skipped
  • Build A (build:e2e, CI env): 1193 pages; release gate, check:hreflang, validate:llms-txt-links (225 links), validate:jsonld (947 pages), check:link-slashes, check:models-html (148 pages) all pass
  • Build B (WORKSHOP_IN_BUILD=0): same 182 Models pages as the on build, no dist/workshop, / is noindex; with the flag stubbed on, no Run, no Hub nav and no Firebase requests
  • Build C (preview shape): 945 of 945 pages noindex, no canonicals except redirect stubs, no hreflang in the sitemap
  • E2E on Build A: 644 of 645 passed; the one mobile failure passed on rerun. Earlier load flakes (navigation, demos, fdct, wan-3.0, network isolation, render guard) all passed when rerun alone
  • Launch: 148 model pages indexable with canonicals, 149 hub entries in the sitemap, 148 non-empty twins with the model h1, 148 in llms-full.txt, 0 titles over 60, 30 workflow pages still noindex
  • Redirects: 853 rules, 782 to /hub all 307, the MiniMax rows 307, every /hub destination built
  • comfy-router#46 under wrangler dev in front of this build: 312 router tests pass; 148 old model URLs (both slash forms) 307 then 200; 30 workflow names served by the website and their old URLs 307; a non-manifest workflow 302 with no-store; manifest.json passes through; /workflows/ and bare /hub unchanged
  • After the router deploys and this merges: purge Cloudflare, then curl https://comfy.org/hub/models/ for a 200 and three old /models/<slug>/ URLs for one 307 each
  • Rich Results Test on /pricing/ and /learning/animations/character-sheet/, then "Validate fix" on Merchant listings and Videos
  • Rich Results Test on two live model pages: breadcrumbs valid and the breadcrumb URL returns 200 with no redirect
  • GPTBot and Googlebot curls on the hub and one model page, then a GSC live test on both
  • Resubmit the sitemap in Search Console and URL-inspect about 20 model pages on day 0 and day 14
  • Not covered: Rich Results and GSC need production; the redirect matrix used a local shim for vercel.json, since astro preview ignores it

Route constants, path builders and hardcoded hrefs now use the
slash-terminated canonical form, so no internal link points at the
second address of a page.
…e top ten families

Replace the all-or-nothing launch switch with a wave list keyed on Router
model id, so the robots meta, sitemap and markdown twins follow the same
set and survive the move to /hub/models. Wave 1 is the ten families with
the most search demand; setting the launch to 'all' opens the rest.
Also stop the legacy /cinematic-studio redirect from appending a second
slash to the now slash-terminated app route.
Also checks www.comfy.org hrefs and the WORKSHOP_IN_BUILD=0 build, fails on
an empty dist, pairs href quotes, and slashes the remaining supported-model,
llms.txt and pricing FAQ links.
Each plan now has a monthly offer at the list price and a yearly offer
at the billed-yearly total, each with its own cycle link and a
UnitPriceSpecification period (MON/P1M or ANN/P1Y). Education offers
mirror the same two cycles.
…t-not-flag-gated

# Conflicts:
#	apps/website/src/components/workshop/ModelDetail.vue
…gated' into maanil/fe-2957-robots-unblock-assets
…gated' into maanil/fe-2950-catalogue-ssr

# Conflicts:
#	apps/website/e2e/models-catalogue-corrections.spec.ts
#	apps/website/e2e/workshop-workflows.spec.ts
#	apps/website/src/components/workshop/ModelsCatalogue.test.ts
#	apps/website/src/components/workshop/ModelsCatalogue.vue
…gated' into maanil/fe-2942-model-page-ssr

# Conflicts:
#	apps/website/src/components/workshop/ModelDetail.test.ts
…r-site

# Conflicts:
#	apps/website/src/routes/models/[slug].astro
#	apps/website/src/routes/models/index.astro
This was referenced Sep 30, 2026
zeus-onl pushed a commit to zeus-onl/ComfyUI_frontend that referenced this pull request Sep 30, 2026
…et (Comfy-Org#19669)

## Summary

Drop the whole-route JS ceiling from the models catalogue budget test.
Every page loads the same shared layout, and that shared code is almost
the entire total, so the ceiling failed on unrelated site changes
(raised 4× in 2 weeks, e.g. Comfy-Org#17971, and failing again after Comfy-Org#19494).

## Changes

- **What**: Remove `totalBytes < 1_825_000` from
`apps/website/e2e/models-performance.spec.ts`. Keep the catalogue-only
delta budget (`< 900_000`).

## Review Focus

Measured on a production build of main:

| | Bytes | Limit |
|---|---|---|
| Route total | 1,824,947 | 1,825,000 |
| Shared layout (loaded on `/`) | 1,658,812 | none |
| Catalogue delta | 166,135 | 900,000 |

The regression this test was written for, server catalogue data in the
client bundle (Comfy-Org#17604), already fails the build via
`src/integrations/workshop-client-boundary.ts`. Verified locally:
importing `content/workshop-router-contracts.json` into
`ModelsCatalogue.vue` fails the build with "contains server catalogue
data". The delta budget has never been raised and still catches a heavy
dependency added to the catalogue island.
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Oct 3, 2026
## Summary

Opening a category on a hub page shows two titles stacked — the hub's
own, smaller and lighter, above the category's — with the link back to
the categories buried between them. It also keeps offering the Models /
Workflows / Apps switch, which inside a category cannot switch anything:
those are links to three separate pages, so taking one leaves the page
and drops the category on the way out.

The hub's eyebrow and heading step aside again, and the switch goes with
them. The search takes the width the tabs leave behind.

## Changes

- **What**: `ModelsPage.vue` gives its eyebrow and heading up to the
category, and `ModelsCatalogue.vue` passes the section state up so it
knows when to. The three catalogues drop the tab switch inside a section
and let the search field fill the row. `WorkshopSearchField.vue` and the
heading block take a `data-testid` so the tests can read those elements
without walking the DOM.
- **Top padding**: the heading block carried the hub pages' top padding,
so hiding it took that space with it and a category's back link sat on
the nav's edge. The container and `pt-8 max-sm:pt-5 lg:pt-12` now live
on a wrapper outside the condition, which keeps the same `v-if` so a
denied gate reserves nothing.
- **Two cosmetic nudges**, asked for by @mariana953 off the preview, in
all three catalogues: the back link's `-ml-1` → `-ml-2.5` and the
category title's `mt-3` → `mt-5`. The first is optical alignment —
Lucide's `ChevronLeft` starts its ink ~5.3px inside its 16px box, so
`-ml-1` lined up the box and `-ml-2.5` lines up the stroke (chevron ink
x=31.3, heading x=32 at 1280). The second puts 8px more air between the
link and the title it sits above.
- **Dependencies**: none. `main` is merged in: the hub tab scroll
(Comfy-Org#19895) landed while this was open and added its own cases to
`hub-navigation.spec.ts` right where this branch adds the way into a
category. Both sides are kept.

## Review Focus

- **This is a regression, not a new design.** `ModelsCatalogue.vue` used
to render the hero behind `v-if="!inSection"`, so a category replaced
it. Comfy-Org#19494 moved the eyebrow and heading out of the island and the
condition stayed behind; the sibling condition on the subtitle is still
there, a few lines from where the title used to be. What this restores
is the behaviour that shipped before 30 September, not a new idea.
- **The heading is hidden, not removed.** `AppCatalogue.test.ts`,
`ModelsCatalogue.test.ts` and `WorkshopModelsGrid.test.ts` each assert
that these components render no `h1` of their own — the page owns the
only one, which is what @MaanilVerma's SEO work engineered for. So the
heading block keeps rendering and goes `sr-only` in a category: the page
still has exactly one `h1`, the category reads as the section of it that
it is, and the three catalogue suites pass untouched.
I tried promoting the category's `h2` to the page `h1` first. It broke
ten tests, two of which assert `queryByRole('heading', { level: 1 })` is
`null` — the invariant written down. The tests were right and I reverted
it.
- **Why the tabs go.** `CatalogueTabs` renders anchors to
`/hub/models/`, `/hub/workflows/` and `/hub/apps/`. From inside a
category the destination has no notion of it, so the control silently
discards where the reader is. The honest way out is the link that says
"Back to all categories".
- **A use case *is* a category.** On models, `?useCase=…` and the filter
menu open the category view — back link, category title, no tabs — so
two existing navigation tests that clicked a tab from a filtered models
page now leave the category first. The workflows rows are untouched: a
workflow category filter opens no category, so the tab bar is still
there, and each row names the step it takes rather than branching on a
flag.
- **What is untouched.** The top-level view of all three hub pages:
eyebrow, heading, subtitle and tabs exactly as now.

## Verification

- **Unit** — `pnpm test:unit src/components/workshop`: 82 files, 858
tests, all passing. One case added: the page hands its heading and the
tab switch to a category and takes both back, and the `h1` stays in the
document while hidden. The three catalogue suites that pin the no-`h1`
invariant are unchanged.
- **Browser** — `hub-navigation.spec.ts` asserts the whole
`catalogue-tabs` group is absent inside a model category and back after
the link out, and reads the search field's declared cap: `max-width:
480px` outside a category, `none` inside one, capped again on return, on
both the models and the workflows catalogue. Inside a category it also
measures the rendered box past 480, which is what shows the width went
to the field rather than nowhere.
An earlier revision measured the box on *both* sides. That was wrong and
the description said so: outside a category the shared row already holds
the field at 471.3px, well under the cap, so those two readings could
not fail — deleting `sm:max-w-120` left them green. Reading the cap
itself is what discriminates. Mutation-checked on a local build: cap
applied unconditionally → both tests fail; `sm:max-w-120` deleted → both
tests fail; real code → both pass.
Locally, 16 pass and the only failures are the six `keeps the page
steady` cases that assert a `link[rel="canonical"]` a local build does
not emit — they fail on `main` too.
- `pnpm typecheck:website` 0 errors; eslint, prettier and the
repository's `fallow` gate clean on the changed files.
- Measured on a local build at 1280 and 390, in a category: 1 `h1` in
the document, no "HUB" eyebrow on screen, 0 tab bars, 1 back link,
search 836px wide at 1280, first visible content 48px / 20px below the
nav as on every other page.

## Screenshots (if applicable)

Before and after are in the thread with @mariana953, who asked for this;
the preview on this PR shows it — open `/hub/models/` and pick a
category.

---------

Co-authored-by: webshepherd-bot <webshepherd@comfy.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants