Repository navigation
feat(website): Workshop /models SEO integration branch - #19494
Merged
Merged
Conversation
Route constants, path builders and hardcoded hrefs now use the slash-terminated canonical form, so no internal link points at the second address of a page.
…nto maanil/fe-2922-model-markdown-twins
…e top ten families Replace the all-or-nothing launch switch with a wave list keyed on Router model id, so the robots meta, sitemap and markdown twins follow the same set and survive the move to /hub/models. Wave 1 is the ten families with the most search demand; setting the launch to 'all' opens the rest.
…ideo cards server-render
Also stop the legacy /cinematic-studio redirect from appending a second slash to the now slash-terminated app route.
Also checks www.comfy.org hrefs and the WORKSHOP_IN_BUILD=0 build, fails on an empty dist, pairs href quotes, and slashes the remaining supported-model, llms.txt and pricing FAQ links.
Each plan now has a monthly offer at the list price and a yearly offer at the billed-yearly total, each with its own cycle link and a UnitPriceSpecification period (MON/P1M or ANN/P1Y). Education offers mirror the same two cycles.
…t-not-flag-gated # Conflicts: # apps/website/src/components/workshop/ModelDetail.vue
…gated' into maanil/fe-2957-robots-unblock-assets
…gated' into maanil/fe-2950-catalogue-ssr # Conflicts: # apps/website/e2e/models-catalogue-corrections.spec.ts # apps/website/e2e/workshop-workflows.spec.ts # apps/website/src/components/workshop/ModelsCatalogue.test.ts # apps/website/src/components/workshop/ModelsCatalogue.vue
…gated' into maanil/fe-2942-model-page-ssr # Conflicts: # apps/website/src/components/workshop/ModelDetail.test.ts
…nto maanil/fe-2985-content-cls-guard
…nto maanil/fe-2940-related-models-links
…nto maanil/fe-2930-example-gallery
…r-site # Conflicts: # apps/website/src/routes/models/[slug].astro # apps/website/src/routes/models/index.astro
This was referenced Sep 30, 2026
zeus-onl
pushed a commit
to zeus-onl/ComfyUI_frontend
that referenced
this pull request
Sep 30, 2026
…et (Comfy-Org#19669) ## Summary Drop the whole-route JS ceiling from the models catalogue budget test. Every page loads the same shared layout, and that shared code is almost the entire total, so the ceiling failed on unrelated site changes (raised 4× in 2 weeks, e.g. Comfy-Org#17971, and failing again after Comfy-Org#19494). ## Changes - **What**: Remove `totalBytes < 1_825_000` from `apps/website/e2e/models-performance.spec.ts`. Keep the catalogue-only delta budget (`< 900_000`). ## Review Focus Measured on a production build of main: | | Bytes | Limit | |---|---|---| | Route total | 1,824,947 | 1,825,000 | | Shared layout (loaded on `/`) | 1,658,812 | none | | Catalogue delta | 166,135 | 900,000 | The regression this test was written for, server catalogue data in the client bundle (Comfy-Org#17604), already fails the build via `src/integrations/workshop-client-boundary.ts`. Verified locally: importing `content/workshop-router-contracts.json` into `ModelsCatalogue.vue` fails the build with "contains server catalogue data". The delta budget has never been raised and still catches a heavy dependency added to the catalogue island.
Penguinjanator
pushed a commit
to Penguinjanator/ComfyUI_frontend
that referenced
this pull request
Oct 3, 2026
## Summary Opening a category on a hub page shows two titles stacked — the hub's own, smaller and lighter, above the category's — with the link back to the categories buried between them. It also keeps offering the Models / Workflows / Apps switch, which inside a category cannot switch anything: those are links to three separate pages, so taking one leaves the page and drops the category on the way out. The hub's eyebrow and heading step aside again, and the switch goes with them. The search takes the width the tabs leave behind. ## Changes - **What**: `ModelsPage.vue` gives its eyebrow and heading up to the category, and `ModelsCatalogue.vue` passes the section state up so it knows when to. The three catalogues drop the tab switch inside a section and let the search field fill the row. `WorkshopSearchField.vue` and the heading block take a `data-testid` so the tests can read those elements without walking the DOM. - **Top padding**: the heading block carried the hub pages' top padding, so hiding it took that space with it and a category's back link sat on the nav's edge. The container and `pt-8 max-sm:pt-5 lg:pt-12` now live on a wrapper outside the condition, which keeps the same `v-if` so a denied gate reserves nothing. - **Two cosmetic nudges**, asked for by @mariana953 off the preview, in all three catalogues: the back link's `-ml-1` → `-ml-2.5` and the category title's `mt-3` → `mt-5`. The first is optical alignment — Lucide's `ChevronLeft` starts its ink ~5.3px inside its 16px box, so `-ml-1` lined up the box and `-ml-2.5` lines up the stroke (chevron ink x=31.3, heading x=32 at 1280). The second puts 8px more air between the link and the title it sits above. - **Dependencies**: none. `main` is merged in: the hub tab scroll (Comfy-Org#19895) landed while this was open and added its own cases to `hub-navigation.spec.ts` right where this branch adds the way into a category. Both sides are kept. ## Review Focus - **This is a regression, not a new design.** `ModelsCatalogue.vue` used to render the hero behind `v-if="!inSection"`, so a category replaced it. Comfy-Org#19494 moved the eyebrow and heading out of the island and the condition stayed behind; the sibling condition on the subtitle is still there, a few lines from where the title used to be. What this restores is the behaviour that shipped before 30 September, not a new idea. - **The heading is hidden, not removed.** `AppCatalogue.test.ts`, `ModelsCatalogue.test.ts` and `WorkshopModelsGrid.test.ts` each assert that these components render no `h1` of their own — the page owns the only one, which is what @MaanilVerma's SEO work engineered for. So the heading block keeps rendering and goes `sr-only` in a category: the page still has exactly one `h1`, the category reads as the section of it that it is, and the three catalogue suites pass untouched. I tried promoting the category's `h2` to the page `h1` first. It broke ten tests, two of which assert `queryByRole('heading', { level: 1 })` is `null` — the invariant written down. The tests were right and I reverted it. - **Why the tabs go.** `CatalogueTabs` renders anchors to `/hub/models/`, `/hub/workflows/` and `/hub/apps/`. From inside a category the destination has no notion of it, so the control silently discards where the reader is. The honest way out is the link that says "Back to all categories". - **A use case *is* a category.** On models, `?useCase=…` and the filter menu open the category view — back link, category title, no tabs — so two existing navigation tests that clicked a tab from a filtered models page now leave the category first. The workflows rows are untouched: a workflow category filter opens no category, so the tab bar is still there, and each row names the step it takes rather than branching on a flag. - **What is untouched.** The top-level view of all three hub pages: eyebrow, heading, subtitle and tabs exactly as now. ## Verification - **Unit** — `pnpm test:unit src/components/workshop`: 82 files, 858 tests, all passing. One case added: the page hands its heading and the tab switch to a category and takes both back, and the `h1` stays in the document while hidden. The three catalogue suites that pin the no-`h1` invariant are unchanged. - **Browser** — `hub-navigation.spec.ts` asserts the whole `catalogue-tabs` group is absent inside a model category and back after the link out, and reads the search field's declared cap: `max-width: 480px` outside a category, `none` inside one, capped again on return, on both the models and the workflows catalogue. Inside a category it also measures the rendered box past 480, which is what shows the width went to the field rather than nowhere. An earlier revision measured the box on *both* sides. That was wrong and the description said so: outside a category the shared row already holds the field at 471.3px, well under the cap, so those two readings could not fail — deleting `sm:max-w-120` left them green. Reading the cap itself is what discriminates. Mutation-checked on a local build: cap applied unconditionally → both tests fail; `sm:max-w-120` deleted → both tests fail; real code → both pass. Locally, 16 pass and the only failures are the six `keeps the page steady` cases that assert a `link[rel="canonical"]` a local build does not emit — they fail on `main` too. - `pnpm typecheck:website` 0 errors; eslint, prettier and the repository's `fallow` gate clean on the changed files. - Measured on a local build at 1280 and 390, in a category: 1 `h1` in the document, no "HUB" eyebrow on screen, 0 tab bars, 1 back link, search 836px wide at 1280, first visible content 48px / 20px below the nav as on every other page. ## Screenshots (if applicable) Before and after are in the thread with @mariana953, who asked for this; the preview on this PR shows it — open `/hub/models/` and pick a category. --------- Co-authored-by: webshepherd-bot <webshepherd@comfy.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deploy gate: comfy-router#46 is merged and live (2026-09-30). Its follow-up comfy-router#48 (serves
/hub/models.mdinstead of 301ing it to a /workflows 404) must be deployed before this merges. After the merge, purge Cloudflare for/hub/models*,/hub/workflows*and the 30 workflow names inhub-workflow-names.json. The redirects ship as 307; FE-3083 flips them to 308 later.This branch combines every Workshop /models SEO PR, so merging it to main replaces merging them one by one. It also launches: #19405 commits
launchedModelPages = 'all', so all 148 model pages become indexable in the same deploy as the URL move.Part of FE-2912, FE-2942 (PR 2 is FE-3086), FE-2974 (/minimax 308 is FE-3087)
Fixes FE-2978, FE-2989, FE-2991, FE-2990, FE-2959, FE-2981, FE-2977, FE-2979, FE-3014, FE-2936, FE-2980, FE-2975, FE-3085, FE-2972, FE-2935, FE-2950, FE-2940, FE-2930, FE-2985, FE-2957, FE-2961, FE-2986, FE-2921, FE-2922, FE-2947
Changes
Router follow-up: comfy-router#48 (
/hub/models.mdrouting, 324/324 router tests), deploy before this merges.The included PRs, in merge order. Every head was checked as contained at the final tip.
uploadDateNOINDEX_ROUTESdecides noindex for serverless-animationvercel.json/hub/models/hub/workflowswith redirects/hub/models*from the website and routes/hub/workflowsby manifest. Merged and liveThese fixes exist only on this branch, because they only break once two PRs meet:
scripts/check-models-html.tsreads each page atmodel.hrefand skips models without a page (f1df1e4).e2e/fixtures/modelsCatalogue.tsreadsdist/hub/models(f87bb4c).routerIdsByModelPageaccepts an optionalhref, since feat(website): move model pages to /hub/models (step B1 of 2): serve model pages at /hub/models #19421 made it optional and feat(website): lift noindex on every canonical model page #19405 no longer typechecked (9783819).ModelStatuslinks a successor only when it has a page, for the same reason on feat(website): render each model page in the static HTML #18899 (c4761d8).modelJsonLd.tspoints at/hub/models/instead of the/models/redirect (eb985b6). Its label still says "Models" while the nav says "Hub".getRoutes().workshop, and itstest.failis gone now that feat(website): render the models catalogue heading and A to Z links as static HTML #18898 renders the h1 (831499f).resetWorkshopAccountSourceresetsdecision; a clean auto-merge of main's FE-2899 feat(website): read the session balance in the run gates and credit action #19454 into fix(website): show models content whatever the workshop flag says #18891 left it assigning a variable that no longer exists (c28c7a7).The conflict resolutions, briefly:
ALTERNATE_TWIN_SOURCESstays deleted as #18898 wants, so/hub/models.mdcomes from the real catalogue. The hub keeps #18898's single static h1 instead of theWorkshopHeroh1 that main's #19320 added.ExamplesTabkeeps #19385's figure and caption with main's video poster. The #19399/#19405 indexing tests were rewritten for hub paths. The #19359 redirect test no longer builds/enterprise//from slash-ended routes. The #19369 URL-map test importsPROVIDER_NAMESfrom its new home. The full table of 47 resolutions is in the integration report.Review Focus
Launch rides along with the URL move. If launch should stay a separate step, set
launchedModelPagesinapps/website/src/config/model-page-launch.tstonew Set()before merging.Main's feat(website): land Mar's complete Hub design pass #19320 gives the catalogue island its own h1 through
WorkshopHero. This branch keeps feat(website): render the models catalogue heading and A to Z links as static HTML #18898's static h1 and renders only the subtitle inModelsCatalogue.vue, so the hub has exactly one h1.fix(website): let NOINDEX_ROUTES decide noindex for /platform/serverless-animation #19476 overlaps the open community PR fix(website): exclude serverless animation route from sitemap #18591 (same sitemap exclusion for serverless-animation). One of them should be closed once this lands.
QA
pnpm typecheckand website typecheck clean,pnpm lint0 errors, eslint onapps/websiteclean,pnpm knipcleanbuild:e2e, CI env): 1193 pages; release gate,check:hreflang,validate:llms-txt-links(225 links),validate:jsonld(947 pages),check:link-slashes,check:models-html(148 pages) all passWORKSHOP_IN_BUILD=0): same 182 Models pages as the on build, nodist/workshop,/is noindex; with the flag stubbed on, no Run, no Hub nav and no Firebase requestsllms-full.txt, 0 titles over 60, 30 workflow pages still noindexwrangler devin front of this build: 312 router tests pass; 148 old model URLs (both slash forms) 307 then 200; 30 workflow names served by the website and their old URLs 307; a non-manifest workflow 302 with no-store;manifest.jsonpasses through;/workflows/and bare/hubunchangedhttps://comfy.org/hub/models/for a 200 and three old/models/<slug>/URLs for one 307 each/pricing/and/learning/animations/character-sheet/, then "Validate fix" on Merchant listings and Videosvercel.json, sinceastro previewignores it