Repository navigation
feat(website): move model pages to /hub/models (step B1 of 2): serve model pages at /hub/models - #19421
feat(website): move model pages to /hub/models (step B1 of 2): serve model pages at /hub/models#19421MaanilVerma wants to merge 37 commits into
Conversation
Every redirect now lives in src/config/redirects.ts. vercel.json is generated from it (pnpm --filter @comfyorg/website sync:redirects) and Astro's redirect map is derived from it, so the two can no longer disagree. A test fails when vercel.json drifts, a destination is itself a source, a source repeats, or an internal destination lacks its trailing slash. The Astro-only entries and the 12 supported-models alias pages now answer with a real 308 on Vercel instead of a 200 meta-refresh page, and both slash forms of every source redirect.
/minimax/ had 7.6k clicks in the 90 days before it moved to /minimax-h3/. A 307 is not a canonical signal, so that equity never transferred. The redirects test encoded the temporary status on purpose; it now asserts 308.
- Sources must be plain literal paths, so a generated slug can't smuggle a path-to-regexp pattern into vercel.json. - A row whose slash form is a page stays out of Astro's map, since its stub would overwrite that page. - Both emitters read the marker fields by definedness. - The test derives MiniMax, Enterprise and Pricing paths from routes.ts. - sync:redirects validates vercel.json before rewriting it.
Derives a /hub/models/<model-task>/ slug for each of the 148 model pages and each of the 212 aliases from the display name. Nothing reads the map yet; the switch-over uses it later.
… maanil/fe-2972-hub-serve
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (101 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 8a695a9ec190da414b1c29a162101fdb2c0da857
Full docs: ADR-DEVEX-LINT-0015 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-19421.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-pe6avcj8t-comfyui.vercel.app Last updated: 2026-09-29T22:09:18Z for 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-29T22:17:36.634Z",
"gitSha": "1081ceac36cc338a0238a7fa2ea4e2a061d12db1",
"branch": "maanil/fe-2972-hub-serve",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2016.4800000000014,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.168000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 322.562,
"heapDeltaBytes": -2288040,
"heapUsedBytes": 77048940,
"domNodes": -228,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 10.053,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2033.2569999999919,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.708,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.389,
"heapDeltaBytes": -10678544,
"heapUsedBytes": 68627556,
"domNodes": -228,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.344000000000001,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1702.9440000000022,
"styleRecalcs": 71,
"styleRecalcDurationMs": 16.291,
"layouts": 12,
"layoutDurationMs": 4.465,
"taskDurationMs": 567.117,
"heapDeltaBytes": -1084308,
"heapUsedBytes": 78350228,
"domNodes": -228,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 110.064,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1720.595000000003,
"styleRecalcs": 73,
"styleRecalcDurationMs": 18.444999999999997,
"layouts": 12,
"layoutDurationMs": 4.684,
"taskDurationMs": 657.4340000000001,
"heapDeltaBytes": -13490764,
"heapUsedBytes": 66151344,
"domNodes": -228,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 131.29399999999998,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1719.319999999982,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.884,
"layouts": 6,
"layoutDurationMs": 1.281,
"taskDurationMs": 254.85200000000003,
"heapDeltaBytes": 1769136,
"heapUsedBytes": 81010940,
"domNodes": 53,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 12.967,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1732.2430000000395,
"styleRecalcs": 33,
"styleRecalcDurationMs": 7.895000000000001,
"layouts": 6,
"layoutDurationMs": 1.05,
"taskDurationMs": 191.88,
"heapDeltaBytes": 1532332,
"heapUsedBytes": 80633076,
"domNodes": 53,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 8.356000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 502.837999999997,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.6399999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 305.32800000000003,
"heapDeltaBytes": 17665544,
"heapUsedBytes": 97421320,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 110.265,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 535.1590000000215,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.92,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.194,
"heapDeltaBytes": 17978308,
"heapUsedBytes": 97374484,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 124.63199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668750000000003,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 907.3080000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.154,
"heapDeltaBytes": 9283816,
"heapUsedBytes": 86251644,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 42.50500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 295,
"frameDurationMs": 26.958823529411763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 936.0489999999686,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 544.636,
"heapDeltaBytes": 9368228,
"heapUsedBytes": 86754396,
"domNodes": 0,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 44.547000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 311,
"frameDurationMs": 27.450000000000006,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 717.9499999999734,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 285.8330000000002,
"heapDeltaBytes": 15560380,
"heapUsedBytes": 90593884,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 98.10900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 96,
"frameDurationMs": 21.079411764705902,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 718.9619999999763,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 293.1180000000002,
"heapDeltaBytes": 16080004,
"heapUsedBytes": 91246956,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 97.54999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 95,
"frameDurationMs": 21.076470588235306,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6355.004000000008,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.44700000000000123,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5386.108,
"heapDeltaBytes": -7082268,
"heapUsedBytes": 73285512,
"domNodes": 0,
"jsHeapTotalBytes": -10485760,
"scriptDurationMs": 4150.566,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.895517241379306,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6428.236000000026,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.4720000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5461.874,
"heapDeltaBytes": 306232,
"heapUsedBytes": 80620048,
"domNodes": 0,
"jsHeapTotalBytes": -14155776,
"scriptDurationMs": 4145.0199999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 5,
"frameDurationMs": 21.388333333333332,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6153.067000000021,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.2730000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5207.808,
"heapDeltaBytes": -9794892,
"heapUsedBytes": 70791764,
"domNodes": 0,
"jsHeapTotalBytes": -15204352,
"scriptDurationMs": 4001.556,
"eventListeners": 0,
"totalBlockingTimeMs": 76,
"frameDurationMs": 21.444405594405595,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6623.753999999963,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5742.661,
"heapDeltaBytes": -2219568,
"heapUsedBytes": 70997356,
"domNodes": 0,
"jsHeapTotalBytes": -6553600,
"scriptDurationMs": 4413.164,
"eventListeners": 0,
"totalBlockingTimeMs": 32,
"frameDurationMs": 24.23589743589744,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2029.642000000024,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1579999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 351.11400000000003,
"heapDeltaBytes": -36624720,
"heapUsedBytes": 82838696,
"domNodes": -228,
"jsHeapTotalBytes": 163840,
"scriptDurationMs": 26.227,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2030.4100000000176,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.855,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.103,
"heapDeltaBytes": -36512292,
"heapUsedBytes": 83343740,
"domNodes": -228,
"jsHeapTotalBytes": -884736,
"scriptDurationMs": 28.997999999999998,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2121.9559999999547,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.301000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1211.337,
"heapDeltaBytes": -40995024,
"heapUsedBytes": 79681840,
"domNodes": -228,
"jsHeapTotalBytes": 389120,
"scriptDurationMs": 589.096,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666141732283467,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2161.7090000000303,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.619000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1245.572,
"heapDeltaBytes": 23992856,
"heapUsedBytes": 86303992,
"domNodes": -228,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 601.4609999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665891472868218,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3085.868000000005,
"styleRecalcs": 64,
"styleRecalcDurationMs": 12.395000000000001,
"layouts": 60,
"layoutDurationMs": 15.165000000000001,
"taskDurationMs": 1190.715,
"heapDeltaBytes": 11024344,
"heapUsedBytes": 77283724,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 529.4449999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6654054054054,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3132.8039999999646,
"styleRecalcs": 64,
"styleRecalcDurationMs": 11.854999999999999,
"layouts": 60,
"layoutDurationMs": 14.911999999999999,
"taskDurationMs": 1154.392,
"heapDeltaBytes": 12538888,
"heapUsedBytes": 76814300,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 529.28,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665957446808513,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2187.234999999987,
"styleRecalcs": 45,
"styleRecalcDurationMs": 7.279000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1404.231,
"heapDeltaBytes": 17302896,
"heapUsedBytes": 82383664,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 693.924,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.793846153846157,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2187.8829999999994,
"styleRecalcs": 45,
"styleRecalcDurationMs": 7.065999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1254.69,
"heapDeltaBytes": 17628420,
"heapUsedBytes": 82712468,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 636.3030000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66564885496183,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2011.1410000000092,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.065000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.32700000000006,
"heapDeltaBytes": 21400448,
"heapUsedBytes": 84257784,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 29.338000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2030.2910000000338,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.2520000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 309.11599999999993,
"heapDeltaBytes": -37507104,
"heapUsedBytes": 83343720,
"domNodes": -228,
"jsHeapTotalBytes": -1146880,
"scriptDurationMs": 20.938,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 493.7370000000101,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.853999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 287.038,
"heapDeltaBytes": 12648500,
"heapUsedBytes": 94404864,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 100.58600000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 437.93599999997923,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.702999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 250.03299999999996,
"heapDeltaBytes": 13142472,
"heapUsedBytes": 93717164,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 92.78599999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2025.9320000000116,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.9759999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 293.826,
"heapDeltaBytes": -11880788,
"heapUsedBytes": 69021712,
"domNodes": -244,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.508,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2020.4819999999586,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.7090000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 312.36600000000004,
"heapDeltaBytes": 21607192,
"heapUsedBytes": 74944812,
"domNodes": -243,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.456999999999999,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.3990000000326,
"styleRecalcs": 77,
"styleRecalcDurationMs": 18.65,
"layouts": 16,
"layoutDurationMs": 5.596,
"taskDurationMs": 552.8290000000001,
"heapDeltaBytes": -17360592,
"heapUsedBytes": 64071964,
"domNodes": -244,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 86.09700000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.3029999999867,
"styleRecalcs": 73,
"styleRecalcDurationMs": 19.908999999999995,
"layouts": 16,
"layoutDurationMs": 6.072,
"taskDurationMs": 651.104,
"heapDeltaBytes": -2964032,
"heapUsedBytes": 78472348,
"domNodes": -244,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 98.041,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 834.780999999964,
"styleRecalcs": 19,
"styleRecalcDurationMs": 19.849999999999998,
"layouts": 5,
"layoutDurationMs": 8.192000000000002,
"taskDurationMs": 627.645,
"heapDeltaBytes": 21687220,
"heapUsedBytes": 102478484,
"domNodes": 13667,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 21.371000000000002,
"eventListeners": 2383,
"totalBlockingTimeMs": 67,
"frameDurationMs": 18.938636363636366,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8165.212999999994,
"styleRecalcs": 251,
"styleRecalcDurationMs": 40.143,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3985.585,
"heapDeltaBytes": -35371764,
"heapUsedBytes": 83879940,
"domNodes": -228,
"jsHeapTotalBytes": 389120,
"scriptDurationMs": 1845.2160000000001,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66605316973415,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8199.074999999993,
"styleRecalcs": 251,
"styleRecalcDurationMs": 39.645,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3667.262,
"heapDeltaBytes": -40701272,
"heapUsedBytes": 78657312,
"domNodes": -228,
"jsHeapTotalBytes": -135168,
"scriptDurationMs": 1848.577,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66598778004073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12091.47200000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12020.301,
"heapDeltaBytes": -26845352,
"heapUsedBytes": 180556872,
"domNodes": -3046,
"jsHeapTotalBytes": 14737408,
"scriptDurationMs": 188.487,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.311670020120722,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-idle",
"durationMs": 11034.19000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10260.024,
"heapDeltaBytes": -32767612,
"heapUsedBytes": 188374264,
"domNodes": -8049,
"jsHeapTotalBytes": -8445952,
"scriptDurationMs": 143.613,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.73157894736842,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 12021.47100000002,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.805000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11728.818000000001,
"heapDeltaBytes": -36514632,
"heapUsedBytes": 188802540,
"domNodes": -3045,
"jsHeapTotalBytes": 6451200,
"scriptDurationMs": 607.7220000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.888190476190477,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 13785.95699999994,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.202999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13365.648999999998,
"heapDeltaBytes": 4223204,
"heapUsedBytes": 191284056,
"domNodes": -8049,
"jsHeapTotalBytes": -31264768,
"scriptDurationMs": 569.888,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.602040816326532,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 4609.433000000025,
"styleRecalcs": 20,
"styleRecalcDurationMs": 54.55399999999999,
"layouts": 20,
"layoutDurationMs": 23.386000000000003,
"taskDurationMs": 4567.790999999999,
"heapDeltaBytes": -16260656,
"heapUsedBytes": 197367624,
"domNodes": -8049,
"jsHeapTotalBytes": 22999040,
"scriptDurationMs": 75.14,
"eventListeners": -14923,
"totalBlockingTimeMs": 56,
"frameDurationMs": 28.9796178343949,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 4269.979999999919,
"styleRecalcs": 20,
"styleRecalcDurationMs": 55.326000000000015,
"layouts": 20,
"layoutDurationMs": 20.523,
"taskDurationMs": 4169.355,
"heapDeltaBytes": 7511248,
"heapUsedBytes": 207429900,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 69.738,
"eventListeners": 0,
"totalBlockingTimeMs": 99,
"frameDurationMs": 25.70240963855422,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6646.541999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6613.744000000001,
"heapDeltaBytes": 13312392,
"heapUsedBytes": 195079060,
"domNodes": 0,
"jsHeapTotalBytes": -25690112,
"scriptDurationMs": 103.159,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.73899613899614,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5568.687999999952,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5203.611000000001,
"heapDeltaBytes": 19300020,
"heapUsedBytes": 187516700,
"domNodes": 0,
"jsHeapTotalBytes": -19136512,
"scriptDurationMs": 74.26099999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.61705685618729,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "workflow-execution",
"durationMs": 101.1530000000107,
"styleRecalcs": 7,
"styleRecalcDurationMs": 11.187,
"layouts": 3,
"layoutDurationMs": 1.582,
"taskDurationMs": 76.541,
"heapDeltaBytes": -17041832,
"heapUsedBytes": 80506164,
"domNodes": 113,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 6.986999999999998,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 138.56399999997393,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.886000000000001,
"layouts": 3,
"layoutDurationMs": 1.131,
"taskDurationMs": 122.798,
"heapDeltaBytes": -44506496,
"heapUsedBytes": 52581520,
"domNodes": 113,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 5.707,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 450.41299999991224,
"styleRecalcs": 78,
"styleRecalcDurationMs": 76.299,
"layouts": 76,
"layoutDurationMs": 17.282,
"taskDurationMs": 408.451,
"heapDeltaBytes": 13319868,
"heapUsedBytes": 91202760,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 140.011,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67037037037035,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 391.88400000000456,
"styleRecalcs": 78,
"styleRecalcDurationMs": 72.044,
"layouts": 76,
"layoutDurationMs": 15.585999999999999,
"taskDurationMs": 353.23699999999997,
"heapDeltaBytes": 12726904,
"heapUsedBytes": 96472136,
"domNodes": 76,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 115.813,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304356,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 666.2320000000364,
"styleRecalcs": 78,
"styleRecalcDurationMs": 178.74499999999998,
"layouts": 76,
"layoutDurationMs": 19.411,
"taskDurationMs": 636.604,
"heapDeltaBytes": 8142180,
"heapUsedBytes": 131250200,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 156.805,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 896.7529999999897,
"styleRecalcs": 78,
"styleRecalcDurationMs": 220.036,
"layouts": 76,
"layoutDurationMs": 26.128,
"taskDurationMs": 869.106,
"heapDeltaBytes": 10111820,
"heapUsedBytes": 128471792,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 241.773,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.64509803921568,
"p95FrameDurationMs": 33.30000000000018
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🎭 Playwright: ✅ 2160 passed, 0 failed📊 Browser Reports
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## maanil/fe-2986-models-url-registry #19421 +/- ##
=====================================================================
Coverage 84.14% 84.15%
=====================================================================
Files 3202 3204 +2
Lines 155760 155818 +58
Branches 42186 40311 -1875
=====================================================================
+ Hits 131069 131131 +62
+ Misses 22982 22976 -6
- Partials 1709 1711 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
QA
Round 2 (31f4e7f): the onboarding e2e now takes the model id from data ( Round 3 (24fa571), Ben's review: deploy order is now in the description (comfy-router#46 first, B1 must not reach production before it). Round 4 (0036005, cascade): merges #19386 (8a695a9), #19369 (7863a60) and #19359 (015a264). The registry is on the roots API with roots Round 5 (f32a6d6, cascade, merges #19369 at 93ceff2): the URL map now freezes from the Round 6 (d3ebd9b, cascade, merges #19369 at da1053e): clean merge, bringing in the string-escaping fix for the URL map. Proof: regenerating the URL map changes nothing (148 pages, 212 aliases); URL map tests: 33 passed; typecheck 0 errors. |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @MaanilVerma.
Found 8 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 2 |
| 🟢 Low | 5 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
…ld slugs, and report the hub as the Datadog view
A frozen row whose name now slugifies differently shows under Check these first, and the generated headers name the hand edit to model-urls.ts as the way to change a published slug.
benjcooley
left a comment
There was a problem hiding this comment.
Re-review — approved (scoped to a0b6ad7)
One new commit since my approval, and it fixes the second of my two non-blocking notes. Two files, ~20 lines. No new inline comments — I went looking and did not find anything.
What it does: prepareModelPage now destructures href and throws Models route <slug> resolved to <model>, which has no page ahead of both the redirect and the page branch, then returns model: { ...model, href } so href is a plain string for canonicalPath and Astro.redirect.
I verified the mechanism rather than trusting the claim. The author's explanation is exactly right, which means my note was a silent-failure bug, not a type nit:
astro/dist/core/middleware/index.js:38—redirect(path, status)returnsnew Response(null, { status: status || 302, headers: { Location: path } }).- Node coerces:
new Headers({ Location: undefined }).get('location')is the string"undefined". getRedirectLocationOrThrowonly throws on!location, and"undefined"is truthy, so it passes.
A page-less model reaching that branch would have shipped a stub with content="0;url=undefined" and no error anywhere.
What I checked on the fix itself:
- Throw ordering is right — an alias pointing at a page-less model gets the descriptive error, not a bad
Location. - The
{ ...model, href }spread is lossless:detailForreturns a plain object literal with no getters, so the runtime payloadpage.json.tsserialises is byte-identical. - Nothing downstream depends on object identity.
relatedModelscomparesother.slug !== model.slugandworkshopExecutionId, and it is called with the originalmodelabove the return anyway. !hrefalso catches the empty string, buthubModelHrefalways yields/hub/models/<slug>/and workflow hrefs are/models/<slug>/, so there is no legitimate empty value to false-positive on.- Tests cover both branches (
it.for(['old-alias', model.slug])) and both cases fail on the old code, so they are not vacuous.
Two things to carry into the merge, neither blocking:
- CI has not run the real jobs on this head yet — only
dispatchandcla-assistantare queued;typecheck,lintand the unit suites have not spun up. Thehref?: stringchange has genuine fan-out, so typecheck green ona0b6ad79a0is the gate. (The author reports it clean locally; I cannot verify from here.) - The zod/TS drift note on
models-catalogue.tsis still open and unanswered. Explicitly non-blocking and it should not hold the merge, but it is a different seam from the one just fixed —fetchModelsCatalogueparses in the browser withhrefrequired — so either flip it to.optional()or fold it into B2/B3 and close the thread.
And the standing one, unchanged: comfy-router#46 must be live before this reaches production.
Reviewed by Claude. If any of this is wrong, say why and I'll drop it.
…-hub-serve # Conflicts: # apps/website/src/config/indexing.test.ts # apps/website/src/config/models-url-registry.test.ts # apps/website/src/config/models-url-registry.ts # apps/website/src/config/workshop-release.test.ts
# Conflicts: # apps/website/scripts/generate-model-url-map.test.ts # apps/website/scripts/generate-model-url-map.ts
…ub-serve # Conflicts: # apps/website/package.json # apps/website/src/config/redirects.test.ts
benjcooley
left a comment
There was a problem hiding this comment.
Re-review — approved (scoped to 997bda0 + the three merges)
All my threads are now resolved. One new commit of the author's own work, plus three merges of already-approved sibling branches. No new inline comments — I went looking, including specifically at whether the merges damaged anything I had verified earlier.
The one new commit: 997bda0
This closes my last open note, and with a better answer than the one I gave. I suggested loosening presentationSchema.href to .optional(); instead the schema stays required — correct, since catalogue.json genuinely only ships published pages — and the invariant is pinned by two tests:
serves a payload the catalogue island parsesis stronger than it reads. zod v3z.objectstrips unknown keys, sotoEqual(payload)fails in both directions: schema rejecting a shipped field, and schema missing a shipped field. A real round-trip pin.fails the catalogue parse when a disabled model leaks into the payloadproves the rejection fires, andexpect(disabled).toBeDefined()stops it passing vacuously if content ever has no disabled model.not.toHaveProperty('href')pins the distinction that matters for JSON — key omitted, nothref: undefined.
What I re-verified after the merges
The merges pull in #19359, #19369 and #19386. My concern was that the redirect-list refactor could quietly break the page.json guard I asked for last round. It did not:
- The guard survived and was correctly re-pointed at
toVercelRedirects(siteRedirects)— the typed source of truth — instead of parsingvercel.json. Better than before: a bad entry is caught in the list, before it can even be synced. vercel.jsonis pinned to that list (redirects.test.ts:65), so guarding the list transitively guards the shipped artifact. No gap.- I checked all 71 generated redirect sources: none matches
/models/<id>/page.jsonor/models/catalogue.json, and there is no premature/models->/hub/modelsrule. The model-ish sources are all/p/supported-models/*and/platform/models, different trees. models-url-registry.tsmerged cleanly against base's new explicit-roots refactor. The PR correctly passes[MODELS_BASE_PATH, HUB_MODELS_PATH]and the localisUnderModelshelper I reviewed in round 1 is gone rather than left stale. Base's newassertOneHubis satisfied — onehub, with/modelsas analias.hreflangAudit.tsis a mechanicalredirects->astroRedirectsrename from the refactor.
The slug-freeze work (906fb56, 7863a60) is confined to generation and reporting, so it cannot move a URL at build time. pageUseCase introduces a new throw, but only inside the generator and its test, where failing loud is right.
One gap, not blocking
The merge-order note in the description is now incomplete. It says "Stacked on #19386; also merges #19369" — but this branch now also merges #19359 (one typed redirect list), which contributes the single largest change in the diff (vercel.json +288, redirects.ts +179). All three are open and approved, so this is ordinary stacked-PR hygiene rather than unreviewed scope creep. But given that this PR's entire risk story is ordering, an unlisted merged-in dependency is worth fixing in the body so nobody lands this ahead of #19359.
Worth knowing for anyone reading the diff cold: at 95 files / +3491 this no longer looks like a PR titled "serve model pages at /hub/models". The great majority of that is the three approved siblings, not this step's work.
Standing items
- comfy-router#46 must be live before this reaches production. Unchanged, still the thing I would personally confirm at merge time — it is a process constraint with no code enforcing it.
- CI on this head is still spinning up. The
href?: stringfan-out plus a three-way merge makes typecheck-green on0036005f72the real gate.
Reviewed by Claude. If any of this is wrong, say why and I'll drop it.
Each row in model-urls.ts now records the display name its slug was frozen against, so a deliberate slug edit no longer plants a permanent review row. Also note that the freeze covers renames, not removals.
… maanil/fe-2972-hub-serve # Conflicts: # apps/website/scripts/generate-model-url-map.test.ts # apps/website/scripts/generate-model-url-map.ts
benjcooley
left a comment
There was a problem hiding this comment.
Re-review — approved (scoped to 93ceff2)
One real commit plus a merge of the already-approved #19369. Touches only the URL-map generator and its generated output. One non-blocking note inline.
The critical check: did any URL move?
model-urls.ts changed by 451 lines, which is exactly the shape a silent URL move would take, so I verified it rather than reading the commit message. I extracted every oldSlug -> newSlug and alias -> newSlug pair from both revisions and diffed them:
- 360 pairs before, 360 after, byte-identical. The churn is entirely the new
namefield. Nothing moved.
The logic change is correct
The diagnosis is a good one: the previous drift flag compared modelUrlSlug(model.name) against the frozen newSlug, so a deliberate slug edit — the documented escape hatch — would plant a review row that could never be cleared. Recording the name each slug was frozen against and comparing modelUrlSlug(name) against modelUrlSlug(frozenName) fixes it at the right granularity: it flags when the name moves enough to change the URL, and stays quiet for a cosmetic rename that slugifies the same.
The freeze carries both newSlug and name forward, so a flag stays sticky until a human edits name to acknowledge the rename. For a URL-stability gate that is the right choice, and it matches the documentation.
Test coverage is the strongest part
keeps every recorded slug when display names changerenames every model (${name} Renamed) and asserts the compiled map equals the committedmodelPageUrls/modelAliasUrlsexactly. That is a freeze proof against the real 148-page map, not a fixture.- The three-case table on the rename flag covers precisely what this commit is for: flags a real rename, ignores a deliberate slug edit, and ignores a rename that slugifies identically. It also asserts the
## Check these first (N)count, so a spurious row fails. - Every guard I have relied on across these reviews survived the 73-line test rewrite: generator-output-matches-file, old-slug/
workshopModelsparity, alias targets, and the route-collision check.
Switching the generator's frozen source from hub-models.ts to model-urls.ts directly also drops its dependency on app config. Cleaner.
Standing items
- comfy-router#46 must be live before this reaches production. Unchanged.
- The merge-order note in the description still omits #19359, which this branch merges. Worth adding.
- CI on this head is queued again (20 checks). Still the real gate.
Reviewed by Claude. If any of this is wrong, say why and I'll drop it.
A display name with a newline or other control character emitted an unterminated literal and broke model-urls.ts. Literals now go through one helper that escapes via JSON.stringify and picks the quote oxfmt would, so the byte-for-byte test and the formatter agree.
benjcooley
left a comment
There was a problem hiding this comment.
Re-review — approved (scoped to da1053e)
One commit plus a merge of the already-approved #19369. All threads now resolved. One non-blocking test-coverage suggestion inline.
The bug was real
The previous escaper was v.replace(/[\\']/g, '\\$&') — backslash and apostrophe only. A display name containing a newline or any control character would emit a raw newline inside a '...' literal, producing an unterminated string and a model-urls.ts that does not compile. Worth noting this was latent from round 1 but only became reachable in 93ceff2, which started writing display names into the generated file. Catching it one commit later is good follow-through.
I executed the helper rather than trusting a mental trace
stringLiteral leans on one genuinely subtle line — JSON.stringify(text).slice(1, -1).replace(/\\"/g, '"') — where a literal backslash sitting immediately before a quote could make the un-escape eat the wrong character. I ran it against 11 inputs, including two your tests do not cover:
back\"quote— backslash directly before a double quote. Emits'back\\"quote'. Correct.''\"— two apostrophes forcing the double-quote branch, with a backslash-quote adjacency. Emits"''\\\"". Correct.- Plus NUL, lone surrogate, non-ASCII, U+2028, and the three from your suite.
All 11 round-trip exactly. The \\ and \" cases work because the intermediate body is always "valid escape text with " raw", so re-escaping only the chosen quote is safe.
The oxfmt claim checks out empirically
Since model-urls.ts is not in the oxfmt ignore list, format:check reads it, so the quote choice has to match the formatter or the byte-for-byte test and the formatter fight. I piped samples through oxfmt --stdin-filepath:
| input | oxfmt | helper |
|---|---|---|
| apostrophe only | "Veo's 3 quote" |
same |
| double quotes only | 'Say "hi"' |
same |
| 1 apostrophe vs 2 quotes | 'it\'s "x"' |
same |
Identical in all three. countOf("'") > countOf('"') is exactly Prettier's fewer-escapes rule with a tie going to the default quote.
Two things I confirmed because they are the usual ways this breaks
model-urls.tsandMODEL_URL_MAP.mdare byte-identical after the change. The new escaper is a pure no-op on all 148 real display names, so no slug, name or URL churned andformat:checkcannot be affected today.typescriptis a declared devDependency ofapps/websiteand resolves from there, so the test'simport { transpileModule } from 'typescript'is legitimate under pnpm's isolatednode_modulesrather than an accidental hoist.
The test itself is the right shape for a code generator: compile the emitted module with the real compiler, assert zero diagnostics, then execute it and assert the string round-trips — rather than asserting on emitted text.
Standing items
- comfy-router#46 must be live before this reaches production. Unchanged.
- The description still omits #19359 from its merge-order note.
- CI is queued again (21 checks). Five rounds in I have still not seen
typecheckor the unit suites go green on any head of this PR. Given thehref?: stringfan-out, four merges, and a generator whose correctness now rests on these tests, I would insist on a green run before merge rather than treat it as a formality.
Reviewed by Claude. If any of this is wrong, say why and I'll drop it.
benjcooley
left a comment
There was a problem hiding this comment.
Re-review — approved (scoped to 07e7af9)
Smallest possible round: three test literals, one file, +4/-1. No inline comments. All threads resolved.
Verified by execution, not by reading
The cases added are test inputs that themselves contain escapes, so a mis-escaped literal would pass while covering something other than what it claims — the precise failure mode stringLiteral exists to prevent. I evaluated all three and checked which branch each takes:
| test literal | runtime string | branch | reaches /\\"/g |
|---|---|---|---|
'Veo "3" Text-to-Video' |
Veo "3" Text-to-Video |
single-quote | yes |
'back\\"quote' |
back\"quote |
single-quote | yes |
"''\\\"" |
''\" |
double-quote | yes |
All three round-trip. The third is the one that matters: the double-quote branch had no coverage before this commit, and it is the only input shape that reaches the un-escape and the replaceAll(quote, ...) re-escape in sequence. That is the gap I flagged, closed correctly.
Where this leaves the review
Across six rounds every substantive item is now resolved: the deploy-ordering blocker (documented), the alias e2e coverage (restored), the page.json coupling (guarded, and the guard survived the redirect-list refactor), the href optionality (throws, with the redirect slot narrowed), the zod/TS drift (pinned by a round-trip test), removals (tracked as FE-3084), and the generator's string escaping (fixed and now fully branch-covered).
I have nothing further on the code.
The one item still open is CI, and it has moved
For the first time the checks are progressing rather than sitting queued. 14 green, zero failures anywhere. But the green ones are all lightweight: json-lint, yaml-lint, validate-pins, adr-links, binary-size, fallow, deploy-preview, Socket. The decisive jobs are still queued:
typecheck,typecheck-aux,lint,build,repo-checks,scan
No unit-test job has reported yet either, and the correctness of this PR's generator now rests on the tests in generate-model-url-map.test.ts. So: approving on the code with confidence, but I would still not merge until typecheck and the test suites are green on 3807c73c08. That is not a formality here — the href?: string change has fan-out across roughly ten call sites and the branch carries four merges.
Also still outstanding, trivially: the description omits #19359 from its merge-order note, and comfy-router#46 must be live before this reaches production.
Reviewed by Claude. If any of this is wrong, say why and I'll drop it.
The parity step only walked dist/models, so it stayed green after model pages moved to dist/hub/models. List pages under the registry's roots.
|
QA (6040907): the Workshop-off parity step now lists pages under every Models URL registry root. Ran the step locally after both builds: |
benjcooley
left a comment
There was a problem hiding this comment.
Re-review — approved (scoped to 6040907)
One commit, and it is a catch I missed. One trivial inline note; nothing blocking.
You found a guard that had silently stopped guarding
The parity step ran find apps/website/dist/models -name index.html. After this PR moved model pages to dist/hub/models, that walk no longer saw them — and critically it did not go empty, because dist/models/ still holds the old pages, showcase, apps/* and workflows/*. So the ! -s baseline guard never fired and the step kept reporting green while covering none of the 148 pages this PR actually introduces.
This is the same failure mode I checked for on the page.json guard after the redirect-list refactor, and I did not think to check the CI build-parity step for it. Good catch.
It also has an uncomfortable implication for my own standing advice: the full green run on 3807c73c08 includes this step passing because it was blind. Green CI was, in this one respect, not evidence.
The fix
Driving the walk from modelsUrlRegistry.roots is the right shape — the registry already owns which roots exist, so a future root is covered without touching the workflow. Checked:
join(DIST, '/hub/models')resolves todist/hub/models(join, notresolve, so the leading slash is a segment rather than an absolute path).relative(DIST, file)emitsmodels/<slug>/index.htmlandhub/models/<slug>/index.html, matching the oldsed "s|.*/dist/||"format, so the diff semantics are unchanged.- Both captures use the same function and the same JS sort, so ordering is consistent across the comparison by construction.
--silentis necessary and present; without it pnpm's script banner would land in the baseline file.- The
! -sbaseline guard survives, and the second capture is protected by thediffitself. - Exporting
modelsUrlRootsis inert —models-url-registry.tswas already imported by the release gate, and the client boundary still catches a leak viamodel-urls.ts.
CI: the standing gate is now satisfied
For six rounds I have been saying I would not merge without a green run. On 3807c73c08 it is green, and comprehensively so:
typecheck, typecheck-aux, lint, build, repo-checks, website-unit, website-build, website-e2e (all four shards), and codecov — all success, zero failures.
That covers the href?: string fan-out and the four merges, which was the substance of my concern. 60409074e1 is re-running now and touches only CI wiring and one inert export.
With that, everything I have raised across seven rounds is closed. The remaining items are not mine to close: comfy-router#46 must be live before this reaches production, and the description still omits #19359 from its merge-order note.
Reviewed by Claude. If any of this is wrong, say why and I'll drop it.
benjcooley
left a comment
There was a problem hiding this comment.
Re-review — approved (scoped to e91961b)
One line changed. No inline comments. Every thread from my reviews is now resolved.
The fix
DIST resolves from the script's own location instead of process.cwd(). Path arithmetic confirmed: dirname(fileURLToPath(import.meta.url)) is apps/website/scripts, .. is apps/website, so DIST is apps/website/dist.
The property that matters: that is the same directory the old form resolved to under pnpm --filter, which sets cwd to the package root. So CI behaviour is unchanged and this cannot have destabilised the parity step that just went green. The import.meta.url pattern is also already proven here — generate-model-url-map.ts relies on it under tsx and its byte-for-byte test passes.
You verified it the right way, too: 0 lines from the repo root before, the same 543 after. That number cross-checks against the registry — 148 hub pages + 148 old pages + 212 alias stubs + 2 roots + showcase + 2 apps + the workflow pages lands right about there.
The open question from last round is answered
I flagged that a guard which had been blind might, once it could see, surface a pre-existing difference. It does not. The parity step lives in the build: job of CI: Website Build, and on 60409074e1 that job is green — so the Workshop-off build really does produce the same page set under /hub/models as the Workshop-on build. The fixed check passes on its merits, not because it is still looking at the wrong directory.
CI, stated precisely
Last round I said "zero failures" off a mid-run snapshot. It held: 3807c73c08 finished at 128 checks, 111 success, 15 skipped, 2 cancelled, zero failures.
One thing worth naming so nobody trips on it: 60409074e1 does show 2 failures — Custom Nodes Ecosystem Matrix test and e2e-status. Both are the cancellation cascade from pushing e91961b1b7 while that run was in flight; the concurrency group cancelled 16 checks, and e2e-status is an aggregate gate over them. Neither touches apps/website. The two heads allowed to run to completion are clean, and the current head is at 75 success / 30 in progress / zero failures.
Where this ends
Eight rounds, and everything I raised is closed: the deploy-ordering blocker, the alias e2e coverage, the page.json coupling, the href optionality and its redirect slot, the zod/TS drift, removals (FE-3084), the generator's string escaping and its branch coverage, the blind CI parity walk, and this. Full CI green on the code. I have nothing left.
The two remaining items are not mine to close: comfy-router#46 must be live before this reaches production, and the description still omits #19359 from its merge-order note.
Reviewed by Claude. If any of this is wrong, say why and I'll drop it.
## Summary **Deploy gate: comfy-router#46 is merged and live (2026-09-30). Its follow-up comfy-router#48 (serves `/hub/models.md` instead of 301ing it to a /workflows 404) must be deployed before this merges. After the merge, purge Cloudflare for `/hub/models*`, `/hub/workflows*` and the 30 workflow names in `hub-workflow-names.json`. The redirects ship as 307; FE-3083 flips them to 308 later.** This branch combines every Workshop /models SEO PR, so merging it to main replaces merging them one by one. It also launches: Comfy-Org#19405 commits `launchedModelPages = 'all'`, so all 148 model pages become indexable in the same deploy as the URL move. Part of FE-2912, FE-2942 (PR 2 is FE-3086), FE-2974 (/minimax 308 is FE-3087) Fixes FE-2978, FE-2989, FE-2991, FE-2990, FE-2959, FE-2981, FE-2977, FE-2979, FE-3014, FE-2936, FE-2980, FE-2975, FE-3085, FE-2972, FE-2935, FE-2950, FE-2940, FE-2930, FE-2985, FE-2957, FE-2961, FE-2986, FE-2921, FE-2922, FE-2947 ## Changes Router follow-up: comfy-router#48 (`/hub/models.md` routing, 324/324 router tests), deploy before this merges. The included PRs, in merge order. Every head was checked as contained at the final tip. | PR | Ticket | What | Ben | |---|---|---|---| | Comfy-Org#18887 | FE-2978 | Pricing Product markup and full video `uploadDate` | approved | | Comfy-Org#18889 | FE-2989 | A unique meta description on every model page | approved | | Comfy-Org#18890 | FE-2991 | Model page JSON-LD, emitted once noindex lifts | approved | | Comfy-Org#18892 | FE-2990 | Cleaner tag pills, guard against duplicate summaries | approved | | Comfy-Org#18893 | FE-2959, 2981, 2977, 2979 | Social tags, hub title, Organization data. The FE-2977 title was confirmed by the owner | approved | | Comfy-Org#19362 | FE-3014 | Every non-production build is noindex | approved | | Comfy-Org#19366 | FE-2936 | Model titles lead with "API & Playground" | approved | | Comfy-Org#19402 | FE-2980 | Every internal link ends with a slash, plus a CI check | approved | | Comfy-Org#19419 | FE-2975 | Footer links the catalogue on every page and locale | approved | | Comfy-Org#19476 | FE-3085 | `NOINDEX_ROUTES` decides noindex for serverless-animation | approved; re-approval pending on a one-line follow-up (CodeRabbit approved) | | Comfy-Org#19359 | FE-2974 | One typed redirect list that generates `vercel.json` | approved | | Comfy-Org#19369 | FE-2972 A | The old to new model URL map | approved | | Comfy-Org#18891 | FE-2935 | Model content shows whatever the flag says | approved | | Comfy-Org#18899 | FE-2942 | Model pages render in the static HTML | approved | | Comfy-Org#18898 | FE-2950 | Catalogue h1 and A to Z links in the static HTML | approved | | Comfy-Org#19375 | FE-2940 | Related models leave no page unlinked | approved | | Comfy-Org#19385 | FE-2930 | Examples show the prompt that made them | approved | | Comfy-Org#19394 | FE-2985 | Render guard e2e: no loader, no layout shift | approved | | Comfy-Org#19357 | FE-2957 | robots.txt stops blocking our scripts and styles | approved | | Comfy-Org#19360 | FE-2961 | Turning Workshop off keeps every Models page | approved (a CodeRabbit changes-requested review is still open) | | Comfy-Org#19386 | FE-2986 | One registry of every Models address | approved | | Comfy-Org#19421 | FE-2972 B1 | Model pages served at `/hub/models` | approved | | Comfy-Org#19422 | FE-2972 B2 | Every old model URL redirects (307) | approved | | Comfy-Org#19424 | FE-2972 B3 | Workflow pages at `/hub/workflows` with redirects | approved | | Comfy-Org#19399 | FE-2921 | One switch decides model robots and sitemap listing | approved | | Comfy-Org#19404 | FE-2922 | Clean markdown twins for model pages | approved | | Comfy-Org#19405 | FE-2947 | Lifts noindex on every canonical model page | approved | | comfy-router#46 | FE-3075 | Serves `/hub/models*` from the website and routes `/hub/workflows` by manifest. Merged and live | merged | These fixes exist only on this branch, because they only break once two PRs meet: - `scripts/check-models-html.ts` reads each page at `model.href` and skips models without a page (f1df1e4). - `e2e/fixtures/modelsCatalogue.ts` reads `dist/hub/models` (f87bb4c). - `routerIdsByModelPage` accepts an optional `href`, since Comfy-Org#19421 made it optional and Comfy-Org#19405 no longer typechecked (9783819). - `ModelStatus` links a successor only when it has a page, for the same reason on Comfy-Org#18899 (c4761d8). - The model breadcrumb in `modelJsonLd.ts` points at `/hub/models/` instead of the `/models/` redirect (eb985b6). Its label still says "Models" while the nav says "Hub". - Twin, meta-description and entry tests use the hub pages and the new tag set (86ac3b0, d4ffc0f). - The render guard finds the catalogue through `getRoutes().workshop`, and its `test.fail` is gone now that Comfy-Org#18898 renders the h1 (831499f). - A new test renders a real model page and checks its markdown twin has the model's h1 (9a6c5cb). - Main's newer catalogue and workflow e2e cases use the hub addresses (2aeda77). - `resetWorkshopAccountSource` resets `decision`; a clean auto-merge of main's Comfy-Org#19454 into Comfy-Org#18891 left it assigning a variable that no longer exists (c28c7a7). The conflict resolutions, briefly: `ALTERNATE_TWIN_SOURCES` stays deleted as Comfy-Org#18898 wants, so `/hub/models.md` comes from the real catalogue. The hub keeps Comfy-Org#18898's single static h1 instead of the `WorkshopHero` h1 that main's Comfy-Org#19320 added. `ExamplesTab` keeps Comfy-Org#19385's figure and caption with main's video poster. The Comfy-Org#19399/Comfy-Org#19405 indexing tests were rewritten for hub paths. The Comfy-Org#19359 redirect test no longer builds `/enterprise//` from slash-ended routes. The Comfy-Org#19369 URL-map test imports `PROVIDER_NAMES` from its new home. The full table of 47 resolutions is in the integration report. ## Review Focus - Launch rides along with the URL move. If launch should stay a separate step, set `launchedModelPages` in `apps/website/src/config/model-page-launch.ts` to `new Set()` before merging. - Main's Comfy-Org#19320 gives the catalogue island its own h1 through `WorkshopHero`. This branch keeps Comfy-Org#18898's static h1 and renders only the subtitle in `ModelsCatalogue.vue`, so the hub has exactly one h1. - Comfy-Org#19476 overlaps the open community PR Comfy-Org#18591 (same sitemap exclusion for serverless-animation). One of them should be closed once this lands. ## QA - [x] Gates: `pnpm typecheck` and website typecheck clean, `pnpm lint` 0 errors, eslint on `apps/website` clean, `pnpm knip` clean - [x] Website unit: 547 files, 10347 passed, 4 skipped - [x] Build A (`build:e2e`, CI env): 1193 pages; release gate, `check:hreflang`, `validate:llms-txt-links` (225 links), `validate:jsonld` (947 pages), `check:link-slashes`, `check:models-html` (148 pages) all pass - [x] Build B (`WORKSHOP_IN_BUILD=0`): same 182 Models pages as the on build, no `dist/workshop`, `/` is noindex; with the flag stubbed on, no Run, no Hub nav and no Firebase requests - [x] Build C (preview shape): 945 of 945 pages noindex, no canonicals except redirect stubs, no hreflang in the sitemap - [x] E2E on Build A: 644 of 645 passed; the one mobile failure passed on rerun. Earlier load flakes (navigation, demos, fdct, wan-3.0, network isolation, render guard) all passed when rerun alone - [x] Launch: 148 model pages indexable with canonicals, 149 hub entries in the sitemap, 148 non-empty twins with the model h1, 148 in `llms-full.txt`, 0 titles over 60, 30 workflow pages still noindex - [x] Redirects: 853 rules, 782 to /hub all 307, the MiniMax rows 307, every /hub destination built - [x] comfy-router#46 under `wrangler dev` in front of this build: 312 router tests pass; 148 old model URLs (both slash forms) 307 then 200; 30 workflow names served by the website and their old URLs 307; a non-manifest workflow 302 with no-store; `manifest.json` passes through; `/workflows/` and bare `/hub` unchanged - [x] After the router deploys and this merges: purge Cloudflare, then curl `https://comfy.org/hub/models/` for a 200 and three old `/models/<slug>/` URLs for one 307 each - [x] Rich Results Test on `/pricing/` and `/learning/animations/character-sheet/`, then "Validate fix" on Merchant listings and Videos - [x] Rich Results Test on two live model pages: breadcrumbs valid and the breadcrumb URL returns 200 with no redirect - [x] GPTBot and Googlebot curls on the hub and one model page, then a GSC live test on both - [x] Resubmit the sitemap in Search Console and URL-inspect about 20 model pages on day 0 and day 14 - Not covered: Rich Results and GSC need production; the redirect matrix used a local shim for `vercel.json`, since `astro preview` ignores it --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: benjcooley <benjcooley@gmail.com> Co-authored-by: Deep Mehta <42841935+deepme987@users.noreply.github.com>
|
Superseded by the integration branch #19494, which combined this PR with every other Workshop SEO slice and has been merged to main. Closing this one. |
Summary
Model pages and the catalogue now also build at
/hub/models/<new-slug>/, using the approved table from #19369, and every internal link points there. The old/models/<old-slug>/pages and the 212 alias stubs still build, but their canonical now names the new URL. Redirects come in step B2.Deploy order: comfy-router#46 first, then this PR, then #19422 (B2) and #19424 (B3). This PR must not reach production before comfy-router#46 is live. It moves the nav, the homepage CTAs, llms.txt, the
/models/canonical and the sitemap to/hub/models/, and until the router ships, comfy.org still sends/hub/modelsto /workflows. Router first is harmless.Stacked on #19386; also merges #19369, so merge that first. Part of FE-2972 (step B1 of 2): https://linear.app/comfyorg/issue/FE-2972
Changes
/hub/modelsand/hub/models/[slug].[slug].astrousesroutePatternto decide whether to build the new pages or the old/modelspages, alias stubs and workflow pages./hub/modelsis the hub and each new slug is a model page./models, the 148 old slugs and the 212 aliases are registered asaliaspointing at their new page. They're still built for now, but their canonical already names the new URL and B2 turns them into redirects (307 first, 308 after router Zoom in/out broken after litegraph change #46, FE-3083). Because alias entries stay out of the sitemap, only/hub/models/is listed there.BaseLayouttakes an optionalcanonicalPath, which sets the canonical, og:url, twin link and JSON-LD url. The old model pages and/modelspass the new URL. The alias stubs already refresh straight to the new URL, because they followmodel.href.hub-models.ts): cards, the A-to-Z list, related models,routes.workshop(/hub/models/, used by tags, nav and back links), the platform gallery cards, the/hub/models.mdtwin and llms.txt.hubModelHrefthrows for a slug with no built page, so a disabled model gets no link rather than a 404 address./models/<old id>/page.jsonand/models/catalogue.json. A test inredirects.test.tsfails if any redirect source matches those paths, so B2's redirects can't break hydration.list:models-pages), not justdist/models, so it keeps covering/hub/models(and/hub/workflowsafter B3).provider--model--taskids (analytics, onboardingmodel=, drafts) andnoindexare unchanged.Review Focus
aliaswhile their pages still build was the simplest honest option: every entry of that kind already names the page it hands off to, and B2 only swaps the page for a redirect.