Skip to content

feat(website): render each model page in the static HTML - #18899

Closed
MaanilVerma wants to merge 10 commits into
maanil/fe-2935-content-not-flag-gatedfrom
maanil/fe-2942-model-page-ssr
Closed

MaanilVerma wants to merge 10 commits into
maanil/fe-2935-content-not-flag-gatedfrom
maanil/fe-2942-model-page-ssr

Conversation

@MaanilVerma

@MaanilVerma MaanilVerma commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Every /models/<slug>/ page now ships the model itself in the raw HTML: one h1 with the model name, the summary, provider, price when we have one, and real links to the related models. Crawlers and AI fetchers that don't run JavaScript stop seeing a loader and the Grok Imagine showcase.

Part of FE-2942 (https://linear.app/comfyorg/issue/FE-2942/build-each-model-page-as-real-html-that-search-engines-and-ai-can-read). This is PR 1 of 2; PR 2 (the definition sentence and the facts list with the Router id) is FE-3086 (https://linear.app/comfyorg/issue/FE-3086).

Stacked on #18891 (FE-2935). The base moves to main once that merges.

Changes

  • [slug].astro hydrates ModelPage directly as the page's one island, with the build-time page data as props, so the hero, playground, examples and related models all server-render at their final size. There's no page.json fetch and no loader on model pages anymore.
  • The Grok showcase fallback and its <noscript> copy now only apply to workflow pages (/models/workflows/*), which are still behind their own flag and unchanged here.
  • ModelPage drops SplitReveal from the h1 so the name is a plain text node, and the related-models h2 is one text node (relatedHeading) instead of two responsive spans. relatedHeadingShort and its string are gone.
  • ModelDetail's Run area stays pending until mount whatever the flag says, so the server HTML and the first client render always match and a cached flag answer no longer causes a hydration mismatch. After mount it follows fix(website): show models content whatever the workshop flag says #18891's flag logic.
  • The extra tag popover is no longer flag-gated, since FE-2914 made content public.
  • New check:models-html step in the website build workflow reads every built model page and fails on a missing or wrong h1, any Grok showcase, Grok Imagine outside the related section on non-Grok pages, or a loader in place of the content.
  • E2E specs that type or click into the playground now open the page with openModelPage, which waits for the island to hydrate, because input before hydration is lost now that the playground is server-rendered.

Changed from the ticket:

  • The hero stays in ModelPage.vue rather than moving to a new ModelHero.astro. Hydrating the existing component with props gives the same HTML with no duplicated markup; trimming its JS is FE-2948.
  • form is rebuilt in the island with formForContract instead of exporting the zod schema. Same result, one line.
  • ModelsPage's model branch and page.json are now unused by model pages but left in place (the ticket defers that cleanup, and ModelsPage is shared with the catalogue work in FE-2950).

QA

  • check:models-html passes on all 148 model pages, and fails on the base branch
  • Unit tests for the audit rules, plus an SSR test that the Run area renders the same with the flag on and off
  • Full website unit suite and full e2e suite pass locally
  • JS-off e2e: h1, summary, price and a related link are visible with no loader
  • CLS on three model pages, flag on and off, desktop and mobile, is no worse than the base branch
  • No hydration mismatch in the console with the flag on or off
  • noindex is still on every model page and the 212 alias slugs still redirect
  • WORKSHOP_IN_BUILD=0 build still succeeds
  • Preview: curl as Googlebot and GPTBot returns the model name as the only h1
  • Not covered: workflow pages under /models/workflows/, which keep today's behaviour

The model page now hydrates ModelPage directly with its build-time data
instead of fetching page.json behind a loader, so the raw HTML carries
one h1 with the model name, the summary, provider, price and related
model links. The Grok showcase fallback and noscript copy only remain on
workflow pages.

The Run area renders the same markup before mount whatever the flag
says, so a cached flag answer no longer causes a hydration mismatch.
Model pages now server-render the playground, so tests that type or click
into it wait for the island to hydrate first.
@MaanilVerma MaanilVerma added the cursor-review Trigger multi-model Cursor agent review on this PR label Sep 25, 2026
@MaanilVerma MaanilVerma self-assigned this Sep 25, 2026
@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 67c730c9-f6eb-4137-b640-61611677b220

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@MaanilVerma

MaanilVerma commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator Author

QA

Local production builds of this branch and of the base (#18891, a2ab4c0083). The e2e and CLS runs used the CI e2e build env (WORKSHOP_IN_BUILD=1 PUBLIC_WORKSHOP_ROUTER_RUN=1 PUBLIC_WORKSHOP_CLOUD_ENV=test) served by astro preview.

# Check Proof Result
1 Raw HTML of every model page has exactly one h1 equal to the model name, no Grok showcase, no loader pnpm check:models-html on this branch: [models-html] 148 model pages carry their model in the HTML. On the base build: exit 1, [models-html] 444 problem(s) (148 pages x no h1, Grok showcase, loader), e.g. /models/beeble--switchx-image-edit--edit-images/: expected one h1 "Beeble SwitchX Image Edit", found [] pass
2 Ticket's curl recipe over all built model pages (strip template/noscript/script/style) Before: pages 148 h1==name 0, grok_all>0 148, loading>0 148, with related links 0. After: h1==name 148, grok_all>0 0, grok outside related on non-Grok pages 0, loading>0 0, with related links 148. FLUX sample after: h1: ['FLUX 2 Max Text-to-Image'] h2: ['Try an example', 'More from Black Forest Labs'] grok_all: 0 loading: 0 related_links: 4 pass
3 Summary, provider, price (when known) and every related href are in the raw HTML Script comparing each page's page.json to its index.html (props attribute stripped): router pages 148 problems 0. 38 pages have a price and all 38 show it (FLUX: 14.8 credits/Run) pass
4 JS off New e2e without JavaScript > a model page shows the model and its related models: h1 FLUX 2 Max Text-to-Image, summary, model-price contains credits, related link href=/models/bfl--flux-2-pro--generate-images/, no workshop-loading pass
5 No layout jump on hydrate (CLS, 6 s after load, Playwright PerformanceObserver) FLUX / Luma Photon Flash / Seedance, desktop: flag on 0.0061 / 0.0049 / 0.0061 (base 0.0061 / 0.0061 / 0.0061, the shift is the header nav CTA), flag off 0 / 0 / 0 (base 0). Mobile Pixel 5: 0 everywhere, both branches pass
6 No hydration mismatch (re-run after merging the latest #18891, where the Run area is pending until mount) Console with the flag on and off on the FLUX page: no Hydration completed but contains mismatches. Before the gate fix a flag-on visit logged Hydration node mismatch ... expected on client: button (server rendered the rollout note) (found with __VUE_PROD_HYDRATION_MISMATCH_DETAILS__). ModelDetail.ssr.test.ts new case fails without the fix, passes with it pass
7 Flag behaviour from #18891 still holds workshop-visibility.spec.ts (PostHog unavailable, flag off: h1 visible, run-rollout-note visible, no run-button) and workshop-loading-flash.spec.ts (flag on resolves to the playground, flag off shows the rollout note) pass pass
8 Full e2e suite playwright test desktop + mobile: 564 passed; after merging the latest #18891, 563 passed and 1 unrelated homepage nav hover test (navigation.spec.ts, flaky on repeat, no model page involved). Before adding openModelPage 10 tests failed from typing or clicking before hydration; all pass on the base, and all pass here now pass
9 Unit tests vitest run in apps/website: 451 files, 8971 passed, 4 skipped pass
10 noindex and aliases unchanged 148/148 model pages have <meta name="robots" content="noindex, nofollow">; 212 alias pages still meta-refresh pass
11 Other build validators validate:jsonld, check:hreflang, validate:llms-txt-links exit 0 pass
12 WORKSHOP_IN_BUILD=0 Build exits 0; dist/models/ has only index.html (the showcase), no dist/workshop pass
13 Gates pnpm typecheck (website) 0 errors, eslint + oxlint + oxfmt + prettier on touched files clean, pnpm knip exit 0 pass
14 Workflow pages (/models/workflows/*, 30 pages) Unchanged: still ModelsPage behind the workflows flag with the showcase fallback not in scope
15 Preview deploy, ticket's curl recipe as Googlebot and GPTBot HOST=https://comfy-website-preview-pr-18899.vercel.app, FLUX and Seedance pages, both UAs: h1: ['FLUX 2 Max Text-to-Image'] grok_all: 0 grok_live: 0 loading_live: 0 and h1: ['Seedance 2.5 Text-to-Video'] grok_all: 0 grok_live: 0 loading_live: 0, identical per UA (prod today: h1: [] grok_all: 2 loading_live: 1) pass
16 CI Website Build runs check:models-html: [models-html] 148 model pages carry their model in the HTML. All 102 checks pass pass
17 Ben review follow-up: no input before hydration (thread, fix 010c86d85d, head a6024e4bf2) New e2e the server-rendered prompt takes no input until the island hydrates holds the ModelPage chunk: prompt disabled, typed text refused, enabled after hydration. Without the fix: toBeDisabled() failed, Received: enabled; with it: 1 passed. SSR unit: server prompt <textarea> has disabled (red without the fix). CLS for FLUX, Seedance and the no-sample Bria page, desktop and Pixel 5, flag on and off: 0, no hydration console errors. openModelPage removed; full e2e 565 passed before the last #18891 merge, and after it the only failures are 5 mobile nav/workflow tests that fail the same way on #18891's head 393384cfb8 pass

Raw HTML size of model pages goes from about 76 KB to 113 KB median (167 KB max) because the island's props now carry the page data that page.json used to fetch.

Update 2026-09-30 (body only, no code change): this PR builds PR 1 of FE-2942 only (no definition sentence, no facts <dl>; routerId is used only to pick the island branch in [slug].astro). Body now says "Part of FE-2942" so merging doesn't close the ticket, and PR 2 is tracked as FE-3086. Head unchanged at 426f156357.

…gated' into maanil/fe-2942-model-page-ssr

# Conflicts:
#	apps/website/src/components/workshop/ModelDetail.vue
@vercel

vercel Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 25, 2026 7:06pm UTC
billing-web-test Skipped Skipped Sep 25, 2026 7:06pm UTC

Request Review

@vercel
vercel Bot temporarily deployed to Preview – billing-web-test September 25, 2026 19:05 Inactive
@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🎭 Playwright: ✅ 2160 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 2139 / ❌ 0 / ⚠️ 0 / ⏭️ 9)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (23 changed files).

Kind Finding Where Usual remedy
Complexity <template>() — cyclomatic 49, CRAP undefined apps/website/src/components/workshop/ModelDetail.vue:872 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.
Complexity gate() — cyclomatic 16, CRAP 71.3 apps/website/src/components/workshop/ModelDetail.vue:304 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.

Pre-existing findings are baselined in .fallow-baselines/ and are not your
responsibility — see ADR-DEVEX-LINT-0015.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 90bb942059e3ef05308bb05f21d085c40061ca7c

Full docs: ADR-DEVEX-LINT-0015

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-18899.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-ehea40qwx-comfyui.vercel.app

Last updated: 2026-09-29T18:02:41Z for 426f156

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.4 MB heap
canvas-mouse-sweep: · 59.7 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.9 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.5 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 92.6 MB heap
dom-widget-order-dense-n200-w200-i120: · 29.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 517ms TBT · 82.5 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 41.0 avg FPS · 40.0 P5 FPS ❌ (target: ≥52) · 195ms TBT · 86.1 MB heap
extension-clean-combined-draw: · 31.6 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 584ms TBT · 90.3 MB heap
extension-rgthree-prototype-draw: · 31.3 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 573ms TBT · 76.1 MB heap
large-graph-idle: · 59.8 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.1 MB heap
large-graph-pan: · 59.8 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.4 MB heap
large-graph-zoom: · 59.9 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.0 MB heap
legacy-node-drag: · 59.7 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.4 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 89.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.9 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.6 MB heap
subgraph-transition-enter: · 52.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 124ms TBT · 97.4 MB heap
viewport-pan-sweep: · 59.9 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.4 MB heap
vue-large-graph-idle: · 34.5 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 168.0 MB heap
vue-large-graph-pan: · 27.9 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 20ms TBT · 164.5 MB heap
vue-node-resize-workload: · 29.0 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 289ms TBT · 191.3 MB heap
vue-zoom-out-idle: · 34.3 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 173.4 MB heap
workflow-execution: · 52.9 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 76.3 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.7 MB heap
agent-composer-long-conversation-typing: · 57.2 avg FPS · 40.1 P5 FPS ❌ (target: ≥52) · 0ms TBT · 117.7 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 5ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 436ms
canvas-idle: script duration 12ms
canvas-idle: TBT 0ms
canvas-idle: heap used 57.4 MB
canvas-idle: DOM nodes -228
canvas-idle: event listeners -142
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 18ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 75
canvas-mouse-sweep: task duration 864ms
canvas-mouse-sweep: script duration 154ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 72.9 MB
canvas-mouse-sweep: DOM nodes -228
canvas-mouse-sweep: event listeners -164
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 11ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 348ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 76.5 MB
canvas-zoom-sweep: DOM nodes 53
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 4ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 440ms
dom-widget-clipping: script duration 166ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 92.6 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 34ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 777ms
dom-widget-order-dense-n200-w200-i120: script duration 61ms
dom-widget-order-dense-n200-w200-i120: TBT 517ms
dom-widget-order-dense-n200-w200-i120: heap used 82.5 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes 0
dom-widget-order-dense-n200-w200-i120: event listeners 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time 24ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 25ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 445ms
dom-widget-order-sparse-n1000-w20-i120: script duration 146ms
dom-widget-order-sparse-n1000-w20-i120: TBT 195ms
dom-widget-order-sparse-n1000-w20-i120: heap used 86.1 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 32ms
extension-clean-combined-draw: p95 frame time 50ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 8919ms
extension-clean-combined-draw: script duration 7129ms
extension-clean-combined-draw: TBT 584ms
extension-clean-combined-draw: heap used 90.3 MB
extension-clean-combined-draw: DOM nodes 0
extension-clean-combined-draw: event listeners 0
extension-rgthree-prototype-draw: avg frame time 32ms
extension-rgthree-prototype-draw: p95 frame time 50ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 0
extension-rgthree-prototype-draw: task duration 8808ms
extension-rgthree-prototype-draw: script duration 7034ms
extension-rgthree-prototype-draw: TBT 573ms
extension-rgthree-prototype-draw: heap used 76.1 MB
extension-rgthree-prototype-draw: DOM nodes 0
extension-rgthree-prototype-draw: event listeners 0
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 577ms
large-graph-idle: script duration 33ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 79.1 MB
large-graph-idle: DOM nodes -228
large-graph-idle: event listeners -164
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1656ms
large-graph-pan: script duration 813ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 83.4 MB
large-graph-pan: DOM nodes -228
large-graph-pan: event listeners -164
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 14ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 63
large-graph-zoom: task duration 1738ms
large-graph-zoom: script duration 773ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 70.0 MB
large-graph-zoom: DOM nodes -114
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 44
legacy-node-drag: task duration 1957ms
legacy-node-drag: script duration 969ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 85.4 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 553ms
minimap-idle: script duration 32ms
minimap-idle: TBT 0ms
minimap-idle: heap used 79.9 MB
minimap-idle: DOM nodes -116
minimap-idle: event listeners -71
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 6ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 410ms
subgraph-dom-widget-clipping: script duration 143ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 89.4 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 4ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 464ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 59.9 MB
subgraph-idle: DOM nodes -244
subgraph-idle: event listeners -199
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 19ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 817ms
subgraph-mouse-sweep: script duration 105ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 66.6 MB
subgraph-mouse-sweep: DOM nodes -244
subgraph-mouse-sweep: event listeners -199
subgraph-transition-enter: avg frame time 19ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 11ms
subgraph-transition-enter: style recalc duration 26ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 928ms
subgraph-transition-enter: script duration 32ms
subgraph-transition-enter: TBT 124ms
subgraph-transition-enter: heap used 97.4 MB
subgraph-transition-enter: DOM nodes 13667
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 33ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 5947ms
viewport-pan-sweep: script duration 2719ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 79.4 MB
viewport-pan-sweep: DOM nodes -228
viewport-pan-sweep: event listeners -142
vue-large-graph-idle: avg frame time 29ms
vue-large-graph-idle: p95 frame time 50ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 14933ms
vue-large-graph-idle: script duration 239ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 168.0 MB
vue-large-graph-idle: DOM nodes -5547
vue-large-graph-idle: event listeners -7458
vue-large-graph-pan: avg frame time 36ms
vue-large-graph-pan: p95 frame time 67ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 16ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 131
vue-large-graph-pan: task duration 18178ms
vue-large-graph-pan: script duration 862ms
vue-large-graph-pan: TBT 20ms
vue-large-graph-pan: heap used 164.5 MB
vue-large-graph-pan: DOM nodes -3046
vue-large-graph-pan: event listeners -14915
vue-node-resize-workload: avg frame time 34ms
vue-node-resize-workload: p95 frame time 67ms
vue-node-resize-workload: layout duration 25ms
vue-node-resize-workload: style recalc duration 76ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5489ms
vue-node-resize-workload: script duration 98ms
vue-node-resize-workload: TBT 289ms
vue-node-resize-workload: heap used 191.3 MB
vue-node-resize-workload: DOM nodes -4025
vue-node-resize-workload: event listeners -7462
vue-zoom-out-idle: avg frame time 29ms
vue-zoom-out-idle: p95 frame time 50ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7598ms
vue-zoom-out-idle: script duration 134ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 173.4 MB
vue-zoom-out-idle: DOM nodes -1523
vue-zoom-out-idle: event listeners -7458
workflow-execution: avg frame time 19ms
workflow-execution: p95 frame time 33ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 13ms
workflow-execution: layout count 3
workflow-execution: style recalc count 9
workflow-execution: task duration 122ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 76.3 MB
workflow-execution: DOM nodes 106
workflow-execution: event listeners 25
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 23ms
agent-composer-empty-conversation-typing: style recalc duration 106ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 78
agent-composer-empty-conversation-typing: task duration 822ms
agent-composer-empty-conversation-typing: script duration 315ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 76.7 MB
agent-composer-empty-conversation-typing: DOM nodes 76
agent-composer-empty-conversation-typing: event listeners 876
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 25ms
agent-composer-long-conversation-typing: layout duration 25ms
agent-composer-long-conversation-typing: style recalc duration 247ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 78
agent-composer-long-conversation-typing: task duration 1394ms
agent-composer-long-conversation-typing: script duration 437ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 117.7 MB
agent-composer-long-conversation-typing: DOM nodes -3935
agent-composer-long-conversation-typing: event listeners -175
Raw data
{
  "timestamp": "2026-09-29T18:18:37.308Z",
  "gitSha": "c6ce73bfb139357745436714b528631d47c86545",
  "branch": "maanil/fe-2942-model-page-ssr",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2022.8309999999965,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 4.465,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 487.30100000000004,
      "heapDeltaBytes": -14809636,
      "heapUsedBytes": 63890324,
      "domNodes": -228,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 10.666000000000002,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2017.105000000015,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 4.720999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 384.787,
      "heapDeltaBytes": -42288828,
      "heapUsedBytes": 56402136,
      "domNodes": -228,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 12.485999999999997,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1842.7189999999882,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 17.702,
      "layouts": 12,
      "layoutDurationMs": 4.57,
      "taskDurationMs": 838.194,
      "heapDeltaBytes": -21894808,
      "heapUsedBytes": 76749620,
      "domNodes": -228,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 152.516,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.818348623853208,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1868.9540000000306,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 17.757,
      "layouts": 12,
      "layoutDurationMs": 5.022,
      "taskDurationMs": 889.319,
      "heapDeltaBytes": -2637724,
      "heapUsedBytes": 76228908,
      "domNodes": -228,
      "jsHeapTotalBytes": 1310720,
      "scriptDurationMs": 156.022,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666964285714283,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1733.0519999999865,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 10.806000000000001,
      "layouts": 6,
      "layoutDurationMs": 1.324,
      "taskDurationMs": 341.7,
      "heapDeltaBytes": 1516224,
      "heapUsedBytes": 80330028,
      "domNodes": 53,
      "jsHeapTotalBytes": 3407872,
      "scriptDurationMs": 10.954999999999997,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665384615384614,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1731.6459999999552,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 11.225999999999999,
      "layouts": 6,
      "layoutDurationMs": 1.2850000000000001,
      "taskDurationMs": 354.924,
      "heapDeltaBytes": 1516556,
      "heapUsedBytes": 80176184,
      "domNodes": 53,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 12.725,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846156,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 710.1840000000266,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 4.026,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 463.95899999999995,
      "heapDeltaBytes": 18296524,
      "heapUsedBytes": 97188904,
      "domNodes": 0,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 166.944,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 642.0170000000098,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 4.27,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 416.871,
      "heapDeltaBytes": 18340980,
      "heapUsedBytes": 96989172,
      "domNodes": 0,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 165.596,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665789473684214,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1133.9380000000006,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 759.4259999999999,
      "heapDeltaBytes": 9076232,
      "heapUsedBytes": 86419628,
      "domNodes": 0,
      "jsHeapTotalBytes": 3047424,
      "scriptDurationMs": 61.120999999999995,
      "eventListeners": 0,
      "totalBlockingTimeMs": 524,
      "frameDurationMs": 34.339393939393936,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1143.9560000000029,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 794.9,
      "heapDeltaBytes": 9573844,
      "heapUsedBytes": 86636744,
      "domNodes": 0,
      "jsHeapTotalBytes": 3833856,
      "scriptDurationMs": 60.690000000000005,
      "eventListeners": 0,
      "totalBlockingTimeMs": 510,
      "frameDurationMs": 33.8235294117647,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 846.5849999999477,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 449.80699999999985,
      "heapDeltaBytes": 13637476,
      "heapUsedBytes": 91591056,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 147.23400000000004,
      "eventListeners": 0,
      "totalBlockingTimeMs": 191,
      "frameDurationMs": 24.285714285714285,
      "p95FrameDurationMs": 33.29999999999927
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 831.0679999999593,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 440.6489999999996,
      "heapDeltaBytes": 15694208,
      "heapUsedBytes": 88996436,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 144.15,
      "eventListeners": 0,
      "totalBlockingTimeMs": 198,
      "frameDurationMs": 24.50882352941177,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 9633.375,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8697.896999999999,
      "heapDeltaBytes": 18145668,
      "heapUsedBytes": 92993632,
      "domNodes": 0,
      "jsHeapTotalBytes": -10223616,
      "scriptDurationMs": 6903.161,
      "eventListeners": 0,
      "totalBlockingTimeMs": 467,
      "frameDurationMs": 31.687171052631584,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 10052.831999999966,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9140.234000000002,
      "heapDeltaBytes": 15783016,
      "heapUsedBytes": 96280036,
      "domNodes": 0,
      "jsHeapTotalBytes": -3145728,
      "scriptDurationMs": 7355.155,
      "eventListeners": 0,
      "totalBlockingTimeMs": 700,
      "frameDurationMs": 31.702208201892745,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 10092.155999999988,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9234.826,
      "heapDeltaBytes": 5100688,
      "heapUsedBytes": 80099464,
      "domNodes": 0,
      "jsHeapTotalBytes": -1310720,
      "scriptDurationMs": 7458.312,
      "eventListeners": 0,
      "totalBlockingTimeMs": 853,
      "frameDurationMs": 32.31698717948718,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 9234.66099999996,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8381.956,
      "heapDeltaBytes": -723504,
      "heapUsedBytes": 79564204,
      "domNodes": 0,
      "jsHeapTotalBytes": -11272192,
      "scriptDurationMs": 6609.612,
      "eventListeners": 0,
      "totalBlockingTimeMs": 293,
      "frameDurationMs": 31.619520547945204,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2055.8670000000347,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.9670000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 582.8209999999999,
      "heapDeltaBytes": -36751148,
      "heapUsedBytes": 83054636,
      "domNodes": -228,
      "jsHeapTotalBytes": 950272,
      "scriptDurationMs": 29.732999999999997,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.80081300813008,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2042.0159999999896,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 2.2779999999999987,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 570.572,
      "heapDeltaBytes": -36897856,
      "heapUsedBytes": 82810708,
      "domNodes": -228,
      "jsHeapTotalBytes": -98304,
      "scriptDurationMs": 35.913000000000004,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2699.147000000039,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 10.143999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1682.088,
      "heapDeltaBytes": -31602480,
      "heapUsedBytes": 88504568,
      "domNodes": -228,
      "jsHeapTotalBytes": 389120,
      "scriptDurationMs": 814.6600000000001,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.770625000000003,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2736.938000000009,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 9.051999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1629.7290000000003,
      "heapDeltaBytes": 23242788,
      "heapUsedBytes": 86443216,
      "domNodes": -228,
      "jsHeapTotalBytes": 487424,
      "scriptDurationMs": 811.0459999999999,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666257668711655,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3742.2070000000076,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 10.866000000000001,
      "layouts": 60,
      "layoutDurationMs": 13.953999999999999,
      "taskDurationMs": 1704.3029999999999,
      "heapDeltaBytes": 8733168,
      "heapUsedBytes": 72685780,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 765.1,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665777777777773,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3898.4420000000455,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 11.399,
      "layouts": 60,
      "layoutDurationMs": 14.938,
      "taskDurationMs": 1770.8539999999998,
      "heapDeltaBytes": 9498408,
      "heapUsedBytes": 74021720,
      "domNodes": -228,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 781.278,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.737339055793996,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3152.2019999999884,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 6.207000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1988.5009999999997,
      "heapDeltaBytes": 26722924,
      "heapUsedBytes": 90908196,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 990.812,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.75508021390374,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3112.2850000000426,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 5.972999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1926.1150000000002,
      "heapDeltaBytes": 24375552,
      "heapUsedBytes": 88266892,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 947.2210000000001,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.755913978494622,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2031.5630000000056,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 2.680999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 560.0619999999999,
      "heapDeltaBytes": -37346520,
      "heapUsedBytes": 83834876,
      "domNodes": -228,
      "jsHeapTotalBytes": -360448,
      "scriptDurationMs": 34.36500000000001,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666942148760327,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2046.167999999966,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 2.179999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 546.0169999999998,
      "heapDeltaBytes": 20992660,
      "heapUsedBytes": 83818772,
      "domNodes": -4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 30.37200000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 648.6279999999738,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 6.486999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 414.028,
      "heapDeltaBytes": 12652564,
      "heapUsedBytes": 93635900,
      "domNodes": 0,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 146.68699999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664102564102556,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 666.9180000000097,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 5.946999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 406.51000000000005,
      "heapDeltaBytes": 12392548,
      "heapUsedBytes": 93745596,
      "domNodes": 0,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 140.22099999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667499999999997,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2047.2350000000006,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.842,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 451.952,
      "heapDeltaBytes": -11653056,
      "heapUsedBytes": 70097528,
      "domNodes": -244,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 10.195999999999996,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536584,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.7300000000241,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 4.316999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 475.22600000000006,
      "heapDeltaBytes": -24980776,
      "heapUsedBytes": 55510848,
      "domNodes": -244,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 9.288999999999998,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666942148760327,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1755.7130000000143,
      "styleRecalcs": 81,
      "styleRecalcDurationMs": 19.439999999999998,
      "layouts": 16,
      "layoutDurationMs": 6.1450000000000005,
      "taskDurationMs": 817.1370000000001,
      "heapDeltaBytes": -16311212,
      "heapUsedBytes": 64343616,
      "domNodes": -244,
      "jsHeapTotalBytes": -786432,
      "scriptDurationMs": 105.004,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66571428571429,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1737.435000000005,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 18.057999999999996,
      "layouts": 16,
      "layoutDurationMs": 6.713,
      "taskDurationMs": 817.1590000000001,
      "heapDeltaBytes": -5602824,
      "heapUsedBytes": 75231432,
      "domNodes": -244,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 105.29299999999999,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66538461538462,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1369.811000000027,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 25.779999999999998,
      "layouts": 5,
      "layoutDurationMs": 10.972,
      "taskDurationMs": 928.121,
      "heapDeltaBytes": 21326832,
      "heapUsedBytes": 102124084,
      "domNodes": 13667,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 31.887,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 124,
      "frameDurationMs": 19.212500000000002,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9044.354999999996,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 32.335,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5926.814,
      "heapDeltaBytes": -35874832,
      "heapUsedBytes": 83073324,
      "domNodes": -228,
      "jsHeapTotalBytes": 94208,
      "scriptDurationMs": 2712.863,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.69667282809612,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9441.81100000003,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 32.830999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5966.421,
      "heapDeltaBytes": -35559724,
      "heapUsedBytes": 83543144,
      "domNodes": -228,
      "jsHeapTotalBytes": -430080,
      "scriptDurationMs": 2725.0840000000003,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.69540636042403,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15181.21400000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14947.042,
      "heapDeltaBytes": -36815272,
      "heapUsedBytes": 161351272,
      "domNodes": -3045,
      "jsHeapTotalBytes": 5734400,
      "scriptDurationMs": 243.32199999999997,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 29.1975,
      "p95FrameDurationMs": 50.099999999998545
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15139.741999999955,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14919.279,
      "heapDeltaBytes": 2294044,
      "heapUsedBytes": 190950156,
      "domNodes": -8049,
      "jsHeapTotalBytes": -4456448,
      "scriptDurationMs": 234.31199999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 28.824380952380956,
      "p95FrameDurationMs": 50.099999999998545
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 18348.336000000018,
      "styleRecalcs": 132,
      "styleRecalcDurationMs": 16.333000000000013,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18225.47,
      "heapDeltaBytes": -55976884,
      "heapUsedBytes": 165897140,
      "domNodes": -3045,
      "jsHeapTotalBytes": 7929856,
      "scriptDurationMs": 865.158,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 16,
      "frameDurationMs": 36.12066929133858,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 18267.295999999988,
      "styleRecalcs": 129,
      "styleRecalcDurationMs": 16.085999999999988,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18129.671000000002,
      "heapDeltaBytes": -45625368,
      "heapUsedBytes": 179081892,
      "domNodes": -3046,
      "jsHeapTotalBytes": 6078464,
      "scriptDurationMs": 858.531,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 23,
      "frameDurationMs": 35.5692607003891,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5545.534999999973,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 77.57199999999997,
      "layouts": 20,
      "layoutDurationMs": 24.461999999999996,
      "taskDurationMs": 5493.021999999999,
      "heapDeltaBytes": 7549068,
      "heapUsedBytes": 207240496,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 103.30700000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 280,
      "frameDurationMs": 33.738414634146345,
      "p95FrameDurationMs": 66.69999999999891
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5505.482000000029,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 75.22099999999998,
      "layouts": 20,
      "layoutDurationMs": 24.857000000000003,
      "taskDurationMs": 5484.817000000001,
      "heapDeltaBytes": 7319100,
      "heapUsedBytes": 193922548,
      "domNodes": -8049,
      "jsHeapTotalBytes": 18612224,
      "scriptDurationMs": 93.65700000000001,
      "eventListeners": -14923,
      "totalBlockingTimeMs": 297,
      "frameDurationMs": 35.136305732484075,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7699.141000000054,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7584.651000000001,
      "heapDeltaBytes": -4152532,
      "heapUsedBytes": 188925140,
      "domNodes": -3045,
      "jsHeapTotalBytes": 10842112,
      "scriptDurationMs": 126.03199999999998,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 28.99283018867924,
      "p95FrameDurationMs": 50.10000000000218
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7720.248999999967,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7610.873999999999,
      "heapDeltaBytes": 14510300,
      "heapUsedBytes": 174704632,
      "domNodes": 0,
      "jsHeapTotalBytes": -20447232,
      "scriptDurationMs": 141.899,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 29.339923954372615,
      "p95FrameDurationMs": 50.099999999998545
    },
    {
      "name": "workflow-execution",
      "durationMs": 135.03100000002632,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 12.107,
      "layouts": 3,
      "layoutDurationMs": 2.189,
      "taskDurationMs": 107.119,
      "heapDeltaBytes": -16807976,
      "heapUsedBytes": 80273060,
      "domNodes": 117,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 9.289999999999997,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 19.057142857142935,
      "p95FrameDurationMs": 33.30000000000018
    },
    {
      "name": "workflow-execution",
      "durationMs": 153.74399999996058,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 14.516,
      "layouts": 3,
      "layoutDurationMs": 1.3409999999999997,
      "taskDurationMs": 136.265,
      "heapDeltaBytes": -16669816,
      "heapUsedBytes": 79671672,
      "domNodes": 94,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 7.258999999999998,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.737500000000068,
      "p95FrameDurationMs": 33.30000000000018
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 929.2720000000827,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 108.07700000000001,
      "layouts": 76,
      "layoutDurationMs": 25.04,
      "taskDurationMs": 899.188,
      "heapDeltaBytes": 17663688,
      "heapUsedBytes": 87601188,
      "domNodes": 76,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 349.40500000000003,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664285714285693,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 782.942999999932,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 102.924,
      "layouts": 76,
      "layoutDurationMs": 21.544,
      "taskDurationMs": 745.24,
      "heapDeltaBytes": -15252512,
      "heapUsedBytes": 73318132,
      "domNodes": 76,
      "jsHeapTotalBytes": 8126464,
      "scriptDurationMs": 281.101,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665957446808516,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1434.705000000008,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 239.87900000000002,
      "layouts": 76,
      "layoutDurationMs": 23.816,
      "taskDurationMs": 1424.712,
      "heapDeltaBytes": -14165912,
      "heapUsedBytes": 109014420,
      "domNodes": -7945,
      "jsHeapTotalBytes": -3973120,
      "scriptDurationMs": 430.99699999999996,
      "eventListeners": -1226,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.28271604938271,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1383.136000000036,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 253.31900000000002,
      "layouts": 76,
      "layoutDurationMs": 25.493,
      "taskDurationMs": 1363.5220000000002,
      "heapDeltaBytes": 14167780,
      "heapUsedBytes": 137785752,
      "domNodes": 76,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 443.024,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.707500000000003,
      "p95FrameDurationMs": 33.20000000000073
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 52956 80654 65.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1151
src/LGraphNode.ts 70.3% 388
src/platform/workspace/stores/billingOperationStore.ts 8.0% 345
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.5% 344
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/LGraph.ts 79.2% 267
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/core/billing/operationLifecycle.ts 1.2% 252
src/scripts/app.ts 73.2% 252
src/core/webSessionIdentity.ts 3.4% 224

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

@codecov

codecov Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
apps/website/src/components/workshop/ModelPage.vue 50.00% 0 Missing and 1 partial ⚠️
@@                            Coverage Diff                            @@
##           maanil/fe-2935-content-not-flag-gated   #18899      +/-   ##
=========================================================================
- Coverage                                  84.14%   84.14%   -0.01%     
=========================================================================
  Files                                       3188     3188              
  Lines                                     155118   155105      -13     
  Branches                                   41990    42475     +485     
=========================================================================
- Hits                                      130530   130509      -21     
- Misses                                     22916    22923       +7     
- Partials                                    1672     1673       +1     
Flag Coverage Δ
e2e 65.65% <ø> (+<0.01%) ⬆️
unit 81.41% <ø> (-0.01%) ⬇️
website-unit 78.88% <87.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ps/website/src/components/workshop/ModelDetail.vue 90.60% <100.00%> (+0.04%) ⬆️
apps/website/src/config/models-page-data.ts 90.90% <ø> (ø)
apps/website/src/i18n/translations.ts 100.00% <ø> (ø)
apps/website/src/routes/models/model-page.ts 95.00% <ø> (ø)
apps/website/src/components/workshop/ModelPage.vue 75.86% <50.00%> (-3.45%) ⬇️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 25, 2026
@MaanilVerma MaanilVerma removed their assignment Sep 28, 2026

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One actionable issue found: the newly server-rendered controls accept interaction before hydration, but hydration discards it. Reproduced against the preview with delayed island JavaScript.

Severity Count
TRIVIAL 0
SHOULD FIX 1
BLOCKER 0

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved: no blockers found.

Severity Count
TRIVIAL 0
SHOULD FIX 1
BLOCKER 0

# Conflicts:
#	apps/website/src/components/workshop/ModelPage.vue
#	apps/website/src/routes/models/[slug].astro
The model page now arrives server-rendered, and anything typed into it
before the island hydrated was reset by hydration. The form and the
native-JSON toggle stay disabled until mount, the Run area waits on a
neutral label, and the output panel only depends on the flag after mount
so the server HTML and the first client render always match.
…lPage

Fills now wait on the enabled state the page itself exposes, and the few
tests that open a disclosure or tab first wait for the island to hydrate.
# Conflicts:
#	apps/website/src/components/workshop/ModelDetail.vue
…gated' into maanil/fe-2942-model-page-ssr

# Conflicts:
#	apps/website/src/components/workshop/ModelDetail.test.ts

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scoped re-review of commits after 20103e2e. The pre-hydration input-loss issue is fixed: controls remain disabled until hydration, the regression is covered at SSR and browser levels, and I reproduced the corrected behavior on the refreshed preview. The prior thread is resolved.

Severity Count
TRIVIAL 0
SHOULD FIX 0
BLOCKER 0

…gated' into maanil/fe-2942-model-page-ssr

# Conflicts:
#	apps/website/src/components/workshop/ModelDetail.test.ts

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scoped re-review of the sole new commit after c8e4ad1: a base-branch merge with one conflict in ModelDetail.test.ts. The resolution preserves the async mount required by the hydration fix while adapting the tests to the new account/balance lifecycle. I re-ran the delayed-hydration reproduction against the refreshed 426f156 preview; pre-hydration input remains disabled, post-hydration input persists, and no console errors appeared. The prior thread remains resolved.

Severity Count
TRIVIAL 0
SHOULD FIX 0
BLOCKER 0

pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 30, 2026
## Summary

**Deploy gate: comfy-router#46 is merged and live (2026-09-30). Its
follow-up comfy-router#48 (serves `/hub/models.md` instead of 301ing it
to a /workflows 404) must be deployed before this merges. After the
merge, purge Cloudflare for `/hub/models*`, `/hub/workflows*` and the 30
workflow names in `hub-workflow-names.json`. The redirects ship as 307;
FE-3083 flips them to 308 later.**

This branch combines every Workshop /models SEO PR, so merging it to
main replaces merging them one by one. It also launches: Comfy-Org#19405 commits
`launchedModelPages = 'all'`, so all 148 model pages become indexable in
the same deploy as the URL move.

Part of FE-2912, FE-2942 (PR 2 is FE-3086), FE-2974 (/minimax 308 is
FE-3087)
Fixes FE-2978, FE-2989, FE-2991, FE-2990, FE-2959, FE-2981, FE-2977,
FE-2979, FE-3014, FE-2936, FE-2980, FE-2975, FE-3085, FE-2972, FE-2935,
FE-2950, FE-2940, FE-2930, FE-2985, FE-2957, FE-2961, FE-2986, FE-2921,
FE-2922, FE-2947

## Changes

Router follow-up: comfy-router#48 (`/hub/models.md` routing, 324/324
router tests), deploy before this merges.


The included PRs, in merge order. Every head was checked as contained at
the final tip.

| PR | Ticket | What | Ben |
|---|---|---|---|
| Comfy-Org#18887 | FE-2978 | Pricing Product markup and full video `uploadDate`
| approved |
| Comfy-Org#18889 | FE-2989 | A unique meta description on every model page |
approved |
| Comfy-Org#18890 | FE-2991 | Model page JSON-LD, emitted once noindex lifts |
approved |
| Comfy-Org#18892 | FE-2990 | Cleaner tag pills, guard against duplicate
summaries | approved |
| Comfy-Org#18893 | FE-2959, 2981, 2977, 2979 | Social tags, hub title,
Organization data. The FE-2977 title was confirmed by the owner |
approved |
| Comfy-Org#19362 | FE-3014 | Every non-production build is noindex | approved |
| Comfy-Org#19366 | FE-2936 | Model titles lead with "API & Playground" |
approved |
| Comfy-Org#19402 | FE-2980 | Every internal link ends with a slash, plus a CI
check | approved |
| Comfy-Org#19419 | FE-2975 | Footer links the catalogue on every page and locale
| approved |
| Comfy-Org#19476 | FE-3085 | `NOINDEX_ROUTES` decides noindex for
serverless-animation | approved; re-approval pending on a one-line
follow-up (CodeRabbit approved) |
| Comfy-Org#19359 | FE-2974 | One typed redirect list that generates
`vercel.json` | approved |
| Comfy-Org#19369 | FE-2972 A | The old to new model URL map | approved |
| Comfy-Org#18891 | FE-2935 | Model content shows whatever the flag says |
approved |
| Comfy-Org#18899 | FE-2942 | Model pages render in the static HTML | approved |
| Comfy-Org#18898 | FE-2950 | Catalogue h1 and A to Z links in the static HTML |
approved |
| Comfy-Org#19375 | FE-2940 | Related models leave no page unlinked | approved |
| Comfy-Org#19385 | FE-2930 | Examples show the prompt that made them | approved
|
| Comfy-Org#19394 | FE-2985 | Render guard e2e: no loader, no layout shift |
approved |
| Comfy-Org#19357 | FE-2957 | robots.txt stops blocking our scripts and styles |
approved |
| Comfy-Org#19360 | FE-2961 | Turning Workshop off keeps every Models page |
approved (a CodeRabbit changes-requested review is still open) |
| Comfy-Org#19386 | FE-2986 | One registry of every Models address | approved |
| Comfy-Org#19421 | FE-2972 B1 | Model pages served at `/hub/models` | approved |
| Comfy-Org#19422 | FE-2972 B2 | Every old model URL redirects (307) | approved |
| Comfy-Org#19424 | FE-2972 B3 | Workflow pages at `/hub/workflows` with
redirects | approved |
| Comfy-Org#19399 | FE-2921 | One switch decides model robots and sitemap listing
| approved |
| Comfy-Org#19404 | FE-2922 | Clean markdown twins for model pages | approved |
| Comfy-Org#19405 | FE-2947 | Lifts noindex on every canonical model page |
approved |
| comfy-router#46 | FE-3075 | Serves `/hub/models*` from the website and
routes `/hub/workflows` by manifest. Merged and live | merged |

These fixes exist only on this branch, because they only break once two
PRs meet:

- `scripts/check-models-html.ts` reads each page at `model.href` and
skips models without a page (f1df1e4).
- `e2e/fixtures/modelsCatalogue.ts` reads `dist/hub/models`
(f87bb4c).
- `routerIdsByModelPage` accepts an optional `href`, since Comfy-Org#19421 made
it optional and Comfy-Org#19405 no longer typechecked (9783819).
- `ModelStatus` links a successor only when it has a page, for the same
reason on Comfy-Org#18899 (c4761d8).
- The model breadcrumb in `modelJsonLd.ts` points at `/hub/models/`
instead of the `/models/` redirect (eb985b6). Its label still says
"Models" while the nav says "Hub".
- Twin, meta-description and entry tests use the hub pages and the new
tag set (86ac3b0, d4ffc0f).
- The render guard finds the catalogue through `getRoutes().workshop`,
and its `test.fail` is gone now that Comfy-Org#18898 renders the h1 (831499f).
- A new test renders a real model page and checks its markdown twin has
the model's h1 (9a6c5cb).
- Main's newer catalogue and workflow e2e cases use the hub addresses
(2aeda77).
- `resetWorkshopAccountSource` resets `decision`; a clean auto-merge of
main's Comfy-Org#19454 into Comfy-Org#18891 left it assigning a variable that no longer
exists (c28c7a7).

The conflict resolutions, briefly: `ALTERNATE_TWIN_SOURCES` stays
deleted as Comfy-Org#18898 wants, so `/hub/models.md` comes from the real
catalogue. The hub keeps Comfy-Org#18898's single static h1 instead of the
`WorkshopHero` h1 that main's Comfy-Org#19320 added. `ExamplesTab` keeps Comfy-Org#19385's
figure and caption with main's video poster. The Comfy-Org#19399/Comfy-Org#19405 indexing
tests were rewritten for hub paths. The Comfy-Org#19359 redirect test no longer
builds `/enterprise//` from slash-ended routes. The Comfy-Org#19369 URL-map test
imports `PROVIDER_NAMES` from its new home. The full table of 47
resolutions is in the integration report.

## Review Focus

- Launch rides along with the URL move. If launch should stay a separate
step, set `launchedModelPages` in
`apps/website/src/config/model-page-launch.ts` to `new Set()` before
merging.
- Main's Comfy-Org#19320 gives the catalogue island its own h1 through
`WorkshopHero`. This branch keeps Comfy-Org#18898's static h1 and renders only
the subtitle in `ModelsCatalogue.vue`, so the hub has exactly one h1.

- Comfy-Org#19476 overlaps the open community PR Comfy-Org#18591 (same sitemap exclusion
for serverless-animation). One of them should be closed once this lands.

## QA

- [x] Gates: `pnpm typecheck` and website typecheck clean, `pnpm lint` 0
errors, eslint on `apps/website` clean, `pnpm knip` clean
- [x] Website unit: 547 files, 10347 passed, 4 skipped
- [x] Build A (`build:e2e`, CI env): 1193 pages; release gate,
`check:hreflang`, `validate:llms-txt-links` (225 links),
`validate:jsonld` (947 pages), `check:link-slashes`, `check:models-html`
(148 pages) all pass
- [x] Build B (`WORKSHOP_IN_BUILD=0`): same 182 Models pages as the on
build, no `dist/workshop`, `/` is noindex; with the flag stubbed on, no
Run, no Hub nav and no Firebase requests
- [x] Build C (preview shape): 945 of 945 pages noindex, no canonicals
except redirect stubs, no hreflang in the sitemap
- [x] E2E on Build A: 644 of 645 passed; the one mobile failure passed
on rerun. Earlier load flakes (navigation, demos, fdct, wan-3.0, network
isolation, render guard) all passed when rerun alone
- [x] Launch: 148 model pages indexable with canonicals, 149 hub entries
in the sitemap, 148 non-empty twins with the model h1, 148 in
`llms-full.txt`, 0 titles over 60, 30 workflow pages still noindex
- [x] Redirects: 853 rules, 782 to /hub all 307, the MiniMax rows 307,
every /hub destination built
- [x] comfy-router#46 under `wrangler dev` in front of this build: 312
router tests pass; 148 old model URLs (both slash forms) 307 then 200;
30 workflow names served by the website and their old URLs 307; a
non-manifest workflow 302 with no-store; `manifest.json` passes through;
`/workflows/` and bare `/hub` unchanged
- [x] After the router deploys and this merges: purge Cloudflare, then
curl `https://comfy.org/hub/models/` for a 200 and three old
`/models/<slug>/` URLs for one 307 each
- [x] Rich Results Test on `/pricing/` and
`/learning/animations/character-sheet/`, then "Validate fix" on Merchant
listings and Videos
- [x] Rich Results Test on two live model pages: breadcrumbs valid and
the breadcrumb URL returns 200 with no redirect
- [x] GPTBot and Googlebot curls on the hub and one model page, then a
GSC live test on both
- [x] Resubmit the sitemap in Search Console and URL-inspect about 20
model pages on day 0 and day 14
- Not covered: Rich Results and GSC need production; the redirect matrix
used a local shim for `vercel.json`, since `astro preview` ignores it

---------

Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: benjcooley <benjcooley@gmail.com>
Co-authored-by: Deep Mehta <42841935+deepme987@users.noreply.github.com>
@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

Superseded by the integration branch #19494, which combined this PR with every other Workshop SEO slice and has been merged to main. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger multi-model Cursor agent review on this PR risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants