Repository navigation
feat(website): one typed redirect list, generated vercel.json - #19359
MaanilVerma wants to merge 8 commits into
Conversation
Every redirect now lives in src/config/redirects.ts. vercel.json is generated from it (pnpm --filter @comfyorg/website sync:redirects) and Astro's redirect map is derived from it, so the two can no longer disagree. A test fails when vercel.json drifts, a destination is itself a source, a source repeats, or an internal destination lacks its trailing slash. The Astro-only entries and the 12 supported-models alias pages now answer with a real 308 on Vercel instead of a 200 meta-refresh page, and both slash forms of every source redirect.
/minimax/ had 7.6k clicks in the 90 days before it moved to /minimax-h3/. A 307 is not a canonical signal, so that equity never transferred. The redirects test encoded the temporary status on purpose; it now asserts 308.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughA shared redirect list now generates Astro and Vercel rules. The Vercel routes were updated, and model pages and hreflang audits now use the generated Astro redirect map. ChangesWebsite redirects
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant PackageScript as package.json sync:redirects
participant SyncScript as sync-vercel-redirects.ts
participant RedirectConfig as redirects.ts
participant VercelConfig as vercel.json
PackageScript->>SyncScript: Run redirect synchronization
SyncScript->>RedirectConfig: Generate rules from siteRedirects
SyncScript->>VercelConfig: Replace redirects and preserve other properties
Suggested reviewers: Merge Risk: ⚪ Minimal · up to The redirect catalog and its Vercel and Astro integrations show no established current user-facing failure, so no merge-blocking risk is apparent. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The new redirects affect public URLs, including sign-in-adjacent and off-site routes. The reviewed destinations are fixed, and the sensitive redirects remain temporary. No introduced security issue was established, but deployment validation and rollback behavior are not fully evidenced. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
Hardening Proposals
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since a3a4a0b8a692ed738e9ceb5c23da0784739ce7c4
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle: 10 MB gzip 🔴 +346 kBDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.73 kB) • 🔴 +38 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.46 MB (baseline 1.43 MB) • 🔴 +29.7 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 133 kB (baseline 124 kB) • 🔴 +9.54 kBTop-level views, pages, and routed surfaces
Status: 17 added / 16 removed / 1 unchanged Panels & Settings — 643 kB (baseline 621 kB) • 🔴 +21.7 kBConfiguration panels, inspectors, and settings screens
Status: 28 added / 27 removed User & Accounts — 39.4 kB (baseline 27.8 kB) • 🔴 +11.6 kBAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 2 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🔴 +691 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 125 kB (baseline 117 kB) • 🔴 +8.07 kBReusable component library chunks
Status: 16 added / 15 removed Data & Services — 4.06 MB (baseline 3.6 MB) • 🔴 +463 kBStores, services, APIs, and repositories
Status: 15 added / 16 removed Utilities & Hooks — 582 kB (baseline 559 kB) • 🔴 +23.2 kBHelpers, composables, and utility bundles
Status: 31 added / 30 removed / 6 unchanged Vendor & Third-Party — 17.4 MB (baseline 18.1 MB) • 🟢 -684 kBExternal libraries and shared vendor chunks
Status: 12 added / 12 removed / 6 unchanged Other — 17.9 MB (baseline 16.4 MB) • 🔴 +1.54 MBBundles that do not match a named category
Status: 178 added / 174 removed / 122 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-29T20:17:15.104Z",
"gitSha": "df31610c40590bb96e803bde53bbcc20fa4b24e8",
"branch": "maanil/fe-2974-one-redirect-list",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2026.2129999999843,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.796,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.043,
"heapDeltaBytes": -20858112,
"heapUsedBytes": 77785228,
"domNodes": -228,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 11.052999999999997,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2027.8619999999137,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.139999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.8640000000001,
"heapDeltaBytes": -28654480,
"heapUsedBytes": 69919400,
"domNodes": -228,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 9.856,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1860.5699999999956,
"styleRecalcs": 75,
"styleRecalcDurationMs": 19.396,
"layouts": 12,
"layoutDurationMs": 4.543,
"taskDurationMs": 869.228,
"heapDeltaBytes": -32040404,
"heapUsedBytes": 66176036,
"domNodes": -228,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 180.501,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666964285714283,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1850.5820000000313,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.043999999999997,
"layouts": 12,
"layoutDurationMs": 4.633,
"taskDurationMs": 864.755,
"heapDeltaBytes": -37946544,
"heapUsedBytes": 60614468,
"domNodes": -228,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 172.539,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576576576577,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.8029999999949,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.963000000000001,
"layouts": 6,
"layoutDurationMs": 1.09,
"taskDurationMs": 351.27799999999996,
"heapDeltaBytes": -18651648,
"heapUsedBytes": 80121740,
"domNodes": 53,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 14.076000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1757.8439999999773,
"styleRecalcs": 32,
"styleRecalcDurationMs": 12.437,
"layouts": 6,
"layoutDurationMs": 1.638,
"taskDurationMs": 360.14000000000004,
"heapDeltaBytes": -18579612,
"heapUsedBytes": 80053196,
"domNodes": 53,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 13.038000000000004,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 743.8850000000343,
"styleRecalcs": 13,
"styleRecalcDurationMs": 4.555,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.616,
"heapDeltaBytes": -1862508,
"heapUsedBytes": 96585544,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 175.74900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66818181818181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 745.565000000056,
"styleRecalcs": 13,
"styleRecalcDurationMs": 4.055999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.853,
"heapDeltaBytes": -2935592,
"heapUsedBytes": 95419692,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 177.877,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1205.0839999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 853.2570000000001,
"heapDeltaBytes": 9614576,
"heapUsedBytes": 85714256,
"domNodes": 0,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 77.11699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 574,
"frameDurationMs": 35.291176470588226,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1190.725000000043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 847.038,
"heapDeltaBytes": 6643020,
"heapUsedBytes": 82892248,
"domNodes": 0,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 66.856,
"eventListeners": 0,
"totalBlockingTimeMs": 565,
"frameDurationMs": 35.857575757575766,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 880.1510000000121,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.0010000000004,
"heapDeltaBytes": 16685060,
"heapUsedBytes": 90348576,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 179.529,
"eventListeners": 0,
"totalBlockingTimeMs": 242,
"frameDurationMs": 25.979411764705862,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 897.803999999951,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.14800000000014,
"heapDeltaBytes": 15932880,
"heapUsedBytes": 89393440,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 175.055,
"eventListeners": 0,
"totalBlockingTimeMs": 233,
"frameDurationMs": 24.997222222222213,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9954.451000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9085.041000000001,
"heapDeltaBytes": 11890548,
"heapUsedBytes": 92105452,
"domNodes": 0,
"jsHeapTotalBytes": -10485760,
"scriptDurationMs": 7679.188,
"eventListeners": 0,
"totalBlockingTimeMs": 1404,
"frameDurationMs": 35.03380281690141,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10735.148000000096,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9707.571,
"heapDeltaBytes": -9737000,
"heapUsedBytes": 70489344,
"domNodes": 0,
"jsHeapTotalBytes": -13631488,
"scriptDurationMs": 8047.812000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1288,
"frameDurationMs": 31.94315476190476,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11988.832000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10976.913,
"heapDeltaBytes": -7064940,
"heapUsedBytes": 68383848,
"domNodes": 0,
"jsHeapTotalBytes": -3145728,
"scriptDurationMs": 9221.822999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1904,
"frameDurationMs": 35.140469208211144,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10963.84999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9944.935,
"heapDeltaBytes": -10768944,
"heapUsedBytes": 69588420,
"domNodes": 0,
"jsHeapTotalBytes": -13369344,
"scriptDurationMs": 8250.467999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1304,
"frameDurationMs": 32.6375,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2060.4099999999903,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.401999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 599.819,
"heapDeltaBytes": -36814400,
"heapUsedBytes": 82458576,
"domNodes": -228,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 36.219,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2043.431000000055,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.4949999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.408,
"heapDeltaBytes": -36589124,
"heapUsedBytes": 82565808,
"domNodes": -228,
"jsHeapTotalBytes": -98304,
"scriptDurationMs": 33.22,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2538.0569999999807,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.557,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1687.7640000000001,
"heapDeltaBytes": 27586372,
"heapUsedBytes": 91105616,
"domNodes": -228,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 878.804,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77682119205298,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2624.57500000005,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.023000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1715.49,
"heapDeltaBytes": -31397004,
"heapUsedBytes": 88503888,
"domNodes": -228,
"jsHeapTotalBytes": 389120,
"scriptDurationMs": 876.488,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77261146496816,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3714.5270000000323,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.878000000000002,
"layouts": 60,
"layoutDurationMs": 13.786,
"taskDurationMs": 1721.493,
"heapDeltaBytes": 8266048,
"heapUsedBytes": 73624768,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 802.424,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66591928251121,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3696.8540000000303,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.122999999999998,
"layouts": 60,
"layoutDurationMs": 14.024,
"taskDurationMs": 1741.6399999999999,
"heapDeltaBytes": 9456352,
"heapUsedBytes": 73997996,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 806.9040000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666367713004487,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3169.467999999995,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.606,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1909.7,
"heapDeltaBytes": 28502356,
"heapUsedBytes": 93144852,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1076.422,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.842328042328038,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3147.450000000049,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.269,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1928.6580000000001,
"heapDeltaBytes": 22543384,
"heapUsedBytes": 86493528,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 987.653,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84516129032258,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2013.6430000000018,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.6160000000000028,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 523.939,
"heapDeltaBytes": 21358428,
"heapUsedBytes": 84198728,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.75399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2046.6880000000174,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.2639999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.82,
"heapDeltaBytes": -38205452,
"heapUsedBytes": 83243604,
"domNodes": -228,
"jsHeapTotalBytes": 163840,
"scriptDurationMs": 36.389,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 630.1740000000109,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.297,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.64,
"heapDeltaBytes": 12407056,
"heapUsedBytes": 93643196,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 151.12199999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 631.0250000000224,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.326,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.435,
"heapDeltaBytes": 13003488,
"heapUsedBytes": 93996540,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 144.913,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2024.487000000022,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.846999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.78599999999994,
"heapDeltaBytes": -15394844,
"heapUsedBytes": 65006992,
"domNodes": -244,
"jsHeapTotalBytes": -1048576,
"scriptDurationMs": 8.458999999999998,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2031.6460000000234,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.562,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.91700000000003,
"heapDeltaBytes": -23325532,
"heapUsedBytes": 56591028,
"domNodes": -244,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 8.559999999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1760.2509999999825,
"styleRecalcs": 76,
"styleRecalcDurationMs": 22.423,
"layouts": 16,
"layoutDurationMs": 6.548,
"taskDurationMs": 833.5899999999999,
"heapDeltaBytes": -23311468,
"heapUsedBytes": 57611484,
"domNodes": -244,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 117.80300000000003,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66509433962264,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1738.9910000000555,
"styleRecalcs": 61,
"styleRecalcDurationMs": 19.603,
"layouts": 16,
"layoutDurationMs": 6.589,
"taskDurationMs": 817.575,
"heapDeltaBytes": -5167124,
"heapUsedBytes": 75012296,
"domNodes": -244,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 119.43600000000002,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.8470000000889,
"styleRecalcs": 17,
"styleRecalcDurationMs": 30.538999999999998,
"layouts": 5,
"layoutDurationMs": 13.478999999999997,
"taskDurationMs": 940.498,
"heapDeltaBytes": 21474728,
"heapUsedBytes": 92195068,
"domNodes": 13667,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 41.192,
"eventListeners": 2383,
"totalBlockingTimeMs": 138,
"frameDurationMs": 19.143243243243237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9300.71700000002,
"styleRecalcs": 250,
"styleRecalcDurationMs": 34.10000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6209.199,
"heapDeltaBytes": -37075448,
"heapUsedBytes": 82057640,
"domNodes": -228,
"jsHeapTotalBytes": 356352,
"scriptDurationMs": 3004.4900000000002,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.695863309352518,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8871.748000000025,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.912,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6024.8910000000005,
"heapDeltaBytes": -35573896,
"heapUsedBytes": 82993588,
"domNodes": -228,
"jsHeapTotalBytes": -167936,
"scriptDurationMs": 2896.63,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666165413533832,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17487.521000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17029.875,
"heapDeltaBytes": -56493188,
"heapUsedBytes": 196377432,
"domNodes": -8049,
"jsHeapTotalBytes": -24911872,
"scriptDurationMs": 282.586,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.102029520295204,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 17114.97900000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16571.891,
"heapDeltaBytes": -8965896,
"heapUsedBytes": 189117188,
"domNodes": -3045,
"jsHeapTotalBytes": 10895360,
"scriptDurationMs": 278.933,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.051493848857643,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 21111.492999999995,
"styleRecalcs": 165,
"styleRecalcDurationMs": 17.82900000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20831.353,
"heapDeltaBytes": -60800640,
"heapUsedBytes": 168299860,
"domNodes": -3045,
"jsHeapTotalBytes": 2826240,
"scriptDurationMs": 1001.391,
"eventListeners": -14915,
"totalBlockingTimeMs": 78,
"frameDurationMs": 40.92209302325582,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 20563.318999999978,
"styleRecalcs": 146,
"styleRecalcDurationMs": 16.847999999999974,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20341.904,
"heapDeltaBytes": -25850716,
"heapUsedBytes": 168438488,
"domNodes": 0,
"jsHeapTotalBytes": -26738688,
"scriptDurationMs": 870.651,
"eventListeners": 0,
"totalBlockingTimeMs": 23,
"frameDurationMs": 39.7023166023166,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6272.6880000000165,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.25200000000002,
"layouts": 20,
"layoutDurationMs": 23.664999999999992,
"taskDurationMs": 6161.6939999999995,
"heapDeltaBytes": -12775096,
"heapUsedBytes": 212329740,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 116.28200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 485,
"frameDurationMs": 37.978181818181824,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6295.134999999959,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.52300000000001,
"layouts": 20,
"layoutDurationMs": 24.61200000000001,
"taskDurationMs": 6204.517,
"heapDeltaBytes": -12098608,
"heapUsedBytes": 216775480,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 122.14200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 423,
"frameDurationMs": 38.751533742331276,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8728.437999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8574.472,
"heapDeltaBytes": -34945404,
"heapUsedBytes": 198417664,
"domNodes": -3045,
"jsHeapTotalBytes": 6258688,
"scriptDurationMs": 139.86500000000007,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.928205128205132,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8729.916000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8546.300000000003,
"heapDeltaBytes": -28766208,
"heapUsedBytes": 189922520,
"domNodes": -3045,
"jsHeapTotalBytes": 6565888,
"scriptDurationMs": 147.19499999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.755999999999993,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 491.4929999999913,
"styleRecalcs": 20,
"styleRecalcDurationMs": 22.903,
"layouts": 4,
"layoutDurationMs": 1.918,
"taskDurationMs": 163.40900000000002,
"heapDeltaBytes": -14370496,
"heapUsedBytes": 82425884,
"domNodes": 129,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 13.474,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 521.253999999999,
"styleRecalcs": 14,
"styleRecalcDurationMs": 19.012,
"layouts": 4,
"layoutDurationMs": 1.996,
"taskDurationMs": 230.23399999999998,
"heapDeltaBytes": -42033012,
"heapUsedBytes": 55070808,
"domNodes": -141,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 12.115999999999998,
"eventListeners": -52,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.206451612903216,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 937.9610000000866,
"styleRecalcs": 78,
"styleRecalcDurationMs": 110.50699999999999,
"layouts": 76,
"layoutDurationMs": 23.491000000000003,
"taskDurationMs": 897.26,
"heapDeltaBytes": 17806368,
"heapUsedBytes": 87822448,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 366.679,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571417,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 975.5969999999934,
"styleRecalcs": 78,
"styleRecalcDurationMs": 109.534,
"layouts": 76,
"layoutDurationMs": 24.29,
"taskDurationMs": 935.0379999999999,
"heapDeltaBytes": -7271892,
"heapUsedBytes": 85478232,
"domNodes": 76,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 385.49699999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.959649122806997,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1339.3519999999626,
"styleRecalcs": 78,
"styleRecalcDurationMs": 237.952,
"layouts": 76,
"layoutDurationMs": 24.241,
"taskDurationMs": 1326.425,
"heapDeltaBytes": 8409068,
"heapUsedBytes": 120426132,
"domNodes": -7943,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 451.116,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.873749999999994,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1459.3479999999772,
"styleRecalcs": 78,
"styleRecalcDurationMs": 242.291,
"layouts": 76,
"layoutDurationMs": 24.101000000000003,
"taskDurationMs": 1453.2540000000001,
"heapDeltaBytes": -14112812,
"heapUsedBytes": 109065196,
"domNodes": -7945,
"jsHeapTotalBytes": -2662400,
"scriptDurationMs": 462.27199999999993,
"eventListeners": -1226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.25294117647059,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-19359.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-nakg4unv6-comfyui.vercel.app Last updated: 2026-09-29T19:36:49Z for 🌐 Website E2ETip All tests passed.
🎭 Playwright: ✅ 2158 passed, 0 failed · 1 flaky📊 Browser Reports
|
QA for #19359Redirect inventory on main (95932b4)
Built-dist count on main: 240 meta-refresh stubs = 15 Astro map + 12 supported-models aliases + 212 Workshop aliases + 1 cinematic-studio. Checks
1. Red (flipped 2. Green (restored the generated file): 3. All generated rules on the preview (status and 4. Before and after. Probe per path and slash form: Before, After,
5. Destinations are real pages (on the branch build): 6. Build compared with main (
7. e2e (Astro 7 preview daemonises, so run against it with a throwaway config): 8. Gates The 3 failures are unrelated to this diff. Not covered
Update 2026-09-30 (title and body only, no code change): the four |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19359 +/- ##
==========================================
- Coverage 84.16% 84.15% -0.02%
==========================================
Files 3237 3192 -45
Lines 156372 155362 -1010
Branches 42319 40333 -1986
==========================================
- Hits 131614 130748 -866
+ Misses 23003 22930 -73
+ Partials 1755 1684 -71
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 56 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @MaanilVerma.
Found 7 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 1 |
| 🟢 Low | 4 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
- Sources must be plain literal paths, so a generated slug can't smuggle a path-to-regexp pattern into vercel.json. - A row whose slash form is a page stays out of Astro's map, since its stub would overwrite that page. - Both emitters read the marker fields by definedness. - The test derives MiniMax, Enterprise and Pricing paths from routes.ts. - sync:redirects validates vercel.json before rewriting it.
benjcooley
left a comment
There was a problem hiding this comment.
Read the whole redirect path end to end rather than just the diff: traced astroRedirects through astro.config.ts, hreflangAudit.ts, hreflang.test.ts, the sitemap integration and the markdown-twins integration, and executed the PR's redirects.ts against the PR's generated-models.json and vercel.json to confirm the drift test actually passes.
No blockers. The generated vercel.json is internally consistent: 71 rules, no duplicate sources, every source in both slash forms except /login, no destination that is itself a source, every internal destination trailing-slashed, and toVercelRedirects(siteRedirects) is byte-identical to what is committed.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 3 |
| TRIVIAL | 2 |
Things I checked that hold up, so nobody re-does the work:
- Sitemap is genuinely unchanged. Astro only pushes
route.type === 'page'intopages(core/build/generate.js), and@astrojs/sitemapfiltersr.type !== 'page'out ofrouteUrls, so the 12 model aliases moving from[slug].astroto config redirects drops them frompages— exactly whereMODEL_REDIRECT_PATHNAMESwas excluding them before. Same for the new/career,/press,/privacystubs. (Side effect:MODEL_REDIRECT_PATHNAMESinindexing.tsis now dead weight.) - The e2e canonical assertions still hold. Astro's redirect stub template (
core/routing/3xx.js) emits<meta name="robots" content="noindex">plusrel="canonical"resolved againstconfig.site, andconfig.build.redirectsdefaults to true — sodist/p/supported-models/t5xxl-fp8-e4m3fn-scaled/index.htmlis the same shape the oldAstro.redirect()produced. - No dangling alias targets and no chains.
models.tsalready throws on acanonicalSlugthat is missing or self-referential, and all 12 targets are non-alias slugs, so the new one-hop test has nothing to catch today. - Nothing links to bare
/login. Every internal reference goes through/login/. - Vercel matches trailing slashes strictly, which is why the paired forms are needed and why
/loginalone is safe — consistent with the existing config, which already paired/api,/cloud/pricing,/minimaxand/share-news.
One out-of-scope note: src/pages/p/supported-models/index.astro still maps over all 394 models, so it renders cards for the 12 aliases and lists their URLs in the ItemList JSON-LD. [slug].astro, [slug].md.ts and llms.txt.ts now all filter on canonicalSlug; that index page is the last consumer that doesn't. Pre-existing, but this PR makes it the odd one out and it's a one-line .filter((model) => !model.canonicalSlug).
Nice work overall — collapsing two drifting sources of truth into one typed list with a drift test is the right shape, and the temporaryBecause / slashFormIsPageBecause fields carry their justification next to the data instead of in a comment that rots.
benjcooley
left a comment
There was a problem hiding this comment.
Converting my earlier review to request-changes. To be clear about what is and isn't wrong: I found no correctness bug, and I verified the generated vercel.json is exactly what toVercelRedirects(siteRedirects) produces. The shape of this change is right. Two items are gates rather than nits:
1. pnpm generate:models now produces a broken commit. vercel.json is downstream of generated-models.json, and nothing regenerates it. model-page-discovery.yaml instructs contributors to run the generator and commit the result — that documented path now lands red CI. This is a break the PR introduces, and the fix is one line in package.json. Please close it here rather than leaving it for whoever trips over it first.
2. /minimax going 308 needs a human's sign-off, not an inference. A 308 is cached by browsers indefinitely, and /minimax/ is a live namespace root with minimax/license.astro and minimax/license/professional-request.astro under it. The review checklist box is ticked, but that is the author checking their own box — I would like the MiniMax launch-page owner named in a comment confirming /minimax/ won't be reused. If that confirmation is awkward to get, shipping this row as-is (307) and flipping it in a follow-up costs nothing, since the rest of the PR stands on its own.
The third item (a test that a source's slash form can't shadow a built page) I would like but won't hold the PR for. /login is the only collision today and I checked the full set.
Happy to re-review quickly once 1 is fixed and 2 is answered.
- generate:models also syncs vercel.json redirects; discovery workflow names sync:redirects - test that no emitted slash form shadows a built page - keep /minimax temporary (307) until the page owner signs off - assert astroRedirects by count and literal entries - one zod schema validates and produces the written vercel.json
|
@benjcooley on the out-of-scope note: fixed in ab4f655. I kept |
benjcooley
left a comment
There was a problem hiding this comment.
Re-reviewed scoped to 3ceaa417 and ab4f6559 (the merge from main is noise for this feature — the only overlap is indexing.ts, and nothing there touches the alias handling).
Four of my five items are genuinely fixed, not just acknowledged, and I verified each rather than taking the commit message for it:
generate:modelsnow chains the sync script. Separate process, so it reads the freshly-writtengenerated-models.json. The discovery workflow gained both the chained path and the hand-edit path.- The shadow test is real. I reconstructed
builtPagesagainst the head commit —routeOfreturns trailing-slash routes, so the keys line up, and/loginis the only source whose slash form is a built page. Drop itsslashFormIsPageBecauseand the test goes red, which is exactly what I wanted. - The tautological Astro-redirects test now asserts behavior (length plus the 307/308 mapping) instead of re-running the production filter.
index.astrofilters aliases.numberOfItemsis derived from the same array, so the grid and the JSON-LD stay in agreement.
Also re-ran toVercelRedirects(siteRedirects) against the head vercel.json: still byte-identical, 71 rules, 30 Astro entries.
One thing left, and it's one line. /minimax went back to 307 with the reason recorded — good — but /zh-CN/minimax is still flipping to a permanent 308, and the reason you wrote for the English row applies to it verbatim: src/pages/zh-CN/minimax/license.astro exists, so /zh-CN/minimax/ is the same live namespace with the same owner. On main that row is permanent: false today. As it stands the PR backs English out of the irreversible change and leaves Chinese in it.
I'd have approved over a stylistic split, but a 308 can't be walked back once browsers cache it, and that was the whole reason for holding last round — so I'd rather spend one more round than guess that the asymmetry was deliberate. Move the same temporaryBecause onto the /zh-CN/minimax row, rerun pnpm sync:redirects, update the keeps only the listed rows temporary expectation, and this is done.
Two small things while you're in there, neither blocking: the zod → astro/zod import swap in the sync script (details in that thread — I checked, no data loss, just an unnecessary hop), and the PR title/body, which still say "all permanent" and still carry [x] /minimax goes permanent. That text becomes the squash commit message.
Nit I won't hold anything for: builtPages skips content-collection routes (customers/[slug], events/[slug], learning/[slug], demos/[slug], cloud/supported-nodes/[pack]), so a future source colliding with a content slug wouldn't be caught. Enumerating those in a unit test means reaching into astro:content, which isn't worth it — the static tree, the injected routes and the model pages are the cases that actually matter.
benjcooley
left a comment
There was a problem hiding this comment.
Approving. Scoped to 9ad6e90c, which is exactly the one-line fix I asked for plus its test updates.
Verified against the head commit rather than reading the diff:
- All four MiniMax rows are
permanent: false, andastroRedirects['/zh-CN/minimax']is{ status: 307 }. Net effect on MiniMax versusmainis now zero, which is the right resting place until the owner signs off. toVercelRedirects(siteRedirects)is still byte-identical tovercel.json— 71 rules, 30 Astro entries, and18 + aliasCountstill equals 30 so that assertion is honest.- The
keeps only the listed rows temporaryexpectation matches emission order exactly. zhis still referenced at line 176, so removing the/zh-CN/minimaxcase from the permanent-rows table didn't orphan the binding.
Pulling the reason into MINIMAX_TEMPORARY_BECAUSE and rewording it to "before both locales go permanent together" is better than what I suggested — it makes the pairing a property of the data instead of something the next person has to notice.
One thing to fix before you squash: the title and body are now the opposite of what ships. The title says "all permanent", the summary says "/minimax is permanent", the changes list says "/minimax and /zh-CN/minimax are permanent (second commit)", and the Review Focus still carries [x] /minimax goes permanent. That text becomes the permanent commit message on main, and it would describe three rows that are deliberately temporary. Something like feat(website): one typed redirect list, generated vercel.json plus a line noting MiniMax stays 307 pending owner sign-off. Not re-reviewing for it — just don't let it ride through.
Leaving the zod / astro/zod thread open as a genuine nit you can take or decline; it's cosmetic and I've confirmed it has no behavioural effect.
Good work across three rounds. The final shape — one typed list, both emitters derived from it, a drift test, a shadow-page test, and the generator chained so the artifact can't go stale — is materially better than what this replaced, and the two things I pushed back on were both real.
benjcooley
left a comment
There was a problem hiding this comment.
Approving again. Scoped to 015a2643, which is the one-line zod import swap, plus the body edits.
The import change was not the no-op I implied when I raised it. astro/zod re-exports zod/v4, but the workspace catalog pins zod: ^3.23.8 and apps/website resolves to 3.25.76 — so this moved the script across a Zod major version rather than deleting a redundant hop. That is my error in how I framed the nit, and it is the kind of change that deserves a check rather than a glance, because a record-and-object intersection is precisely where v3 and v4 merge semantics could diverge and silently drop top-level keys from vercel.json — a file that is now rewritten automatically as part of generate:models.
I ran the real script end to end against the committed file under 3.25.76. $schema, outputDirectory, installCommand, framework, github and headers all survive in their original order, and the output is byte-identical to what is committed — so pnpm sync:redirects is idempotent and touches nothing outside the redirects block. Safe.
Body is fixed too: the summary no longer claims /minimax is permanent, and the changes list now reads "/minimax and /zh-CN/minimax stay 307 as on prod ... they go permanent together only after the MiniMax page owner signs off," which is exactly right.
The title is the last thing. It still reads feat(website): one typed redirect list, all permanent, generated vercel.json, and 7 of the 71 rules are deliberately temporary. That string becomes the commit on main. Drop the two words when you squash:
feat(website): one typed redirect list, generated vercel.json
All five of my threads are resolved. Nothing else outstanding from me.
## Summary **Deploy gate: comfy-router#46 is merged and live (2026-09-30). Its follow-up comfy-router#48 (serves `/hub/models.md` instead of 301ing it to a /workflows 404) must be deployed before this merges. After the merge, purge Cloudflare for `/hub/models*`, `/hub/workflows*` and the 30 workflow names in `hub-workflow-names.json`. The redirects ship as 307; FE-3083 flips them to 308 later.** This branch combines every Workshop /models SEO PR, so merging it to main replaces merging them one by one. It also launches: Comfy-Org#19405 commits `launchedModelPages = 'all'`, so all 148 model pages become indexable in the same deploy as the URL move. Part of FE-2912, FE-2942 (PR 2 is FE-3086), FE-2974 (/minimax 308 is FE-3087) Fixes FE-2978, FE-2989, FE-2991, FE-2990, FE-2959, FE-2981, FE-2977, FE-2979, FE-3014, FE-2936, FE-2980, FE-2975, FE-3085, FE-2972, FE-2935, FE-2950, FE-2940, FE-2930, FE-2985, FE-2957, FE-2961, FE-2986, FE-2921, FE-2922, FE-2947 ## Changes Router follow-up: comfy-router#48 (`/hub/models.md` routing, 324/324 router tests), deploy before this merges. The included PRs, in merge order. Every head was checked as contained at the final tip. | PR | Ticket | What | Ben | |---|---|---|---| | Comfy-Org#18887 | FE-2978 | Pricing Product markup and full video `uploadDate` | approved | | Comfy-Org#18889 | FE-2989 | A unique meta description on every model page | approved | | Comfy-Org#18890 | FE-2991 | Model page JSON-LD, emitted once noindex lifts | approved | | Comfy-Org#18892 | FE-2990 | Cleaner tag pills, guard against duplicate summaries | approved | | Comfy-Org#18893 | FE-2959, 2981, 2977, 2979 | Social tags, hub title, Organization data. The FE-2977 title was confirmed by the owner | approved | | Comfy-Org#19362 | FE-3014 | Every non-production build is noindex | approved | | Comfy-Org#19366 | FE-2936 | Model titles lead with "API & Playground" | approved | | Comfy-Org#19402 | FE-2980 | Every internal link ends with a slash, plus a CI check | approved | | Comfy-Org#19419 | FE-2975 | Footer links the catalogue on every page and locale | approved | | Comfy-Org#19476 | FE-3085 | `NOINDEX_ROUTES` decides noindex for serverless-animation | approved; re-approval pending on a one-line follow-up (CodeRabbit approved) | | Comfy-Org#19359 | FE-2974 | One typed redirect list that generates `vercel.json` | approved | | Comfy-Org#19369 | FE-2972 A | The old to new model URL map | approved | | Comfy-Org#18891 | FE-2935 | Model content shows whatever the flag says | approved | | Comfy-Org#18899 | FE-2942 | Model pages render in the static HTML | approved | | Comfy-Org#18898 | FE-2950 | Catalogue h1 and A to Z links in the static HTML | approved | | Comfy-Org#19375 | FE-2940 | Related models leave no page unlinked | approved | | Comfy-Org#19385 | FE-2930 | Examples show the prompt that made them | approved | | Comfy-Org#19394 | FE-2985 | Render guard e2e: no loader, no layout shift | approved | | Comfy-Org#19357 | FE-2957 | robots.txt stops blocking our scripts and styles | approved | | Comfy-Org#19360 | FE-2961 | Turning Workshop off keeps every Models page | approved (a CodeRabbit changes-requested review is still open) | | Comfy-Org#19386 | FE-2986 | One registry of every Models address | approved | | Comfy-Org#19421 | FE-2972 B1 | Model pages served at `/hub/models` | approved | | Comfy-Org#19422 | FE-2972 B2 | Every old model URL redirects (307) | approved | | Comfy-Org#19424 | FE-2972 B3 | Workflow pages at `/hub/workflows` with redirects | approved | | Comfy-Org#19399 | FE-2921 | One switch decides model robots and sitemap listing | approved | | Comfy-Org#19404 | FE-2922 | Clean markdown twins for model pages | approved | | Comfy-Org#19405 | FE-2947 | Lifts noindex on every canonical model page | approved | | comfy-router#46 | FE-3075 | Serves `/hub/models*` from the website and routes `/hub/workflows` by manifest. Merged and live | merged | These fixes exist only on this branch, because they only break once two PRs meet: - `scripts/check-models-html.ts` reads each page at `model.href` and skips models without a page (f1df1e4). - `e2e/fixtures/modelsCatalogue.ts` reads `dist/hub/models` (f87bb4c). - `routerIdsByModelPage` accepts an optional `href`, since Comfy-Org#19421 made it optional and Comfy-Org#19405 no longer typechecked (9783819). - `ModelStatus` links a successor only when it has a page, for the same reason on Comfy-Org#18899 (c4761d8). - The model breadcrumb in `modelJsonLd.ts` points at `/hub/models/` instead of the `/models/` redirect (eb985b6). Its label still says "Models" while the nav says "Hub". - Twin, meta-description and entry tests use the hub pages and the new tag set (86ac3b0, d4ffc0f). - The render guard finds the catalogue through `getRoutes().workshop`, and its `test.fail` is gone now that Comfy-Org#18898 renders the h1 (831499f). - A new test renders a real model page and checks its markdown twin has the model's h1 (9a6c5cb). - Main's newer catalogue and workflow e2e cases use the hub addresses (2aeda77). - `resetWorkshopAccountSource` resets `decision`; a clean auto-merge of main's Comfy-Org#19454 into Comfy-Org#18891 left it assigning a variable that no longer exists (c28c7a7). The conflict resolutions, briefly: `ALTERNATE_TWIN_SOURCES` stays deleted as Comfy-Org#18898 wants, so `/hub/models.md` comes from the real catalogue. The hub keeps Comfy-Org#18898's single static h1 instead of the `WorkshopHero` h1 that main's Comfy-Org#19320 added. `ExamplesTab` keeps Comfy-Org#19385's figure and caption with main's video poster. The Comfy-Org#19399/Comfy-Org#19405 indexing tests were rewritten for hub paths. The Comfy-Org#19359 redirect test no longer builds `/enterprise//` from slash-ended routes. The Comfy-Org#19369 URL-map test imports `PROVIDER_NAMES` from its new home. The full table of 47 resolutions is in the integration report. ## Review Focus - Launch rides along with the URL move. If launch should stay a separate step, set `launchedModelPages` in `apps/website/src/config/model-page-launch.ts` to `new Set()` before merging. - Main's Comfy-Org#19320 gives the catalogue island its own h1 through `WorkshopHero`. This branch keeps Comfy-Org#18898's static h1 and renders only the subtitle in `ModelsCatalogue.vue`, so the hub has exactly one h1. - Comfy-Org#19476 overlaps the open community PR Comfy-Org#18591 (same sitemap exclusion for serverless-animation). One of them should be closed once this lands. ## QA - [x] Gates: `pnpm typecheck` and website typecheck clean, `pnpm lint` 0 errors, eslint on `apps/website` clean, `pnpm knip` clean - [x] Website unit: 547 files, 10347 passed, 4 skipped - [x] Build A (`build:e2e`, CI env): 1193 pages; release gate, `check:hreflang`, `validate:llms-txt-links` (225 links), `validate:jsonld` (947 pages), `check:link-slashes`, `check:models-html` (148 pages) all pass - [x] Build B (`WORKSHOP_IN_BUILD=0`): same 182 Models pages as the on build, no `dist/workshop`, `/` is noindex; with the flag stubbed on, no Run, no Hub nav and no Firebase requests - [x] Build C (preview shape): 945 of 945 pages noindex, no canonicals except redirect stubs, no hreflang in the sitemap - [x] E2E on Build A: 644 of 645 passed; the one mobile failure passed on rerun. Earlier load flakes (navigation, demos, fdct, wan-3.0, network isolation, render guard) all passed when rerun alone - [x] Launch: 148 model pages indexable with canonicals, 149 hub entries in the sitemap, 148 non-empty twins with the model h1, 148 in `llms-full.txt`, 0 titles over 60, 30 workflow pages still noindex - [x] Redirects: 853 rules, 782 to /hub all 307, the MiniMax rows 307, every /hub destination built - [x] comfy-router#46 under `wrangler dev` in front of this build: 312 router tests pass; 148 old model URLs (both slash forms) 307 then 200; 30 workflow names served by the website and their old URLs 307; a non-manifest workflow 302 with no-store; `manifest.json` passes through; `/workflows/` and bare `/hub` unchanged - [x] After the router deploys and this merges: purge Cloudflare, then curl `https://comfy.org/hub/models/` for a 200 and three old `/models/<slug>/` URLs for one 307 each - [x] Rich Results Test on `/pricing/` and `/learning/animations/character-sheet/`, then "Validate fix" on Merchant listings and Videos - [x] Rich Results Test on two live model pages: breadcrumbs valid and the breadcrumb URL returns 200 with no redirect - [x] GPTBot and Googlebot curls on the hub and one model page, then a GSC live test on both - [x] Resubmit the sitemap in Search Console and URL-inspect about 20 model pages on day 0 and day 14 - Not covered: Rich Results and GSC need production; the redirect matrix used a local shim for `vercel.json`, since `astro preview` ignores it --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: benjcooley <benjcooley@gmail.com> Co-authored-by: Deep Mehta <42841935+deepme987@users.noreply.github.com>
|
Superseded by the integration branch #19494, which combined this PR with every other Workshop SEO slice and has been merged to main. Closing this one. |
…Org#20191) ## Summary The old `/models` addresses now redirect permanently (308) to their `/hub` pages, so search engines move their ranking to the new URLs. comfy-router#46 is live on prod, which was the only reason they were temporary. ## Changes - **What**: removes `temporaryBecause` from every old Models row in `redirects.ts`: `/models`, each old model slug and alias, each `/models/workflows/<name>` and each `/models/apps/<name>`, both slash forms (786 rules). `vercel.json` is regenerated with `sync:redirects`. The tests that pinned these rows to 307 now pin 308. - **Kept temporary**: `/minimax` and `/zh-CN/minimax` stay 307. Their reason is still open: the MiniMax page owner has not signed off that `/minimax/` won't be reused (FE-3087, asked for in review on Comfy-Org#19359). `/trust`, `/login` and `/share-news*` stay 307 for their own reasons, so the `temporaryBecause` field stays. - **Changed from the ticket**: FE-2974's `/minimax` part is not in this PR. It is a one-line flip once FE-3087 has the sign-off. ## Review Focus - [ ] A 308 is cached by browsers and can't be taken back. On prod today `/hub/models/`, `/hub/workflows/` and `/hub/apps/` answer 200 from the website, and each old URL reaches a 200 page in one hop. - [ ] The `/models/apps/*` rows had their own reason (router sends `/hub/apps/` here). That is also true on prod now, so they flip too. Fixes FE-3083 (https://linear.app/comfyorg/issue/FE-3083) Part of FE-2974 (https://linear.app/comfyorg/issue/FE-2974) --------- Co-authored-by: GitHub Action <action@github.com>
Summary
Every redirect on the website now comes from one typed list in
src/config/redirects.ts, andvercel.jsonis generated from it. Pages that used to "redirect" with a 200 meta-refresh now get a real 308, and a test fails ifvercel.jsondrifts from the list.Part of FE-2974 (https://linear.app/comfyorg/issue/FE-2974). This is part A; part B, making
/minimaxand/zh-CN/minimaxpermanent after the page owner signs off, is FE-3087 (https://linear.app/comfyorg/issue/FE-3087).Changes
siteRedirectsinsrc/config/redirects.tsis the one list. A row is{ source, destination }, it's a 308 unless it setstemporaryBecause, and the 12 supported-models alias rows are generated fromcanonicalSluginmodels.ts. FE-2972 can append its model-URL rows the same way.pnpm --filter @comfyorg/website sync:redirectsrewrites only theredirectsblock ofvercel.json, emitting both slash forms of every source.redirectsoption is derived from the same list (internal rows only, since Astro can't redirect off-site), soastro previewand the e2e suite still see every internal redirect.redirects.test.tsfails whenvercel.jsondiffers from the list, a source repeats, a destination is itself a source (a chain), an internal destination lacks its trailing slash, or the route count reaches Vercel's 2,048 cap./zh-CN/terms-of-service,/zh-CN/affiliates,/zh-CN/affiliates/terms, the two/cloud/enterprise-case-studies/*paths and the 12/p/supported-models/<alias>pages now answer with a 308 on Vercel. Before, only a meta-refresh page served them./careers,/pricing,/platform, ...) now end in/, so each redirect lands in one hop.p/supported-models/[slug].astrono longer builds alias pages itself. The Astro map builds the same stub, byte for byte./minimaxand/zh-CN/minimaxstay 307 as on prod: both namespaces hold license pages, so they go permanent together only after the MiniMax page owner signs off.No new e2e:
e2e/canonical-redirects.spec.tsalready covers the stubs Astro now builds from the list (including the t5xxl alias), and it passes unchanged.astro previewdoesn't readvercel.json, so the 308s are covered by the drift test and the preview curls in the QA comment.Changed from the ticket: the 212
/models/<alias>/meta-refresh pages and/cinematic-studiostay as they are. They move with the new model URLs in FE-2972, and/cinematic-studiopicks its target from a query string, so it can't be a plain redirect.Review Focus
/loginkeeps its no-slash-only rule (slashFormIsPageBecause), because/login/is the Workshop sign-in page. The bare path still sends people to Cloud sign-in, which predates the Workshop page./trust,/login,/share-news*and both/minimaxrows stay 307, each with its reason next to the row./career/,/privacy/,/press/,/blog/,/discord/and/trust/gained their slash form, so/privacy/changes from a 404 to a redirect. Locally,/career,/pressand/privacyalso get Astro stubs. The sitemap is unchanged.