Skip to content

feat(website): move model pages to /hub/models (step B2 of 2): redirect every old URL (307 first, 308 after router #46, FE-3083) - #19422

Closed
MaanilVerma wants to merge 17 commits into
maanil/fe-2972-hub-servefrom
maanil/fe-2972-hub-redirects
Closed

MaanilVerma wants to merge 17 commits into
maanil/fe-2972-hub-servefrom
maanil/fe-2972-hub-redirects

Conversation

@MaanilVerma

@MaanilVerma MaanilVerma commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Every old model address now answers with one 307 straight to its /hub/models/ page, and the old pages and alias stubs are no longer built.

Deploy together with comfy-router#46. Until the router stops sending /hub/models* to /workflows, the new pages can't be reached on comfy.org, so this PR alone would send every old URL to a page visitors can't see. Router deploys are manual (ask Ben). Deploy #46 in the same window, then purge the Cloudflare cache for /hub/models and /hub/models/.

Stacked on #19421 (step B1); also merges #19359, so merge that first. Part of FE-2972 (step B2 of 2): https://linear.app/comfyorg/issue/FE-2972

Changes

  • siteRedirects gets 361 rows generated from model-urls.ts: /models, the 148 old slugs and the 212 aliases, each going straight to its final page. They ship temporary (307) via temporaryBecause, because a 308 is cached by browsers and can't be retracted if the router change slips. After sync:redirects that's 722 new Vercel rules; vercel.json now has 793 redirects plus 4 headers, 797 of the 2,048 route limit. These rows get no Astro stubs.
  • /models and the old model pages stop building; only workflow pages, apps and the showcase stay under /models. The registry already lists the old paths as alias.
  • The release gate fails the build if any page, models/catalogue.json, models/<slug>/page.json or markdown twin links to an old /models/<slug> address.
  • .gitattributes marks vercel.json as generated.
  • The e2e alias test no longer visits /models/bfl--flux-2-max/ in astro preview, where it is now a 404. It loads the hub page the alias points at; the alias rows themselves are pinned in redirects.test.ts.
  • /minimax and /zh-CN/minimax keep their status from feat(website): one typed redirect list, generated vercel.json #19359, which leaves them 307 until the page owner signs off.

Review Focus

  • Follow-up: after comfy-router#46 is live and verified on prod, flip the old model rows to permanent (drop temporaryBecause: HUB_ROUTER_PENDING from hubModelRedirects in redirects.ts), run sync:redirects and redeploy.
  • Local astro dev and astro preview now return 404 for old model URLs, because those redirects only exist on Vercel.

@MaanilVerma MaanilVerma added the cursor-review Trigger multi-model Cursor agent review on this PR label Sep 29, 2026
@MaanilVerma MaanilVerma self-assigned this Sep 29, 2026
@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: f3c57d95-c7cf-4450-9b36-62caa483d9e8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🎭 Playwright: ✅ 2158 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2137 / ❌ 0 / ⚠️ 1 / ⏭️ 9)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since e91961b1b7db7b64dc1c625d4e2f225d850b9152

Full docs: ADR-DEVEX-LINT-0015

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-19422.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-q8cld9wxm-comfyui.vercel.app

Last updated: 2026-09-29T22:09:33Z for 356ea8f

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.1 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.2 MB heap
dom-widget-order-dense-n200-w200-i120: · 32.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 415ms TBT · 81.0 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 45.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 125ms TBT · 74.1 MB heap
extension-clean-combined-draw: · 39.3 avg FPS · 24.0 P5 FPS ❌ (target: ≥52) · 37ms TBT · 71.9 MB heap
extension-rgthree-prototype-draw: · 39.2 avg FPS · 24.0 P5 FPS ❌ (target: ≥52) · 64ms TBT · 79.5 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.2 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.2 MB heap
legacy-node-drag: · 59.6 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 89.6 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.4 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.3 MB heap
subgraph-transition-enter: · 49.6 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 96ms TBT · 94.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.3 MB heap
vue-large-graph-idle: · 52.5 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 171.3 MB heap
vue-large-graph-pan: · 41.8 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 22ms TBT · 163.5 MB heap
vue-node-resize-workload: · 48.4 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 0ms TBT · 194.6 MB heap
vue-zoom-out-idle: · 54.7 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 159.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.4 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.1 MB heap
agent-composer-long-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 121.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 3ms
canvas-idle: layout count 0
canvas-idle: style recalc count 12
canvas-idle: task duration 342ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 73.1 MB
canvas-idle: DOM nodes -228
canvas-idle: event listeners -164
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 12ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 73
canvas-mouse-sweep: task duration 620ms
canvas-mouse-sweep: script duration 108ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 71.4 MB
canvas-mouse-sweep: DOM nodes -228
canvas-mouse-sweep: event listeners -164
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 8ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 256ms
canvas-zoom-sweep: script duration 9ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 77.1 MB
canvas-zoom-sweep: DOM nodes 53
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 3ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 362ms
dom-widget-clipping: script duration 122ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 78.2 MB
dom-widget-clipping: DOM nodes -114
dom-widget-clipping: event listeners -71
dom-widget-order-dense-n200-w200-i120: avg frame time 31ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 660ms
dom-widget-order-dense-n200-w200-i120: script duration 48ms
dom-widget-order-dense-n200-w200-i120: TBT 415ms
dom-widget-order-dense-n200-w200-i120: heap used 81.0 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes 0
dom-widget-order-dense-n200-w200-i120: event listeners 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time 22ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 343ms
dom-widget-order-sparse-n1000-w20-i120: script duration 104ms
dom-widget-order-sparse-n1000-w20-i120: TBT 125ms
dom-widget-order-sparse-n1000-w20-i120: heap used 74.1 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 25ms
extension-clean-combined-draw: p95 frame time 42ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 1
extension-clean-combined-draw: task duration 5892ms
extension-clean-combined-draw: script duration 4686ms
extension-clean-combined-draw: TBT 37ms
extension-clean-combined-draw: heap used 71.9 MB
extension-clean-combined-draw: DOM nodes 0
extension-clean-combined-draw: event listeners 0
extension-rgthree-prototype-draw: avg frame time 26ms
extension-rgthree-prototype-draw: p95 frame time 42ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 1
extension-rgthree-prototype-draw: task duration 6300ms
extension-rgthree-prototype-draw: script duration 4955ms
extension-rgthree-prototype-draw: TBT 64ms
extension-rgthree-prototype-draw: heap used 79.5 MB
extension-rgthree-prototype-draw: DOM nodes 0
extension-rgthree-prototype-draw: event listeners 0
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 2ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 10
large-graph-idle: task duration 459ms
large-graph-idle: script duration 25ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 79.2 MB
large-graph-idle: DOM nodes -228
large-graph-idle: event listeners -164
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 8ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1238ms
large-graph-pan: script duration 610ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 75.5 MB
large-graph-pan: DOM nodes -114
large-graph-pan: event listeners -71
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 10ms
large-graph-zoom: style recalc duration 7ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 64
large-graph-zoom: task duration 1216ms
large-graph-zoom: script duration 540ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 71.2 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 4ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 45
legacy-node-drag: task duration 1366ms
legacy-node-drag: script duration 659ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 76.9 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 440ms
minimap-idle: script duration 22ms
minimap-idle: TBT 0ms
minimap-idle: heap used 79.9 MB
minimap-idle: DOM nodes -228
minimap-idle: event listeners -142
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 5ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 281ms
subgraph-dom-widget-clipping: script duration 103ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 89.6 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 3ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 12
subgraph-idle: task duration 375ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 72.4 MB
subgraph-idle: DOM nodes -244
subgraph-idle: event listeners -199
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 14ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 601ms
subgraph-mouse-sweep: script duration 73ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 67.3 MB
subgraph-mouse-sweep: DOM nodes -230
subgraph-mouse-sweep: event listeners -199
subgraph-transition-enter: avg frame time 20ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 8ms
subgraph-transition-enter: style recalc duration 21ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 664ms
subgraph-transition-enter: script duration 26ms
subgraph-transition-enter: TBT 96ms
subgraph-transition-enter: heap used 94.3 MB
subgraph-transition-enter: DOM nodes 13667
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 21ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 252
viewport-pan-sweep: task duration 4291ms
viewport-pan-sweep: script duration 2002ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 82.3 MB
viewport-pan-sweep: DOM nodes -228
viewport-pan-sweep: event listeners -164
vue-large-graph-idle: avg frame time 19ms
vue-large-graph-idle: p95 frame time 33ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 10650ms
vue-large-graph-idle: script duration 138ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 171.3 MB
vue-large-graph-idle: DOM nodes -8049
vue-large-graph-idle: event listeners -7462
vue-large-graph-pan: avg frame time 24ms
vue-large-graph-pan: p95 frame time 50ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 10ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 65
vue-large-graph-pan: task duration 13068ms
vue-large-graph-pan: script duration 628ms
vue-large-graph-pan: TBT 22ms
vue-large-graph-pan: heap used 163.5 MB
vue-large-graph-pan: DOM nodes -8049
vue-large-graph-pan: event listeners -7462
vue-node-resize-workload: avg frame time 21ms
vue-node-resize-workload: p95 frame time 33ms
vue-node-resize-workload: layout duration 18ms
vue-node-resize-workload: style recalc duration 59ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 3308ms
vue-node-resize-workload: script duration 52ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 194.6 MB
vue-node-resize-workload: DOM nodes 0
vue-node-resize-workload: event listeners 0
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 33ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 5226ms
vue-zoom-out-idle: script duration 58ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 159.5 MB
vue-zoom-out-idle: DOM nodes -1523
vue-zoom-out-idle: event listeners -7458
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 4
workflow-execution: style recalc count 20
workflow-execution: task duration 110ms
workflow-execution: script duration 9ms
workflow-execution: TBT 0ms
workflow-execution: heap used 78.4 MB
workflow-execution: DOM nodes 115
workflow-execution: event listeners 81
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 15ms
agent-composer-empty-conversation-typing: style recalc duration 77ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 78
agent-composer-empty-conversation-typing: task duration 421ms
agent-composer-empty-conversation-typing: script duration 153ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 85.1 MB
agent-composer-empty-conversation-typing: DOM nodes 76
agent-composer-empty-conversation-typing: event listeners 876
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 14ms
agent-composer-long-conversation-typing: style recalc duration 182ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 78
agent-composer-long-conversation-typing: task duration 685ms
agent-composer-long-conversation-typing: script duration 186ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 121.1 MB
agent-composer-long-conversation-typing: DOM nodes 76
agent-composer-long-conversation-typing: event listeners 876
Raw data
{
  "timestamp": "2026-09-29T22:19:10.296Z",
  "gitSha": "820145f8cfba442472f663093a59e64eb65ec3b6",
  "branch": "maanil/fe-2972-hub-redirects",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2033.0699999999524,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 3.1399999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 385.458,
      "heapDeltaBytes": -2083384,
      "heapUsedBytes": 77038384,
      "domNodes": -228,
      "jsHeapTotalBytes": 3145728,
      "scriptDurationMs": 8.488000000000001,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2022.324000000026,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 2.6169999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 299.12300000000005,
      "heapDeltaBytes": -2571844,
      "heapUsedBytes": 76304468,
      "domNodes": -228,
      "jsHeapTotalBytes": 2883584,
      "scriptDurationMs": 7.791000000000001,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1721.5310000000272,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 11.812,
      "layouts": 12,
      "layoutDurationMs": 2.799,
      "taskDurationMs": 598.412,
      "heapDeltaBytes": -2561328,
      "heapUsedBytes": 76223844,
      "domNodes": -228,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 105.709,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666990291262138,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1739.4479999999817,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 12.940999999999999,
      "layouts": 12,
      "layoutDurationMs": 3.2509999999999994,
      "taskDurationMs": 641.706,
      "heapDeltaBytes": -25383780,
      "heapUsedBytes": 73489940,
      "domNodes": -228,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 110.75299999999999,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846153,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1717.0509999999695,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 7.967999999999999,
      "layouts": 6,
      "layoutDurationMs": 1.138,
      "taskDurationMs": 255.557,
      "heapDeltaBytes": 1759284,
      "heapUsedBytes": 81145996,
      "domNodes": 53,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 8.741,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66601941747573,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1723.214999999982,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 7.728,
      "layouts": 6,
      "layoutDurationMs": 0.9159999999999999,
      "taskDurationMs": 256.073,
      "heapDeltaBytes": 1533784,
      "heapUsedBytes": 80484192,
      "domNodes": 53,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 8.379,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666019417475724,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 549.3690000000129,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 2.8310000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 335.538,
      "heapDeltaBytes": 18296664,
      "heapUsedBytes": 97360932,
      "domNodes": 0,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 121.303,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 588.2199999999784,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 3.483000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 388.787,
      "heapDeltaBytes": -12591880,
      "heapUsedBytes": 66708536,
      "domNodes": -228,
      "jsHeapTotalBytes": -786432,
      "scriptDurationMs": 122.975,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.668571428571433,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1035.4680000000371,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 660.131,
      "heapDeltaBytes": 7093136,
      "heapUsedBytes": 82605300,
      "domNodes": 0,
      "jsHeapTotalBytes": 4620288,
      "scriptDurationMs": 51.168000000000006,
      "eventListeners": 0,
      "totalBlockingTimeMs": 413,
      "frameDurationMs": 31.312121212121216,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1047.9060000000118,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 659.7490000000001,
      "heapDeltaBytes": 9872992,
      "heapUsedBytes": 87280300,
      "domNodes": 0,
      "jsHeapTotalBytes": 3571712,
      "scriptDurationMs": 44.778999999999996,
      "eventListeners": 0,
      "totalBlockingTimeMs": 416,
      "frameDurationMs": 30.879411764705885,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 780.386999999962,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 355.96000000000004,
      "heapDeltaBytes": 15503408,
      "heapUsedBytes": 89434396,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 109.69300000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 132,
      "frameDurationMs": 22.380000000000006,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 749.3109999999774,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 330.1340000000001,
      "heapDeltaBytes": -12296544,
      "heapUsedBytes": 65961968,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 98.55000000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 118,
      "frameDurationMs": 22.058823529411764,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 7338.316000000021,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6474.43,
      "heapDeltaBytes": 2959292,
      "heapUsedBytes": 83888728,
      "domNodes": 0,
      "jsHeapTotalBytes": -13369344,
      "scriptDurationMs": 5094.084,
      "eventListeners": 0,
      "totalBlockingTimeMs": 44,
      "frameDurationMs": 25.82042253521127,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 6180.96700000001,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 0.22299999999999925,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5308.999,
      "heapDeltaBytes": -13319692,
      "heapUsedBytes": 66961500,
      "domNodes": 0,
      "jsHeapTotalBytes": -14680064,
      "scriptDurationMs": 4278.103,
      "eventListeners": 0,
      "totalBlockingTimeMs": 29,
      "frameDurationMs": 25.032793522267205,
      "p95FrameDurationMs": 33.400000000001455
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 7580.483000000015,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.030000000000000512,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6829.998,
      "heapDeltaBytes": 3950364,
      "heapUsedBytes": 84959892,
      "domNodes": 0,
      "jsHeapTotalBytes": -10223616,
      "scriptDurationMs": 5402.089,
      "eventListeners": 0,
      "totalBlockingTimeMs": 87,
      "frameDurationMs": 26.271874999999998,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6440.589000000045,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.030999999999999778,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5769.068000000001,
      "heapDeltaBytes": 7969644,
      "heapUsedBytes": 81829468,
      "domNodes": 0,
      "jsHeapTotalBytes": -6291456,
      "scriptDurationMs": 4507.7789999999995,
      "eventListeners": 0,
      "totalBlockingTimeMs": 41,
      "frameDurationMs": 24.74230769230769,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2051.480999999967,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.3560000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 473.58200000000005,
      "heapDeltaBytes": -36736196,
      "heapUsedBytes": 82942692,
      "domNodes": -228,
      "jsHeapTotalBytes": -360448,
      "scriptDurationMs": 29.640000000000008,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2028.8630000000012,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.3309999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 443.53299999999996,
      "heapDeltaBytes": -37281272,
      "heapUsedBytes": 83068620,
      "domNodes": -228,
      "jsHeapTotalBytes": -360448,
      "scriptDurationMs": 20.867000000000004,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666393442622947,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2123.673999999994,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 5.699000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1175.0179999999998,
      "heapDeltaBytes": 15800868,
      "heapUsedBytes": 79178100,
      "domNodes": 0,
      "jsHeapTotalBytes": 487424,
      "scriptDurationMs": 593.4399999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2167.324000000008,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 9.341000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1300.443,
      "heapDeltaBytes": -42229632,
      "heapUsedBytes": 79217292,
      "domNodes": -228,
      "jsHeapTotalBytes": 389120,
      "scriptDurationMs": 626.741,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666153846153843,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3102.8009999999995,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 7.2379999999999995,
      "layouts": 60,
      "layoutDurationMs": 9.431999999999999,
      "taskDurationMs": 1192.001,
      "heapDeltaBytes": 9526740,
      "heapUsedBytes": 72938192,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 530.9069999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666129032258066,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3116.659000000027,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 7.245,
      "layouts": 60,
      "layoutDurationMs": 9.606,
      "taskDurationMs": 1240.2549999999999,
      "heapDeltaBytes": 11992812,
      "heapUsedBytes": 76368636,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 548.654,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665775401069517,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2191.498000000024,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 3.8819999999999983,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1359.592,
      "heapDeltaBytes": 10319924,
      "heapUsedBytes": 75159116,
      "domNodes": 0,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 659.969,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.79312977099237,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2233.7059999999838,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 3.236000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1371.712,
      "heapDeltaBytes": 21715824,
      "heapUsedBytes": 86166716,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 658.9269999999999,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.79097744360902,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2028.1720000000405,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 1.7890000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 443.362,
      "heapDeltaBytes": -10522808,
      "heapUsedBytes": 83627636,
      "domNodes": -228,
      "jsHeapTotalBytes": -1708032,
      "scriptDurationMs": 22.767000000000003,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2027.782000000002,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 1.8099999999999992,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 436.1060000000001,
      "heapDeltaBytes": -37775380,
      "heapUsedBytes": 83866404,
      "domNodes": -228,
      "jsHeapTotalBytes": -360448,
      "scriptDurationMs": 21.385,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 499.9349999999936,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 4.480999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 290.70799999999997,
      "heapDeltaBytes": 12682820,
      "heapUsedBytes": 94081292,
      "domNodes": 0,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 100.89,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 460.32800000000407,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 4.607,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 270.322,
      "heapDeltaBytes": 12357000,
      "heapUsedBytes": 93833336,
      "domNodes": 0,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 104.99199999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66428571428571,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2027.8710000000046,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 2.857,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 377.198,
      "heapDeltaBytes": -7367768,
      "heapUsedBytes": 73526584,
      "domNodes": -244,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 7.275999999999998,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2011.2530000000106,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 2.895,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 373.241,
      "heapDeltaBytes": -2514792,
      "heapUsedBytes": 78261592,
      "domNodes": -244,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 6.632000000000001,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1725.8640000000014,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 14.175999999999998,
      "layouts": 16,
      "layoutDurationMs": 4.0920000000000005,
      "taskDurationMs": 589.272,
      "heapDeltaBytes": -18525108,
      "heapUsedBytes": 63039596,
      "domNodes": -215,
      "jsHeapTotalBytes": 1310720,
      "scriptDurationMs": 71.31700000000001,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846153,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1711.4789999999402,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 12.896,
      "layouts": 16,
      "layoutDurationMs": 4.973999999999999,
      "taskDurationMs": 611.792,
      "heapDeltaBytes": -3167556,
      "heapUsedBytes": 78172764,
      "domNodes": -244,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 75.209,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666019417475724,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 866.8349999999805,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 20.729999999999997,
      "layouts": 5,
      "layoutDurationMs": 8.176,
      "taskDurationMs": 664.3840000000001,
      "heapDeltaBytes": 21394200,
      "heapUsedBytes": 98906892,
      "domNodes": 13667,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 25.608,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 96,
      "frameDurationMs": 20.153488372093033,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8166.934000000027,
      "styleRecalcs": 252,
      "styleRecalcDurationMs": 19.711,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4437.375,
      "heapDeltaBytes": -30726028,
      "heapUsedBytes": 89714100,
      "domNodes": -228,
      "jsHeapTotalBytes": 126976,
      "scriptDurationMs": 2101,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66591836734694,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8122.848999999974,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 22.378999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4144.566,
      "heapDeltaBytes": 20918444,
      "heapUsedBytes": 82936412,
      "domNodes": -228,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 1903.6870000000001,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666119096509238,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 11173.986000000014,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10459.502,
      "heapDeltaBytes": -20255724,
      "heapUsedBytes": 180808740,
      "domNodes": -8049,
      "jsHeapTotalBytes": -27262976,
      "scriptDurationMs": 139.68999999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.707382550335574,
      "p95FrameDurationMs": 33.30000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 11457.915999999954,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10839.661,
      "heapDeltaBytes": 4754876,
      "heapUsedBytes": 178517860,
      "domNodes": -8049,
      "jsHeapTotalBytes": -14680064,
      "scriptDurationMs": 136.903,
      "eventListeners": -14923,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 19.406101694915257,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14012.773000000037,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 11.370999999999992,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13207.085000000001,
      "heapDeltaBytes": -25291168,
      "heapUsedBytes": 175460152,
      "domNodes": -8049,
      "jsHeapTotalBytes": -35913728,
      "scriptDurationMs": 662.329,
      "eventListeners": 0,
      "totalBlockingTimeMs": 43,
      "frameDurationMs": 24.028767123287672,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 13466.060999999969,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 9.488999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12928.479,
      "heapDeltaBytes": -44337152,
      "heapUsedBytes": 167497452,
      "domNodes": -8049,
      "jsHeapTotalBytes": -14663680,
      "scriptDurationMs": 594.358,
      "eventListeners": -14923,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 23.82966252220249,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 3913.7549999999806,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 59.059,
      "layouts": 20,
      "layoutDurationMs": 18.160999999999998,
      "taskDurationMs": 3808.5190000000002,
      "heapDeltaBytes": 14105076,
      "heapUsedBytes": 204278852,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 60.212,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 22.127118644067796,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 2936.6919999999936,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 59.508,
      "layouts": 20,
      "layoutDurationMs": 17.244999999999997,
      "taskDurationMs": 2806.6569999999997,
      "heapDeltaBytes": 7768708,
      "heapUsedBytes": 203794804,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 44.032000000000004,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 19.17058823529412,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 5457.1770000000015,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5276.27,
      "heapDeltaBytes": -22903208,
      "heapUsedBytes": 164695616,
      "domNodes": 0,
      "jsHeapTotalBytes": -20971520,
      "scriptDurationMs": 59.18099999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.41148648648649,
      "p95FrameDurationMs": 33.29999999999927
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 5426.270000000045,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5176.2519999999995,
      "heapDeltaBytes": -42017584,
      "heapUsedBytes": 169769744,
      "domNodes": -3045,
      "jsHeapTotalBytes": 10690560,
      "scriptDurationMs": 57.114,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.1761744966443,
      "p95FrameDurationMs": 33.29999999999927
    },
    {
      "name": "workflow-execution",
      "durationMs": 440.84200000003193,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 13.246,
      "layouts": 3,
      "layoutDurationMs": 1.4169999999999998,
      "taskDurationMs": 107.42800000000001,
      "heapDeltaBytes": -14292964,
      "heapUsedBytes": 82484160,
      "domNodes": 104,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 8.325999999999999,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.662962962962965,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 461.43500000005133,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 15.761000000000001,
      "layouts": 4,
      "layoutDurationMs": 1.3059999999999998,
      "taskDurationMs": 112.193,
      "heapDeltaBytes": -14202472,
      "heapUsedBytes": 81847712,
      "domNodes": 126,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 9.040999999999999,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667857142857137,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 460.52899999995134,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 77.551,
      "layouts": 76,
      "layoutDurationMs": 14.607999999999999,
      "taskDurationMs": 415.786,
      "heapDeltaBytes": 13462644,
      "heapUsedBytes": 88776208,
      "domNodes": 76,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 148.668,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667857142857137,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 470.2599999999393,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 76.851,
      "layouts": 76,
      "layoutDurationMs": 14.562999999999999,
      "taskDurationMs": 426.359,
      "heapDeltaBytes": 13522556,
      "heapUsedBytes": 89610944,
      "domNodes": 76,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 156.668,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66428571428573,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 709.6829999999272,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 177.364,
      "layouts": 76,
      "layoutDurationMs": 14.316,
      "taskDurationMs": 670.584,
      "heapDeltaBytes": 8521984,
      "heapUsedBytes": 126712060,
      "domNodes": 76,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 182.251,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665909090909075,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 733.2639999999628,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 187.468,
      "layouts": 76,
      "layoutDurationMs": 14.109,
      "taskDurationMs": 699.6629999999999,
      "heapDeltaBytes": 8707688,
      "heapUsedBytes": 127180468,
      "domNodes": 76,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 190.254,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667391304347824,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 52953 80724 65.6% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1151
src/LGraphNode.ts 70.3% 388
src/platform/workspace/stores/billingOperationStore.ts 8.0% 345
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.5% 344
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/LGraph.ts 79.2% 267
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/core/billing/operationLifecycle.ts 1.2% 252
src/scripts/app.ts 73.2% 252
src/core/webSessionIdentity.ts 3.4% 224

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 29, 2026
@MaanilVerma

MaanilVerma commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator Author

QA

Check Proof Result
Preview: 3 old URLs, both slash forms, go through one 308 to a 200 curl loop below, on comfy-website-preview-pr-19422 pass
Preview: /models and /models/ go to /hub/models/ same pass
Redirect rows 722 new Vercel rules; vercel.json has 793 redirects + 4 headers = 797 of 2,048 pass
Old pages and stubs are gone find dist/models -name index.html shows only workflows, apps and the showcase pass
148 pages still build under dist/hub/models ls pass
Old-href guard grep over dist = 0; the release gate fails the build otherwise pass
Redirect, registry, hub-models, URL-map, gate and llms tests vitest: 273 passed pass
typecheck / eslint / oxfmt clean pass
/models/bfl--flux-2-max--generate-images -> 308 /hub/models/flux-2-max-text-to-image/ -> 200
/models/bfl--flux-2-max--generate-images/ -> 308 /hub/models/flux-2-max-text-to-image/ -> 200
/models/byteplus--seedance-2-5-text-to-video--generate-videos -> 308 /hub/models/seedance-2-5-text-to-video/ -> 200
/models/byteplus--seedance-2-5-text-to-video--generate-videos/ -> 308 /hub/models/seedance-2-5-text-to-video/ -> 200
/models/vertexai--gemini-3-pro-image--edit-images -> 308 /hub/models/nano-banana-pro-image-edit/ -> 200
/models/vertexai--gemini-3-pro-image--edit-images/ -> 308 /hub/models/nano-banana-pro-image-edit/ -> 200
/models -> 308 /hub/models/ -> 200
/models/ -> 308 /hub/models/ -> 200

The preview serves /hub/models/ directly with no router in front, so this checks the website side only.

Round 2 (cf025df, merges #19421): the old-link guard now catches /models and /models/ and absolute https://comfy.org/models/... hrefs, reads pages one at a time, skips retired Workshop output, and reads flat .html pages. Proof: unit tests 99 passed; typecheck 0 errors; one build: old-link grep = 0; playwright test api-keys-onboarding canonical-redirects = 8 passed. 9 Cursor threads answered and resolved (5 fixed, 4 declined).

Round 3 (Ben's review, 10bcbb0, a128f6d, 37d49e5, a6e8610):

Check Proof Result
Old Models rows ship as 307 vercel.json: 793 redirects, 64 permanent, 729 temporary (722 old Models rows + 7 existing) pass
Preview answers 307 → 200 /models/bfl--flux-2-max--generate-images/ -> 307 /hub/models/flux-2-max-text-to-image/ -> 200; /models/vertexai--gemini-3-pro-image -> 307 /hub/models/nano-banana-pro-text-to-image/ -> 200; /models -> 307 /hub/models/ -> 200 pass
Redirect, hub-models and gate tests, red → green 10 failing before the change, 42 passed after; pretty-printed JSON case 1 failing → passing pass
Gate reads page data and twins clean build passes; with an old link put into dist/models/bfl--flux-2-max--generate-images/page.json and dist/hub/models.md, the gate fails: /hub/models.md → /models/bfl--flux-2-max--generate-images, /models/bfl--flux-2-max--generate-images/page.json → /models/bfl--flux-2-pro--generate-images pass
Disabled-model guard at the hub address playwright test models-catalogue-corrections -g "availability manifest|GPT Image generation" on a local preview: 2 passed pass
typecheck 0 errors pass

Round 3b (45bd0e1, merges #19421): B1 now makes hubModelHref throw for a slug with no built page and adds a redirect test that keeps model page data unredirected. That test replaces my narrower catch-all test. Proof: redirect, hub-models, gate, browse-content, registry and llms tests: 88 passed. Typecheck: 0 errors. PR is MERGEABLE.

Round 4 (acd5f67, cascade, merges #19421 at 0036005): redirects.ts merged clean: the hub rows plus #19359's minimax 307s. Proof: sync:redirects leaves vercel.json unchanged; 793 redirects, 722 hub-bound, 0 of them permanent; all four minimax rows are permanent: false; every hub destination exists in dist; website vitest 9886 passed; typecheck 0 errors; one build, the gate passed.

Round 5 (d92f80e, cascade, merges #19421 at f32a6d6): clean merge, bringing in the recorded-name drift check from #19369. Proof: regenerating the URL map changes nothing; URL map, redirects and registry tests: 85 passed; typecheck 0 errors.

Round 6 (a531ba3, cascade, merges #19421 at d3ebd9b): clean merge, bringing in the string-escaping fix from #19369. Proof: regenerating the URL map changes nothing; URL map, redirects and hub-models tests: 66 passed; typecheck 0 errors.

@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                     Coverage Diff                     @@
##           maanil/fe-2972-hub-serve   #19422     +/-   ##
===========================================================
  Coverage                     84.15%   84.15%             
===========================================================
  Files                          3204     3204             
  Lines                        155818   155849     +31     
  Branches                      40311    42209   +1898     
===========================================================
+ Hits                         131131   131161     +30     
- Misses                        22976    22977      +1     
  Partials                       1711     1711             
Flag Coverage Δ
e2e 65.59% <ø> (-0.02%) ⬇️
unit 81.42% <ø> (ø)
website-unit 79.10% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/website/src/config/hub-models.ts 100.00% <100.00%> (ø)
apps/website/src/config/redirects.ts 100.00% <100.00%> (ø)
apps/website/src/config/workshop-page-content.ts 100.00% <100.00%> (ø)
.../website/src/integrations/workshop-release-gate.ts 94.73% <100.00%> (+3.07%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @MaanilVerma.

Found 9 finding(s).

Severity Count
🟠 High 1
🟡 Medium 4
🟢 Low 3
⚪ Nit 1

Panel: 8/8 reviewers contributed findings.

Comment thread apps/website/src/config/redirects.ts Resolved
Comment thread apps/website/src/config/hub-models.ts Resolved
Comment thread apps/website/src/config/redirects.ts Resolved
Comment thread apps/website/src/config/hub-models.ts Resolved
Comment thread apps/website/src/config/redirects.ts Resolved
…aanil/fe-2972-hub-redirects

# Conflicts:
#	apps/website/src/config/hub-models.test.ts
#	apps/website/src/config/hub-models.ts
@vercel

vercel Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 29, 2026 10:07pm UTC
billing-web-test Ignored Ignored Sep 29, 2026 10:07pm UTC

Request Review

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review is generated by Claude. Flag anything you think is wrong and I will explain the reasoning.

Solid PR. One list, generated vercel.json, a drift test, a one-hop test, a no-duplicate test, and a build gate — the invariants that matter are encoded rather than asserted by convention. I verified that all 31 pre-existing Vercel rows survive the regeneration byte-for-byte except the deliberate MiniMax status change, that no source shadows a built page, that every old-slug source is a literal path with no path-to-regexp metacharacters, and that 793 redirects is well under Vercel's documented 2,048 cap. All checks are green including website-build, so the release gate is not tripping on any current page.

Severity Count
BLOCKER 0
SHOULD FIX 3
TRIVIAL 2

Deploy risk — read this one first

720 of the new rows are 308s, and a 308 is cached by the client. The destination is currently routed to /workflows by comfy-router. If this ships ahead of comfy-router#46 by any margin, every visitor who touches an old model URL in that window pins a permanent redirect to a page they cannot reach, and no amount of Cloudflare purging retracts it — it lives in their browser. The PR description already calls for a coordinated deploy, which is right, but the plan has no recovery path if the ordering slips. temporaryBecause already exists in the row type; shipping the model rows as 307 and flipping to 308 in a follow-up costs one deploy and removes the only unrecoverable outcome here.

Coverage

Dropping the hub rows from the Astro map is correct for the build, but it silently neutered the disabled-model guard in e2e/models-catalogue-corrections.spec.ts — that test now asserts a 404 that every slug returns. And the new build gate reads HTML only, so the catalogue/page JSON and the markdown twins are outside it. Details inline.

Scale note (no action needed now)

793 literal rules are evaluated at the edge on every request to comfy.org, not just on old model URLs. Vercel now ships bulkRedirectsPath for exactly this shape — thousands of simple literal redirects, explicitly described as performant at scale, generated at build time into CSV/JSON/JSONL. toVercelRedirects already produces the right rows; it would be a small change to the sync script if this list keeps growing.

Done well

  • temporaryBecause / slashFormIsPageBecause as required prose rather than a boolean — the reason a row is unusual cannot be dropped silently.
  • Migrating the Astro-only rows into vercel.json upgrades ~16 meta-refresh stubs into real edge redirects.
  • p/supported-models aliases moving from a runtime Astro.redirect to getStaticPaths filtering plus a real 308 is a strict improvement.
  • The "reaches every destination in one hop" test is the right invariant to encode, and buildModelsUrlRegistry already throws on alias/page collisions.

Comment thread apps/website/src/config/redirects.ts Resolved
Comment thread apps/website/src/config/redirects.ts Resolved
Comment thread apps/website/src/config/redirects.ts Resolved
Comment thread apps/website/src/config/redirects.ts Resolved

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review is generated by Claude. Flag anything you think is wrong and I will explain the reasoning.

Re-reviewed the three new commits (10bcbb0, a128f6d, 37d49e5) against my previous round. All five threads are genuinely addressed — not acknowledged, addressed — and I verified each one rather than taking the commit message for it.

Severity Count (this round)
BLOCKER 0
SHOULD FIX 0
TRIVIAL 2

What I verified

  • 307 flip (10bcbb0). Diffed the regenerated vercel.json against the previous head: exactly 722 rows changed, all permanent: true -> false, all destinations byte-identical, zero non-model rows touched, row count still 793. The seven pre-existing temporary rows are untouched. The unrecoverable failure mode is gone — a 307 is not client-cached, so a slipped router deploy is now fully retractable.
  • Gate coverage (a128f6d). The regex gained "href":" and ]( branches; modelsDataFiles sweeps dist/models/** for catalogue.json and page.json; each page's markdown twin is read alongside its HTML. Confirmed markdown-twin.ts emits [text](url) with absolute() URLs, so the ](https://comfy.org/models/...) form the new test uses is the form actually produced. The new gate tests write a clean variant and assert it passes before writing the dirty one, so they cannot silently rot into no-ops.
  • Disabled-model guard (37d49e5). Now asserts absence from hubModelSlugs/hubModelAliases plus a 404 at /hub/models/<slug>/. That is an assertion only a correct build satisfies, unlike the old one.
  • Identity filter. isOldModelsAddress replaces hubModelRedirects.includes(row).
  • Description. The MiniMax 307->308 flip and the follow-up "flip back to permanent" step are both written down now.

Nice extras I did not ask for: the /models/:path* catch-all hazard is captured as both a code comment and a test (never adds a /models catch-all), and filesLinkingOldModels reports the offending file path rather than the page pathname, which is more useful when the hit is in a JSON blob.

Two trivia inline, neither blocking. CI is still running on the new head — assuming it stays green, this is good to go.

Follow-up owner

The 307 -> 308 flip after comfy-router#46 goes live is now the only loose end, and it lives in a PR-description checkbox. If FE-2972 closes on merge, that checkbox stops being visible to anyone. Worth a Linear ticket rather than a checkbox.

Comment thread apps/website/src/config/hub-models.ts Resolved

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review is generated by Claude. Flag anything you think is wrong and I will explain the reasoning.

Re-reviewed the one new commit (a6e8610) since my approval at 37d49e5. Both trivia addressed, nothing new found, approval stands.

Severity Count (this round)
BLOCKER 0
SHOULD FIX 0
TRIVIAL 0

Regex fix. Rather than take the test's word for it, I re-ran the new pattern against a full case matrix outside the suite. Every previously-matching form still matches — HTML href="...", query-suffixed, absolute https://comfy.org, bare /models, /models/, compact JSON, markdown ](...) both relative and absolute — /hub/models/... and /modelsfoo/ are still correctly ignored, and pretty-printed "href": "..." now matches. No regression from the added \s*.

Scope. vercel.json is byte-identical to the previous head (793 rows, zero added, removed or changed), which confirms this commit touches only the gate's detection logic and not the generated output.

Twin ordering. Agreed on the comment-only resolution. With 484 intentionally twin-less pages, a per-page hard failure would flag real pages and the guard would get weakened or deleted within a week. Naming the dependency in a one-line comment is the right weight.

Two coordination notes, neither blocking this PR

  1. MiniMax is now a moving target across PRs. This branch's vercel.json still has /minimax and /zh-CN/minimax as 308. Per your reply, #19359 is taking them back to 307 pending the page owner's sign-off. When that lands, this branch needs a re-merge plus another sync:redirects — the drift test will catch it at merge time rather than letting it through, so this is a scheduling note, not a risk.
  2. The 307 -> 308 flip after comfy-router#46 is still only a PR-description checkbox. You noted that follow-up PR does not exist yet. Once FE-2972 closes on merge, that checkbox stops being visible to anyone. A Linear ticket would outlive the merge; otherwise the old URLs quietly never consolidate.

CI is still spinning up on the new head — the website jobs have not registered yet. Everything was green at 37d49e5 and this delta is a regex plus a test case with identical build output, so I do not expect a surprise, but worth a glance before merge.

Merge order unchanged: #19359, then #19421, then this, deployed in the same window as comfy-router#46.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review is generated by Claude. Flag anything you think is wrong and I will explain the reasoning.

Re-reviewed the one new commit since my approval at a6e8610. It is 45bd0e1 — a base sync merging origin/maanil/fe-2972-hub-serve, no new work of its own. All review threads remain resolved. Re-approving so the approval sits on the current head.

Severity Count (this round)
BLOCKER 0
SHOULD FIX 0
TRIVIAL 1 (inherited from the base branch)

What I checked, since a base sync into a redirect-generating branch is exactly where drift hides

The generated output cannot have drifted. siteRedirects is derived from three files, and I confirmed all three are byte-identical across the merge: model-urls.ts, models.ts, redirects.ts. vercel.json is likewise untouched. So toVercelRedirects(siteRedirects) is unchanged and the drift test still holds without a re-run of sync:redirects.

hub-models.ts changed, but not in a way this PR depends on. The merge rewrote hubModelHref to throw for a slug with no built page instead of silently falling back to hubModelPath(oldSlug). hubModelSlugs, hubModelAliases and hubModelPath are identical, and oldModelLinks/oldModelPaths are untouched. hubModelRedirects builds from the maps via hubModelPath, never via hubModelHref, so every slug it passes is present by construction — the new throw is unreachable from this PR's code path.

The href-now-optional ripple is handled. RouterWorkshopModel.href became optional so disabled models carry no link, and the four call sites that could have produced undefined are all guarded (WorkshopModelsGrid.vue, WorkshopSections.vue, model-release-links.ts, featured-slides.ts). For the gate this is a non-event: an absent href key is simply nothing to scan in catalogue.json.

The catch-all guard got better. The merge replaced my [:*()] proxy assertion with a sourcePattern simulation that expands [...slug] and :path* and tests the real data paths, plus a meta-test proving the matcher is not vacuous. That tests the actual harm rather than a symptom — strictly better than what I suggested, and it directly pins the /models/<slug>/page.json coupling.

One trivial gap, inherited from the base branch

dataPaths in the new model page data suite covers /models/catalogue.json and modelPageUrls, but not the workflow pages. page.json is built for all of workshopPages, so /models/workflows/<slug>/page.json exists and is fetched by fetchModelsPage, yet a hypothetical /models/workflows/:x* rule would slip past the guard. One extra spread into dataPaths closes it. This arrived via the base branch rather than this PR, so fix it wherever is convenient — it is not a reason to hold this up.

(Unescaped . in sourcePattern I checked and deliberately did not flag: it only makes patterns more permissive, so it can produce a noisy failure but never a missed swallow.)

CI is mid-run on the new head (19 pending). Given the merge carries no change to any redirect input, I expect it green.

Merge order unchanged: #19359, then #19421, then this, deployed in the same window as comfy-router#46. The two open coordination items from my last pass still stand: the MiniMax status is being revisited in #19359, and the 307 -> 308 flip after comfy-router#46 is still only a PR-description checkbox rather than a ticket.

…ects

# Conflicts:
#	apps/website/scripts/generate-model-url-map.test.ts
#	apps/website/src/config/redirects.test.ts

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review is generated by Claude. Flag anything you think is wrong and I will explain the reasoning.

Re-reviewed the one new commit since my approval at 45bd0e1. It is acd5f676 — another base sync, no new work authored on this branch. All threads remain resolved. Re-approving on the current head.

Severity Count (this round)
BLOCKER 0
SHOULD FIX 0
TRIVIAL 0

The drift risk I flagged last round materialised, and was handled correctly

This sync brought #19359's MiniMax reversal down from the base: /minimax and /zh-CN/minimax go back to temporary, with the reason now spelled out (/minimax/ is a live namespace, the license pages sit under it, both locales flip together on the page owner's sign-off). The thing I actually wanted to check is that vercel.json was re-synced in the same commit rather than left to fail the drift test later — it was. Exactly four rows changed, permanent: true -> false, nothing else in the file moved.

Post-merge state of the generated config: 793 rows, zero duplicate sources, 722 model rows all temporary, 733 temporary total (722 model + 7 pre-existing + 4 MiniMax), zero sources containing :, *, ( or ), zero non-literal sources.

Merge resolution checked artifact by artifact

A sync this large across files both branches edit is where work silently disappears, so I confirmed each of this PR's contributions is still present at head rather than trusting the diffstat:

  • hubModelRedirects with temporaryBecause: HUB_ROUTER_PENDING on /models and all 361 slug rows.
  • oldModelLinks with all three prefixes and the \s* fix.
  • filesLinkingOldModels plus modelsDataFiles, the markdown-twin read, and the ordering comment.
  • isOldModelsAddress in the astroRedirects filter.
  • /models still removed from modelsBuildRoutes, both e2e specs still pointed at /hub/models.

The base's new assets-based leak check merged cleanly alongside the link gate, and models-url-registry's exports are unchanged, so nothing this PR imports shifted under it.

A nice consequence of the two branches converging

The base added never shadows a built page with a slash form — the general guard I noted was missing on my first pass. It derives builtPages partly from modelsBuildRoutes(true), and the base's unbuilt check derives from modelsBuildRoutes(false). Both now depend on this PR having removed /models from that list: leave it in while the page stops building and one of them fails; take it out without stopping the build and the other does. The two halves of this change now cross-check each other instead of each being asserted on its own. That is a better place to land than where this started.

One non-issue, noted so it is not mistaken for scope creep

The raw commit delta looks alarming — ~23k insertions across 271 files, most of it full-page billing checkout, cinematic studio and telemetry work. That is the base branch catching up with main, not this PR. This PR's own diff against its base is 14 files and 3,877 additions, of which 3,610 are the generated vercel.json. The reviewable surface is unchanged.

CI is mid-run on the new head (20 pending, no failures). The surface it now has to clear is much larger because of the base sync, so worth a real look at the result rather than assuming, but nothing in the redirect path changed beyond the four MiniMax rows.

Merge order unchanged: #19421, then this, deployed in the same window as comfy-router#46. #19359 has landed in the base. The only open item from my earlier passes is still the 307 -> 308 flip after comfy-router#46 — the MiniMax handling here is a good argument for tracking it as a ticket rather than a description checkbox, since that is the second status flip on this branch that needed a coordinated follow-up.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review is generated by Claude. Flag anything you think is wrong and I will explain the reasoning.

Re-reviewed the one new commit since my last pass. It is d92f80e3 — a third base sync, no work authored on this branch. All threads remain resolved. Re-approving on the current head.

Severity Count (this round)
BLOCKER 0
SHOULD FIX 0
TRIVIAL 0

This one looked like the drift failure, and isn't

The sync touches four files, and one of them is model-urls.ts — the generated source that hubModelSlugs and hubModelAliases are built from, and therefore the origin of all 722 model rows in vercel.json. It changed by 451 lines. vercel.json did not change at all.

That is the exact shape of a missed sync:redirects, so I did not take the diffstat's word for it. Extracting every oldSlug, newSlug and alias literal from both revisions gives 720 values on each side, and they are byte-identical. The entire 451-line change is the generator learning to emit a name display field (148 rows plus the type declaration) and the trailing-comma reflow that comes with it. No redirect source moved, no destination moved, so toVercelRedirects(siteRedirects) is unchanged and vercel.json is correctly untouched.

Worth saying plainly because the next reviewer will hit the same thing: a large diff in model-urls.ts is only dangerous when it moves a slug. It is also the case that if a future regeneration did move one, the drift test would fail rather than ship a wrong redirect — the safety net is in the right place.

Everything this PR owns is untouched

redirects.ts, hub-models.ts, workshop-release-gate.ts, redirects.test.ts and vercel.json are all byte-identical across the merge. The only file in the delta that this PR also edits is scripts/generate-model-url-map.test.ts, where the base rewrote 73 lines; the merge kept this PR's astroRedirects -> siteRedirects switch in sitePathPatterns(), which is still the correct source now that the old-model rows are deliberately absent from the Astro map.

The new name field is inert here: hubModelSlugs and hubModelAliases read oldSlug/newSlug/alias only, so nothing downstream of this PR sees it.

CI is mid-run (15 pending, no failures).

Merge order unchanged: #19421, then this, deployed in the same window as comfy-router#46. The 307 -> 308 flip afterwards remains the one open item, still tracked only as a PR-description checkbox.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review is generated by Claude. Flag anything you think is wrong and I will explain the reasoning.

Re-reviewed the one new commit since my last pass. It is a531ba39 — a fourth base sync, no work authored on this branch. All threads remain resolved. Re-approving on the current head.

Severity Count (this round)
BLOCKER 0
SHOULD FIX 0
TRIVIAL 0

The delta is two files, both base-branch work on the model-url-map generator: stringLiteral() replaces the old v.replace(/[\\']/g, '\\$&') escaper, and a round-trip test transpiles the generated module and checks the string survives. Neither is this PR's code, but both sit upstream of model-urls.ts, which is upstream of every redirect row here, so I read them properly rather than skipping on ownership.

The escaper is correct. I traced the one branch that looked risky — .replace(/\\"/g, '"') running over a JSON-escaped body, where a literal backslash immediately before a quote could in principle be mis-paired. It cannot: JSON.stringify doubles every backslash, so any real \" in the body is always preceded by an even run, and a left-to-right scan pairs them off correctly. I walked a\"b, a\\", and the mixed-quote cases by hand and each round-trips. The quote-choice heuristic also minimises escaping in the right direction. The new test covering newline, backslash, tab, CR and U+2028 by actually executing the emitted module is a stronger check than asserting on the string, and is the right shape for a codegen escaper.

Nothing downstream moved: model-urls.ts, vercel.json, redirects.ts, hub-models.ts, workshop-release-gate.ts and redirects.test.ts are all byte-identical across the merge. The generator was hardened but not re-run, so the 720 slug values and all 793 generated rules are untouched.

One forward-looking note, not a defect: the checked-in model-urls.ts was produced by the old escaper. The next generate:model-url-map run may re-quote some name fields — a diff confined to display names, never to a slug — so it cannot invalidate vercel.json. Worth knowing so the diff is not mistaken for drift when it appears.

This PR's astroRedirects -> siteRedirects change in sitePathPatterns() survived the merge intact, alongside the base's 28 new lines in the same file.

CI is mid-run (14 pending, no failures).

Merge order unchanged: #19421, then this, deployed in the same window as comfy-router#46. The 307 -> 308 flip afterwards is still the one open item and still only a PR-description checkbox.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review is generated by Claude. Flag anything you think is wrong and I will explain the reasoning.

Re-reviewed the one new commit since my last pass. It is 4491f428 — a fifth base sync. All threads remain resolved. Re-approving on the current head.

Severity Count (this round)
BLOCKER 0
SHOULD FIX 0
TRIVIAL 0

The entire delta is three added cases to the base's renderModelUrlsModule round-trip test: Veo "3" Text-to-Video, back\"quote, and ''\". Those are, almost exactly, the three cases I traced by hand last round when arguing the new stringLiteral() escaper could not mis-pair a backslash sitting before a quote. Good to see them pinned as tests rather than left resting on a reviewer's argument — the third one in particular is the quote = " branch with a preceding backslash, which is the only genuinely subtle path through that function.

Since I had asserted correctness from a hand-trace, I checked it properly this time: I extracted stringLiteral() as it stands at head and round-tripped it through eval over the six cases in the test plus twelve adversarial ones of my own — empty string, lone backslash, lone quote of each kind, three consecutive backslashes, a\\"b, '''\\", mixed quotes with a trailing backslash, U+2028/U+2029, NUL, and an astral-plane emoji. All eighteen round-trip exactly. The quote-choice heuristic also picks the cheaper delimiter in every mixed case.

One incidental finding, not a defect: JSON.stringify leaves U+2028 as a literal character rather than escaping it, so a name containing one would be emitted raw into model-urls.ts. That is valid since ES2019 and the test proves it round-trips through an actual transpile-and-execute, so nothing to do — noting it only because it is the single place the escaper leans on a language guarantee instead of escaping defensively.

Nothing this PR owns moved: vercel.json, model-urls.ts, redirects.ts, hub-models.ts, workshop-release-gate.ts, redirects.test.ts and the generator itself are all byte-identical across the merge. This PR's astroRedirects -> siteRedirects change in sitePathPatterns() survived intact.

The thing actually worth attention now

This is the fifth base sync in roughly seventy-five minutes, and each one cancels the in-flight checks. Right now lint, typecheck, typecheck-aux and website-build are all still pending, and website-unit and website-e2e have not even registered on this head. Those are the jobs that would run the vercel.json drift test and the release gate — the two mechanisms this whole change depends on.

Every conclusion I have reached over these rounds came from reading the artifacts directly, and I stand behind them, but that is not the same as the suite having actually executed. Please let the gating jobs finish on a stable head before merging rather than treating the approvals as the green light.

Merge order unchanged: #19421, then this, deployed in the same window as comfy-router#46. The 307 -> 308 flip afterwards is still the one open item and still only a PR-description checkbox.

@github-actions github-actions Bot added risk:high PR risk grade (advisory shadow check; grader-owned) and removed risk:xhigh PR risk grade (advisory shadow check; grader-owned) labels Sep 29, 2026
Old /models addresses are vercel.json 307s, so astro preview no longer
serves a page there. Assert the deployed redirect rows and that the
destination renders.
@MaanilVerma MaanilVerma changed the title feat(website): move model pages to /hub/models (step B2 of 2): 308 every old URL feat(website): move model pages to /hub/models (step B2 of 2): redirect every old URL (307 first, 308 after router #46, FE-3083) Sep 29, 2026

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review is generated by Claude. Flag anything you think is wrong and I will explain the reasoning.

Two new commits since my last pass: 2c5666d1 (sixth base sync) and 2b3389b5, the first authored change in five rounds. Approving.

Severity Count (this round)
BLOCKER 0
SHOULD FIX 1 (against FE-3083, not this diff)
TRIVIAL 1

FE-3083 closes the item I have been repeating for four rounds

I read the ticket rather than taking the title reference on faith. It is better than what I asked for: it names the exact rows and file, covers the 60 workflow rows from #19424 as well as the 722 here, explicitly scopes /minimax out with a reason, and gates the flip on four concrete preconditions including curl -sI https://comfy.org/hub/models/ answering 200 rather than redirecting to /workflows, plus a 24-hour no-rollback hold and a GSC Live Test. High priority, assigned, in the SEO milestone. That is a real runbook, not a placeholder. Changing the body from "Fixes FE-2972" to "Part of FE-2972" is the right call too — it stops the merge from closing the parent while B3 is outstanding.

CI caught a regression the base sync introduced, and the fix is correct

Worth recording precisely, because I initially suspected I had missed this for six rounds and it turns out I had not. At my first review head the alias test navigated to /hub/models/flux-2-max-text-to-image/ and website-e2e passed. A later base sync changed it to page.goto('/models/bfl--flux-2-max/') with expect(status).toBe(200) — correct on B1, where alias stubs still build, and necessarily a 404 once B2 stops building them. website-e2e then failed on 4491f42808 (shard 4 of 4, 21:38Z), about half an hour after I approved that head while the suite was still pending. That is exactly the case I flagged last round when I said not to treat the approval stack as the green light, so the warning earned its keep and the process worked.

website-build is now green on this head; website-unit is running and the e2e shards are queued.

One completeness gap, against the ticket rather than the code

FE-3083's verification section says "the redirect drift test passes and no hub row has temporaryBecause". Dropping temporaryBecause will actually turn three test sites red, not one:

  • redirects.test.ts:169 / :175 — the it.for titled "...temporarily until comfy-router#46 is live", asserting permanent: false.
  • redirects.test.ts:263 — it('each redirect once, temporarily, ...'), whose predicate inverts on rows[0].permanent.
  • e2e/workshop.spec.ts:418 / :432 — the test added in this commit, asserting permanent: false.

None of those are wrong today; pinning the status deliberately is the right choice for a decision this consequential. But whoever executes FE-3083 should know the edit spans four files, so a red suite mid-follow-up is expected rather than a sign something broke. Worth a line in the ticket.

Nothing else this PR owns moved across either commit, and the sixth sync's widening of the CI Workshop-off parity check from find dist/models to every registry root via list:models-pages is a change this PR arguably required — the old baseline would have gone empty once the model pages left /models.

Comment thread apps/website/e2e/workshop.spec.ts Resolved
@MaanilVerma

MaanilVerma commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator Author

QA (2b3389b): CI: Website E2E run 36635648690 passed all four shards. The previous head failed shard 4 on workshop.spec.ts:406 with 404 ≠ 200. Follow-up 356ea8f renames the test and drops its vercel.json check, which redirects.test.ts already covers (26/26). Locally on the B3 build, workshop.spec.ts passed 33/33.

@MaanilVerma

MaanilVerma commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator Author

About the e2e change: "a static compatibility alias reaches its canonical model page" used to open /models/bfl--flux-2-max/ in astro preview and expect a 200. This PR stops building pages and stubs under the old /models addresses, and those addresses are now Vercel redirects in vercel.json. astro preview does not apply vercel.json, so that URL is a 404 there, which is why shard 4 failed on run 36629931314.

The redirect itself is covered at the config level. redirects.test.ts "old Models addresses" requires every alias, bfl--flux-2-max included, in both slash forms, to have exactly one temporary row that lands on a built page (307 until FE-3083). It also asserts that vercel.json equals toVercelRedirects(siteRedirects). The e2e test is now "the hub page an old alias points at renders" (356ea8f): it opens /hub/models/flux-2-max-text-to-image/ and expects a 200 and the h1 "FLUX 2 Max Text-to-Image". Between them, the two tests cover the path the old test covered: the unit test covers the part Vercel owns, and the e2e covers the part the site owns.

redirects.test.ts already pins every old alias row in vercel.json, so the
e2e only checks the destination page renders.
@datadog-official

This comment has been minimized.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review is generated by Claude. Flag anything you think is wrong and I will explain the reasoning.

Two new commits since my last pass: 1137e3c4 (seventh base sync) and 356ea8f7, which addresses the one trivial note I left. Approving.

Severity Count (this round)
BLOCKER 0
SHOULD FIX 0
TRIVIAL 0

The gating suite is green for the first time

This is the thing I have been withholding confidence on for several rounds, so worth stating plainly. On this head: website-build, website-unit, website-e2e and all four e2e shards, typecheck, typecheck-aux, lint, lint-and-format and json-lint have all completed successfully. Shard 4 of 4 — the one that went red on 4491f42808 after the base sync reverted the alias test — now passes.

Every conclusion I reached in earlier rounds came from reading artifacts directly, which was the right thing to do while the suite kept getting cancelled, but it is not the same as the drift test and the release gate actually executing. They have now executed. The 33 still-pending checks are the broader monorepo jobs pulled in by the base sync, not website gating.

The trivial note was addressed, and the reasoning behind it checks out

The alias e2e is now the hub page an old alias points at renders: it loads the destination, asserts 200 and the h1, and the vercel.json assertion plus its zod schema and imports are gone. I verified the claim that this loses no coverage rather than accepting it — bfl--flux-2-max sits in modelAliasUrls at model-urls.ts:770 mapping to flux-2-max-text-to-image, all four of its rows in vercel.json are 307s to that destination, and the old Models addresses unit test walks every hubModelAliases key in both slash forms requiring exactly one non-permanent row that lands on a registered model or hub page. The dropped assertion covered one alias; what remains covers all 361 sources. The split is now clean: configuration asserted in unit tests, rendering asserted in the browser.

The base sync's other change is list-models-pages.ts resolving dist from the script's own location instead of process.cwd(). Same result under pnpm --filter, which is how CI invokes it, but correct from any working directory — a small strictly-positive change.

Nothing this PR owns moved across either commit: vercel.json, redirects.ts, hub-models.ts, workshop-release-gate.ts, redirects.test.ts and model-urls.ts are all byte-identical.

Where this leaves the merge

No open review items. FE-3083 carries the 307 -> 308 follow-up with real preconditions. The one thing I would still add to that ticket, repeating it here only because it is the last loose thread: dropping temporaryBecause will turn redirects.test.ts:169/175, redirects.test.ts:263 and the surviving e2e expectations red, so the follow-up edit spans more than the drift test its verification section names.

Merge order unchanged: #19421, then this, deployed in the same window as comfy-router#46, then purge the Cloudflare cache for /hub/models and /hub/models/.

pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 30, 2026
## Summary

**Deploy gate: comfy-router#46 is merged and live (2026-09-30). Its
follow-up comfy-router#48 (serves `/hub/models.md` instead of 301ing it
to a /workflows 404) must be deployed before this merges. After the
merge, purge Cloudflare for `/hub/models*`, `/hub/workflows*` and the 30
workflow names in `hub-workflow-names.json`. The redirects ship as 307;
FE-3083 flips them to 308 later.**

This branch combines every Workshop /models SEO PR, so merging it to
main replaces merging them one by one. It also launches: Comfy-Org#19405 commits
`launchedModelPages = 'all'`, so all 148 model pages become indexable in
the same deploy as the URL move.

Part of FE-2912, FE-2942 (PR 2 is FE-3086), FE-2974 (/minimax 308 is
FE-3087)
Fixes FE-2978, FE-2989, FE-2991, FE-2990, FE-2959, FE-2981, FE-2977,
FE-2979, FE-3014, FE-2936, FE-2980, FE-2975, FE-3085, FE-2972, FE-2935,
FE-2950, FE-2940, FE-2930, FE-2985, FE-2957, FE-2961, FE-2986, FE-2921,
FE-2922, FE-2947

## Changes

Router follow-up: comfy-router#48 (`/hub/models.md` routing, 324/324
router tests), deploy before this merges.


The included PRs, in merge order. Every head was checked as contained at
the final tip.

| PR | Ticket | What | Ben |
|---|---|---|---|
| Comfy-Org#18887 | FE-2978 | Pricing Product markup and full video `uploadDate`
| approved |
| Comfy-Org#18889 | FE-2989 | A unique meta description on every model page |
approved |
| Comfy-Org#18890 | FE-2991 | Model page JSON-LD, emitted once noindex lifts |
approved |
| Comfy-Org#18892 | FE-2990 | Cleaner tag pills, guard against duplicate
summaries | approved |
| Comfy-Org#18893 | FE-2959, 2981, 2977, 2979 | Social tags, hub title,
Organization data. The FE-2977 title was confirmed by the owner |
approved |
| Comfy-Org#19362 | FE-3014 | Every non-production build is noindex | approved |
| Comfy-Org#19366 | FE-2936 | Model titles lead with "API & Playground" |
approved |
| Comfy-Org#19402 | FE-2980 | Every internal link ends with a slash, plus a CI
check | approved |
| Comfy-Org#19419 | FE-2975 | Footer links the catalogue on every page and locale
| approved |
| Comfy-Org#19476 | FE-3085 | `NOINDEX_ROUTES` decides noindex for
serverless-animation | approved; re-approval pending on a one-line
follow-up (CodeRabbit approved) |
| Comfy-Org#19359 | FE-2974 | One typed redirect list that generates
`vercel.json` | approved |
| Comfy-Org#19369 | FE-2972 A | The old to new model URL map | approved |
| Comfy-Org#18891 | FE-2935 | Model content shows whatever the flag says |
approved |
| Comfy-Org#18899 | FE-2942 | Model pages render in the static HTML | approved |
| Comfy-Org#18898 | FE-2950 | Catalogue h1 and A to Z links in the static HTML |
approved |
| Comfy-Org#19375 | FE-2940 | Related models leave no page unlinked | approved |
| Comfy-Org#19385 | FE-2930 | Examples show the prompt that made them | approved
|
| Comfy-Org#19394 | FE-2985 | Render guard e2e: no loader, no layout shift |
approved |
| Comfy-Org#19357 | FE-2957 | robots.txt stops blocking our scripts and styles |
approved |
| Comfy-Org#19360 | FE-2961 | Turning Workshop off keeps every Models page |
approved (a CodeRabbit changes-requested review is still open) |
| Comfy-Org#19386 | FE-2986 | One registry of every Models address | approved |
| Comfy-Org#19421 | FE-2972 B1 | Model pages served at `/hub/models` | approved |
| Comfy-Org#19422 | FE-2972 B2 | Every old model URL redirects (307) | approved |
| Comfy-Org#19424 | FE-2972 B3 | Workflow pages at `/hub/workflows` with
redirects | approved |
| Comfy-Org#19399 | FE-2921 | One switch decides model robots and sitemap listing
| approved |
| Comfy-Org#19404 | FE-2922 | Clean markdown twins for model pages | approved |
| Comfy-Org#19405 | FE-2947 | Lifts noindex on every canonical model page |
approved |
| comfy-router#46 | FE-3075 | Serves `/hub/models*` from the website and
routes `/hub/workflows` by manifest. Merged and live | merged |

These fixes exist only on this branch, because they only break once two
PRs meet:

- `scripts/check-models-html.ts` reads each page at `model.href` and
skips models without a page (f1df1e4).
- `e2e/fixtures/modelsCatalogue.ts` reads `dist/hub/models`
(f87bb4c).
- `routerIdsByModelPage` accepts an optional `href`, since Comfy-Org#19421 made
it optional and Comfy-Org#19405 no longer typechecked (9783819).
- `ModelStatus` links a successor only when it has a page, for the same
reason on Comfy-Org#18899 (c4761d8).
- The model breadcrumb in `modelJsonLd.ts` points at `/hub/models/`
instead of the `/models/` redirect (eb985b6). Its label still says
"Models" while the nav says "Hub".
- Twin, meta-description and entry tests use the hub pages and the new
tag set (86ac3b0, d4ffc0f).
- The render guard finds the catalogue through `getRoutes().workshop`,
and its `test.fail` is gone now that Comfy-Org#18898 renders the h1 (831499f).
- A new test renders a real model page and checks its markdown twin has
the model's h1 (9a6c5cb).
- Main's newer catalogue and workflow e2e cases use the hub addresses
(2aeda77).
- `resetWorkshopAccountSource` resets `decision`; a clean auto-merge of
main's Comfy-Org#19454 into Comfy-Org#18891 left it assigning a variable that no longer
exists (c28c7a7).

The conflict resolutions, briefly: `ALTERNATE_TWIN_SOURCES` stays
deleted as Comfy-Org#18898 wants, so `/hub/models.md` comes from the real
catalogue. The hub keeps Comfy-Org#18898's single static h1 instead of the
`WorkshopHero` h1 that main's Comfy-Org#19320 added. `ExamplesTab` keeps Comfy-Org#19385's
figure and caption with main's video poster. The Comfy-Org#19399/Comfy-Org#19405 indexing
tests were rewritten for hub paths. The Comfy-Org#19359 redirect test no longer
builds `/enterprise//` from slash-ended routes. The Comfy-Org#19369 URL-map test
imports `PROVIDER_NAMES` from its new home. The full table of 47
resolutions is in the integration report.

## Review Focus

- Launch rides along with the URL move. If launch should stay a separate
step, set `launchedModelPages` in
`apps/website/src/config/model-page-launch.ts` to `new Set()` before
merging.
- Main's Comfy-Org#19320 gives the catalogue island its own h1 through
`WorkshopHero`. This branch keeps Comfy-Org#18898's static h1 and renders only
the subtitle in `ModelsCatalogue.vue`, so the hub has exactly one h1.

- Comfy-Org#19476 overlaps the open community PR Comfy-Org#18591 (same sitemap exclusion
for serverless-animation). One of them should be closed once this lands.

## QA

- [x] Gates: `pnpm typecheck` and website typecheck clean, `pnpm lint` 0
errors, eslint on `apps/website` clean, `pnpm knip` clean
- [x] Website unit: 547 files, 10347 passed, 4 skipped
- [x] Build A (`build:e2e`, CI env): 1193 pages; release gate,
`check:hreflang`, `validate:llms-txt-links` (225 links),
`validate:jsonld` (947 pages), `check:link-slashes`, `check:models-html`
(148 pages) all pass
- [x] Build B (`WORKSHOP_IN_BUILD=0`): same 182 Models pages as the on
build, no `dist/workshop`, `/` is noindex; with the flag stubbed on, no
Run, no Hub nav and no Firebase requests
- [x] Build C (preview shape): 945 of 945 pages noindex, no canonicals
except redirect stubs, no hreflang in the sitemap
- [x] E2E on Build A: 644 of 645 passed; the one mobile failure passed
on rerun. Earlier load flakes (navigation, demos, fdct, wan-3.0, network
isolation, render guard) all passed when rerun alone
- [x] Launch: 148 model pages indexable with canonicals, 149 hub entries
in the sitemap, 148 non-empty twins with the model h1, 148 in
`llms-full.txt`, 0 titles over 60, 30 workflow pages still noindex
- [x] Redirects: 853 rules, 782 to /hub all 307, the MiniMax rows 307,
every /hub destination built
- [x] comfy-router#46 under `wrangler dev` in front of this build: 312
router tests pass; 148 old model URLs (both slash forms) 307 then 200;
30 workflow names served by the website and their old URLs 307; a
non-manifest workflow 302 with no-store; `manifest.json` passes through;
`/workflows/` and bare `/hub` unchanged
- [x] After the router deploys and this merges: purge Cloudflare, then
curl `https://comfy.org/hub/models/` for a 200 and three old
`/models/<slug>/` URLs for one 307 each
- [x] Rich Results Test on `/pricing/` and
`/learning/animations/character-sheet/`, then "Validate fix" on Merchant
listings and Videos
- [x] Rich Results Test on two live model pages: breadcrumbs valid and
the breadcrumb URL returns 200 with no redirect
- [x] GPTBot and Googlebot curls on the hub and one model page, then a
GSC live test on both
- [x] Resubmit the sitemap in Search Console and URL-inspect about 20
model pages on day 0 and day 14
- Not covered: Rich Results and GSC need production; the redirect matrix
used a local shim for `vercel.json`, since `astro preview` ignores it

---------

Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: benjcooley <benjcooley@gmail.com>
Co-authored-by: Deep Mehta <42841935+deepme987@users.noreply.github.com>
@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

Superseded by the integration branch #19494, which combined this PR with every other Workshop SEO slice and has been merged to main. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger multi-model Cursor agent review on this PR risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants