Repository navigation
test(website): drop whole-route JS ceiling from models catalogue budget - #19669
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
🌐 Website E2ETip All tests passed.
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since b01e5bf488e4873fc891229b3ba5a0da4102d06c
Full docs: ADR-DEVEX-LINT-0015 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-19669.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-2qc95spaz-comfyui.vercel.app Last updated: 2026-09-30T21:35:40Z for |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Repository guideline files applied to this review (4)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC. 📝 WalkthroughWalkthroughThe catalogue performance test still checks scripts loaded on ChangesCatalogue JavaScript budget
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change removes a brittle shared-layout limit while retaining the catalogue-specific performance budget, with no concrete merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19669 +/- ##
==========================================
- Coverage 84.54% 84.43% -0.11%
==========================================
Files 3357 3284 -73
Lines 161826 159607 -2219
Branches 44034 43297 -737
==========================================
- Hits 136812 134769 -2043
+ Misses 23104 23038 -66
+ Partials 1910 1800 -110
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…rg#19364) ## Summary Attach an installer dropdown to the download hero's primary button so visitors can choose a different desktop installer. ## Changes - **Dependencies**: Targets main. The unrelated Router fixture and checkout PRs have been removed from this stack. - Offer Windows x64/ARM64, macOS Apple Silicon, and Linux x64 AppImage from one installer table; share selected installer records and platform icons between the button and menu. - Share the primary button's device-detection gate; retain phone email capture and the existing plain ecosystem download button. - Translate the menu into English and Chinese, label Windows x64 consistently, and identify the NVIDIA-only ARM64 build. Retain platform-level download analytics. ## Review Focus - Unknown desktops retain both Windows and macOS fallback buttons, with one dropdown attached to the first. - The final two-PR stack passes 36 focused installer/composable unit tests. The dropdown fix also passed 43 focused unit tests and 25 download browser tests before this final restack. Current main includes Comfy-Org#19669, which retains the catalogue-only JavaScript budget and removes the unrelated whole-route ceiling. No checkout prerequisite remains. CI has not been checked after this final restack. ## Screenshots (if applicable) [Preview](https://comfy-website-preview-pr-19364.vercel.app/download/) Before <img width="1425" height="891" alt="Download hero before the dropdown" src="https://github.com/user-attachments/assets/00c4ebc5-0c11-4525-adf0-5f2ed7c1f472" /> Existing after capture, before the concise x64 copy update: desktop <img width="1680" height="1003" alt="Installer dropdown with hardware requirements" src="https://github.com/user-attachments/assets/115f5288-0ba2-48ad-b4b7-133d5e983842" /> Existing after capture, before the concise x64 copy update: narrow 320px viewport <img width="320" height="844" alt="Installer dropdown at 320 pixels" src="https://github.com/user-attachments/assets/59c9ad4d-dbd0-4e6c-b1c9-2b92ac953c49" /> Existing after capture, before the concise x64 copy update: Chinese <img width="1680" height="1003" alt="Chinese installer dropdown" src="https://github.com/user-attachments/assets/ab1c8f4f-4e2d-4806-ac5e-fbc268779c97" />
… models catalogue budget (#19968) ## Summary Backport of #19669 to `cloud/1.55`: drop the whole-route JavaScript ceiling from the models catalogue budget test, which on this release line is a coin flip that blocks website- and `packages/`-touching carriers. ## Changes - **What**: Remove `expect(totalBytes).toBeLessThan(1_815_000)` from `apps/website/e2e/models-performance.spec.ts`. Keep the catalogue-only delta budget (`< 900_000`). The resulting test body is **identical to `main`'s**. ## Review Focus **The ceiling is non-deterministic on this branch, not merely outgrown.** On one fixed build of `cloud/1.55` (`a9968daf95`) the assertion reports two discrete values with the ceiling sitting between them: | mode | scripts | route total | vs 1,815,000 | |---|---|---|---| | low | 85 | 1,803,417 | passes | | high | 93 | 1,835,228 | fails | Ten consecutive focused runs against that single build: **5 failed, 5 passed**. The 31,811-byte swing is eight homepage/brand chunks and **no catalogue code**: `ProductShowcaseSection` (10,626), `GalleryDetailModal` (9,623), `AIModelsSection` (4,412), `ModelCreationsSection` (3,836), `BrandButton` (1,177), `brandButton.variants` (1,039), `CardArrow` (1,004), `cta` (94). They race the `shared` baseline captured on `/`: when they have not arrived before the baseline is sampled they are absent from `shared`, then charged in full against `/models/`. That explains a result that otherwise looks like drift: the gate passed on #19670 (152/152, 2026-09-30) and failed 3/3 on #19953 (1,835,341, 2026-10-02) with no catalogue change in between. Hosted runners are slower, which biases them toward the failing mode. The ceiling had also been ratcheted by unrelated billing work, exactly as #19669 describes upstream: #17971 set 1,810,000, and the #19120 billing backport (#19207) raised it to 1,815,000 on this line while measuring over it. **What still guards the route:** - The catalogue-only delta budget is kept and binds: measured 507,500–526,375 against 900,000. Tightening it to 500,000 **fails** at 507,500, so it is not vacuous. - The regression this test was written for — server catalogue data in the client bundle (#17604) — is caught at build time by `apps/website/src/integrations/workshop-client-boundary.ts`, which is present on this branch. **Validation** (`cloud/1.55` @ `a9968daf95`, local production build, port 6255): - Before: 5/10 focused runs failed at 1,835,228. - After: `models-performance.spec.ts` passes **10/10** (2 tests each). - `pnpm --filter @comfyorg/website typecheck` — 0 errors; `oxfmt --check`, `oxlint --type-aware`, `eslint` clean. I am not merging this; it needs a frontend reviewer's approval. Alexander Brown (@DrJKL) authored #19669 and is the natural reviewer. ## Screenshots (if applicable) Not applicable; this removes a test assertion and changes no product code.
Summary
Drop the whole-route JS ceiling from the models catalogue budget test. Every page loads the same shared layout, and that shared code is almost the entire total, so the ceiling failed on unrelated site changes (raised 4× in 2 weeks, e.g. #17971, and failing again after #19494).
Changes
totalBytes < 1_825_000fromapps/website/e2e/models-performance.spec.ts. Keep the catalogue-only delta budget (< 900_000).Review Focus
Measured on a production build of main:
/)The regression this test was written for, server catalogue data in the client bundle (#17604), already fails the build via
src/integrations/workshop-client-boundary.ts. Verified locally: importingcontent/workshop-router-contracts.jsonintoModelsCatalogue.vuefails the build with "contains server catalogue data". The delta budget has never been raised and still catches a heavy dependency added to the catalogue island.