Repository navigation
feat(website): related models link a model's other tasks and leave no page unlinked - #19375
MaanilVerma wants to merge 6 commits into
Conversation
… to link its other tasks
…l from related models
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
QAHead
Red (base implementation, new test): Green: Build proof. Before: After: Three sample pages, before then after: Pages linking Nano Banana Pro Text-to-Image ( Anchor text in the built HTML is the card title, which names the task, for example Edge cases: a model alone in the list gets an empty row; a model with more other tasks than the limit keeps all of them; the catalogue-order card wraps from the last model to the first; another model is shown once, by its best-ranked page; the next model is pinned only when it has no sibling task, and the row can go one past the limit only when a model's other tasks fill it. All are rows in Not covered: the 30 workflow pages ( Review fixes ( |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 426f1563577c736496bd42adfe02bfca134f2176
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-19375.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-ltc20frn2-comfyui.vercel.app Last updated: 2026-09-29T18:56:56Z for 🌐 Website E2ETip All tests passed.
📦 Bundle Size
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## maanil/fe-2942-model-page-ssr #19375 +/- ##
=================================================================
- Coverage 84.14% 84.05% -0.10%
=================================================================
Files 3188 3158 -30
Lines 155105 154289 -816
Branches 42475 39949 -2526
=================================================================
- Hits 130509 129681 -828
- Misses 22923 22990 +67
+ Partials 1673 1618 -55
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 305 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @MaanilVerma.
Found 5 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 1 |
| 🟢 Low | 3 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
…ver the pinned card past the limit
…nto maanil/fe-2940-related-models-links
This comment has been minimized.
This comment has been minimized.
…nto maanil/fe-2940-related-models-links
benjcooley
left a comment
There was a problem hiding this comment.
Reviewed the ranking change, the link-graph guarantee and both test files against the real catalogue data (workshop-display.json + workshop-content-inputs.json) and the render path (prepareModelPage -> ModelPage.vue -> WorkshopModelCard.vue).
The no-orphan argument holds. relatedModels is only ever called with workshopPages.filter(type === model.type), which for router pages is exactly workshopModels — the same set model-page.links.test.ts iterates — so the catalogue-order cycle covers the tested set with no gap. Every page is either its predecessor's pinned card or a member of some page's siblings, and pinned always survives the final slice. I traced all eleven table cases by hand; the implementation matches them.
Two things I checked because they would have been real regressions and were not:
- Sibling cards can't render identically. Every pair sharing a
routerIdand auseCasehas distinctmodelIds, sosharedNamesforces the legacydisplayNameapart ("Seedance 2.5 Reference" vs "Seedance 2.5 Text-to-Video"), and the card's task pill separates the rest. - Row width is safe today. Max group size in the data is 4 (
byteplus/dreamina-seedance-2-5-260628,kling/kling-v3-omni), sosiblingstops out at 3 androomnever goes to 0.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 2 |
| TRIVIAL | 2 |
The substantive one: pinning the catalogue successor is unconditional, but a successor that has siblings is already linked from each of those siblings' pages. Pinning it anyway forces the .map() that swaps a whole model's best-ranked page for whichever of its task pages happens to sort next — so ~a quarter of the rows will show a less useful card than the ranking chose, for a link that already exists. Narrowing pinned to sibling-less successors keeps the guarantee, deletes the .map(), and drops the reference-identity assumption top.includes(pinned) currently rests on.
Worth noting outside the diff: [slug].astro still renders every model page noindex, so the crawl-graph payoff this PR is buying is deferred until that comes off. Not a reason to hold the change — the link graph should be right before the pages are indexable — just don't expect SEO movement from merging it.
benjcooley
left a comment
There was a problem hiding this comment.
Re-reviewed ff1311fd scoped to the delta. All four comments from the previous pass are addressed in code, not just acknowledged; threads resolved.
What I verified rather than took on faith. The narrowing of pinned is the risky part — it removes a link that used to be unconditional — so I re-derived the no-orphan invariant against the new code rather than trusting the old proof:
- A page with at least one sibling is linked from that sibling's row.
siblingsis spread unconditionally at L73 with no clamp, so this holds regardless oflimit. - A page with no sibling has exactly one catalogue predecessor (the ordering is a total order over unique slugs, so
nextInCatalogueis a permutation cycle). On that predecessor's rowworkshopExecutionId(next) !== idholds — no other page shares the successor's exec id, and the predecessor is not the page itself — soisOnlyTaskpasses and it is pinned. - A defined
pinnedalways reaches the return: it is intop, or it is appended by the L76 branch. Both paths covered.
No gap. I also re-traced all twelve table cases by hand against the new logic; every expectation follows, including the two that changed.
The substantive fix landed correctly. keeps the best page of another model when its next page has other tasks now returns b-busy (9 examples) where it previously returned n-quiet (0). That was the real cost of the old unconditional pin, and it is gone. The new stays within the limit when the next model is linked by its own tasks case is a good addition — it pins down the narrowing itself rather than only its side effects, and it would go red if isOnlyTask were dropped.
Two secondary improvements worth calling out: removing the .map() substitution means pinned is now always a singleton exec-id group, so the slug comparison at L74 is a genuine "did the successor rank in" test instead of a reference-identity trick that silently depended on the caller passing un-copied catalogue entries. And the links test is now one top-level await, matching page.json.test.ts, so each page is prepared once instead of twice.
Not blocking. Your call on the soft limit is the right one — rotating siblings to keep every task page linked would trade a documented one-card overflow for an invariant that cannot hold at limit: 1. I left one nit inline on the new comment wording: it describes the over-limit row as "the other tasks plus that kept page", but when the tasks fill the row and the successor is itself a sibling there is no kept page and the row is the tasks alone. "if any" covers it. Not worth a round trip.
CI was still pending when I looked; the whole-catalogue test is the one that matters here and the invariant holds analytically, so I do not expect a surprise.
## Summary **Deploy gate: comfy-router#46 is merged and live (2026-09-30). Its follow-up comfy-router#48 (serves `/hub/models.md` instead of 301ing it to a /workflows 404) must be deployed before this merges. After the merge, purge Cloudflare for `/hub/models*`, `/hub/workflows*` and the 30 workflow names in `hub-workflow-names.json`. The redirects ship as 307; FE-3083 flips them to 308 later.** This branch combines every Workshop /models SEO PR, so merging it to main replaces merging them one by one. It also launches: Comfy-Org#19405 commits `launchedModelPages = 'all'`, so all 148 model pages become indexable in the same deploy as the URL move. Part of FE-2912, FE-2942 (PR 2 is FE-3086), FE-2974 (/minimax 308 is FE-3087) Fixes FE-2978, FE-2989, FE-2991, FE-2990, FE-2959, FE-2981, FE-2977, FE-2979, FE-3014, FE-2936, FE-2980, FE-2975, FE-3085, FE-2972, FE-2935, FE-2950, FE-2940, FE-2930, FE-2985, FE-2957, FE-2961, FE-2986, FE-2921, FE-2922, FE-2947 ## Changes Router follow-up: comfy-router#48 (`/hub/models.md` routing, 324/324 router tests), deploy before this merges. The included PRs, in merge order. Every head was checked as contained at the final tip. | PR | Ticket | What | Ben | |---|---|---|---| | Comfy-Org#18887 | FE-2978 | Pricing Product markup and full video `uploadDate` | approved | | Comfy-Org#18889 | FE-2989 | A unique meta description on every model page | approved | | Comfy-Org#18890 | FE-2991 | Model page JSON-LD, emitted once noindex lifts | approved | | Comfy-Org#18892 | FE-2990 | Cleaner tag pills, guard against duplicate summaries | approved | | Comfy-Org#18893 | FE-2959, 2981, 2977, 2979 | Social tags, hub title, Organization data. The FE-2977 title was confirmed by the owner | approved | | Comfy-Org#19362 | FE-3014 | Every non-production build is noindex | approved | | Comfy-Org#19366 | FE-2936 | Model titles lead with "API & Playground" | approved | | Comfy-Org#19402 | FE-2980 | Every internal link ends with a slash, plus a CI check | approved | | Comfy-Org#19419 | FE-2975 | Footer links the catalogue on every page and locale | approved | | Comfy-Org#19476 | FE-3085 | `NOINDEX_ROUTES` decides noindex for serverless-animation | approved; re-approval pending on a one-line follow-up (CodeRabbit approved) | | Comfy-Org#19359 | FE-2974 | One typed redirect list that generates `vercel.json` | approved | | Comfy-Org#19369 | FE-2972 A | The old to new model URL map | approved | | Comfy-Org#18891 | FE-2935 | Model content shows whatever the flag says | approved | | Comfy-Org#18899 | FE-2942 | Model pages render in the static HTML | approved | | Comfy-Org#18898 | FE-2950 | Catalogue h1 and A to Z links in the static HTML | approved | | Comfy-Org#19375 | FE-2940 | Related models leave no page unlinked | approved | | Comfy-Org#19385 | FE-2930 | Examples show the prompt that made them | approved | | Comfy-Org#19394 | FE-2985 | Render guard e2e: no loader, no layout shift | approved | | Comfy-Org#19357 | FE-2957 | robots.txt stops blocking our scripts and styles | approved | | Comfy-Org#19360 | FE-2961 | Turning Workshop off keeps every Models page | approved (a CodeRabbit changes-requested review is still open) | | Comfy-Org#19386 | FE-2986 | One registry of every Models address | approved | | Comfy-Org#19421 | FE-2972 B1 | Model pages served at `/hub/models` | approved | | Comfy-Org#19422 | FE-2972 B2 | Every old model URL redirects (307) | approved | | Comfy-Org#19424 | FE-2972 B3 | Workflow pages at `/hub/workflows` with redirects | approved | | Comfy-Org#19399 | FE-2921 | One switch decides model robots and sitemap listing | approved | | Comfy-Org#19404 | FE-2922 | Clean markdown twins for model pages | approved | | Comfy-Org#19405 | FE-2947 | Lifts noindex on every canonical model page | approved | | comfy-router#46 | FE-3075 | Serves `/hub/models*` from the website and routes `/hub/workflows` by manifest. Merged and live | merged | These fixes exist only on this branch, because they only break once two PRs meet: - `scripts/check-models-html.ts` reads each page at `model.href` and skips models without a page (f1df1e4). - `e2e/fixtures/modelsCatalogue.ts` reads `dist/hub/models` (f87bb4c). - `routerIdsByModelPage` accepts an optional `href`, since Comfy-Org#19421 made it optional and Comfy-Org#19405 no longer typechecked (9783819). - `ModelStatus` links a successor only when it has a page, for the same reason on Comfy-Org#18899 (c4761d8). - The model breadcrumb in `modelJsonLd.ts` points at `/hub/models/` instead of the `/models/` redirect (eb985b6). Its label still says "Models" while the nav says "Hub". - Twin, meta-description and entry tests use the hub pages and the new tag set (86ac3b0, d4ffc0f). - The render guard finds the catalogue through `getRoutes().workshop`, and its `test.fail` is gone now that Comfy-Org#18898 renders the h1 (831499f). - A new test renders a real model page and checks its markdown twin has the model's h1 (9a6c5cb). - Main's newer catalogue and workflow e2e cases use the hub addresses (2aeda77). - `resetWorkshopAccountSource` resets `decision`; a clean auto-merge of main's Comfy-Org#19454 into Comfy-Org#18891 left it assigning a variable that no longer exists (c28c7a7). The conflict resolutions, briefly: `ALTERNATE_TWIN_SOURCES` stays deleted as Comfy-Org#18898 wants, so `/hub/models.md` comes from the real catalogue. The hub keeps Comfy-Org#18898's single static h1 instead of the `WorkshopHero` h1 that main's Comfy-Org#19320 added. `ExamplesTab` keeps Comfy-Org#19385's figure and caption with main's video poster. The Comfy-Org#19399/Comfy-Org#19405 indexing tests were rewritten for hub paths. The Comfy-Org#19359 redirect test no longer builds `/enterprise//` from slash-ended routes. The Comfy-Org#19369 URL-map test imports `PROVIDER_NAMES` from its new home. The full table of 47 resolutions is in the integration report. ## Review Focus - Launch rides along with the URL move. If launch should stay a separate step, set `launchedModelPages` in `apps/website/src/config/model-page-launch.ts` to `new Set()` before merging. - Main's Comfy-Org#19320 gives the catalogue island its own h1 through `WorkshopHero`. This branch keeps Comfy-Org#18898's static h1 and renders only the subtitle in `ModelsCatalogue.vue`, so the hub has exactly one h1. - Comfy-Org#19476 overlaps the open community PR Comfy-Org#18591 (same sitemap exclusion for serverless-animation). One of them should be closed once this lands. ## QA - [x] Gates: `pnpm typecheck` and website typecheck clean, `pnpm lint` 0 errors, eslint on `apps/website` clean, `pnpm knip` clean - [x] Website unit: 547 files, 10347 passed, 4 skipped - [x] Build A (`build:e2e`, CI env): 1193 pages; release gate, `check:hreflang`, `validate:llms-txt-links` (225 links), `validate:jsonld` (947 pages), `check:link-slashes`, `check:models-html` (148 pages) all pass - [x] Build B (`WORKSHOP_IN_BUILD=0`): same 182 Models pages as the on build, no `dist/workshop`, `/` is noindex; with the flag stubbed on, no Run, no Hub nav and no Firebase requests - [x] Build C (preview shape): 945 of 945 pages noindex, no canonicals except redirect stubs, no hreflang in the sitemap - [x] E2E on Build A: 644 of 645 passed; the one mobile failure passed on rerun. Earlier load flakes (navigation, demos, fdct, wan-3.0, network isolation, render guard) all passed when rerun alone - [x] Launch: 148 model pages indexable with canonicals, 149 hub entries in the sitemap, 148 non-empty twins with the model h1, 148 in `llms-full.txt`, 0 titles over 60, 30 workflow pages still noindex - [x] Redirects: 853 rules, 782 to /hub all 307, the MiniMax rows 307, every /hub destination built - [x] comfy-router#46 under `wrangler dev` in front of this build: 312 router tests pass; 148 old model URLs (both slash forms) 307 then 200; 30 workflow names served by the website and their old URLs 307; a non-manifest workflow 302 with no-store; `manifest.json` passes through; `/workflows/` and bare `/hub` unchanged - [x] After the router deploys and this merges: purge Cloudflare, then curl `https://comfy.org/hub/models/` for a 200 and three old `/models/<slug>/` URLs for one 307 each - [x] Rich Results Test on `/pricing/` and `/learning/animations/character-sheet/`, then "Validate fix" on Merchant listings and Videos - [x] Rich Results Test on two live model pages: breadcrumbs valid and the breadcrumb URL returns 200 with no redirect - [x] GPTBot and Googlebot curls on the hub and one model page, then a GSC live test on both - [x] Resubmit the sitemap in Search Console and URL-inspect about 20 model pages on day 0 and day 14 - Not covered: Rich Results and GSC need production; the redirect matrix used a local shim for `vercel.json`, since `astro preview` ignores it --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: benjcooley <benjcooley@gmail.com> Co-authored-by: Deep Mehta <42841935+deepme987@users.noreply.github.com>
|
Superseded by the integration branch #19494, which combined this PR with every other Workshop SEO slice and has been merged to main. Closing this one. |
Summary
Related models on a model page now lead with the same model's other tasks, and every model page is linked from at least one other model page. Before this,
relatedModels()skipped the model's own Router id, so Seedance 2.5 Text-to-Video never linked its Image-to-Video or Video Edit pages, and 24 of the 148 pages had no inbound link from any model page.Fixes FE-2940 (https://linear.app/comfyorg/issue/FE-2940)
Stacked on #18899
Changes
relatedModels()inworkshop-related.tsputs the model's other task pages (same Router id) first, and keeps all of them even when they fill the row.model-page.links.test.tsrunsprepareModelPage()over every published model page and fails, naming the pages, if any page has no inbound related link, misses a sibling task, or links itself.workshop-related.test.tsis now one table covering the ranking, siblings, the limit, the catalogue-order card and the wrap.Changed from the ticket: siblings lead the existing related row instead of a separate "Other ways to use {family}" block, since the data has no family name and the cards already carry task-named titles. The no-orphan guarantee comes from the catalogue-order card rather than a fewest-inbound-links tie-breaker, which would need a whole-catalogue pass and still would not guarantee zero. URLs and hrefs are untouched: cards still link
model.href, so FE-2972 only has to change the data.QA
workshop-related.test.tstable and theroutes/modelssuites passWORKSHOP_IN_BUILD=1): related links parsed fromdist/models/*/index.htmlshow 0 orphans, 0 self-links, 0 links without a trailing slash