Repository navigation
fix(website): end every internal page link with a trailing slash - #19402
MaanilVerma wants to merge 8 commits into
Conversation
Route constants, path builders and hardcoded hrefs now use the slash-terminated canonical form, so no internal link points at the second address of a page.
QALocal static builds (
| Fix-up | Fix-up | Fix-up Update 2026-09-30 at
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (11)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe website updates route helpers and internal page links to use trailing slashes in most paths. It adds a build-output checker for slashless internal links and alias-host links, runs that checker in CI, and updates associated unit and end-to-end expectations. ChangesWebsite link normalization
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to Updated links use the canonical slash-terminated paths, and the sitemap remains consistent with them. No actionable merge risk introduced by this change remains. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The inspected routes still lead to fixed website destinations, and locale exclusions remain in place. No introduced security issue is evident, but generated output and live routing have not been verified. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🌐 Website E2ETip All tests passed.
🎭 Playwright: ✅ 2156 passed, 0 failed · 2 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (124 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d8aac6139049e2f8b330fcce119d3cb5ed763066
Full docs: ADR-DEVEX-LINT-0015 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-19402.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-40u1sd1hk-comfyui.vercel.app Last updated: 2026-09-29T22:05:53Z for 📦 Bundle: 10 MB gzip 🔴 +346 kBDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.73 kB) • 🔴 +38 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.46 MB (baseline 1.43 MB) • 🔴 +29.7 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 133 kB (baseline 124 kB) • 🔴 +9.54 kBTop-level views, pages, and routed surfaces
Status: 17 added / 16 removed / 1 unchanged Panels & Settings — 643 kB (baseline 621 kB) • 🔴 +21.7 kBConfiguration panels, inspectors, and settings screens
Status: 28 added / 27 removed User & Accounts — 39.4 kB (baseline 27.8 kB) • 🔴 +11.6 kBAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 2 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🔴 +691 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 125 kB (baseline 117 kB) • 🔴 +8.07 kBReusable component library chunks
Status: 16 added / 15 removed Data & Services — 4.06 MB (baseline 3.6 MB) • 🔴 +463 kBStores, services, APIs, and repositories
Status: 15 added / 16 removed Utilities & Hooks — 582 kB (baseline 559 kB) • 🔴 +23.2 kBHelpers, composables, and utility bundles
Status: 31 added / 30 removed / 6 unchanged Vendor & Third-Party — 17.4 MB (baseline 18.1 MB) • 🟢 -684 kBExternal libraries and shared vendor chunks
Status: 12 added / 12 removed / 6 unchanged Other — 17.9 MB (baseline 16.4 MB) • 🔴 +1.54 MBBundles that do not match a named category
Status: 178 added / 174 removed / 122 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-29T22:18:14.221Z",
"gitSha": "815ec3c8d50b2294091d1bc9a09f04dfe919d1ef",
"branch": "maanil/fe-2980-internal-link-slashes",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2031.9850000000201,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.781000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 509.099,
"heapDeltaBytes": 169372,
"heapUsedBytes": 79023788,
"domNodes": -228,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 12.811,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2041.9070000000374,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.202,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.72099999999995,
"heapDeltaBytes": -37837660,
"heapUsedBytes": 60636260,
"domNodes": -228,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 11.313,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1960.7409999999845,
"styleRecalcs": 76,
"styleRecalcDurationMs": 19.73,
"layouts": 12,
"layoutDurationMs": 4.492,
"taskDurationMs": 940.0719999999999,
"heapDeltaBytes": -36338556,
"heapUsedBytes": 62359676,
"domNodes": -228,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 185.09099999999998,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66581196581196,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1876.5230000000201,
"styleRecalcs": 74,
"styleRecalcDurationMs": 18.932000000000002,
"layouts": 12,
"layoutDurationMs": 4.9319999999999995,
"taskDurationMs": 933.851,
"heapDeltaBytes": -42023892,
"heapUsedBytes": 56630564,
"domNodes": -228,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 188.226,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571424,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1752.3899999999912,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.998000000000001,
"layouts": 6,
"layoutDurationMs": 1.249,
"taskDurationMs": 403.231,
"heapDeltaBytes": -18660448,
"heapUsedBytes": 80100072,
"domNodes": 53,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 16.547,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1734.4370000000708,
"styleRecalcs": 33,
"styleRecalcDurationMs": 11.849,
"layouts": 6,
"layoutDurationMs": 1.311,
"taskDurationMs": 383.05699999999996,
"heapDeltaBytes": 1484360,
"heapUsedBytes": 80368280,
"domNodes": 53,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 15.859000000000005,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 765.8670000000143,
"styleRecalcs": 13,
"styleRecalcDurationMs": 4.498,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 523.173,
"heapDeltaBytes": -3043168,
"heapUsedBytes": 95181184,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 188.38299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 676.1789999999337,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.806999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.52900000000005,
"heapDeltaBytes": 18257240,
"heapUsedBytes": 97238224,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 170.08,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1239.0869999999836,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 888.254,
"heapDeltaBytes": 7618312,
"heapUsedBytes": 85009120,
"domNodes": 0,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 75.25599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 591,
"frameDurationMs": 36.27352941176471,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1178.809000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 834.1840000000001,
"heapDeltaBytes": 9312572,
"heapUsedBytes": 85209416,
"domNodes": 0,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 67.54899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 553,
"frameDurationMs": 34.80294117647057,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 862.6820000000066,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.3469999999995,
"heapDeltaBytes": 15874028,
"heapUsedBytes": 90963144,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 171.606,
"eventListeners": 0,
"totalBlockingTimeMs": 238,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 875.9290000000419,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.67700000000025,
"heapDeltaBytes": 16873492,
"heapUsedBytes": 90890888,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 174.15299999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 238,
"frameDurationMs": 25.979411764705862,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11884.064999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10893.221,
"heapDeltaBytes": -6048996,
"heapUsedBytes": 75494956,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 9318.21,
"eventListeners": 0,
"totalBlockingTimeMs": 2391,
"frameDurationMs": 37.432807570977914,
"p95FrameDurationMs": 66.80000000000018
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9507.369000000039,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8640.298999999999,
"heapDeltaBytes": -10117944,
"heapUsedBytes": 71351132,
"domNodes": 0,
"jsHeapTotalBytes": -11534336,
"scriptDurationMs": 7282.384,
"eventListeners": 0,
"totalBlockingTimeMs": 1167,
"frameDurationMs": 34.41920289855072,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11839.226999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10830.369,
"heapDeltaBytes": 1828544,
"heapUsedBytes": 82917508,
"domNodes": 0,
"jsHeapTotalBytes": -6291456,
"scriptDurationMs": 8998.314,
"eventListeners": 0,
"totalBlockingTimeMs": 1720,
"frameDurationMs": 33.711680911680915,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11040.336000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10006.396,
"heapDeltaBytes": 11402040,
"heapUsedBytes": 92355920,
"domNodes": 0,
"jsHeapTotalBytes": -9437184,
"scriptDurationMs": 8252.682999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1453,
"frameDurationMs": 31.43276353276353,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2048.39800000002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.7669999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 680.84,
"heapDeltaBytes": -36819352,
"heapUsedBytes": 82139148,
"domNodes": -228,
"jsHeapTotalBytes": 1212416,
"scriptDurationMs": 46.114000000000004,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2062.5350000000253,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.8049999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 639.9789999999999,
"heapDeltaBytes": -35651044,
"heapUsedBytes": 82584840,
"domNodes": -228,
"jsHeapTotalBytes": -360448,
"scriptDurationMs": 38.617,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2994.934999999998,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.850999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1805.0130000000001,
"heapDeltaBytes": -32146300,
"heapUsedBytes": 87882612,
"domNodes": -228,
"jsHeapTotalBytes": 389120,
"scriptDurationMs": 897.987,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.760451977401132,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2405.1230000000032,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.852000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1504.734,
"heapDeltaBytes": 22403760,
"heapUsedBytes": 85832624,
"domNodes": -228,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 863.899,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665277777777774,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3932.6030000000287,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.093000000000002,
"layouts": 60,
"layoutDurationMs": 15.104999999999999,
"taskDurationMs": 1878.3010000000002,
"heapDeltaBytes": 9814516,
"heapUsedBytes": 73240684,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 858.0790000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491525,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3810.2989999999863,
"styleRecalcs": 64,
"styleRecalcDurationMs": 11.605,
"layouts": 60,
"layoutDurationMs": 14.429,
"taskDurationMs": 1808.9649999999997,
"heapDeltaBytes": 9941060,
"heapUsedBytes": 74071684,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 831.7189999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66593886462882,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3196.877000000029,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.194000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2120.196,
"heapDeltaBytes": 24912796,
"heapUsedBytes": 88801304,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1098.092,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84157894736842,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3170.9730000000036,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.648000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1976.676,
"heapDeltaBytes": 159212,
"heapUsedBytes": 65331184,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 1008.032,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84308510638298,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2066.3450000000125,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.2929999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 627.7539999999999,
"heapDeltaBytes": -37351100,
"heapUsedBytes": 83174828,
"domNodes": -228,
"jsHeapTotalBytes": -98304,
"scriptDurationMs": 38.559999999999995,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66612903225806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2012.7390000000105,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.818,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 620.081,
"heapDeltaBytes": 21324596,
"heapUsedBytes": 84435768,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 37.812,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 658.2280000000083,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.799999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.82099999999997,
"heapDeltaBytes": 13217564,
"heapUsedBytes": 93424720,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 152.376,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 664.5730000000185,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.481,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.2320000000001,
"heapDeltaBytes": 13210468,
"heapUsedBytes": 94046704,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 155.168,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667500000000018,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2041.5309999999636,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.927,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.456,
"heapDeltaBytes": -6195640,
"heapUsedBytes": 74563816,
"domNodes": -244,
"jsHeapTotalBytes": -1310720,
"scriptDurationMs": 10.308000000000002,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2041.9579999999087,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.6800000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.4680000000001,
"heapDeltaBytes": -11458532,
"heapUsedBytes": 69109284,
"domNodes": -244,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 11.843,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1758.5449999999696,
"styleRecalcs": 62,
"styleRecalcDurationMs": 19.482,
"layouts": 16,
"layoutDurationMs": 6.091000000000001,
"taskDurationMs": 881.575,
"heapDeltaBytes": -21390020,
"heapUsedBytes": 58482644,
"domNodes": -244,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 121.88100000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1760.3639999999814,
"styleRecalcs": 62,
"styleRecalcDurationMs": 19.293000000000006,
"layouts": 16,
"layoutDurationMs": 6.6579999999999995,
"taskDurationMs": 847.886,
"heapDeltaBytes": -21362084,
"heapUsedBytes": 58782404,
"domNodes": -244,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 120.14399999999999,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1436.3220000000183,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.893000000000004,
"layouts": 5,
"layoutDurationMs": 14.391000000000002,
"taskDurationMs": 974.134,
"heapDeltaBytes": 21802624,
"heapUsedBytes": 102763072,
"domNodes": 13667,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 33.80899999999999,
"eventListeners": 2383,
"totalBlockingTimeMs": 147,
"frameDurationMs": 19.594594594594582,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 10446.011999999995,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.135,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6535.21,
"heapDeltaBytes": -34422476,
"heapUsedBytes": 84748068,
"domNodes": -228,
"jsHeapTotalBytes": 1404928,
"scriptDurationMs": 3091.519,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6926517571885,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9653.507999999987,
"styleRecalcs": 250,
"styleRecalcDurationMs": 34.99000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6291.689,
"heapDeltaBytes": -36097696,
"heapUsedBytes": 83182316,
"domNodes": -228,
"jsHeapTotalBytes": 94208,
"scriptDurationMs": 2966.878,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665975820379966,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17411.856999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17101.143999999997,
"heapDeltaBytes": 7310424,
"heapUsedBytes": 196351348,
"domNodes": -8049,
"jsHeapTotalBytes": -9961472,
"scriptDurationMs": 294.488,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.26851145038168,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 13103.06300000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12469.334,
"heapDeltaBytes": -56907308,
"heapUsedBytes": 167916736,
"domNodes": -3045,
"jsHeapTotalBytes": 14430208,
"scriptDurationMs": 229.33599999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.663494809688583,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 16394.520999999997,
"styleRecalcs": 99,
"styleRecalcDurationMs": 16.03199999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16235.853999999996,
"heapDeltaBytes": 5843312,
"heapUsedBytes": 192089024,
"domNodes": -8049,
"jsHeapTotalBytes": -12128256,
"scriptDurationMs": 869.027,
"eventListeners": -14923,
"totalBlockingTimeMs": 11,
"frameDurationMs": 31.18159392789374,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-large-graph-pan",
"durationMs": 20879.85100000003,
"styleRecalcs": 152,
"styleRecalcDurationMs": 20.194999999999965,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20705.266,
"heapDeltaBytes": -38508232,
"heapUsedBytes": 190791920,
"domNodes": -3045,
"jsHeapTotalBytes": 3018752,
"scriptDurationMs": 928.067,
"eventListeners": -14915,
"totalBlockingTimeMs": 95,
"frameDurationMs": 40.753515625,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6303.579999999954,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.75399999999999,
"layouts": 20,
"layoutDurationMs": 26.44199999999998,
"taskDurationMs": 6267.968,
"heapDeltaBytes": 740744,
"heapUsedBytes": 189016320,
"domNodes": -1313,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 121.74100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 429,
"frameDurationMs": 39.97721518987341,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6278.648999999973,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.44100000000005,
"layouts": 20,
"layoutDurationMs": 24.897000000000002,
"taskDurationMs": 6241.853,
"heapDeltaBytes": 7878848,
"heapUsedBytes": 213458064,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 117.19399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 451,
"frameDurationMs": 39.12857142857142,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8840.543999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8751.341999999999,
"heapDeltaBytes": -21026152,
"heapUsedBytes": 161784108,
"domNodes": 0,
"jsHeapTotalBytes": -31719424,
"scriptDurationMs": 144.38299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.777480916030534,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8665.009999999938,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8529.357999999998,
"heapDeltaBytes": -32702932,
"heapUsedBytes": 168357032,
"domNodes": -3046,
"jsHeapTotalBytes": 6938624,
"scriptDurationMs": 145.32999999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.216728624535314,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 146.22099999996863,
"styleRecalcs": 11,
"styleRecalcDurationMs": 21.427999999999997,
"layouts": 5,
"layoutDurationMs": 2.8739999999999997,
"taskDurationMs": 129.901,
"heapDeltaBytes": -17164744,
"heapUsedBytes": 79796804,
"domNodes": 98,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 18.419,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.655555555555516,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 494.94400000003225,
"styleRecalcs": 20,
"styleRecalcDurationMs": 21.524,
"layouts": 4,
"layoutDurationMs": 2.056,
"taskDurationMs": 206.38799999999998,
"heapDeltaBytes": -43013204,
"heapUsedBytes": 53291480,
"domNodes": -125,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 12.806000000000001,
"eventListeners": -62,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1102.1449999999504,
"styleRecalcs": 78,
"styleRecalcDurationMs": 117.513,
"layouts": 76,
"layoutDurationMs": 26.935000000000002,
"taskDurationMs": 1067.199,
"heapDeltaBytes": 19793132,
"heapUsedBytes": 92124768,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 455.017,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636353,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1155.0980000000663,
"styleRecalcs": 78,
"styleRecalcDurationMs": 121.52,
"layouts": 76,
"layoutDurationMs": 28.625999999999998,
"taskDurationMs": 1120.185,
"heapDeltaBytes": 20079160,
"heapUsedBytes": 90032020,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 473.556,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.907246376811575,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1473.4789999999975,
"styleRecalcs": 78,
"styleRecalcDurationMs": 265.168,
"layouts": 76,
"layoutDurationMs": 26.13,
"taskDurationMs": 1450.3819999999998,
"heapDeltaBytes": 8405788,
"heapUsedBytes": 115941560,
"domNodes": -7945,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 485.347,
"eventListeners": -1226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.332500000000003,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1488.7129999999615,
"styleRecalcs": 78,
"styleRecalcDurationMs": 265.44800000000004,
"layouts": 76,
"layoutDurationMs": 26.19,
"taskDurationMs": 1473.689,
"heapDeltaBytes": 8411264,
"heapUsedBytes": 120419136,
"domNodes": -7943,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 499.866,
"eventListeners": -1228,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.51851851851852,
"p95FrameDurationMs": 33.30000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #19402 +/- ##
==========================================
- Coverage 84.25% 84.15% -0.10%
==========================================
Files 3282 3214 -68
Lines 157963 155914 -2049
Branches 41014 40346 -668
==========================================
- Hits 133086 131207 -1879
+ Misses 23048 22983 -65
+ Partials 1829 1724 -105
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 81 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
Also stop the legacy /cinematic-studio redirect from appending a second slash to the now slash-terminated app route.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @MaanilVerma.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 4 |
| 🟢 Low | 5 |
Panel: 8/8 reviewers contributed findings.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Also checks www.comfy.org hrefs and the WORKSHOP_IN_BUILD=0 build, fails on an empty dist, pairs href quotes, and slashes the remaining supported-model, llms.txt and pricing FAQ links.
benjcooley
left a comment
There was a problem hiding this comment.
Review summary
Mechanical change, well executed, and the interesting parts hold up. isLocaleInvariantPath normalising through normalizeRoute is correct (it also fixes a latent bug: /login/ in the set never matched /login before). I checked every place that used to append its own / — AppsBackLink, CinematicStudioPage, routes/models/cinematic-studio.astro, video-sitemap.xml.ts, workshop-app-content.test.ts, redirects.test.ts — and none of them double-slash now. No remaining ${route}/ concatenations anywhere in apps/website/src. isUrlUnderPath('/events') in EventVideoDialog still matches, because the new /events/ prefix satisfies startsWith('/events/').
I also resolved every static path the diff introduces against production (81 paths): all 200 except the two known-intentional ones. The two judgement calls check out — https://comfy.org/zh-CN/p/supported-models/ really does 404, so retargeting the drops.ts and zh-CN/models.astro links to /p/supported-models/ is right, and #faq exists on both /pricing/ and /zh-CN/pricing/. Sitemap and canonicals already use the slashed form, so this aligns links with them rather than against them.
Three leftovers, all one-liners, all pointing at an address that still redirects — i.e. the exact thing the PR is eliminating.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 3 |
| TRIVIAL | 2 |
Not blocking, but worth a follow-up note rather than a code change: EventVideoDialog.closeDialog does location.assign(localizeHref('/events', locale)), so the fallback close still parks the user on the slashless /events. The PR body calls it out as out of scope since it is not an href — fair, but it is a user-visible address that the dist checker structurally cannot see. Same blind spot applies to vercel.json redirect destinations (/careers, /privacy-policy, /pricing, /platform/router are all slashless), which #19359 owns.
Point the leftover /cloud/pricing/ links at /pricing/, switch www.comfy.org links to the apex host, give the markdown twin a slashed canonical, build the learning nav link from categoryPath, and send the events dialog close to /events/. The link check now fails on any www.comfy.org href.
benjcooley
left a comment
There was a problem hiding this comment.
Re-review — ca4ee837 (+ merge of main)
All five items from the last round are genuinely fixed, not papered over. I re-checked each rather than taking the replies at face value:
/cloud/pricing/links —mcp.faq.6.aandcli.faq.3.anow point athttps://comfy.org/pricing/in both locales, and the plain-text mention inmodels.faq.isFree.cloudAnswerwent with them.grep cloud/pricing apps/website/srcnow returns only the redirect map and tests. Resolved.- www host —
ModelHeroSection.vue(both links),[slug].md.ts, andllms.txt.tsare on the apex. The onlywww.comfy.orgleft in shipped copy is the visible text of the privacy-policy sentence, whose href now goes to the apex. Resolved. - Markdown twin canonical —
pageUrlis slashed and_slug.md.test.tsasserts it. Resolved. - The gate — nice upgrade.
ORIGINSis apex-only andaliasHostHrefsfails the build on anywww.comfy.orghref, so the shape can't come back.isOnOrigincorrectly requires/,?,#or exact match, and the test pins thewww.comfy.org.evil.comlookalike. Resolved. EventVideoDialog— the fallback now lands on/events/, and leavingcameFromDirectoryon/eventsis right, sinceisUrlUnderPathappends its own separator.
One new problem, and it is the one I caused. My mainNavigation.ts readability nit was cosmetic; the fix for it pulls learningTutorials.ts into the client:load header bundle on every page, and Rollup does not shake the data out — measured +17.9 KB raw / +3.4 KB gzip. Details and two one-line ways out are in the thread on that line. Requesting changes only for that; revert to the literal and I'm happy.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 1 |
| TRIVIAL | 1 |
TRIVIAL, no action needed unless you disagree: the privacy-policy sentence now displays https://www.comfy.org while linking to https://comfy.org/. Leaving legal copy alone is the right instinct, but the text and the target now disagree — worth a line to whoever owns that document rather than a code change here.
Two notes on the merge of main, neither a change request. src/config/redirects.ts (Astro's map) already uses slashed destinations, which is consistent with this PR; vercel.json still has slashless destinations and runs first, so /cloud/pricing/ still 308s to /pricing in production — that stays #19359's job, as you said. And CI has not finished on the merged head yet, so the link gate has not actually run against whatever main added while this branch was open. Worth a glance at website-build before merging.
Move categoryPath and tutorialPath into a data-free learningPaths module so mainNavigation no longer pulls learningTutorials into the eagerly hydrated HeaderMain island.
benjcooley
left a comment
There was a problem hiding this comment.
Re-review — c050608
The one thing I was blocking on is fixed, and fixed the better of the two ways I offered. learningPaths.ts holds categoryPath / tutorialPath with nothing but a type import, so after erasure it pulls in no module graph at all.
I re-ran the measurement against this branch's real source rather than trusting the shape of the diff:
base (no learning import) raw 640,193 gzip 160,312
+ categoryPath from ./learningPaths raw 640,233 gzip 160,332 (+40 B)
+ categoryPath from ./learningTutorials raw 663,027 gzip 165,240 (+22.8 KB)
The header pays 40 bytes. Approving.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 0 |
| TRIVIAL | 2 |
Both trivials are notes, not asks. The re-export shim in learningTutorials.ts keeps the expensive import path alive for a future caller — detail in the thread, fine as a follow-up or never. And the privacy-policy sentence still displays https://www.comfy.org while linking to the apex; that is a question for whoever owns the legal copy, not for this PR.
One thing to confirm before merging, and it is about CI rather than the code: the ca4ee837 run was cancelled when you pushed c050608, so website-build — and therefore check:link-slashes — has not completed a green run since main was merged in. Everything main added to the site while this branch was open goes through the new gate for the first time on this run. Worth a look at that job before you hit merge; if it is green, there is nothing left from me.
Summary across all three rounds: the route change is sound (normalizeRoute in isLocaleInvariantPath also fixed a latent /login mismatch), no double-slashes anywhere, every static path in the diff resolves 200 on production, the two zh-CN retargets were correct calls, and the gate now catches both the missing slash and the www host so the shape cannot come back.
…al-link-slashes # Conflicts: # apps/website/e2e/header-models-navigation.spec.ts # apps/website/src/components/common/HeaderMain/HeaderMainDesktop.test.ts # apps/website/src/components/workshop/FeaturedBanner.test.ts
benjcooley
left a comment
There was a problem hiding this comment.
Re-review — e45099f5 (merge of main; my previous approval was auto-dismissed)
No authored changes this round. The only new commit is a second merge of origin/main, which brought in 189 website files across eight PRs — the Hub design pass (#19320), Cinematic Studio video (#19370), the SDK snippet tab (#19323), and the Workshop analytics work. That is exactly the content I asked to see run through the new gate before merge, so that is what I checked.
The gate ran, and it ran green. Worth being precise about which job, because the check named website-build is the e2e workflow's build-and-upload step and does not contain the validation steps — I nearly misread that. The gate lives in the job named plainly build, in CI: Website Build. On this head its steps are:
5. Build website success
6. Validate JSON-LD structured data success
7. Validate llms.txt links success
8. Check internal links end with a slash success
9. Check hreflang clusters success
10. Verify the optional Workshop build exclusion success (runs check:link-slashes again on the WORKSHOP_IN_BUILD=0 build)
So main's new pages pass both builds. I also confirmed that independently rather than just trusting the green tick: applying this PR's own rule (internalLinkSlashes.ts's href regex plus the slashless and www tests) to every .vue / .astro / .ts / .mdx / .md / .txt file in apps/website finds zero offending hrefs at this head, and a set-diff against the pre-merge tree shows zero new slashless internal path literals arriving from main. Main added no new baseRoutes entries — only an externalLinks.workshopAppRepos map — so the "every route ends with a slash" invariant still holds by inspection, and the only slashless paths in the new workshop-display.json are .svg / .json asset URLs that the checker correctly skips.
Merge resolution is clean. Sixteen files were touched by both sides, including routes.ts, translations.ts, CinematicStudioPage.vue and six e2e specs — the places where a bad conflict resolution would quietly undo this PR. All of it survived: every route still slash-terminated, url.pathname = workshopAppHref(id, locale) still without the manual slash, cinematic-studio.astro still not appending one, four /pricing/#faq anchors and four apex pricing links present, zero comfy.org/cloud/pricing and zero www.comfy.org hrefs left, learningPaths.ts still type-imports only, and mainNavigation.ts still importing from ./learningPaths. The only slashless literals left in the shared specs are .svg / .json asset paths, which are right as they are.
Re-approving. All five threads from the earlier rounds stay resolved and nothing new came up.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 0 |
| TRIVIAL | 0 |
State of CI as I write this: 42 checks pass, 0 fail, 5 still running — website-e2e-shard (3, 4) and website-unit among them, with the other three e2e shards already green. lint, lint-and-format and the website typecheck are green, and I checked by hand that the routes.test.ts slash invariant holds against this head, so I have no specific reason to expect trouble from the two stragglers. Glance at them before you merge and this is done.
## Summary **Deploy gate: comfy-router#46 is merged and live (2026-09-30). Its follow-up comfy-router#48 (serves `/hub/models.md` instead of 301ing it to a /workflows 404) must be deployed before this merges. After the merge, purge Cloudflare for `/hub/models*`, `/hub/workflows*` and the 30 workflow names in `hub-workflow-names.json`. The redirects ship as 307; FE-3083 flips them to 308 later.** This branch combines every Workshop /models SEO PR, so merging it to main replaces merging them one by one. It also launches: Comfy-Org#19405 commits `launchedModelPages = 'all'`, so all 148 model pages become indexable in the same deploy as the URL move. Part of FE-2912, FE-2942 (PR 2 is FE-3086), FE-2974 (/minimax 308 is FE-3087) Fixes FE-2978, FE-2989, FE-2991, FE-2990, FE-2959, FE-2981, FE-2977, FE-2979, FE-3014, FE-2936, FE-2980, FE-2975, FE-3085, FE-2972, FE-2935, FE-2950, FE-2940, FE-2930, FE-2985, FE-2957, FE-2961, FE-2986, FE-2921, FE-2922, FE-2947 ## Changes Router follow-up: comfy-router#48 (`/hub/models.md` routing, 324/324 router tests), deploy before this merges. The included PRs, in merge order. Every head was checked as contained at the final tip. | PR | Ticket | What | Ben | |---|---|---|---| | Comfy-Org#18887 | FE-2978 | Pricing Product markup and full video `uploadDate` | approved | | Comfy-Org#18889 | FE-2989 | A unique meta description on every model page | approved | | Comfy-Org#18890 | FE-2991 | Model page JSON-LD, emitted once noindex lifts | approved | | Comfy-Org#18892 | FE-2990 | Cleaner tag pills, guard against duplicate summaries | approved | | Comfy-Org#18893 | FE-2959, 2981, 2977, 2979 | Social tags, hub title, Organization data. The FE-2977 title was confirmed by the owner | approved | | Comfy-Org#19362 | FE-3014 | Every non-production build is noindex | approved | | Comfy-Org#19366 | FE-2936 | Model titles lead with "API & Playground" | approved | | Comfy-Org#19402 | FE-2980 | Every internal link ends with a slash, plus a CI check | approved | | Comfy-Org#19419 | FE-2975 | Footer links the catalogue on every page and locale | approved | | Comfy-Org#19476 | FE-3085 | `NOINDEX_ROUTES` decides noindex for serverless-animation | approved; re-approval pending on a one-line follow-up (CodeRabbit approved) | | Comfy-Org#19359 | FE-2974 | One typed redirect list that generates `vercel.json` | approved | | Comfy-Org#19369 | FE-2972 A | The old to new model URL map | approved | | Comfy-Org#18891 | FE-2935 | Model content shows whatever the flag says | approved | | Comfy-Org#18899 | FE-2942 | Model pages render in the static HTML | approved | | Comfy-Org#18898 | FE-2950 | Catalogue h1 and A to Z links in the static HTML | approved | | Comfy-Org#19375 | FE-2940 | Related models leave no page unlinked | approved | | Comfy-Org#19385 | FE-2930 | Examples show the prompt that made them | approved | | Comfy-Org#19394 | FE-2985 | Render guard e2e: no loader, no layout shift | approved | | Comfy-Org#19357 | FE-2957 | robots.txt stops blocking our scripts and styles | approved | | Comfy-Org#19360 | FE-2961 | Turning Workshop off keeps every Models page | approved (a CodeRabbit changes-requested review is still open) | | Comfy-Org#19386 | FE-2986 | One registry of every Models address | approved | | Comfy-Org#19421 | FE-2972 B1 | Model pages served at `/hub/models` | approved | | Comfy-Org#19422 | FE-2972 B2 | Every old model URL redirects (307) | approved | | Comfy-Org#19424 | FE-2972 B3 | Workflow pages at `/hub/workflows` with redirects | approved | | Comfy-Org#19399 | FE-2921 | One switch decides model robots and sitemap listing | approved | | Comfy-Org#19404 | FE-2922 | Clean markdown twins for model pages | approved | | Comfy-Org#19405 | FE-2947 | Lifts noindex on every canonical model page | approved | | comfy-router#46 | FE-3075 | Serves `/hub/models*` from the website and routes `/hub/workflows` by manifest. Merged and live | merged | These fixes exist only on this branch, because they only break once two PRs meet: - `scripts/check-models-html.ts` reads each page at `model.href` and skips models without a page (f1df1e4). - `e2e/fixtures/modelsCatalogue.ts` reads `dist/hub/models` (f87bb4c). - `routerIdsByModelPage` accepts an optional `href`, since Comfy-Org#19421 made it optional and Comfy-Org#19405 no longer typechecked (9783819). - `ModelStatus` links a successor only when it has a page, for the same reason on Comfy-Org#18899 (c4761d8). - The model breadcrumb in `modelJsonLd.ts` points at `/hub/models/` instead of the `/models/` redirect (eb985b6). Its label still says "Models" while the nav says "Hub". - Twin, meta-description and entry tests use the hub pages and the new tag set (86ac3b0, d4ffc0f). - The render guard finds the catalogue through `getRoutes().workshop`, and its `test.fail` is gone now that Comfy-Org#18898 renders the h1 (831499f). - A new test renders a real model page and checks its markdown twin has the model's h1 (9a6c5cb). - Main's newer catalogue and workflow e2e cases use the hub addresses (2aeda77). - `resetWorkshopAccountSource` resets `decision`; a clean auto-merge of main's Comfy-Org#19454 into Comfy-Org#18891 left it assigning a variable that no longer exists (c28c7a7). The conflict resolutions, briefly: `ALTERNATE_TWIN_SOURCES` stays deleted as Comfy-Org#18898 wants, so `/hub/models.md` comes from the real catalogue. The hub keeps Comfy-Org#18898's single static h1 instead of the `WorkshopHero` h1 that main's Comfy-Org#19320 added. `ExamplesTab` keeps Comfy-Org#19385's figure and caption with main's video poster. The Comfy-Org#19399/Comfy-Org#19405 indexing tests were rewritten for hub paths. The Comfy-Org#19359 redirect test no longer builds `/enterprise//` from slash-ended routes. The Comfy-Org#19369 URL-map test imports `PROVIDER_NAMES` from its new home. The full table of 47 resolutions is in the integration report. ## Review Focus - Launch rides along with the URL move. If launch should stay a separate step, set `launchedModelPages` in `apps/website/src/config/model-page-launch.ts` to `new Set()` before merging. - Main's Comfy-Org#19320 gives the catalogue island its own h1 through `WorkshopHero`. This branch keeps Comfy-Org#18898's static h1 and renders only the subtitle in `ModelsCatalogue.vue`, so the hub has exactly one h1. - Comfy-Org#19476 overlaps the open community PR Comfy-Org#18591 (same sitemap exclusion for serverless-animation). One of them should be closed once this lands. ## QA - [x] Gates: `pnpm typecheck` and website typecheck clean, `pnpm lint` 0 errors, eslint on `apps/website` clean, `pnpm knip` clean - [x] Website unit: 547 files, 10347 passed, 4 skipped - [x] Build A (`build:e2e`, CI env): 1193 pages; release gate, `check:hreflang`, `validate:llms-txt-links` (225 links), `validate:jsonld` (947 pages), `check:link-slashes`, `check:models-html` (148 pages) all pass - [x] Build B (`WORKSHOP_IN_BUILD=0`): same 182 Models pages as the on build, no `dist/workshop`, `/` is noindex; with the flag stubbed on, no Run, no Hub nav and no Firebase requests - [x] Build C (preview shape): 945 of 945 pages noindex, no canonicals except redirect stubs, no hreflang in the sitemap - [x] E2E on Build A: 644 of 645 passed; the one mobile failure passed on rerun. Earlier load flakes (navigation, demos, fdct, wan-3.0, network isolation, render guard) all passed when rerun alone - [x] Launch: 148 model pages indexable with canonicals, 149 hub entries in the sitemap, 148 non-empty twins with the model h1, 148 in `llms-full.txt`, 0 titles over 60, 30 workflow pages still noindex - [x] Redirects: 853 rules, 782 to /hub all 307, the MiniMax rows 307, every /hub destination built - [x] comfy-router#46 under `wrangler dev` in front of this build: 312 router tests pass; 148 old model URLs (both slash forms) 307 then 200; 30 workflow names served by the website and their old URLs 307; a non-manifest workflow 302 with no-store; `manifest.json` passes through; `/workflows/` and bare `/hub` unchanged - [x] After the router deploys and this merges: purge Cloudflare, then curl `https://comfy.org/hub/models/` for a 200 and three old `/models/<slug>/` URLs for one 307 each - [x] Rich Results Test on `/pricing/` and `/learning/animations/character-sheet/`, then "Validate fix" on Merchant listings and Videos - [x] Rich Results Test on two live model pages: breadcrumbs valid and the breadcrumb URL returns 200 with no redirect - [x] GPTBot and Googlebot curls on the hub and one model page, then a GSC live test on both - [x] Resubmit the sitemap in Search Console and URL-inspect about 20 model pages on day 0 and day 14 - Not covered: Rich Results and GSC need production; the redirect matrix used a local shim for `vercel.json`, since `astro preview` ignores it --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: benjcooley <benjcooley@gmail.com> Co-authored-by: Deep Mehta <42841935+deepme987@users.noreply.github.com>
|
Superseded by the integration branch #19494, which combined this PR with every other Workshop SEO slice and has been merged to main. Closing this one. |
Summary
Every internal link on the website now uses the slash-terminated address our canonicals already use, so crawlers stop meeting a second, slashless copy of each page. A new build check keeps it that way.
Changes
routes.tsends with/, for all locales. The locale-invariant lookup now normalises the path, so/models/and/modelsare treated alike.https://comfy.org/...links all end with/. Query strings and anchors keep the slash in front of them (/models/?q=...,/cloud/pricing/#faq).check:link-slashesscript, run in CI after the build likevalidate:llms-txt-links. It scansdist/HTML for internal page hrefs without a trailing slash and fails with the list. Files (.md,.txt,.xml, fonts, assets) and external links are ignored./zh-CN/p/supported-models..., which doesn't exist (it 404s). They now point at/p/supported-models/, the only real page, instead of just getting a slash added.Review Focus
isLocaleInvariantPathinroutes.ts: this is the one logic change. The rest is string swaps./to a route (AppsBackLink,CinematicStudioPage,video-sitemap.xml.ts, and the redirects tests) no longer add it, so nothing ends up with//.trailingSlashinvercel.jsonand no redirect changes (feat(website): one typed redirect list, generated vercel.json #19359 / FE-2974 owns those), and no/modelsURL moves (FE-2972). Thewww.comfy.org/workflows/...links on supported-models pages andEventVideoDialog's JS navigation to/eventsaren'threfs this check sees, so they're left as they are.Fixes FE-2980
https://linear.app/comfyorg/issue/FE-2980/make-every-internal-link-end-with-a-slash