Repository navigation
feat(website): render the models catalogue heading and A to Z links as static HTML - #18898
MaanilVerma wants to merge 16 commits into
Conversation
…s static HTML /models/ now ships one h1, "ComfyUI models", and a plain link to every published model in its server HTML, outside the catalogue island, so a failed catalogue fetch or disabled JavaScript can no longer leave the page without a heading or model links. Shelf and browse-all titles become h2s and the showcase noscript fallback is gone from the hub.
Assert the raw /models/ HTML has one ComfyUI models h1 and links every published model, that both survive a failed catalogue fetch and disabled JavaScript, and move shelf heading checks to level 2.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌐 Website E2ETip All tests passed.
📦 Bundle Size
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 90bb942059e3ef05308bb05f21d085c40061ca7c
Full docs: ADR-DEVEX-LINT-0015 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-18898.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-av9cu0owc-comfyui.vercel.app Last updated: 2026-09-29T18:04:59Z for 🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
QA for FE-2950Checked on a local
Note: Not covered here: Lighthouse and the robots-honouring render script, GSC Live Test, and the 14-day query watch. Those are post-deploy checks on prod. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## maanil/fe-2935-content-not-flag-gated #18898 +/- ##
=========================================================================
- Coverage 84.12% 84.06% -0.07%
=========================================================================
Files 3189 3159 -30
Lines 155237 154277 -960
Branches 42015 41848 -167
=========================================================================
- Hits 130592 129690 -902
- Misses 22973 22974 +1
+ Partials 1672 1613 -59
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 306 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @MaanilVerma.
Found 7 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 2 |
| 🟢 Low | 3 |
| ⚪ Nit | 2 |
Panel: 8/8 reviewers contributed findings.
This comment has been minimized.
This comment has been minimized.
… guard an empty catalogue
benjcooley
left a comment
There was a problem hiding this comment.
Review summary
Read the change against workshop-browse-content.ts, the release gate, the twin and sitemap integrations, and the deployed preview.
No blockers. The directory is built from the same workshopModels array that feeds workshopPagePaths, so every link has a built page; the gate still swaps /models to showcase.astro when the workshop is out of the build, so nothing leaks from a gated build; and WorkshopLoading is noscript:hidden, so the JS-off page is heading + list with no spinner stuck in the middle. Verified on the preview: exactly one h1, 148 links, all unique, no duplicate anchor text. Scoping the existing specs to workshop-models-grid / workshop-sections was the right call now that 148 model names appear twice on the page.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 2 |
| TRIVIAL | 3 |
Worth answering before this merges
Every page this directory links to serves <meta name="robots" content="noindex, nofollow"> (checked on the preview), and /models/<slug> is excluded from the sitemap by isWorkshopRoute. Crawlers can now reach the model pages, but none of them will be indexed, and nofollow stops crawlers following links back out of them. #18890 ("inert while pages are noindex") suggests the flip is tracked elsewhere — worth confirming the sequencing, because until it lands this ships the cost without the benefit.
That cost is user-facing, not just bytes: the A-to-Z block is 1,576px tall at 1440px wide and sits at the bottom of the hub for every visitor. Worth a designer looking at the hub with it in place rather than treating it as an SEO-only affordance.
benjcooley
left a comment
There was a problem hiding this comment.
Requesting changes on one item; the rest of my inline comments are optional and can be waved off.
Required — /models.md now contradicts /models/.
markdown-twins.ts carries ALTERNATE_TWIN_SOURCES = new Map([['models', 'models/showcase']]). That mapping was correct before this PR, because /models/ had no static content worth twinning. This PR is what makes it wrong: the page now has an h1 and 148 model links, but the twin still opens with # Grok Imagine in ComfyUI, contains none of those links, and sets canonical: https://comfy.org/models/. Confirmed on the preview.
So the one surface built specifically for machine readers — the twin and its llms.txt entry — misses exactly the content this ticket adds, and misrepresents the page it claims to be. Dropping that map entry generates the twin from index.astro and gives llms.txt the same A-to-Z list.
Not blocking, already inline: the hero class duplication between index.astro and WorkshopHero.vue, the now-degenerate WorkshopHero call on the hub, the tautological set-equality in workshop-loading-flash.spec.ts (nothing navigates a directory link, so a wrong href shape passes every assertion), and the workshop.hub.* namespace already belonging to HubBrowse.
Still worth answering: every page this directory links to serves <meta name="robots" content="noindex, nofollow">, and /models/<slug> is excluded from the sitemap by isWorkshopRoute. Crawlers reach the pages; nothing indexes them. #18890 suggests that flip is tracked elsewhere — confirming the sequencing would settle whether the 1,576px link block should land now or with it.
The rest of the change holds up: every link has a built page via workshopPagePaths, disabled models stay excluded, the release gate still swaps /models to showcase.astro out of build, and the JS-off page degrades cleanly to heading + list.
The page now has its own heading and model list, so the twin no longer needs to borrow the showcase.
…talogue's headless hero The static /models heading and WorkshopHero now read their eyebrow and h1 classes from one module. ModelsCatalogue renders its subtitle and Browse all row directly, so WorkshopHero goes back to always having a heading.
Compare the directory links with the canonical model pages in dist instead of the array that renders them, and follow one link with JavaScript off.
…b.com/Comfy-Org/ComfyUI_frontend into maanil/fe-2950-catalogue-ssr
benjcooley
left a comment
There was a problem hiding this comment.
Re-review — approved
Checked the four fix commits (dfe4872e39, c58bf63b83, 6e062c9f9c, e7c12b96c4) and the base merge. Every item from the last round is genuinely addressed, not papered over.
Verified, not just read:
- Markdown twin.
ALTERNATE_TWIN_SOURCESis gone entirely along withreadBuiltTwinSource. On the preview,/models.mdnow opens# ComfyUI models, carries all 148 model links as real markdown list items, and contains no trace of Grok Imagine. This was the required item and it is fixed. - Shared heading classes.
workshopHeadingClasses.tsis imported by bothindex.astroandWorkshopHero.vue. One owner again. - Headless hero removed.
WorkshopHerois back to a requiredheadingwith bothheading &&guards deleted, andModelsCataloguerenders the subtitle row itself while keepingdata-testid="workshop-hero"so the in-sectiontoHaveCount(0)assertions still mean something. I re-measured the preview: hero row still at y=328, height 28, Browse-all at x=1216, document height 5633px — identical to my round-one measurements. The restructure is behaviour-preserving. - Directory test.
publishedModelSlugsnow readsdist/modelsand filters meta-refresh redirects, so the expectation comes from the build rather than from the same array that renders the list. That closes the tautology. The new JS-off test that clicks a directory link and lands on the model page is the coverage that was missing — that is the crawler path, tested end to end. - Translation keys moved to
workshop.catalogue.*.
All five threads resolved. CI green across lint, typecheck, unit, and all four e2e shards.
Non-blocking leftovers
- The dead
optionsparameter onhtmlToTwin, commented inline. /models.mdcarries a strayLoadingline from the island'srole="status"placeholder — you already called this out, and it is one word in an otherwise correct document. Fine to leave for FE-2922, but it is now the only twin in the build that shows it.- The non-empty guard moved out of the fixture into
workshop-loading-flash.spec.ts, soexpectHubHeadingAndDirectoryinworkshop-visibility.spec.tsassertstoHaveCount(publishedModelSlugs.size)with no floor of its own. The suite still catches an empty set via the other test, so this only bites when that file runs alone. A throw at module scope in the fixture would cover every consumer, and would also turn thereaddirSyncat import time into a clear message rather than an ENOENT that fails two spec files during collection —canonical-redirects.spec.tsreadsdistfrom inside a test body, which degrades more gracefully.
The noindex, nofollow sequencing question from last round is unchanged by the base merge and stays tracked elsewhere; not a reason to hold this.
…b.com/Comfy-Org/ComfyUI_frontend into maanil/fe-2950-catalogue-ssr
…gated' into maanil/fe-2950-catalogue-ssr # Conflicts: # apps/website/e2e/models-catalogue-corrections.spec.ts # apps/website/e2e/workshop-workflows.spec.ts # apps/website/src/components/workshop/ModelsCatalogue.test.ts # apps/website/src/components/workshop/ModelsCatalogue.vue
benjcooley
left a comment
There was a problem hiding this comment.
Re-review — approved
Scoped to the three commits since my last pass (d7b77228d3, bc579f4ab5, cd8e2b350f) plus the two base merges.
Both items from last round are fixed, verified in the source:
HtmlToTwinOptions, the thirdoptionsparameter, and theoptions.canonical ??branch are gone frommarkdown-twin.ts.htmlToTwin(html, fallbackCanonical)is a two-argument function again.- The fixture now throws at module load for both cases — missing
dist/modelsand a build with no model pages — so every consumer gets the floor, and the now-redundant in-test guard came out. That closes the gap whereworkshop-visibility.spec.tscould have passed vacuously on its own.
cd8e2b350f is the interesting one, and it's a real catch. Main's Hub V2 added a /models/apps/[app] route, so dist/models/apps/ now exists as a namespace folder with no index.html. Without that commit the fixture would have thrown ENOENT at import. Adding apps to NON_MODEL_ROUTES plus the existsSync(page) guard handles it, and the failure direction stays safe: a future non-model route under /models/ lands in the expected set, mismatches the directory, and fails loudly rather than passing wrongly. The denylist is a maintenance coupling worth remembering, not worth restructuring.
On the merge resolution: switching the static eyebrow from workshop.hero.eyebrow to workshop.catalogue.eyebrow is correct, and it's the sort of thing that could easily have gone the other way. Main's ModelsCatalogue.vue already passes workshop.catalogue.eyebrow to its hero, so leaving the old key would have silently reverted main's "Models" to "Hub" copy change at the moment this PR lifted the eyebrow out of the island. Confirmed on the preview: one h1, one eyebrow reading Hub, 148 unique directory links, hero row still 28px and document height still 5633px — identical geometry to two rounds ago. Adding the eyebrow assertion alongside the h1 one was the right instinct; one note inline on how it's anchored.
/models.md still carries the 148 links and the stray Loading line is gone. CI green across build, lint, typecheck, unit, and all four e2e shards.
Nothing blocking. Ship it.
…gated' into maanil/fe-2950-catalogue-ssr
benjcooley
left a comment
There was a problem hiding this comment.
Re-review — approved
One substantive commit since last pass (3a1af28563) plus a base merge.
The eyebrow assertion is fixed as suggested — />\s*Hub\s*<\/p>/, no utility class in the pattern. I checked it against the real built HTML rather than just reading it: the regex matches exactly once on the deployed preview, and the single match is the eyebrow paragraph, so loosening the anchor didn't buy a false positive. A restyle of the eyebrow now leaves the test alone while a copy change still trips it.
The base merge (d13a73de8f) touches workshop-visibility.spec.ts, which this PR also edits, so I checked the resolution rather than assuming: base only renamed recordFirebaseRequests to recordAccountRequests and widened its URL filter, in tests unrelated to this PR's additions. expectHubHeadingAndDirectory, the catalogue-failure test, and the JS-off directory click-through are all intact on head. The rest of that merge is main-app src/ code with no bearing here.
Preview still checks out: one h1, 148 unique directory links, eyebrow reading Hub.
One note, not an objection: website-unit and all four website-e2e shards were still queued when I looked — lint, typecheck, and website-build are green. Given the only change is a one-line test regex I verified by hand, I'm comfortable approving ahead of them, but worth a glance at the e2e result before merging rather than taking the approval as cover.
Nothing outstanding from my side.
## Summary **Deploy gate: comfy-router#46 is merged and live (2026-09-30). Its follow-up comfy-router#48 (serves `/hub/models.md` instead of 301ing it to a /workflows 404) must be deployed before this merges. After the merge, purge Cloudflare for `/hub/models*`, `/hub/workflows*` and the 30 workflow names in `hub-workflow-names.json`. The redirects ship as 307; FE-3083 flips them to 308 later.** This branch combines every Workshop /models SEO PR, so merging it to main replaces merging them one by one. It also launches: Comfy-Org#19405 commits `launchedModelPages = 'all'`, so all 148 model pages become indexable in the same deploy as the URL move. Part of FE-2912, FE-2942 (PR 2 is FE-3086), FE-2974 (/minimax 308 is FE-3087) Fixes FE-2978, FE-2989, FE-2991, FE-2990, FE-2959, FE-2981, FE-2977, FE-2979, FE-3014, FE-2936, FE-2980, FE-2975, FE-3085, FE-2972, FE-2935, FE-2950, FE-2940, FE-2930, FE-2985, FE-2957, FE-2961, FE-2986, FE-2921, FE-2922, FE-2947 ## Changes Router follow-up: comfy-router#48 (`/hub/models.md` routing, 324/324 router tests), deploy before this merges. The included PRs, in merge order. Every head was checked as contained at the final tip. | PR | Ticket | What | Ben | |---|---|---|---| | Comfy-Org#18887 | FE-2978 | Pricing Product markup and full video `uploadDate` | approved | | Comfy-Org#18889 | FE-2989 | A unique meta description on every model page | approved | | Comfy-Org#18890 | FE-2991 | Model page JSON-LD, emitted once noindex lifts | approved | | Comfy-Org#18892 | FE-2990 | Cleaner tag pills, guard against duplicate summaries | approved | | Comfy-Org#18893 | FE-2959, 2981, 2977, 2979 | Social tags, hub title, Organization data. The FE-2977 title was confirmed by the owner | approved | | Comfy-Org#19362 | FE-3014 | Every non-production build is noindex | approved | | Comfy-Org#19366 | FE-2936 | Model titles lead with "API & Playground" | approved | | Comfy-Org#19402 | FE-2980 | Every internal link ends with a slash, plus a CI check | approved | | Comfy-Org#19419 | FE-2975 | Footer links the catalogue on every page and locale | approved | | Comfy-Org#19476 | FE-3085 | `NOINDEX_ROUTES` decides noindex for serverless-animation | approved; re-approval pending on a one-line follow-up (CodeRabbit approved) | | Comfy-Org#19359 | FE-2974 | One typed redirect list that generates `vercel.json` | approved | | Comfy-Org#19369 | FE-2972 A | The old to new model URL map | approved | | Comfy-Org#18891 | FE-2935 | Model content shows whatever the flag says | approved | | Comfy-Org#18899 | FE-2942 | Model pages render in the static HTML | approved | | Comfy-Org#18898 | FE-2950 | Catalogue h1 and A to Z links in the static HTML | approved | | Comfy-Org#19375 | FE-2940 | Related models leave no page unlinked | approved | | Comfy-Org#19385 | FE-2930 | Examples show the prompt that made them | approved | | Comfy-Org#19394 | FE-2985 | Render guard e2e: no loader, no layout shift | approved | | Comfy-Org#19357 | FE-2957 | robots.txt stops blocking our scripts and styles | approved | | Comfy-Org#19360 | FE-2961 | Turning Workshop off keeps every Models page | approved (a CodeRabbit changes-requested review is still open) | | Comfy-Org#19386 | FE-2986 | One registry of every Models address | approved | | Comfy-Org#19421 | FE-2972 B1 | Model pages served at `/hub/models` | approved | | Comfy-Org#19422 | FE-2972 B2 | Every old model URL redirects (307) | approved | | Comfy-Org#19424 | FE-2972 B3 | Workflow pages at `/hub/workflows` with redirects | approved | | Comfy-Org#19399 | FE-2921 | One switch decides model robots and sitemap listing | approved | | Comfy-Org#19404 | FE-2922 | Clean markdown twins for model pages | approved | | Comfy-Org#19405 | FE-2947 | Lifts noindex on every canonical model page | approved | | comfy-router#46 | FE-3075 | Serves `/hub/models*` from the website and routes `/hub/workflows` by manifest. Merged and live | merged | These fixes exist only on this branch, because they only break once two PRs meet: - `scripts/check-models-html.ts` reads each page at `model.href` and skips models without a page (f1df1e4). - `e2e/fixtures/modelsCatalogue.ts` reads `dist/hub/models` (f87bb4c). - `routerIdsByModelPage` accepts an optional `href`, since Comfy-Org#19421 made it optional and Comfy-Org#19405 no longer typechecked (9783819). - `ModelStatus` links a successor only when it has a page, for the same reason on Comfy-Org#18899 (c4761d8). - The model breadcrumb in `modelJsonLd.ts` points at `/hub/models/` instead of the `/models/` redirect (eb985b6). Its label still says "Models" while the nav says "Hub". - Twin, meta-description and entry tests use the hub pages and the new tag set (86ac3b0, d4ffc0f). - The render guard finds the catalogue through `getRoutes().workshop`, and its `test.fail` is gone now that Comfy-Org#18898 renders the h1 (831499f). - A new test renders a real model page and checks its markdown twin has the model's h1 (9a6c5cb). - Main's newer catalogue and workflow e2e cases use the hub addresses (2aeda77). - `resetWorkshopAccountSource` resets `decision`; a clean auto-merge of main's Comfy-Org#19454 into Comfy-Org#18891 left it assigning a variable that no longer exists (c28c7a7). The conflict resolutions, briefly: `ALTERNATE_TWIN_SOURCES` stays deleted as Comfy-Org#18898 wants, so `/hub/models.md` comes from the real catalogue. The hub keeps Comfy-Org#18898's single static h1 instead of the `WorkshopHero` h1 that main's Comfy-Org#19320 added. `ExamplesTab` keeps Comfy-Org#19385's figure and caption with main's video poster. The Comfy-Org#19399/Comfy-Org#19405 indexing tests were rewritten for hub paths. The Comfy-Org#19359 redirect test no longer builds `/enterprise//` from slash-ended routes. The Comfy-Org#19369 URL-map test imports `PROVIDER_NAMES` from its new home. The full table of 47 resolutions is in the integration report. ## Review Focus - Launch rides along with the URL move. If launch should stay a separate step, set `launchedModelPages` in `apps/website/src/config/model-page-launch.ts` to `new Set()` before merging. - Main's Comfy-Org#19320 gives the catalogue island its own h1 through `WorkshopHero`. This branch keeps Comfy-Org#18898's static h1 and renders only the subtitle in `ModelsCatalogue.vue`, so the hub has exactly one h1. - Comfy-Org#19476 overlaps the open community PR Comfy-Org#18591 (same sitemap exclusion for serverless-animation). One of them should be closed once this lands. ## QA - [x] Gates: `pnpm typecheck` and website typecheck clean, `pnpm lint` 0 errors, eslint on `apps/website` clean, `pnpm knip` clean - [x] Website unit: 547 files, 10347 passed, 4 skipped - [x] Build A (`build:e2e`, CI env): 1193 pages; release gate, `check:hreflang`, `validate:llms-txt-links` (225 links), `validate:jsonld` (947 pages), `check:link-slashes`, `check:models-html` (148 pages) all pass - [x] Build B (`WORKSHOP_IN_BUILD=0`): same 182 Models pages as the on build, no `dist/workshop`, `/` is noindex; with the flag stubbed on, no Run, no Hub nav and no Firebase requests - [x] Build C (preview shape): 945 of 945 pages noindex, no canonicals except redirect stubs, no hreflang in the sitemap - [x] E2E on Build A: 644 of 645 passed; the one mobile failure passed on rerun. Earlier load flakes (navigation, demos, fdct, wan-3.0, network isolation, render guard) all passed when rerun alone - [x] Launch: 148 model pages indexable with canonicals, 149 hub entries in the sitemap, 148 non-empty twins with the model h1, 148 in `llms-full.txt`, 0 titles over 60, 30 workflow pages still noindex - [x] Redirects: 853 rules, 782 to /hub all 307, the MiniMax rows 307, every /hub destination built - [x] comfy-router#46 under `wrangler dev` in front of this build: 312 router tests pass; 148 old model URLs (both slash forms) 307 then 200; 30 workflow names served by the website and their old URLs 307; a non-manifest workflow 302 with no-store; `manifest.json` passes through; `/workflows/` and bare `/hub` unchanged - [x] After the router deploys and this merges: purge Cloudflare, then curl `https://comfy.org/hub/models/` for a 200 and three old `/models/<slug>/` URLs for one 307 each - [x] Rich Results Test on `/pricing/` and `/learning/animations/character-sheet/`, then "Validate fix" on Merchant listings and Videos - [x] Rich Results Test on two live model pages: breadcrumbs valid and the breadcrumb URL returns 200 with no redirect - [x] GPTBot and Googlebot curls on the hub and one model page, then a GSC live test on both - [x] Resubmit the sitemap in Search Console and URL-inspect about 20 model pages on day 0 and day 14 - Not covered: Rich Results and GSC need production; the redirect matrix used a local shim for `vercel.json`, since `astro preview` ignores it --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: benjcooley <benjcooley@gmail.com> Co-authored-by: Deep Mehta <42841935+deepme987@users.noreply.github.com>
|
Superseded by the integration branch #19494, which combined this PR with every other Workshop SEO slice and has been merged to main. Closing this one. |
Summary
The raw HTML of /models/ now has one h1, "ComfyUI models", and a plain link to every published model, so crawlers can reach all model pages from the one catalogue page that already ranks.
Fixes FE-2950 (https://linear.app/comfyorg/issue/FE-2950/build-the-models-catalogue-as-real-html-with-a-link-to-every-model)
Stacked on #18891 (FE-2935). Retarget to main once that merges.
Changes
routes/models/index.astroserver-renders the eyebrow, the h1 and an "All models A to Z" list built fromworkshopModelsat build time. None of it sits inside an island, so a failedcatalogue.jsonfetch or disabled JavaScript can't remove it./models/showcase/is untouched.ModelsCatalogueno longer passes a heading toWorkshopHero. The hero only renders an h1 (and its bleed spacing) when it gets one, soHubBrowseis unchanged.WorkshopModelsGridandWorkflowCatalogueare h2s now, so the page keeps exactly one h1 in every view.workshop.hub.heading. fix(website): social and structured-data head tags for /models #18893 editsworkshop.hero.headingandworkshop.hero.subtitle, which the hub no longer shows as its heading, so the two merge cleanly and the subtitle picks up "What will you make next?" once fix(website): social and structured-data head tags for /models #18893 lands.Changed from the ticket:
catalogue.jsoninstead of taking all models as props. The fixed heading and list stay put around it, and CLS measured 0 on base and on this branch.scripts/check-models-html.ts. FE-2942 is adding that script in parallel, so the hub assertions live in the existingworkshop-loading-flashe2e instead, which checks the raw HTML against every published slug.test.fail()exists on this base yet, so that step doesn't apply here.Review focus
WorkshopHero.vue: the negative top margin now applies only when there's a heading. With it, the hub hero overlapped the new static h1 and swallowed clicks on it.index.astro: the A to Z list sits below the island. Before hydration the loader is a full viewport tall, so the list starts below the fold and doesn't move anything on screen when the catalogue swaps in.