Skip to content

feat(website): render the models catalogue heading and A to Z links as static HTML - #18898

Closed
MaanilVerma wants to merge 16 commits into
maanil/fe-2935-content-not-flag-gatedfrom
maanil/fe-2950-catalogue-ssr
Closed

MaanilVerma wants to merge 16 commits into
maanil/fe-2935-content-not-flag-gatedfrom
maanil/fe-2950-catalogue-ssr

Conversation

@MaanilVerma

@MaanilVerma MaanilVerma commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The raw HTML of /models/ now has one h1, "ComfyUI models", and a plain link to every published model, so crawlers can reach all model pages from the one catalogue page that already ranks.

Fixes FE-2950 (https://linear.app/comfyorg/issue/FE-2950/build-the-models-catalogue-as-real-html-with-a-link-to-every-model)

Stacked on #18891 (FE-2935). Retarget to main once that merges.

Changes

  • routes/models/index.astro server-renders the eyebrow, the h1 and an "All models A to Z" list built from workshopModels at build time. None of it sits inside an island, so a failed catalogue.json fetch or disabled JavaScript can't remove it.
  • The showcase noscript fallback is gone from the hub. /models/showcase/ is untouched.
  • ModelsCatalogue no longer passes a heading to WorkshopHero. The hero only renders an h1 (and its bleed spacing) when it gets one, so HubBrowse is unchanged.
  • The shelf and browse-all titles in WorkshopModelsGrid and WorkflowCatalogue are h2s now, so the page keeps exactly one h1 in every view.
  • The h1 copy uses a new key, workshop.hub.heading. fix(website): social and structured-data head tags for /models #18893 edits workshop.hero.heading and workshop.hero.subtitle, which the hub no longer shows as its heading, so the two merge cleanly and the subtitle picks up "What will you make next?" once fix(website): social and structured-data head tags for /models #18893 lands.

Changed from the ticket:

  • The catalogue island still fetches catalogue.json instead of taking all models as props. The fixed heading and list stay put around it, and CLS measured 0 on base and on this branch.
  • No scripts/check-models-html.ts. FE-2942 is adding that script in parallel, so the hub assertions live in the existing workshop-loading-flash e2e instead, which checks the raw HTML against every published slug.
  • No CLS guard to un-test.fail() exists on this base yet, so that step doesn't apply here.

Review focus

  • WorkshopHero.vue: the negative top margin now applies only when there's a heading. With it, the hub hero overlapped the new static h1 and swallowed clicks on it.
  • index.astro: the A to Z list sits below the island. Before hydration the loader is a full viewport tall, so the list starts below the fold and doesn't move anything on screen when the catalogue swaps in.

…s static HTML

/models/ now ships one h1, "ComfyUI models", and a plain link to every
published model in its server HTML, outside the catalogue island, so a
failed catalogue fetch or disabled JavaScript can no longer leave the page
without a heading or model links. Shelf and browse-all titles become h2s
and the showcase noscript fallback is gone from the hub.
Assert the raw /models/ HTML has one ComfyUI models h1 and links every
published model, that both survive a failed catalogue fetch and disabled
JavaScript, and move shelf heading checks to level 2.
@MaanilVerma MaanilVerma added the cursor-review Trigger multi-model Cursor agent review on this PR label Sep 25, 2026
@MaanilVerma MaanilVerma self-assigned this Sep 25, 2026
@vercel

vercel Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 29, 2026 5:44pm UTC
billing-web-test Ignored Ignored Sep 29, 2026 5:44pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 45fbe0d2-9021-4c3a-9e9c-67fcc3b2bca8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

📦 Bundle Size

⏳ Size data collection in progress…

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 90bb942059e3ef05308bb05f21d085c40061ca7c

Full docs: ADR-DEVEX-LINT-0015

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-18898.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-av9cu0owc-comfyui.vercel.app

Last updated: 2026-09-29T18:04:59Z for d13a73d

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 25, 2026
@MaanilVerma

MaanilVerma commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator Author

QA for FE-2950

Checked on a local pnpm build of this branch against the #18891 base (a2ab4c0), on the Vercel preview, and against prod. Before is the base branch, after is this PR.

Check Proof Result
Raw dist/models/index.html (template, noscript, script and style stripped) has exactly one h1, "ComfyUI models" python3 check.py dist/models/index.html (the ticket's regex): before h1: [], after h1: ['ComfyUI models'] pass
Unique /models/<slug>/ hrefs equal the published model count workshopModels.length = 148 (tsx). Before model_links: 0, after model_links: 148. The e2e compares the set against the router slugs in catalogue.json pass
No showcase copy in the page before grok_all: 1 ("Grok Imagine in ComfyUI" in noscript), after grok_all: 0. "Grok Imagine" outside noscript is 8 on this branch: those are the eight Grok Imagine model names in the A to Z list, which the ticket expects pass
Ticket curl as Googlebot and GPTBot on the preview HOST=https://comfy-website-preview-pr-18898.vercel.app: h1: ['ComfyUI models'] grok_all: 0 loading_live: 1 model_links: 148 for both user agents. Prod today: h1: [] grok_all: 2 loading_live: 1 model_links: 0 pass (see note on loading_live)
No layout jump on hydrate, flag on and off, 412x915 and 1440x900 Playwright + layout-shift observer, 4 s after load. Preview: CLS 0 to 0.0002 in all 8 runs. Base preview #18891: 0 to 0.0004. Locally with catalogue.json delayed 1.5 s: 0 on both viewports pass
Hub survives catalogue.json failing Route to 500: before h1: [] links: 0 (error panel only), after h1: ['ComfyUI models'] links: 148 with the error panel and Retry inside the island. New e2e workshop-visibility "/models/ keeps its heading and model links when the catalogue fails" pass
JavaScript off Playwright javaScriptEnabled: false: before h1 "Grok Imagine in ComfyUI", 0 model links; after h1 "ComfyUI models", 148 visible links, loader hidden. New e2e "/models/ shows its heading and every model link" pass
Opening a shelf or Browse all never adds an h1 Before: h1 becomes "Generate videos 24" / "All models 148". After: h1 stays "ComfyUI models", shelf titles are h2 (unit tests in WorkshopModelsGrid.test.ts, ModelsCatalogue.test.ts) pass
Search, filters, shelves, Browse all work as before pnpm exec playwright test on workshop, workshop-workflows, models-performance, models-catalogue-corrections, models-row-arrows, header-models-navigation, homepage, router, loading-flash, visibility: 79 passed, 6 failed. The same 6 fail on the base build locally (model-page rollout note, sign-in and API tab, workflow launch form), so they are not from this diff pass
WORKSHOP_IN_BUILD=0 still builds WORKSHOP_IN_BUILD=0 pnpm build: exit 0, 1018 pages, /models/ is the showcase with 0 model links (no links to pages that don't exist) pass
HTML size dist/models/index.html 76,809 bytes before, 85,298 after pass
Unit tests pnpm exec vitest run in apps/website: 450 files, 8966 passed pass
Typecheck, lint, format, knip pnpm typecheck:website 0 errors; pnpm exec eslint on touched files clean; pnpm format:astro:check clean; pnpm knip exit 0 pass
Review follow-up (7 automated threads) 903e14c: numeric A to Z sort, provider span guarded. 4601b75: catalogue fixture asserts ok + non-empty, hub test checks the SSR loading frame, links matched only inside models-directory with no duplicates, shelf click scoped. Rebuilt dist/models/index.html: h1: ['ComfyUI models'] grok_all: 0 model_links: 148, 0 dangling separators. Hub e2e (loading-flash, visibility, workshop, catalogue-corrections): 42 passed, the 5 failures are the same ones that fail on the base build locally. Locale thread declined (route is locale-invariant) pass
Ben review follow-up dfe4872: /models.md is built from the hub, with 1 # ComfyUI models heading, 148 unique model links and 0 showcase lines. c58bf63: copy keys moved to workshop.catalogue.*. 6e062c9: heading classes shared via workshopHeadingClasses.ts, and WorkshopHero is no longer used on the hub. Before/after screenshots: 390 identical, 1440 differs by 3 px in a card placeholder, and Browse all sits at the same spot at both widths. e7c12b9: directory links compared against the non-redirect pages in dist/models; the test goes red when one link is removed from the built hub and green when it is restored; new JS-off test clicks a directory link to the model page. After merging #18891 at ad53e5f: vitest 8971 passed; typecheck 0 errors; knip clean; dist/models/index.html still has h1: ['ComfyUI models'] model_links: 148; hub e2e 55 passed, and the 6 failures also fail on the base build locally pass
Ben round 2 follow-up d7b7722: dead HtmlToTwinOptions and the canonical override removed from htmlToTwin; twin and WorkshopGate unit tests 19 passed, typecheck 0 errors, /models.md still has 1 h1 and 148 links. bc579f4: the models fixture throws "build the website first" when dist/models is missing or has no model pages, checked by listing the specs in both cases. Merged #18891 at 393384c (fa89529): workshop unit tests 505 passed, typecheck 0 errors. Hub e2e: 10 passed; the 3 failures also fail on the base build locally pass
Fixture after main merge cd8e2b3: the models fixture now reads only folders with an index.html and skips apps, showcase and workflows, which fixes the CI ENOENT on dist/models/apps/index.html. The missing or empty dist error is unchanged. On a fresh build, workshop-loading-flash and workshop-visibility: 10 passed, including the directory-equals-built-pages test (148). The 3 failures also fail on the base build locally pass

Note: loading_live: 1 is the island's "Loading" placeholder, which the ticket expected to reach 0 via full SSR of the catalogue. This PR keeps the fetch (see the PR description), so the placeholder stays in the HTML. It is hidden with JS off and replaced on hydrate. Crawlers still get the h1 and all 148 links.

Not covered here: Lighthouse and the robots-honouring render script, GSC Live Test, and the 14-day query watch. Those are post-deploy checks on prod.

@codecov

codecov Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                            Coverage Diff                            @@
##           maanil/fe-2935-content-not-flag-gated   #18898      +/-   ##
=========================================================================
- Coverage                                  84.12%   84.06%   -0.07%     
=========================================================================
  Files                                       3189     3159      -30     
  Lines                                     155237   154277     -960     
  Branches                                   42015    41848     -167     
=========================================================================
- Hits                                      130592   129690     -902     
- Misses                                     22973    22974       +1     
+ Partials                                    1672     1613      -59     
Flag Coverage Δ
website-unit 78.89% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ebsite/src/components/workshop/ModelsCatalogue.vue 96.96% <100.00%> (+0.04%) ⬆️
...pps/website/src/components/workshop/ModelsPage.vue 86.53% <ø> (ø)
...site/src/components/workshop/WorkflowCatalogue.vue 90.90% <ø> (ø)
...s/website/src/components/workshop/WorkshopHero.vue 85.71% <100.00%> (+10.71%) ⬆️
...ite/src/components/workshop/WorkshopModelsGrid.vue 92.63% <ø> (ø)
.../src/components/workshop/workshopHeadingClasses.ts 100.00% <100.00%> (ø)
apps/website/src/i18n/translations.ts 100.00% <ø> (ø)
apps/website/src/integrations/markdown-twins.ts 80.00% <100.00%> (-1.64%) ⬇️
apps/website/src/lib/markdown-twin.ts 81.73% <ø> (-0.18%) ⬇️

... and 306 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @MaanilVerma.

Found 7 finding(s).

Severity Count
🟡 Medium 2
🟢 Low 3
⚪ Nit 2

Panel: 8/8 reviewers contributed findings.

@datadog-official

This comment has been minimized.

@vercel
vercel Bot temporarily deployed to Preview – billing-web-test September 25, 2026 19:08 Inactive

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

Read the change against workshop-browse-content.ts, the release gate, the twin and sitemap integrations, and the deployed preview.

No blockers. The directory is built from the same workshopModels array that feeds workshopPagePaths, so every link has a built page; the gate still swaps /models to showcase.astro when the workshop is out of the build, so nothing leaks from a gated build; and WorkshopLoading is noscript:hidden, so the JS-off page is heading + list with no spinner stuck in the middle. Verified on the preview: exactly one h1, 148 links, all unique, no duplicate anchor text. Scoping the existing specs to workshop-models-grid / workshop-sections was the right call now that 148 model names appear twice on the page.

Severity Count
BLOCKER 0
SHOULD FIX 2
TRIVIAL 3

Worth answering before this merges

Every page this directory links to serves <meta name="robots" content="noindex, nofollow"> (checked on the preview), and /models/<slug> is excluded from the sitemap by isWorkshopRoute. Crawlers can now reach the model pages, but none of them will be indexed, and nofollow stops crawlers following links back out of them. #18890 ("inert while pages are noindex") suggests the flip is tracked elsewhere — worth confirming the sequencing, because until it lands this ships the cost without the benefit.

That cost is user-facing, not just bytes: the A-to-Z block is 1,576px tall at 1440px wide and sits at the bottom of the hub for every visitor. Worth a designer looking at the hub with it in place rather than treating it as an SEO-only affordance.

Comment thread apps/website/src/i18n/translations.ts Resolved

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes on one item; the rest of my inline comments are optional and can be waved off.

Required — /models.md now contradicts /models/.

markdown-twins.ts carries ALTERNATE_TWIN_SOURCES = new Map([['models', 'models/showcase']]). That mapping was correct before this PR, because /models/ had no static content worth twinning. This PR is what makes it wrong: the page now has an h1 and 148 model links, but the twin still opens with # Grok Imagine in ComfyUI, contains none of those links, and sets canonical: https://comfy.org/models/. Confirmed on the preview.

So the one surface built specifically for machine readers — the twin and its llms.txt entry — misses exactly the content this ticket adds, and misrepresents the page it claims to be. Dropping that map entry generates the twin from index.astro and gives llms.txt the same A-to-Z list.

Not blocking, already inline: the hero class duplication between index.astro and WorkshopHero.vue, the now-degenerate WorkshopHero call on the hub, the tautological set-equality in workshop-loading-flash.spec.ts (nothing navigates a directory link, so a wrong href shape passes every assertion), and the workshop.hub.* namespace already belonging to HubBrowse.

Still worth answering: every page this directory links to serves <meta name="robots" content="noindex, nofollow">, and /models/<slug> is excluded from the sitemap by isWorkshopRoute. Crawlers reach the pages; nothing indexes them. #18890 suggests that flip is tracked elsewhere — confirming the sequencing would settle whether the 1,576px link block should land now or with it.

The rest of the change holds up: every link has a built page via workshopPagePaths, disabled models stay excluded, the release gate still swaps /models to showcase.astro out of build, and the JS-off page degrades cleanly to heading + list.

The page now has its own heading and model list, so the twin no longer
needs to borrow the showcase.
…talogue's headless hero

The static /models heading and WorkshopHero now read their eyebrow and h1
classes from one module. ModelsCatalogue renders its subtitle and Browse
all row directly, so WorkshopHero goes back to always having a heading.
Compare the directory links with the canonical model pages in dist
instead of the array that renders them, and follow one link with
JavaScript off.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — approved

Checked the four fix commits (dfe4872e39, c58bf63b83, 6e062c9f9c, e7c12b96c4) and the base merge. Every item from the last round is genuinely addressed, not papered over.

Verified, not just read:

  • Markdown twin. ALTERNATE_TWIN_SOURCES is gone entirely along with readBuiltTwinSource. On the preview, /models.md now opens # ComfyUI models, carries all 148 model links as real markdown list items, and contains no trace of Grok Imagine. This was the required item and it is fixed.
  • Shared heading classes. workshopHeadingClasses.ts is imported by both index.astro and WorkshopHero.vue. One owner again.
  • Headless hero removed. WorkshopHero is back to a required heading with both heading && guards deleted, and ModelsCatalogue renders the subtitle row itself while keeping data-testid="workshop-hero" so the in-section toHaveCount(0) assertions still mean something. I re-measured the preview: hero row still at y=328, height 28, Browse-all at x=1216, document height 5633px — identical to my round-one measurements. The restructure is behaviour-preserving.
  • Directory test. publishedModelSlugs now reads dist/models and filters meta-refresh redirects, so the expectation comes from the build rather than from the same array that renders the list. That closes the tautology. The new JS-off test that clicks a directory link and lands on the model page is the coverage that was missing — that is the crawler path, tested end to end.
  • Translation keys moved to workshop.catalogue.*.

All five threads resolved. CI green across lint, typecheck, unit, and all four e2e shards.

Non-blocking leftovers

  1. The dead options parameter on htmlToTwin, commented inline.
  2. /models.md carries a stray Loading line from the island's role="status" placeholder — you already called this out, and it is one word in an otherwise correct document. Fine to leave for FE-2922, but it is now the only twin in the build that shows it.
  3. The non-empty guard moved out of the fixture into workshop-loading-flash.spec.ts, so expectHubHeadingAndDirectory in workshop-visibility.spec.ts asserts toHaveCount(publishedModelSlugs.size) with no floor of its own. The suite still catches an empty set via the other test, so this only bites when that file runs alone. A throw at module scope in the fixture would cover every consumer, and would also turn the readdirSync at import time into a clear message rather than an ENOENT that fails two spec files during collection — canonical-redirects.spec.ts reads dist from inside a test body, which degrades more gracefully.

The noindex, nofollow sequencing question from last round is unchanged by the base merge and stays tracked elsewhere; not a reason to hold this.

…gated' into maanil/fe-2950-catalogue-ssr

# Conflicts:
#	apps/website/e2e/models-catalogue-corrections.spec.ts
#	apps/website/e2e/workshop-workflows.spec.ts
#	apps/website/src/components/workshop/ModelsCatalogue.test.ts
#	apps/website/src/components/workshop/ModelsCatalogue.vue

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — approved

Scoped to the three commits since my last pass (d7b77228d3, bc579f4ab5, cd8e2b350f) plus the two base merges.

Both items from last round are fixed, verified in the source:

  • HtmlToTwinOptions, the third options parameter, and the options.canonical ?? branch are gone from markdown-twin.ts. htmlToTwin(html, fallbackCanonical) is a two-argument function again.
  • The fixture now throws at module load for both cases — missing dist/models and a build with no model pages — so every consumer gets the floor, and the now-redundant in-test guard came out. That closes the gap where workshop-visibility.spec.ts could have passed vacuously on its own.

cd8e2b350f is the interesting one, and it's a real catch. Main's Hub V2 added a /models/apps/[app] route, so dist/models/apps/ now exists as a namespace folder with no index.html. Without that commit the fixture would have thrown ENOENT at import. Adding apps to NON_MODEL_ROUTES plus the existsSync(page) guard handles it, and the failure direction stays safe: a future non-model route under /models/ lands in the expected set, mismatches the directory, and fails loudly rather than passing wrongly. The denylist is a maintenance coupling worth remembering, not worth restructuring.

On the merge resolution: switching the static eyebrow from workshop.hero.eyebrow to workshop.catalogue.eyebrow is correct, and it's the sort of thing that could easily have gone the other way. Main's ModelsCatalogue.vue already passes workshop.catalogue.eyebrow to its hero, so leaving the old key would have silently reverted main's "Models" to "Hub" copy change at the moment this PR lifted the eyebrow out of the island. Confirmed on the preview: one h1, one eyebrow reading Hub, 148 unique directory links, hero row still 28px and document height still 5633px — identical geometry to two rounds ago. Adding the eyebrow assertion alongside the h1 one was the right instinct; one note inline on how it's anchored.

/models.md still carries the 148 links and the stray Loading line is gone. CI green across build, lint, typecheck, unit, and all four e2e shards.

Nothing blocking. Ship it.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review — approved

One substantive commit since last pass (3a1af28563) plus a base merge.

The eyebrow assertion is fixed as suggested — />\s*Hub\s*<\/p>/, no utility class in the pattern. I checked it against the real built HTML rather than just reading it: the regex matches exactly once on the deployed preview, and the single match is the eyebrow paragraph, so loosening the anchor didn't buy a false positive. A restyle of the eyebrow now leaves the test alone while a copy change still trips it.

The base merge (d13a73de8f) touches workshop-visibility.spec.ts, which this PR also edits, so I checked the resolution rather than assuming: base only renamed recordFirebaseRequests to recordAccountRequests and widened its URL filter, in tests unrelated to this PR's additions. expectHubHeadingAndDirectory, the catalogue-failure test, and the JS-off directory click-through are all intact on head. The rest of that merge is main-app src/ code with no bearing here.

Preview still checks out: one h1, 148 unique directory links, eyebrow reading Hub.

One note, not an objection: website-unit and all four website-e2e shards were still queued when I looked — lint, typecheck, and website-build are green. Given the only change is a one-line test regex I verified by hand, I'm comfortable approving ahead of them, but worth a glance at the e2e result before merging rather than taking the approval as cover.

Nothing outstanding from my side.

pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 30, 2026
## Summary

**Deploy gate: comfy-router#46 is merged and live (2026-09-30). Its
follow-up comfy-router#48 (serves `/hub/models.md` instead of 301ing it
to a /workflows 404) must be deployed before this merges. After the
merge, purge Cloudflare for `/hub/models*`, `/hub/workflows*` and the 30
workflow names in `hub-workflow-names.json`. The redirects ship as 307;
FE-3083 flips them to 308 later.**

This branch combines every Workshop /models SEO PR, so merging it to
main replaces merging them one by one. It also launches: Comfy-Org#19405 commits
`launchedModelPages = 'all'`, so all 148 model pages become indexable in
the same deploy as the URL move.

Part of FE-2912, FE-2942 (PR 2 is FE-3086), FE-2974 (/minimax 308 is
FE-3087)
Fixes FE-2978, FE-2989, FE-2991, FE-2990, FE-2959, FE-2981, FE-2977,
FE-2979, FE-3014, FE-2936, FE-2980, FE-2975, FE-3085, FE-2972, FE-2935,
FE-2950, FE-2940, FE-2930, FE-2985, FE-2957, FE-2961, FE-2986, FE-2921,
FE-2922, FE-2947

## Changes

Router follow-up: comfy-router#48 (`/hub/models.md` routing, 324/324
router tests), deploy before this merges.


The included PRs, in merge order. Every head was checked as contained at
the final tip.

| PR | Ticket | What | Ben |
|---|---|---|---|
| Comfy-Org#18887 | FE-2978 | Pricing Product markup and full video `uploadDate`
| approved |
| Comfy-Org#18889 | FE-2989 | A unique meta description on every model page |
approved |
| Comfy-Org#18890 | FE-2991 | Model page JSON-LD, emitted once noindex lifts |
approved |
| Comfy-Org#18892 | FE-2990 | Cleaner tag pills, guard against duplicate
summaries | approved |
| Comfy-Org#18893 | FE-2959, 2981, 2977, 2979 | Social tags, hub title,
Organization data. The FE-2977 title was confirmed by the owner |
approved |
| Comfy-Org#19362 | FE-3014 | Every non-production build is noindex | approved |
| Comfy-Org#19366 | FE-2936 | Model titles lead with "API & Playground" |
approved |
| Comfy-Org#19402 | FE-2980 | Every internal link ends with a slash, plus a CI
check | approved |
| Comfy-Org#19419 | FE-2975 | Footer links the catalogue on every page and locale
| approved |
| Comfy-Org#19476 | FE-3085 | `NOINDEX_ROUTES` decides noindex for
serverless-animation | approved; re-approval pending on a one-line
follow-up (CodeRabbit approved) |
| Comfy-Org#19359 | FE-2974 | One typed redirect list that generates
`vercel.json` | approved |
| Comfy-Org#19369 | FE-2972 A | The old to new model URL map | approved |
| Comfy-Org#18891 | FE-2935 | Model content shows whatever the flag says |
approved |
| Comfy-Org#18899 | FE-2942 | Model pages render in the static HTML | approved |
| Comfy-Org#18898 | FE-2950 | Catalogue h1 and A to Z links in the static HTML |
approved |
| Comfy-Org#19375 | FE-2940 | Related models leave no page unlinked | approved |
| Comfy-Org#19385 | FE-2930 | Examples show the prompt that made them | approved
|
| Comfy-Org#19394 | FE-2985 | Render guard e2e: no loader, no layout shift |
approved |
| Comfy-Org#19357 | FE-2957 | robots.txt stops blocking our scripts and styles |
approved |
| Comfy-Org#19360 | FE-2961 | Turning Workshop off keeps every Models page |
approved (a CodeRabbit changes-requested review is still open) |
| Comfy-Org#19386 | FE-2986 | One registry of every Models address | approved |
| Comfy-Org#19421 | FE-2972 B1 | Model pages served at `/hub/models` | approved |
| Comfy-Org#19422 | FE-2972 B2 | Every old model URL redirects (307) | approved |
| Comfy-Org#19424 | FE-2972 B3 | Workflow pages at `/hub/workflows` with
redirects | approved |
| Comfy-Org#19399 | FE-2921 | One switch decides model robots and sitemap listing
| approved |
| Comfy-Org#19404 | FE-2922 | Clean markdown twins for model pages | approved |
| Comfy-Org#19405 | FE-2947 | Lifts noindex on every canonical model page |
approved |
| comfy-router#46 | FE-3075 | Serves `/hub/models*` from the website and
routes `/hub/workflows` by manifest. Merged and live | merged |

These fixes exist only on this branch, because they only break once two
PRs meet:

- `scripts/check-models-html.ts` reads each page at `model.href` and
skips models without a page (f1df1e4).
- `e2e/fixtures/modelsCatalogue.ts` reads `dist/hub/models`
(f87bb4c).
- `routerIdsByModelPage` accepts an optional `href`, since Comfy-Org#19421 made
it optional and Comfy-Org#19405 no longer typechecked (9783819).
- `ModelStatus` links a successor only when it has a page, for the same
reason on Comfy-Org#18899 (c4761d8).
- The model breadcrumb in `modelJsonLd.ts` points at `/hub/models/`
instead of the `/models/` redirect (eb985b6). Its label still says
"Models" while the nav says "Hub".
- Twin, meta-description and entry tests use the hub pages and the new
tag set (86ac3b0, d4ffc0f).
- The render guard finds the catalogue through `getRoutes().workshop`,
and its `test.fail` is gone now that Comfy-Org#18898 renders the h1 (831499f).
- A new test renders a real model page and checks its markdown twin has
the model's h1 (9a6c5cb).
- Main's newer catalogue and workflow e2e cases use the hub addresses
(2aeda77).
- `resetWorkshopAccountSource` resets `decision`; a clean auto-merge of
main's Comfy-Org#19454 into Comfy-Org#18891 left it assigning a variable that no longer
exists (c28c7a7).

The conflict resolutions, briefly: `ALTERNATE_TWIN_SOURCES` stays
deleted as Comfy-Org#18898 wants, so `/hub/models.md` comes from the real
catalogue. The hub keeps Comfy-Org#18898's single static h1 instead of the
`WorkshopHero` h1 that main's Comfy-Org#19320 added. `ExamplesTab` keeps Comfy-Org#19385's
figure and caption with main's video poster. The Comfy-Org#19399/Comfy-Org#19405 indexing
tests were rewritten for hub paths. The Comfy-Org#19359 redirect test no longer
builds `/enterprise//` from slash-ended routes. The Comfy-Org#19369 URL-map test
imports `PROVIDER_NAMES` from its new home. The full table of 47
resolutions is in the integration report.

## Review Focus

- Launch rides along with the URL move. If launch should stay a separate
step, set `launchedModelPages` in
`apps/website/src/config/model-page-launch.ts` to `new Set()` before
merging.
- Main's Comfy-Org#19320 gives the catalogue island its own h1 through
`WorkshopHero`. This branch keeps Comfy-Org#18898's static h1 and renders only
the subtitle in `ModelsCatalogue.vue`, so the hub has exactly one h1.

- Comfy-Org#19476 overlaps the open community PR Comfy-Org#18591 (same sitemap exclusion
for serverless-animation). One of them should be closed once this lands.

## QA

- [x] Gates: `pnpm typecheck` and website typecheck clean, `pnpm lint` 0
errors, eslint on `apps/website` clean, `pnpm knip` clean
- [x] Website unit: 547 files, 10347 passed, 4 skipped
- [x] Build A (`build:e2e`, CI env): 1193 pages; release gate,
`check:hreflang`, `validate:llms-txt-links` (225 links),
`validate:jsonld` (947 pages), `check:link-slashes`, `check:models-html`
(148 pages) all pass
- [x] Build B (`WORKSHOP_IN_BUILD=0`): same 182 Models pages as the on
build, no `dist/workshop`, `/` is noindex; with the flag stubbed on, no
Run, no Hub nav and no Firebase requests
- [x] Build C (preview shape): 945 of 945 pages noindex, no canonicals
except redirect stubs, no hreflang in the sitemap
- [x] E2E on Build A: 644 of 645 passed; the one mobile failure passed
on rerun. Earlier load flakes (navigation, demos, fdct, wan-3.0, network
isolation, render guard) all passed when rerun alone
- [x] Launch: 148 model pages indexable with canonicals, 149 hub entries
in the sitemap, 148 non-empty twins with the model h1, 148 in
`llms-full.txt`, 0 titles over 60, 30 workflow pages still noindex
- [x] Redirects: 853 rules, 782 to /hub all 307, the MiniMax rows 307,
every /hub destination built
- [x] comfy-router#46 under `wrangler dev` in front of this build: 312
router tests pass; 148 old model URLs (both slash forms) 307 then 200;
30 workflow names served by the website and their old URLs 307; a
non-manifest workflow 302 with no-store; `manifest.json` passes through;
`/workflows/` and bare `/hub` unchanged
- [x] After the router deploys and this merges: purge Cloudflare, then
curl `https://comfy.org/hub/models/` for a 200 and three old
`/models/<slug>/` URLs for one 307 each
- [x] Rich Results Test on `/pricing/` and
`/learning/animations/character-sheet/`, then "Validate fix" on Merchant
listings and Videos
- [x] Rich Results Test on two live model pages: breadcrumbs valid and
the breadcrumb URL returns 200 with no redirect
- [x] GPTBot and Googlebot curls on the hub and one model page, then a
GSC live test on both
- [x] Resubmit the sitemap in Search Console and URL-inspect about 20
model pages on day 0 and day 14
- Not covered: Rich Results and GSC need production; the redirect matrix
used a local shim for `vercel.json`, since `astro preview` ignores it

---------

Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: benjcooley <benjcooley@gmail.com>
Co-authored-by: Deep Mehta <42841935+deepme987@users.noreply.github.com>
@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

Superseded by the integration branch #19494, which combined this PR with every other Workshop SEO slice and has been merged to main. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger multi-model Cursor agent review on this PR risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants